[00:02:22] brion: chrome, opera, safari… any others? [00:07:33] mhurd: Yo, 17:30 walk to the BART station sound good to you? [00:07:49] marktraceur: ya! [00:07:54] Coolio [00:11:46] New patchset: Jdlrobson; "Cleanup Skin language and variants" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [00:23:21] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59722 [00:23:24] New patchset: Jdlrobson; "Bug 30405: Don't special case homepage HTML in alpha" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59722 [00:23:24] New patchset: Jdlrobson; "Make homepage module run outside alpha" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59723 [00:23:32] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59723 [00:57:34] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58459 [01:00:03] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59722 [05:36:24] hello all [06:09:23] New patchset: Jdlrobson; "Build content navigation menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59985 [06:10:12] jdlrobson what module of the resource loader should the fast click library be added to? [06:10:18] mobile.beta.jquery? [06:10:33] hey pragunbhutani ! you probably want to add it to mobile.alpha [06:11:18] the way we tend to do things in mobile is try them out in production on an experimental alpha version of the site , then move them to beta (mobile.beta) if we think they are useful, then big round of testing before moving to stable for everyone mobile.stable [06:11:47] New patchset: Jdlrobson; "Upstream skin changes - getLanguageUrls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [06:12:34] jdlrobson: I don't see any mobile.alpha modules right now, so should I create one? [06:12:59] it's in MobileFrontend.php - are you using latest MobileFrontend? [06:13:03] search for $wgResourceModules['mobile.alpha'] = $wgMFMobileResourceBoilerplate + array( [06:13:34] I'm pretty sure I [06:13:42] *I'm using the latest [06:13:48] let me just check that to be sure [06:14:08] pragunbhutani: latest commit is commit 293c572e3cbf847203adcf4351f918dffc169ebf [06:19:15] jdlrobson: there's the problem then [06:19:23] ? [06:19:29] I'd included the extension with installation some time back [06:19:41] ahh you'll need to upgrade.. :) [06:19:45] cloning the latest from git now :) [06:19:58] git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/MobileFrontend.git [06:20:28] yep, that's the one I'm cloning [06:21:53] my MW installation is encountering a fatal error now [06:22:30] call to undefined method OutputPage::etProperty() [06:22:42] in /mw/extensions/MobileFrontend/includes/skins/SkinMobile.php on line 202 [06:26:42] pragunbhutani: you'll need to update mediawiki as well.. [06:26:53] hmm [06:26:57] MobileFrontend works off the latest and greatest MediaWiki version! :) [06:27:06] we spend a lot of time upstreaming changes [06:27:27] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git [06:29:05] jdlrobson: I can't believe how noobishly I've set mediawiki up [06:29:12] nothing is a git repo! [06:29:16] pragunbhutani: don't worry! happens to us all :) [06:29:34] I'm going to clean up this entire thing before I make any changes :p [06:30:45] rm -rf is my friend today [06:33:49] :) [06:33:59] excited to see the results :) [06:55:24] pragunbhutani: gotta go sleep but hopefully see you tomorrow :) [07:55:50] mmm I love the smell of a fresh installation :) [13:42:17] New review: MaxSem; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59722 [14:14:50] New review: Jdlrobson; "(2 comments)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59722 [14:14:55] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59710 [14:19:03] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/59987 [14:37:32] New patchset: MaxSem; "[DON'T MERGE, EXTERNAL DEPENDENCY]Upstream skin changes - getLanguageUrls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [14:37:48] New review: Jdlrobson; "Out of interest does the redirecter not take care of these rules to ensure user gets to mobile site?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [14:38:36] New review: MaxSem; "Blocking a merge until the dependency is merged." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/59987 [14:39:33] New review: MaxSem; "Redirector means more requests on mobile connections, and even redirector will not help people brows..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [15:26:22] New patchset: Jdlrobson; "Upstream skin changes - getLanguageUrls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [15:51:55] New patchset: MaxSem; "[DON'T MERGE, EXTERNAL DEPENDENCY] Upstream skin changes - getLanguageUrls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [16:47:52] MaxSem: since awjr_away is ill can you fix up https://gerrit.wikimedia.org/r/#/c/59765/ so i can merge it? [16:47:58] (setup and teardowns) [16:48:23] on it [16:49:07] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/59987 [16:49:11] thanks MaxSem :) [16:49:21] also got a bit confused by your tweak to mobile device detect ^ [16:49:41] owchie [16:49:48] New patchset: Jdlrobson; "Promote menu button generation to MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58990 [16:50:01] New patchset: Jdlrobson; "Define render function in MinervaTemplate to output page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58991 [16:50:12] New patchset: Jdlrobson; "Kill navigationStart" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58992 [16:50:27] New patchset: Jdlrobson; "Promote all the banners into MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58993 [16:50:29] jdlrobson, so by enabling $wgMFVaryResources we actually get a more resonable order of stylesheets, right? [16:50:45] MaxSem: in what sense? [16:51:05] currently, device styles are loaded first [16:51:14] and thus can't override anyhting [16:51:36] so if we set the group to other as in https://gerrit.wikimedia.org/r/#/c/59512/ they will come last [16:51:52] otherwise they will be packaged up as RL sees fit :( [16:52:09] we should really reduce the number of requests [16:52:44] New review: Jdlrobson; "The other benefit of this patchset is that 'other' stylesheets are loaded last so will force loading..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59512 [16:52:56] MaxSem: i don't see it as such a big deal [16:53:10] the device stylesheet is a last resort [16:53:17] most of the time it is empty [16:53:34] we could remove the request altogether on devices that don't use it [16:53:38] of course! you're using it via Wi-Fi instead of GPRS;) [16:53:56] expedited request: denied [16:53:57] sigh [16:54:01] no we can't - it will require a variance in HTML [16:54:10] MaxSem: i really think this is being blown out of proportion - it's one http request - i'd worry more about our use of the api! :) [16:54:25] MaxSem: that's true yes - i guess we do always have to include it [16:54:35] jdlrobson, I will slowly chew the API usage out of you, too:) [16:55:12] jdlrobson - haha, from the mobile editor survey i put up, in answer to what kind of editing would you like to do on mobile that you can't: "Add pictures to articles that have a infobox" [16:55:20] did i send this to your sockpuppet? [16:55:22] brion, throw your MacBook, iPhone and iPad (and iPod?) out of the window:P [16:55:23] Maryana: :D [16:55:42] yeah i'll switch to microsoft surface ;) [16:56:27] * Maryana plans out iteration after next - editing, talk pages, and images in articles w/infoboxes [16:56:37] wheeee [16:57:30] Maryana, and "you have new messages" - we don't want to inflate the blocklist [16:58:16] brion: http://jonrobson.me.uk/sadbrion.jpg [16:58:16] by that point, echo should be enabled on enwiki - we can probably gank their "you have new messages" notice :D [16:58:40] jdlrobson: nice :D [17:00:14] agh standup time [17:02:20] zz_YuviPanda: poke [17:03:20] duh, no clue, will try to reboot... [17:11:51] brion: denied for expedited. bastards! [17:11:57] yuuuuup [17:12:39] brion: poke [17:12:41] back [17:12:43] hey, at least they were expedient in denying the expediation [17:13:02] YuviPanda: just checking if you were gonna be on the standup, too late now :) [17:13:12] in the meantime, what's up? [17:13:16] heh, I don't usually turn up for Standups on Friday [17:13:25] brion: head is clearer, pain's gone :) [17:13:30] brion: working on analytics stuff. [17:13:30] yay [17:13:33] awesome [17:13:45] diving into mysql indexes on the logging table right now :) [17:14:14] managed to get an order of magnitude speedup in my query by adding a namespace check to a where clause [17:14:18] stupid mysql wih stupid indexes [17:14:34] yay [17:14:38] hehe [17:15:25] jgonera: big win :) https://gerrit.wikimedia.org/r/#/c/59985/ [17:16:11] whee, that works :) [17:16:49] jdlrobson, nice [17:17:10] jdlrobson, won't this generate lots of stuff that we don't need though (isn't gonna be too costly)? [17:17:48] jgonera: on the long term we can reuse a lot of it / encourage refactoring of it [17:18:04] jgonera: for example watch list star is buried in there :) [17:18:21] and the watch list star works without javascript [17:18:26] which will be exciting.. [17:18:26] :) [17:18:34] ok, will test it today [17:18:47] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997 [17:18:57] New patchset: Jdlrobson; "Promote addToBodyAttributes to desktop skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58257 [17:20:52] New patchset: MaxSem; "Make sure globals are not overwritten in MobileContextTest" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59765 [17:20:59] jdlrobson, ^^ [17:21:48] thanks MaxSem testing now! [17:23:13] New patchset: Jdlrobson; "Make sure globals are not overwritten in MobileContextTest" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59765 [17:23:25] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59765 [17:23:37] New patchset: Jdlrobson; "Do not display desktop view on mobile domain" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59778 [17:23:48] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59778 [17:24:38] jgonera: re deploying on the dashboad. [17:24:42] jgonera: something seems to be wrong with labs [17:24:58] jgonera: I tried deploying on -dev, it errored out and -dev is now in an unusable state [17:25:05] I've asked labs and analytics folks, no response yet though [17:25:09] hm, I see, I was surprised because I remember you telling me that it should autodeploy [17:25:12] so hold off on deploying the dashboard :) [17:25:18] ok [17:25:20] hmmm [17:25:23] it should [17:25:50] jgonera: I suppose this is all due to a labs issue [17:25:54] jgonera: since manual deploy is failing too [17:27:22] ok, let's wait for analytics response [17:27:39] ok [17:28:04] jgonera: https://mingle.corp.wikimedia.org/projects/mobile/cards/449 :) [17:28:16] jgonera: actually jgonera, I think adding a new graph requires a manual deploy. [17:28:22] jgonera: the auto deploy is only for fixes to existing graphs [17:28:33] also MaxSem https://mingle.corp.wikimedia.org/projects/mobile/cards/461 - let me know if you need me to poke anyone in the office to get that done [17:29:31] jgonera: http://stat1001.wikimedia.org/limn-public-data/mobile/datafiles/performance-rendering.csv is up and running, so that part of the auto deploy clearly worked [17:29:42] YuviPanda, ok, still, I'm not going to try before it works on dev because I don't want to break it ;) [17:29:44] hm [17:29:45] :) [17:29:58] yeah, me neither [17:30:05] no response from analytics *or* labs though :( [17:30:31] jdlrobson, how should I move it and where should I move it to? [17:31:22] jgonera: i just suggest mailing mobile-l with a brief summary of anything you've discovered and maybe link the limn graph you made with some suggestions for next steps? [17:31:41] then i'll move it to ready ready for sign off :) [17:31:46] bbiab [17:32:14] jdlrobson, ok, will do that today, now I have to reboot because a system update messed up my desktop a bit, possibly the mic too, brb [17:32:22] thanks jgonera [17:35:38] Maryana: any big pushes going out tomorrow for web ? [17:35:57] err, on saturday? [17:36:05] or do you mean next week? [17:36:07] s/tomorrow/next week :D [17:36:10] hehehe [17:36:12] yup, I think we're enabling editing for everyone on stable on saturday evening :P [17:36:25] yes. on 4/20 [17:36:27] great idea! [17:36:35] +1! [17:36:50] in fact, if we actually show everyone the edit view by default [17:36:53] Maryana: so anything big going out ? [17:37:00] that'll skyrocket our active editor count! :P [17:37:40] tfinc: nothing major. a lot of bug fixes. the only big-ish thing is potentially the device-targeted banner to download the commons app. but that's just for logged in beta users [17:37:50] so a pretty small population [17:38:18] but its our first use of mobile banners [17:38:37] Maryana: --^ ? [17:38:56] yes indeed [17:40:03] Maryana: when will the banner go live ? [17:40:58] the banner code is already live on testwiki. if all goes well, it will be deployed to full mobile beta during our regular deployment window [17:41:07] tuesday afternoon [17:43:13] MaxSem: what x-device changes are going out next week ? [17:43:42] tfinc, rollout of our performance work on more wikis [17:43:53] aka all of them if everything goes well [17:44:21] MaxSem: by well do you mean analyzing the current rollout ? [17:46:01] the current rollout looks good already. I mean what if there's something that breaks badly performance-wise? with the current share of requests being served the new way, performance changes are not noticeable [17:49:08] mhurd: YuviPanda : brion : retrospective in 10min reminder [17:49:13] yup [17:49:16] hey jgonera [17:49:23] MaxSem: by well do you mean analyzing the current rollout ? [17:49:57] jdlrobson - commas are your friend :) [17:50:00] tfinc: yes [17:50:02] tfinc, replied above^^ [17:50:02] YuviPanda, yes? [17:50:20] jgonera: can you V+2 a patch for me? [17:50:22] arr you weren't here [17:50:24] Maryana: which commas? [17:50:32] tfinc, the current rollout looks good already. I mean what if there's something that breaks badly performance-wise? with the current share of requests being served the new way, performance changes are not noticeable [17:50:36] ahh i see [17:50:42] jgonera: https://gerrit.wikimedia.org/r/60027 [17:51:29] Maryana: nice survey! [17:52:07] YuviPanda, has some whitespace issues but I won't be too picky ;) you tested it? [17:52:25] jgonera: I tested the data generation parts, but have no way to test the limn part :) [17:52:36] hence the request for V+2, since you're the only person I know who has a working Limn install :P [17:53:00] ok, let me check [17:53:34] tfinc: homepage special casing is disappearing from alpha which should make the likes of aharoni excited ;-) [17:53:44] jdlrobson, see my email :) [17:53:47] ok [17:53:50] and cause lots of unknown breakage of course :-) [17:54:16] Maryana: more wikis = all wikis ? [17:54:17] err [17:54:19] MaxSem: --^ [17:55:48] tfinc, yes - the plan is to deploy it everywhere [17:55:53] Maryana: Also, in order to use "special" pages like watchlists you have to disable Java. Very annoying - and it took ages for me to figure out what the problem was." o_O [17:56:01] java?! [17:56:04] yeah..... [17:56:07] i don't even know [17:56:09] ... [17:56:18] on a tablet, even [17:56:28] Maryana: \o/ "There should be a "Add topic" option for talk pages." [17:56:30] almost there.. :) [17:56:34] yep :D [17:56:50] we might need to revive our mobile nav discussion [17:56:55] we're running out of space to stick stuff [17:56:55] also haha "I like Wikipedia very much, and I use it several times a day. Thank you very much!" [17:57:07] yeah, i bet all the nice things came from new users [17:57:12] Maryana: well the add topic is orthogonal to mobile nav but we do need that discussion [17:57:15] and all the mean/snarky things came from exisiting users [17:57:27] yeah - i'm thinking user talk [17:57:27] Maryana: i've got a proof of concept that adds topics to talk pages via the overlay [17:57:28] "you guys are all right bastards" [17:57:31] you don't even have to leave the article [17:57:42] lolz "I like Wikipedia very much, and I use it several times a day. Thank you very much!" [17:57:47] wrong lolz.. [17:57:49] lolz ""I wasn't really impressed with the mobile editor." [17:57:54] heh [17:57:58] YuviPanda, I think you left some print somewhere because generate.py is outputting a lot of stuff in the terminal [17:58:00] it's amazing it works at all! be pleased ;) [17:58:09] jgonera: argh, yes. let me fix that [17:58:15] worst. mobile. editor. ever. [17:58:23] is i think what that guy was going for [17:58:25] "It is still very buggy, please get the quality assurance people on it. Also adding fair use images needs to be easier." [17:58:31] ^ jcmish think that means you ;-) [17:58:38] see what i mean about overrepresented wikipedians [17:58:45] oh fair use [17:58:51] jgonera: other than that? [17:58:59] still checking [17:59:02] okay ;) [17:59:23] so brion why can't I do Title::newFromText( $title )->getHeadings()['h2's] ? :( [17:59:43] we have to use jinja for JSON config files too I guess, because I have to change the url in datasources all the time manually [17:59:44] this would make talk pages soooooo aamaszmzmazzzzinggballs [17:59:48] jdlrobson: well if Title::newFromText returns null it will break [17:59:54] oh getHeadings() ? hah [17:59:56] yeah that'd be nice eh [18:00:02] getHeadings is what i want yes [18:00:20] brion: is that anything you'd be interested in experimenting with in your experimental time? i fear i don't know enough to do this :( [18:00:25] but i soooooo want it [18:00:39] i might take a peek later :D [18:01:08] YuviPanda, the graph shows values only for ios, for android it's always 0 and for web the graph is missing [18:01:33] hmm [18:01:34] loking [18:07:22] New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59559 [18:09:58] mhurd: http://mobile-reportcard.wmflabs.org/ [18:12:03] YuviPanda still working on the commons android icons, but here's the wikipedia set for what it's worth https://www.dropbox.com/sh/hivuelx5eq5mqco/awtWO4eStx [18:14:03] jdlrobson, anything specific you want me to review? [18:14:38] MaxSem: all the skin stuff would be great starting with https://gerrit.wikimedia.org/r/#/c/58990/3 [18:14:55] i really want to see all that get merged so anything you need fixing up just let me know and i'll do it right away [18:15:54] YuviPanda, have you checked it? [18:17:56] jdlrobson: i pushed a new patchset for the spam [18:17:56] err [18:17:56] jg [18:17:56] gah [18:17:56] he left [18:18:00] sorry jdlrobson [18:18:07] you better be sorry YuviPanda :) [18:19:03] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58990 [18:24:37] jgonera: submitted a patchset :) [18:24:42] two actually [18:25:05] New patchset: Jdlrobson; "Alpha: Talk page - allow access to lead section conversation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59559 [18:25:05] New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [18:25:26] great... I just rebooted to OS X to check the mic, it doesn't work there either, so I guess the Apple service broke it/forgot to connect it :/ [18:25:48] YuviPanda, will check in a sec [18:26:00] :D [18:26:08] ow, at mic [18:26:19] New patchset: Jdlrobson; "Promote menu button generation to MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58990 [18:26:28] ^ MaxSem [18:26:34] New review: Jdlrobson; "Done." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58990 [18:26:42] New patchset: Jdlrobson; "Define render function in MinervaTemplate to output page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58991 [18:30:57] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58990 [18:31:47] jgonera: you're right, it's not reporting deletions for iOS at all [18:31:49] * YuviPanda looks into it [18:32:02] for ios? or for android? [18:33:19] jgonera: for iOS. There was an off-by-one error in the graph definition that shifted things [18:33:23] jgonera: Web graph should be visible now [18:33:29] in latest patchset, that is [18:33:56] ok, running generate [18:34:49] we should add *.pyc to .gitignore [18:35:02] yeah [18:35:32] jgonera: they're on my global gitignore :) [18:35:50] at least python saves its byte code :P [18:36:08] yeah, snakes are careful with bites ;P [18:36:17] haha [18:36:42] ok, seems to work [18:36:44] ok i'm gonna get a sandwich and stuff and get back to categories [18:36:47] bbiab [18:37:15] I mean, I didn't verify the data but loads of deleted uploads for web seems to be right considering the village pump discussion [18:38:35] YuviPanda, merged, anything else? [18:38:40] jgonera: no, thanks :) [18:38:51] jgonera: i'm setting up with Dan about the dashboard [18:38:53] will take care of it [18:38:55] before I shut down the whole ssh tunnel and limn ;) [18:38:56] ok [18:42:45] jgonera: thanks a lot :) [18:42:51] jgonera: also, can you pass me over the commands for the ssh tunnel? :) [18:43:16] * munaf sighs. [18:43:18] YuviPanda, ssh -L 3307:s1-analytics-slave.eqiad.wmnet:3306 -L 3308:s4-analytics-slave.eqiad.wmnet:3306 stat1.wikimedia.org [18:43:24] i really want a new commons logo. [18:44:21] jgonera: http://mobile-reportcard-dev.wmflabs.org/ :) [18:44:33] munaf: the current one is all wrong proportions? :D [18:44:45] jgonera: the new graphs are tehre [18:45:06] and, well... i feel like it's just not the clearest brand [18:45:51] YuviPanda, great, thanks! [18:47:31] YuviPanda, I don't understand gerrit, I just wanted to modify .gitignore, branched off master and modified it, and git review wants to submit 5 commits that are already in master... [18:47:43] jgonera: do git fetch gerrit [18:47:46] jgonera: 'known bug' [18:48:01] wow, thanks [18:48:13] YuviPanda, https://gerrit.wikimedia.org/r/60032 [18:48:21] :D [18:49:10] jgonera: merged :) [18:49:17] thanks [18:49:20] jgonera: that's a bug in the newest version of git review [18:49:32] jgonera: so everytime it does that, do a 'git fetch gerrit' and do a git review again [18:49:34] will go away [18:50:06] thanks, I'll think two times before updating git review next time [18:50:12] heh :D [18:50:52] still no call from the airlines/airport... I'd call them but yesterday I had to hold for 1.5h to actually talk to someone... [18:56:07] munaf: the wiki icons look nice :D [18:56:21] munaf: did you notice the desktop wikipedia favicon change? [18:56:21] i did [18:56:25] and thanks! [18:57:07] yeah it's an improvement. might need to pop a bit more with a border or something because pure white sort of fades into most browser default themes [18:57:17] jdlrobson, what's the difference between prepareData() and prepareCommonData()? [18:57:51] New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [18:57:56] MaxSem: prepareData can be overriden [18:58:09] is that bad?:) [18:58:19] prepareCommonData shouldn't have to (and in future shouldn't exist when SkinTemplate gets some more polyfill) [18:58:20] YuviPanda commons ios icons done :-) android coming next [18:58:24] hang on grabbing the link. [18:58:27] yay [18:58:32] argh, they just called and said that they will bring my bag before 3pm... yesterday they said it would be in the morning. I thought 3pm could be considered as morning only in Spain and even there it's far-fetched. [18:58:36] just meeting with jorm so brb [18:59:07] jdlrobson, I still don't see a need [18:59:28] MaxSem: it becomes clearer in the later commits [18:59:33] brb [19:06:16] YuviPanda here's ios for reference :-) https://www.dropbox.com/sh/f88mogxgych5g1k/Ga9D0bIKc_ brb. [19:06:38] munaf: wah neato! [19:06:45] whee [19:06:50] snazzy [19:06:56] very! [19:08:47] munaf: got flattened versions for us without photoshop? :) [19:09:51] yes brion [19:09:55] app icon squared / rounded [19:09:56] \o/ [19:10:00] those 2 folders have 'em all [19:10:03] awesome [19:10:51] jdlrobson: new dual usb charger is on our desk [19:10:54] your* [19:10:56] YuviPanda android will be ready some time after lunch :) [19:11:00] wheee! [19:11:01] munaf: the 'small' icons in the squared dir appear to be rounded :) otherwise they look awesome [19:11:09] odd [19:11:14] i shall look into this [19:12:06] tfinc: oh did we get the hdmi adaptor for the nexus4 in? i'll want to update the android video on monday or tuesday, if it's not going to be here I can just reflash my galaxy nexus, i have the adaptor for it [19:12:15] brion: YuviPanda : i just passed on a copy of TeamGeek to mhurd. lets see what kind of hand balancing he can do after [19:12:20] munaf: thanks [19:12:21] :) [19:12:22] brion: amazon was out of them when i checked yesterday [19:12:23] :) [19:12:25] heh [19:12:25] let me check today [19:12:32] tfinc: :) [19:12:36] tfinc: brion mhurd Maryana new graphs at http://mobile-reportcard.wmflabs.org/ :) [19:12:47] still need to add two more [19:12:47] i have the kindle edition, not sure if i can lend that or not these days :) [19:12:50] but there is now a 'deletions per day' [19:12:53] of mobile uploads [19:12:59] brion: ZOMG $72.89 + $13.75shipping [19:13:02] it's missing iOS, but works otherwise [19:13:15] tfinc: waaaaaaaaat that's crazy talk [19:13:23] awesome, yuvipanda [19:13:28] awesome and sad for that one day [19:13:36] brion: http://www.amazon.com/SlimPort%C2%AE-SP1002-Connect-connector--Supports/dp/B009UZBLSG [19:13:40] 300 files deleted :( [19:13:50] that's a lot of test images [19:13:50] glad to see we're past that [19:13:52] 300 files were deleted on 3 consecutive days :( [19:14:12]