[00:00:05] jgonera: is the dashboard public? [00:00:29] jdlrobson, it is, you can't access it? [00:00:43] jgonera: i was wondering if i should forward to mobile-l in case anyone is interested [00:01:38] jdlrobson, hm, not sure, after all it's about our own private infrastructure, or maybe not [00:02:00] ori-l: what do you think? [00:02:11] i guess if it's on the web and unprotected it should be ok to put on a public mailing list? [00:02:26] you can find it via google :) [00:02:31] https://www.google.com/search?q=mobile+report+card+wikimedia&rlz=1C5CHFA_enUS503US504&aq=f&oq=mobile+report+card+wikimedia&aqs=chrome.0.57j62l3.2706j0&sourceid=chrome&ie=UTF-8 [00:02:42] well the non-mobile one.. [00:02:51] i'll mail the list [00:02:57] hmm, what's going on? [00:03:02] mhurd: i'm starting to wind down. leaving at 5:30 [00:03:22] * jdlrobson needs beer that's what's going on! [00:03:28] jdlrobson: https://mingle.corp.wikimedia.org/projects/mobile/cards/579 [00:03:34] yeah, i hear you [00:04:35] Maryana: we should think about how we want to handle this.. [00:04:37] beta only for instance? [00:04:45] yes, we should start in beta [00:05:00] i know there will be an awkward period of code fragmentation, but thems the breaks [00:05:13] also jgonera - another thought i had with the skin refactoring is you could have a SkinMobileBeta ... [00:05:19] we'll also have to have a related card that moves the watchlist star [00:05:30] rather than resorting to horrible if statements all over the place [00:05:39] skins on the mind [00:05:46] heh [00:05:51] i know what that means in british! [00:05:54] i watched that show [00:07:20] jdlrobson, that might be a good idea, I always felt that we should have a clearer code separation between mobile modes [00:07:46] also, I hope the -1s on the minerva commits don't discourage you, I really appreciate the effort ;) [00:08:00] tfinc: sounds good [00:08:20] Maryana, where will we move the watchlist star? [00:08:49] we have a couple options [00:09:01] either to the right (or left, depending on the language) of the article title [00:09:05] or below it [00:09:53] though we have to consider where to put edit, too [00:10:11] and, of course, the upload CTA :) [00:10:19] jgonera: no i appreciate the review [00:10:27] a speedy -1 is the same as a +1 to me [00:10:51] Maryana: you've got me thinking about effy now [00:10:58] heheheheh [00:11:03] i had a big crush on sid [00:11:10] of course [00:11:44] http://en.wikipedia.org/wiki/Effy_Stonem ahhh effy [00:12:19] haha [00:12:23] i love the fictional character articles [00:12:27] stay classy, wikipedia [00:12:39] omg, this is ridiculously detailed [00:13:31] jdlrobson, were you thinking of incorporating the "cover image" concept into MFE, or just your skin for now? [00:13:50] wtf gerrit [00:13:52] https://gerrit.wikimedia.org/r/#/c/59987/ < jgonera [00:13:58] jenkins tried to +2 it? [00:14:12] BAD JENKINS [00:14:22] haha [00:14:25] Maryana: we can do both but i'd suggest just desktop Minerva skin [00:14:34] keep page load down on mobile [00:14:38] eventually tablets though [00:14:39] good point [00:14:43] yeah :) [00:16:30] jdlrobson, is the change in includes/modules/MobileDeviceDetectModule.php related? [00:16:39] jgonera: no max sneaked that in for unknown reasons [00:16:47] just fixing that now [00:17:28] I think it was not intentional ;) [00:21:24] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58996 [00:23:10] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58996 [00:25:44] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58994 [00:27:20] brion: i still have a bit of clean-up on the default browser setting code - didn't have much time for it today but will prob get it wrapped & submit a pull req either tonight or tomorrow [00:28:01] mhurd awesome [00:29:49] jdlrobson, speaking of beer, there's no happy hour today I guess? [00:30:08] New patchset: Jdlrobson; "Upstream skin changes - getLanguageUrls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [00:30:10] no :( [00:31:04] New review: Jdlrobson; "Core change was merged !" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [00:31:32] New patchset: Jdlrobson; "Upstream skin changes - getLanguageUrls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [00:32:03] talking of beer [00:32:06] time to call it a day [00:32:12] agreed [00:32:15] consensus achieved [00:48:00] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/59987 [01:01:04] New review: JGonera; "(6 comments)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58997 [01:06:03] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58257 [02:55:40] Jon wants getHeaders()-> from a title? [02:55:46] Isn't that in an API module? [03:09:23] [02:55:40] Jon wants getHeaders()-> from a title? [03:09:23] [02:55:46] Isn't that in an API module? [03:09:25] jdlrobson: ^ [03:37:50] New patchset: Jdlrobson; "Talk: Write the number of talk topics in the talk bubble" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [03:43:00] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58994 [14:27:29] New review: Yurik; "looks good, but i don't have a good way to test it." [mediawiki/extensions/ZeroRatedMobileAccess] (migrate-mfe-to-zrma) C: 2; - https://gerrit.wikimedia.org/r/59757 [18:16:47] I'm trying to incorporate fast click.js into MF to make it a little snappier [18:17:22] for that, it needs to be instantiated on body load [18:17:49] I wonder if application-alpha.js is the right place to instantiate it?