[00:03:39] ok, i've disabled mobile sitenotice everywhere but testwiki [00:04:39] MaxSem, mwalker ^ [00:04:47] sehr gut [00:07:01] mwalker: do you have enough info about the prob to open a bug? [00:07:42] from what i can gather there were two problems - one device detection seems to not be working right, and siteNotice div is surrounding all the page content [00:10:51] brion: is it cool to include a stack overflow link in the comments now and again? [00:11:32] mhurd absolutely [00:11:42] brion: awesome! [00:11:42] awjr: ya; I can do that [00:11:43] references are great [00:11:54] thanks mwalker, much appreciated [00:12:06] brion: i've got the opt-out working i believe [00:12:16] jgonera: i'll take a look at that patchset shortly [00:12:21] used to have to link php bug reports all the time in workarounds :) [00:12:40] ok [00:12:44] great... pull request it and I'll look oy over [00:13:13] *it [00:13:33] brion: will do [00:19:33] [Commons-iOS] montehurd opened pull request #49: Opt out for logging (master...optOutForLogging) http://git.io/-or1bA [00:19:34] marktraceur: are you doing MC or Glen Park ? [00:29:16] brion: heading out to climb - anything look out of true thus far? [00:29:44] so far so good [00:30:12] I'll leave some comments on the request, enjoy your climb! [00:30:51] brion: sounds good! have a good night! [00:30:54] mhurd: just getting off of a call [00:31:19] tfinc: no rush! [00:43:53] jgonera: make nodecheck gives me: https://gist.github.com/awjrichards/4209c0f05f6e74649a30 [00:44:20] argh, mac users, what's wrong with your nodes? ;) [00:44:25] tehe [00:44:32] I can't see a reason why this would happen [00:44:34] jshinttests too [00:44:43] have you installed Node.js in a typical way for OS X? [00:44:51] they all fail that way, actually [00:44:52] yeah, gonna be the same for all of them [00:44:59] jeez i dont know, i dont remember [00:45:00] npm install doesn't work for you [00:45:03] no idea why [00:45:03] probably not [00:45:13] what's your Node.js version? [00:45:20] how can i tell jgonera? [00:45:31] nodejs -v [00:45:34] Arthurs-MacBook-Pro:MobileFrontend awjrichards$ node -v [00:45:34] v0.8.7 [00:45:39] hm [00:45:47] Arthurs-MacBook-Pro:MobileFrontend awjrichards$ node -v [00:45:47] v0.8.7 [00:45:47] Arthurs-MacBook-Pro:MobileFrontend awjrichards$ nodejs -v [00:45:47] -bash: nodejs: command not found [00:45:53] well, I'll have a look at it tomorrow [00:46:01] must be that nodejs is Linux/Ubuntu specific [00:46:04] some aliast or sth [00:46:16] that is annoying [00:47:05] ok, I'm done for today, see you tomorrow [00:47:12] see ya, jgonera have a good one [05:09:40] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60601 [05:11:47] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60592 [05:21:17] New patchset: Jdlrobson; "Add watchlist star to nearby view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58825 [05:21:30] New patchset: Jdlrobson; "Alpha: Add watchlist star to nearby view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58825 [07:30:30] Mobile wikipedia: "read in other languages" links disappeared? [07:30:32] Is it intentional? --fireattack (talk) 07:02, 24 April 2013 (UTC) [07:30:51] I can confirm, not seeing them in plain and beta mode. only in dragons mode. [09:03:03] New patchset: Zfilipin; "Updated ffi gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60641 [09:10:22] New review: MaxSem; ":facepalm:" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60609 [09:10:47] MaxSem: hey :) [09:11:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60609 [09:11:08] MaxSem: I have upgraded Zuul a minute ago. Your change 60609,1 is the first to use the new version :) [09:11:15] and it works \O/ [09:11:21] wheee [13:54:55] New patchset: Jdlrobson; "Upstream skin changes - getLanguageUrls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [14:01:54] irc's not letting me log in regularly ("nick temporarily unavailable") [14:01:56] so i'm on the webchat [14:02:00] it's... frightening [14:02:03] needs some UI lovin [14:03:07] YuviPanda: how goes it? [14:06:58] hey brion__ [14:07:40] brion__: is the iOS app in the store yet? legoktm was asking... [14:08:19] it should be now [14:08:22] :D [14:08:27] nice [14:08:35] https://itunes.apple.com/us/app/wikimedia-commons/id630901780 :D [14:09:37] now that that versions in the store i better hope my database version migration works in the real world ;) [14:09:48] heh :P [14:09:53] testing in production, etc :P [14:11:31] i need something to take a picture of! [14:12:21] is there no setting like "only download on wifi"? [14:12:40] legoktm: https://commons.wikimedia.org/wiki/File:US_power_socket_faces.jpeg [14:12:49] i uploaded that while testing in the office [14:12:56] Brion then annotated it :D [14:13:17] LOL [14:15:18] short webchat timeout is short [14:15:45] legoktm: you said something about a wifi-related option before i got disconnected? [14:15:55] [09:12:21 AM] is there no setting like "only download on wifi"? [14:16:18] basically i dont really care about looking at what i already uploaded, especially when im on 4G with a limited data plan [14:17:01] :) [14:18:07] YuviPanda: can the sync provider do stuff like disable itself on slow networks? or is it low-bandwidth enough that it shouldn't be a big deal [14:18:20] i don't think it actually pulls the images until you view them right? [14:18:27] brion___: yup, it's easily doable [14:18:31] brion___: and yup, doesn't pull images [14:18:34] brion___: only pulls metadata [14:18:37] so light enouh [14:18:42] and the ones it does pull get cached to storage right? [14:18:53] yup [14:19:03] it pulls them *as* you scroll [14:19:04] so :D [14:19:06] whee [14:19:10] i don't think we need to do more there [14:19:31] man, i'm having so much fun with grid views and their relatives, i miss that in html [14:19:44] we need a good listview control for the web site [14:20:05] as someone who was doing desktop apps for a long time before going web, the web is stuck in the 80s in terms of layout [14:20:31] consitent grid basaed css frameworks are a huge improvement, but that's only because the web 'base' is so bad... [14:20:39] heh [14:20:41] I mean, they still don't have a reliable flexbo [14:20:42] x [14:20:44] * YuviPanda shakes fist [14:20:57] it's painful to be restricted because of the underlying platform's code [14:21:03] yeah, consistent flexbox model would be nice. i dare not use it now because i don't understand how it'll behave on different browsers [14:21:16] yeah, and they sortof changed the standard itself a few months back [14:21:29] heh [14:21:38] reminds me i should check and make sure srcset hasn't changed [14:21:44] haha [14:22:38] marktraceur: i swear that once my mandated jail time is over (exams) I'll actually spend some time learning parsing ad related concepts [14:23:29] s/exams/college/ [14:23:32] i read "mandated jail time" and was like wat. [14:23:35] fuuuuuuuuuuuuu [14:23:53] did they take srcset back out? or partially? it's still mentioned in http://www.w3.org/html/wg/drafts/html/master/embedded-content-0.html#the-img-element but not listed in the attributes. sigh. [14:24:09] good morning [14:24:14] i'm back to the states! [14:24:31] ooooh [14:24:37] hope i didn't miss much :) [14:24:38] they split it out to an extension standard? wtf http://www.w3.org/html/wg/drafts/srcset/w3c-srcset/ [14:24:42] hi yurik :D [14:24:57] hi brion___ [14:26:13] brion___: I think what happened to Java with the establishment of the committees is happening to HTML now [14:26:32] okay, I should really calm down now. [14:26:55] YuviPanda: no, that was XHTML -- committee hell that never went anywhere [14:26:58] legoktm: i've the superpower of whining constantly about how horrible college is. [14:27:19] i'm actually much happier with html5 these days, the browser vendors at least are moving on things and driving most of it [14:27:28] I hate classes, but loooove the internet. [14:27:44] i don't think 'hate' does it justice, however. [14:27:50] "Wikimedia: we try not to make you drop out of college, but you might." [14:27:58] STAY IN SCHOOL KIDS [14:28:09] it's like, do you 'hate' poverty? Disease? War? [14:28:25] I think 'drives you into dispair' is a more accurate description [14:28:40] hey, for various definition of 'school' :) [14:28:57] If could get a guaranteed job I'd be out of here in a flash. The problem is I can't until I graduate from college :x [14:30:15] I *think* I've a job :P [14:35:31] wtf how do i add a limit to my content provider query? [14:35:42] or do i just stop reading the cursor when i get to where i want to stop? :P [14:36:33] I think so [14:36:35] (the latter I mean) [14:36:43] hey jdlrobson - are you on a plane? [14:37:11] MaxSem: just having a coffee before i grab my taxi [14:37:21] not sure if this plane will have wifi.. it hasn't told me it will :) [14:37:22] oh [14:37:33] MaxSem: looks like i broke languages :-S [14:37:35] YuviPanda: sounds icky... but i'll do that for now i guess [14:37:38] sooo... we've got a lang links screwup [14:37:43] yup [14:37:48] see my mail? [14:37:48] well, don't think of contentproviders as SQL Databases! [14:37:55] yes, we both knew what to talk about:) [14:38:03] we're using those in the underlying fashion but that's not the interface they expose. so no limits :P [14:38:17] jdlrobson, I guess an emergency deployment would be appropriate [14:38:34] brion___: the interface to a contentprovider is an URI, so you can implemnet limits by parsing the URI if you want [14:38:42] brion___: there's even a class that lets you do URI matching [14:38:46] brion___: but we don't really need that [14:38:48] * jdlrobson guesses so too especially with the central notice unclosed div [14:39:10] YuviPanda: mmmm, yes. i could pass a special uri to ask for 'gimme the last 8 items' or something [14:39:16] MaxSem: does anything about https://gerrit.wikimedia.org/r/#/c/59987/ look wrong to you? [14:39:17] but eek, don't! [14:39:19] and then stick the limit in the sql :P [14:39:22] jdlrobson, CN has other problems so I'd rather restrict ourselves to one fix [14:39:24] brion___: the SQL is a cursor [14:39:29] so it shouldn't really affect things, n o? [14:39:32] *no [14:39:45] YuviPanda: well, i don't know if it buffers the query or whatever... [14:40:02] MaxSem: the unclosed div could be quite problematic though on certain older browsers [14:40:11] brion___: let's stick to it for now and we'll profile later :) [14:40:15] in php that'd be a big piece of crap by default because it would pull everything into a buffer, then you iterate through the buffer [14:40:15] most modern ones can deal with that but not so sure about all those older phones out there..! [14:40:15] ok [14:40:20] do we display it even if notices are disabled? [14:40:24] yup [14:40:27] woops gotta find my usb cable [14:40:29] oh [14:40:33] argggghhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh [14:40:33] no we don't sorry [14:40:40] phew:) [14:40:40] yeh so we can just turn that off [14:40:46] which will make life easier [14:40:49] is it turned off? [14:41:04] it was as far as i remember [14:41:12] * jdlrobson checks [14:41:23] yep it's off [14:41:23] sweet [14:41:23] brion___: oh, no it's not going to fetch everything into Memory :) [14:41:41] brion___: if it did ragesoss opening the app should've crashed his phone consistently ;P [14:41:44] if there were jcmish around, I would've attempted a push right now [14:41:47] so yeh MaxSem if we can get https://gerrit.wikimedia.org/r/#/c/59987/9 merged in some form job done [14:41:55] MaxSem: she's on email so i could poke her [14:42:04] please do:) [14:42:13] MaxSem: done [14:42:36] MaxSem: although that fix requires a core change as well. [14:42:48] i can quickly try knocking something up for the short term if you prefer [14:43:00] not the first time we've had to backport:) [14:43:20] MaxSem: so the core change isn't a problem? [14:43:22] but yeah, just plugging that overwrite would be even cooler! [14:43:32] YuviPanda: excellent... that's what testers are for :D [14:43:45] less stuff to deploy, less chances of a fail [14:43:53] :) [14:44:09] ok i'll have a quick look [14:44:29] hey YuviPanda, what happens if we install on a device with no camera? does the 'take photo' button disappear or disable itself? [14:44:35] i'll have to try it on my old kindle fire sometime [14:44:51] nah, it'll probably just crash :P [14:44:56] heh [14:45:17] brion___: it uses an intent, so it'll send out a 'can someone take a picture for me please?' intent request [14:45:21] will probably match nothing and die [14:45:39] k i'll make a note to test it, fire's back at the office and i'm at home today [14:45:45] :D [14:48:29] New patchset: Jdlrobson; "Bug 47597: Languages: Don't set to empty list" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60664 [14:48:30] so MaxSem this should fix it in short term ^ [14:49:01] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60664 [14:49:12] awesome [14:50:36] so i need to grab a taxi in next 20 minutes [14:50:41] i've poked jcmish but no sign of her yet [14:50:59] MaxSem: any reason you want to wait for her? should just be a case of applying it and checking languages appear :) [14:51:34] yeah, with this minimum fix I'm confident enough. already conococting a cherrypick [14:52:02] brion___: oh, also - do patrol the mobile-feedback-l too :) it has incoming commons feedback from inside the app [14:52:04] sweet [14:52:06] (wheni 'm gone that is ) [14:52:11] i just replied to a few from tehre now [14:52:11] New patchset: MaxSem; "Bug 47597: Languages: Don't set to empty list" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/60665 [14:53:01] YuviPanda: No worries - I'll be happy to lend you a hand with diving into Parsoid if you'd like :) [14:53:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/60665 [14:53:17] marktraceur: :) thank you [14:53:34] hmm i'm not sure that sort order is going through [14:54:03] but i see it being passed through... [14:54:06] oh fuck i see [14:54:10] i'm not updating the last-used timestamp [14:56:13] brion___: :D [14:56:50] yesssss something worked \o/ [14:59:11] jdlrobson: MaxSem here [14:59:27] jcmish, I'm deploying a fix in a minute [14:59:34] MaxSem: k [15:01:49] YuviPanda: how many recent items should i pull? 8? 10? 20? [15:01:57] 20 seems good [15:02:02] but we really should put search there brion___ [15:02:07] hmm [15:02:07] also [15:02:15] YuviPanda: well how'd search work on that exactly? [15:02:23] start typing [15:02:30] one asynctask looks into contentprovider [15:02:32] populates that [15:02:34] those items already turn up from the live search...? [15:02:36] ahhhhh [15:02:37] another asynctask gets web [15:02:41] appends to it [15:02:51] so if you've already used the cat [15:02:52] Wikidata and Mobile Frontend seem to be friendly to each other! [15:02:53] it'll be much faster [15:03:13] brion___: it shouldn't be too hard, since it's only prefix search. [15:03:20] so once the web lookup is done it should look the same as it does now [15:03:23] just a bit of synchronization needed to avoid duplicates but that's easily solveable [15:03:33] just you'll get faster results from the local lookup [15:03:36] yup [15:03:38] and it'll work offline :) [15:03:39] and we can keep the local results on top [15:03:43] That too! [15:03:43] ok i can do that i think [15:03:46] whee [15:05:18] our app is the 2nd result when I search for "Wikimedia Commons" in the app store. :/ [15:05:34] ragesoss: the first is a broken app built as a result of a contest from the WMF 2 years back [15:05:49] jcmish, deployed to 1.22wmf2 eg enwiki [15:06:01] k thanks [15:06:30] I see it back on testwiki [15:07:37] ragesoss: fired off an email to mobile-tech about that [15:07:46] iOS app is totally unresponsive after login. I guess it's pulling in my uploads? [15:07:49] pragunbhutani: ooo, works fine? [15:07:54] brion___: ^ [15:08:06] hmm [15:08:23] ragesoss: does it continue after a few seconds? [15:08:25] responsive now. [15:08:25] or is it just stuck [15:08:27] YuviPanda: Breaks in a few places, but definitely looks promising! [15:08:28] yay [15:08:31] it lasted about 20 or 30 seconds [15:08:35] not bad [15:08:37] i'll have to work on that... might be inserting things sslloowwllyy [15:08:39] then it went back to the login screen. [15:08:44] brion___: he has a few thousand of those :P [15:08:48] (contributions0 [15:08:49] ) [15:08:56] YuviPanda: I'm going to take a few screenshots to share on my wikitech-i thread and then set up a localtunnel [15:09:02] for others to see [15:09:04] ah nice :) [15:09:09] then when I pressed login again (it still had my password), it was responsive and showed some uploads [15:09:17] the web api lookup is async but i think the inserts to the db are on the main thread. :P [15:09:35] good work MaxSem [15:09:36] MaxSem: jdlrobson see it back in beta, alpha and regular en [15:09:41] seeing the results :) [15:09:42] the uploads it shows are not recent, though, brion. [15:09:53] ragesoss: can you drop a quick bug into bugzilla that first-load performance is awful with a large number of items? [15:10:04] might be that it's freaking out with such a huge number and didn't store them all [15:10:31] brion___: it starts with the oldest uploads. this is the opposite of Android. [15:10:36] brion___: android happily throws exceptions a lot of times when you try to do blocking things on the main thread ;) [15:11:07] i'll have to google around, see if i can find hints on using CoreData with background threads [15:11:09] brion___: bugzilla, will do [15:11:19] sweet i'm gonna grab a plane [15:11:24] lots of exciting things to build on my flight :) [15:11:32] ha [15:11:36] see jdlrobson [15:11:39] ragesoss: the display should show you your most recent items at top... but it's possible it's doing the initial query backwards, i'll have to double-check [15:12:03] i might be overcomplicating a certain story that's 5 points into an 8 in the process.. ;-) [15:12:10] brion___: right now it shows my oldest 500. [15:12:22] ragesoss: oh have you registered for the ios beta? i'll probably want to send you more builds before we get them into the store :) [15:12:25] it says it's refreshing, but it's been working for several minutes. [15:12:39] brion___: I tried, but it never worked. [15:12:40] ok you are definitely my new stress-test case. ;) [15:12:45] i'll have to make a bot and just upload a bunch of crap [15:13:20] about 5 minutes now, still refreshing with nothing showing but the initial 500. [15:14:10] hah, that pull to refresh stretch animation is hilarious! [15:14:24] brion___: so for the Android app I tested this by simply setting the API limit to 5 :P [15:14:40] so to even get my ~300 uploads to testwiki, it had to make 20 reqs [15:14:48] ragesoss: that's a standard ios control now :D it's delightful though [15:15:53] YuviPanda: 300/5 = 60 [15:15:55] thedj[work]: language fix deployed. [15:16:08] hmmm [15:16:12] I don't know how I arrived at 20 [15:16:20] ragesoss: lemme see if we can get you registered for the beta so i can send you a more recent build once we've fixed the data import [15:16:57] ragesoss: try going to http://testflightapp.com/join/b1a2a80c3a53dc30691503e6cc0a98c7-MTYyNTU3/ it should offer a signup. then log into testflightapp.com on the ios device and hit the 'connect' button [15:17:09] it should, in theory, send me your device id so i can make the next build work for you [15:17:22] if I [15:17:33] if I've done that before, should it be good to go? [15:18:09] ragesoss: what name are you registered under? lemme check if it's got you in there [15:18:19] Sage Ross [15:18:28] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60641 [15:18:29] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60641 [15:19:22] ragesoss: oddly enough i don't see you, let's walk through the steps in case something didn't register properly [15:20:10] I hate how gmail doesn't always let you see which of your email addresses you *received* a message with. [15:20:33] like, if it's a mailing list or other situation where the recipient is not in the header [15:21:05] * brion___ shakes fist at the google gods [15:21:16] brion___: just did the signup [15:21:29] I've already got testflight on my phone, logged in to that account. [15:21:34] anything else? [15:22:22] ragesoss: does it offer to 'connect'? [15:23:11] brion___: no. [15:23:19] hrm [15:23:51] i hate testflight's developer dashboard ui, it's hard to find anything :P [15:24:12] brion___: yeah, let's go back to sending ipas by hand :P [15:24:14] I think I'm connected already. [15:24:30] heh [15:24:42] ragesoss: ok then we should just need to get you on the team for the app testing, lemme find the right link [15:24:51] the app says my name and phone model, just with no apps. [15:25:46] ragesoss: try http://testflightapp.com/install/463e6449eeb271cc741acbfc39afbc25-NDYwNDk2NQ/ see if that prompts you to join or just says 'no can't install' [15:26:33] if that doesn't do it... try http://testflightapp.com/join/b1a2a80c3a53dc30691503e6cc0a98c7-MTYyNTU3/ [15:26:38] jesus these urls are horrible to copy by hand [15:26:49] not very... mobile-friendly :P [15:27:20] reconnecting device, installing profile [15:27:24] YuviPanda: oh while i've got you here -- what should the initial display look like? right now we either show the explanatory notice *or* the cat list [15:27:41] show the note if cat list is empty [15:27:50] so it works for the first time, and that's enough [15:27:52] i think [15:27:54] problem is this phone isn't linked to my email. [15:27:54] ah that'll do [15:28:10] urgh [15:28:31] "New Recruit: Sage Ross" [15:28:34] that's a good sign :D [15:28:50] and it's got a device id, so i'll set you up [15:28:50] \o/ [15:30:23] okay, got an email [15:30:35] opening the email is the only way to install? [15:30:46] or will it also get pushed straight through the app eventually? [15:31:11] this build is not available for this device [15:31:18] ragesoss: i think it'll show up on testflight.com -- but i have to make a new build first [15:31:22] testflightapp.com rather [15:31:33] it's crazy, i have to sign the build with a list of devices [15:31:36] apple :P [15:32:09] holy shit. they really don't like open source style development, do they? [15:32:19] ragesoss: they don't like developers in general, really [15:32:51] seriously [15:32:56] I mean, you get plenty of people going 'I <3 iOS' [15:33:04] I'm yet to hear anyone going 'I <3 XCode!' [15:33:10] or 'I <3 iTunes Connect!' [15:33:17] or even 'I <3 Developing for iOS!' [15:33:18] xcode's not half bad. itunes connect? piece of shit :) [15:33:40] coming from vim (and later intellij) XCode is horrible horrible horrible ;P [15:35:57] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/2LeB4Q [15:35:57] Commons-iOS/master 2a2bc63 Brion Vibber: bump version to 1.0.2 [15:36:19] aha! [15:36:44] the app left memory before successfully pulling in another 500 uploads the first time. [15:37:02] but this time I did refresh and eventually got newer uploads. [15:37:28] brion___: when you feel it is time, add a watchlist notice, etc to the iOS app too :) [15:38:05] shows 999 photos now. [15:38:28] takes forever to scroll through that many to the bottom, though. [15:39:01] is there a way to grab the slider and go straight to the bottom like on Android? or some other way to scroll more quickly through a really long list? [15:39:20] I see that scrolling speed is pretty adaptive, but still it takes a lot of swipes. [15:40:33] ragesoss: ok see if it'll install now. mostly minor changes have landed so it'll still have most of the same problems [15:40:40] but if you can install that, we can send you new versions :D [15:41:22] yeah, just plain scrolling won't be nice enough for really long lists like yours. i'll see about a thumb or something [15:41:54] hey valeriej|away :) [15:41:58] i know that can be done on a tableview, not sure about on a collectionview [15:42:32] it's working, I think [15:42:32] Hey, YuviPanda! [15:42:40] how're you? [15:42:51] been busy? :) [15:42:58] unable to download at this time [15:43:04] oh, retry worked. [15:43:08] \o/ [15:43:18] I'm good. Yeah, I've got a job interview this Friday, and I'm preparing for that. :) How are you? [15:43:33] valeriej: nice! [15:43:39] valeriej: good luck on the interview :) [15:43:50] valeriej: pretty good, but will be dropping off the internet for a month from next week [15:43:54] have a month of exas [15:44:29] YuviPanda: Thanks! Oh, good to know. Good luck on your exams! [15:44:34] thank you :) [15:44:54] managed to find any time for the android stuff? [15:46:33] YuviPanda: I was working on the IntelliJ set up instructions and Markdown. [15:46:39] ah [15:47:49] YuviPanda: I'll have more time after this week, but you'll be away, ha. I have an idea of where to start for the few bugs I've taken. [15:48:04] i'll still be responding to emails inside a day :) [15:49:00] YuviPanda: you gone all week next week or part of the week? [15:49:01] YuviPanda: Also good to know! I can contact you that way, then. :) [15:49:09] valeriej: indeed! [15:49:20] valeriej: but do post to mobile-l instead of just me, brion___ is up on android stuff too :) [15:49:27] :D [15:49:33] brion___: i'll be around but not really :P Just popping in and out [15:49:43] YuviPanda: Ah, ok. Will do! [15:49:43] will be 'around' around only till end of week [15:49:46] ;) [15:49:54] ok. i'll expect to catch you mostly via email then [15:51:07] brion___: :) [15:53:35] oh yay my regular nick is available again [15:53:36] i can escape web chat :) [15:53:59] brion: whee :) [15:55:44] ok i'm gonna grab some breakfast, then add search & initial view to https://github.com/brion/android-commons/commits/recentcats [15:56:23] YuviPanda: anything else i should add before you review & merge it? [15:56:34] do you want to do search separately? [15:56:36] ah [15:56:38] didn't see that [15:56:39] no [15:56:43] brion: search + initial is good :) [15:56:54] excellent [16:02:54] ragesoss: seen https://meta.wikimedia.org/wiki/Requests_for_comment/Interproject_links_interface#Option_2:_Links_on_the_sidebar [16:02:54] ? [16:03:03] I mean https://meta.wikimedia.org/wiki/Requests_for_comment/Interproject_links_interface [16:04:06] brion: ^ [16:04:37] YuviPanda: i actually kinda dig the tabs idea, but don't know how to reliably link things :P [16:04:46] brion: me too! [16:04:53] reliably link as in? [16:04:54] needs more wikidata ;) [16:04:58] ah yeah [16:05:02] brion: we already have interwikis! [16:05:04] it's just not exposed [16:05:13] same as interlanguage [16:05:38] mm true [16:05:50] brion: but if you like the idea please do a {{support}} [16:05:51] we could extend that to support arbitrary tab links [16:09:39] yurik, for the json blobs, do you want the default values echoed into the json blobs to start with? or if no value is specified, simply do not echo the key:value into the json blob (i.e., leave it undefined)? [16:10:01] YuviPanda: I hadn't seen that, but it's long overdue [16:10:01] dr0ptp4kt, leave it undefined [16:10:09] ragesoss: yupo [16:10:11] yurik, sounds good. [16:10:19] but not an easy problem to solve, since many links aren't 1:1 [16:10:20] ragesoss: please do spread the word [16:10:25] dr0ptp4kt, only put whatever is unique to the entry that is not default [16:10:33] thx :) [16:10:41] dr0ptp4kt, i'm back home!!!! [16:10:48] welcome back, yurik [16:11:09] thx! it is a bit tiring to jump timezones so much [16:11:25] dr0ptp4kt, are you back to SF? [16:11:33] (or is that forward?)( [16:11:48] yurik, i'm in minneapolis-st. paul. will be back in the office next week, though [16:11:56] kul [16:44:12] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60601 [16:49:17] New patchset: JGonera; "Handle all the Node.js dependencies the same way" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60601 [16:55:39] brion: it made me very happy to see the approval from apple last night [17:01:52] brion, you in the office? [17:10:34] anybody in the mobile team in the sf office? quick favor... [17:10:45] ….favor request, that is. really, i promise it is simple. [17:14:44] mhurd, can i ask a favor? [17:15:00] dr0ptp4kt: ya! [17:16:14] using your office internet connection in sf, starting with a completely fresh browser session (window 0, cache cleared, etc.), what happens when you go to http://en.zero.wikipedia.org (just that URL nothing else)? [17:18:03] mhurd: ^ specifically, is it redirecting you to a different domain? are you seeing images or no images once you land? [17:22:58] dr0ptp4kt: i dunno if it still exists, but i think office IT has a way you can VPN thorugh the office, so you can do this kinda testing anywhere [17:23:55] i know they at least used to - i had to do that for fundraising a couple years ago [17:25:26] awjr, yeah, i managed to establish a vpn connection, but it seems it's split tunneling or something. gotta check on that. was thinking i could just change the default gateway, but not sure which ip to use! will have to email support. [17:25:43] oh gotcha [17:25:45] good times :p [17:31:55] dr0ptp4kt: it puts me on http://en.m.wikipedia.org/wiki/Main_Page [17:31:58] jgonera: were you able to get ahold of jon about those mysterious cards? [17:32:13] mhurd, with images? [17:32:20] dr0ptp4kt: ya there are a couple [17:32:49] mhurd, thx. been trying to track down why that is, but wanted to see if my reality was the same as yours :) [17:33:31] brion: i put a 4th gen ipod on order as we were running low on handset iOS testing devices [17:33:41] ok [17:33:54] mhurd, you know, quantum superposition and all that. [17:34:08] i'll pick up another iPad mini if the budget permits [17:35:06] brion: https://itunes.apple.com/us/app/wikimedia-commons/id630901780?mt=8 is missing our privacy policy [17:35:37] hm i'll check our metadata [17:36:19] odd, it's in the metadata on iTunes connect [17:36:54] tfinc: doesn't show at https://itunes.apple.com/us/app/wikipedia-mobile/id324715238?mt=8 either ... [17:37:22] lemme check in itunes [17:38:00] tfinc: yeah i see 'privacy policy' link on sidebar if i open the app info in itunes [17:38:05] it's just not showing on the web. weird [17:40:34] weird [17:41:30] dr0ptp4kt: any time :) [17:42:10] dr0ptp4kt, did you forget to disable that header-setting extension? [17:46:16] yurik, i actually have it turned on so that i can see the behavior. i'm spoofing the X-Carrier and X-Subdomain headers to be that for one of our carrier partners. awjr and brion, do you know if there's a redirect somewhere in squid/varnish/apache/MediaWiki/MobileFrontEnd that would for access originating from a carrier partner's IP when accessing http://en.zero.wikipedia.org result in a *301* to Location: http://en.m.wikipedia.org/wiki/Main_Pag [17:47:03] brion: please add the itunes link to http://www.mediawiki.org/wiki/Mobile/Release_history [17:47:03] dr0ptp4kt: that actually sounds familiar to me for some reason [17:47:07] dr0ptp4kt, i thought we had that redirect in varnish? [17:47:08] dr0ptp4kt: lemme think for a sec [17:47:15] hmm [17:47:23] i remember doing that in VCL [17:48:10] dr0ptp4kt: im not sure about the 301 specifically, but that's standard behavior on desktop and i think it was implemented for mobile as well. I *think* that actually used to happen in MobileFrontend, but has since been handled in varnish [17:49:16] dr0ptp4kt: if you're not able to quickly turn anything up about it, talk to asher (who i think set it up) - he's usually in #wikimedia-operations during the day (nick: binasher) [17:49:23] awjr, no, I texted him and tried calling with no success [17:49:30] i'd help dig but am about to walk into an interview [17:49:58] jgonera: ok, no worries, probably best to assume he's working on it for now, and we can confirm one way or another with him when he can be in touch [17:51:52] dr0ptp4kt, mobile-frontend.inc.vcl.erb has all that logic [17:52:21] which line is it that does the 301 redirect? i'm sure it's there in plain sight, but i haven't been able to pinpoint it. [17:55:07] awjr, yeah, I'll start with another story [17:59:52] brion, I can't reproduce that Kindle bug. should I see it on the keyboard-less Kindle or the one with keyboard? [18:00:08] jgonera: i confirmed it on the keyboard-less one [18:00:13] oh -- make sure javascript is enabled [18:00:19] we might have left it disabled during previous testing [18:00:30] it is enabled, I just loaded an article and it did not disappear [18:00:32] enwiki [18:00:42] yeah you have to mouse over the search box [18:00:50] which is *really* easy to do if the cursor was initially in the URL bar [18:01:07] ^ yurik, it may seem like these could be a pointer: [18:01:08] awjr, Jon has just texted me back, he moved the story back to ready for development [18:01:09] 562 /* Replace .(m|zero)..org by ..org */ [18:01:10] 563 set req.http.host = regsub(req.http.host, "^([a-zA-Z0-9-]+)\.(m|zero)\.", "\1."); [18:01:17] brion: hey quick question - there are a couple places in CommonsApp.m which are logging like so: [self.eventLog log: … and others which are using [self log: … should be alright to change the former to the latter right? [18:01:19] New patchset: Jdlrobson; "Story 425: Nearby preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [18:01:21] excellent jgonera :) [18:01:36] mhurd: hm lemme check just in case there was a reason for that :) [18:02:10] yurik, at that point when it forwards the request on chained through call device_detection i'm not sure where it goes next [18:02:24] dr0ptp4kt, sorry, wasn't looking at the irc, sec [18:02:48] brion, I still can't see it, cursor initially in url bar, I hit reload and the cursor gets over the search input but the article does not disappear... [18:02:50] dr0ptp4kt, i'm not sure about device detection [18:02:52] mhurd: yeah i think those should go ahead and use log: and not use eventLog log: [18:03:01] you'll show me when you're around [18:03:03] dr0ptp4kt, the error 666 is how all the redirects happen [18:03:19] yeah, that's a 302, not a 301, though from what i see? [18:03:24] brion: cool! [18:03:24] ^ yurik [18:03:30] jgonera: hmm, well i could totally repro it the other day :( [18:03:40] yurik, the device detection just seems to set the X-Device [18:03:49] dr0ptp4kt, oh, good point, i only know abotu 302 [18:03:52] yurik: but i'm guessing that thing ends up hitting something else [18:04:07] yurik: and down the rabbit hole we go [18:04:22] hmm.. i wonder who generates 301s [18:05:23] brion: log: will tack on username, device, platform and appversion to each log dictionary - that should be ok right? [18:05:34] yurik, i can see we're going to have to track the next hop from vcl_fetch :) [18:05:38] mhurd: that should be the correct thing yeah [18:05:48] yurik, FUN WITH VARNISH! [18:05:53] brion: great! [18:06:03] brion, ok, I reproduced it now, not sure what I did differently [18:07:11] aha [18:07:23] dr0ptp4kt, could that be a rewrite rule in apache? [18:07:29] yeah the cursor is a bit weird on the kindle, sometimes you have to have it positioned _just so_ [18:07:31] yurik, i'm thinking so [18:07:59] yurik, cd .. mediawiki-config :) [18:08:03] cd .. [18:08:18] i'm greping through the pupets [18:14:37] jgonera: should have pinged me here :) [18:14:57] jdlrobson, you were online all the time? [18:15:03] [09:39am] jgonera joined the chat room. :) [18:15:14] my phone was in my bag :) [18:15:53] Maryana: latest jon the cowboy controversy… enjoy > https://gerrit.wikimedia.org/r/#/c/60684/ [18:16:29] heh, I noticed that just after the standup and then you still weren't online [18:16:37] you have wifi on the plane again? [18:16:46] yurik, shoot, accidentally closed wikimedia-mobile tab. [18:16:57] yurik, did you have anything extra to say while i was gone? [18:17:21] New patchset: Jdlrobson; "Story 425: Nearby preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [18:17:27] jgonera: no i board my flight at 11:50 [18:18:11] ok, I thought you got one of those posh modern flights again ;) [18:18:34] dr0ptp4kt, nope, no results so far [18:19:02] yurik, i'm looking through https://noc.wikimedia.org/conf/ (also in mediawiki-config repo) [18:27:52] New patchset: Jdlrobson; "Story 425: Nearby preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [18:30:09] New review: Jdlrobson; "Preview: http://imgur.com/P8VvnTc,gYj8k2E" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [18:31:28] New review: Jdlrobson; "ps. could be reused on watchlist a-z list." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [18:31:54] New review: JGonera; "Ugh, that header looks bad. I'd move the title into the content I guess, or trim it." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [18:35:18] jgonera: are you referring to heading in screenshot or patchset? [18:35:21] brion, how do I clear the browser cache in Kindle? clearing history and cookies doesn't seem to work [18:35:36] jgonera: excellent question :D [18:36:14] I guess I'll just regenerate localtunnel url [18:40:01] jgonera: btw i want to introduce a setting for link hijacking. It's way too experimental even for alpha ;-) [18:40:39] here be MEGADRAGONS [18:40:43] lol [18:40:57] here's how a wikibase item page looks with mobile frontend [18:40:58] http://wikibase.pragunbhutani.in/mw/index.php?title=Item:Q10&mobileaction=toggle_view_mobile [18:40:58] i was thinkin of just using a localStorage flag but not sure what opt in /out would look like [18:41:01] a bit like chrome flags [18:41:18] jdlrobson, I'm fine with that, but we should consider rewriting settings, I thought about doing this as a part of story 358 (btw did you take it? ;) [18:41:36] pragunbhutani: cool you got it up and running :) [18:41:40] I mean the code for storing settings [18:41:57] i've taken all stuff in mingle [18:42:09] you mean local Storage settings? [18:42:39] possibly localStorage with fallback cookies [18:42:40] jdlrobson: trying to figure out how and where it breaks with #wikimedia-wikidata now [18:42:44] but yeh i can think about that as i go - but this is somewhat different - not sure what would turn it on and off [18:42:58] as the watch list view just happens as you click [18:43:03] you don't need to toggle it on anywhere [18:43:24] jdlrobson, yes, but it needs to be stored somewhere [18:43:31] sure [18:43:38] same way as language data i guess [18:43:38] so, you're working on 358? [18:43:43] yes jgonera it's in mingle :) [18:43:55] yes, but for some reason you're name is not assigned to it [18:43:57] not now but i have no doubts i'll get all the stuff done on the plane [18:44:06] jgonera: yey mingle :) [18:44:37] anyway i need to go board my flight [18:44:40] anything before i go? [18:44:46] yes, but you need to hijack links, or possibly even have those settings being accessible on the server side to generate appropriate menu link [18:44:58] after all, the menu link depends on what the user selected last time [18:45:21] I thought about taking this one too (as stated in e-mail) because I did some preliminary thinking on it ;) [18:45:33] jgonera: no i don't [18:45:39] just using js to update link [18:45:49] kind of ugly [18:45:50] plus [18:45:58] I often click the menu button before all the js loads [18:45:59] i think it's perfectly acceptable to only apply to js users [18:46:05] jgonera: not possible [18:46:07] and I got taken to the separate-page-menu [18:46:15] ah yeh [18:46:50] i don't think it's the end of the world though in that situation [18:47:24] anyway.. must fly… literally [18:56:27] jgonera: so my flight is a little delayed [18:56:28] yey united! [18:56:45] i will look into using user preferences though for watch list view since it is logged in users only [18:56:56] ok [18:58:00] jdlrobson: united? :( [18:58:11] are you direct to lhr? [18:59:45] New patchset: JGonera; "Don't use focus event for the search input" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60691 [19:02:43] Maryana, I don't understand this sentence: Given I am a logged in new user (less than 3 edits on the local wiki) on beta and have 0 uploads who hasn�t uploaded on their current device more than 3 times. (https://mingle.corp.wikimedia.org/projects/mobile/cards/483) [19:05:50] oh i bet my mediawiki instance runs way better with memcached running :PPPP [19:07:34] New review: Brion VIBBER; "Haven't tested in all browsers, but this sounds like the right solution." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/60691 [19:09:30] jgonera: i think some browsers won't do a 'touchend' event, in which case it should still open the overlay once you start typing… might want to double-check in things like windows phone tho [19:10:36] brion, oh the WIndows Phone... should I take the HTC Windows Phone 7 to test it? [19:10:58] jgonera: yeah. iirc, IE has a different touch event model [19:11:05] might send a mouse event instead or something [19:11:26] Maryana: these Opera mini bugs, do you want to get any of them on lined up for the next sprint? [19:12:27] i'd prioritize the ones that affect readers, like the search bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=47567 [19:13:19] brion, you're right, doesn't register touchend, but the overlay shows up when I start typing [19:13:28] whee [19:13:44] did you review all the open bugs tomorrow morning and decide which ones should go in the next iteration, jcmish_? [19:15:17] New patchset: Jdlrobson; "Story 358: Persistent watchlist view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60692 [19:15:28] I did look at them last night and grabbed 4 but I had the Mini's on the "ask if you want them" list [19:17:16] awjr, can you check https://gerrit.wikimedia.org/r/#/c/60601/ again when you have some time? [19:19:49] sure jgonera [19:21:42] jgonera: seems to work for me :) [19:21:59] jgonera: i got one warning with make less: npm WARN prefer global jshint@1.1.0 should be installed with -g [19:22:07] awjr, thanks [19:22:51] awjr, yes, that's expected (https://github.com/isaacs/npm/issues/1648) [19:23:06] ah ok [19:23:16] New patchset: Jdlrobson; "Story 429: Show watchlist photo CTA where photo absent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60696 [19:23:24] jgonera: i assume it works fine in your environment too? [19:23:26] it'll show up only in the first run or when someone updates versions of packages in package.json [19:23:31] maybe as MaxSem to give it a whirl too [19:23:34] *ask [19:23:40] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60691 [19:23:51] awjr, it does, Jon had some problems with it though, I assume he has Node.js installed in some uncommon way [19:23:55] jdlrobson: in flight wifi? [19:24:02] awjr: delayed flight [19:24:05] roger [19:24:07] not sure if this plane has wifi or not [19:24:12] will soon know [19:24:20] jdlrobson: are you direct to lhr or stop over on the east coast? [19:24:21] at least i can charge my laptop :) [19:24:23] direct [19:24:32] i don't do stop overs if i can;-) [19:24:36] same [19:24:49] i think i've heard the longhaul united flights have in-filght wifi now, but who knows [19:25:29] so jgonera i will easily have time for more stories at this rate [19:25:33] any preferences on what i take? [19:25:53] otherwise i'll end up being a rhinestone cowboy again [19:26:10] promoting dynamic sessions I guess? you know the code better [19:26:28] or just spend some time on doing general cleanup and refactoring ;) [19:26:29] for some reason story ownership is not updating - jdlrobson, jgonera did you guys drag the stories into 'in development' from 'ready for development', or did you update them to 'in development' some other way? [19:26:36] mingle is broken again awjr [19:26:42] it doesn't even ask me for the gerrit url anymore [19:26:42] :-/ [19:26:42] awjr, I dragged mine [19:26:53] jgonera: roger [19:26:55] something's changed that shouldn't have :( [19:27:02] hey, update, i moved the left nav grouping story back to the backlog [19:27:03] i'll investigate this afternoon [19:27:06] hopefully that didn't break mingle [19:27:12] shouldn't ahve [19:27:41] i realized it makes more sense to just start tackling the right nav if that's the direction we're happier with [19:27:51] jdlrobson ^ [19:28:07] Maryana: I'm still unsure about the nav situation [19:28:12] right nav? [19:28:33] awjr: the evil twin [19:28:41] heh, ok, i think this calls for a mailing list email [19:28:44] i hate right nav :( [19:28:52] Maryana: I still wonder if the right menu is better for actions on article rather than user related stuff [19:28:55] but maybe i'll like this one :) [19:29:17] Maryana: also to be honest my latest thought is the right button should open an overlay with actions on it [19:29:26] like a user dashboard potentially [19:29:37] jdlrobson, but when you hide article-related action, it reduces their visibility [19:29:40] the problem with right nav is the button that opens it disappears from under your finger [19:29:43] on left nav it doesn [19:29:44] 't [19:30:03] Maryana: how is opening an overlay different from sliding open a right menu? [19:30:04] i'll write up some ideas in an email & send it out [19:30:15] i'm saying we put article actions in the article :) [19:30:18] not hide them anywhere [19:30:20] oh i see [19:30:31] well regardless right menu i'm still not sure about [19:30:34] an overlay might make more sense [19:30:41] then there's the question of where the watch star etc go [19:30:48] and if we need a user menu [19:31:03] that's what i was thinking [19:31:06] currently we would only have 4 things in it - watch list, uploads, settings and login/logout and 3 in the left menu [19:31:09] that's where notifications can go, too [19:31:21] and talk page :D [19:31:23] the menus seem to small in the current setup [19:31:25] user talk, i mean [19:31:29] jgonera, so what did you wanted me to check, stuff like make nodecheck? [19:31:39] Maryana: what i said about talk applies to user talk [19:31:51] i think it should be activated from the page itself [19:31:59] which page is that for a user? [19:32:09] so jgonera i tried latest patchset [19:32:22] i can now run sudo make less [19:32:22] but it's very slow [19:32:29] as each time it makes a request to /Users/jrobson/Sites/w/extensions/MobileFrontend/node_modules/phantomjs/tmp/phantomjs-1.9.0-macosx.zip [19:32:42] which seems to freeze it [19:33:31] (https://gerrit.wikimedia.org/r/#/c/60601/ patchset) [19:33:54] Maryana: so I think there should be a menu item 'jdlrobson' / 'accedie' [19:34:02] which takes user to a profile page and from that they can access things like talk [19:34:18] that would be cool [19:34:59] for a minimum viable product for beta, though, we can just start with a list of things and go from there [19:35:11] yurik, i'm going to e-mail binasher about that redirect, but i guess it doesn't really matter in the wild, seeing as the X-Carrier will only get set properly if the user is in the correct IP space and there's a domain match. nonetheless, it's weird redirect behavior and i want to try to deal with it if possible. [19:36:12] yurik, actually maybe it matters now that i think about it. hmmmmph. i'll e-mail binasher [19:36:21] dr0ptp4kt, sure, but if we are getting rid of it ... [19:36:26] Maryana: as i've said many times if the skin refactoring gets finished it will be really trivial to provide radically different skins in beta/alpha/stable [19:36:50] so are you saying we should wait till then? [19:36:59] to mess w/nav stuff? [19:37:10] Maryana: i'm just reminding everyone that i could really really really really do with some code review for the skin stuff - it's been so so so slow [19:37:17] jgonera: you got my messages above? [19:37:22] my connection is dodgy [19:37:35] yurik, are you talking about 'getting rid of' the *.zero.wikimedia.org subdomains? i think that depends on old arrangements expiring. [19:37:39] Maryana: I'd go with the current navigation for the time being and start a mailing list discussion [19:37:52] ok. working on an email :) [19:37:54] preferably to mobile-l to keep the YuviPanda gods happy :) [19:37:57] dr0ptp4kt, no, getting rid of the x-carrier to move to x-cs [19:38:06] jgonera: ? [19:38:09] yes yes yes! [19:38:30] yurik, right. i'm not 100% sure it's strictly related to x-carrier, though :( [19:39:06] New review: Jdlrobson; "This works but triggers but makes things extremely slow:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60601 [19:39:42] yurik, that is to say i think we still need the same subdomains, and am thinking the redirect behavior might be some strange edge case. [19:40:12] mhurd, when you visited the en.zero.wikipedia.org that redirected you earlier to en.m.wikipedia.org did you see the zero rated access banner at the top of the webpage? [19:42:52] yurik, heading over to the bank for a bit, then will be back online after that [19:43:03] dr0ptp4kt, kul [19:51:42] yeyy united [19:51:45] they just announced boarding [19:51:55] and then decided 6 minutes later they are going to stop boarding [20:00:20] Maryana: im having some connection problems im tyring to sort out, might be a few minutes late for prioritization [20:05:23] mmmm new IntelliJ version [20:11:26] * NoContextPanda heads to sleep. [20:11:27] gnite folks [20:21:44] darn, just lost yuvi [20:21:49] wanted to run something past him [20:23:16] i'll roll back the local recent cats search for now, it works but I'm not happy with the ui behavior [20:31:52] brion: got most of your revisions implemented - abstracting logging pref and browser pref to CommonsApp now. also spent some time reproducing a weird bug with the new browser pref stuff - will jump on that too [20:37:43] woot [20:42:13] awjr: Maryana sorry rebooted [20:42:23] just to see if my machine was flakey [20:42:28] bud hunt tomorrow? :D [20:42:39] *bug [20:42:43] and bud :D [20:42:47] yes! awjr, did you wanna join in? [20:42:53] if so, what time works for everyone? [20:42:55] jcmish, Maryana: would you like me to run bingle before triaging? also, it imght be good to have an engineer present to help clarify/shape priorities [20:43:34] yeah, i think that would help [20:43:37] im in a mtg til 1130, but am otherwise free all day tmrw [20:44:00] my only obligation tomorrow is 10:30-11, so i'm pretty free, too [20:44:05] Maryana, "home wiki" in your strategy doc means the wiki in the language the user uses most often? [20:44:06] same here [20:44:09] Im free whenever [20:44:18] jgonera, the wiki they're on when they tap upload [20:44:24] should we do noon ? [20:44:25] for most people it'll be whatever language wikipedia [20:44:33] cool then we could invite jgonera and MaxSem and make it optional [20:44:36] or does that mess with lunch for you? [20:44:38] jcmish: noon pdt works for me [20:44:42] nah, fine for me [20:44:42] Maryana, ok, but that's not about wikis they set up themselves, about cats or video games? [20:44:49] i may munch lunch while we do it [20:44:49] k cool and I'll add then to the invite [20:44:50] ok [20:44:51] hahahah [20:44:53] jgonera, no [20:45:02] sweet thanks :) [20:45:03] wikimedia foundation wikis :) [20:45:26] i'll make sure bingle's run at least once before then so we can triage in mingle [20:45:35] * Maryana wants to make joke about wikia but sees there are wikia developers sitting not 10 feet away from me.. [20:46:41] Maryana, pretend they are not listening... [20:46:55] :) [20:49:35] jgonera: https://mingle.corp.wikimedia.org/projects/mobile/cards/483 [20:49:42] i made it a little clearer, hopefully [20:50:04] there is invisible acceptance criteria that says "and i am not on a wiki iset up myself, about cats or video games" :) [20:50:11] *i set [20:50:33] Maryana, thanks, it was much clearer after we talked [20:50:45] ok, cool :) sorry about that [20:50:55] hehe, so I should disable it on wikis that people set up themselves? ;) [20:51:08] hm, maybe a config option though [20:51:26] that's actually a good point, non-WMF users of mediawiki might not want that [20:54:27] only on cat wikis [20:58:36] [android-commons] brion opened pull request #8: Store and show recently-used categories list (master...recentcats2) http://git.io/2yHumg [20:58:50] zz_NoContextPand: https://github.com/wikimedia/android-commons/pull/8 is for you :) [21:03:58] mhurd: let me know when updates are ready to review & merge :) [21:07:47] brion: will do. just got the tracking and default browser abstracted to commons app [21:07:58] sweet [21:08:15] brion: i like it much better that way too [21:08:22] brion: good suggestion [21:08:40] as long as we don't end up with an abstracted FactoryFactory that creates ObjectFactories [21:08:47] lol [21:37:40] mhurd: don't suppose you know any tricks for mixing dynamic and static sections in a UITableView do you? [21:37:56] I'm thinking of changing the detail view, which currently uses static cells [21:38:24] worst case we can redo it as all prototype cells with some hardcoding on the first section [21:38:36] but i think this means rearranging all the delegates :P [21:40:09] brion: hmmm… not sure [21:40:19] * brion hmms a bit [21:40:26] hehe [21:40:27] http://stackoverflow.com/a/9313825/82439 looks like what I need [21:40:49] does that sound sane to you? list it as static, but override behavior for one section [21:41:00] and just include the prototype cells as the static entries in the dynamic section... [21:41:03] … sounds sane right? :) [21:41:41] brion: oh. cool! yeah it makes sense at first glance [21:41:51] phew [21:42:06] switching between obj-c and java hasn't rotted my brain too bad then [21:42:53] haha many hats will give you hat hair though [21:44:28] :P hehe [21:49:22] tfinc, I was wondering if things like http://thesourcery2.eventbrite.com/ are worth anything when looking for candidates. it says frontend, but in a message from meetup.com they mention generalists too [21:54:04] jgonera: could be. sent it to emily to see if its on her radar. [21:54:09] good find [22:01:21] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60691 [22:01:59] New patchset: JGonera; "Don't use focus event for the search input" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60691 [22:02:25] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60691 [22:04:04] New review: JGonera; "Whaat? I'm not sure what's going on there. PhantomJS has nothing to do with this... You'll need to s..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60601 [22:07:44] brion: i just pushed 5 commits - should address your comments with the exception of https://github.com/montehurd/Commons-iOS/commit/74517d40715db364f8238bc7a019685f0c3fcac5#L1R155 which i'd like to play around with a bit more. [22:08:10] brion: going to try to quickly knock out that browser list bug i mentioned earlier [22:12:10] mhurd: great i'll look em over [22:17:05] MaxSem: any objection to me rebooting staging? [22:18:29] MaxSem: also, i need to add two additional python modules to staging - do i need to do that via puppet or can i just install them locally? [22:18:52] staging is not managed by puppet [22:19:14] groovy [22:19:18] that makes it easier [22:22:08] hey jgonera, when you get a chance, can you update the limn dashboards to point to the new uploads schema? [22:22:44] i'm in the analytics quarterly review & they're showing off the limn grpahs. unfortunately, it looks like there were 0 uploads from mobile web since the 17th :) [22:22:50] *graphs [22:27:54] Maryana: i checked in with jgonera and he said that he could keep the dashboard moving while Yuvi was out [22:28:15] so thankfully we have broad coverage [22:30:30] mhurd: quick note testing the current branch: https://github.com/wikimedia/Commons-iOS/pull/49#issuecomment-16975356 [22:31:43] Maryana, there are patches awaiting review for this and I wanted Yuvi to have a look at them while he's still here, but if you need it now I'll self-merge [22:31:52] else I'll ping him tomorrow [22:32:20] oh, ok - no worries, it's not a huge rush [22:33:11] brion: want me to add that quick-like? [22:33:15] heh, "while he's still here", in our virtual IRC-land [22:33:21] mhurd: sure should be easy [22:33:26] brion: k [22:35:01] Maryana, the copyvio message should appear both for the dashboard uploads and lead photo uploads, right? [22:35:08] yep [22:35:10] ok [22:37:22] awjr, I'll need to move your getUserUploadCount() function somewhere so that it can be accessed on any page and its value forwarded to JS (probably using onMakeGlobalVariablesScript hook). what would be the best place for it? [22:37:43] hmm [22:37:49] one sec jgonera i'll take a look [22:37:51] ok [22:41:31] jgonera we could leave it where it is an make it public and static [22:41:51] what do you htink? [22:41:59] im not really sure where else would make sense for that method [22:42:08] it's pretty… upload-specific [22:42:24] hm, I thought about it but something seems wrong about it ;) do we have something like a User model to which we could add something? [22:42:38] model?!?! [22:42:42] you ask too much, jgonera [22:42:54] well, model-like object or something ;) [22:42:55] :p [22:43:01] that would be cool [22:43:17] ok, I guess I'll just make it static now [22:43:27] this can be changed later [22:43:33] that could be an interesting direction to move in [22:43:54] brion: i made the links open in default browser [22:43:58] whee [22:44:02] :) [22:44:09] pushed [22:44:26] another possibility jgonera, as an intermediary step, would be to extend the MW User class [22:45:24] hm, I'll try it out [22:45:57] that coulda ctually be kinda cool - we could overload the User object in the request context to be our mobile-specific user obj [22:45:59] mhurd: looks good. still working on some stuff? i'll merge em all together when you're done [22:46:03] http://devblog.blackberry.com/2013/04/blackberry-jam-blackberry-z10/ [22:46:05] MaxSem: what do you htink ^^ [22:46:34] awjr, I think of worms. in a can [22:46:40] lol [22:47:22] man, editing those iOS storyboards sucks on a small screen… Xcode eats a lot of space :P [22:47:27] brion: i do have one bug. hopefully quick fix [22:47:34] had to switch to 1920x1200 just to see everything :) [22:47:38] ok [22:47:53] jgonera: if you're up for trying out, could be interesting - particularly if there are other user-specific functions we currently have or will want to add; then again, it may be a bit prematue to do that (it might be something we explore when adding other user-specific stuff like notifications) [22:48:07] but max is right - it could easily become a nightmare :p [22:48:33] why would it be that bad? [22:48:49] the short answer is because it's MW [22:48:53] brion: ya [22:49:03] you're modifying the global state [22:49:35] which so long as you don't start mucking around with other User internals shouldn't really be a big deal [22:49:43] if the user object is cached somewhere, hell breaks loose [22:50:13] but if you set the User object in the request context when MobileFrontend is instantiated... [22:50:39] *should* be ok, i would think [22:50:48] but [22:51:08] things can get freaky really quickly in mediawiki [23:00:10] haha [23:00:24] sorry, out of context, that was hilarious, awjr [23:00:33] hehehee :p [23:01:24] >:) [23:08:02] brion: found fix for my weird bug [23:08:10] \o/ [23:14:10] brion: testing now should push shortly [23:14:37] great [23:27:33] moving along on https://github.com/brion/Commons-iOS/commits/cats-dynamic -- looks like i've got the table view doing what i want, just need to hook up the actual add stuff ;) [23:27:47] brion: pushed fix. it looks sort of odd but according to the 3rd item here it should work http://stackoverflow.com/a/6391136/135557 [23:28:27] ooh scary :) [23:28:52] ya a bit of a hack [23:29:01] but seems to do the trick [23:29:43] hmmm [23:29:50] and i need it to happen every time the view is presented, which this does [23:30:08] mhurd: numberOfRowsInSection gets called multiple times potentially [23:30:35] if using for initialization might want to make sure it's not set before creating a new array [23:30:41] brion: w/additions and deletions iirc [23:31:13] brion: ah [23:31:20] also fun fact -- you can do [array mutableCopy] to get an NSMutableArray slightly less verbosely :) [23:31:28] brion: otherwise i may be leaning too heavily on arc [23:31:53] yeah it shouldn't leak thanks to arc, it'll just do more lookups and constructions than it needs :) [23:32:01] i'll patch the patch.. [23:32:05] super [23:33:48] brion: switching to mutableCopy, but i do need it to give me fresh list every time in case a browser was deleted since last time settings page was seen. [23:34:03] brion: is that ok for now? [23:34:06] hmmmm [23:34:17] that's a good point actually [23:34:33] but it might not invalidate the table layout automatically…. [23:34:36] * brion wonders [23:34:58] you might have to poke the tableView when reappearing on screen to make sure it reenumeratest he cells [23:35:09] brion: that's why i had it in viewWillAppear [23:35:12] brion: ua [23:35:17] *ya* [23:35:33] brion: i'll check that real fast [23:35:55] d'oh http://stackoverflow.com/questions/5277940/why-does-viewwillappear-not-get-called-when-an-app-comes-back-from-the-backgroun [23:37:02] i think there's a better notification than the one the accepted answer recommends [23:37:22] ah it was in the comments: UIApplicationDidBecomeActiveNotification [23:37:48] New patchset: Yurik; "Use JSON carrier settings for banner localization" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/58875 [23:37:48] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [23:39:02] notification center saves the day again [23:39:05] brion: :) [23:39:13] testing/adding fix now [23:42:17] dr0ptp4kt, [23:42:27] yurik, you rang? [23:42:28] dr0ptp4kt, there? just checked in zero editor [23:42:40] yurik, i'm here [23:42:57] now all the validation are performed when you save json, plus there is a visualizer that pretty-prints it :) [23:44:11] tip of master in ZRMA? [23:44:20] its a patch in gerrit [23:45:30] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/60775/ [23:46:52] dr0ptp4kt, pls take a look at the protection - I added it in the patch, but I saw you did some research into that, so maybe it should be done differently [23:50:34] yurik, nice. which file and lines have the protection? the code itself runs trusted, so it's just a matter of not letting one carrier mess with another carrier's config. [23:51:10] dr0ptp4kt, please review the whole thing :D [23:51:23] yurik, i will, but you know me, i like appsec [23:51:32] ^ (who doesn't?) [23:51:58] ^ yurik, so which file? :) [23:52:18] https://gerrit.wikimedia.org/r/#/c/60775/ [23:52:21] dr0ptp4kt, ^ [23:52:31] yurik, very funny. very well! [23:52:56] dr0ptp4kt, lol, sorry, wrong paste key :)))) [23:52:58] https://gerrit.wikimedia.org/r/#/c/60775/1/includes/ConfigPageHooks.php [23:53:01] it was not intentional! [23:53:22] yurik, lol, thanks. [23:53:28] (jumping between apple & windows is more pain than between dvorak & qwerty [23:54:46] nothing is more of a pain that mistyping your bios password in dvorak [23:55:54] brion, i don't think you can switch bios to use dvorak :)