[00:01:47] exactly ;) [00:22:31] jgonera: https://mingle.corp.wikimedia.org/projects/mobile/cards/692 [00:23:22] let's use the word screen ("take me back to the _page_") [00:23:45] good call [00:23:48] changed [00:23:56] can you estimate? :) [00:23:59] and just to be clear, I'm not blaming this behavior on Jon, I totally agreed with him back then because the code was messy and unreliable ;) [00:24:08] heh, no worries [00:24:43] for some reason Jon didn't do it when rewriting overlay code, so I guess he encountered some problems, possibly with older browsers or internet explorer [00:24:46] hard to say then [00:24:53] maybe a 5 for a start? [00:25:00] sounds reasonable to me [00:25:07] ok [00:25:07] we can re-estimate with the team next week [01:21:53] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [08:04:47] New patchset: Zfilipin; "Updated parallel_tests gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60800 [11:22:56] New patchset: Jdlrobson; "Alpha: Rewrite makePrettyDiff function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60816 [11:22:57] New patchset: Jdlrobson; "Story 464: Promote pretty diffs to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60817 [11:23:00] New patchset: Jdlrobson; "beta: increase diff readability via line height" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60818 [11:25:21] New patchset: Jdlrobson; "Story 477: Only show nearby in menu when supported" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60819 [11:25:21] New patchset: Jdlrobson; "Move feature detection to top of page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60820 [11:27:00] New review: Jdlrobson; "slight issue with this - new patchset on the way" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60684 [12:11:06] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60800 [12:11:06] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60800 [13:41:19] YuviPanda: which bit are you recommending getting rid of here? https://github.com/brion/android-commons/commit/8363a7d0a324ef7424319c8f5e3a44d4ada89659#commitcomment-3083452 [13:47:58] * brion pokes YuviPanda with a stick [15:09:48] hey brion [15:09:52] panda! [15:10:03] I just got back from a NIGHTMARE bus ride. [15:10:03] ugh [15:10:16] 2 hours through heavy traffic and my back feels like how batman's must've after bane broke that [15:10:27] rofl [15:10:36] i mean… i'm sorry to hear that [15:11:19] YuviPanda, in a rickshaw? [15:11:47] MaxSem: in a bus [15:11:49] half of it was standing [15:11:57] crushed along with some 100 other people [15:12:49] brion: also GitHub - can you just pull request without your squashed commit? [15:12:52] and with individual commits? [15:12:59] this isn't Gerrit! [15:13:06] and it's much easier to review individual commits no? [15:13:16] brion: can you send the PR for your actual branch itself instead of squashing? [15:13:24] YuviPanda: well they're not all structured well [15:13:27] man, this is going to take days for my back to recover [15:13:28] but i can do that :) [15:13:35] brion: well, git rebase -i :P [15:13:48] that's how i squashed them :P :) [15:14:09] too much squashing! [15:15:11] [android-commons] brion opened pull request #9: Store and show recently-used categories list (master...recentcats) http://git.io/OljW4g [15:17:25] bah. dell sent me an email saying my linux laptop shipped, but the tracking link says it's still in production [15:19:46] brion, XPS13? [15:19:51] yeah [15:19:58] dev edition?:) [15:20:01] yep [15:20:06] the newer 1080p screen one [15:20:06] mmmm [15:21:57] I got to get me some of that [15:22:07] brion: and yes, I was referring to being able to update without id [15:22:13] did we have that in the other content providers? [15:22:34] yeah, copied it from ContributionsContentProvider :) [15:29:01] hmm, then i'll need to get rid of that everywhere together [15:30:20] YuviPanda: so other than that, i think the only issue remaining was the first-view experience? it's hiding the message when it shouldn't be? [15:30:28] brion: yup [15:30:30] hiding it too soon [15:30:35] i mean i saw something flas [15:30:35] h [15:30:50] ok i'll test that… [15:30:58] * brion prepares to delete and reinstall the app a lot :D [15:31:10] :D [15:31:18] brion: or, y'know, you can comment out the insert :P [15:31:35] heh [15:33:25] gotta charge, brb [15:50:29] void and Void are different. nice. [15:51:07] brion: heh :D [15:51:20] brion: int and Integer too [15:51:29] " The Void class is an uninstantiable placeholder class to hold a reference to the Class object representing the Java keyword void. " [15:51:31] ugh [15:51:40] that's just weird [15:51:44] Java ^ [15:52:00] …shit how do I return a value from a function that returns java.lang.Void ? [15:52:10] you don't have to, I think? [15:52:12] just a return;? [15:52:27] compiler says no [15:52:36] hmmm i've them in the code [15:52:37] * YuviPanda looks [15:53:12] i guess i can just add a fake object and return null :) [15:53:54] 'return null' makes the compiler happy. let's see if it works at runtime [15:54:02] heh [15:55:01] seems to :D [15:55:38] brion: indeed, I'm using return null; [15:55:45] in MultipleShareActivity [16:08:34] YuviPanda: ok updated https://github.com/wikimedia/android-commons/pull/9 [16:08:41] sweet! lookin [16:11:16] ok i gotta get ready to head into the office. i'll check in on the road :) [17:02:20] awjr_away, it looks like bingle went on rampage (see story wall) [17:02:51] muhaha [17:03:46] will it also close cards once the related bugs are closed? [17:06:53] dr0ptp4kt, have you had a chance to run my new and improved patch on your machine? :) [17:08:55] no, but that's item #1 after going through my email today. just sent an email with plans for the day to you and dan. i signed off after my last message on irc yesterday (long day, trying to just make it to 5 PM Pacific Time while in MN). [17:09:02] ^yurik [17:09:23] jgonera: yt? [17:09:45] dr0ptp4kt, hehe, let me know if you run into any problems :) [17:12:14] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/60579 [17:19:44] jcmish, yt? [17:19:59] oh, "you there"? [17:19:59] jgonera: yup quick question [17:20:09] do you know much about different JS Code coverage tools? [17:20:14] YuviPanda: how's the code look? [17:20:33] I'm talking to the Platform folks and thought I'd add you to the discussion [17:20:56] test coverage? I've never had a closer look at them, but I heard about some [17:20:58] brion_: ran a cursory look looks good. In the middle of fixing the 'sharing produces wrong url' code, will stash and have a look in a bit [17:21:08] nice thanks [17:21:11] but I'd like to be in the discussion anyway [17:21:23] i'll run off to the microsoft store opening in a bit, then i'll be back in afternoon :) [17:22:01] cool I shall include you :D [17:22:14] I know them for Java but JS is pretty limited :-/ [17:22:15] brion_: how much is a 'bit'? [17:22:40] in about 25 minutes [17:22:41] YuviPanda, when you have a moment, can you review https://gerrit.wikimedia.org/r/#/q/status:open+project:analytics/limn-mobile-data,n,z ? [17:22:50] will do jgonera [17:22:53] jcmish, thanks, I'll do some googling later on [17:22:54] i merged the other one i think [17:23:08] YuviPanda, yes, thanks, Maryana was asking me about it yesterday [17:24:17] hmmm wat [17:26:50] brion_: alright, doing a stash and reviewing / testing more thoroughly now [17:26:52] jgonera: re bingle, that's expected :) i sent an email about it last night [17:27:06] hee [17:27:08] whee [17:27:25] awjr, ok, just wanted to be sure ;) [17:28:12] :) [17:28:33] if everything goes according to plan, it should be low volume from now on; this is just the initial import [17:28:49] [android-commons] brion pushed 20 new commits to master: http://git.io/PlG2Iw [17:28:49] android-commons/master 58e4839 Brion Vibber: Work in progress: Category class and content provider... [17:28:49] android-commons/master 0e23531 Brion Vibber: Tweak column order...? [17:28:49] android-commons/master fd1de3c Brion Vibber: Stub adapter for the recent cats view... [17:29:18] brion_: err, you merged? :| [17:29:27] aaaagh [17:29:29] pushed the wrong button sorry [17:29:32] meant to do that on ios [17:29:45] i give up on today [17:29:48] this is just not my day :P [17:29:48] heh :) [17:29:56] was it at least ht elatest pull req? [17:30:06] yeah [17:30:06] yes :) [17:30:07] it was [17:30:47] Project Android-Commons (mobile) - Nightly builds build #154: SUCCESS in 2 min 6 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/154/ [17:30:47] * Brion VIBBER: Work in progress: Category class and content provider [17:30:48] * Brion VIBBER: Tweak column order...? [17:30:48] * Brion VIBBER: Stub adapter for the recent cats view... [17:30:49] * Brion VIBBER: Add XML/manifest bits for internal category content provider [17:30:49] * Brion VIBBER: Drop Parcelable interface, not needed [17:30:50] * Brion VIBBER: Initial stab at pulling cats from content provider [17:30:50] * Brion VIBBER: Work in progress: hook up content provider for recent cats [17:30:51] * Brion VIBBER: Add DB updaters for Category table [17:30:51] * Brion VIBBER: Categories now save :D [17:30:52] * Brion VIBBER: Use a single content provider client for all cat queries [17:30:52] * Brion VIBBER: Show used cats in MRU order [17:30:53] * Brion VIBBER: Use query conditions for the name lookup :D [17:30:53] * Brion VIBBER: Limit view of recent cats to 20 [17:30:54] * Brion VIBBER: Use same limit for recent cats and cat search [17:30:54] * Brion VIBBER: Hide the "skip" message if we load up some recent cats [17:30:55] * Brion VIBBER: Fixups per Yuvi's notes [17:30:55] * Brion VIBBER: Remove generic update from categories provider [17:30:56] brion_: so it still flashes the welcome text once [17:30:59] before showing the list [17:31:27] brion_: for like half a ms :) [17:31:32] err [17:31:33] half a sec [17:31:35] or something like that [17:31:46] brion_: we should hide it in the XML and show it only when there is no entries [17:31:52] rather than hide it everytime there is soemthing [17:32:02] YuviPanda: hmmmm yeah that probably makes sense [17:32:13] yeah, the flashing is distracting [17:32:25] ragesoss: around? [17:32:31] yes [17:32:44] [Commons-iOS] brion pushed 19 new commits to master: http://git.io/nkHRaQ [17:32:44] Commons-iOS/master 419395e Monte Hurd: Partial implementation of external browser setting... [17:32:44] Commons-iOS/master 4ce326f Monte Hurd: More progress on selectable browser... [17:32:44] Commons-iOS/master a8898d4 Monte Hurd: Adjusted settings page layout a bit [17:33:29] I wonder if we could get unit tests on iOS running automatically in jenkins… i'd have to set up a spare Mac somewhere I guess :) [17:33:32] ragesoss: up for testing? [17:33:32] will think about that in future [17:33:37] sure [17:34:14] ragesoss: https://integration.wikimedia.org/nightly/mobile/android-commons/android-commons_latest.apk [17:34:23] brion_: also, what was the issue with search? [17:34:45] ragesoss: it has better UI for reusing recently used cats, courtesy brion_ :) [17:34:47] do test it out! [17:34:54] \o/ [17:34:59] i think i didn't break it too bad [17:35:02] only a little yuvi said :) [17:35:19] :D [17:36:20] YuviPanda: time for us to try a release later today or should we just do it tomorrow morning my time (so we have time to fix it if it breaks)? [17:37:05] brion_: hmm, when will you be back? [17:37:17] the bus ordeal has left me in bad shape, and i'll probably head to sleep soon [17:37:22] depends how long the lines at the store are... [17:37:27] ok i'll just catch you tomorrow then [17:37:35] alright [17:37:49] brion_: can we fix the flashing before the release? :D [17:39:06] yes we can [17:39:13] if you don't do it now i'll do it later today [17:39:29] brion_: i'll leave that to you and go finish up the patch i've been working on :) [17:43:30] it only works on categories you've used in the app? [17:43:34] ok :) [17:43:53] I encountered another phantom keyboard, btw, Yuvi. [17:43:53] YuviPanda: ok i'm wandering off, i should still be online on my phone if you need to poke me about anything, i just won't be able to code it up yet :D [17:46:48] YuviPanda: recent cats UI works nicely. [17:48:06] YuviPanda: when will over-writing be disabled? [17:49:24] ragesoss: good question [17:49:28] i don't know. [17:49:47] YuviPanda: the phantom keyboard I found was, I think, from the rename-individual-file-during-multiupload view. whatever it was, it was there after I pressed 'back' in the categorization input view. I could press keys, but to no effect. [17:50:50] New patchset: Jdlrobson; "Alpha: Talk page - allow access to lead section conversation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59559 [17:50:50] New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [17:51:27] well, I found out that you can overwrite the same file during a multiupload, if you manually rename to the same name as another file. [17:51:28] https://test.wikipedia.org/wiki/File:Queasy_-_3.jpeg [17:51:47] which I guess is not really a bug in and of itself. [17:55:12] hmm... can't figure out how to replicate that phantom keyboard. [17:57:01] New patchset: Jdlrobson; "Story 425: Nearby preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [17:57:01] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [17:57:01] New patchset: Jdlrobson; "Regression: Don't attempt to load special and main pages via api" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60887 [17:57:02] New patchset: Jdlrobson; "Simplify enable sections if statement" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60888 [18:10:25] ragesoss: hmm, i can't repro it either [18:10:38] ragesoss: how's categories looking? [18:11:04] good [18:16:01] brion: 15ft hdmi extension cable is on your desk [18:17:36] woohoo [18:18:00] that should be plenty for demos :) [18:24:11] Maryana: awjr are we still okay for moving the bug hunt out by 1 hour [18:24:20] jcmish: yeah works for me [18:24:20] jcmish, works for me! [18:24:23] jinx [18:24:28] HAHAH [18:24:32] that was AWESOME [18:24:51] k thanks just wanted to make sure before I got all heads down [18:27:30] tfinc: responded on PM [18:32:41] w00t, thanks for updating mobile web limn graphs, yuvipanda and jgonera! [18:32:58] all credit to jgonera Maryana [18:33:08] you reviewed :) [19:06:09] yurik, going for lunch, be back online in 30 minutes or so [19:06:43] lol, DR is quick - disappears immediately upon notification :) [19:23:15] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60579 [19:27:18] YuviPanda: i'm back :) [19:27:24] woohoo :) [19:27:41] they gave me bad directions to the VIP area and there were a billion people in the regular line so I didn't actually get in the MS store [19:27:50] but I saw it, and now I can order things online ;) [19:27:54] brion_: wanna talk about what UI problems you ran into the for search? [19:27:59] sure [19:28:11] brion_: ah! didn't you flash your 'I have a Wikipedia Holiday named after me' card/ [19:28:11] YuviPanda: so the main problem was that it looked weird and flashy [19:28:11] ? [19:28:18] hah [19:28:25] oh i even had a badge [19:28:28] :D [19:28:34] they were just all confused themselves. :) [19:28:41] :D [19:29:15] brion_: what do you mean by 'weird and flashy'? [19:29:19] it was... too fast? :P [19:29:34] so normally you have a list of items from your last search [19:29:41] then you type something, and it starts a new search [19:29:46] right [19:29:50] and after a second, magically your old results turn into new results [19:29:58] so with the double search, what i was seeing was: [19:29:59] right [19:30:07] * immediately on typing, most of the results disappear [19:30:16] * after a second, the results list gets big again [19:30:32] it looked wrong to me :( [19:30:48] hmmm so i think we need to do a little bit of additional work here [19:30:51] how i think it should be is [19:30:55] 1. you start typing [19:31:07] 2. categories in the *currently displayed list* that also match what you typed stay [19:31:24] 3. this is mixed with search results from the local storage [19:31:35] 4. all this while a spinner keeps spinning util our remote request finishes [19:31:51] 5. we can avoid flashing by making sure to *not* remove current items until we have (2) and (3) calculated [19:31:58] that should work, no? [19:33:22] brion_: ^ [19:33:38] hmmm, that could work [19:34:19] brion_: so that'll avoid the flashing since it will look like we are merely clearing out some items rather than killing everything and adding some new ones [19:34:38] and once you have uploaded enough pictures you'll get most of your results from the local one anyway ;) [19:34:54] brion_: we should also be doing (2 & 3) and (4) on different threads [19:35:07] brion_: that means they should be different asynctasks running on different executors [19:35:15] (easiest way) [19:37:03] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60579 [19:37:06] yeah [19:37:32] brion_: sweet :) [19:37:43] brion_: i'll get the two cards assigned to me done by tomorrow [19:37:53] what i had initially done was split CategoriesUpdater into an abstract base with the UI and two subclasses with the different logic, but i'm not totally happy with that either since they can bump over each other [19:37:55] brion_: and we can do a release early tomorrow morning your time :) [19:38:09] probably want to separate out the ui update [19:38:56] brion: it makes sense to have asynctasks as inner classes inside the places where they are used [19:39:01] brion: since they get access to the instance variables [19:39:08] yeah [19:39:17] they were still inner classes :) [19:39:19] brion: I've tried seperating things out before (specifically what goes on in the Login ones) [19:39:23] and that never works right [19:39:24] ah, okay :) [19:39:52] either way, I've found that 'do it the easiest way, and if it feels ugly then refactor' works for me [19:39:55] and more importantly [19:40:03] prevents me from accidentally creating factoryfactories :P [19:40:06] is there a handy inter-thread messaging system where i can post 'this is done' and have it pick up in the main thread? or should i just use the onPostExecute of the AsyncTask for that [19:40:10] hehe [19:40:27] brion: so, onPostExecute is the easiest way [19:40:31] brion: and I suggest you use that [19:40:49] brion: but you can also execute things on the main thread by 'post'ing (there are a bunch of methods starting with post on each view) [19:40:54] a Runnable() [19:40:59] but onPostExecute is IMO cleaner [19:41:05] since it is consistent [19:41:10] and easy to track [19:41:27] yeah i'll stick with that [19:41:58] :) [19:43:20] brion: i'm going to go sleep off being squished. I'll be available tomorrow as well, since I didn't get too much done today. [19:43:32] brion: anything you want before I go? [19:45:47] ok [19:45:51] nope i'll poke you tomorrow :D [19:45:56] brion: sweet :) [19:46:02] sleep well [19:46:09] do not dream of buses [19:46:13] i'll try [19:46:13] :) [20:00:31] awjr, jcmish, just getting r31 set up [20:00:47] np Maryana [20:00:56] by which i mean chip is getting r31 set up [20:00:58] ;) [20:01:01] jgonera: was it you that i was talking with recently about compatibility with different versions of MW in MobileFrontend? [20:01:23] awjr, I don't recall anything like that [20:01:33] maybe it was jon [20:02:22] mhurd: so here's the error schema: https://meta.wikimedia.org/wiki/Schema:MobileAppUploadAttempts [20:14:57] MaxSem: I have an instance that I configured by hand to reproduce the EventLogging setup on labs [20:15:13] hmm [20:15:36] it's not puppetized, but I could add you to the project and hand over the instance to you so you can either a) use it for your purposes, or b) see how to configure a dinky self-standing varnish instance for simulating the event.gif endpoint. [20:16:20] but in general it's pretty much OK to just log to the production instance from your dev wiki. Just be sure $wgDBname is set to something clearly non-production-y. [20:17:05] o_0 [20:18:32] you're not the first person to be surprised by that, and you won't be the last to be eventually mollified and satisfied that it's sane after i spend an hour explaining in detail the rationale for things being configured the way they are :) [20:19:51] I don't want to discourage you from doing extra puppet work that makes it simple to provision labs instances -- that would be awesome to have for all sorts of purposes. But if you're trying to work through some immediate issue, let me know and I can try and help come up with an easier solution. [20:19:59] ori-l, maybe i will bug you at some point to instrument api logging in a better way :) [20:20:33] ori-l, logging to prod is not an option because the deployment cluster has the same DB names as prod [20:22:09] OK, let me get the useful varnish configuration bits from the labs instance [20:23:47] yurik: bug me now :P [20:30:08] ori-l, nah, need to take care of a few other things, like getting the new zero config. Let me know when you can look at it ;) [20:37:46] Maryana: i'm looking at the app blog post now [20:39:07] New patchset: JGonera; "Alpha: Allow searching from special page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59636 [20:39:39] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59636 [20:39:39] brion: mhurd zz_YuviPanda : i think its coming to the time to take beta off the commons android app [20:39:45] \o/ [20:39:53] :) [20:39:58] mhurd: brion : i can't believe wwdc 2013 sold out in two minutes [20:40:05] haha [20:40:10] crazy [20:40:13] it's like san diego comic con man [20:40:19] ain't nobody can get in anymore [20:41:47] at least their servers stayed up unlike googles for i/o [20:42:20] does Yuvi have any stock photos for the android app ? i'm looking to add some screenshots to the blog post Maryana wrote [20:43:15] tfinc_: there should be the screens we have in the store at least [20:45:09] brion: yeah, too bad the android market doesn't allow me to download the high quality assets back. i'll just take some new ones [20:45:17] bah [20:45:56] that's why i try to keep the sample images in source control, so we can reuse/resubmit them if necessary [20:46:04] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59723 [20:46:12] but we ain't got em in the android one [20:51:29] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60339 [20:55:04] brion: mhurd added an easy bug to the current backlog for android https://trello.com/card/android-bug-47688-commons-app-should-provide-a-visual-during-first-sync/51756be77b9586a0780053c0/55 [20:55:23] ah good one [20:55:40] might be an easy one for mhurd to jump into [20:55:53] spinner, text, etc. anything but a black screen [20:55:59] :) [20:56:06] i'm sure vibha would have ideas [20:58:42] :) [21:02:36] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58994 [21:04:52] New patchset: JGonera; "Change remaining #mw-mf-header occurrences to .header" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60919 [21:07:21] yurik, for change 60775, other than setting the following settings in LocalSettings.php, creating a page Zero:413-02 on the local instance with the data from SampleConfigPage.json, and forging the X-CS header to 413-02, what else do you need to do to get the banner to render on http://localhost:8080/wiki/Main_Page?useformat=mobile [21:07:23] require_once("$IP/extensions/MobileFrontend/MobileFrontend.php"); [21:07:24] $wgZeroRatedMobileAccessConfigIndexUri = 'http://127.0.0.1/w/index.php'; [21:07:25] $wgZeroRatedMobileAccessDisableCache = true; [21:07:26] $wgEnableZeroRatedMobileAccessTesting = true; [21:07:27] require_once("$IP/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.php"); [21:08:03] dr0ptp4kt, sec [21:08:09] yurik, cool [21:09:26] dr0ptp4kt, i'm not sure if that's important, but i think you should "require" before setting the values [21:09:46] $wgEnableZeroRatedMobileAccessTesting = true; [21:09:48] yurik, tried that. one sec, will try again [21:11:08] yurik, no luck with require_once("$IP/extensions/MobileFrontend/MobileFrontend.php"); [21:11:08] require_once("$IP/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.php"); [21:11:10] $wgZeroRatedMobileAccessConfigIndexUri = 'http://127.0.0.1/w/index.php'; [21:11:11] $wgZeroRatedMobileAccessDisableCache = true; [21:11:12] $wgEnableZeroRatedMobileAccessTesting = true; [21:11:25] yurik, no luck with the following: [21:12:23] dr0ptp4kt, there is one more -- $wgZeroRatedMobileAccessEnableZeroConfigPages [21:12:34] set to true [21:12:43] it will need to be set on meta [21:13:16] yurik, irc broke down on me. [21:13:23] i updated LocalSettings.php to the following: [21:13:27] require_once("$IP/extensions/MobileFrontend/MobileFrontend.php"); [21:13:28] require_once("$IP/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.php"); [21:13:29] $wgZeroRatedMobileAccessConfigIndexUri = 'http://127.0.0.1/w/index.php'; [21:13:30] $wgZeroRatedMobileAccessDisableCache = true; [21:13:31] $wgEnableZeroRatedMobileAccessTesting = true; [21:13:51] dr0ptp4kt_, did you add the $wgZeroRatedMobileAccessEnableZeroConfigPages ? [21:14:34] yurik, nope. one minute [21:14:55] WhyAreTheseVarsSoRidiculoyuslyLongThatMyBrainSwellsWhnITryToReadThem [21:15:26] MaxSem, learn to love long variables! :) [21:15:37] BECAUSEALLCASESMAKESTHEMEVENHARDERTOREAD [21:16:12] $var10123 is far easier to read and type [21:16:56] MaxSem, we just need to use bit.ly codes for variable names [21:17:33] and submit patches via Twitter! [21:17:44] ha [21:19:54] dr0ptp4kt, success? [21:20:02] yurik, not yet [21:20:43] New review: JGonera; "There is still a problem with the star. There are two elements with class "watch-this-article", whic..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58997 [21:20:54] dr0ptp4kt, how about now? [21:21:04] yurik, HA! [21:22:03] New review: JGonera; "Argh, gerrit!" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997 [21:22:57] oh sweet, thanks for getting those pics into the apps blog post, tfinc! [21:23:00] are they yuvi's? [21:23:35] yurik, which headers do you have forged on your system? [21:24:11] dr0ptp4kt, the zero editor works without any headers [21:24:29] actually i think you should disable zeroratedmobileaccesstesting [21:24:35] ok, lemme try that [21:25:18] dr0ptp4kt, actually no [21:25:19] sorry [21:25:21] i have it on [21:25:45] but if you edit any Zero:XXXXX page, it should show you an editor [21:26:00] ohh, btw, make sure you get code editor extension :) [21:26:11] not a must have, but looks soo much nicer :) [21:26:23] but that's optional [21:27:48] dr0ptp4kt, what do you see when you edit and try saving a Zero:555 page? [21:27:59] put some junk there [21:28:06] yurik, installing CodeEditor right now [21:28:12] yurik, uno momento [21:28:17] dr0ptp4kt, don't worry about it [21:28:23] its a "nice to have" [21:28:30] but shouldn't be required [21:28:34] see if it works without it [21:29:07] code editor adds a nicer editor interface, but not for visualizer or validation [21:29:37] Maryana: one yuvi one brion [21:29:45] http://127.0.0.1:8080/w/index.php?title=Zero:555&action=edit gives me a standard editor. about to try to load bad data into it. [21:29:55] ok, try that [21:30:01] just put any random text [21:30:02] and save [21:30:04] yurik, "Unable to parse JSON configuration. Please check the syntax. " [21:30:05] yay [21:30:10] yei!!!!! [21:30:25] we may have room for one more. three is the max that ive seen for well formed blog posts [21:30:28] yurik, now it's a matter of getting the content to render to me like i'm on a partner network :) [21:30:31] \o/ [21:30:39] dr0ptp4kt, hold on [21:30:46] first copy/paste zero config sample :) [21:30:51] yurik, jumping on a google chat first [21:30:53] and see how it renders once saved [21:30:57] yurik, i did that, actually [21:31:02] aaand? [21:31:44] yurik, gotta run, will get back to you on that [21:31:54] ok, let me know [21:32:05] (the suspense is killing me) [21:45:16] yurik, i had another disconnection [21:45:19] yurik, you there? [21:45:24] dr0ptp4kt, yep [21:45:34] but about to take off for a bit [21:45:45] k, i just emptied the array so it was an empty array [] and that stopped it from whining at me [21:46:07] yurik, okay, you know what time you'll be back around? [21:46:48] dr0ptp4kt, so did it accept the json that you gave it? [21:48:04] yurik, so sorry, my dhcp lease expired. here's what i just sent: [21:48:13] dr0ptp4kt [21:48:13] : k, i just emptied the array so it was an empty array [] and that stopped it from whining at me [21:48:14] [2:46PM] dr0ptp4kt: yurik, okay, you know what time you'll be back around? [21:48:15] [2:46PM] dr0ptp4kt: yurik, trying to plan out remainder of day [21:49:45] dr0ptp4kt, i got all of that [21:50:25] dr0ptp4kt, but what did you see when you saved it? [21:50:42] yurik, cool. sorry, i' missed whatever may have come after that [21:53:05] dr0ptp4kt, ok, so can you try saving some sample json? [21:53:56] yeah, it seems to do the trick in the standard editor. i think we'll want to look at the code to make it treat a missing element the same as an empty array in the case of whitelistedLangs. [21:54:55] dr0ptp4kt, not for langs - "all" must be an explicit setting [21:55:06] not just accidently missed [21:55:08] yurik, AHA [21:55:32] yurik, i hadn't looked at that section of code closely yet, but i'll double check some of these validations so that the data is populated correctly into meta-wiki. [22:02:09] yurik, the banner's working. [22:04:02] yurik, the banner is rendering now. gotta get my debugger working nicely between host and guest (started down that path using your article, but the adapters weren't playing nicely), because i would have got that more easily as being a parser syntax problem before. [22:04:22] dr0ptp4kt, ok, let me know if you run into an issue [22:04:27] yurik, NOW i can more confidently get into the code :) [22:04:36] got to take off for a bit [22:04:38] yurik, you are free to go out for a beer now :) [22:05:17] hehe [22:05:20] l8r [22:05:24] peace [22:16:05] brion: mhurd same issue on iOS on first login. do you guys want another bug/story ? [22:17:28] tfinc_: yeah it'll be a different impl [22:18:30] brion: mhurd : really nice job with the responsiveness of the iOS UI [22:18:37] \o/ [22:18:49] woohoo! [22:21:49] brion: mhurd : i'd like to get a regular cycle of test releases for us. what's been the cadence so far ? [22:21:53] pretty ad hoc right ? [22:22:19] pretty ad-hoc yeah [22:22:27] can do weekly, or twice weekly [22:23:30] how about one every iteration [22:23:33] that puts it on a two week cycle [22:23:40] and aligns pretty neatly with our process [22:23:43] ok [22:23:58] should we try to push updates to apple on that cadence? [22:24:04] they'll always be at least a few days behind [22:24:58] i think the apple pushes should as we are ready [22:25:20] given apples track record for approvals getting anything predictable is impossible [22:25:34] id say that we should budget 3 weeks for any apple review [22:25:40] mhurd: thoughts ? [22:25:40] heh [22:26:21] Maryana, i feel entirely braindead after that [22:26:21] i think yuvi was releasing them even faster given that the play store is far nicey [22:26:35] * tfinc_ passes awjr a virtual beer  [22:26:47] * awjr gulps it down [22:27:07] * tfinc wonders what the abv is for virtual beer  [22:27:19] tfinc: clearly you have learned that if popeye was me, beer would be his spinach [22:27:58] virtual beer wouldn't have the same gravity issues as real beer [22:28:03] or more clearly, if i were popeye, beer would be my spinach [22:28:03] yup [22:28:25] yeah, how do you measure digital specific gravity? [22:28:42] i guess you'd have to compare 0's and 1's before and after digital fermentation [22:29:27] and hope that no wort packets were lost [22:33:57] brion: can't seem to reproduce that magical file name issue [22:36:21] have to disappear for ~1hr, maybe less [22:36:32] ok jgonera, thanks for the heads up [22:38:15] hahaha tfinc - wort packets [22:41:11] Maryana: i'm finding http://mobile-reportcard.wmflabs.org/ harder to explain to people since its not month to month [22:41:17] what do you think about switching it over? [22:43:23] [Commons-iOS] montehurd opened pull request #50: Logging upload cancellations (master...logUploadCancellations) http://git.io/0yxJoQ [22:46:23] [android-commons] brion opened pull request #10: Fix flash of descriptive text before recent cats shown (master...flash-text) http://git.io/jgM11A [22:49:49] brion: mhurd looking over http://etherpad.wikimedia.org/mobile-q4-planning-2013 i'm really eager to start pushing on campaigns [22:49:56] wheeee [22:49:58] for this quarter [22:50:03] we haven't made much progress on it due to design [22:50:08] but i think we can move past that [22:54:23] [Commons-iOS] brion pushed 3 new commits to master: http://git.io/M5uNgQ [22:54:23] Commons-iOS/master 366c8c3 Monte Hurd: Logging upload cancellations... [22:54:23] Commons-iOS/master ae21661 Monte Hurd: Changed constant name to be more accurate [22:54:23] Commons-iOS/master b4dca90 Brion Vibber: Merge pull request #50 from montehurd/logUploadCancellations... [22:54:56] tfinc: would it make more sense to have a 'Mobile web' section in the engineering report rather than 'mobile web photo upload'? i think it would be easier to capture our work over the last month that way, but perhaps it's already organized in this way for some reason im not aware of [22:57:05] do it [22:57:58] tfinc what do i need to do to make that happen? [22:58:05] talk to guillaume? [22:58:06] edit the page [22:58:28] well [22:58:33] each item corresponds to a project page [22:58:42] we did away with team project pages a couple of years ago [22:58:47] and focused on projects instead [22:59:13] hmm [23:00:03] eh [23:00:23] well, maybe i'll ping guillaume and see what he thinks is sensible [23:00:31] k [23:00:39] but does this mean we should be creating new pages for every project we embark on (like our performance improvements?) [23:01:15] only the ones that need broad community visibility [23:01:28] like uploads which is one of our annual goals [23:01:37] others can be under a different umbrella [23:01:58] yeah that makes sense, but then it becomes difficult to categorize the other things (even like the experimental stuff you brought up in the email thread) [23:02:26] guillaume can help figure it out :) [23:02:45] tfinc, re: limn, yeah, you're right, most of those graphs would make a *lot* more sense as a month-to-month report. will create a story for that. [23:02:53] thanks [23:03:18] brion: will the upload cancellations appear in limn? [23:04:29] mhurd: if there's a graph for it... [23:04:35] … i leave those to yuvi so far :) [23:05:28] brion: ah thx [23:09:34] brion: thinking about tackling "Fix uploads list for >500 uploads" card [23:09:46] nice [23:09:57] quick question when u have a sec [23:12:34] mhurd: can you respond on climber@ to say that your coming tonight ? [23:12:46] tfinc: ya [23:38:04] jgonera: you back? [23:38:09] yes [23:38:37] i noticed a bit ago that we're hurting for code review [23:38:46] particularly front-endy stuff :) [23:39:18] can you help work through some of it when you're at a good point for a context switch? [23:39:23] awjr, I know, I did some today, but the problem is that it's a vicious circle, if I keep doing code review without giving Jon anything to review, then he's only writing code and I'm only reviewing [23:39:39] I'll review a few commits more later [23:39:45] yeah, i've fallen into that trap before too [23:39:48] thanks jgonera [23:40:12] just so long as it's on your radar; i'll be working through the backlog tomorrow [23:42:54] * adam forehead slaps after putting xdebug statements in global index.php that borks &action=raw