[00:10:10] mhurd: brion : what made you guys go with the solid white background for the config settings ? [00:11:15] its looks pretty jarring compared to the rest of the ui [00:13:20] hadn't gotten around to adding logo yet :) [00:13:27] easy fix [00:13:38] i'll add a story card [00:13:42] cool [00:14:22] Maryana, am I doing something wrong or is editing currently broken in production? I can't unfold sections [00:14:54] hmm.. [00:14:57] * Maryana checks [00:16:13] jgonera, you're right [00:16:39] ok [00:16:40] i tapped edit and it only opened the first 3 sections of the page [00:17:02] are you working on the editing spike? :) [00:17:19] yes [00:18:02] would we still want to keep the full-page edit with various textareas for each section if we had section-level editing? [00:18:46] i think section-level editing would zoom into the section in question [00:19:25] with maybe the ability to open up the previous and next sections... [00:19:34] but generally i think if you select a section to edit, you should just see that section [00:19:45] I see [00:20:29] mainly i want to avoid the weird mix where you're seeing something kind of half in edit mode and half in read mode [00:33:03] ori-l, have you used CustomEditor hook to make the edit page for EL schemas look different? [00:34:23] jgonera: I used CodeEditor and added a handler for 'CodeEditorGetPageLanguage', but I forget the exact mechanics of how it works [00:34:37] ok, thanks [00:34:44] jgonera: I think the change itself happens within CodeEditor if you indicate that the page language is one that it is configured to activate for [00:35:12] I'll have a look at CodeEditor's source [00:53:04] Maryana, do we need to replace the page that is shown when action=edit is present in the URL or is it enough if we provide a nicer editor e.g. in an overlay? [00:57:55] do you mean when users add &action=edit to the url, jgonera? [00:57:58] or..? [00:58:04] yes [00:58:36] or when they simply open this page by clicking a link sent on messenger or somewhere [00:59:02] or could we just ignore that page, or make it redirect back to the article and provide an editor in an overlay [00:59:05] ahh, right. that's going to happen if they click on a red link (nonexistent) page. [00:59:13] hm [00:59:16] [Commons-iOS] montehurd opened pull request #51: Trigger sync on 1st load after delete & re-install app (master...initialSync) http://git.io/oIsmJg [00:59:23] we can replace that link too [00:59:52] it seems like letting people go right to edit mode on mobile is a bad idea [00:59:57] it's much easier to screw something up [01:00:27] what do you mean by "right to edit mode"? [01:01:29] hm, maybe I'll just concentrate on technical things now and I'll try to explain my vision better tomorrow by the whiteboard ;) [01:01:36] i mean being taken straight to the editing interface [01:01:41] hehe, ok [01:01:56] IRC is not so great for design discussions [01:02:05] unless you're very talented in ascii [01:02:10] we're not redirecting them now straight to edit page now [01:02:27] right. i'm saying i don't think we should do it even in an overlay [01:02:30] what I mean in general, that the "edit" link, instead of going to an edit page would open an edit overlay [01:02:49] mhm [01:02:56] ok, we'll talk tomorrow ;) [01:03:06] deal [01:03:56] kaplan appears to be having some sort of cajun themed party [01:04:01] Maryana: bingle's on auto pilot now, seems to be working. i have it set to run every hour, but maybe will relax it to run once a day once i have a little more confidence in the whole thing [01:04:12] i know; i've been getting all the notifications [01:04:14] :) [01:04:15] i always wanted to go check out their shindigs [01:04:18] lol [01:04:21] sorry for the spam :p [01:04:23] they're blasting zydeco [01:04:27] cajun themed party? I only know more or less what cajun means in terms of food, but not parties [01:04:40] hey, you went to my cajun party, jgonera! [01:04:43] you guys should go check it out [01:04:50] or did you have such a good time that you don't remember? ;) [01:05:33] so... cajun party is a party with gumbo? can you smell gumbo through the ceiling? [01:06:00] not sure if gumbo or someone's lunch from earlier [01:06:08] ;) [01:07:16] ok, i think this means it's time to go [01:07:22] goodnight, kids! [01:42:40] 'night everyone [01:48:59] New patchset: JGonera; "Make sure anonymous users can't edit on mobile (#463)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60956 [02:20:52] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [03:08:47] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60692 [03:10:32] New review: JGonera; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60956 [06:16:28] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58994 [07:53:37] New patchset: Raimond Spekking; "Remove deleted special page from alias file." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60967 [07:54:28] New review: Raimond Spekking; "Deleted special page removed from alias file with I09d0ea416796d92ff9d0ec24eb1f3581fb372f51" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60339 [12:26:06] New patchset: Zfilipin; "Fixed failing search test" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60990 [12:31:12] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/AoZ39g [12:31:12] android-commons/master c37b185 Brion Vibber: Fix flash of descriptive text before recent cats shown... [12:31:12] android-commons/master 6a7b0c9 Yuvi Panda: Merge pull request #10 from brion/flash-text... [12:32:00] Project Android-Commons (mobile) - Nightly builds build #155: SUCCESS in 56 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/155/ [12:32:01] Brion VIBBER: Fix flash of descriptive text before recent cats shown [12:33:50] New review: Zfilipin; "No failures:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60990 [12:37:08] New patchset: Zfilipin; "Fix given/when/then format" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60991 [12:45:39] New patchset: Zfilipin; "Do not check anything in a "given" step" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60992 [13:28:19] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/UbgMmg [13:28:19] android-commons/master ce1934d YuviPanda: Disable menu items for share and open browser when upload incomplete... [13:29:37] Project Android-Commons (mobile) - Nightly builds build #156: SUCCESS in 1 min 30 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/156/ [13:29:38] yuvipanda: Disable menu items for share and open browser when upload incomplete [15:44:40] * SlowPanda glares at his DNS server [16:27:35] New patchset: MaxSem; "MF part of code that forbids legacy gadgets in mobile view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61028 [16:45:23] New patchset: Zfilipin; "Fixed watchlist tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61030 [16:46:53] New patchset: Zfilipin; "Fixed watchlist tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61030 [16:48:28] * DnsServer glares back at YuviPanda [16:48:41] YOU WEREN"T WORKING! [16:49:10] YuviPanda, if it made the humming noises, it counts as working :P [16:49:23] it's in a data center far far away, so I can't really hear it [16:49:52] a self-respecting DNS server should be heard everywhere [16:50:04] o.O [16:51:30] legoktm obviously listened to the DNS server [16:52:30] I just saw the nick change and bet it was this channel :P [16:58:11] heh [16:58:14] hello brion [16:58:19] yo [16:58:21] yurik: looks like the channel is gaining a reputation ;) [16:58:26] slept later than i expected :) [16:58:31] heh [16:58:45] i merged the PR [16:58:50] when do you want to do the testing + release? [16:58:53] are you at th eoffice? [16:59:42] YuviPanda, this channel always has a reputation... not sure of the kind of reputation, but reputation nevertheless. [16:59:52] hehe :P [17:00:08] YuviPanda: i'm flying down to visit my parents this evening and have bunches of errands to catch up on so i'm at the home office [17:00:12] brion, its alright, its 10pm, and almost noone is awake anyway [17:00:13] let's do the test/release after the call [17:00:24] brion: oooh, okay ;) [17:00:57] i've also got a windows phone 8 device on the way to play with :) [17:01:03] fast shipping, i only ordered it yesterday [17:01:11] makes me wonder why they bothered opening a microsoft store in the mall ;) [17:02:05] dr0ptp4kt, i updated error checking last night [17:02:29] so now it swears at you in russian if you use private IP [17:03:01] i got sick of testing WP8's IE in the SDK emulator since I have to run it on the least convenient device I have available (wifi's broken) [17:03:28] brion: hey brion. finished the initial sync trigger stuff before i left yesterday - should be a pull req [17:03:52] great, i'll take a peek [17:04:13] also, FRIDAY! :) [17:04:14] \o/ [17:05:00] brion: :D [17:05:02] that was indeed fast [17:05:18] yes. had too much fun this week [17:05:31] :) [17:05:38] i'll have catching up to do on Android when i'm back [17:07:29] hmm.. looks like the Dr is having network issues again :) [17:09:06] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/FbnBhw [17:09:06] Commons-iOS/master b99dad4 Monte Hurd: Trigger sync on 1st load after delete & re-install app... [17:09:06] Commons-iOS/master 4d993c7 Brion Vibber: Merge pull request #51 from montehurd/initialSync... [17:09:09] whee [17:12:38] has anyone heard of a good PHP library to handle ipv4 & v6 CIDR blocks? [17:13:29] yurik: check what's already in mediawiki for dealing with ip range blocks, there might be some goodies already hiding [17:13:59] brion, in the core? [17:14:43] yurik: yeah and/or CheckUser [17:15:02] MaxSem: can you comment on and close https://bugzilla.wikimedia.org/show_bug.cgi?id=47636 ? [17:15:18] and https://bugzilla.wikimedia.org/show_bug.cgi?id=47462 [17:15:53] done [17:15:57] thanks dude! [17:16:36] awjr, what to do with https://mingle.corp.wikimedia.org/projects/mobile/cards/746 ? [17:16:51] MaxSem: stick it in 'ready for signoff' [17:24:10] whee [17:24:35] brion: test on 2.3? [17:26:04] crap i left the 2.3 devices at the office [17:26:12] brion: yay! :) [17:26:12] i'll fire up an emulator [17:26:20] brion: yay merge :) [17:26:28] i should just toss the nexus one in my bag so i've consistently got it handy [17:26:29] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/Z8eQ8Q [17:26:29] android-commons/master d9b19fd YuviPanda: Added patch file that can be used to make app upload to commons [17:26:38] ooh handy [17:26:38] brion: aw damn :( [17:26:43] brion: i've a 2.3 device but [17:26:46] and so does ragesoss :P [17:27:05] ragesoss has everything to stress-test us :) [17:27:19] * YuviPanda pokes ragesoss [17:27:26] ohai [17:27:44] Project Android-Commons (mobile) - Nightly builds build #157: SUCCESS in 1 min 28 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/157/ [17:27:44] yuvipanda: Added patch file that can be used to make app upload to commons [17:27:59] ohai, weilder of the 2.3 :) [17:28:23] YuviPanda: ok i can confirm the flashing during first sync bug occurs in the 2.3 emulator for me too [17:28:27] so if we want to fix that quick i can test [17:28:36] brion: so it doesn't flash only during sync [17:28:41] uhoh [17:28:43] it's a known bug for a while now [17:28:48] i spent a couple of days on it an iterationb ack [17:28:51] and gave up [17:28:51] :( [17:29:00] simplest solution might be to just turn off the fade-in effect on 2.3 [17:29:02] brion: https://bugzilla.wikimedia.org/show_bug.cgi?id=45391 [17:29:09] brion: that's not a solution :) [17:29:16] hehe [17:29:20] as in [17:29:22] that doesn't work [17:29:22] :P [17:29:24] oh [17:29:26] brion: the problem is *not* the fading [17:29:43] is it just that it's regenerating the grid cells? [17:29:51] not that either :P [17:29:51] so [17:30:00] we're not supposed to change the image in a list item [17:30:05] if the previous image is the same [17:30:13] dr0ptp4kt, are you back? [17:30:19] mmm [17:30:21] just note that my 2.3 device is also my IRC server. [17:30:30] brion: so we store the image url as a tag and then check to make sure that we don't set it again if it is the same [17:30:35] so don't break it, or I can't report back on the breakage. [17:30:37] brion: for some reason that doesn't work on 2.3 [17:30:39] yurik, yup. sorry, dhcp lease expired, irc notified me i was offline, i reconnected [17:30:41] ah [17:30:42] did i miss anything? [17:30:43] ragesoss: :P [17:30:50] YuviPanda: the tag doesn't show up when we check it? [17:30:52] i'm looking at your validation code on ips [17:30:57] ^yurik [17:31:06] brion: nope. [17:31:08] brion: 'twas weird [17:31:10] boo [17:31:17] yurik, why you gotta go and write breaking tests first like a tdd-head? :) [17:31:22] brion: so the problem is that we reset the image to black everytime if it is not the same [17:31:31] brion: this is necessary, since listitems are cached [17:31:41] dr0ptp4kt, huh? [17:31:42] brion: and if we don't do it we'll get to see the cached images as we scroll [17:31:55] *nod* i've got a related bug on iOS with that kind of problem :) [17:32:03] brion: there are like only 4-5 listitems initiated overall, and they just keep getting reused (hence we can handle all of ragesoss's images without problems) [17:33:08] brion: so it's messy [17:33:16] brion: don't you have a fire that is 2.3? :P [17:33:20] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60967 [17:33:22] yurik, the sample configuration causes errors, proving it's working in the negative case. good! although this is behavioral functional testing that i'm doing at the moment, it reminds me of tdd style, also good. break, then fix, then run. it's good! [17:33:40] yurik, i saw the new cucumber book came out. if you're into that kind of thing, it's pretty sweet. [17:33:49] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60956 [17:34:23] YuviPanda: yeah it's also at the office. same bug on that and the nexus1 [17:34:30] heh [17:34:35] brion: anyway let's still do the release ;) [17:34:48] ok i'll do some debugging anyway while i'm here :D [17:34:50] brion: there's a RELEASE-CHECKLIST [17:36:23] dr0ptp4kt, :) haven't heard of it, but might have to take a look :) [17:36:25] so there's now a patch to do the url change right [17:36:27] yes i see it [17:36:40] yurik, cucumber is The Truth [17:36:49] dr0ptp4kt, btw, your script, are you doing it in two parts? one - to generate some master text file, and 2 - to upload it? [17:36:59] YuviPanda: anything like, say, bumping version numbers that needs doing? [17:37:03] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60919 [17:37:19] brion: yes [17:37:21] let me put that in that :P [17:37:25] :D [17:37:25] brion: in AndroidManifest.xml [17:37:49] dr0ptp4kt, yes, and pickle is the preserved truth [17:37:51] yurik, was planning to generate both in one fell swoop, but yes, will have it generate two parts. one monolithic CSV-style file is on my TODO, actually. [17:38:04] ^yurik drum-drum-cymbal [17:38:16] what's new: *no longer causes phones to explode [17:38:25] yurik, er drum-drum-hi hat [17:38:39] ragesoss: wheee! [17:38:54] New review: MaxSem; "This breaks cases where we specifically need MP-formatted HTML, e.g. API." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60888 [17:38:55] o_O [17:39:19] dr0ptp4kt, otherwise we should be ready to deploy ;) [17:39:54] brion: updated that [17:39:56] ok [17:40:21] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/2BbVBA [17:40:21] android-commons/master 2602f60 YuviPanda: Updated the RELEASE-CHECKLIST [17:40:24] yurik, i think this line is broken: if ( count( $parts ) > 2 [17:40:25] || false === filter_var( $parts[0], FILTER_VALIDATE_IP, $ipFlags ) [17:40:25] ) { [17:40:38] yurik, my breakpoint tells me so. [17:40:43] what IP are you testing it with? [17:40:58] in the editor, not as an end user [17:41:02] Project Android-Commons (mobile) - Nightly builds build #158: SUCCESS in 52 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/158/ [17:41:02] yuvipanda: Updated the RELEASE-CHECKLIST [17:41:12] as an end user, i'll use the 10. ip address in the editor [17:41:15] brion: i just noticed that images which no longer exist are still appearing in "my uploads" as a black square. hmm [17:41:35] yurik, oh wait, lemme look at that bitmask [17:41:35] dr0ptp4kt, you mean phpstorm is not green in CarrierConfig.php ? [17:41:43] mhurd: yeah we still have the upload records but we don't handle their being missing well [17:41:48] we'll have to add some handling for that [17:41:53] same issue on android [17:42:19] dr0ptp4kt, it will not allow any IPs in the private range (192.168, 10., ...) [17:42:21] yurik, i seems to be jumping out of that if, and thus rejecting an otherwise valid ips value of: [17:42:30] do you want to handle that server side? [17:42:31] "ips":[ [17:42:31] "192.168.0.0/24", "192.168.1.0/24", "192.168.2.0/24" [17:42:32] ], [17:42:39] exactly :) [17:42:39] yurik, and thus you answered my question [17:42:41] yurik, LOL [17:42:42] dr0ptp4kt, hehe [17:42:53] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/59560 [17:43:04] yurik, why you wanna use security so much? [17:43:06] !!! [17:43:07] :) [17:43:27] ragesoss: anything major? [17:43:33] that's not security - that's just invalid junk data that will never be used even in testing... I suspect [17:44:07] YuviPanda: huh? [17:44:13] was I supposed to have tested something? [17:44:14] ragesoss: in the app that is [17:44:28] well, just generally making sure that things don't blow up [17:44:34] yurik, fair enough :) this worked: "ips":[ [17:44:35] "50.50.50.50/24", "50.50.51.50/24", "50.50.52.50/24" [17:44:35] ], [17:44:38] nothing from yesterday. [17:44:42] dr0ptp4kt, good! [17:44:59] yurik, thx. this is actually fun. i like debuggers. [17:45:06] dr0ptp4kt, now i need to check that what you just entered should be an error too! [17:45:16] YuviPanda: so I believe I have to bump android:versionCode and android:versionName, right? anything else hiding around? :) [17:45:20] * brion is always suspicious [17:45:33] brion: nope :) [17:45:38] brion: you've to do a git tag -a [17:45:42] afterwards [17:45:58] brion: and also test the release apks for db upgrading issues [17:46:09] add the tagging to the todo list pls :) [17:46:27] and… we upload the APKs somewhere right? [17:46:46] and make some kind of release announcement? [17:46:47] brion: yup :) [17:46:50] that too [17:46:51] let me do all that [17:46:52] wait [17:46:54] as in [17:46:56] put all that in the doc [17:47:01] brion: do you have access to the google play dev console? [17:47:03] tfinc: ^ [17:47:10] hmm ? [17:47:11] i do [17:47:15] let me pull it up [17:47:38] wait! [17:47:49] I just made it crash. [17:48:01] ragesoss: ow [17:48:02] how [17:48:09] yurik, those are technically legal CIDR blocks. you thinking that if it's a /24 we want them to start the last octet at 0? [17:48:12] there we are, found the right account [17:48:26] yurik, and by 'them', i mean 'us' for the time being? [17:48:40] just emailed the crash report. [17:48:45] dr0ptp4kt, no, i think what I will do is do on-the-fly optimization of those entries [17:48:52] so it won't be an error [17:48:58] YuviPanda: we need a change log for the store right? [17:49:08] all I did was try to do multiupload, and then tap an individual photo to rename. crashed at that point. [17:49:18] I didn't even do anything exotic yet. [17:49:19] brion: hmm, so ragesoss found a bug [17:49:24] and that's from my 'fix' earlier today [17:49:25] bleargy [17:49:27] brion: yup [17:49:41] doh [17:50:06] YuviPanda: oh and i confirmed that it crashes if you take a photo when there's no camera. :) probably easy to fix, no rush on it though [17:50:18] brion: yup! i commented on the bug [17:50:21] :D [17:50:24] ragesoss: let me get to that [17:52:01] are you gonna change the crash email address? [17:52:11] ragesoss: yup [17:52:15] yurik, connection dropped. anyway, i was saying those are legitimate CIDR blocks [17:52:36] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/-VfDAQ [17:52:36] android-commons/master 3b29af2 YuviPanda: More complete RELEASE-CHECKLIST! [17:52:59] ragesoss: changed to mobile-feedback-l [17:53:02] Project Android-Commons (mobile) - Nightly builds build #159: SUCCESS in 37 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/159/ [17:53:02] ragesoss: do you want to be on it? [17:53:02] yuvipanda: More complete RELEASE-CHECKLIST! [17:53:08] YuviPanda: sure [17:53:13] yurik, although you could compel /24s to have a last octet of 0. [17:53:16] dr0ptp4kt, no, i think what I will do is do on-the-fly optimization of those entries [17:53:21] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/CCh7ZA [17:53:21] android-commons/master 1be36cb YuviPanda: Change Crash feedback email address to mobile-feedback-l [17:53:21] so it won't be an error [17:53:46] YuviPanda: nice :D [17:53:47] the same logic would need to be applied to other octets at the correct demarcation dictated by the integer after the '/' character [17:54:04] Project Android-Commons (mobile) - Nightly builds build #160: SUCCESS in 54 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/160/ [17:54:04] yuvipanda: Change Crash feedback email address to mobile-feedback-l [17:54:10] brion: i'm looking at the error sage reported. [17:54:22] ok i'll prep the other bits while you're working on that [17:54:23] dr0ptp4kt_, although, come to think of it, i won't bother - will do it in python [17:54:45] brion: alright [17:55:58] hey tbharath [17:55:59] err [17:56:01] tfinc: i mean [17:56:04] hello tbharath too :) [17:56:13] tfinc: can you add ragesoss to mobile-feedback-l [17:56:31] is it not just a mailing man list ? [17:56:57] tfinc: it's a private one, so I think they'll want someone giving a 'ok' [17:57:21] yeah https://lists.wikimedia.org/mailman/listinfo/mobile-feedback-l [17:57:28] hey YuviPanda, will you have some time to have a look at the limn patchsets? ;) [17:57:32] ragesoss: did you already send in a subscription request ? [17:57:43] jgonera: yes, i'll make sure I do that before I take off for 5 weeks :) [17:57:51] tfinc: no [17:57:54] ok, thanks [17:58:00] YuviPanda: thanks. I really want to make sure that jgonera can take limn requests while your out [17:58:12] ragesoss: pm me the email address you want for the list [17:59:01] [android-commons] brion opened pull request #11: Update version and CHANGELOG for 1.0beta8 (master...beta8) http://git.io/93ZfiA [17:59:02] jgonera: can we not call them 'datafiles' but something else? [17:59:05] jgonera: datagenerators maybe? [17:59:11] since their output will be under datafiles... [17:59:25] and then also datasourcegeneratos? ;) [17:59:43] Successfully subscribed: [17:59:43] I just assumed that whatever is in the mobile dir, "generates: stuff [17:59:43] ragesoss+wikipedia@gmail.com [17:59:46] YuviPanda: --^ [17:59:49] oops [17:59:55] hehe :P [17:59:59] well that was dumb of me after asking rage to pm that [18:00:01] sorry ragesoss [18:00:21] ha! [18:00:26] ragesoss: it gets *some* spam, so I've a filter that only surfaces things that have the word 'commons' in them [18:00:29] to me [18:00:34] i highly reccomend using a similar thing :) [18:00:45] YuviPanda: I can handle that. [18:01:49] thanks :) [18:03:03] yurik, sorry, connection flaked [18:03:42] dr0ptp4kt, wow, you really do have a major problem with connection. I haven't said anything though [18:04:08] jgonera: sent comments [18:04:16] YuviPanda, thanks [18:04:30] YuviPanda, hi , sorry I am afk [18:04:40] yurik, yeah, though it pains me i may have to go home. or go to a cafe that has more lit people and fewer csci people. [18:04:51] YuviPanda, I want to know about native app for android [18:05:26] dr0ptp4kt, going home is a pain? [18:05:40] tbharath: which native app? [18:05:46] the wikipedia one? [18:05:47] yurik, my (old) home doesn't have any office furniture. [18:05:49] or ? [18:06:08] YuviPanda, yes the wikipedia one [18:06:19] we plan to rewrite it sometime in the future [18:06:20] YuviPanda, I think you are planning to shift from phonegap [18:06:23] but no plans right now [18:06:25] yes we are! [18:06:36] dr0ptp4kt, my home doesn't either - i am the most productive while lying a couch [18:07:09] YuviPanda, so I want to contribute to that , [18:07:26] ah nice! [18:07:35] yurik, ha! that works pretty well for me. but nothing like having indie music playing overhead and barista-served coffee. [18:07:36] but sadly i'm going off the internet for a month starting tomorrow for exams :( [18:08:21] you're gonna have net withdrawal so bad [18:08:31] YuviPanda, me too , but will I get any updates for that [18:08:41] tbharath: have you joined the mobile-l mailing list? [18:09:00] dr0ptp4kt, true that, but i might overconcentrate on a girl at the next table, which would improve my social life, but might be detrimental to the code quality [18:09:14] YuviPanda, nope [18:09:43] ;) [18:10:12] tbharath: https://lists.wikimedia.org/mailman/listinfo/mobile-l [18:10:19] please subscribe to that, we'll use that list to keep people informed :) [18:10:58] YuviPanda, yeah sure , thanks a lot [18:11:04] welcome :) [18:11:12] YuviPanda, btw I participated in shastra hackathon [18:11:25] ah, the name sounded familiar :D [18:11:50] YuviPanda, I worked on tags [18:12:24] ah, hotcat replacement? [18:13:21] nice! I remember :) [18:13:31] YuviPanda, giving tags to article [18:13:38] yup [18:13:40] add categories [18:13:45] YuviPanda, yeah [18:13:50] New patchset: JGonera; "Make sure anonymous users can't edit on mobile (#463)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60956 [18:14:33] nice :) [18:15:10] New patchset: JGonera; "Fix indentation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61046 [18:17:41] ragesoss: any other bugs you encountered/ [18:18:12] lemme try [18:19:14] ragesoss: brion I fixed that [18:19:16] and pushed [18:19:23] ragesoss: do yo have your 2.3 device? [18:19:34] brion: can you do the 'upgrade' testing on your device? [18:19:36] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/8o770A [18:19:36] android-commons/master 0e1297f YuviPanda: Fix crash when trying to edit individual file name in multiple upload... [18:19:38] i'll test on my 2.3 one [18:19:43] ok [18:20:08] Project Android-Commons (mobile) - Nightly builds build #161: SUCCESS in 46 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/161/ [18:20:09] yuvipanda: Fix crash when trying to edit individual file name in multiple upload [18:20:14] ragesoss: ^ [18:24:02] YuviPanda: does mvn config have anything for signing or do i have to do that manually? [18:24:59] brion: intellij. [18:25:08] brion: Build -> Generate Signed APK [18:25:14] ooh [18:25:16] \o/\ [18:25:52] YuviPanda: seems to be working. [18:25:59] \o/ [18:27:04] I've finding fun new ways to make your app misbehave. [18:27:26] building..... [18:27:49] check out the file and edit history of this: https://test.wikipedia.org/wiki/File:Little_ones_-_3.jpeg [18:28:55] Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES] [18:28:59] ok i must have done something wrong [18:29:05] brion: are you signing with the app store's key? [18:29:15] in theory yes [18:29:16] ragesoss: IT'S A TRAP! [18:29:37] oh wait wrong file :P [18:29:50] ragesoss: .... [18:29:56] ragesoss: did that just happen without you doing anything? [18:29:58] or...? [18:30:02] Success [18:30:05] no, I renamed every file the same. [18:30:15] and then it uploaded all 11 over each other. [18:30:18] oh you evil person :P [18:30:25] and added the set of 10 categorys... 11 times each. [18:30:51] brion: hah! :D [18:30:55] ragesoss: :P [18:31:03] ragesoss: we should probably not let people do that in multiple upload [18:32:03] YuviPanda: ok upgrade works in-place on android 4.2.2 nexus 4 \o/ [18:32:08] brion: nice : [18:32:09] :) [18:32:15] brion: all things carry over, no failures? [18:32:17] YuviPanda: can you merge my PR for the version bump? [18:32:25] yeah, all my contris still there [18:32:25] brion: and try uploading something? [18:32:32] and the categories recent list works [18:32:33] brion: i'm testing on 2.3 [18:32:40] once that seems fine i'll just merge [18:32:44] ok [18:33:36] ragesoss: do you have your 2.3 device? [18:33:42] YuviPanda, so, about using graphs from config instead of iterating over file names, the problem is that datasources != graphs. should we create another list in the config for datasources? this seems redundant... [18:33:43] yes [18:34:00] ragesoss: can you test? *puppy eys* [18:34:25] jgonera: ah, hmm... shouldn't data generators correspond to data sources? [18:34:42] jgonera: now that I think about it that part of the config is misnamed [18:35:35] jgonera: so just rename that part of config to 'datasources'? [18:36:23] ok, still, there is alltime-numbers in mobile/datafiles but no alltime-numbers in mobile/datasources [18:36:36] I'm not sure what it is anyway [18:37:12] jgonera: hmm, right. [18:37:25] jgonera: it just generates a CSV with all time deletion percentages [18:37:27] should I just ignore the ones that don't exist? [18:37:34] that sounds reasonable [18:37:40] ok [18:37:58] also, do we use the titles from the config anywhere? it seems to me that they're set in JSON [18:38:09] jgonera: we used to, but not anymore. [18:38:13] jgonera: initially the data sources [18:38:17] jgonera: and the graph files [18:38:21] jgonera: were generated every time by limn [18:38:27] I see [18:38:49] jgonera: but during the great 'puppetize-it-or-your-cluster-access-shall-be-revoked' drive, we had to get rid of limnpy [18:39:01] jgonera: since that had pandas as a dependency and that's still not really installed anywhere [18:39:13] YuviPanda: no problems noticed on 2.3 [18:39:22] cats ui is a little cramped, though: https://test.wikipedia.org/wiki/File:Cats_ui_cramped.png [18:39:44] YuviPanda, not sure what pandas is ;) [18:40:05] jgonera: oh it is a statistical analysis library for python [18:40:09] jgonera: used by limnpy. [18:40:09] grrrrr im having connectivity problems again [18:40:19] jgonera: limnpy is a library from our analytics team [18:40:23] ragesoss: you should be able to scroll that list [18:40:30] but yeah once you have a couple selected that might be a little tight [18:40:34] jgonera: you can feed it csv structures and it'll generate graph / datasources json files [18:40:41] YuviPanda, why can't it be installed within the virtualenv? [18:40:56] jgonera: ops doesn't like virtualenv [18:41:01] brion: right, it's a minor issue. but 3 is not very many to see at one time, if you've started typing and want to choose the right cat. [18:41:05] ... [18:41:22] jgonera: it was running off virtualenv to begin with. [18:41:25] ragesoss: get a galaxy note ;)) [18:41:29] and then there was no more virtualenv [18:41:32] it was a sad day. [18:41:46] it must've been, indeed :/ [18:41:46] ragesoss: but i'm not sure how to fix that [18:41:52] brion: I'm waiting for a Nexus 5. [18:41:59] jgonera: a little pissing off too. [18:42:05] jgonera: at least we still got to keep jinja2 [18:42:23] hey yuvipanda & jgonera, have you heard that ori-l has been playing around with ipython notebooks? [18:42:23] ragesoss: http://www.dell.com/Learn/us/en/19/campaigns/xps-18-1810 [18:42:28] jgonera: so long story short, we can only easily use python packages that have ubuntu packages. [18:42:32] Maryana: oh yes, I saw the demo :D [18:42:33] he has a local instance synced up to eventlogging data [18:42:43] and played with the EL data :D [18:42:45] brion: is that the 18" tablet thingy? [18:42:47] YuviPanda, what's the reasoning? "no virtualenv! those crazy careless devs will install crap that will destroy our servers"? [18:42:55] yes :D [18:42:55] jgonera: something like that, yes [18:42:59] hehe. [18:42:59] let me find you the link [18:43:25] jgonera: https://wikitech.wikimedia.org/wiki/Server_access_responsibilities [18:43:28] I'd like a Note, except the screen isn't that great. [18:43:29] Maryana, ipyhon notebooks? [18:43:34] LCD FTW. [18:44:00] ok, I see [18:44:03] jgonera: that was an almost direct result of us trying to install virtualenv on stat1001 :P [18:44:09] jgonera: https://wikitech.wikimedia.org/wiki/IPython [18:44:13] Maryana: it won't help with our dashboard though [18:44:19] Maryana: but can easily replace ad hoc analysis :) [18:44:20] I thought it's a notebook with ipython installed on it and wondered what's so special ;) [18:44:34] it's really useful for sharing data analysis across teams [18:44:51] Maryana: yup! [18:44:57] Maryana: repeatable data analysis ftw! [18:45:59] yeah, though it helps if you know python, which i don't ;) [18:46:26] Maryana: it's easy to learn! [18:46:54] Maryana: and programming in iPython is a lot more similar to writing SQL or R than to python [18:47:15] YuviPanda: is that a selling point? [18:47:23] ragesoss: yes. [18:47:33] ragesoss: 'power and convenience of R / SQL, but with a non-shitty language!' [18:47:57] but does it support siri integration? [18:48:04] I hope not :P [18:48:08] :D [18:48:16] "Siri: tea, earl gray, hot." [18:48:17] YuviPanda, I don't quite understand how something can facilitate access for intruders unless it starts listening on a port or modifies something that listens on a port [18:48:30] so, one neat thing about the Android voice actions is... [18:48:39] you can address it as Siri and it still works. [18:48:44] jgonera: well, for one pip doesn't verify signatures. [18:48:54] jgonera: so theoretically someone can take control of the cluster by taking control of pypi [18:49:05] hmm [18:49:11] jgonera: or even one of the machines in the path from pypi to us [18:49:16] it's to do that with iPhone users and try a voice action that their phone can't do. [18:49:23] jgonera: this isn't the case with OS packages [18:49:25] it's *fun* to [18:49:38] ragesoss: heh, I'm sure iOS users by now are used to seeing things their phone can't do [18:49:42] YuviPanda, can we package pandas as an os package then? [18:49:58] yeah, but it rubs salt in the wound when you address yours as Siri. [18:50:01] ragesoss: it's mostly gone back to the original OS 9 defence of 'but it is eaiser to use!' [18:50:05] ragesoss: hah! [18:50:13] jgonera: so the OS provided version of pandas is damn too old [18:50:35] jgonera: and we could package it ourselves but it's a complete pain in the posterior for anyone who is not well versed in the intricasies of dpkg and friends [18:51:00] YuviPanda, I think I created a deb once, a long time ago ;) [18:51:05] oooo! [18:51:13] you are going to be a man in high demand then, jgonera ;) [18:51:35] YuviPanda, I'd have to refresh that knowledge though [18:51:40] jgonera: can you pop over to -analytics? [18:51:42] *shudder* debs are scary [18:51:48] i remember making rpms, that was easier [18:51:53] but supposedly debs are more flexible [18:51:56] I made a deb once too, I think. [18:52:14] it involved a fair bit of copying and pasting bash commands. [18:52:43] if i wanted to write bash commands i'd just make an install.sh [18:55:16] gonna grab a sandwich -- YuviPanda ping me when ready to proceed [18:55:22] brion: sweet [19:03:48] brion: i thinkw e're good to go :) [19:04:16] \o/ [19:04:30] brion: goddamnit. Forgot *one* thing [19:04:35] brion: our about page still says GPL :P [19:04:41] oops [19:04:58] * YuviPanda fixes [19:06:38] brion: merged :) [19:06:40] brion: do tag it :) [19:06:42] [android-commons] yuvipanda pushed 1 new commit to master: https://github.com/wikimedia/android-commons/commit/e1d76e302d174d87c156c38053e471e5d85e33c5 [19:06:42] android-commons/master e1d76e3 YuviPanda: Mention changed LICENSE in about page [19:06:48] brion: and release! [19:07:27] [android-commons] yuvipanda pushed 2 new commits to master: http://git.io/H8iftg [19:07:27] android-commons/master 49c44df Brion Vibber: Update version and CHANGELOG for 1.0beta8 [19:07:27] android-commons/master 2b614db Yuvi Panda: Merge pull request #11 from brion/beta8... [19:07:35] \o/ [19:07:37] :D [19:07:39] do ieet! [19:07:51] and double, *triple* check that it is going to send things to commons [19:07:53] and not testwiki :P [19:07:57] heh [19:07:58] because that is very, very, bad [19:08:57] heh [19:09:35] YuviPanda: should the tagged revision include the patch or not? [19:09:45] brion: i think not. [19:09:53] brion: we should never commit that patch :P [19:09:53] ok [19:10:09] brion: makes things easier, since we can always assume that everything without local changes goes to testwiki [19:10:13] don't suppose we can make it a separate build configuration or something so we don't have to play patches... [19:10:59] brion: we could, I'm sure maven can do soemthing about that [19:11:04] brion: intelliJ too [19:11:35] ok tag pushed [19:11:39] * [new tag] v1.0beta8 -> v1.0beta8 [19:11:46] [android-commons] brion tagged v1.0beta8 at 02374b1: http://git.io/-Cv94Q [19:11:54] applying patch locally [19:11:55] :) [19:11:58] wheee [19:12:27] generating signed apk... [19:13:03] brion: hey brion - quick question about faking out having hundreds of image - what property did you recommend adding duplicates to? (looks like fetchedResultsController.fetchedObjects is read-only) [19:13:36] mhurd: i think i was just recommending reducing the number of items we fetch at a time [19:13:42] so we can easily test fetching in multiple pieces [19:14:40] testing signed apk... [19:15:50] confirmed it uploads to commons :D [19:16:00] YuviPanda: do we store the .apks on download.wikimedia.org also? [19:16:09] brion: we sohuld but we don't [19:16:20] brion: mostly because I keep forgetting to find someone with access to put them there [19:16:24] heh [19:16:26] well i can do that [19:16:27] brion: let me add that to RELEASE-CHECKLIST [19:16:32] brion: sweet, please do! :D [19:17:53] brion: done [19:18:12] brion: mhurd YuviPanda : how do you feel if i sorted ToDo by priority for everything top down ? [19:18:14] yurik, so that we can do stuff from non-private, non-reserved IP addresses easily, i'm putting in the following into the code, although i don't know if i like it very much. is there a preferred way to get at the nature of the GLOBAL in question? pass it in as a boolean arg to validate()? [19:18:16] if ( count( $parts ) > 2 [19:18:17] || ( false === filter_var( $parts[0], FILTER_VALIDATE_IP, $ipFlags ) && ! $GLOBALS['$wgEnableZeroRatedMobileAccessTesting'] ) [19:18:18] || ( false === filter_var( $parts[0], FILTER_VALIDATE_IP ) && $GLOBALS['wgEnableZeroRatedMobileAccessTesting'] ) [19:18:18] ) { [19:18:31] tfinc: please do :D [19:18:36] tfinc: good idea [19:18:45] k [19:18:46] tfinc: yes! [19:18:46] YuviPanda: ok updated in the store, can you check it looks ok? [19:18:55] sure [19:19:06] dr0ptp4kt, i actually had that code in place before [19:19:09] * YuviPanda goes [19:19:12] but decided not to use it [19:19:30] as i couldn't come up with any reasonable way it would be used [19:19:33] for testing [19:19:35] yurik, ok, i can redact [19:19:41] brion: heh 'An app downloaded from Google Play may not modify, replace or update its own APK binary code using any method other than Google Play's update mechanism' [19:19:52] brion: i like how they change policies to target one single app (facebook in this case) [19:20:31] :) [19:20:59] brion: can you update the CHANGELOGs at Recent Changes? [19:21:28] YuviPanda: i did, did it not save? [19:21:35] looks like not [19:21:38] dr0ptp4kt, not sure what you mean [19:21:50] yurik, i won't add that code. [19:21:57] ok :) [19:22:00] yurik, or shall i say, re-add. [19:22:07] why did you want it in the first place? [19:22:08] YuviPanda: are you looking at the regular store page or the publishing page? [19:22:13] it takes a while to update the regular store page [19:22:14] brion: publishing page [19:22:16] like an hourish [19:22:17] hm [19:22:25] brion: I see beta 7 and 6 [19:22:30] i see 8 and 7 [19:23:24] yurik, i'm gonna change locations. be back in 10-15 minutes [19:23:32] k [19:23:39] hmm lemme refresh [19:23:45] brion: alright refresh fixed that [19:23:52] yay [19:23:59] brion: hmm, can you also update the screenshots? Those are pretty old ;) [19:24:16] brion: there are screenshots at https://commons.wikimedia.org/wiki/Commons:Mobile_app [19:24:34] ok [19:24:45] YuviPanda: can you stash those in source control? i tend to keep the store images under a 'scratch' subdir [19:24:53] that way we can easily find them in case we need to reuse them [19:25:27] brion: hmm, that'll be easier to update too I think [19:25:44] yep [19:25:49] ok added to https://www.mediawiki.org/wiki/Mobile/Release_history#Commons [19:26:16] :D [19:26:25] brion: now send out the email? [19:26:39] \o/ [19:28:11] brion: updated checklist coming up... [19:29:29] brion: can you check that and tell me if I've missed anything? [19:29:30] [android-commons] yuvipanda pushed 1 new commit to master: http://git.io/ZjgJhA [19:29:30] android-commons/master 8860944 YuviPanda: Update RELEASE-CHECKLIST [19:29:44] sent mail to mobile-l [19:30:19] super [19:32:01] forwarded to wikitech-l and commons-l [19:33:32] also http://commons.wikimedia.org/wiki/Commons_talk:Mobile_app :) [19:35:41] brion: can you make sure to have the video done before the banners, etc go out on monday? [19:35:54] brion: most people don't figure out how to use multiple upload at all for example [19:36:18] i won't be able to do it until monday afternoon sorry :( [19:36:25] equipment's at the office [19:36:33] but i will indeed update it then [19:36:55] nexus4 turns out to output HDMI at 1080p60 which our capture widget doesn't do [19:37:03] so I have to do it with my galaxy nexus instead [19:37:25] brion: heh, that's okay. but when you do make sure to include multiple uploads prominently [19:37:41] yeah it's a little nonobvious [19:37:47] yup [19:37:54] brion: so the 'select from gallery' intent does not support multiple images [19:37:54] hmm when we ask for gallery picker is there any way to request multiple file selection capability? [19:37:56] fail [19:37:59] or can we only get it from the regular gallery [19:38:00] bah [19:38:02] I checked. [19:38:07] android FAIL [19:38:13] brion: so what we can do is to have an 'add another' button somewplace [19:38:23] ah yes [19:45:54] brion: i'm going to head off now [19:45:59] brion: anything you want from me? [19:47:26] Yuthink im good [19:47:29] thanks! [19:47:41] *YuviPanda think I'm good [19:47:47] whee :D [19:50:25] ok gonna run some errands around the house [19:50:45] brion: see ya! [19:53:38] jgonera: i'll do another round of CR on that jinja2 patch for the dashboard tomorrow. [19:53:49] jgonera: i'll CR that one until it is merged. [19:53:55] i'm going off now! [19:54:31] Maryana_lunch: also I can't seem to access that blog post :( [19:54:34] can youg ive me access? [19:56:40] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61046 [20:13:10] yuvipanda, you should email matthew to get wmf blog access [20:29:12] New review: awjrichards; "This breaks nearby for me - that is, I no longer see it in my nav in alpha or beta. I tested in desk..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60819 [20:37:55] New review: JGonera; "It does not work in all cases, at least on my MW instance. Some articles in my watchlist don't have ..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60696 [20:42:38] New review: JGonera; "I just started wondering if we shouldn't do this on the server side." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60816 [20:42:39] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60816 [20:46:16] jgonera: would you mind dbl checking me on https://gerrit.wikimedia.org/r/#/c/60820/ ? [20:46:20] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60887 [20:46:53] awjr, ok, will do, when I finish reviewing diff-related patchsets [20:47:05] sure thing it's not urgent, just want to make sure my comments aren't off-base [20:48:01] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60817 [20:48:53] Maryana: jon appears to have approached the nearby preview a little differently than perhaps expected - can you read through the commit summary and see if this sounds ok? https://gerrit.wikimedia.org/r/#/c/60684/ [20:50:00] i looked through the comments, but it's really hard for me to get an understanding of what it looks/feels like. i was gonna ask jgonera if he can show me on a local instance [20:50:36] Maryana: i can probably get that up on staging too if jgonera is busy with other stuff [20:50:41] Maryana, we can have a look at it now [20:50:47] but probably easier in person :) [20:50:53] that would be cool, thanks jgonera [20:51:01] New review: JGonera; "I think that actually makes it worse. There should be no white and green/red alternating stripes as ..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60818 [21:04:18] New review: awjrichards; "This is a nice approach! But I think this only partly solves the problem I think this story is attem..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/60684 [21:09:28] converted this wikipedia here experiment to a leaflet.js map - http://inkdroid.org/ici/ [21:14:51] jgonera: is there an easy way for me to practically test https://gerrit.wikimedia.org/r/#/c/60346/ [21:16:01] awjr, well, just remove the changes made by me in mediawiki.js and run mediawiki.test.js [21:16:25] additional review from someone from core is more needed to actually know if this is the right fix, the code itself works [21:17:31] edsu: that looks really cool [21:17:31] edsu i dont really know anything about leaflet - does it automatically fetch map tiles from somewhere? is that something that' configurable? it would be extra cool if it used open street map tiles [21:22:19] New review: JGonera; "It doesn't work for me 90% of the cases. There must be a race condition:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60684 [21:24:25] MaxSem, why do i keep getting weird notifications from labs? [21:24:49] such as MaxSem built instance 'deployment-eventlogging' in project Nova Resource:Deployment-prep [21:32:28] New review: JGonera; "Apart from inline comments, modified ui.less is missing." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60820 [21:35:32] yurik: probably because you're part of that project and have your notifications configured to alert you on those kinds of events [21:35:42] yurik, because I did that!:P [21:35:55] hehe, but what does that mean is beyond me :) [21:36:31] MaxSem. built. instance. [21:38:08] jgonera: makes sense [21:38:33] jgonera: where is the code for https://mingle.corp.wikimedia.org/projects/mobile/cards/685 ? [21:43:39] MaxSem, so its just an event that a new labs instance was created in mobile? [21:43:59] yes. in deployment-prep [21:44:02] maybe i'm reading too much into it, never mind :) [21:44:58] awjr, https://gerrit.wikimedia.org/r/#/c/60614/ [21:45:07] cool ty [21:46:49] jgonera: looks like Yuvi has done most of the reviewing of your patchsets there - who else is familiar enough with that stuff to review? [21:47:25] hm, possibly milimetric [21:47:41] Yuvi said he'd had another look tomorrow, I fixed one thing in another patchset today [21:47:55] ok right on [21:49:37] brion: go the market update for commons :D [21:49:57] \o/ [21:50:25] brion: i can't add/modify categories post upload yet right? [21:50:57] just the one time immediately yeah [21:51:16] k [21:51:18] we'll try and make that work for after upload when yuvis away :) [21:51:32] i may add it to the backlog [21:51:50] since android doesn't have a send to test wiki i need something good to photo [21:51:59] to see the new suggested categories [21:53:11] yeah i uploaded a lot of pictures of the ceiling to testwiki while working on that feature :) [21:55:13] brion: please tell me your cat was on the ceiling for one of those [21:55:21] o_O [21:55:23] haha [22:08:21] New review: Maryana; "This also has the unfortunate side-effect of not showing users the "add image" button, which means w..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [22:15:55] brion: we need to update the text on https://play.google.com/store/apps/details?id=org.wikimedia.commons [22:16:00] do we have any existing text ? [22:16:06] oh wait [22:16:10] we do but the tip shows up first [22:16:21] making this https://play.google.com/store/apps/developer?id=Wikimedia+Foundation look wrong [22:16:33] :( [22:16:44] shall i move the tip to the bottom? [22:16:56] yes [22:17:10] ok done [22:17:20] might take a while to update of course [22:17:42] yup [22:26:02] gotta run, will check in later [22:26:04] mhurd: brion: are we explicitly blocking saving images in the iOS app to your own gallery ? [22:26:29] longtap sadly doesn't do anything [22:26:31] just curious [22:29:23] tfinc: shouldn't be tough to add it. not explicitly blocking that i know [22:31:35] ei! works :) [22:31:37] http://api.beta.wmflabs.org/wiki/Zero:100-10 [22:31:45] (temp setup) [22:31:55] dr0ptp4kt, ^^ [22:32:22] yurik, cool [22:32:35] pretty [22:32:43] i used api instance as i wasn't sure which mobile instance to use [22:33:11] if anyone wants to try editing, let me know and i will add you to zero [22:33:17] (account) [22:36:01] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60990 [22:36:08] yurik, i won't edit today, but please do add me [22:37:33] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60991 [22:39:26] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60992 [22:39:26] dr0ptp4kt, create an account on that wiki [22:39:36] will add you to admin, etc [22:39:36] yurik, just about to do that [22:40:03] dr0ptp4kt, btw, if you want, you can run your script against that site [22:40:33] yurik, looks like account creation isn't available? [22:40:47] bleh [22:41:07] default test install [22:41:08] sec [22:41:13] Change merged: Mgrover; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61030 [22:41:40] dr0ptp4kt, acct name? [22:42:12] that'll do, yeah. [22:42:29] http://api.beta.wmflabs.org/w/index.php?title=Special:UserLogin&type=signup -- what do you see ? [22:43:14] dr0ptp4kt, ok, account created, pswd "a" :) [22:43:17] please change [22:43:50] dr0ptp4kt, let me know when, will add your rights [22:43:54] Permissions errors [22:43:54] Jump to: navigation, search [22:43:55] You do not have permission to create this user account, for the following reason: [22:43:56] The action you have requested is limited to users in the group: Administrators. [22:44:05] ^yurik [22:44:33] dr0ptp4kt, ok, guess its showing for logged in users. Did you login ^^? [22:44:41] yurik, no [22:45:06] yurik, starting fresh browsing session [22:45:24] yurik, same error [22:45:59] dr0ptp4kt, http://api.beta.wmflabs.org/w/index.php?title=Special:UserLogin&returnto=Main+Page ? [22:46:32] yurik, i missed the strong password yous et [22:46:44] hehe [22:46:51] did you change it yet? [22:47:30] dr0ptp4kt, ? [22:48:08] yurik, STRONG password changed to EVEN STRONGER :) now to test url [22:48:35] dr0ptp4kt, ok, granted zero & admin [22:48:44] yurik, i have edit rights. thx [22:49:02] see if you script can populate it [22:50:53] yurik, will be doing that. maybe not today. [22:51:12] dr0ptp4kt, sure, let me know if you run into any issues [22:51:28] yurik, sure thing. nice work, man. [23:27:19] mhurd: are we good on this https://bugzilla.wikimedia.org/show_bug.cgi?id=46000 ? [23:27:54] tfinc: yes :) [23:28:03] mhurd: and what about its counterpart https://bugzilla.wikimedia.org/show_bug.cgi?id=46731 ? [23:28:22] tfinc: not sure [23:29:00] its missing the credits so i'll keep it open [23:29:10] tfinc: just saw the comments [23:34:31] tfinc: i got stuck on the >500 uploads patch. going to need to tag team w brion more. thinking about knocking out a couple lower priority cards with remainder of the afternoon if that sounds cool [23:36:23] yurik, just sent you an email with some requested code changes. it seems pretty good to me, and am hoping you can add in the three minor tweaks. then i'll +1 it [23:36:30] awjr: yes i believe leaflet.js integrates w/ osm http://switch2osm.org/using-tiles/getting-started-with-leaflet/ [23:37:14] yurik, i'm going to drive home, then i'm going to check email and head on out for the evening. dinner with parents tonight. going-away party tomorrow. have a good weekend. [23:37:26] dr0ptp4kt, ok [23:39:36] awjr: just switched it for you http://inkdroid.org/ici/ [23:40:13] cool edsu! [23:40:42] they look better, good call :) [23:40:56] that's really great. at some point in the hopefully not-to-distant-future, the wmf will be hosting our own OSM tile-servers [23:41:05] which we could use for something like this [23:41:27] nice [23:41:34] yeah this is really neat - edsu you should mail mobile-l about this [23:43:20] mhurd: just make sure to carry the story cards over to doing [23:43:33] awjr: ok :) can you share your url, so i can see what you see? [23:44:00] edsu: http://inkdroid.org/ici/#lat=32.2164&lon=-110.9679 [23:44:17] i'm in washington dc, and i'm totally amazed at the number of wikipedia articles that are tagged around me [23:44:29] i am too! i didnt think there would be much in tucson [23:44:33] awjr: nice :) [23:45:01] awjr: you see how it highlights articles that need an image? [23:45:18] yes :) [23:45:28] very cool [23:45:49] i was thinking it might be interesting to highlight articles that are flagged as needing work [23:45:52] as well [23:46:04] if that can easily be determined via the api [23:47:09] yeah that would also be really cool