[10:06:49] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61355 [13:40:22] woohoo! chromebook pixel driver support in linux kernel 3.9 [13:40:42] not that that helps me now, i gave my pixel to gnome developers to test with :) [14:16:25] chromebook's SSD is too small anyway [14:21:01] :) [14:26:41] * brion sits patiently while git fetch'ing [14:31:17] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61355 [14:31:17] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61355 [14:32:24] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/vxQWug [14:32:24] Commons-iOS/master f6cd48b Brion Vibber: Add messages-rif.json to project [14:32:24] Commons-iOS/master 2823c4c Brion Vibber: Sort message files in project [15:02:15] [android-commons] brion opened pull request #12: (provisional) Disable fade-in effect on images in Android 2.3 (master...flicker) http://git.io/noj0zA [15:27:21] New patchset: Jdlrobson; "Story 358: Persistent watchlist view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60692 [15:33:44] Change abandoned: Jdlrobson; "I'll leave this to designers then. It's currently hard to see small changes in large diffs though in..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60818 [15:34:26] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60819 [15:34:32] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60820 [15:38:06] New review: Jdlrobson; "I would prefer a global that turns on/off anonymous mobile editing " [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60956 [15:43:21] New patchset: Jdlrobson; "Story 477: Only show nearby in menu when supported" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61386 [15:45:08] New review: Brion VIBBER; "Looks right, but I haven't had a chance to test." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/61386 [15:46:50] New patchset: Jdlrobson; "Story 477: Only show nearby in menu when supported" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61386 [15:51:57] New patchset: Jdlrobson; "Move header to generic MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58994 [16:10:28] New patchset: Jdlrobson; "Simplify enable sections if statement" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60888 [16:33:39] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60888 [16:36:49] New review: MaxSem; "Is it possible to hide that link by default and show it with JS instead? This would work correctly o..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61386 [17:01:40] New patchset: Jdlrobson; "Alpha: Talk page - allow access to lead section conversation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59559 [17:01:41] New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [17:02:02] gooood morning - jgonera we're just waiting on you and maryana [17:02:29] New review: MaxSem; "The problem with this approach is that it gets reset once the user saves Special:Preferences because..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60692 [17:16:50] I'll fix the main problem with^^^ [17:18:58] jdlrobson, so getFooterLinks() is something we want to keep for Minerva? [17:19:16] yup [17:19:57] and it needs to return an array with notice and places keys? [17:20:52] MediaWiki/core->SkinTemplate.php/getFooterLinks [17:21:37] Maryana: what troublesome gadgets have you got enabled [17:22:01] hehe… let's see… hotcat and proveit, which are quite useful [17:22:18] some other ones, too, probably [17:22:20] * Maryana checks [17:23:11] navigation popups, reference tooltips, a watchlist bolding gadget [17:23:22] jgonera: can you share a link to the updated task? [17:23:43] and some others i appear to have been opted into: teahouse "ask a question" widget and dispute resolution widget [17:23:53] awjr, I haven't updated it yet, but it will be the same gist I sent, I'll do it in a few minutes [17:23:59] oh ok thanks jgonera [17:24:20] Maryana, are you sure that we want a link to page history in https://mingle.corp.wikimedia.org/projects/mobile/cards/487 ? [17:24:26] we don't have a mobile version [17:24:45] we're already linking to the desktop version in the "contributors like you" footer link [17:24:47] so it will show a kind-of-mobile version and then when someone tries to compare revisions it will redirect them to dektop [17:24:51] oh [17:25:02] yeah, it sucks, but it's been sucking for some time already [17:25:11] Maryana: just need it for the gadget bug that MaxSem has put a fix in for [17:25:21] ok, I forgot the contributors link also took us there [17:25:32] jdlrobson, i can take a screenshot of my preferences for you [17:25:35] that might help :) [17:25:39] Maryana: no need [17:25:41] i should be fine [17:25:45] ok [17:32:48] New review: Jdlrobson; "Code looks fine and works but merge when dependency has been merged." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/61028 [17:45:35] New review: Siebrand; "I18n/l10n looks fine." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/60684 [17:49:36] tfinc, awjr, updated task: https://gist.github.com/jgonera/69930780b2c4b18f2838 (same URL, you can click Revision to see changes). also, can someone check if English is not too Polish? [17:51:50] mornin [17:51:57] sorry i missed the standup, i was in a taxi :) [17:53:18] New review: Siebrand; "L10n LGTM" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/59559 [17:54:33] tfinc: moving the app sync up to tuesday? [17:55:06] brion: in your email you said that you would be out after 10:30 [17:55:14] and we didn't see you at the standup [17:55:16] so i decided to move it [17:55:21] ok [17:55:42] brion: please mail in your status [17:55:48] writing it now [17:58:18] sent [17:58:23] awjr, Maryana, why do we sometimes use � and sometimes � when $wgMFTrademarkSitename is true? [17:58:31] i'm in the airport so i'll be intermittent again :) [17:58:43] eh jgonera? [17:59:01] SkinMobile.php, line 65 [17:59:02] oh, were you using trademark symbols? [17:59:07] i think my client converted those to '?' [17:59:08] and onward [17:59:13] oh, yes [17:59:16] there is a reason [17:59:17] (R) or ^TM [17:59:22] lemme see if i can refresh my own memory [17:59:41] I mean, we use one if we use an image, and other if we use text [18:00:03] Maryana: the app sync-up got moved to tomorrow [18:00:39] so we can only use ® on marks that are actually registered with the us patent office - and i think the distinction between image/text is incidental in our case (but convenient for knowing when to use which) [18:00:50] tfinc: I added a bunch of things to the backlog board this weekend, feel free to rearrange or veto :) [18:00:55] ok [18:01:37] * brion sees mhurd has taken some cards… excellent :D [18:01:44] does that make sense jgonera? [18:01:54] brion: :) [18:02:03] awjr, kind of, but linking that to image/text doesn't ;) [18:02:15] i know :-/ [18:02:19] jgonera, s/testeable/testable/ [18:02:29] there is likely more history there, jgonera, but i think we'd need to ask patrick [18:02:30] brion: oh heads-up i'll be out of the office friday [18:02:38] ok [18:02:45] ok, I'll leave it as it is now [18:02:51] jgonera: also i think the *only* image that we actually have is for wikipedia [18:03:10] I see [18:03:21] not that that necessarily makes it any easier :p [18:03:32] jgonera: so i wrote that code originally [18:04:06] oh! sorry jdlrobson, i thought it was patrick [18:04:18] awjr: yeh i did it back in the phil days [18:04:24] yah [18:04:26] let me see if i can dig out mails [18:06:16] jdlrobson: also when you have a chance, can you leave a comment on https://mingle.corp.wikimedia.org/projects/mobile/cards/477 to point to the right patchsets since the original ones were abandoned (i know mingle no longer prompts for comment like it used to; im still trying to get to the bottom of this) [18:06:40] awjr: i'm pretty sure it was convenience though [18:06:44] New patchset: awjrichards; "Story 425: Nearby preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [18:06:56] jdlrobson: yeah… that's kinda what i remembered but wasnt sure [18:07:11] awjr: it will be story 477 in the commit summary [18:07:22] got it jdlrobson [18:08:03] New review: Jdlrobson; "Could we not start caching sections per current revision in a separate table? This would surely spee..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [18:08:04] awjr, is SkinMobileWML something we still use? [18:08:29] OuKB: ^ [18:08:38] yes [18:09:24] do we know if the WML output actually still works? [18:09:37] is it likely to stay for a long time? [18:09:53] and OuKB, pardon my ignorance, but who are you? ;) [18:09:55] we chatted a couple months ago about stopping support for WAP devices [18:10:09] nobody of importance [18:10:16] lol [18:10:21] OuKB = MaxSem [18:10:23] jgonera: ^ [18:10:40] brion: good question... [18:10:51] I suspected that but couldn't find a reason why you'd change the nickname ;) [18:10:52] last time i looked it did, but that was admittedly a long time ago [18:10:53] we should either test it or kill it at some point :) [18:11:05] brion, well - try in Opera [18:11:14] yeah, we talked about killing it and there seemed to be some general consensus, but no real decision about how to go about it or when it should be done [18:11:29] ok, I see [18:11:31] OuKB: opera takes html... [18:11:45] brion, &useformat=mobile-wap [18:11:49] ah [18:11:52] or -wml... [18:12:28] http://en.wikipedia.org/wiki/Main_Page?useformat=mobile-wap gives… "XML parsing failed" [18:12:49] there's an that's not closed [18:12:51] click on read as HTML [18:13:07] i think we last talked about killing WAP during our performance sprint a few weeks back - since we killed X-Device for cache variance, we now use X-WAP (wap or not) but would be nice to just get rid of it... [18:13:11] well, that … sorta works [18:13:25] search doesn't do anything [18:13:30] brion, just like WAP itself;) [18:13:31] jgonera: awjr so i can't find the email which said use the ™ symbol annoyingly. I seem to remember it being something about english language - and Change-Id: Ic5b2491485a93909ae2a4c944f7140ed26fc1741 seems supports this [18:13:36] hah [18:14:25] jdlrobson, what is this hash? can't find it in the repo [18:14:35] 4ff6fa4ead979e68ce5587492076e81bddcc98c8 [18:14:47] "use image+ ® for en version, text +™ for others (requested by legal)" [18:14:52] boarding time… see y'all in a bit [18:14:59] * jdlrobson waves at brion [18:15:11] i think there's some expanded information in a currently open bug, jdlrobson, jgonera [18:15:19] lemme see if i can find it [18:15:37] jdlrobson, awjr, wow, so that's even weirder, we use an image for enwiki, but text for all the others [18:15:41] so yeah, I would love to establish a threshold after which we can trash WAP to where it belongs [18:16:23] jgonera jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=41141#c14 [18:16:28] read my comment (#14) [18:16:32] New review: MaxSem; "We should do it on talk page save and stash into page_properties." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [18:16:38] jgonera: don't mess with legal [18:16:53] most of that is copy/pasted from an email from legal [18:17:09] New review: Jdlrobson; "That would be awesome.... I assume there is a hook?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [18:17:13] I'm not messing, we can use text everywhere, (R) is as easy to show as a text as is ^TM [18:17:44] i'm confused.. we're not using text? [18:18:17] jdlrobson: on enwiki we use an image [18:18:27] i think everywhere else is text [18:18:33] yes, it seems so [18:19:16] awjr: only because we had an image [18:19:31] images are preferred but we only bothered making an image for enwiki [18:19:37] oh i see [18:20:25] why are they preferred? it's only a small bit of footer, nobody notices it and we have all this mixed up logic around it now ;) [18:20:33] if i was doing it again now i'd have a single config variable which has an optional image and site name suffix property which can hold R or ™ [18:20:58] jgonera: i forget - this was implemented months ago but i remember heather walls stressing the importance of the logo [18:20:59] ok, I'll just leave it more or less as it is now ;) [18:21:04] can we just fix the bug and be done with it :) [18:21:26] but I guess I'll move it to one place, right now generating the footer is scattered over 3 files (!) [18:21:41] it's a story, not a bug ;) [18:22:25] you're not talking about the infamous meta ™ bug ? [18:22:39] jgonera: it wouldn't be scattered if someone bothered merging minerva :) [18:22:59] (and this would also save me doing yet another rebase) [18:23:01] well, I reviewed it, I can't merge it if it breaks something [18:23:14] what's broken now? [18:23:27] i thought i fixed it [18:23:30] I don't know, I'll see when I re-review it, let's hope nothing ;) [18:23:37] (you mean the header refactor) [18:23:40] ? [18:24:20] I left my last comments on gerrit on Friday, if those things are fixed, I'll merge today [18:24:37] jgonera: yeh i fixed all those things [18:24:55] but the header problem was because i merged someone else's code before mine :) [18:25:12] ok [18:26:00] anyway i can't stress how much easier skin development will be when those minerva commits get merged [18:26:08] btw, jdlrobson did we change something with scrolling/link hijacking. lately, in Chrome, no links have a pointer cursor for me, I can't see their URL until I click them and the scrollbar sometimes doesn't work [18:26:17] or is my Chrome broken? [18:26:33] i don't know of anything that would have caused that [18:26:41] is it ok in Chrome for you? [18:26:47] err lemme check in a min [18:28:01] jgonera: beta alpha stable? [18:28:33] jdlrobson, beta currently but I think all of them [18:28:42] New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [18:28:53] stable too [18:29:03] both my dev env and production [18:29:24] maybe it's something with my Chrome, although our site is the only site that shows this behavior [18:30:11] [Commons-iOS] montehurd opened pull request #53: Spinning "Refreshing..." wheel was not going away if refresh failed (master...initialSync) http://git.io/sRIwRA [18:31:32] brion: ^ this one was easy :) [18:32:11] New review: Jdlrobson; "Are you serious!?!?!!?! (wtf mediawiki) Saving page preferences overwrites them? That's messed up..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60692 [18:32:51] jgonera: nothing looking wrong to me [18:33:05] jgonera: unless i'm misunderstanding you [18:33:09] jdlrobson, ok, will try on my laptop at home later [18:33:25] the mouse cursor doesn't change when I hover the link [18:33:34] and the status bar doesn't show the URL [18:33:47] but links work when I click them [18:33:53] the link = a link [18:45:54] New review: Jdlrobson; "Please don't waste time reviewing this just now when there are more important patches to review (eve..." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/58825 [18:48:43] brion, yt? [18:52:10] Maryana, regarding footer, "Text is available under the Creative Commons Attribution-ShareAlike License" - instead of "text" it's "content" now, do we want to change it? [18:52:26] should be text [18:52:32] images may or may not be cc by sa [18:52:36] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/56613 [18:52:40] jgonera ^ [18:52:40] jdlrobson: ^ [18:53:00] ok [18:53:41] New review: awjrichards; "Actually... my previous comment may have been premature - i seem to be getting the JS error on curre..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [18:53:46] jdlrobson: yt? [19:01:18] Maryana, " CC BY-SA 3.0" => "Creative Commons Attribution-ShareAlike License", any reason we can't keep it as short as possible? [19:01:44] good point [19:01:57] keep it short! :) [19:02:20] there's a 65% chance legal is going to grumble about that, but i will grumble back [19:03:44] ok ;) [19:05:57] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/CIyU3w [19:05:57] Commons-iOS/master fd5d438 Monte Hurd: Spinning "Refreshing..." wheel was not going away if refresh failed [19:05:57] Commons-iOS/master 8c0f5b1 Brion Vibber: Merge pull request #53 from montehurd/initialSync... [19:12:51] awjr: what's the js error you are getting? [19:13:07] one sec jdlrobson - i think my instance might actually be messed up [19:15:58] jcmish: MobileFrontend on betalabs is wayyy out of date - is it not auto-pulling? [19:16:14] jdlrobson: im getting: [19:16:15] . Uncaught TypeError: Cannot read property '0' of undefined https://www.virtualbot.com/testing/core/extensions/MobileFrontend/javascripts/specials/uploads.js [19:16:15] . getImageDataFromPagehttps://www.virtualbot.com/testing/core/extensions/MobileFrontend/javascripts/specials/uploads.js [19:16:15] . $.ajax.done.fileArrayhttps://www.virtualbot.com/testing/core/extensions/MobileFrontend/javascripts/specials/uploads.js [19:16:16] . jQuery.extend.eachhttps://m.virtualbot.com/testing/core/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20130412T195913Z [19:16:18] . (anonymous function)https://www.virtualbot.com/testing/core/extensions/MobileFrontend/javascripts/specials/uploads.js [19:16:21] . firehttps://m.virtualbot.com/testing/core/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20130412T195913Z [19:16:21] awjr, cc hashar [19:16:23] . self.fireWithhttps://m.virtualbot.com/testing/core/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20130412T195913Z [19:16:24] no errors here awjr [19:16:32] . donehttps://m.virtualbot.com/testing/core/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20130412T195913Z [19:16:32] . send.callback [19:16:33] jdlrobson: which is because it seems there's a db entry for the image the but file never actually uploaded [19:16:40] !pastebin | awjr [19:16:51] heh okok OuKB :p [19:16:53] also awjr that's useless without line numbers [19:17:33] jdlrobson: http://pastie.org/7739243 [19:17:58] hey mhurd, commons app login is not working for stevenw from e3 [19:18:14] i just watched him try both his staff and personal accounts [19:18:16] no dice [19:19:02] jdlrobson: i think ultimately tehre's something wrong on my instance, but not 100% sure yet; either way upload.js should be a little more defensive (i think either showGallery() should check for properly formated page data before passing the page object to getImageDataFromPage(), or geImageDataFromPage() should make sure data is properly formatted) [19:20:58] awjr_lunch: what response are you getting from server? [19:23:20] grrrrrrrrrrrrrrrrrrrrrrrrr [19:24:17] awjr_lunch: i'm pretty sure this is your instance messed up [19:24:24] jdlrobson: yeah agreed [19:24:42] jdlrobson: i get a 200 from the server [19:24:42] awjr_lunch: i'm not sure how the js could be more defensive. [19:24:49] what's the response body? [19:25:07] jdlrobson: well it assumes that page.imageinfo will exist [19:25:20] so, making sure that page.imageinfo is set before messing aroudn with it would be more defensive [19:25:38] awjr_lunch: which should exist.. [19:25:53] jdlrobson: it should, but it doesnt for some of my resources [19:25:56] which is the problem [19:26:03] awjr_lunch: well the bug is in the api then [19:26:08] http://pastie.org/7739271 [19:26:12] that's the response im getting [19:26:59] awjr_lunch: where is the image info missing? [19:27:18] New review: awjrichards; "I'm removing the -1 since I cant accurately test this locally (my instance is borked), but it would ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [19:28:23] jdlrobson: ah sorry, i forgot i had added some code to skip pages that had imageinfo missing - one sec [19:28:28] brion: i'm reviewing our official wikipedia app data. unconfirmed but Windows8 traffic is less the BlackBerry PlayBook. It's hovering around .05% of total mobile traffic [19:28:46] heh [19:28:50] oh well :) [19:28:57] awjr_lunch: that would make sense ;-) [19:29:12] jdlrobson: http://pastie.org/7739278 look for pageid 395 [19:29:27] that really shows that investing in Win8 right now doesn't make much sense right now [19:29:31] iOS and Android look strong [19:29:50] 12%-16% total for both [19:29:53] OuKB: https://gerrit.wikimedia.org/r/#/c/60692/ what would you suggest? [19:29:54] let me share the numbers with you [19:30:11] jdlrobson, wait for my commit;) [19:30:14] take a look and let me know if anything looks weird [19:30:22] OuKB: :D [19:30:31] * jdlrobson loves it when people commit amend [19:30:38] i'm doing this to verify the data in https://mingle.corp.wikimedia.org/projects/analytics/cards/92 [19:30:42] poor windows 8 [19:31:48] * jdlrobson is having an internet fail [19:31:53] New patchset: MaxSem; "Story 358: Persistent watchlist view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60692 [19:32:30] New patchset: Jdlrobson; "Story 436: Use file name for images with descriptions with templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [19:33:00] awjr_lunch: can you take a look at https://gerrit.wikimedia.org/r/#/c/58994/ ? Minerva review is going slow and the code should be so so simple [19:33:27] brion: the order of magnitude difference make sense to me. what do you think? [19:34:14] OuKB: did you forget SkinMobilebase? [19:34:20] no [19:34:24] not needed [19:34:36] why not? [19:34:44] how does it know what link to make max ? [19:35:15] I simply fixed your code that used user prefs as default query values [19:35:16] ^ OuKB [19:36:03] * jdlrobson doesn't like abusing the url.. [19:36:15] it just seems wrong... [19:36:16] well [19:36:24] it's NOT abused any more:P [19:36:47] but the menu link always points to http://localhost/w/index.php?title=Special:Watchlist no? [19:36:51] and that varies in meaning [19:36:56] it could be the feed / the a-z [19:37:03] what's wrong? you've set defaults - whenever you visit that page, the defaults are used if URL doesn't say otherwise [19:37:23] just try it yourself [19:37:36] OuKB: no i can see it works - it just feels wrong [19:38:03] as i can't reliably share the url of the current screen with a friend who's also logged in and see the same ui [19:38:11] awjr_lunch, jgonera - what do you feel on ^^^ [19:38:12] but i can cope with that for the time being [19:38:29] mhurd: Maryana : woot http://thenextweb.com/apps/2013/04/29/wikimedia-commons-new-ios-and-android-apps-make-it-easier-to-donate-your-photos-to-wikipedia/ [19:38:30] where does it start? [19:38:36] nice! [19:38:47] http://gizmodo.com/set-your-phones-photos-free-with-the-wikimedia-commons-484586665 [19:38:49] jgonera, [23:34:15] OuKB: did you forget SkinMobilebase? [19:39:03] http://www.theverge.com/2013/4/29/4282828/wikimedia-commons-app-for-ios-and-android-helps-you-contribute [19:39:20] jgonera: so basically the discussion is this in summary: [19:39:24] generally simple but good coverage Maryana [19:39:30] * the url in the menu is always to http://localhost/w/index.php?title=Special:Watchlist for watchlist [19:39:33] tfinc: awesome! [19:39:34] "With native mobile apps now in tow, it’s easier for users to take a snap with their pocket rocket and upload on the spot." ewww, pocket rocket? somebody needs a better copyeditor :-P [19:39:40] * the content of this page varies based on last view of the user [19:40:01] Maryana: haha agreed [19:40:21] * i find that a little icky since i can't share that link (i know that that the other user won't be able to see my watch list but if they're logged in they should be able to see something that represents the same thing) [19:40:28] OuKB, I agree with jdlrobson [19:40:58] it also helps us out in the future if we were ever to add caching to special pages… [19:41:45] jdlrobson, they will never be cached [19:42:12] ROFL [19:42:27] OuKB: i know but in theory one day they could which is another consideration [19:42:31] and logged0in pageviews too [19:42:41] jdlrobson, nevar [19:42:47] but my main issue is a belief i have that if i share a url with someone the same thing should be seen by them (and in user cases their customized view of it) [19:42:48] that kills the idea [19:43:58] ok, I don't mind if we use ugly links for now [19:43:58] yeah, OuKB, the content under the same URL changing because of the app state (cookie, user preferences) just seems wrong, it reminds me of all those crappy HR online systems I have to use [19:44:08] jgonera: +1 [19:44:21] * jdlrobson has flashbacks to performance management system hell [19:44:34] OuKB: i'll fix this up now then if you are okay with me doing so? [19:49:00] New patchset: MaxSem; "Story 358: Persistent watchlist view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60692 [19:49:11] jdlrobson, ^^ [19:49:28] * jdlrobson looks [19:49:56] DAFUQ!!1 [19:49:58] "online repository of license-free images and other media files" [19:58:55] awjr: our 1p doesn't have a hangout [19:59:12] oops [19:59:14] just added one tfinc [20:02:31] OuKB: making a slight change to ps [20:15:40] Change abandoned: Jdlrobson; "I haven't got time to explore this right now. I'd assume this is not such a big deal since minified ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59512 [20:17:16] Maryana: Doh! [20:17:39] https://commons.wikimedia.org/w/index.php?title=Commons_talk:Village_pump&diff=prev&oldid=95337815 [20:18:05] multichill - ? [20:18:16] You posted your message on the wrong page.... [20:18:43] oh man [20:18:46] did i put it on commons talk? [20:18:47] haha [20:18:54] * Maryana blames monday [20:19:03] It's correct, but you might want to bang your head into some wall ;-) [20:19:44] you know what makes this especially irksome? the template transcluded on top of the commons vp that says in big giant letters: "click here to post on commons:village pump" [20:19:53] *commons vp talk page [20:20:21] meh [20:21:04] Hehe, cool app [20:21:19] have you tried it out yet? [20:21:39] steven walling fired up the iOS app and i think it might have melted from trying to load all his contribs [20:21:56] need more power users to try it out and file bugs :) [20:22:39] DIE APPLE DIE (stupid "extra security" nonesense) [20:24:46] New patchset: Jdlrobson; "Story 358: Persistent watchlist view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60692 [20:30:31] hey, was wondering how hard it would be to take the commons app and change the upload server/wiki to a 3rd party wiki and use it for uploading there [20:30:47] just a one-liner for the upload server (and the logo?:) [20:32:19] New review: Jdlrobson; "If everyone else is happy with this..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/60692 [20:32:34] https://commons.wikimedia.org/wiki/File:Speaker_at_Glamwiki_Uk.jpeg seems to work [20:32:44] Do you not add coordinates on purpose? [20:33:27] OuKB: jgonera awjr please please please https://gerrit.wikimedia.org/r/#/c/58994/ [20:33:40] in a mtg, will be free after 2 [20:35:02] OUch, we should have a mobile version of Commons [20:35:29] And of bugzilla.... [20:37:37] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58994 [20:45:46] jdlrobson, I finish the footer stuff and I'll start reviewing [20:58:14] New patchset: Jdlrobson; "Move header to generic MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58994 [20:58:22] ^ OuKB [21:03:21] dfoy, ping? [21:03:26] dfoy, are you joing us? [21:06:59] hmmm… I got it to show a "Waiting for first sync" message, but it didn't go away when data started coming in :D [21:07:28] * brion continues to poke [21:09:15] YuviPanda, wondering whether you would like to volunteer as co-mentor for http://www.mediawiki.org/wiki/User:Orsagi/GSoC_2013_proposal [21:09:28] aka mobile app for MediaWiki translation [21:09:37] Android app, I mean [21:10:39] (or anybody else in the mobile team, of course) [21:11:05] awjr, grr, something's up w/my colloquy client. it lies and says you're offline. restarting - one sec [21:11:19] lies! [21:11:20] okidoke [21:16:06] brion: will you be available for the 3-4 audio/video? if not i'm debating about moving it to tomorrow [21:16:14] i woudln't mind some extra time for it [21:16:51] crap, i've got the win8 call double-scheduled with it. i won't do much more than advise jul on it though [21:16:57] *kul [21:17:38] brion: let me move the codec talk to tomorrow then [21:17:43] i need some more time reading through the docs anayways [21:17:44] ok [21:17:47] :) [21:26:54] New patchset: JGonera; "Story 487: Footer update" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [21:36:15] so awjr i really want to wrap these minerva commits up. How about instead of having getMode I simply have a public function getSearchPlaceholderText [21:36:40] and have the inheriting class deal with it? [21:37:16] that could work - although i do like the idea of the whole thing supporting a concept of modes [21:37:50] awjr: well i'm not too bothered - i just want to get the skin to a manageable state again [21:38:08] but using getSearchPlaceholderText and having the inheriting classes deal with it (and define modes/how they use them/etc) is fine for now too [21:38:14] i'm getting massive headaches trying to manage the existing 3 patch sets with all the changes happening to skins [21:38:22] up to you jdlrobson [21:38:22] i can imagine [21:38:47] i like the idea of having a desktop alpha/beta/stable and having a generic function in future that can be reused across the skin [21:39:08] but equally there's no guarantee we will need that so possibly for time being it could just be a mobile skin thing [21:39:18] yeah totally; or even better not restricting available modes to alpha/beta/stable, but support modes in general [21:39:36] and in a predictable way across different implementations [21:40:07] but you're right, simple thing is to just keep it with the mobile skin for now and deal with it later when we need it [21:40:22] cart after horse [21:40:43] ok i think what i'll do [21:40:49] is have a getMode on SkinMobileTemplate [21:40:56] that way we can always promote it [21:41:00] makes sense [21:41:07] you might not want to hear this right now [21:41:07] but [21:41:18] i feel like MinervaTemplate should be an abstract class [21:41:23] and not function on its own [21:41:47] abstract class BaseTemplate extends QuickTemplate [21:41:47] but… cart/horse [21:41:54] MinervaTemplate can't be abstract [21:42:01] it extends BaseTemplate [21:42:24] wait… what? [21:42:42] an abstract class can extend another abstract calss [21:42:46] New patchset: JGonera; "Make sure anonymous users can't edit on mobile (#463)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60956 [21:44:11] New patchset: Jdlrobson; "Move header to generic MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58994 [21:45:00] awjr: but then wouldn't it have to avoid implementing? or maybe i'm misunderstanding [21:45:23] awjr: i'm tired so maybe i'm not making sense - anyway the above should be agreeable? [21:45:46] hehehe jdlrobson im not sure of the specifics without looking it up, it's been a while since i've done it [21:45:57] jdlrobson: yeah, don't worry about it for now - lemme take a look [21:47:34] that looks more sensible, jdlrobson - lemme test - OuKB what do you think ^? [21:48:39] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60956 [21:50:27] awjr, about making it abstract? [21:50:41] OuKB: no, about the latest changeset [21:51:45] i think in the longer term abstracting that would be cool, but curious if you think it's good enough for now [21:53:03] getSearchPlaceholderText() duplicates the logic of getMode() on a new level [21:53:35] it takes mode awareness out of MinervaTemplate, which i think is fine for now [21:53:40] if it's required by other revs, we can merge it and I'll refactor shortly [21:54:46] New review: awjrichards; "Looks fine for now; we can keep iterating on this" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/58994 [21:56:24] the only other thing is that i feel like things like prepareCommonData() should do ONLY that… prepare the data; not output HTML too [21:56:47] awjr: prepareCommonData only prepares data [21:56:51] no output html.. [21:57:04] it prepares the html for the header but doesn't render it [21:57:14] oh my bad, i misread [21:57:29] awjr: it's confusing - i tried to separate one giant commit into logical small chunks [21:57:31] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60696 [21:57:38] but it only becomes clear what i'm doing when you see the finished skin [21:57:39] :( [21:57:46] yet minerva progress \o/ [21:57:51] heheh yes [21:58:06] awjr: so who's +2ing ? https://gerrit.wikimedia.org/r/#/c/58994/ [21:58:09] any reason why not? [21:58:21] i was hoping for OuKB's blessing first [21:58:48] meh [21:59:15] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58994 [21:59:55] so OuKB awjr https://gerrit.wikimedia.org/r/#/c/58996/ should be an easy one [21:59:59] it's a simple lift and shift [22:00:07] New patchset: awjrichards; "Code move: Lift and shift html rendering to MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58996 [22:00:25] (well with some renames) [22:04:34] New review: JGonera; "I have $wgResourceLoaderDebug = true;" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60684 [22:09:51] jdlrobson: in https://gerrit.wikimedia.org/r/#/c/58996/7/includes/skins/MinervaTemplate.php why are renderFooter() and render() private? [22:10:09] renderLanguages() is public [22:10:43] awjr: errrrr mm [22:10:47] awjr: probably can be public [22:11:11] the only reason you'd want it private, i guess, is if you'd *NEVER* want a child interfering with those [22:11:33] not a big deal for now, but was curious [22:12:07] pretty please protected not public [22:12:20] yeah that would make senes [22:12:31] sense, too [22:13:29] New review: Jdlrobson; "Juliusz... I'm not expecting you to +1 that something that doesn't work for you but I'm trying to cl..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [22:17:59] New patchset: awjrichards; "Code move: Lift and shift html rendering to MinervaTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58996 [22:18:22] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997 [22:19:13] New review: Jdlrobson; "Marking as -1 just as I'm not sure you'll see the comment otherwise - but apart from that fix this l..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60956 [22:19:36] New review: JGonera; "Jon, sorry for misinterpreting." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [22:27:02] New patchset: Jdlrobson; "Bug 47598 Make Special:Nearby work on desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61496 [22:27:39] New patchset: JGonera; "Make sure anonymous users can't edit on mobile (#463)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60956 [22:30:55] New review: Jdlrobson; "/me interested to see if this annoys/upsets anyone." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60956 [22:30:56] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60956 [22:31:14] * jdlrobson off to sleep [22:32:56] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58996 [22:33:28] bah, trying to use a shared preferences listener to detect when the sync completes but the callback isn't firing [22:34:18] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61496 [22:36:36] dfoy - emailed [22:38:08] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997 [22:48:58] brion: in order to make card https://mingle.corp.wikimedia.org/projects/analytics/cards/503 actionable i've started a list of popular wikipedia based apps on iOS on http://www.mediawiki.org/wiki/Mobile/User_agents#Un-Official_Apps [22:49:12] brion: past sniffing their traffic. how would you start sourcing their UA's ? [22:49:19] nice [22:49:29] well, sniffing the UAs in our logs should turn them up [22:49:42] though it's possible many will have generic UAs that don't identify themselves well [22:49:58] we could also try contacting the various app authors and ask [22:50:10] but that's hard to scale if there's a lot :) [22:50:23] there will be over a dozen [22:50:32] so anything manual is already going to be slow [22:54:51] Maryana: for https://mingle.corp.wikimedia.org/projects/mobile/cards/358 - is the view supposed to persistent even if a browser session ends, or the user logs out/logs back in? [22:56:53] tfinc: it's probably not too hard to build an automated report that slurps every UA that claims to be 'iOS', sort em, and display them for humans to check if they mention an app name [22:57:06] "not too hard" for them analytics people anyway :) [22:58:27] awjr - ideally, yes... [22:58:48] Maryana: ok we need a new card then since it wasn't mentioned in the acceptance criteria [22:59:13] yeah, i wasn't sure how hard/possible that was, so i didn't include it [22:59:19] the code that was merged satisfies the acceptance criteria, but no more [22:59:35] so it doesn't seem to fully persist if you log out/close your browser [23:00:00] ok - if you want that functionality, let's add a card and we can discuss with folks [23:00:13] word [23:03:17] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61386 [23:03:40] New review: Maryana; ""If someone is interested in playing the wikipedia nearby photo hunt game they will click through" �..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [23:04:11] awjr, O RLY? [23:04:24] eh OuKB? [23:05:12] the WL settings are saved to DB [23:05:52] i know [23:05:58] but the interface doesn't handle it quite right [23:06:25] OuKB, we're doing things a bit differently on the mobile watchlist. we're allowing you to easily toggle between the "view all pages" view and "view recently changed items" view. those prefs, afaik, don't get saved to any db [23:07:02] so if you go to your desktop watchlist and open "view and edit raw watchlist," then log out and log back in and tap the watchlist link, it'll take you back to the recently changed items watchlist view [23:07:09] not the view and edit raw watchlist view [23:07:16] » » if ( $user->getOption( $name ) != $value ) { 513 [23:07:16] » » » $user->setOption( $name, $value ); 514 [23:07:16] » » » $this->optionsChanged = true; 515 [23:07:16] » » } [23:07:47] so let's say you selcet the 'modified' view, and the 'talk' filter - close your browser, open it up again, and navigate to watchlist, the 'all' view will be active (though if you switch to 'modified' view, the 'talk' filter will be active) [23:09:19] it is close [23:12:43] brion: grrr ... internet sharing is not forwarding DNS requests. i'm getting a bunch of 'udp port domain unreachable' ideas? [23:13:15] ugh [23:13:18] that's odd [23:13:55] i worked around it [23:14:08] told the phone to use google's dns servers [23:14:13] \o/ [23:15:25] New patchset: MaxSem; "Story 358: Persistent watchlist view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60692 [23:16:59] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60692 [23:28:37] Krinkle: we could use your or another RL-expert's input on https://gerrit.wikimedia.org/r/#/c/60346/ [23:38:19] jcmish: do we have a way we can repro this problem? https://bugzilla.wikimedia.org/show_bug.cgi?id=46241 [23:42:55] New review: awjrichards; "jenkins? you awake?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [23:44:28] um [23:44:36] OuKB: still awake? [23:44:42] yep [23:45:00] any idea why jenkins isn't even trying to merge https://gerrit.wikimedia.org/r/61474 ? [23:45:14] "The change could not be rebased due to a path conflict during merge." [23:45:20] also, Jenkins is slow today [23:45:22] ... [23:45:26] i am not seeing that comment [23:45:38] click on rebase [23:45:47] oh [23:45:56] it will probably run gate tests later [23:46:02] sigh. [23:47:12] jgonera: https://gerrit.wikimedia.org/r/#/c/61474/ is not happy with a rebase :( [23:48:12] awjr, ok, let me check [23:48:12] i can try and clean up conflicts but i suspect you're more likely to get through it faster/with less errors than i [23:48:17] thanks jgonera [23:51:09] awjr, that's a tougher one, gonna take a few minutes... [23:51:19] yeah jgonera looked nasty [23:51:58] 9 minutes till cutoff:) [23:52:15] no pressure [23:59:23] while rebasing I discovered [23:59:49] that one of the commits a) will probably break some acceptance tests b) left some cruft in CSS [23:59:57] one of the Minerva commits