[00:08:20] New review: JGonera; "Checked with Vibha and Maryana, they approved the new footer layout. Regarding issue #1, I don't hav..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [00:10:36] New review: awjrichards; "Also -2'ing until we figure out how to handle this in regards to production caching." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/61474 [00:11:03] awjr, so can we revert "Revert "Change remaining #mw-mf-header occurrences to .header""? [00:11:30] jgonera: yeah i already did, i think just waiting on jenkins/zuul to… go [00:11:41] ok, thanks [00:11:57] jgonera: https://gerrit.wikimedia.org/r/#/c/61727/ [00:11:57] np [00:25:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61727 [00:30:12] Maryana, what's Kaldari's nickname on IRC? [00:30:24] i think it's kaldari :) [00:30:29] oh [00:30:41] what channels does he frequent? ;) [00:30:49] hmm.. not sure [00:31:04] maybe try #wikimedia-staff? [00:31:10] nope, not there [00:31:29] hmm... [00:32:38] i don't see him in the tech channel either [00:32:41] not sure [00:32:56] you could, of course, go visit him IRL ;) [00:34:33] I'll wait until I have more questions ;) [00:35:24] ok - just let me know if i can help [00:37:35] jgonera: he's usually in #wikimedia-dev [00:37:41] ok, thanks [00:37:53] or … -tech [00:37:53] or both [00:38:09] MaxSem, still around? [00:38:10] and yeah, his nick is just 'kaldari' [00:38:17] yup [00:38:18] what's the difference between -dev and -tech? [00:38:36] #-dev is for programming stuff [00:38:41] MaxSem, did i show you the new and improved SMS/USSD system that works in russian? :) [00:38:51] #-tech us for "omg wp is down" [00:38:59] technically tech is for help with the wikis, dev is for actual dev-related qs/discussion [00:39:03] what max said [00:39:19] yurik, wee [00:39:20] I see ;) [00:42:12] MaxSem, just sent you a copy of the log - it has some fun stuff you'll appreciate [00:42:27] Maryana might also like it come to think of it [00:42:41] (basic unicode->latin transliteration of the text messages) [00:43:05] hmm? [00:43:47] is there any standard way of checking if another extension is loaded? or should I just pick one of the global classes/variables it creates and check isset()? [00:43:54] Maryana, i was involved in USSD/SMS project - so now it also allows to read cyrrilic wikies in latin [00:43:55] Predstavliaet soboi? [00:44:02] Predstavlyaet soboy! [00:44:09] oh nice! [00:44:25] MaxSem, https://pypi.python.org/pypi/Unidecode [00:44:51] MaxSem, i suspect this is done in a very language-neutral way [00:45:09] as it doesn't know that its russian or bolgarian [00:45:26] does anyone actually use these gateways? [00:45:45] MaxSem, going live in a few weeks, will see :) [00:47:53] Maryana: how would you like to handle redeployment? do you want me to reschedule something for this week or should we just wait for the next regular window? [00:48:32] it doesn't look like we have anything really critical that needs to go out asap [00:48:51] the nearby styling would be nice to fix, but it's just beta [00:49:03] so i'd say wait for next window [00:52:03] ok cool Maryana, thanks [00:57:34] ok, so just to be sure because I'm a bit paranoic after today ;) HTML for logged in users is not cached at all, right? [00:58:09] that is currently correct, jgonera - as well as for alpha/beta [00:58:21] ok, good [00:58:42] in the long run, it would be nice if we *could* cache article text for those buckets too, so we should could keep that in mind as we move forward [00:59:48] sure, I'm just thinking if everything will explode when I add number of Echo notifications to the chrome in alpha [00:59:56] @_@ [01:00:03] dude [01:00:04] awesome. [01:00:32] I'm just playing with it now, but it shouldn't be very difficult [01:00:34] yeah, we dont really need to worry about it for now [01:00:37] ok [01:00:47] totally - from what kaldari explained to me a few weeks back it sounded like echo makes it pretty easy [01:00:54] yep [01:00:58] ok, gotta catch the bus [01:01:03] cool man, have a good one [01:01:04] see you tomorrow! [01:01:07] see ya [01:02:05] im outta here too - hasta mañana everyone [02:52:58] [Commons-iOS] montehurd opened pull request #55: Greatly improved scrolling perfomance (master...scrollImageFade) http://git.io/_YEPGg [11:06:52] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61694 [11:08:26] New review: Jdlrobson; "@jgonera correct" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [11:24:06] New review: Jdlrobson; "Retracting Arthur's -2:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [13:07:43] New patchset: Jdlrobson; "Story 498 Beta: Lazy load sections in beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61580 [13:40:56] New patchset: Jdlrobson; "Add cachedpage.sh, apply fix for bad deployment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [14:25:12] New patchset: Jdlrobson; "Bug 31876: Add an html validation test to Makefile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61775 [14:36:49] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [14:40:23] New patchset: Jdlrobson; "Add cachedpage.sh, apply fix for bad deployment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [14:48:14] New patchset: Jdlrobson; "Bug 47857: Deprecate #mw-mf-searchForm, allow search term clearing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61553 [17:14:32] https://gerrit.wikimedia.org/r/#/c/54987/ < MaxSem [17:28:55] awjr, MaxSem do we know for sure if we'll do cache flush after the next deployment? [17:29:06] no jgonera [17:29:22] which probably means we won't do it [17:29:28] unless we really need to [17:29:28] I see [17:29:54] but we will need to coordinate a plan with ops in advance [17:30:02] well, I can try to make the old footer HTML work with the new CSS if I have to [17:30:24] my current thinking is that it might be best to wait until we're ready to move the new nav to stable (since we'll definitely need to flush then) [17:30:33] jgonera: i think jdlrobson beat you to it, actually [17:30:55] ok, then that's the first thing I'll do after some code review [17:31:02] im not sure if this covers everything, but looks like it adds backwards compatability: https://gerrit.wikimedia.org/r/#/c/61773/2 [17:31:07] oh [17:32:43] well, that's only the header, now I'll do the footer too ;) [17:32:51] :) [17:33:01] actually before you do that jgonera [17:33:22] we chatted a bit about this with Maryana during standup - we might not actualy want a b/c footer [17:33:39] she doesn't want two different versions of the footer out in the wild [17:33:55] if we can wait for the new footer, it might be best to bundle it with other changes that will require a flush (eg new nav) [17:35:17] I see, although it already makes me scared that I'll have to write that from scratch with Minerva's progress [17:35:20] or rebase daily [17:35:30] i see what you mean [17:35:45] hrm [17:35:51] man, i wish i had thought of this when we were discussing the footer changes originally :( [17:35:53] but now we know [17:36:39] so i moved the new nav stuff to the iteration after next. that means they'll go out sometime mid-may [17:36:52] Maryana: and that's for beta to start, right? [17:36:54] well, ok, let's try to wait, I'll rebase every day and see if there are changes that mess it up often [17:37:01] awjr, yep [17:37:23] so that means new nav will not be in stable probably until beginning of june [17:37:36] (assuming there are no issues/major changes) [17:37:40] uh [17:37:52] so why exactly having two different footers for a month is that bad? [17:38:01] Maryana: ^ [17:38:21] i can check in w/legal. my gut says they will not be pleased [17:38:25] but maybe i'm being overly cautious [17:38:40] i'll try to grab them today and resolve this [17:38:42] ok [17:39:16] aside from legal not being happy, i imagine we'll get a lot of feedback about the footer looking broken [17:39:37] but we can also let OTRS volunteers know so they can have a canned response for that kind of thing [17:40:40] good call [17:40:50] we can say we're a/b testing it :) [17:40:54] lol [17:41:06] just like them big fancy internet companies [17:41:48] actually [17:41:57] how hard would it be to get logging on the form? [17:42:03] err footer [17:42:05] jgonera ^ [17:42:21] just the about & disclaimers links would even be good [17:42:31] when nature hands you an experiment... [17:42:54] it shouldn't be that hard [17:42:59] should be doable ;) [17:43:41] :) [17:44:31] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61773 [17:46:39] jgonera: the script doesn't work for you o_O [17:46:49] nope [17:47:10] I'm guessing Linux/Mac incompatibilities [17:47:12] also i'd rather not split them up independently as i think the context of how i got the fix is important [17:47:29] jgonera: are you any good with shell scripts? [17:47:34] potentially i might not be :) [17:47:41] only if I have to ;) [17:47:47] confused by the schema error [17:47:51] I'll try changing #!/bin/sh to #!/bin/env bash later [17:47:56] * scheme [17:48:04] sh != bash, at least on Linux [17:48:13] mm what happens if you remove that line? [17:59:19] right, the regular http:// urls ;) [17:59:23] jdlrobson: iirc that change is waiting on either being made backwards compatible or for 1.22wmf3 to be deployed everywhere in produciton (which won't be until next weds) [17:59:46] jdlrobson: what if we just diff'd the two pages and used that for manual review for now? [17:59:59] awjr: that's not the purpose of the script [18:00:01] the purpose is to view css issues [18:00:08] you should be able to determine html changes in theory from looking at MinervaTemplate.html (in future at least anyway) [18:00:25] awjr: in terms of that change - i'd rather not rebase it again - is there no way we can cherry pick the core commit in next deployment? [18:00:27] well, it's not just CSS issues we need to be concerned about - JS as well [18:00:56] jdlrobson: yeah, like i said in the comment, we can either backport the core change to 1.22wmf2 (though some folks frown on that practice and tend to get annoyed when we do that), make our change backwards compatible, or just wait [18:00:57] jdlrobson, regarding "action" in https://gerrit.wikimedia.org/r/#/c/61553/2/javascripts/modules/search-2.js [18:01:02] we actually don't need it [18:01:02] I think [18:01:06] because if someone has JS, then they won't submit the form anyway, will they? [18:01:16] anyway, wgScript is definitely nicer, so I'll merge anyway ;) [18:01:18] jgonera: they will [18:01:18] pressing enter causes a full text search [18:01:18] oh, when they press Enter [18:01:18] right [18:01:18] ok [18:01:19] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61553 [18:01:40] jdlrobson: wouldn't automated browsers tests be able to help us with breaking css/js changes? [18:02:22] awjr: i'm not sure i need to understand what tools we have at our disposal. Worth running that question by michelle when she's back [18:02:30] definitely [18:02:41] jgonera, take a look when you get a sec: http://meta.wikimedia.org/wiki/Schema:MobileWebEditing [18:02:47] and make any edits you see fit :) [18:03:08] i talked a bit with michelle about this last week - she's been waiting to coordinate broader automated browser testing until they either sort out the issues they've been experiencing with watir or choose another tool [18:03:18] im not sure what the current status of that is [18:03:32] today's her birthday too, what a bummer to be sick :( [18:03:44] awjr: yeh i saw :( [18:04:43] ok guess we're not doing the mobile app retro since tfinc is out [18:04:45] bbiab [18:04:52] Maryana, "True if the referrer article the user is adding an image to is editable based on user privileges" [18:05:04] err, whoops [18:05:05] so that's for the upcoming editing changes? [18:05:08] copy pase fail [18:05:13] *paste [18:05:21] I mean, we won't use it with current editing? [18:05:34] yeah, that's not applicable [18:05:56] just cut it [18:08:31] Maryana, I think that's ok in general, I guess we want to leave both token and username if at some point we decide to allow anonymous users to edit [18:08:55] true.. [18:10:08] editAttempt is just shwoing the form? [18:10:10] New patchset: Jdlrobson; "Bug 44918: MF part of code that forbids legacy gadgets in mobile view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61028 [18:10:21] Maryana, ^ [18:10:23] MaxSem: awjr - we also need a core change for https://gerrit.wikimedia.org/r/#/c/61028/ [18:10:45] jdlrobson, no [18:10:49] jgonera, yep [18:10:55] just someone tapping edit [18:11:15] I'll remove the "edit" prefix from actions, is that ok? [18:11:48] jdlrobson, https://gerrit.wikimedia.org/r/#/c/61028/ can be safely merged - it will not cause problems if mixed with older Gadgets [18:12:06] MaxSem: roger [18:12:20] MaxSem: i will +2 if jgonera or awjr haven't looked at it in the next hour [18:13:05] it was definitely worth it to wait for the gadgets change to be merged because CR might have resulted in changes to it [18:13:15] but once it's merged, there's no reason to wait [18:14:59] jdlrobson, I'm not sure what that hook does [18:15:03] where is it documented? [18:15:05] jgonera: which hook? [18:15:12] the allowLegacy [18:15:35] see parent commit referenced in commit [18:15:43] see the linked change [18:16:09] New patchset: awjrichards; "Bug 44918: MF part of code that forbids legacy gadgets in mobile view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61028 [18:18:47] New patchset: Jdlrobson; "Bug 35233: Stop mobile site indexing in google by properly using a canonical url" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61809 [18:20:15] MaxSem, jdlrobson, so what's the difference between legacy and non-legacy gadgets? shouldn't we document that hook somewhere like most of the hooks are? [18:20:41] jgonera, there's no standard for documenting extension hooks [18:21:07] waiiiit [18:21:12] hooks are documented on mw.o [18:21:13] and Gadgets hook documentation are really tangential to MF [18:21:19] awjr, core ones [18:21:33] oh, is that not what we're talking about? [18:21:34] Maryana, why do you think WAP should be killed? I thought that with Zero we should get a lot more WAP clients [18:21:44] jgonera, as of legacy gadgets - it means they're not delivered via RL [18:21:49] oh nm i forgot gadgets is an extension [18:22:24] yurik, it's not so much that i want it killed. i just want to understand how many users we're actually getting with it, so i can factor that in against the technical debt it forces our team to incur :) [18:22:47] MaxSem, I see, thanks [18:23:34] Maryana, true that, but we really should also look at it in terms of how much each new Zero partner adds to it [18:23:47] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61028 [18:23:51] that's a good point, yurik [18:24:22] Maryana, but yes, I agree. Anything non-HTML5 should die a very short, yet painful death [18:24:22] totally yurik, that thought hadn't occurred to me [18:24:38] *groan* london [18:24:51] eh jdlrobson? for wikimania 2014? [18:24:54] yehh [18:24:57] how dull [18:25:06] it was DC last year [18:25:08] bleh, lets do israel again - good fruits!!! [18:25:13] awjr: that was dull too ;-) [18:25:21] jdlrobson: i would argue it would have to be more dull than london [18:25:23] New review: MaxSem; "Oh lol." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61809 [18:25:39] Reykjavik? [18:25:48] that would be sweet [18:26:02] i've never been to a wikimania though, so i can't really talk i guess [18:26:20] i've been holding out for hong kong this year :) [18:26:55] awjr, Maryana, from my SA trip, it seems that on one hand, the entire continent has mobile phones. And a VERY large proportion of those phones is actually smart or blackberries [18:27:08] the rest are fairly complex nokias [18:27:16] which support wap [18:27:19] jdlrobson, https://gerrit.wikimedia.org/r/61809 depends on a bunch of other commits:( [18:27:33] I personally prefer to chain as little as possible [18:27:43] and some basic HTML, but the extent of that is ... to put it mildly... shi**ty [18:27:55] MaxSem: I do normally but I wanted to show the story of why a html validation script is important ;-) [18:28:03] can always cherry-pick and resubmit [18:29:36] so MaxSem jgonera is https://gerrit.wikimedia.org/r/#/c/59560/ good now? [18:29:49] also https://gerrit.wikimedia.org/r/#/c/59559/ [18:30:00] (which it depends on and is probably more important) [18:30:37] i'd just like to get all these older patch sets off my plate now so i don't have to rebase them again [18:31:09] New review: JGonera; ""Scheme missing" was because I didn't have MEDIAWIKI_URL set. See inline comments." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61773 [18:31:41] jdlrobson, I don't know yet, haven't gotten to it yet [18:33:36] New patchset: Jdlrobson; "Bug 35233: Stop mobile site indexing in google by properly using a canonical url" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61809 [18:33:48] New review: Jdlrobson; "cherry picked so no dependency" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61809 [18:33:52] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61809 [18:34:45] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61775 [18:40:27] jdlrobson, how do I start a lead section discussion on my test article? [18:43:42] New patchset: Jdlrobson; "Add cachedpage.sh, apply fix for bad deployment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [18:43:57] ^ jgonera [18:44:08] jgonera: on talk page just add some text at top of talk page [18:44:13] edit it manually no heading [18:44:26] e.g. HELLO WORLD \n == topic title== [18:44:33] HELLO WORLD would be the lead discussion [18:45:09] MaxSem: in reply to https://gerrit.wikimedia.org/r/#/c/61775/1/scripts/w3c-validate.sh [18:45:15] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59559 [18:45:49] in theory it could but i like having it in the dev directory for better transparency [18:46:13] jdlrobson, whom should I CC in my proposal about CN browser detection? [18:46:23] hmm [18:50:16] New review: JGonera; "Replied in patchset 3 comments." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [18:50:35] jdlrobson, jgonera: i have a file that the latest changes in https://gerrit.wikimedia.org/r/#/c/56613/9 does not work for [18:50:49] shall i add a test for it and ammend the commit so you can see? [18:51:59] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [18:52:04] awjr: what's the file name? [18:52:19] File:This work? 2013-04-29 12-9.png [18:52:47] hm, what's the output? [18:52:58] This work? 2013-04-29 12-9 [18:53:20] MaxSem: cc mobile-l [18:53:31] could do with some sanity checking [18:53:34] oh, right, 12-9 [18:53:38] jdlrobson, are all the analytics doodz on it? [18:53:47] awjr: so it's basically because the date format is different? [18:53:54] that shouldn't happen too, I'd rather fix filename generation [18:53:58] sounds too tecnical for a general list [18:54:00] looking at the regex [18:54:00] awjr: i wouldn't -1 for that particular case [18:54:01] minutes should have leading zero [18:54:11] awjr: we are never going to cover all edge cases [18:54:21] jdlrobson, but it's our bug [18:54:29] we should optimize for what the mobile photo upload generates as most of our users will be going through there [18:54:36] we don't generate the time string appropriately [18:54:59] jgonera: we don't? Well that's a separate bug that should be raised and fixed orthogonal to this patch set :) [18:55:08] true [18:55:09] it seems to me easy enough to accommodate for this case [18:55:13] will do that [18:55:23] awjr, it is, but this case should have not happened ;) [18:55:26] you're not going to be able to go back and fix all the filenames that have been generated incorrectly [18:55:33] true [18:55:33] awjr: exactly [18:55:58] actually i guess you could but that would be even more work than i imagine it's worth [18:56:03] so awjr jgonera +2 https://gerrit.wikimedia.org/r/#/c/56613/ ? [18:56:29] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/56613 [18:56:46] MaxSem: send it to mobile-tech first then - i'll forward and maybe tweak to mobile-l if I think it's of interest [18:58:56] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61775 [18:59:07] need to rush off for food. WIll poke around later to see what's going on. :) [19:01:26] dr0ptp4kt, ping [19:01:43] yurik, poong [19:01:52] yurik s/poong/pong/ [19:02:54] dr0ptp4kt, dfoy replied with some comments, hope you understood what they are about :) [19:03:08] yurik, i did. just about to e-mail both you and dfoy. you guys are good writers. [19:03:23] dr0ptp4kt, rright [19:03:46] yurik, not only of english prose, but also code [19:03:58] dr0ptp4kt, flattery is paramount! [19:04:18] yurik, i'm thankful. this is fun work. [19:04:20] dr0ptp4kt, btw, did you check in the script? I have been thinking of some creative uses for it ;) [19:04:36] what lang is it in? [19:05:07] yurik, i did it in php. gonna send a question in a couple of minutes about which branch or review you want me to add it to. [19:05:27] dr0ptp4kt, master is fine - it goes into maintenance/ anyway [19:05:59] i guess i will have to do another script in python (shouldn't be hard really, will use pywiki) - as there is no good CIDR library in php [19:06:59] yurik, you should write a CIDR library in PHP! people would like it! [19:07:25] dr0ptp4kt, i considered it, but I think I should do something more productive :) [19:07:51] actually there is already an IP handling lib for php, a pretty extensive one. It just needs some algos [19:08:27] yurik, :) [19:13:11] Maryana, do you want to check on the progress of talk pages? I have Jon's latest commits running on my laptop [19:13:19] yesssss [19:15:41] New review: JGonera; "In general works nice. Apart from the inline comments I have two comments about the UI:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/59560 [19:23:16] update on footer situation: legal is okay with having some weirdness for a little while [19:23:21] awjr, jdlrobson ^ [19:23:29] just told jgonera, too [19:23:56] so we can go ahead and push that change and just wait for it to sort itself out [19:31:08] [Commons-iOS] brion pushed 5 new commits to master: http://git.io/BuBGWw [19:31:08] Commons-iOS/master f609086 Monte Hurd: Merge remote-tracking branch 'upstream/master' [19:31:08] Commons-iOS/master c35d5b6 Monte Hurd: Vaslty improved scrolling and thumbnail loading performance... [19:31:08] Commons-iOS/master 2976a55 Monte Hurd: Further reduction in fade duration for non-iPad... [19:31:16] brion: woohoo! [19:31:33] mhurd: only change i made was to double the thumb res on retina displays [19:31:54] if we want to get fancy later we might consider loading a low-res thumb first, then a high-res thumb if the cell stays onscreen :) [19:34:23] brion: true. and if compression level becomes an option we could adjust it for non-broadband users [19:35:37] resolution's waaaay easier to vary on so far :) [19:40:01] true. hmm i wonder how much bigger the double-res files are? [19:40:28] prob not double because of jpg compression, unless compression level is low [19:41:06] yeah, i forget the typical ratio -- i should probably make some stats some time [19:41:12] but i don't recall it being too awful [19:42:03] yeah i've heard it suggested to use high-res images at a lower compression ratio for retina [19:42:18] ends up looking nicer than the low-res images but doesn't increase the dl size as much [19:45:39] iirc double res does quadruple the pixel buffer memory required by the device once the file is decoded… but retina devices should handle it nicely [19:45:59] yeah, they've got the VRAM and pixel-pushing power to handle it [19:46:15] ya [19:46:15] but they say don't load retina images on non-retina devices if you can help it, so that's an improvement over what we had before :D [19:46:26] for sure! [19:47:07] definitely it's much more responsive on the iPad mini now, job well done! [19:47:21] :) [19:54:28] New review: Jdlrobson; "I was hoping just to get the functionality in there and then get a designer to look at it and maybe ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [19:58:16] gotta charge stuff, & gonna grab some lunch. bbiab [20:13:34] New patchset: JGonera; "Fix file name and description generation in uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61824 [20:15:34] New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [20:16:46] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [20:19:37] dr0ptp4kt, could you re-run the script [20:19:41] the IPs are now sorted :) [20:20:38] huh I somehow closed the mobile channel on IRC [20:21:36] yurik, yup, will do. it will now *not* add showZeroBanner to the json unless the value is false (i.e. showLangs <= 1). btw, do you want showZeroBanner to have an explicit true/false in the TSV, or only have a value if it's false? [20:22:11] dr0ptp4kt, i guess TSV should have all the values, and the uploader script should decide how to upload. [20:22:40] dr0ptp4kt, btw, are you already at the stage where the TSV file is parsed and uploaded to the site? [20:22:42] New review: JGonera; "There's one thing I forgot about: the CSS fix fixes the layout, but there were many more references ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [20:22:51] or is it more like a log [20:23:16] New review: JGonera; "Oh my gerrit... -1 was not persisted. See previous comment." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61773 [20:42:49] http://test-reportcard.wmflabs.org/graphs/active_uploaders_commons_target [20:49:10] dr0ptp4kt, need to take off for a while, email if you have questions [20:49:27] dr0ptp4kt, thx. i'm going to grab some food shortly, too. [20:49:44] yurik, sorry, ^ meant that for you [20:52:27] dr0ptp4kt, are you talking to yourself again? [20:52:59] yes. in code, too. sudo dr0ptp4kt eatlunch.sh [21:34:11] Maryana, I thought that maybe we'd like to add the hardware back button for closing overlays as a low priority story/bug for next iteration [21:36:51] yeah, i bumped it back because it looked like we already had a lot of things in the sprint [21:37:07] it's see where we're at when we estimate the remaining stories [21:37:16] i think it's probably fine to keep in there; we're on the lower end of story points [21:37:24] ok, cool [21:37:24] we can always reasses on monday [21:37:41] aighty, moving back to the bottom of the next iteration :) [21:38:29] you want more work? i'll give you more work! [21:38:50] i guess that's what we get for getting stuff done [21:38:56] haha [21:39:13] MaxSem: where are htings at with the OSM build out? [21:39:49] it reoccurred to me today that we've kinda stopped tracking some of the infrastructure/other backendy work not directly related to MobileFrontend in Mingle [21:39:58] awjr, labs work is mostly blocked due to that bug [21:40:10] yeah makes sens [21:40:10] e [21:41:05] MaxSem: would you like me to help get some of the work you've been doing outside of MobileFrontend up on Mingle, or do you prefer how things have been going? [21:46:12] awjr, I believe that the right course of actions would be to start attracting more ops attention, Tomasz will talk about it with the higher ups [21:46:26] MaxSem: eh? [21:46:31] oh, you mean in regards tot he labs issues? [21:47:41] no, wrt doing it [21:51:00] im confused MaxSem what specifically are you talking about? [21:51:51] the osm manifests and stuff like that [21:52:09] oh [21:52:11] yes :) [21:52:51] i was asking more generally about whether or not you want the non-MF work you've been doing to be tracked in mingle again (since we sorta stopped doing that again) [21:54:48] jgonera, Maryana: i just chatted with ori RE https://mingle.corp.wikimedia.org/projects/mobile/cards/684 - he's concerned about logging full URLs (log line byte limit of 1024) and suggested we try just logging page titles [21:55:14]