[00:00:00] New patchset: MaxSem; "Rm DeviceDetection::supportsJQuery()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61934 [00:00:01] no idea, this file was there before I joined [00:04:16] I would love to see it burn [00:12:01] probably a good idea, need to check with Jon first though [00:16:25] hey Maryana [00:16:36] heya ragesoss [00:16:38] what's up? [00:16:41] good news / bad news [00:16:45] ruh roh [00:17:07] [[selfie]] got a mention in teh media: http://www.slate.com/articles/life/gentleman_scholar/2013/04/how_to_take_a_selfie_for_men.single.html [00:17:15] haha [00:17:18] is that good or bad? [00:17:22] good. [00:17:32] but yesterday, some people agreed to remove the gallery. [00:17:47] what?? lame [00:17:50] apparently, it's much more in line with how srs Wikipedia articles are supposed to look. [00:18:20] that's silly [00:18:23] it's mentioned in slate! [00:18:30] we have muppet porn on commons! [00:18:56] well, the gallery isn't mentioned on slate. [00:19:07] :( [00:19:20] sigh [00:19:29] "Is it me, or is this page slowly becoming a repository for editors who want to show off their pic? Do we need that many examples?" [00:19:40] not slowly, it started out like that. [00:19:43] and yes. [00:19:44] ha [00:19:46] yes we do. [00:20:11] sadly, i think this is just one of those systemic bias things that we can only fix by bringing more reasonable, diverse people into our projects [00:21:00] I think the article just needs to be fleshed out more, with refs and prose for each style of selfie. [00:21:05] … unfortunately, who wants to join a club where you're actively discouraged from showing your face? [00:21:11] then those all can be added back but not in a gallery. [00:22:11] it's also really handy to have a diverse set of faces on commons. maybe we can finally start illustrating our articles with non-white, non-european-looking faces... [00:22:32] meh [00:24:21] yeah. I tried to make the gallery as diverse as possible. but alas. [00:25:56] heh, adding back this guy is totally doable using that slate article as a ref: http://en.wikipedia.org/wiki/File:Lead_Photo_For_DonateImage0-09435469635476434.jpg [00:26:16] I feel a special bond with that guy. [00:31:51] New review: Dr0ptp4kt; "This has been verified as working in staging. Yurik, would you please code review the 2 changed line..." [mediawiki/extensions/ZeroRatedMobileAccess] (production); V: 2 - https://gerrit.wikimedia.org/r/61926 [00:34:09] yurik ^ can you drop into gerrit and handle this? dfoy said to go ahead and do this to rectify an issue for a carrier. [00:34:20] dr0ptp4kt, reviewing [00:35:01] yurik, thx [00:40:20] New review: Yurik; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (production) C: -1; - https://gerrit.wikimedia.org/r/61926 [00:40:28] dr0ptp4kt, reviewed [00:41:34] MaxSem: still alive? [00:41:45] yurik, what's the -1 for in this case? need i modify something? [00:41:46] yep [00:42:05] dr0ptp4kt, yep [00:42:12] MaxSem: when you have the chance can you take a look at https://gerrit.wikimedia.org/r/#/c/61941/1 and corresponding bug? (maybe tomorrow tho - go sleep!) [00:42:16] yurik, what's that? [00:42:31] dr0ptp4kt, click on the comment in the file [00:42:35] will do [00:42:40] thanks [00:43:21] are there any other possibly affected wikis? [00:45:04] yurik, oh, yes, okay, i see. agreed. will amend shortly. don't normally like messing with central variables but in this case that variable is only used by those two rewriters. stand by... [00:45:39] MaxSem: should just be commons and meta [00:45:45] cool [00:46:49] yeah those are the only two projects that explicitly set their whole domain as the CetnralAuth cookie domain [00:47:00] grr http://www.useragentstring.com/pages/Kindle%20Browser/ [00:49:09] New patchset: Dr0ptp4kt; "Appending 'wiki/Main_Page' to home page links currently pointing to http://[LANG_CODE].(zero|m).wikipedia.org/. Currently, users accessing http://[LANG_CODE].zero.wikipedia.org/ are incorrectly being redirected to http://[LANG_CODE].m.wikipedia.org/ witho" [mediawiki/extensions/ZeroRatedMobileAccess] (production) - https://gerrit.wikimedia.org/r/61926 [00:50:34] yurik ^ attempt 2 [00:50:36] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (production) - https://gerrit.wikimedia.org/r/61926 [00:50:41] dr0ptp4kt, already +2 [00:50:48] yurik, you're quick [00:51:36] dr0ptp4kt, dfoy, not sure why, but the warning here is shown in english--not good. http://ru.zero.wikipedia.org/wiki/Main_Page [00:51:50] New patchset: MaxSem; "Device type rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [00:52:10] New review: MaxSem; "WIP" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61942 [00:54:46] New review: Dr0ptp4kt; "Patch Set 2 also works in staging at the Special:ZeroRatedMobileAccess path with the correct X-Carri..." [mediawiki/extensions/ZeroRatedMobileAccess] (production) - https://gerrit.wikimedia.org/r/61926 [04:01:09] [android-commons] valeriej opened pull request #13: Instructions on how to set up IntelliJ (master...master) http://git.io/SPK1CQ [04:36:48] [Commons-iOS] montehurd opened pull request #56: Made messages appear if no images are found (master...visualOnFirstLogin) http://git.io/7i9VJg [09:10:27] New review: Jdlrobson; "See for yourself :)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [09:14:38] MaxSem, hi [09:14:48] yo [09:15:46] MaxSem, apparently this is causing some serious ZERO bugs https://gerrit.wikimedia.org/r/#/c/61926/ [09:15:57] and dan wants it deployed asap [09:16:13] is it causing or fixing them? [09:16:24] the patch should somewhat fix it [09:16:33] apparently there is somewhere some magic redirect rule [09:16:36] that causes issues [09:16:54] but this way it doesn't... supossedly [09:17:00] adam would know more [09:17:28] is production branch up to date? [09:17:44] no idea - i wasn't here when you two were deploying it :) [09:18:30] i seriously have no clue what is in production - will need to take a few lessons from you on how to deploy and do other magic [09:18:52] you already showed it once, but i wouldn' twant to do it without some serious oversight [09:19:07] do you remeber that Zero branches thread? [09:19:17] ?? [09:19:38] MaxSem, no idea what you meant [09:20:13] not running on all cylinders - its 5:30 here [09:20:19] am [09:21:23] ohhhh [09:21:36] then go to sleep, I'll try to figure it out [09:21:42] thx :) [09:21:58] but don't do too much without me - I want to see how to do it [09:22:08] or should i watch it now? [09:22:15] dafuq? that revision is wrong [09:22:24] it assumes English everywhere [09:22:36] nah, i think it works in other langs [09:22:38] i tried ru [09:24:08] you think? [09:24:23] people will get redirected to non-existent pages [09:25:02] try it in the browser, after setting X-Device, X-Carrier, and X-CS [09:25:08] there is no redirect [09:25:13] just shows the page [09:25:45] my device & UA are set to "android", X-Carrier to "Dialog Sri Lanka", X-CS - 250-99 [09:25:58] can't wait to get the zero config deployed [09:26:13] next tuesday. hope you can help with that [09:27:21] with wiki language set to 'en'? [09:27:36] MaxSem, the bug is when you try to navigate to http://ru.zero.wikipedia.org -- it gets auto-redirected to "m" [09:27:38] ?? [09:27:52] MaxSem, any language [09:27:59] howwwww? [09:28:05] i'm confused [09:28:14] what are you asking?+ [09:28:14] I don't understand this [09:28:21] which part? [09:28:26] want to do hangout? [09:28:45] I'm telling you that people will be redirected to sq.m.wikipedia.org/wiki/Main_Page [09:29:35] MaxSem, nope, it doesn't [09:29:40] check for yourself [09:29:54] it only redirects to "m" if there is no path [09:30:12] are you already awake or still awake? [09:30:21] still awake [09:30:27] MaxSem, hangout? [09:30:32] sure [09:32:07] MaxSem, don't see u there [09:32:15] where? [09:32:23] MaxSem, google hangout [09:32:31] in gmail chat [09:40:51] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [09:57:48] New patchset: Jdlrobson; "Bug 31876: Add an html validation test to Makefile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61775 [10:01:35] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [10:02:21] New patchset: Jdlrobson; "Add cachedpage.sh, apply fix for bad deployment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [10:03:07] New patchset: Jdlrobson; "Add hashbang to qunit.sh" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61969 [10:03:39] New patchset: Jdlrobson; "Add cachedpage.sh, apply fix for bad deployment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [10:07:55] where is that jdlrobson?:P [10:08:43] New review: Jdlrobson; "Like the idea but please don't reorder the regexs :)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61942 [10:12:18] * MaxSem bites jdlrobson [10:47:51] New patchset: Jdlrobson; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [10:57:38] New review: Jdlrobson; "All this does in dynamically load sub sections. Inspect the DOM for #content_1 and you will see it i..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [11:00:57] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61934 [12:42:50] New patchset: Jdlrobson; "Make the universe explode by making a desktop AND mobile skin called Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997 [12:43:19] New review: Jdlrobson; "So... when can we merge this and start paving the way to having nice skin code?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997 [13:46:49] New patchset: Jdlrobson; "[Alpha] Talk: Write the number of talk topics in the talk bubble" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [13:47:07] New review: Jdlrobson; "@MaxSem - different approach" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [13:49:21] New patchset: Liangent; "Calculate talk page name correctly for namespaces other than main" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [13:52:22] New review: Nikerabbit; "Please have a empty line after the first line next time to separate subject from the description." [mediawiki/extensions/ZeroRatedMobileAccess] (production) - https://gerrit.wikimedia.org/r/61926 [13:58:05] New patchset: Liangent; "Calculate talk page name correctly for namespaces other than main." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [15:11:58] New patchset: Jdlrobson; "Bug 47586: Remove DeviceDetection js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [15:14:10] New review: Jdlrobson; "Waiting on dependency... otherwise CentralNotice module will break and throw js exception." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/61989 [15:27:12] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [16:01:09] New review: Liangent; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [16:28:14] New review: Jdlrobson; "Talk module will not run on talk page. On special page it will not execute." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [16:29:26] New review: Jdlrobson; "(but happy to merge as is if necessary). Juliusz?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [16:55:19] has anyone seen Michelle? [16:58:52] yurik: nope [16:59:06] she was out sick yesterday, so maybe she's still not feeling well [16:59:25] hope everything's ok with her [17:02:47] MaxSem: thanks for getting that fix for meta login out :) [17:02:53] :) [17:05:25] MaxSem: do you know why Jon decided to push device detection into CentralNotice? [17:05:45] because I wanted so >:) [17:05:59] heh [17:06:17] basically, X-Device is not intended for platform or feature detection [17:06:21] New review: Liangent; "I'm just used to typing bitwise operations when dealing with these subject/talk issues." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [17:07:06] furthermore, we don't even guarantee that we will not merge 'andorid' into 'webkit' one day, depriving you of even that information [17:07:27] so, a separate detection solution is needed [17:08:02] gotcha... I talked briefly to mark this morning about serving the detected device along with geoip information from varnish; but he wasn't much of a fan [17:08:06] I was slowly writing to summarize this (and more) in a email, but Jon beat me to it with an actual commit [17:08:16] and I'm not exactly a fan of having to manage multiple device lists [17:08:30] ok -- I'll wait for the email then [17:09:57] anyone knows how to lure Jon into irc?:) [17:12:01] MaxSem: tell him 'free hat!' [17:14:14] or call him... http://www.youtube.com/watch?v=NsJLhRGPv-M [17:15:39] New review: Liangent; "And in ancient ages, bitwise operations are considered faster than arithmetic operations." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [17:15:41] New patchset: Liangent; "Calculate talk page name correctly for namespaces other than main." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [17:39:59] dr0ptp4kt, hi, could you re-run the script to upload everything to meta? We will re-run it later to let the cleanup logic do its magic :) [17:41:54] dr0ptp4kt, and please please commit it (as a separate patch to master branch) [17:43:07] ok my mac sees my linux machine's web server, but my linux firefox doesn't [17:43:08] *headdesk* [17:43:56] ooooh i bet it's cause i've got a 32-bit firefox [17:44:14] * brion installs lib32nss-mdns [17:44:20] why that's not included with ia32-libs i'll never know [17:44:46] * brion goes to file a bug \o/ [17:55:30] https://bugs.launchpad.net/ubuntu/+source/ia32-libs/+bug/1175708 whee [18:04:27] no jdlrobson, no jgonera - a disaster:P [18:04:42] I'm here, sorry [18:07:47] New patchset: MaxSem; "Device type rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [18:08:30] jgonera, you trolled me by one second [18:08:38] that's pretty jediish:P [18:08:44] hehe [18:10:55] jgonera, we currently serve ie.css to user-agents matching /MSIE (8|9|1\d)/ - is it needed by other trident-based crap? [18:11:22] not sure, but what other trident-based browsers for mobile are there? [18:11:46] MSIE [1-7] :P [18:11:57] *shudder* [18:12:00] or even probably desktop IE [18:12:34] did y'all see my bug that windows phone 8 IE hits all our checks for supporting file uploads but doesn't? yeah, that's awesome [18:12:48] I'm not sure if we should serve any JS/CSS for IE < 8 [18:13:13] brion, no, what's the URL? [18:13:15] RL handles the JS part, but CSS... [18:13:57] we definitely need some CSS. even for Trident:P [18:14:03] https://bugzilla.wikimedia.org/show_bug.cgi?id=47374 [18:49:46] ok tidying up the last of the firefoxos fixes so that's out of my hair [19:05:49] hmm, never knew that /foo/ and /bar/ is faster than /foo|bar/ [19:24:03] New patchset: MaxSem; "Device type rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [19:51:59] tfinc: can we talk tomorrow? they were able to fit me into the doctor but only if I can get there in the next 30mins [19:52:11] jcmish: sure [19:52:19] thanks same time? [20:12:35] Maryana, there's a contradiction in the copyvio story I guess [20:12:42] "I have less than 3 edits on the local WMF wiki where I�m uploading from, and 0 uploads to Commons" [20:13:09] when someone uploads something, they no longer have 0 uploads so they won't see the second and third message [20:13:19] ok, done with the firefox os updates, just need to get it deployed then i'm back to ios and android work \o/ [20:25:07] jgonera, right, the 0 uploads part just applies to the first-time message [20:25:09] the full one [20:25:22] so after someone makes an upload, they shouldn't see that one [20:25:35] does that make sense? [20:25:35] ok, so if we showed the first one, we always show the next ones? [20:25:43] yes [20:25:46] I see [20:26:41] also: https://mingle.corp.wikimedia.org/projects/mobile/cards/743 [20:26:46] lemme know if that makes sense [20:29:25] New review: awjrichards; "i like the direction this is heading in!" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61942 [20:34:24] mhurd, anything for me to check on? [20:34:31] ah there's a pull req i'll test that now :D [20:36:02] ya just that one for now [20:36:52] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61580 [20:41:16] Maryana: were starting to see the early crash http://mobile-reportcard.wmflabs.org/ [20:41:26] mhurd, looks good but id' recommend prefixing those enum constants [20:41:32] oh and i should test on ipad too :D [20:42:07] New patchset: MaxSem; "Device type rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [20:42:21] New patchset: Yurik; "Removed all carrier-specific names and banners from i18n file" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62034 [20:42:56] ok looks good on ipad too :D [20:43:15] will do! [20:43:19] mwalker, seen my email? [20:44:20] New review: awjrichards; "jdlrobson, can you please split up this commit so the 'fix for bad deployment' is in another changeset?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [20:46:32] brion: will push update in a bit - tweaked a couple other things too [20:53:28] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61969 [20:53:51] ok [21:02:30] tfinc: i started pulling some simple conversion stats: https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0ApHbVP8ovBVIdHJBaXJuUlJSWjQ2Y2Z0SG5TcEszdHc#gid=5 [21:04:26] the login to upload conversion is much lower than industry standard. i really think 1st time UX is key for getting people who log in to make that first upload [21:34:23] Maryana: nice. i'll take a look at it today/tomorrow [21:46:08] Maryana: conversion for web, or apps? [21:46:18] oh, just apps [21:46:40] ahh. interesting. [21:47:08] i think the rule of thumb is generally a 20% dropoff for each step - install, open, login, use [21:47:13] err, attempt, use [21:48:14] I'm sure lack of AC is a big part. [21:48:33] but we're getting an 85% dropoff between login and attempt [21:48:42] a/c? :) [21:48:48] yeah, it is quite hot in here [21:48:49] dr0ptp4kt, good job! now, should we wait for zero deployment first, and then fix it for X-CS only? [21:48:55] account creation. [21:49:12] nah, i'm just looking at the step between login & attempt upload [21:49:16] but your stat axes that hypothesis [21:49:22] yeah... [21:49:46] i think we're getting some noise from the various tech media posts that went out [21:50:14] yurik, i think we need to add the vary header to MobileFrontEnd. if we add X-Carrier, X-Subdomain, and X-CS now that should future proof the code. [21:50:31] dr0ptp4kt, ok [21:51:14] how many logins have 0 uploads? [21:51:28] including desktop [21:51:47] yurik, can you think of any downside with that? in theory all three of those headers should always be present for participating carriers, so there shouldn't be problems with cache fragmentation above and beyond what's strictly necessary…i think. [21:53:27] dr0ptp4kt, come to think of it, you can already base it on X-CS only because that is always set [21:53:37] +device? [21:54:04] ragesoss, 2537 since the official apps launch [21:54:12] out of 2877 total logins [21:54:27] 88% [21:55:02] that many newbies? or just no app uploads? [21:55:25] yurik, lemme look. we still need X-Subdomain so that it's clear when a user is navigating to [lang_code].zero.wikipedia.org or [lang_code].m.wikipedia.org and gets the correct cached 301. [21:55:39] yurik, looking at vcl... [21:55:56] unique logins, right? I've logged in 100 times. [21:56:06] dr0ptp4kt, but isn't cache based on URLs? [21:56:39] and the subdomain would be part of that url? [21:59:30] ragesoss - yeah uniques [22:01:27] MaxSem: your email makes sense -- I will poke around at the patches a little bit more to make them a more permanent solution. [22:01:32] yurik, iirc varnish actually proxies the call to [lang_code].wikipedia.org before it sends it in, so we're stuck with having X-Subdomain in there for the moment. [22:02:09] dr0ptp4kt, thx, didn't know that, then yes, subdomains it is [22:09:55] brion: just pushed update [22:30:16] brion: doh! forgot one thing and just pushed it [22:33:22] heh [22:33:38] good thing i was busy with email for 20 minutes :) [22:35:27] brion: :) [22:39:13] gotta go run an errand - back in a bit [22:42:43] [Commons-iOS] brion pushed 5 new commits to master: http://git.io/WK4gOw [22:42:43] Commons-iOS/master 767e709 Monte Hurd: Made message appear if no images are found... [22:42:43] Commons-iOS/master 7012ef7 Monte Hurd: Forgot the sync message! Added it. [22:42:43] Commons-iOS/master 9355354 Monte Hurd: Made lines to buttons be drawn with core animation... [22:43:44] mhurd, looks awesome [22:43:51] i like the animated lines :D [22:44:01] woohoo! [22:44:55] New patchset: Dr0ptp4kt; "Adding X-Subdomain, X-Carrier, and X-CS to HTTP 301 Vary: header." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62105 [22:45:51] tfinc: what did that feedback have to do with campaigns? [22:46:10] lolz [22:46:13] wrong email [22:46:14] haha [22:46:14] did you mean that for the other guy? [22:46:52] yup. just sent it [22:53:49] New review: Yurik; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62105 [22:53:58] dr0ptp4kt, -1 :) [22:56:24] yurik, fair enough, hang on a sec [22:56:41] brion: just noticed if you tapped the add image toggle really quickly the welcome message could get out of sync. just pushed a fix to the branch you just merged [22:56:51] \o/ [22:56:56] fix ALL the bugs! [22:57:07] they must go [22:57:10] brion, the best part about wellness plan - you can spend it on a massage! :) [22:57:16] New patchset: Dr0ptp4kt; "Adding X-Subdomain, X-Carrier, and X-CS to HTTP 301 Vary: header." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62105 [22:57:32] i hate strangers touching me :D [22:57:47] it's awful for my mental health ;) [22:58:16] brion, it all depends on who you pay to massage you ;) [22:58:19] durrrr, all the ios stuff is on my mac and i'm on my linux, that's why my git isn't there [22:58:28] well they won't pay my wife to do it i'm sure ;) [22:59:06] brion, but if she declares it as business income... [22:59:15] heh [23:01:26] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/PsX-Xw [23:01:26] Commons-iOS/master a240c4b Monte Hurd: Add image toggle tapped quickly bug... [23:01:26] Commons-iOS/master eb107c5 Brion Vibber: Merge remote-tracking branch 'monte/visualOnFirstLogin' [23:07:09] brion: just pushed one more! sorry! last one :) [23:09:16] heh [23:11:29] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/jHaHWQ [23:11:29] Commons-iOS/master 97c3733 Monte Hurd: Add image toggle tap while refreshing caused welcome msg out of sync... [23:11:29] Commons-iOS/master 67d0323 Brion Vibber: Merge remote-tracking branch 'monte/visualOnFirstLogin' [23:15:17] jgonera, estimate this when you have a sec? https://mingle.corp.wikimedia.org/projects/mobile/cards/743 [23:16:11] Maryana, could you mark next to each graphs name which one is new and which one not? [23:16:19] sure thing [23:18:55] ok, now with color tags! [23:18:59] jgonera ^ [23:19:25] not sure how you want to do the special pages rendering time stuff [23:19:39] should those three bar graphs have the target line too? [23:19:43] I guess not? [23:19:52] yeah, we don't have a growing target [23:20:02] though i guess having a flat 1k target line might be ok [23:20:04] ok [23:20:12] let's make that optional :) [23:20:31] I'd rather not hardcode a target graph, maybe let's skip it for now [23:21:00] fine by me. and our target might change anyway [23:21:55] any guesses as to story points? [23:22:11] special pages rendering time - we need to talk about this more. even if we log page names, special pages have different names in different languages (even the Special word) [23:22:31] so we'd have to log also some boolean value saying if page is special [23:22:39] or limit this to English wikipedia [23:23:19] just logging english wikipedia would work, honestly [23:23:31] it's something like 80% of our audience [23:23:52] hm [23:24:07] ok, let's add it to the story then [23:24:24] let's say it's 5 points, and let's leave the special pages graph as optional [23:24:59] ok. one more thing: is it more technically complex to separate the uploaders bars by web, android, and ios? [23:25:56] something like this: http://www.tigerlogic.com/tigerlogic/omnis/developers/images/technews/g2mstackedbargraph.jpg [23:25:59] jgonera? [23:26:51] Maryana, no idea, you should ask milimetric if limn supports those graphs [23:27:01] hmmm [23:27:15] ok, back to the copyvio story ;) [23:27:27] ok, sorry to bug you [23:27:29] :) [23:27:42] yurik, would you be able to take a look at https://gerrit.wikimedia.org/r/#/c/62105/ ? this is a pretty hot one [23:34:15] dr0ptp4kt, how urgent is it? [23:35:16] MaxSem, i'll go ask. the guys are next door. [23:36:47] dr0ptp4kt, i could totally look at it, but i have no clue if it will fix it - do we know anyone who knows about addVaryHeader() ? [23:37:08] Maryana, how do I explain "This is not a personal photo" message in i18n? [23:37:14] MaxSem, as usual is the best expert around it seems :) [23:37:27] "Explain to users that they can't upload selfies"? [23:37:27] haha [23:37:31] yeah, i mean, that's pretty much it [23:37:38] personally, I would like to have a separation between MF and Zero [23:37:55] maybe use the more formal self-portrait [23:37:57] but I guess I can't use "selfies" in i18n description [23:37:59] MaxSem, https://gerrit.wikimedia.org/r/#/c/62105/2/includes/MobileFrontend.hooks.php [23:38:00] oh ok [23:38:16] so, you just need to use the same hook in Zero [23:38:19] no photos of yourself or your family [23:38:21] something like that [23:38:35] MaxSem, yes, zero should not be the same as mobile, which should be part of core really [23:38:36] Maryana, *unless they're notable [23:38:39] because we were also getting a lot of photos of people's kids [23:38:41] hehehe [23:38:42] true [23:38:52] unless they're famous... [23:39:10] jgonera, famous != notable [23:39:23] dr0ptp4kt, did you have a chance to run the script on meta? [23:39:36] well, yeah, is there a Britney Spears article on Wikipedia? is she "notable"? [23:39:44] New review: MaxSem; "Please do it in Zero instead." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62105 [23:40:50] is notable synonymous with famous? if yes - yes, if no - maybe [23:41:05] Maryana, should I just say "no self-portraits or portraits of family/friends" and assume that not too many famous/notable will use the upload feature? ;) [23:41:15] i think that's a safe assumption, yes [23:42:57] brion: any advice on the "fix uploads list for >500 uploads" card? should i just update "500" to "1000"? now that the images are loading on a background thread things should be maybe ok? [23:43:13] https://wiki.openstack.org/wiki/Special:Version <— using a very new version of mobile frontend [23:43:23] I hit it on my iphone and no device detection [23:43:37] is there any special configuration I need? [23:44:05] Ryan_Lane, what caching are you using? [23:44:10] none [23:44:17] well, I'm using memcache [23:44:19] and apc [23:44:20] heh [23:44:25] but no frontend cache [23:44:55] wasn't it you who added support for that apache thingie? [23:45:06] mobile frontend has native device detection [23:45:10] so says you guys [23:45:18] yep [23:45:20] $wgMFAutodetectMobileView [23:45:31] why isn't that documented? :) [23:45:31] but apache's faster [23:45:47] $wgMFAutodetectMobileView = true; ? [23:46:21] documentation? /me looks at Ryan_Lane as at a blasphemer [23:46:25] yes [23:46:34] hahaha [23:46:36] that didn't do anything [23:46:47] i think jon started documenting that stuff a while back [23:48:50] hm. it works if I set the user agent in my desktop browser [23:48:59]