[00:01:58] damn it [00:02:02] I forgot to login: http://www.mediawiki.org/w/index.php?title=Extension:MobileFrontend&oldid=684125 [00:03:19] :) [00:03:24] thanks [00:03:31] hooray for docs! [00:03:31] :) [00:03:34] yw [00:03:40] im doing a quick cleanup of the device detection page now as well [00:03:47] cool [00:05:47] New review: Asher; "I would rather not see an additional BeforePageRedirect hook added for such a rarely applicable case..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62105 [00:05:50] awjr: MaxSem mhurd brion jgonera: heads up that our next showcase is this upcoming monday [00:06:23] ok [00:06:43] monday it is then :D [00:06:56] ya [00:06:58] i should have ios categories working (ooooh!) [00:07:19] awesome! [00:09:27] brion: can you handle the Android demo while mhurd does iOS ? [00:09:48] New review: awjrichards; "Ultimately we should keep X-CS in MobileFrontend and set Zero-specific headers in Zero - we should b..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62105 [00:10:53] tfinc, sounds good [00:30:37] New patchset: Dr0ptp4kt; "Adding X-Subdomain and X-CS to HTTP 301 Vary: header for Zero traffic." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62105 [00:33:32] MaxSem, awjr - can we get ^ pushed in? [00:33:58] as I already explained, it's not so easy [00:38:12] MaxSem, the context that the existing MobileFrontEnd hook has is useful for knowing if the url is mobile targeted. Asher indicated that he would prefer to keep it in MobileFrontEnd to avoid having another hook point. i did add an if clause to check for the presence of X-CS and X-Subdomain to reduce unnecessary addition of Vary: list items. [00:38:26] yeah [00:38:37] but I'm too sleepy for today [00:38:49] MaxSem, understood. Do you think we could get this in after you get some rest? [00:39:03] have you read my email? [00:39:12] MaxSem, not yet, sorry. just a sec. [00:40:16] MaxSem: when you have a moment: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_Browser_Auto-Detection#Separate_mobile_and_desktop_domains_.28Recommended.29 [00:40:27] aha [00:40:32] MaxSem, okay, i'll loop in greg on that e-mail thread. [00:40:34] er, https://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_Browser_Auto-Detection [00:40:54] i filled it out a bit, hopefully more accurately - it would be good if you can review [00:44:20] mhurd: do you know how far brion got with https://trello.com/card/ios-add-categories-ui/51756be77b9586a0780053c0/16 ? [00:45:13] no, but he mentioned above he thinks it'll be ready monday [00:45:34] k [00:46:16] mhurd: i'd like to move anything left in the todo column back to the backlog. is there anything that you don't want me to move ? [00:46:34] tfinc: i'll check... [00:46:58] tfinc: no [00:51:46] yurik, i haven't run the script against meta. i actually think i will need to mod the script to grab centralauth cookies. alternatively, i could add the config pages manually, seeing as we already have the correct data. the data would be tight, so there's not much risk of making a mistake. [00:52:15] yurik, i gotta run, but lemme know what you think. [00:52:24] mhurd: k. their all moved to the backlog now [00:52:42] tfinc: looks good :) [00:57:10] New review: awjrichards; "Actually, I confused myself. X-CS is also zero-specific (I was thinking of X-Analytics). Unless we n..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62105 [01:05:11] mhurd: whats actually happens if you have 500+ images https://trello.com/card/ios-fix-uploads-list-for-500-uploads/517b115c243fd8d361000faa/27 ? [01:05:36] tfinc: brion said it only downloads the 1st 500 [01:05:42] k [01:05:54] i think it was super choppy on it's way to doing so [01:06:08] so the fixes from the last couple days will help [01:06:26] but for actually getting more than 500 may have to do multiple requests [01:06:37] brion pointed me in the right direction [01:06:47] but still playing with it [01:07:32] k, i'm putting together the backlog for sprint 8 . here is a preview https://trello.com/board/mobile-app-backlog/517b115c243fd8d361000faa [01:07:36] things may change by monday [01:07:58] i had to split android and iOS as it was getting too hard to read [01:08:25] looks nice! [01:09:00] mhurd: only the ready for dev column would be picked up. since we don't have estimation yet how do you feel about the current depth of the column between you and brion ? [01:09:40] just the ready for dev [01:10:11] ya makes sense [01:13:30] New patchset: JGonera; "WIP: Story 483: Show intermediate copyvio/scope message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [01:37:14] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62105 [01:37:21] dr0ptp4kt: ^ [10:13:03] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61981 [10:17:01] where art thou Jon?:) [15:00:42] Project WikipediaMobile - Nightly builds build #516: STILL FAILING in 1.7 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/516/ [15:00:42] Brion VIBBER: Script to check completeness of translations for Win8 app [15:00:51] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/oJ014Q [15:00:51] WikipediaMobile/master 02c18a3 Brion Vibber: Script to check completeness of translations for Win8 app [15:22:22] dr0ptp4kt, do you know why there is no index file for zero? http://staging-zero.wmflabs.org/ [15:23:06] yurik, not sure about that. michelle may actually know. [15:50:53] Project WikipediaMobile - Nightly builds build #517: STILL FAILING in 2.4 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/517/ [15:50:54] * Brion VIBBER: Win8: list supported languages in manifest [15:50:54] * Brion VIBBER: Trim win8 language list to supported by store [15:51:01] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/uqonXg [15:51:01] WikipediaMobile/master 9b94f40 Brion Vibber: Win8: list supported languages in manifest [15:51:01] WikipediaMobile/master 0774434 Brion Vibber: Trim win8 language list to supported by store [15:54:14] New review: Dr0ptp4kt; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62105 [15:55:04] awjr ^ [16:20:56] hey MaxSem ! :D [16:23:35] yo! [16:25:57] MaxSem: so on https://gerrit.wikimedia.org/r/#/c/61775/2/scripts/w3c-validate.sh [16:26:11] we're doing the same as the qunit script so I'd rather not repurpose [16:26:37] does anyone use a different setup currently? (phantomjs tests/externals/phantomjs-qunit-runner.js "$URL/index.php/Special:JavaScriptTest/qunit?filter=MobileFrontend&useformat=mobile&debug=true") [16:27:14] dr0ptp4kt, jcmish when would you like to do the setup? [16:27:16] also the default is just because jgonera wrote the first script and that's his default setup ;-) [16:27:44] yurik, jcmish: i defer to you two [16:27:45] i'd rather not delay merging this though for something trivial that we might not even need - someone can always rewrite if necessary [16:27:56] ^ MaxSem [16:28:00] I have standup in 30 mins but I can work with you guys after that dr0ptp4kt and yurik [16:28:34] I used to have the classical scheka with w/index.php and wiki/Article_title [16:28:42] jcmish, sounds good, 2pm EST/11am Pacific ? [16:28:53] s/scheka/schema/ [16:28:58] New review: Jdlrobson; "Please reconsider and merge in light of my comments. Minor fix ups like this should not stop code ge..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61775 [16:29:00] dr0ptp4kt, ^^ [16:29:14] sounds good yurik and dr0ptp4kt [16:29:56] jcmish, yurik: cool [16:30:21] dr0ptp4kt, jcmish so sorry, can we push it up one hour? scheduling conflict? [16:31:06] yurik, jcmish: works for me [16:32:04] jdlrobson, re https://gerrit.wikimedia.org/r/#/c/60093 - so there will be just that red thingie with a number? [16:32:24] MaxSem: correct [16:32:38] MaxSem: the idea is to give the reader an idea of new topics without having to visit the talk page [16:32:41] I'm flexible dr0ptp4kt and yurik [16:32:56] MaxSem: do people tend to remove topics from talk pages when they have been solved? [16:33:12] there are even archival bots [16:33:36] MaxSem: in athena there is a similar idea but used suffix conversations http://upload.wikimedia.org/wikipedia/commons/thumb/2/28/Athena-Wikimania-2012-BrandonHarris.png/400px-Athena-Wikimania-2012-BrandonHarris.png [16:34:00] HATEHATEHATE [16:34:06] MaxSem: why so? [16:34:06] (Beatles) [16:34:10] oh lol [16:34:16] you don't like the beatles o_O [16:36:52] New patchset: Jdlrobson; "Add cachedpage.sh to identify potential caching problems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [16:36:53] New patchset: Jdlrobson; "make css backwards compatible with old html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62164 [16:44:25] New review: Jdlrobson; "I'd be keen to keep Firefox. It's significantly different." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61942 [16:45:08] New review: Jdlrobson; "ps. i'd still distinguish between ie8 and others as they are significantly different. ie < 8 doesn't..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [16:49:01] dr0ptp4kt: and yurik sorry I messed up the timezones I have a 1:00pm - 1:30pm appt [16:49:07] working with a volunteer [16:50:08] jcmish, i thought htat's what you said? [16:50:09] dr0ptp4kt: and yurik what about 1:30pm MT/12:30pm PT? [16:50:27] ohh, you are in MT [16:50:32] yup! [16:50:32] :D [16:50:39] jcmish, yurik, works for me [16:51:12] jcmish, sent an update [16:51:19] thanks guys [16:52:56] jdlrobson, significantly different from what? [16:58:13] New patchset: Jdlrobson; "Bug 46804: Make padding consistent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62166 [16:59:34] New patchset: Jdlrobson; "jshint: fix bad line break" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62167 [16:59:43] standup, anyone? [16:59:46] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62167 [17:09:27] dr0ptp4kt: just FYI I'm conducting a test with Orange Central African Republic until 11am (previously scheduled earlier this week). [17:11:31] MaxSem: awjr anyway we can edit the commit for https://gerrit.wikimedia.org/r/#/c/61899/ [17:11:39] i hate commits that are factually incorrect :) [17:12:13] jdlrobson: that will need a followup [17:12:24] awjr: it's the commit summary itself though.. [17:12:29] not the commit [17:12:33] jdlrobson: oh [17:12:45] Completely blacklist Opera Mobile from RL should be Completely blacklist Opera /Mini/ from RL [17:12:48] i dont think you can do it through gerrit once it's been merged, but im not sure [17:12:59] errgggg :( [17:13:03] talk to roan or chad i guess (catrope, ^demon respectively) [17:13:12] i know it's possible in git [17:25:25] New review: JGonera; "Doesn't fix it. Cancel and Submit buttons still look taller. Plus, you reduced left/right padding wh..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62166 [17:32:38] New review: Jdlrobson; "Then the bug is not clear which says that the buttons in the photo upload form should be the same as..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62166 [17:33:59] jgonera: can you let me know what to do about https://gerrit.wikimedia.org/r/#/c/59785/ asap so i can make the fix? i'm awaiting your response.. [17:34:11] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [17:34:26] New patchset: JGonera; "Add cachedpage.sh to identify potential caching problems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [17:34:27] New review: MaxSem; "Since there's no FF X-Device, this change doesn't reduce our support for it." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [17:34:41] ok, this one will be next [17:36:05] New patchset: JGonera; "Add cachedpage.sh to identify potential caching problems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [17:36:23] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61773 [17:36:44] MaxSem: I don't see how bug https://bugzilla.wikimedia.org/show_bug.cgi?id=30827 relates to that commit? [17:36:58] that says it was RESOLVED WONTFIX.. [17:37:35] Maryana: any updates to https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0Aoizbfxc5g6KdEkza0xkQnJlM0o0TXlwQXhDOUFvYnc#gid=0 ? [17:37:38] roadmap [17:37:50] jdlrobson, so why the data- attribute? why we're not storing the sections in a JavaScript object? [17:38:07] tfinc: will take a look later today - probably some tweaks to be made [17:38:15] is it true that were not doing anything with beta labs in may ? [17:38:16] k [17:38:29] jgonera: well we don't have models. This is a simple way for dynamic sections to work without changing a model and refreshing it [17:39:06] jgonera: if you can find a better way of writing it be my guest but this was the best i could come up with after 2 days of scratching my head [17:39:12] I don't understand. we don't have models so what do you mean by "changing a model"? [17:39:26] Samsung browsers accept vnd.wap so it will be treated as a WAP browser w/o that check [17:40:13] jgonera: my main question at the moment is should i remove the hijacked links and random module code altogether? [17:40:59] jdlrobson, I'd do that. it's not doing anything right? so why is it there? we should probably rewrite it, and if we really want to reuse later, we can retrieve it from git history [17:41:15] jgonera: the backbone way is to change the model and refresh the view [17:42:02] jdlrobson, I know, but we're not using backbone atm ;) [17:42:12] jgonera: exactly... [17:42:16] ok, let me have a second look [17:42:17] hence my point [17:43:25] Maryana: as an app using Wikimedian what do you think i could add to http://wikimania2013.wikimedia.org/wiki/Submissions/Why_Apps,_Commons,_and_Wikimedia_go_great_together in order to get more attendees ? [17:46:56] jdlrobson, so... can we join the 2 blackberrys? [17:47:09] jdlrobson, so why do you think that using the data- attribute is better/simpler than using page.getSubSection? [17:47:26] MaxSem: So max… the problem with blackberrys is there is webkit and non-webkit [17:47:32] ok, wait, maybe I'm beginning to understand ;) [17:47:32] yeah [17:47:41] if we can catch webkit in a separate one i think we're good just having a blackberry [17:47:45] and the webkit ones are detected as webkit [17:47:55] MaxSem: and that has precedence yes? [17:47:56] cuz they call themselves BB [17:49:07] Mozilla/5.0 (PlayBook; U; RIM Tablet OS 1.0.0; en-US) AppleWebKit/534.11 (KHTML, like Gecko) Version/7.1.0.7 Safari/534.11 [17:49:44] hmm, not always... will need moar tests [17:50:43] jdlrobson, no I don't understand [17:50:52] why do you think that using the data- attribute is better/simpler than using page.getSubSection? [17:51:09] jgonera: i don't understand what you don't understand. [17:51:24] data- vs. page.getSubSection [17:52:01] why would we want to switch from the former to the latter [17:52:39] New patchset: MaxSem; "[Alpha] Talk: Write the number of talk topics in the talk bubble" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [17:52:41] jdlrobson, ^^ [17:53:29] jgonera: why am i switching? [17:53:35] yes [17:53:40] jgonera: there are 2 things that need to happen when you toggle open a section [17:53:45] 1) check if it needs toggling [17:54:11] 1) check that it needs /injecting/ [17:54:13] 2) inject [17:54:19] and also know what to inject [17:54:36] what do you have against the data attribute? [17:55:00] also how would the toggle section access the associated javascript section? [17:55:10] it just doesn't feel right, plus we're doing that to avoid the overhead of inserting too much stuff into DOM, and this attribute is a part of DOM [17:55:34] jgonera: we're doing this to avoid image loading into the DOM and initial page load [17:55:55] jdlrobson, let me try to edit this patchset in an hour or so, ok? maybe then I'll realize what the obstacles are ;) [17:56:02] as i said before feel free to rewrite it another way if you can find another way to do it - but this was the simplest i could come up with [17:56:11] jgonera: ok. let me just remove link hijacking code first [17:56:12] jdlrobson, I've seen many pages avoiding image loading until you scroll without such tricks [17:56:17] jdlrobson, ok [17:56:36] ok, brb, need to talk with Maryana and Vibha [17:56:50] dr0ptp4kt, meanwhile prepare for deployment :evilgrin: [17:57:14] get yourself a separate checkout of MW [17:57:14] MaxSem: will look in a sec [17:59:08] MaxSem, i think you're enjoying this too much ;) [17:59:12] New patchset: MaxSem; "[Alpha] Talk: Write the number of talk topics in the talk bubble" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [17:59:47] dr0ptp4kt, you WILL BE a deployer. and no, I'm not asking whether you want it or not:P [17:59:56] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/62105 [18:01:53] erggggggggg rebase conflicts AGAIN [18:01:54] grrr [18:23:34] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62105 [18:24:17] MaxSem: fyi we got ops' blessing on the zero change so i just merged it ^ [18:24:52] wee [18:25:08] dr0ptp4kt & yurik ^^ [18:30:17] dr0ptp4kt, ready? [18:31:34] MaxSem, i don't have my local environment readied, but if you want to push the change, YES, i'm ready :) [18:31:50] I want you to push;) [18:31:56] MaxSem, https://plus.google.com/hangouts/_/1a0b40d22ddce2923042bbaf0cb0562ac5e72a79?authuser=0&hl=en [18:34:59] MaxSem: dr0ptp4kt and i are hanging out in ^ and he's prepping for deployment now [18:35:50] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/59560 [18:51:24] jdlrobson is there anything I should do to see the number of talk topics after applying https://gerrit.wikimedia.org/r/#/c/60093/4 ? [18:51:30] because I can't see any number [18:55:12] New review: JGonera; "I can't see the number of topics anywhere." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/60093 [18:57:11] Maryana: as an app using Wikimedian what do you think i could add to http://wikimania2013.wikimedia.org/wiki/Submissions/Why_Apps,_Commons,_and_Wikimedia_go_great_together in order to get more attendees [18:58:56] tfinc - there's a thread on wikimedia-l about favorite wikimania talk proposals… you could respond and slip in a self-promotion :) [19:00:44] i'm not above that. but before i do. what do you suggest changing about mine? [19:01:03] most wikimedians don't use apps so i'd love your perspective of one that does like apps [19:02:40] New patchset: Dr0ptp4kt; "Remove conditional for X-CS and X-Subdomain check for Vary:." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62180 [19:02:43] New review: JGonera; "I hesitantly give it a +1, hoping that the "title in the header" issue will be addressed in future p..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/60684 [19:04:25] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62180 [19:07:34] New patchset: Dr0ptp4kt; "Adding X-Subdomain and X-CS to HTTP 301 Vary: header for Zero traffic." [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/62181 [19:07:34] New patchset: Dr0ptp4kt; "Remove conditional for X-CS and X-Subdomain check for Vary:." [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/62182 [19:09:10] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/62182 [19:09:11] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/62181 [19:12:39] New patchset: JGonera; "Bug 31876: Add an html validation test to Makefile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61775 [19:13:33] New patchset: JGonera; "Bug 31876: Add an html validation test to Makefile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61775 [19:14:16] New review: JGonera; "I agree that we should store the defaults for the scripts in one central place, but let's do it as a..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/61775 [19:20:34] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [19:21:21] jgonera: sorry was just grabbing dinner - if you read the code you'll see that the number of topics is only written on a save [19:21:29] so you will have to save the talk page before you see a number [19:21:37] oh [19:21:46] this is to make it less expensive [19:21:47] can any user save it and then everyone sees it? [19:21:56] yes [19:22:02] ok, let me try again then [19:22:05] it's a hook at the end of the save which writes it as a property [19:22:20] MaxSem pointed out that it's As I explained before, this is unacceptable from a performance point of view, and alpha is not an excuse go ahead. [19:22:46] (thus we don't do the lookup every time) [19:24:21] New review: JGonera; "Still looks broken on special pages (settings) because of the double padding." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62164 [19:24:58] yeah, I understand [19:25:32] but I thought we'd have a fallback like "if property doesn't exist then we generate it and populate" (without anyone saving the talk page) [19:25:54] jgonera: that would be extremely expensive [19:25:59] imagine a google crawler bot :) [19:26:24] right [19:26:52] New review: Jdlrobson; "special page html doesn't cache." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62164 [19:27:42] New review: Jdlrobson; "in which case don't need to generate cached_special :) duhhhh - i'll fix that now" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62164 [19:28:23] * jdlrobson facepalm [19:28:30] dr0ptp4kt, jcmish - http://api.beta.wmflabs.org/wiki/Test1?X-CS=250-99&useformat=mobile [19:28:55] cool thanks yurik [19:29:07] so we're going to use this to test against? [19:29:15] i wonder if its a security issue to be able to spoof x-cs [19:29:18] jcmish, yep [19:30:17] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61570 [19:33:03] dr0ptp4kt, around? [19:33:11] yurik, am busy [19:34:16] MaxSem, sorry, i'm in testing, what did i miss? [19:35:33] dr0ptp4kt, what are you up to? :) [19:35:46] * yurik is worried it will all collapse... [19:36:40] quirk, working with MaxSem to deploy cache variance fix [19:36:52] i'm not quirk! [19:37:05] have fun [19:38:04] New review: JGonera; "Minor ones." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61496 [19:39:02] jdlrobson, awjr_lunch, so special pages are absolutely _never_ cached? [19:41:08] jgonera, yes [19:41:19] jgonera: correct < MaxSem should be able to confirm [19:41:24] ah there we go ;-) [19:44:02] Can people take a look at testwiki? we're adding a cache variance change. MaxSem just pulled the change in [19:44:52] New patchset: Jdlrobson; "Cachedpage.sh adjustments" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62185 [19:47:24] New review: Jdlrobson; "See https://gerrit.wikimedia.org/r/62185 - special pages are not effected by caching." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62164 [19:53:27] wifi here is like india [20:02:11] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [20:05:36] New review: JGonera; "I think it would be better to make it a second optional argument for the script instead of an env va..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62185 [20:07:54] New patchset: JGonera; "make css backwards compatible with old html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62164 [20:08:30] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62164 [20:11:44] MaxSem: you there? i think I may have broken the api on master :-S [20:12:10] bad boy [20:12:33] i'm not sure what's going on [20:12:40] New patchset: JGonera; "Alpha: Allow users to start conversations on talk page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [20:12:56] but "text":"

is appearing in mobile section api response [20:13:02] should probably add a test to protect again that [20:13:08] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59560 [20:13:09] url: ?format=json&action=mobileview&page=Duel+Masters&variant=en&redirects=yes&prop=sections%7Ctext&noheadings=yes§ionprop=level%7Cline%7Canchor§ions=all [20:13:48] MaxSem: i think something went wrong in https://gerrit.wikimedia.org/r/#/c/60888/2 [20:15:44] although saying that MaxSem seems to be a problem there as well [20:16:49] MaxSem: can you replicate? [20:17:00] MaxSem: do you know what i'm talking about? :) [20:17:00] New review: JGonera; "Just tested. It's broken. Did you run it?" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61571 [20:18:05] sorry, just back from deployment, need to reload the knowledge base:) [20:18:09] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61496 [20:19:01] jdlrobson, when will you remove the hijacking code from https://gerrit.wikimedia.org/r/#/c/59785/ ? [20:19:16] jgonera: i'm doing it now but i'm troubleshooting the above bug [20:19:26] without it it's broken [20:19:27] ok, no problem, just let me know [20:20:05] jgonera: in terms of nearby caching i suspect it's another funky dependency issue with your weird setup :) [20:20:18] do you want to try it with jquery.json specified as a nearby dependency? [20:20:24] jdlrobson, jQuery does not have a toJSON function [20:20:41] oh well, this can be it, if that's a plugin [20:20:54] jgonera: the jquery json plugin [20:21:09] i think the module is jquery.json - i thought it was provided by default but would you care to check if that solves the problem? [20:21:18] ok, I'll try it although I think you should fix this one yourself :P [20:21:45] jgonera: i'm currently refactoring the section code for you so would really appreciate you checking this out since you can replicate it.. [20:22:52] dr0ptp4kt, MaxSem deployment go ok? [20:22:52] ok, jdlrobson, in future just test with $wgResourceLoaderDebug = true; too (or debug=1), then you'll get the same env I have [20:22:52] so MaxSem i'm not sure when this started happening but compare https://en.m.wikipedia.org/w/api.php?format=json&action=mobileview&page=Mehboob+Khan&variant=en&redirects=yes&prop=sections%7Ctext&noheadings=yes§ionprop=level%7Cline%7Canchor§ions=all to the current master response [20:23:07] jgonera: i hate $wgResourceLoaderDebug = true it's too buggy - i don't trust it :) [20:23:10] and I'd say you're refactoring the sections code for the _project_ not for _me_ [20:23:21] works fine for me ;) [20:23:41] MaxSem: I get content_block in it for some reason [20:23:54] is that just me? [20:23:57] awjr, it seems to at least not have broken anything. MaxSem said he's familiar with the "you can bring a horse to water, but can't make it drink" quote when my ssh id didn't work [20:24:25] awjr, MaxSem, the correct Vary: header now seems to be coming back. [20:24:30] jgonera: i was merely saying i was getting the patch set ready so you could review it again [20:24:41] lol good dr0ptp4kt [20:24:41] and i know you wanted to have a go at rewriting it :) [20:24:43] awjr, MaxSem, not sure how soon we can expect Varnish to actually start honoring it, though. [20:25:06] awjr, MaxSem, at least it seems it was updated in the right function (the redirect hook). [20:26:04] MaxSem: i cleared memcache and problem went away (weird) [20:26:12] dr0ptp4kt: immediately, i would guess though it will take a while for cached resources to invalidate [20:26:53] ok jdlrobson, anyway, I think $wgResourceLoaderDebug is not buggy and in fact it helps in finding problems with dependencies. when everything is loaded as a big concatenated JS file, then you can't know if you have a problem with dependencies [20:27:41] New patchset: JGonera; "Story 425 Nearby: Cache last known location/nearby places" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61571 [20:30:12] jdlrobson, I think I have an idea how we can accomplish Story 425 without previews. when user comes back to nearby after pressing back button, we could simply scroll to the last position (previously save this position in localStorage too), what do you think? [20:30:34] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61571 [20:33:25] New review: JGonera; "I think I know what Munaf meant. I can have a stab at it if you want." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62166 [20:34:04] gerrit is unbearably slow, time for lunch [20:34:13] hehehe good solution [20:49:54] awjr, do you recall which bug it was that was a dependency for getting centralnotice running on mobile? [20:50:01] mm [20:50:08] yeah [20:50:10] lemme pull it pu [20:50:25] thx! [20:50:39] hmm [20:50:45] it was the js device detection one i think [20:52:09] found it [20:52:11] thanks :) [20:52:16] oh good [20:52:22] yeah i believe it was this one https://bugzilla.wikimedia.org/show_bug.cgi?id=47586 [20:52:34] yep [20:52:41] but it looks like it's a centralnotice bug now? [20:52:48] according to jon's last comment [20:53:00] max/jon wound up moving the device detection stuff that's needed by CN into CN [20:53:24] oh, sweet - so we can run banners whenever we want now? [20:53:37] almost :) [20:53:45] well, within reason [20:53:46] related code still needs to be merged/deployed [20:53:51] gotcha [20:54:07] but if i understand correctly, it should be no big deal after tahr [20:54:09] *that [20:54:34] that said, i think there was also some CentralNotice UI limitation for configuring banners for mobile... [20:54:36] jdlrobson: ? ^ [20:55:14] awjr: you'd need to check with matt.. think ui got done.. [20:55:28] oh ok cool [20:55:40] good to know [21:00:48] New review: Jdlrobson; "please do.. but please please please sync up with him to avoid more confusion." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62166 [21:05:43] New patchset: Jdlrobson; "Story 425: Nearby preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [21:05:43] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [21:07:12] wow according to wunderground.com it is currently hotter in SF than in tucson, by about 1F [21:10:10] New patchset: Jdlrobson; "Cachedpage.sh adjustments" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62185 [21:12:09] awjr: can we wrap up minerva? https://gerrit.wikimedia.org/r/#/c/58997/8 [21:12:21] (well minerva phase 1) [21:12:44] jdlrobson: i can't review right now im in the middle of other stuff, but generally speaking i don't see why not [21:13:40] New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [21:15:56] New review: Jdlrobson; "Thanks Max!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60093 [21:15:59] jcmish, are our Opera Mini problems verified to be gone? [21:16:04] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60093 [21:16:57] MaxSem: I haven't moved those over yet [21:17:00] still need to test them [21:34:04] New patchset: Jdlrobson; "Story 425: Nearby preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [21:34:05] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [21:41:15] i'm glad i'm not the only one - https://twitter.com/itsdrenthe/status/330436842325430272 [21:46:56] New patchset: Jdlrobson; "Bug 47598 Make Special:Nearby work on desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61496 [21:47:28] New review: Jdlrobson; "OK this patch should make more sense. I don't know why I didn't think of doing this in the first place." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61496 [21:49:28] New patchset: Jdlrobson; "make css backwards compatible with old html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62164 [21:50:04] New review: Jdlrobson; "I rebased. Adding back Juliusz's +1 using myself as proxy ;-)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/60684 [22:10:54] jdlrobson, what does simple.css do? why do we serve it to such different devices? [22:11:05] * jdlrobson shrugs - kill it [22:11:27] ie move everything with it to generic? [22:15:37] jdlrobson, ^^ [22:16:37] MaxSem: roger [22:20:04] frak [22:20:17] I'm afraid of breaking WAP detection [22:25:11] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [22:28:56] New patchset: Jdlrobson; "Bug 44959: Change settings label" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62203 [22:32:38] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62203 [22:39:26] MaxSem: i'm seeing this api error again :( [22:39:44] html for the content_block div is some how being returned in the api response for mobilesections [22:39:51] i don't understand why :( [22:43:02] gawd gerrit so slow today [22:44:08] New patchset: MaxSem; "Device type rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [22:55:55]