[03:28:08] New patchset: Jdlrobson; "Story 425: Nearby preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [03:28:08] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [03:28:09] New patchset: Jdlrobson; "Regression: Don't put content_block wrappers in API response" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62411 [03:28:09] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [03:28:09] New patchset: Jdlrobson; "Code organisation: Rename history modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62413 [03:28:24] New patchset: Jdlrobson; "Alpha table module: Blacklist tables with class metadata or navbox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62414 [03:28:34] New patchset: Jdlrobson; "Support hlists out in the world out of the box" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62415 [11:31:18] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62428 [16:17:52] Change abandoned: Jdlrobson; "code has changed too much" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61580 [16:46:40] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62411 [17:02:07] Maryana: mornin! juliusz is going to be late and im unclear if jon's going to be in the office today [17:02:39] jcmish: we're all on! [17:10:32] awjr: sorry I didn't even realize I'd disconnected I'd clicked on a link and it replaced my hangout :D [17:10:42] i knew you guys were pretty quiet! [17:10:48] haha [17:13:10] jdlrobson: ping! [17:13:56] uh-huh, section edit links aren't removed on beta [17:14:43] jcmish, it looks like the only free window vibha has today is after 4:30 [17:14:54] :) [17:15:02] then I'll accomodate [17:15:19] I need to pick up my son but I'll pick him up a bit early [17:15:42] or do you wanna shoot for early tomorrow Maryana? [17:18:08] jcmish, i'm all booked up tomorrow morning, unfortunately [17:18:28] can we do 5 pm sf time today? [17:18:36] yup [17:18:43] I can do that if it's okay with you guys [17:19:20] that should work - thank you! [17:19:36] you bet [17:20:41] New patchset: Jdlrobson; "Bug 48153: Remove section edit links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62455 [17:24:17] New patchset: MaxSem; "Section edit links class has changed" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62456 [17:25:46] something very weird is going on with our dashboards... [17:26:37] Maryana: do you think it's something wrong with reporting as opposed to the features themselves/ [17:26:49] i think so. take a look at the performance graph: http://mobile-reportcard.wmflabs.org/ [17:27:13] brion: able to review https://gerrit.wikimedia.org/r/#/c/58997/ ? [17:27:22] also, the number of successful mobile web uploads/day haven't changed [17:27:32] (to unleash awesomeness on to the mediawiki world) [17:27:46] moment [17:28:12] niiiiice [17:28:16] jdlrobson, ok lemme look over that [17:28:51] yeah that looks relatively stable; total uploads has dropped (albeit slightly, in the big scheme of things) starting on Friday and uniques have dropped [17:29:30] and at first i was concerned about successful uploads graph, but i guess the big spike is a result of ios android uploads, not a drop in web uplaods [17:29:53] it's not a huge spike on android/ios though, just a gentle bump in the totals [17:31:46] i dunno, looking closer im actually not sure anything is necessarily wrong [17:31:59] if we were having problems with web uploads, i think those graphs would actually look at lot scarrier [17:34:13] whew, almost checked out MobileFrontend into my core git repo again [17:35:26] happens to me as well [17:35:44] it'll actually let you do it, it just prints a warning that there's no commits in common [17:35:48] and takes a while :) [17:36:07] oh i need some shorter test pages. san francisco takes forever to rerender [17:40:15] jdlrobson: so far nothing's exploding :) [17:40:22] it [17:40:25] it's a good explosion.. [17:40:29] rendering and menu are a bit different between mobile view and desktop view of minerva, but that's to be expected [17:40:30] hehe [17:41:06] jdlrobson, MaxSem, jcmish_coffee: don't forget to prep any work you want to show off and make sure to get it on the agenda for the showcase: http://etherpad.wikimedia.org/MobileShowcase [17:43:39] New review: Brion VIBBER; "Doesn't appear to explode in a bad way. \o/" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58997 [17:43:40] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58997 [17:44:47] MaxSem: can you take a look at https://gerrit.wikimedia.org/r/#/c/62455/ ? [17:46:23] jdlrobson, lol - we collided on that:) [17:49:57] Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62456 [17:50:58] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62455 [17:52:16] MaxSem: any reasons we can [17:52:16] ' [17:52:25] MaxSem: any reasons we can't cherry pick core change for https://gerrit.wikimedia.org/r/#/c/59987/ tomorrow? [17:52:52] New patchset: Jdlrobson; "Promote addToBodyAttributes to desktop skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58257 [17:52:54] we can [17:53:08] MaxSem: care to test and merge it? [17:53:44] also MaxSem awjr jgonera https://gerrit.wikimedia.org/r/#/c/62164/ this needs to be merged asap if we want to avoid the problem with last weeks deployment :) [17:57:43] tfinc, can you give me access to our apple store stats? [17:57:49] Maryana: sure [17:57:55] you may have already done this at some point, but i'm not finding it in my email [17:58:02] Maryana: pm me your apple id [18:02:04] jdlrobson: reminder about the ops project overview @ 11 [18:04:52] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62164 [18:07:42] brion: mhurd : all iOS and Android cards on https://trello.com/board/mobile-app-sprint-8/51830a8104d981c70c0012ce are now split out [18:13:58] tfinc: want anything from specialities? putting in an order.. [18:14:09] awjr: is there a defect card tracking the dip in http://mobile-reportcard.wmflabs.org/ ? [18:14:33] jdlrobson: hmm .. i'll pass . thanks though. if your adding other peoples orders then feel free to pass me the bill [18:14:39] jgonera: ? [18:14:50] yes? [18:14:55] above ^ [18:15:03] jgonera: menu http://www.specialtys.com/ [18:15:03] tfinc: no, not yet, at least not that i know of. [18:15:13] then i'll cut a bug [18:15:16] ok, give me 1 min ;) [18:15:17] ordering food to pick up for 12 for hangout [18:15:28] thanks tfinc [18:15:28] awjr: what product/bug do we use for mobile report card ? [18:16:12] i dont know tfinc but for this i would just file it in MobileFrontend; i dont think there's a problem with limn (and honestly i am not convinced there's a problem with mobilefrontend either), but judging form the graphs if somehting is wrong it's likely in MF [18:17:27] awjr: done https://bugzilla.wikimedia.org/show_bug.cgi?id=48167 [18:17:28] New review: Jdlrobson; "Simply rebased this. Still has +1 from jgonera.." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/58257 [18:17:43] cool tfinc, we'll review it during today's sprint kickoff [18:17:50] jdlrobson, beef & blue from http://www.specialtys.com/Products.aspx?MenuId=228 [18:18:42] jgonera: got it - any drinks/chips? [18:19:06] jdlrobson, no thanks, just the sandwich ;) [18:19:42] brion: monte? ^ [18:19:45] mhurd: --^ [18:21:31] MaxSem, jdlrobson, jgonera, jcmish_coffee: reminder again about the showcase, please add stuff you wanna show off from the last two weeks to the agenda: http://etherpad.wikimedia.org/MobileShowcase [18:22:44] brion: mhurd last call for lunch..! [18:22:57] no blue for me [18:23:20] are we ordering sammiches? [18:23:38] brion: yup [18:23:39] mhurd: got it [18:23:54] jdlrobson: thx! [18:24:03] jdlrobson: yum yum [18:24:06] mhurd: no blue or beef and blue? [18:24:10] i'll take the roasted turkey [18:24:12] mhurd: you have al ink? [18:24:40] ya [18:24:41] http://www.specialtys.com/Products.aspx?MenuId=228 [18:24:47] no dressing [18:25:04] mhurd: added beef and blue [18:25:11] its southwestern with sauce - not sauce for me [18:25:26] mhurd: ? [18:25:49] mhurd: ok got it [18:26:16] jdlrobson: thanks! [18:28:29] [android-commons] brion pushed 7 new commits to master: http://git.io/fKae7A [18:28:29] android-commons/master 02cd07e valeriej: Add instructions on how to set up IntelliJ in README [18:28:29] android-commons/master e1e3aed valeriej: Fixed format to fix link in README [18:28:29] android-commons/master 83a70d1 valeriej: Adding line breaks to IntelliJ set up [18:28:37] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60684 [18:28:41] dr0ptp4kt, what are you trying to pull to production? [18:28:55] Project Android-Commons (mobile) - Nightly builds build #163: SUCCESS in 40 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/163/ [18:28:56] * valerie.m.juarez: Add instructions on how to set up IntelliJ in README [18:28:57] * valerie.m.juarez: Fixed format to fix link in README [18:28:57] * valerie.m.juarez: Adding line breaks to IntelliJ set up [18:28:57] * valerie.m.juarez: Fixed typos [18:28:58] * valerie.m.juarez: Fix link to IntelliJ download [18:28:58] * valerie.m.juarez: Fix typos in instructions and link [18:29:15] dr0ptp4kt, btw, i copied all the zero configs to meta [18:29:26] Maryana: just a reminder that https://gerrit.wikimedia.org/r/#/c/61801/ is still pending mobile review and testing [18:29:56] yeah, we have trouble with our code review backlog.. [18:30:29] heh, tis okay. I'm just nagging since it gets a lot harder to deploy the longer we delay [18:30:48] pgehres: did you mail the mobile team about that or just add folks as reviewers to the patchset? [18:30:49] [android-commons] brion pushed 2 new commits to master: http://git.io/5_AAQw [18:30:49] android-commons/master e5f38ab Brion Vibber: Disable fade-in effect on images in Android 2.3... [18:30:49] android-commons/master 8a02baa Brion Vibber: Merge pull request #12 from brion/flicker... [18:31:11] Project Android-Commons (mobile) - Nightly builds build #164: SUCCESS in 32 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/164/ [18:31:11] Brion VIBBER: Disable fade-in effect on images in Android 2.3 [18:31:26] pgehres: if the latter, i recommend emailing the mobile team about that patchset; it's otherwise easy for that stuff to get burried. [18:31:40] what list? [18:31:56] mobile-l ? [18:32:14] pgehres: for most things mobile, mobile-l - otherwise if it's internal or team-specific, mobile-tech [18:33:43] MaxSem: lolz http://www.metrolyrics.com/no-good-can-come-of-this-lyrics-katatonia.html [18:33:49] jgonera, jdlrobson when either of you have a chance can you take a look at https://gerrit.wikimedia.org/r/#/c/60346/ ? [18:34:11] jgonera: it's stalled - there's a bug discussion going on [18:34:32] jgonera awjr https://bugzilla.wikimedia.org/show_bug.cgi?id=47296 [18:35:01] jdlrobson: has everything for https://mingle.corp.wikimedia.org/projects/mobile/cards/498 been merged now? i dont see anyhting obviously outstanding in gerrit [18:35:02] awjr: also https://bugzilla.wikimedia.org/show_bug.cgi?id=47882 [18:35:09] awjr: no [18:35:25] what is left, jdlrobson? [18:35:32] awjr: loads.. https://gerrit.wikimedia.org/r/#/c/62413/ [18:35:45] and that doesn't even cover the promotion [18:36:17] the promotion itself is trivial though once the above is merged [18:36:18] jdlrobson: can you please add relevant changesets to the story (or otherwise make it clear the changesets relate to the story perhaps in the commit messages? [18:36:23] awjr: i already have [18:36:32] thanks [18:36:36] this is where better gerrit/mingle integration would be useful [18:36:49] agreed [18:37:54] is Adam around? [18:38:16] jdlrobson, jgonera you might have a hard time getting feedback from munaf on https://gerrit.wikimedia.org/r/#/c/62166/; perhaps double check with Maryana/vibha [18:38:23] the previous gerrit patch linked to an abandoned one which had dependencies which were not abandoned [18:38:36] awjr: well vibha would be fine for that discussion [18:38:54] my main concern is making sure there is consistency and not duplicate css rules [18:38:58] awjr, jdlrobson, I think I know what Munaf meant, but we can double check if Vibha if you want [18:39:17] jgonera, you could maybe check with s page on e3 [18:39:24] i know munaf handed over most of the agora stuff to him [18:39:31] jgonera, jdlrobson: however you want to handle it is fine with me so long as Maryana is happy with the changes [18:39:35] he's spagewmf on the e3 channel, #wikimedia-e3 [18:40:21] ok, thanks [18:44:42] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61775 [18:50:38] jdlrobson, https://gerrit.wikimedia.org/r/#/c/59987/ has a merge conflict [18:55:46] awjr: can you join the hangout early ? i want to make sure the av is fine [18:55:59] [android-commons] brion opened pull request #14: Show 'waiting' or 'no uploads' messages when no uploads (master...blank2) http://git.io/P78v4A [18:56:29] [android-commons] brion pushed 3 new commits to master: http://git.io/4rMyzQ [18:56:29] android-commons/master 04a1555 Brion Vibber: Work in progress: waiting for first sync msg [18:56:29] android-commons/master 5b8990b Brion Vibber: Localize messages for first sync / no images [18:56:29] android-commons/master f141e13 Brion Vibber: Merge pull request #14 from brion/blank2... [18:57:05] Project Android-Commons (mobile) - Nightly builds build #165: SUCCESS in 42 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/165/ [18:57:05] * Brion VIBBER: Work in progress: waiting for first sync msg [18:57:06] * Brion VIBBER: Localize messages for first sync / no images [18:59:02] MaxSem: can you join the hangout early ? i want to make sure the av is fine [19:06:49] tfinc: sorry i missed your msg; was making a sandwich [19:07:02] no worries [19:12:34] dr0ptp4kt, dfoy do you guys see any banners? [19:14:11] something wonky going on. http://ru.zero.wikipedia.org/wiki/This_Article_Does_Not_Exist1 that works. [19:14:40] ^yurik as russian partner [19:15:15] dr0ptp4kt, i tried en.zero for article "T", NONE of the partners show banners [19:17:27] dr0ptp4kt, is RU on the same version as EN ? [19:18:30] yurik, dunno, will check .dat. but notice that http://es.zero.wikipedia.org/wiki/Stone_Temple_Pilots works in Spanish [19:18:50] enDOT seems to be the problem at the moment [19:20:48] dr0ptp4kt, en is the only one on wfm3 [19:20:59] both es & ru are on wmf2 [19:21:22] enwiki php-1.22wmf3 * ruwiki php-1.22wmf2 * < yup [19:21:48] so it using master instead of production perhaps? [19:22:14] yurik ^ [19:22:29] dr0ptp4kt, what is?? [19:23:18] yurik, i believe enwiki is running the 'master' version instead of the 'production' version. [19:23:33] dr0ptp4kt, of the Zero extension? [19:23:41] yurik, ruwiki shows zrma at 1.0.0, yes. [19:24:00] oh great, we had a deployment without participating :) [19:24:08] yurik, and enwiki at 1.1.0 [19:24:20] great. Need to configure zero ASAP [19:24:24] will bug OPs [19:24:29] this is NOT the way to do it [19:24:39] MaxSem, or could you help? [19:24:46] we have a mess apparently :) [19:25:02] yurik, we have a meeting. anything urgent? [19:25:05] zero went live without proper sconfiguration [19:25:16] en does not show ANY banners [19:25:35] MaxSem, ^ [19:25:50] i still haven't received my deployment rights [19:26:14] do you have the config change? [19:26:35] MaxSem, i don't want to deploy zero until tomorrow, after i finish all the testing [19:26:51] MaxSem, i believe the default wiki cutover pulled in the latest 'master' version of the plugin instead of the 'production' version. [19:27:03] oh shi~ [19:27:14] Reedy, ^^ [19:27:30] lols [19:27:37] yeah [19:27:42] but wait [19:27:55] Not my fault [19:27:55] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/tools/release.git;a=blob;f=make-wmf-branch/default.conf;h=3b9d9253779cedd267c32b2f4d45a9ff9a7ca95a;hb=HEAD [19:27:56] MaxSem, reedy, yurik, i think that php config file with the branch names should be updated, but a quick fix now would be to simply get the 'production' version onto enwiki [19:28:10] yes please [19:28:53] Syncing [19:28:58] Reedy, thx! [19:29:29] Should be fixed for the moment [19:29:30] but wait [19:29:46] MaxSem, found another issue? [19:30:14] what sux is that now everything is cached :( [19:30:15] nevermind, that was MF [19:30:52] good, i'm getting some banners now [19:30:53] thx [19:31:01] but only for a different title [19:31:25] is wmf2 ok? [19:31:37] wmf2 is ok [19:33:25] just read through backscroll - how big of a problem is the caching of bad pages before this was fixed? [19:33:28] yurik: ^ [19:33:37] like, was it broken for a few minutes, hours, days? [19:33:47] if it's a serious issue then we may need to coordinate a cache flush with ops [19:33:58] dr0ptp4kt also ^ [19:34:58] At most, it's 90 minutes since I changed enwiki over [19:36:04] oh, did it only affect enwiki (the other language wikis are still on wmf2, right?)? [19:36:18] awjr, yes, it was only enwiki [19:36:24] since all of wmf3 was corrupted, a lot of other wikis were broken since last week [19:36:36] and we are very lucky that i was testing my new script just now [19:36:55] otherwise it would have been a call from the partners :) [19:37:02] or we offer only WP on Zero? [19:37:07] or dfoy would get on our case [19:37:21] MaxSem, zero is only for WP [19:37:24] at this point [19:37:51] ok, it sounds like the window/scope of the issue probably small enough that a flush is not necessary - yurik, dr0ptp4kt sound right? [19:38:01] awjr, agree [19:38:12] if its was only 90 min, should be ok... i hope [19:38:29] yeah, should be [19:38:39] awjr, but in general, we really need to be able to flush a subrange of cache - based on a specific header for example [19:38:58] yurik: you should talk to ops about that requirement [19:39:05] heh [19:39:31] i dunno if that would be possible [19:40:09] yurik, since we don't hash by date, it's impossible to purge this way in Varnish [19:40:29] https://gerrit.wikimedia.org/r/62477 [19:42:15] MaxSem, thx, +2 [19:43:26] MaxSem, but if we set VaryBy('X-CS'), shouldn't there be a fairly easy way for varnish to find and kill them? [19:43:52] that is, flush all Zero pageviews? [19:44:58] MaxSem, according to this -- [19:45:00] http://kly.no/posts/2010_02_02__Varnish_purges__.html [19:45:12] there are very elaborate purges that can be done in varnish [19:45:34] such as - those that have a specific URL (en.zero.* & X-CS ) [19:46:12] yeah, you'd have to coordinate with ops yurik; i dont know how purges are currently handled for mobile varnish cache or how flexible whatever they have in place currently is [19:48:06] so MaxSem we need to think about upstreaming MobileFormatter to be part of the skin.. [19:48:49] which skin, minerva? [19:49:12] MaxSem: yup [19:49:13] New patchset: Jdlrobson; "Upstream skin changes - getLanguageUrls" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [19:49:21] i want section toggling on the desktop skin for minerva [19:49:42] MaxSem: when we do that we can just use all the mobile js/css on minerva desktop - will be seamless [19:50:22] the way we currently do it is abomination that explicitly MUST NOT be moved anywhere [19:50:24] New review: Jdlrobson; "rebased" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59987 [19:50:24] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59987 [19:50:41] MaxSem: agreed [19:50:50] so it's time to start thinking about getting the parser to do it for us [19:50:54] MaxSem: did you see my diff? [19:51:08] MaxSem: https://gist.github.com/jdlrobson/5439509 [19:51:18] which one? you're produceing them at a terrible speed:P [19:51:41] Reedy, oh I see yurik's code review on MaxSem's change. thanks. [19:52:11] jdlrobson, first... do you want action=*mobile*view in core? [19:52:32] yurik, would you please code review https://gerrit.wikimedia.org/r/#/c/62460/ ? [19:55:16] dr0ptp4kt, could you please re-run your script to upload that change to the labs machine [19:55:43] MaxSem: so I want to deprecate bodytext in core [19:55:54] in favor of sections [19:56:01] as it gives more control to the skin developer [19:56:05] second... per-section splitting should be part of Parser/ParserOutput, but if our alpha mode is here be dragons, parser is here be FUCKING BADASS COWBOY DRAGONS OF DEMENTIA [19:56:32] lol [19:56:43] so MaxSem this would go away if section splitting was part of Parser/ParserOutput [19:56:47] as the skin simply wouldn [19:56:47] ' [19:56:58] * as the skin simply wouldn't render the content of that section [19:58:24] so it would be if ( !$alpha ) { echo $section['heading']; echo "

" . $section['content'] . "

"; } else { echo $section['heading']; echo '

' } [19:58:26] ^ MaxSem [19:58:37] (well something like that) [19:59:07] the reason here be dragons went cowboy was because there was no way to do it in the skin - it treats the content as one big chunk [19:59:14] no alpha in core [19:59:18] yurik, script executed. 20 records returned with result:success [19:59:41] MaxSem: sure it wouldn't need to be - talking about mobile in this context :) [19:59:50] jdlrobson, and you're busting everyone w/o JS here [19:59:52] e.g. if ( !$alpha || $desktop ) [19:59:59] MaxSem: that's another orthogonal discussion [20:00:06] no it's not [20:00:30] dr0ptp4kt, did your script include the change that you made to varnish? [20:00:38] in MF you can go away with "we can break alpha for some ppl" but in core nobody will permit you this [20:00:48] MaxSem: to be clear all i'm talking about here is headingTransform becoming part of core [20:00:51] and the architecture must take this into account [20:01:23] MaxSem: please read my email Rethinking MobileFormatter / Skins on mobile-l [20:01:42] I did [20:01:53] and all the discussion in wikitech-l [20:01:56] MaxSem: all i'm asking for is the sections to be available in the skin /in addition/ to bodytext support this [20:02:15] yeah [20:02:20] it would be backwards compatible - forget alpha and dynamic sections for a minute [20:02:24] worms worms worms [20:02:29] that is a completely orthogonal conversation [20:03:18] the problem I am trying to solve is in desktop I want the toggling to work as it does on mobile stable [20:03:25] (on the minerva skin) [20:03:54] it doesn't necessarily need to be a core change yet - but it would be good if we could eventually upstream it. Would the hook approach in https://gist.github.com/jdlrobson/5439509 not work? [20:03:56] yurik, not yet.i think you would need to +2 the change to get it merged. we need someone from ops for that, right? yurik, Reedy, MaxSem, awjr, do you know who we should add to Varnish configuration changes in the operations/puppet project? [20:04:23] dr0ptp4kt, Mark and Asher [20:04:25] dr0ptp4kt: mark, asher, paravoid [20:04:29] er [20:04:32] paravoid = faidon [20:04:41] dr0ptp4kt, i can't +2 production changes [20:04:48] MaxSem and awjr, thanks! yurik, word. [20:10:34] New patchset: Yurik; "Basic test utils to check zero banners" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62482 [20:12:43] dr0ptp4kt, +2 please - https://gerrit.wikimedia.org/r/#/c/62482/ [20:14:01] yurik, reviewing [20:15:56] jdlrobson: tfinc: google Borocay, Philippines and taal volcano [20:15:57] this is what Japan is up against [20:16:08] also http://farm5.static.flickr.com/4033/4567110759_af02655e51.jpg [20:16:08] good challenge [20:19:41] heads up, there's a weekly deployment cycle discussion on engineering/wikitech-l - we need to formulate our position [20:19:56] yurik, +2'd [20:20:27] since it^^ is mostly related to compat testing, jcmish and jdlrobson should be interested first of all [20:20:56] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62482 [20:22:15] ohh [20:22:20] cool thanks Max! [20:27:33] jdlrobson: can I remove the javascript alert? [20:27:45] or do you need me to leave it there for more debugging [20:28:23] New review: awjrichards; "I'm getting 6 phpunit test failures with this changeset: http://pastie.org/7810129" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61942 [20:31:10] New review: awjrichards; "LGTM but would like someone else to test/dbl check" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/62205 [20:33:26] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58257 [20:34:22] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62185 [20:40:32] New review: MaxSem; "Yeah, it's still WIP" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [20:47:32] MaxSem: what else needs to be done for that to be finished then? [20:48:26] the main problematic point is WAP detection: we want to remove crufty rules, but that changes the way some devices are treated [20:48:44] wrt WAPness [20:48:45] dr0ptp4kt, still there? [20:48:55] yurik, yup. what up? [20:49:03] your script is in php, right? [20:49:08] yurik, yes [20:49:09] oh, i see MaxSem [20:49:48] dr0ptp4kt, could you re-run it while applying "ucwords()" function to the NAME argument [20:49:57] parameter [20:51:07] awjr, and worst part is that while there are a lot of serivces that know user-agents for zounds of devices, none of them lists Accept [20:51:30] :-/ [20:52:33] ugh [20:53:13] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58825 [20:53:41] jcmish: what time do you finish today - was hoping we could work out this opera mini bug together after kickoff [20:54:09] yurik, which NAME parameter? [20:54:24] not til late [20:54:25] dr0ptp4kt, the name parameter in the zero configs, there is an array [20:54:51] I have to work with Maryana and Vibha at 6pm [20:54:52] New patchset: Jdlrobson; "Alpha: Add watchlist star to nearby view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58825 [20:54:56] dr0ptp4kt, http://api.beta.wmflabs.org/wiki/Zero:413-02 [20:55:00] yurik, you're saying to toupper() each of the *values* for each language code key within the 'name' key-value pair structure, right? [20:55:03] opps jdlrobson ^ [20:55:11] jcmish: ok :) [20:55:30] yurik, for example, en -> Dialog Sri Lanka would become en -> DIALOG SRI LANKA, correct? [20:55:31] 6pm MT :D I should say pm PT [20:55:39] dr0ptp4kt, ucwords\ [20:55:44] not toupper [20:55:52] in that example it shouldn't change anything [20:56:08] but in some other configs it will [20:56:16] yurik, right. ucwords. okay, hang on a minute... [20:56:23] New patchset: JGonera; "Story 483: Show intermediate copyvio/scope message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [20:56:38] dr0ptp4kt, and please check taht script in so that i don't have to bug you [20:56:42] awjr: in reply to https://gerrit.wikimedia.org/r/#/c/62185/2/scripts/cachedpage.sh please see https://gerrit.wikimedia.org/r/#/c/61775/2/scripts/w3c-validate.sh [20:57:27] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62185 [20:59:01] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62185 [20:59:50] New patchset: JGonera; "Story 483: Show intermediate copyvio/scope message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [21:00:02] dr0ptp4kt, thanks [21:00:32] yurik, script executed. hear you on posting the code. didn't get to my self code review of it yet. firefighting. will do, though. [21:01:03] dr0ptp4kt, what are you firefighting? are there any burning issues? [21:02:36] yurik, no serious fires at the moment. just working on an update to the language drop down list, which is somewhat urgent. will add you to code review list once i post that. [21:05:20] dr0ptp4kt, but if we are planning to release the zero config tomorrow morning, will that update be a part of it? [21:05:33] yurik, we'll want to add that into the new version [21:05:39] ok [21:32:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=43305 [21:41:35] New patchset: JGonera; "Story 483: Show intermediate copyvio/scope message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [21:48:37] jdlrobson: Maryana hung up on me :D [21:48:42] :) [21:48:46] should we grab another hang out or [21:48:47] chat here [21:48:53] jcmish: we might be able to chat here.. [21:48:55]