[00:00:38] awjr, made changes to https://gerrit.wikimedia.org/r/#/c/62129/ [00:03:44] awjr: that's the nearby not installed area [00:03:46] *error [00:03:59] eh? [00:04:12] awjr: GeoData extension is not setup on your account [00:04:47] awjr: this is https://bugzilla.wikimedia.org/show_bug.cgi?id=47636 bug and why $wgMFNearbyEndpoint was created [00:05:03] although $wgMFNearbyEndpoint won't help you with watch stars as it won't be able to find the articles on your local instance [00:06:38] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62129 [00:07:18] New review: Jdlrobson; "Ensure CentralNotice is deployed before merging/deploying" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [00:08:18] jdlrobson: oh, yeah, i know - but why is Nearby still pulling from enwiki's API when i have $wgMFNearbyEndpoint = ''; and how does that explain the JS error? [00:08:21] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [00:09:05] i think geodata is set up on staging so i should be able to test that patchset there [00:14:43] so jdlrobson im getting the JS error on staging.wmflabs.org which has no Endpoint configured, and geodata is enabled [00:20:05] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [00:23:26] New review: MaxSem; "Pretty please don't needlessly retrieve 500 rows from the DB on every view." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62129 [00:24:31] srsly, most logged in users don't upload - doing this query for them is a waste [00:25:28] "making a slow query and putting its result into memcached is a terrible pattern" (c) Domas [00:25:35] New patchset: Yurik; "Use JSON carrier settings for banner localization" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/58875 [00:25:35] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [00:35:05] mhurd: did we get the new test flight build out ? [00:35:32] tfinc: not sure [00:38:46] mhurd: find out from brion. we should have gotten it out on friday [00:39:00] and ask him about android while your at it [00:39:24] tfinc: he left for the day. i can call [00:39:32] just mail him [00:39:38] k [00:39:39] and cc mobile-tech [00:48:09] Maryana: what should we do about https://mingle.corp.wikimedia.org/projects/mobile/cards/681? i [00:48:26] it's in ready for dev on the current story wall - should we move it over for the new iteration, or backog it? [00:48:42] hmmm… do we have navigation timing in stable? [00:48:50] *navigation timing logging [00:49:56] if it's logging that we're already doing and just need to do some processing, then we can probably must move it over. if it's something we need to add logging pieces for, then i say backlog [00:50:08] *probably just [00:50:12] geez, i can't type today [00:50:14] im not sure about navigation timing; but we have content load time logging in stable [00:50:18] that's what you see under 'performance' on the reportcard [00:50:41] ah, i didn't realize those were two separate things [00:50:55] actually, i should take that back, im not 100% sure that is for stable [00:51:16] i can find the schema on meta. sec [00:52:49] hmm. i'm not seeing a separate content loading schema or table in stat1 [00:52:59] hey jgonera [00:53:16] which schema are you using to produce the performance graph in limn? [00:53:17] i think he left a bit ago [00:53:22] d'oh [00:54:04] ah, it is stable [00:54:14] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [00:54:35] Maryana: it came out of this: https://mingle.corp.wikimedia.org/projects/mobile/cards/449 [00:54:53] right [00:54:59] Maryana: see juliusz's email on april 19' NavigationTiming graph in mobile dashboard (story #449)' [00:55:40] yeah, so it's already logging stuff. just need to analyze. [00:56:06] so i think there's no harm in moving it over for this iteration [00:56:11] though it's probably no longer a 5 [00:56:37] Maryana: i think it involves adding logging for retrieving sections as well as data analysis [00:56:43] oh, that's right [00:56:44] hrm [00:57:02] in that case, let's wait on that part [00:57:40] backlog it [00:57:55] okidoke; the point was to see what kind of performance benefit we get from dynamic sections (now that they've been moved back to beta form alpha) [00:58:23] Maryana: i pushed it back to the backlog [00:58:35] i can do the DOMcontent loading comparison in about 3 seconds if juliusz points me to which fields i should compare :) [00:58:44] that'll give us a start [01:08:01] im outta here, see you all tomorrow! [01:21:26] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [06:02:17] Hello [06:14:30] New patchset: Jdlrobson; "Opera mini header tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62569 [08:20:50] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [08:45:19] MaxSem, awake? [08:45:33] yes, but running aeway shortly [08:46:14] MaxSem, i just wanted to say that I would like to do a deployment in ~6-7 hours, and hopefully my depl right will go through by then [08:46:15] https://gerrit.wikimedia.org/r/#/c/62457/ [08:46:48] (RT has been approved by tfinc) [08:48:00] :) [08:48:38] I'll be there [08:50:01] has your request been in waiting for 3 days? [08:53:00] MaxSem, yes [08:53:18] rt ticket was created on may 2nd [09:24:59] New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62428 [09:24:59] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62579 [15:10:48] New review: Jdlrobson; "Let's put all the overlays into photo-overlays.js - mf-photo.js is getting far too crowded Also mino..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62129 [15:18:27] New review: Jdlrobson; "Also some workflows I just discovered which don't work:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [15:22:21] New review: Jdlrobson; "Also if I click donate image 3 times in the same session it ... stops showing the message. I think t..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [15:27:30] if you click donate image three times in the mirror, the ghost of a Commons admin appears and deletes your head [15:31:41] New patchset: Nemo bis; "Replace dragons with plain language" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62617 [15:42:51] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62569 [15:49:49] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62428 [15:49:50] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62428 [15:50:10] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62579 [15:50:11] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62579 [15:50:36] New review: MaxSem; "There's also 'mobile-frontend-placeholder-alpha' => 'Search {{SITENAME}} (Dragon Mode)'. On a side n..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62617 [15:58:39] MaxSem, either ops are asleep, or i got on their bad side :) [15:59:10] sigh [15:59:17] you didn't even thank them [16:00:38] yurik, when are you going to deploy? [16:01:06] MaxSem,thank them for what? confused. I was hoping to deploy today [16:01:21] for merging your commit! [16:01:43] ohh, i thought you did that! I should dfntly thank them for that :) [16:01:55] who fixed it? [16:13:21] yurik, Y U NO LOOK IT UP? https://gerrit.wikimedia.org/r/62457 :) [16:14:08] MaxSem, lol, somehow it didn't even notify me!!!! yeii!! [16:14:54] MaxSem, i thought you were talking about the bug yesterday, and i was trying to find the patch that fixed it [16:15:12] when will you have time to watch over the deployment? [16:16:15] any time before the mobile deployment [16:16:23] do you have a window? [16:16:39] MaxSem, not official one i don't think. Any time is good :) [16:16:48] MaxSem, can we do it now? [16:17:14] if we end before 10am PST [16:17:55] MaxSem, ok, what about settings change? [16:18:01] https://gerrit.wikimedia.org/r/#/c/62576/ [16:18:07] what's the process for that? [16:19:04] dr0ptp4kt, around? [16:19:16] yurik, yes [16:19:57] dr0ptp4kt, its time to deploy! Could you +2 https://gerrit.wikimedia.org/r/#/c/60775/ [16:20:30] yurik, lemme do a quick run through the files, then will do [16:20:58] dr0ptp4kt, sure, but we have 40 to finish deployment, or we need to get another window [16:21:06] ;) [16:21:09] no pressure :D [16:21:11] yurik, the process is that you do it if you're confident. if you're not, you ask for review. let me -1 it [16:21:13] yurik, 40 what? [16:21:32] min [16:22:00] MaxSem, re settings - obviously i'm not confident with settings because I don't know any good way to test them :) [16:23:16] yurik, aren't we planning to roll this during the mobile deployment with MaxSem? [16:23:37] https://gerrit.wikimedia.org/r/#/c/62576/ [16:23:42] yurik, 0900-1100 PT is occupied by CentralNotice, Core, and Parsoid updates [16:24:26] New patchset: Yurik; "Zero config editor & visualizer" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [16:27:22] yurik, 60775 +2'd [16:27:51] dr0ptp4kt, yei! thx :) [16:38:27] okay, other ppl are scapping [16:38:42] no deployment right now [16:40:20] MaxSem, is there any reason ever to use "include" instead of "require_once" in the common settings? [16:41:18] there was some holywar like "but include() is 2us faster!!1" but in general, that's a non-issue [16:44:24] I as hoping to find jdlrobson. Is he in UK or CA? [16:44:25] was [16:46:00] qgil, he's in ca [16:46:08] qgil, he's not in the office yet, though [16:46:19] qgil, that is to say, he will be here later [16:46:27] ah ok, thank you dr0ptp4kt [16:46:40] qgil, you're welcome [16:47:34] MaxSem, fixed https://gerrit.wikimedia.org/r/#/c/62576/ [16:47:44] at least that's what i think is the fix :) [16:47:59] as for HTTP - no need to do https - internal cluster call [16:48:59] oh, and MaxSem, how did you know someone was scaping? [16:49:15] #-ops [16:50:30] oh, must have been blind, i see it [16:52:43] that's one of the few channels with mostly useful stuff [16:53:35] heh. i hope mobile is also useful. sometimes. when we are talking about cats. Do you think when you do deployment you will have time to watch over ours? [16:54:37] no time for 2 scaps, so there will be no separate zero deployment:) I was hoping to walk you through a full course [16:55:09] dr0ptp4kt, have you resolved your issues with deployment? [16:55:37] MaxSem, i have not resolved my access issues [16:56:13] dr0ptp4kt: what's the issue? [16:57:09] awjr, git pull on fenari failed last week. we think it may have something to do with different usernames for gerrit versus fenari. [16:57:46] ah right, i remember - i left right after you started working through that; have you talked to anyone in ops about it yet? [16:58:02] awjr, MaxSem, i haven't talked to ops about that yet [16:58:10] boo:P [16:58:13] dr0ptp4kt: ping folks in #wikimedia-operations [16:58:51] dr0ptp4kt: mutante, RobH, Ryan_Lane, paravoid are probably your best bets [16:59:00] awjr, thx [16:59:10] but a general query in the channel will probably get it resolved fairly quickly [17:00:22] dr0ptp4kt, what was the issue? I wouldn't want to run into the same thing [17:01:30] i hope my emails have been consistent [17:04:24] New review: Jdlrobson; "That is weird... anything special about your instance Max? I don't get that..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61496 [17:12:59] New patchset: MaxSem; "Bug 47586: Remove DeviceDetection js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [17:17:25] New patchset: Jdlrobson; "Allow validation testing for arbitary pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62643 [17:17:26] New review: MaxSem; "Tried disabling everyrthing but MF/GeoData - same result." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61496 [17:18:13] yurik, git pull wasn't working. we thought it had to do with the gerrit username != fenari username, but changing the git/gerrit username in my git prefs on fenari didn't fix the problem [17:30:39] Just letting you know: I thought the visit to DMV would be shorter if we went really early... On my way now. [17:31:06] heh :) [17:31:39] jdlrobson: good news! centralnotice has now been deployed and seems to be working! bad news! the mobile site does not currently have the siteNotice div! [17:31:59] er what [17:32:08] mwalker: are you in beta? [17:32:22] yep -- so says my settings [17:32:33] ruhroh im seeing a messed up main page [17:32:38] on en.m.wikipedia.org [17:32:55] mwalker: yeh we need to enable the siteNotice div in the config [17:33:03] awjr: works for me [17:33:19] awjr: what exactly is wrong [17:33:21] jdlrobson: no cookies/stable? [17:33:27] ? [17:33:28] jdlrobson: screenshot coming; same as after deployment last week [17:33:39] jdlrobson: i mean, are you sure you're not bypassing cache (you have no cookies, etc) [17:33:43] awjr: are you in stable/beta/alpha? [17:33:51] jdlrobson: stable, private browsing [17:34:12] awjr: ok yeh i see it in private browsing - that's weird [17:34:16] what happened? [17:34:17] jdlrobson: http://imgur.com/l9DCndC [17:34:22] did someone deploy an old version of mf? [17:34:24] dunno i wonder if something got deployed that shouldnt have [17:34:53] checking now [17:35:01] awjr: it's not every page - so i'm guessing someone deployed it [17:35:23] awjr: i can apply a fix though using Mobile.css don't worry [17:36:12] awjr: or we can just fast track todays deployment :) [17:36:13] both work.. [17:37:04] yeah changes that were rolled back last week are currently live. [17:37:17] MaxSem: ^ [17:38:20] oh [17:38:34] MaxSem: when we rolled back changes last week, did you roll back wmf3 as well as wmf2? [17:39:24] looks like yes [17:39:29] awjr: do you need me to apply a fix in Mobile.css ? [17:39:42] that's probably the easiest thing right now jdlrobson [17:39:47] k on it [17:39:49] thanks [17:40:05] i had to do same yesterday due to the 1.5K spike in anonymous edits... [17:40:39] :-/ [17:40:46] awjr: is it just en wiki ? [17:40:47] \ [17:41:02] no jdlrobson [17:41:16] i mean, i havent double checked, but i would expect this to be the case everywhere [17:41:23] ok i only have access to Mobile.css on en wiki [17:41:30] other projects will need someone else to apply fix [17:41:49] jdlrobson: can we make a fix in our own CSS? [17:42:05] awjr: we already have.. [17:42:08] awjr: we just need to deploy [17:42:18] awjr: https://gerrit.wikimedia.org/r/#/c/62164/3 [17:42:21] ah that's right - can you send me the gerrit link? [17:42:24] read my mind [17:42:27] jdlrobson: awjr: or we can just fast track todays deployment [17:42:39] no, we can't [17:42:41] so am i applying fix or not.. [17:42:46] jdlrobson, awjr; if that's done right now you can have the last 20 minutes of my deploy window [17:42:46] (in Mobile.css) [17:43:02] hold one one sec jdlrobson lemme see if i can get the css fix cherry-picked [17:43:06] ok [17:43:07] mwalker: awesome thanks [17:43:13] * jdlrobson on standby [17:44:07] gonna take me a few minutes to update my local deployment copies; i havent done this in a while [17:47:30] yurik, i'm about to update the config pages on metawiki. ok? [17:47:32] New patchset: awjrichards; "make css backwards compatible with old html" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/62646 [17:48:00] dr0ptp4kt, you mean you have fixed your script to go against meta directly? [17:48:02] sure [17:48:15] yurik, yeah. here i go. [17:48:22] there shouldn't be any changes though ;) [17:48:34] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/62646 [17:48:41] yurik, agreed. saw you saved 'em all. [17:49:16] dr0ptp4kt, btw, i have made an ip optimization script, so we can update ips to a smaller range ONCE you are sure they are the same :) [17:49:55] yurik, "they are the same" meaning the config pages for both the api server and metawiki? [17:51:07] dr0ptp4kt, no, i meant between varnish & configs [17:51:13] i can give you optimized ranges [17:51:18] blech updating extensions in deployment branch takes forever [17:52:12] yurik, okay. LOL, no page save hooks on metawiki, so the data in the articles *is* different. well, that is to say, the canonicalized version of the files are different, even if the data is identical. [17:52:45] yurik, see http://meta.wikimedia.org/w/index.php?title=Zero:WMF, for example [17:53:47] yurik, all 20 config files are up-to-date on metawiki [17:56:06] jdlrobson: so! can we flip the switch on the siteNotice div this afternoon? [17:56:16] ^ MaxSem awjr [17:56:32] i don't see why not [17:56:45] awjr: MaxSem https://gerrit.wikimedia.org/r/#/c/61989/ is just dead code now so won't interfere [17:56:49] dr0ptp4kt, excellent, i just ran my script - the configs are identical between meta & test [17:56:58] yurik, good. [17:58:15] dr0ptp4kt, now if we can make sure that varnish ACLs are matching with our IPs, I can update them to minimize the ranges [17:59:26] jdlrobson: just sync'd updated css file to php-1.22wmf3 [17:59:50] awjr: sweet [18:00:08] awjr: looks like it worked [18:01:25] yeah, just about to get the fix out elsewhere [18:01:33] yurik, the blocks added to the json config pages are based off of the values in the raw text file in varnish. [18:01:42] yurik, does that help? [18:02:53] jdlrobson: ok fix deployed everywhere [18:03:16] dr0ptp4kt, so you are vcl scraping? Cool. Is the new IP you just added in it? Btw, there is something I have been trying to figure out [18:03:29] my banners don't match for some reason [18:03:31] :( [18:03:51] yurik, yes, vcl scraping. lemme chef the config page for that partner. the vcl change was merged last night, so this will be a good time to check [18:03:56] mwalker, jdlrobson i dont see any reason not to enable the sitenotice div (for beta only, right?) [18:04:07] awjr: it will only show on beta yes [18:04:11] dr0ptp4kt, run it against test [18:04:13] we just need to flick config switch [18:04:22] easier to see the diff [18:04:41] jdlrobson: since im not sure MaxSem is watching IRC atm, send him an email about the config change [18:04:47] i'll make a note so i dont forget either [18:05:02] * MaxSem is alive [18:05:12] yurik, running script against api machine [18:05:19] * awjr waves to MaxSem [18:06:01] jdlrobson, which Mobile.css changes? [18:06:06] MaxSem: ? [18:08:01] MaxSem: it looks like the production branch got reupdated on fri (may 3) with the changes we rolled back during last deployment :( [18:08:19] uh? [18:08:42] there was just one cherry-pick [18:08:45] dr0ptp4kt, http://meta.wikimedia.org/w/index.php?title=User%3AYurik%2FSandbox&diff=5469640&oldid=5469622 [18:09:45] yurik, oh that's right, there's no entry for that carrier with the new IP address block in https://en.wikipedia.org/wiki/MediaWiki:Zero-rated-mobile-access-carrier-options yet. so there wouldn't be a record for that yet. however, http://api.beta.wmflabs.org/wiki/Zero:413-02 is updated based on the whitelistedLangs field, which is based on the authoritative value from the vcl. [18:10:08] MaxSem: git log on the production branch shows changes that should have been reverted [18:10:17] dr0ptp4kt, some of them i understand -- "Wikipedia" cannot be localized by meta [18:10:44] but i don't understand why Orange Ivory Coast became Orange [18:10:51] for language ki [18:10:58] MaxSem: not a big deal; i just cherry-picked jon's CSS fix and deployed to prod to fix issues [18:11:34] WTF.... [18:11:45] Friday deployments suck [18:11:52] hehehe yep [18:13:03] dr0ptp4kt, do you see it? [18:13:20] yurik, looking at that. gimme a couple minutes here... [18:13:26] :) [18:14:12] awjr: MaxSem; jdlrobson; ach; dont turn on the siteNotice div... at least on the main wikis -- I only deployed to wmf3 so things like enwiki don't currently have the new code (though it should be a simple sync-dir on my part if you dont mind me nosing in on the front end of your deploy this afternoon) [18:14:40] ... or! better yet! enable it on metawiki only and we can test there [18:15:25] yeah we could do that [18:15:29] yurik, the value "Orange" is what the translators on translatewiki entered for those languages. see ZeroConfig.il8n.php [18:15:55] dr0ptp4kt, yes, i understand that, but why is the current zero installation shows Orange Ivory Coast? [18:16:35] yurik, you able to google hangout? [18:16:44] what's the best way to check which file is in production [18:16:46] sure [18:17:52] mwalker, jdlrobson, MaxSem: https://gerrit.wikimedia.org/r/#/c/62650/ [18:19:52] MaxSem, so you think there is no more time to push out zero today? [18:20:30] yurik, only as part of MF deployment, which means that I will press some buttons [18:20:37] not you [18:20:46] MaxSem, that's totally fine with me :) [18:21:08] even though i would want to do the deployment, getting stuff done is more important [18:42:16] jgonera_: i think we have a regression.. when i click watch star not logged in seeing message keys [18:42:38] jdlrobson: in prod? [18:42:40] in = I'm? [18:43:11] awjr: jgonera_ "not logged in", stable not deployed [18:43:25] l'prod? c'est moi [18:43:44] i think i saw it yesterday on beta labs now i think about it [18:43:51] ok, I'm assuming "I'm" [18:43:54] i just glossed over it as i'm so used to seeing broken message keys [18:44:01] yes, I thought it was betalabs issue [18:44:01] jgonera_: you assume wrong [18:44:19] "not logged in seeing message keys" - then I don't understand this part of the sentence [18:44:21] jgonera_: " when i click watch star not logged in … (i'm not) seeing message keys" [18:44:33] that's what I said, ok [18:44:49] no you said in=i'm ;-) in+i'm ;-) [18:45:16] jgonera_: awjr looks like an easy fix [18:45:20] but will need to merge pre deployment [18:45:50] should be, but I wonder what messed it up because it means something slipped through code review [18:47:11] jgonera_: it's really strange [18:47:19] as 'mobile-frontend-watchlist-cta' is working.. [18:47:32] hm [18:47:47] should I have a look at it? I'm currently working with limn [18:47:53] i think that might actually be a betalabs issue [18:47:56] ahhh i see [18:48:01] message cache not getting updated? [18:48:03] no it's a dependency issue [18:48:05] dunno how often that happens on betalabs [18:48:07] oh [18:48:07] ok [18:48:27] oh the dependency issues ;) [18:48:39] fix on way [18:54:27] New patchset: Jdlrobson; "move loginCaption and signupCaption to correct module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62657 [18:54:28] ^ jgonera_ awjr [18:55:51] jdlrobson, what's mobile-frontend-watchlist-cta? [18:55:59] it's not used by navigation too? [18:56:07] New review: Jdlrobson; "ah got it. It was a notification that was not styling. Fixed." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61496 [18:56:14] New patchset: Jdlrobson; "Bug 47598 Make Special:Nearby work on desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61496 [18:56:14] New patchset: Jdlrobson; "Separate notifications styling" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62658 [18:56:14] New patchset: Jdlrobson; "Code hygiene: Move overlays into separate stylesheet" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62659 [18:56:14] New patchset: Jdlrobson; "Code hygiene: Move drawer css into separate file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62660 [18:56:20] jgonera_: ? [18:56:28] jgonera_: loginCaption: mw.msg( 'mobile-frontend-watchlist-cta-button-login' ), [18:56:36] that line is in mf-navigation.js [18:56:55] it's a default of the drawer apparently [18:57:09] so key should probably be 'mobile-frontend-drawer-cta-button-login' [18:57:14] ok [18:57:30] no, I was wondering about "mobile-frontend-watchlist-cta", but I see it's in the watchlist [18:57:37] watchstar* [18:57:50] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62657 [19:08:08] brion: question when u hit break point [19:08:13] sure [19:13:05] awjr: MaxSem are we able to merge code today or will that mean it gets deployed..? [19:13:17] the latter [19:13:28] * jdlrobson sighs and goes to sit in the corner [19:13:54] don't cry, all the fun begins less than in an hour [19:14:01] i hate tuesdays for this reason :( [19:14:25] the code review backlog never shrinks on a tuesday and fairies die [19:18:10] hell yeah death metal! [19:19:33] lol [19:19:41] wow. [19:25:13] MaxSem, so what's the plan with zero? you want to include it as part of your deployment? Or should I do it with your oversight tomorrow morning? [19:25:16] (EST) [19:26:06] i definitely can [19:26:36] but would you prefer learning it? [19:27:06] MaxSem, i would prefer to learn it, yes :) [19:28:20] ok, I'll be available from ~1pm UTC tomorrow [19:28:20] MaxSem, lets do it tomorrow around 10am ET (7am PT). Would we step on anyone's toes? [19:28:39] the list of toes is here: https://wikitech.wikimedia.org/wiki/Deployments [19:30:42] and basically, everything SF working hgours should go past Greg [19:36:14] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/60775 [19:36:14] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/58875 [19:37:46] yurik, oh - so it's a Zero window tomorrow. then it's good to deploy [19:41:06] awjr, is production.bak_20130507 yours? [19:41:18] yes MaxSem, you can kill it [19:45:26] Maryana: re https://mingle.corp.wikimedia.org/projects/mobile/cards/716; take a look in the footer on http://meta.m.wikimedia.org [19:45:39] there's no ™ [19:45:52] dr0ptp4kt, go ahead on the https://gerrit.wikimedia.org/r/#/c/62034/ [19:46:08] Maryana: also, re https://mingle.corp.wikimedia.org/projects/mobile/cards/745, the fix has already been deployed; you can verify by logging on on http://meta.m.wikimedia.org [19:48:46] ah, ok, thanks awjr [19:48:54] i didn't realize those had been deployed already [19:49:01] yeah, they were just config changes [20:03:39] yurik, done [20:03:45] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62034 [20:03:47] dr0ptp4kt, thx [20:03:49] :) [20:04:24] New patchset: Yurik; "Various python scripts to help with maintenance" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62672 [20:05:13] New review: awjrichards; "LGTM and should is good to merge (just waiting til post-deployment)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/62658 [20:07:39] New review: awjrichards; "LGTM and should is good to merge (just waiting til post-deployment)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/62659 [20:09:37] New patchset: awjrichards; "Separate notifications styling" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62658 [20:09:54] New review: awjrichards; "Rebased; restoring +2/+1" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/62658 [20:10:04] New patchset: awjrichards; "Code hygiene: Move overlays into separate stylesheet" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62659 [20:10:18] New review: awjrichards; "Rebased; restoring +2/+1" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/62659 [20:10:29] New patchset: awjrichards; "Code hygiene: Move drawer css into separate file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62660 [20:11:07] New review: awjrichards; "LGTM and should is good to merge (just waiting til post-deployment)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/62660 [20:11:19] New patchset: awjrichards; "Bug 47598 Make Special:Nearby work on desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61496 [20:21:06] awjr, jdlrobson, jgonera, jcmish, Maryana - we're live on testwiki [20:21:11] please test:) [20:21:18] w00t thanks MaxSem [20:21:43] kk [20:22:29] sweet [20:22:30] on it [20:27:55] yurik, you there? [20:28:44] assuming the file upload issues im seeing are only testwiki related things are looking good to me [20:28:44] fyi, we are momentarily distracted by ragesoss being in the office. he brought us an awesome present - a fisheye lens add-on for phone cameras :) [20:28:52] cool! [20:28:58]