[00:17:47] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [00:36:51] [Commons-iOS] montehurd opened pull request #57: Moved image fetching on to an operation queue (master...over500Uploads) http://git.io/a2wmxQ [00:36:55] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [00:36:56] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [00:37:39] New review: Jdlrobson; "So Maxsem.. I'm confused are you +1ing or agreeing with Juliusz?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [00:38:38] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62415 [00:42:28] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [00:42:29] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [00:42:29] New patchset: Jdlrobson; "Make search overlay emit a hook 'write-results' after rendering" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62768 [00:49:04] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62768 [05:55:00] New patchset: Yurik; "Render proper zero banners on the Zero config pages" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62779 [12:35:05] Oh Hey there. [12:35:18] I was wondering if someone could help me. [12:35:36] I was just trying out the GeoData extension in Media Wii [12:35:41] Wiki* [12:36:42] It seems to be all working OK, But I expected to get a co-ordinates linke - sililar to Wikipedia in the page when I added a cooridnates entry [12:36:50] it doesn't seem to do anything, [13:05:59] yurik, you there? [13:46:31] Reedy: you there? seems to be a problem with bits is that known? [13:46:51] I'd just seen the chatter in some of the other channels [13:47:53] is it just mobile Reedy ? [13:52:17] Based on my attempt to just load a couple of wikis, no [13:54:20] jdlrobson: [14:35:03] we have a switch failure [13:54:48] Reedy: thanks - glad Mark knows about it :) [13:55:10] Needs onsite staff at EQIAD ASAP [13:55:50] jdlrobson: Also, not just bits [13:56:03] Reedy: has anyone been called? [13:56:14] based on the errors in #wikimedia-operations it includes squid etc [13:56:27] Reedy: o_O [13:57:14] Potential of access to memcached and redis servers too [13:57:22] Join the fun #wikimedia-operations [14:38:38] dr0ptp4kt, yei, hi [14:38:50] is Max around? [14:38:52] hi yurik [14:39:02] yurik, haven't seen MaxSem online [14:46:38] hmm... i guess no deployment until max gets here. dr0ptp4kt, i am fixing https://gerrit.wikimedia.org/r/#/c/62779 -- i found a way to render the sitename properly [14:46:54] will try to get it into this deployment too [14:53:18] New patchset: Yurik; "Render proper zero banners on the Zero config pages" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62779 [14:55:45] dr0ptp4kt, could you +2 https://gerrit.wikimedia.org/r/#/c/62779/ pls, i fixed some minor issues [14:58:08] yurik, done [14:58:11] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62779 [14:58:16] dr0ptp4kt, thx [14:58:57] dr0ptp4kt, btw, i set up the api labs to use the massive settings file from wiki, which means it shows the proper values now :) [14:59:16] yurik, sweet [14:59:54] dr0ptp4kt, ok, so should we fix the naming so it matches now? [15:00:11] where did you see the ucword issues? [15:00:56] for carrier names that exotic utf8 characters, which was a lot of them [15:01:00] ^yurik [15:01:30] dr0ptp4kt, but how does it work in production? because it does exactly the same call to the same function [15:03:01] yurik, in production it doesn't cause an error iirc, because there is no page save validation to gripe about the nulls resulting from json_encode'ing on byte sequences with strange byte order markers or what have you. [15:03:50] dr0ptp4kt, ooh, i see. In that case, lets do it this way - try to upload, if it fails, upload without uwc [15:03:59] New patchset: Jdlrobson; "Bug 48125: Support gender in mobile-frontend-photo-ownership" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62818 [15:05:21] dr0ptp4kt, because there are too many of them to fix by hand. Oh and could you add a minor check -- if localized value == "en" value, skip it [15:08:16] yurik, i believe only five of the carrier names *won't* fail. people on php.net have indicated that they used mb_* functions to work around this, but i'm really skeptical of messing with conversions at this late stage of the game. so, like you said, what we'll want to do is in the case of the carrier name, while going through each one, look for any exotic characters, and if there are exotic characters, *don't* apply ucwo [15:08:17] and if there are *no* exotic characters, do apply ucwords. [15:09:47] dr0ptp4kt, but i would think that all the extended latin & cyrillic would work fine, otherwise we would have seen lots of complains [15:10:11] they all support fairly straightforward toupper functionality [15:11:37] yurik, yeah, i believe the iso-8559-1 chars worked okay. it was a relatively small subset that was problematic. but there are translated carrier names for those problematic languages across most of the carrier names :) [15:16:02] dr0ptp4kt, right, do it for latin at this point, will deal with the rest later :) [15:20:49] New patchset: Jdlrobson; "Story 757: Add text to upload CTA in lists of articles" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62820 [15:22:28] dr0ptp4kt, "if ( preg_match( '/^[ a-zA-Zа-яА-Я0-9',.]+$/', $string ) [15:23:18] dr0ptp4kt, or if you think its good enough, lets leave it [15:23:40] i'm going to try something i saw on stack overflow really quickly [15:34:22] New review: Siebrand; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62820 [15:35:50] MaxSem, are you back :) [15:36:20] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62818 [15:38:10] dr0ptp4kt, i saw some updates - did you add the removal of localized if its the same as "en"? [15:49:06] quirk, you're talking about the case where if the translation in cn is 'wikimedia' and the translation in en is also 'wikimedia', to not add the 'cn' translation to the json key-value pair, correct? [15:49:19] yurik, i just mod'd the script and re-ran using that logic. lemme know. [15:49:54] maybe i should have used 'de' as compared to 'en', but you get the drift [15:50:21] dr0ptp4kt, yeah, basically remove any duplicate translations -- like en->"Orange" is the same as fr->"Orange", might as well remove "fr" [15:50:49] yurik, remind me, will your code just go look for the 'en' version if it can't find the version in 'fr'? [15:51:21] dr0ptp4kt, no, it goes through the list of fallback languages as defined by Language class, followed by english as the default [15:51:47] so in theory we could remove others, but that requires intimate knowledge of the traversal tree, which is not worth it IMO [15:51:58] yurik, oh right, i think i saw something about that in a python file. [15:52:40] dr0ptp4kt, you mean my scripts? [15:53:37] yurik, yes. or maybe it was a php file. can't remember which. probably both. [15:56:07] sup yurik [15:56:19] MaxSem, yeei!!!!! [15:56:22] you are alive! [15:56:24] =) [15:56:47] MaxSem, dr0ptp4kt hangout [15:57:12] yurik, ugh, looks like gerrit and en.wikipedia.org are having intermittent accessibility issues. probably related to a broken switch (saw jdlrobson and Reedy talking about that) [15:57:14] if MaxSem can help with deployment? :) [15:57:26] dr0ptp4kt: Should be all fixed now [15:57:38] People were complaining about bits still [15:57:51] dr0ptp4kt, as long as fenari is up and running, we should be ok :) [15:58:02] Reedy, thx. [15:59:30] dr0ptp4kt, rring [16:00:39] dr0ptp4kt, there? [16:01:04] yurik, yes. need i join the old google hangout or something else? [16:01:43] dr0ptp4kt, no, just log in into your account & chat [16:40:17] yurik: MaxSem this is dumb: https://bugzilla.wikimedia.org/show_bug.cgi?id=48261 [16:46:45] jdlrobson, don't challenge the API. this sensei is too tough for anyone:) [16:47:02] yurik MaxSem when do we get a new api [16:47:17] jdlrobson, tomorrow [16:47:26] i have a zero ext to deploy now [16:48:18] we will sometimes. but even it will do what you tell it to, not what you meant;) [17:06:56] all, i'm at home paired up with yurik, who is pushing ZeroRatedMobileAccess across the production cluster. after this is done, will do some exercise and clean up and arrive at the office. [17:13:49] yurik, gimme another hangout invitation [17:14:27] MaxSem, sent [17:15:05] mhurd, if it's just us we may as well skip the apps standup today :) [17:19:53] hey brion - are you around for standup? [17:23:48] camera troubles all around \o/ [17:23:54] i was also delayed by login troubles :P [17:24:01] my secondary browser was logged in with the wrong account [17:31:13] yurik, would you please resend the google hangout link? [17:31:28] yurik, comcast connection problematic once everyone in the building starts waking up. [17:33:40] Hallo. I tried https://en.m.wikipedia.org/wiki/Special:Nearby on my laptop (no GPS). I am seeing some things in the area, but all the distances are "NaN km". Known issue? [17:34:57] interesting [17:35:09] i haven't heard that one yet aharoni, though jdlrobson or MaxSem might know more ^ [17:36:06] aharoni: that's weird. I suspect that the results are not returning geo coordinates again (MaxSem ) [17:36:22] let me find the bug [17:37:01] jdlrobson, once again: that bug is a WONTFIX [17:37:32] I'm not closing it again to avoid wheel-warring, but that\s not something that can and should be fixed [17:37:33] MaxSem: it's clearly a bug. aharoni > https://bugzilla.wikimedia.org/show_bug.cgi?id=47133 [17:38:01] we'll poke yu rik to confirm when he's done deploying [17:38:41] Maybe just don't show any distance when it's NaN? Muggles are not supposed to know what "NaN" is. [17:39:15] aharoni: sure.. but it's dumb because if it's nearby then it must have an associated coordinate [17:39:26] otherwise by definition it wouldn't be nearby :) [17:46:58] it may be dumb but the frontend should be defensive as well [17:47:34] ok i gotta charge stuff and swap computers around. brb [17:48:09] jdlrobson: is aharoni actually experiencing the same bug though? that reported bug sounds resolved by using colimit in the the request [17:51:33] hey awjr, it actually does look like the watchlist settings are preserved even after logging out/logging back in! :) [17:51:40] so nice [17:51:46] Maryana: yeah, i think MaxSem fixed that after i complained about it :) [17:51:55] it's a big help [17:52:00] totes [17:52:04] thanks to you both :) [17:52:09] i just whined :p [17:52:16] it was all MaxSem [17:52:29] well, you did work on the story, too [17:52:36] :) [17:53:21] awjr, jdlrobson, MaxSem - maybe it's related to a GPS-less client? It does work from my GPS-enabled phone. [17:53:31] o_0 [17:55:20] aharoni: it sounds like you're experiencing something a little different than one jdlrobson was thinking with the aforementioned bug [17:55:40] aharoni: can you file a bug and share pertinent os/browser details? [18:01:43] awjr: OK [18:02:09] awjr: under the MobileFronted extension? [18:02:19] aharoni: yeah; thanks :) [18:12:26] awjr: is Special:Nearby only supposed to work over https? [18:12:35] no aharoni it should work either way [18:16:56] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [18:30:10] New patchset: Yurik; "Cache should vary on X-CS instead of X-Carrier" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62849 [18:48:23] hi orsa [18:48:40] awjr: in the Hebrew Wikipedia Special:Nearby doesn't seem to work at all. Is it supposed to? [18:49:30] it should aharoni i guess unless they're not using geodata [18:49:38] aharoni: what is the behavior you see? [19:00:57] New patchset: Jdlrobson; "Alpha: Generate dynamic sections using templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [19:11:18] New patchset: JGonera; "Alpha: Lazy-load sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [19:11:34] awjr: it asks me whether to share my geo information and I confirm. then it spins the loader, but doesn't show anything. [19:11:44] it works well under en.wikipedia, but not he.wikipedia. [19:12:02] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/59785 [19:16:18] aharoni: sounds like it might be a geodata issue - MaxSem might know [19:18:41] awjr: it's broken in the same way in English and Russian, in both Firefox and Chrome. But works consistently in English. [19:18:58] Sorry - broken in German and Russian. [19:19:14] aharoni: on dewiki and ruwiki? [19:19:23] awjr: yes [19:21:36] yeah; in both cases for me it finds no results nearby but rather than tell you that, it just spins forever :p [19:22:13] im not sure if there's actually nothing near me on ruwiki/dewiki or geodata isn't being used - MaxSem any thoughts? [19:22:27] aharoni: ^^ [19:24:53] awjr: also, very curiously, Firefox and Chrome give completely different results. [19:25:04] the results in Chrome are closer to where I actually live. [19:25:16] the results in Firefox are from another part of the city. [19:25:25] taht's interesting; there must be a difference in how the browsers are detecting your location [19:26:29] awjr: in Chrome, the nearest result is http://en.wikipedia.org/wiki/Jerusalem_Road_16 . In Firefox it's http://en.wikipedia.org/wiki/Assyrian_Siege_of_Jerusalem . [19:26:53] aharoni: from your laptop/no gps? [19:27:05] yes, laptop, no gps. [19:27:30] MaxSem, that double-escaping issue - i don't see it for some reason -- http://api.beta.wmflabs.org/wiki/Zero:250-99 -- i changed RU for both the name and the banner, but it renders fine at the bottom [19:29:25] could someone with meta admin rights check if they can edit http://meta.wikimedia.org/wiki/Zero:250-99 (please don't edit if you can) [19:30:46] aharoni: firefox uses the google location service; perhaps google wont let them be as accurate. i think they both try to determine location based on IP address and access point info as well (google and mozilla may have different dbs about access point location info) [19:31:34] hi aharoni [19:32:35] orsa, can you try https://en.m.wikipedia.org/wiki/Special:Nearby in Firefox and in Chrome? Do you see the same places displayed? [19:34:32] awjr: on my GPS phone i do see the same results in WebKit and in Firefox for Android, and they are similar to the Chrome results from the laptop. [19:34:59] aharoni: yeah it sounds like chrome is more accurate in your case [19:35:29] (Maybe Firefox on the laptop just gets the name of the city - Jerusalem? And then the coordinates is in the center of the city? Because the results in Firefox on the laptop show places in the city center. Just guessing.) [19:36:31] my guess aharoni is either google is being stingy with their geolocation service used by firefox or google has something in their db that firefox doesnt that allows them to be more accurate (access point info, for example) [19:38:50] aharoni, what's your location? [19:39:53] yurik, I see no stuff that needs to be HTML-escaped there, so it's a non-issue. still, "Бесплатный доступ к Википедиа для абонентов & Билайн& < >" is wrong:) [19:40:00] MaxSem: good question. Can i see the coordinates in my phone? (Android). [19:40:19] aharoni, just city is enough:) [19:40:25] Jerusalem. [19:40:28] MaxSem, I added those symbols to the name, and they don't have double escaping, so it seems they are correct [19:40:43] MaxSem, take a look at the "ru" entries for banner and for the name [19:40:56] MaxSem: close to http://en.wikipedia.org/wiki/Mount_Herzl [19:41:11] yurik, arrrr - rawParams() [19:42:13] MaxSem, so how should it be? [19:42:44] or is that a correct way? [19:42:49] $linkTextMsg->inLanguage( $lang )->rawParams( $nameMsg->inLanguage( $lang )->escaped() )->escaped(); [19:43:31] aharoni, one sec [19:43:43] so yeah, because of rawParams() it's escaped once [19:44:01] dammit, a bowl of spaghetti [19:47:17] aharoni, yes, but not exactly in the same order [19:47:41] orsa: curious. where are you, if you don't mind telling? [19:49:08] tel aviv, north [19:51:00] Maryana: we need to play this to avoid copy violating uploads https://www.youtube.com/watch?v=I9_hWoGrxWg [19:51:10] Maryana: it's the only way we can stop the influx on mobile [19:51:17] aharoni: tel aviv, north. you need more specific? [19:51:19] advertisement [19:51:24] with pandas [19:51:27] i hate youtube [19:51:32] without the advertisement of course ;-) [19:57:53] orsa: thanks, should be enough. [19:58:55] Maryana: awjr sue stole our room [19:59:36] feel free to try and kick her out jdlrobson, we've had it reserved and there's not a suitable alternative for us [20:00:12] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62820 [20:04:18] Maryana, jdlrobson any luck? [20:04:27] yeah, we kicked sue out [20:04:30] setting up now :) [20:04:31] nice [20:04:53] i hope that wasn't too big of a deal [20:22:14] MaxSem, https://gerrit.wikimedia.org/r/#/c/62867/ -- i figured this can go in right away -- I decided to copy X-CS -> X-Carrier, which makes it still unique [20:22:36] until mobile ext goes live [20:22:37] +1 month [20:22:42] yurik, thnx - will look after the mtg [20:28:50] New patchset: Raimond Spekking; "Revert "Localisation updates from http://translatewiki.net."" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62915 [20:29:34] Change merged: Raimond Spekking; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62915 [20:47:42] awjr: are you guys still meeting or did I miss it? [20:49:42] New review: Jdlrobson; "needs a rewrite" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/62412 [20:51:51] New patchset: JGonera; "Story 487: Footer update" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [20:51:56] jcmish: we're done with the prioritization meeting [20:52:12] but there's the navigation meeting in 10 mins or so [20:52:19] jdlrobson, https://gerrit.wikimedia.org/r/61474 [20:55:17] nice… NSDate is immutable, but java.lang.Date is mutable. another fun difference to keep track of [20:55:36] is navigation meeting in the same hangout? [20:55:45] kudos to open street map folks - they have released a really good HTML editor [20:56:10] (HTML5 instead of their legacy flash editor) [20:56:54] Maryana_lunch: i don't see a hangout link in the calendar invite [20:57:53] somebody gets to create a hangout manually, whee [20:58:02] d'oh [20:58:04] New patchset: JGonera; "Story 487: Footer update" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [20:58:05] added [20:58:09] Maryana, what's the hangout url? [20:58:28] https://plus.google.com/hangouts/_/04b009904acf673ec12a199b05916b5e0637e9f0 [20:59:15] New review: Jdlrobson; "last modified disappeared.. :(" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61474 [20:59:15] hmm, I'm alone there:) [20:59:45] whee [21:07:03] http://etherpad.wikimedia.org/Mobile-20navigation-20planning [21:07:08] yurik, you there? [21:07:18] dr0ptp4kt, yep [21:07:53] which branch and in which folder (directory) should i place the ETLZero stuff? i realize we likely won't need to run it again, but want to have checked in for posterity's sake [21:09:12] dr0ptp4kt, etlzero is the script you wrote? put it into maintenace [21:09:31] dr0ptp4kt, i have some python scripts pending (btw, +2 them pls) [21:09:35] master branch, maintenance folder of ZRMA, correct? [21:09:41] just put them there, or a separate subdir [21:09:43] yep [21:09:49] yurik, uno momento on the +2 [21:09:55] thx :) [21:10:03] btw, dr0ptp4kt did you see the varnish change i posted? [21:10:18] it removes the X-Carrier, while still maintaining the cachability [21:10:34] i simply copy the X-CS into X-Carrier at the end [21:10:58] yurik, saw the notification for it, but haven't read the substance of it. switching back contexts, what's the change number for your scripts? i don't think i see it my incoming reviews [21:11:25] https://gerrit.wikimedia.org/r/#/c/62672/ [21:11:30] sorry forgot to add you [21:12:55] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62672 [21:13:04] ^yurik [21:18:52] dr0ptp4kt, check in yours and let me know [21:19:57] New patchset: Dr0ptp4kt; "ETL script and i18n file for preparing v1.1.0 of ZeroRatedMobileAccess." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62920 [21:20:32] ^yurik, patchset submitted [21:42:01] awjr, jcmish http://i.imgur.com/0ID0tAS.jpg [21:42:15] thanks! [21:42:21] sweet [21:42:23] thanks jgonera [21:44:42] jgonera: that's helpful thanks [21:44:48] yup thanks [22:03:14] dr0ptp4kt: got a question about the spoofing settings [22:03:29] dfoy, shall i head up to 6? [22:03:41] dr0ptp4kt: No, I'm WFH today [22:04:04] dfoy, ok. how about a google hangout? [22:04:24] ok sure [22:12:18] New review: JGonera; "Not this change's problem, last modified is not visible on master. Can we merge otherwise?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [22:12:31] dfoy, power cycling my android. it curiously doesn't always connect to 4g or 3g after i've toggled data on or off a couple of times. power cycling usually takes care of it... [22:12:48] dfoy, gotta do that to get 4g/3g working, so i can tether... [22:12:52] dr0ptp4kt: ok np [22:15:41] [Commons-iOS] brion created cats-work (+19 new commits): http://git.io/G80bRA [22:15:41] Commons-iOS/cats-work 18cd4a7 Brion Vibber: Initial stab at UI for adding categories... [22:15:41] Commons-iOS/cats-work 20cfe53 Brion Vibber: Make license selector page localizable, include a web link... [22:15:41] Commons-iOS/cats-work dcc6b55 Brion Vibber: work in progress -- cats pag [22:17:29] [Commons-iOS] brion opened pull request #58: Category addition & list for iOS app (master...cats-work) http://git.io/4nTW0A [22:21:40] New review: Siebrand; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61474 [22:22:16] ok back to the charger, then some code review \o/ [23:27:46] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62849 [23:32:45] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [23:35:40] i was going to leave a note on the en.wikivoyage village pump about nearby, but i realized i don't know what the actual problem is. does anyone know? [23:35:46] is it how geodata is configured? [23:35:53] max does but he's gone for the day [23:35:56] bah [23:36:06] ok [23:36:10] i tried making sense of it yesterday and didn't get very far :( [23:36:11] i'll check in w/him tomorrow [23:36:21] yeah, i want to be able to come at it with a clear proposal [23:36:25] totes [23:36:28] "just do this and you can have this amazing feature!" [23:37:10] i believe there was however some complication due in part to the fact that wikivoyage uses multiple POIs which i gathered somehow interviewed with ascertaining correct coordinates for an article [23:37:14] but… yeah, ask max [23:37:26] s/interviewed/interfered [23:41:23] New patchset: JGonera; "Make header button markup more universal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62935 [23:41:34] New review: awjrichards; "This LGTM - tests pass and I appreciate the switch to using strpos(). Is this still a WIP? If not, I..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/61942 [23:45:06] New patchset: JGonera; "Make header button markup more universal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62935 [23:46:54] Maryana, can you answer / tell me waht the answer is to Siebrand's question in https://gerrit.wikimedia.org/r/#/c/61474/7/MobileFrontend.i18n.php [23:47:02] New review: awjrichards; "LGTM but feel nervous about all those CSS changes without someone else taking a look." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/62935 [23:47:38] jgonera, "content" vs. "text"? [23:47:53] yes, legal specifically requested that to be clear that images, for example, may use a different license [23:47:59] but all text is cc-by-sa 3.0 [23:48:01] I don't know, is it important? [23:48:02] ok [23:48:06] so I should change the key name [23:48:13] yes [23:48:14] so that the old translations get updated [23:48:33] that would be great, yeah [23:50:55] New patchset: JGonera; "Story 487: Footer update" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [23:51:37] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [23:52:19] jdlrobson, can we merge https://gerrit.wikimedia.org/r/#/c/61474/ ? [23:53:11] also, jdlrobson, if you have a moment: https://gerrit.wikimedia.org/r/#/c/62935/