[00:09:00] i'm heading out a little earlier today to attend a dinner thingy. anybody need anything from me before i go? [00:10:13] going once, going twice [00:12:09] New patchset: Jdlrobson; "Bug 48273: Show last modified again" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62938 [00:21:36] New patchset: Jdlrobson; "Bug 48273: Show last modified again" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62938 [00:22:21] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62938 [00:28:57] New patchset: Jdlrobson; "Message key dependency fix 'mobile-frontend-drawer-cancel'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62939 [00:32:51] New patchset: Jdlrobson; "Story 757: Add text to upload CTA in lists of articles" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62820 [00:33:44] New patchset: JGonera; "Story 487: Footer update" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [00:35:33] New review: Jdlrobson; "Messes up buttons in photo upload" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62935 [00:37:46] New patchset: JGonera; "Make header button markup more universal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62935 [00:41:02] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61474 [00:51:26] New patchset: Jdlrobson; "Story 498 Beta: Promote lazy loaded sections from alpha" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62940 [00:56:30] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62935 [00:56:55] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62940 [01:01:52] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62939 [01:22:01] Change abandoned: Jdlrobson; "no longer necessary done in https://gerrit.wikimedia.org/r/#/c/62940/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62413 [01:24:24] * awjr high-fives jdlrobson [01:26:18] awjr: all the bug killing? [01:26:23] and merging [01:26:25] jack the giant bug slayer! [01:26:30] well juliusz hung around [01:26:31] SQUASH! [01:26:34] so we got a load of shit done [01:26:44] yeah, i'd totally high-five him too but don't see him around :( [01:26:48] it makes me want to kill bugs more though.. [01:26:55] since the bug list is at an all time low [01:26:56] s [01:26:57] once you pop you can't stop [01:27:02] soon there may be no mobile bugz [01:27:11] o_0 [01:27:15] i kinda want to kill the NaN one right now [01:27:41] that is probably a quick one [01:27:49] actually [01:27:51] https://mingle.corp.wikimedia.org/projects/mobile/cards/704 [01:27:59] needs a device i dont have [01:28:05] blackberry awfulness [01:28:27] my suspicion is bad blackberry browser behavior (i've heard of blackberry/cookie/https problems before) [01:29:53] easy fix WIN [01:31:16] i need to find some time to make bingle smarter [01:31:50] it would be nice if there was more interplay between bugzilla and mingle… otherwise there's going to be a lot of extra cruft floating around in mingle [01:32:26] bugzilla has a restful API but we don't have it set up (it actually requires another piece of software that proxies for BZ…) [01:32:37] out of the box it has a json and xmlrpc api [01:32:59] but it is a little whack (surprise!) [01:33:19] if i can figure it out though, bingle could be a lot more powerful [01:33:48] another thing i'd like to explore htough is something you brought up the other day, jdlrobson - gerrit/mingle integration [01:34:51] anyway, im outta here. goodnight! [01:35:40] New patchset: Dr0ptp4kt; "Bug 44436 - add warning interstitials for non-whitelisted langs." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62942 [01:38:39] New patchset: Jdlrobson; "Bug 48268: NaN NaN NaN NaN NaN NaN batttman" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62944 [01:42:26] ok awjr_away i think it's time for me to leave work [04:58:15] New patchset: Yurik; "Allow zero config to be shown in the user language" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62950 [05:00:28] New patchset: Yurik; "tests cleanup" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62951 [05:52:01] New patchset: Jdlrobson; "Story 757: Add text to upload CTA in lists of articles" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62820 [06:05:51] Change abandoned: Yurik; "Weird bug in gerrit I take it - the file has already been changed in master, so abandoning to remove..." [mediawiki/extensions/ZeroRatedMobileAccess] (migrate-mfe-to-zrma) - https://gerrit.wikimedia.org/r/59757 [06:23:41] New review: Yurik; "Holly mackerel! That is a huge script. I did not expect it to be that huge :) Good job!" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 2; - https://gerrit.wikimedia.org/r/62920 [07:56:20] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62920 [10:40:32] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62961 [11:51:19] New patchset: Siebrand; "Use XHTML compliant breaks" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62967 [11:54:08] New review: Raimond Spekking; "Now maintenance/ZeroConfig.i18n.php is a dupe of includes/ZeroConfig.i18n.php" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62920 [11:56:57] New review: Raimond Spekking; "Strike the last. It's not a dupe, my fault." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62920 [13:34:25] New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62961 [13:34:25] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62961 [13:41:18] [android-commons] siebrand pushed 1 new commit to master: http://git.io/iA_lXA [13:41:18] android-commons/master ce66748 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [13:41:42] Project WiktionaryMobile - Nightly builds build #127: STILL FAILING in 1.8 sec: https://integration.wikimedia.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/127/ [13:41:43] s.mazeland: Localisation updates from http://translatewiki.net. [13:41:49] Project Android-Commons (mobile) - Nightly builds build #166: SUCCESS in 42 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/166/ [13:41:49] s.mazeland: Localisation updates from http://translatewiki.net. [13:41:53] [Commons-iOS] siebrand pushed 1 new commit to master: http://git.io/kvuRIg [13:41:53] Commons-iOS/master d11616c Siebrand Mazeland: Localisation updates from http://translatewiki.net. [13:42:02] Project WikipediaMobile - Nightly builds build #518: STILL FAILING in 1.8 sec: https://integration.wikimedia.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/518/ [13:42:13] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/iNvx6A [13:42:13] WikipediaMobile/master d2dc71f Siebrand Mazeland: Localisation updates from http://translatewiki.net. [15:03:44] New review: Siebrand; "L10n/i18n LGTM." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/62820 [15:41:26] New patchset: Nemo bis; "Replace dragons with plain language" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62617 [15:43:49] New patchset: Nemo bis; "Replace dragons with plain language" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62617 [15:45:32] New review: Nemo bis; "@MaxSem: Done. What name? The new messages don't use any proper name, on purpose, but just a descrip..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62617 [15:48:26] New patchset: Jdlrobson; "Bug 47103: Prevent undefined photos being added to the page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62981 [16:08:39] New review: Siebrand; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62129 [16:48:51] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62967 [17:42:08] MaxSem: awjr any idea whether we still need mf-stop-mobile-redirect.js [17:42:17] yes we do jdlrobson [17:42:30] what does it do - it's not documented at all [17:42:40] it seems to add a click handler to the desktop link [17:42:41] oh wait [17:42:44] that writes a cookie [17:42:47] i was confusing that with unset_stopmobileredirect.js [17:42:47] but what it does i don't know [17:43:03] lemme look [17:43:04] it sets a cookie called mf_mobileFormat [17:45:52] jdlrobson: it's for using javascript to set stopMobileRedirect cookie from the mobile site to desktop site (and if there's no separate mobile domain, unset the cookie that's used to keep users on the mobile site) [17:45:58] New review: Dr0ptp4kt; "Siebrand, just wanted to say thanks!" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62967 [17:46:29] jdlrobson: we need it. [17:46:37] awjr: can you document the js? [17:46:40] sure [17:46:42] FIXME: please document purpose of this [17:46:56] i keep coming back to it and don't understand why i need to be supporting it :) [17:46:59] hehehe [17:47:37] New patchset: MaxSem; "Update readme" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62993 [17:50:01] MaxSem: so this is not quite true either any more^ [17:50:13] JS files in this directory are designed for mobile but may work on desktop :) [17:50:20] for example nearby will work on desktop come tuesday [17:50:23] meh [17:50:26] things are getting blurry ;-) [17:50:31] feel free to reformulate [17:50:38] ohh wait a minute [17:50:44] no this is fine - i misread [17:50:53] these should be desktop only [17:50:59] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62993 [17:51:20] so MaxSem do we really need to kill the dragon? [17:51:24] i'm going to miss the dragon :( [17:51:34] too poetic [17:51:42] think of non-native speakers [17:51:51] i know.. but think of the dragon [17:52:04] that mythical beast weaving his way through the skies unleashing fire on the cold [17:52:30] wreaking destruction and liberating the damsels imprisoned in the castles [17:52:56] New patchset: awjrichards; "Document mf-stop-mobile-redirect.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62996 [17:54:26] awjr: so that file doesn't have to be added if $wgMobileUrlTemplate is set? [17:54:39] jdlrobson: it does [17:55:00] ah i see [17:55:00] shame :( [17:55:07] New review: Jdlrobson; "thank you!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62996 [17:55:08] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62996 [17:55:11] jdlrobson: ' We have backend code to handle this too, however if a user is sent to a cached page, the PHP code that handles this will not get executed. Hence this JS.' [17:55:14] so awjr MaxSem do you want me to slay the dragon? [17:55:21] jdlrobson: huh? [17:55:36] https://gerrit.wikimedia.org/r/#/c/62617/ < if we are doing this please let me at least do it [17:56:03] jdlrobson: i dont really care about the language, Maryana should make the call [17:56:16] I'm for it, any comments from others? [17:56:17] where is Maryana [17:56:27] i'm talking to howie in r37 [17:56:59] ok Maryana just let me know when you're done if I should slay the dragon [17:57:40] New patchset: Jdlrobson; "i18n: Slay the dragon in favour of plain language" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62617 [17:57:59] i'm in an ori-l mood [18:03:38] awjr: does 'wgUseFormatCookie' ever need to be set on desktop? [18:03:47] it seems to only be used in js on mobile [18:04:55] jdlrobson: i believe you are correct, it is only used on the mobile view [18:06:02] same with wgStopMobileRedirectCookie [18:06:23] though we might want to use wgStopMobileRedirectCookie in unset_stomobileredirect.js rather than the ad-hoc vars [18:06:47] those vars came into existence after those js files were originally written, i think [18:07:03] jdlrobson: also, we really should stop using the wg prefix on things that are not actually MW global variables [18:07:34] awjr: yes yes yes.. i'm cleaning this all up as we speak [18:07:51] :) [18:12:46] jdlrobson, ok, which dragon are we talking about this time? :) [18:14:00] Maryana: https://gerrit.wikimedia.org/r/#/c/62617/4/MobileFrontend.i18n.php [18:14:32] changing dragons to experimental? that would honestly probably be good [18:14:43] dragons is cute and all, but i'm sure it's a bitch to localize [18:14:45] any sign of jgonera btw? [18:14:57] plus it runs over the settings toggle on the settings page [18:15:03] jgonera is out sick, i think [18:15:10] but i'm up on 6, so not sure [18:15:12] New review: Jdlrobson; "The dragon is slayed." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62617 [18:15:12] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62617 [18:17:29] Maryana: experimental does as well on smaller screens - the settings page doesn't cope up with long strings [18:18:47] ah, right [18:18:48] oh well [18:19:02] that might be highly variable in other langues [18:19:05] er [18:19:06] languages [18:19:24] you were just saying the french word ;) [18:20:03] hehehe precisement [18:24:29] MaxSem: should we try to push the gadgets changes to production? [18:24:40] we could probably snag some time this afternoon (after e3 deployment, or during lightning deploy) [18:25:26] is it so urgent? [18:25:41] dunno, Maryana ^? [18:25:44] New patchset: Jdlrobson; "Story 578: Allow photo uploads on pages with infoboxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [18:25:47] New patchset: Jdlrobson; "Bug 44133: Cleanup how we do config" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63003 [18:26:04] i guess if we didnt do it now there's a chance we wont see the fix on enwiki for a couple of weeks [18:26:04] i don't see the lead image upload button anymore because of that issue :( [18:26:13] that sounds urgent to me [18:26:33] as a maryana, i would like to upload, plz [18:26:55] hehehe [18:27:41] upload, how boring [18:27:56] only cowbell matters [18:36:45] New patchset: Jdlrobson; "Bug 46726: Remove table tweaks on opera mini" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63004 [18:45:26] \o/ time to merge categories for ios [18:46:10] jdlrobson: re story 757, https://gerrit.wikimedia.org/r/#/c/62820/3 only adds the text to nearby - what about watchlist? [18:51:36] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/dKcaCA [18:51:36] Commons-iOS/master cfdf759 Brion Vibber: Add new languages to project [18:51:36] Commons-iOS/master cf19772 Brion Vibber: Merge branch 'cats-work'... [18:51:49] woohoo [18:53:15] hey team, see my comment at https://bugzilla.wikimedia.org/show_bug.cgi?id=43305#c5 [18:58:50] Maryana: code committed for https://mingle.corp.wikimedia.org/projects/mobile/cards/757 currently only applies for nearby; should this be happening elsewhere (wathclist, ??)? [18:59:12] err, yes [19:00:21] “Add a photo” text should appear on upload CTA asset wherever it appears (e.g., nearby, watchlist, etc.) [19:01:35] what other lists are there other than nearby and watchlist, Maryana? [19:01:51] well, potentially search if/when we add in the upload cta there [19:02:03] but for now just nearby & watchlist [19:02:05] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/ePoL_A [19:02:05] Commons-iOS/master 4881337 Brion Vibber: Request larger image on iPad to make it zoomable [19:02:41] Maryana: ok; can we update the a/c there to just say 'nearby and watchlist' and add the text requirement to the card about adding pageimages to search? [19:02:54] sure thing [19:03:05] gahh the mosquitos have been out in full force here and seem to have a penchant for my feet [19:03:11] thanks :) [19:04:01] done [19:17:16] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63002 [19:20:35] jdlrobson: on https://mingle.corp.wikimedia.org/projects/mobile/cards/771 you added a comment 'see #733' but card 733 seems entirely unrelated? [19:31:01] New patchset: Dr0ptp4kt; "Bug 44436 - add warning interstitials for non-whitelisted langs." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62942 [19:33:34] Maryana_lunch: fyi https://mingle.corp.wikimedia.org/projects/mobile/cards/777 [19:34:21] ah, good call on that [19:35:14] yurik, you there? [19:35:26] dr0ptp4kt, nope [19:36:05] yurik, ha. okay if i abandon the diffs on the master branch on apibeta inside ZeroRatedMobileAccess? i noticed there were a few added lines, and wanted to double chec before i git pull'd [19:36:27] dr0ptp4kt, sec [19:36:35] yurik, k, lemme know once safe [19:37:05] dr0ptp4kt, done [19:37:10] resetted [19:37:16] yurik, gracias [19:37:26] dr0ptp4kt, dinaros! [19:37:38] correction see #773 awjr [19:37:55] or is that dinados? [19:37:57] no dinaros, amigo [19:38:04] :) [19:39:29] New review: awjrichards; "Seems to work for me locally, thanks :)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62944 [19:40:19] jdlrobson: oh; yeah - i guess the name of the bug got changed, hence the dupe [19:42:28] awjr, jdlrobson, Maryana - thoughts on https://bugzilla.wikimedia.org/show_bug.cgi?id=43305#c5 ? [19:44:29] OuKB: are we sure the useformat=mobile thing isn't a red herring? [19:44:46] i'm still not sure what's going on there. i've been talking to mobile editors who say they've never edited the mobile site, just the desktop view, and yet their edits are tagged with the mobile rc tag [19:44:52] the issue Maryana brought up, "Edits made to articles via lead image upload still don't have the mobile edit tag" sounds… different [19:44:57] without it it works. with it, it shoudln't [19:45:20] also, i dont understand 'edits made to articles via lead image upload' [19:45:26] i think in general the mobile edit tag is somewhat… mysteriously applied [19:45:49] unless you mean when the image is added to the article, the edit is not tagged as mobile, Maryana? [19:45:54] yes [19:46:06] which sounds like a different problem [19:46:36] and like the useformat=mobile thing is a redherring [19:46:40] Maryana, I just posted a link to working edit [19:46:42] yeah, agreed [19:47:10] so unless there's a repro, that bug is CLOSED WFM [19:47:52] OuKB: not seeing your link on the bug [19:48:18] https://en.wikipedia.org/w/index.php?title=Albert_Pitt&action=history [19:48:24] (cur | prev) 22:38, 9 May 2013‎ MaxSem (talk | contribs | block)‎ . . (5,891 bytes) (+103)‎ . . (Added photo to page) (undo) (Tag: Mobile edit) [19:48:32] ah, sweet [19:48:43] ok, looks like that's resolved :) [19:48:56] w00t [19:49:31] hmm jenkins is not merging changes i +2d a while ago [19:50:11] huh and im not seeing jobs to deal with them on https://integration.wikimedia.org/zuul/ [19:50:18] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62944 [19:50:37] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63004 [19:50:48] gah i was going to bug hashar about it in case there's a bigger issue [19:50:52] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62820 [19:50:56] but thanks for merging :) [19:51:08] jenkins is being jenkins, nothing new:) [19:51:51] heh [19:52:07] hmm, we have suspiciously few commits in review. who kidnapped Jon?:P [19:52:31] he's sitting right in front of me. unless he's a clone [19:52:37] … are you a clone, jdlrobson? [19:52:45] (12:48:10 PM) ori-l: !jenkins [19:52:45] (12:48:10 PM) e3-standup-bot: Jenkins has 56 jobs queued up. [19:52:48] just fyi [19:53:41] oh hey, maxsem, question for you [19:53:56] do you know what needs to be fixed in order for nearby to work on wikivoyage? [19:54:10] are they just misapplying geodata somehow? [19:54:13] lol MaxSem [19:54:17] get them to use it in their templates [19:54:47] which templates? [19:55:03] MaxSem: is this ready to go now? https://gerrit.wikimedia.org/r/#/c/61989/ if so it looks ok to merge to me [19:55:06] coordinates [19:55:27] but as I already said, it's probably not really helpful for them because they have huge pages with a lot of POIs [19:55:53] i see this in a random wvoyage page: {{geo|51.9500|5.2333}} [19:55:59] awjr, not yet, I'm trying to simplify the regexes [19:56:06] k [19:56:09] *further [19:56:34] basically, foo.*bar is not fast enough [19:57:05] jdlrobson, can we merge iphone with android as webkit?:P [19:57:18] oh whoops, MaxSem i meant https://gerrit.wikimedia.org/r/#/c/61942/ [19:57:44] meh, and I meant it too:P [19:57:49] lol [19:58:27] New review: awjrichards; "Still WIP, Max is trying to further simplify regexes." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/61942 [19:59:02] I'll tweak https://gerrit.wikimedia.org/r/#/c/61989/ now [20:06:21] New patchset: MaxSem; "Bug 47586: Remove DeviceDetection js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [20:06:27] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [20:20:09] MaxSem: whoops i killed Mobile.js again... [20:36:19] New patchset: Dr0ptp4kt; "Bug 44436 - add warning interstitials for non-whitelisted langs." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62942 [20:36:37] New patchset: Jdlrobson; "Move nearby overlays to separate module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63061 [20:37:59] New patchset: Jdlrobson; "Move mobile-frontend-overlay-escape key to correct module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63062 [20:39:00] New patchset: Jdlrobson; "Move mobile-frontend-overlay-escape key to correct module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63062 [20:39:13] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63062 [20:46:24] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [20:47:40] New patchset: Jdlrobson; "Fix nearby / Move nearby overlays to separate module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63061 [20:49:50] New patchset: Jdlrobson; "Allow validation testing for arbitary pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62643 [20:51:45] brion: should i just go with the file title hack for now? [20:51:53] sure [20:52:10] cool it's touching core data stuff so i recoiled a bit haha [20:53:00] yurik, you there? [20:53:17] dr0ptp4kt, yep [20:53:28] you mind reviewing and +2'ing https://gerrit.wikimedia.org/r/#/c/62942/ ? [20:53:31] ^yurik [20:53:44] dr0ptp4kt, 5 min [20:53:51] yurik, cool, thx [20:54:24] New review: Dr0ptp4kt; "This works on apibeta." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 1 - https://gerrit.wikimedia.org/r/62942 [20:56:24] Change abandoned: Dr0ptp4kt; "This has been migrated to a forked branch in master. See change 62942." [mediawiki/extensions/ZeroRatedMobileAccess] (production) - https://gerrit.wikimedia.org/r/62527 [21:03:04] dr0ptp4kt, yes, i saw that, will working on it now [21:03:34] yurik, thanks. i abandoned production, and the only change is the 62942 on master. [21:03:49] dr0ptp4kt, what do you mean abandoned production? [21:04:24] yurik, i abandoned the interstitial for dropdowns on the 'production' branch. the submitted change for review, 62942, is in the 'master' branch. [21:05:03] dr0ptp4kt, a, gotcha, cool [21:05:17] dr0ptp4kt, will delete production branch all together [21:05:37] do we have the final HEAD on that saved somewhere in gerrit? [21:05:48] ^yurik [21:06:05] dr0ptp4kt, ?? [21:06:45] yurik, will gerrit still have a copy of the old 'production' branch for zrma so that if we need to examine history we have the option? [21:06:58] yurik, that is to say…after deletion of the 'production' branch [21:08:27] dr0ptp4kt, good question - not sure really, what does git delete - everything that's not tracable from the references? [21:08:57] dr0ptp4kt, let me look at where production is pointing to [21:08:58] sec [21:09:26] yurik, i'm not sure about that. thx for looking... [21:12:54] dr0ptp4kt, production had two patches, -- Stopping Wikipedia Zero X close button from overlaying elements. and -- Appending 'wiki/Main_Page' to home page links currently pointing to http://[LANG_CODE].(zero|m).wikipedia.org/ [21:13:12] and was not merged back into the master [21:14:36] dr0ptp4kt, but both seemed to have been reimplemented in the master [21:15:40] yurik, i think those were cherry-picked for deploys. seeing as we have these items in the history of master (via zrma v1.1.0) i'm not afraid of the 'production' branch being lost. [21:16:25] dr0ptp4kt, ok, deleting it thene [21:17:09] yurik, cool. "what's the worst that could happen" --famous last words :) [21:17:20] yurik, in all seriousness, i can't think of any damage done. [21:17:38] dr0ptp4kt, at the end of the day, deleting a branch in git is simply removing the ref :) [21:21:50] dr0ptp4kt, come to think of it, i will also delete all other, non REL branches [21:21:53] https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/ZeroRatedMobileAccess,branches [21:22:04] migrate-mfe..., per-partner, production [21:22:17] they are all junk [21:23:17] yurik, are rel1_19 and rel1_20 accounted for in master as well? [21:23:28] agreed migrate- and per- can go [21:23:55] yep, rel1.20 is just a point in nov 2012 [21:23:57] the rel1_19 and rel1_20 i think are there to indicate that they can run on the older releases of core, but i dunno [21:24:08] yurik, cool [21:24:21] and rel_19 is in feb of 2012 [21:24:38] i just don't want junk "development" branches [21:24:47] because they may confuse [21:24:59] roadstones are fine [21:25:05] yurik, yeah. agreed, that's one thing that makes life anytime one is visiting project repos! [21:25:21] s/makes life anytime/makes life difficult anytime/ [21:28:28] dr0ptp4kt, do a "git remote prune gerrit" if you want to delete them locally as well after you git pull [21:29:02] yurik, good one, i forgot about that. [21:37:57] how do I center an image in a div? [21:39:22] *with div's styles? [21:39:34] MaxSem: margin-left: auto; margin-right: auto; [21:39:34] iirc [21:43:58] New patchset: MaxSem; "Bug 47648: meta.m.wikimedia.org user login screen inexplicably has "W" icon" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63072 [21:44:28] brion: think i'm ready to commit... [21:44:52] \o/ [21:46:37] New patchset: Jdlrobson; "Tweaks to search css when no javascript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63073 [21:53:41] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63072 [21:54:13] New review: JGonera; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63073 [21:55:32] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63073 [21:55:50] MaxSem: will you take care of the configuration change that will be needed with https://gerrit.wikimedia.org/r/#/c/63072/1 ? [21:56:49] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63072 [21:57:00] jdlrobson, ^^ [21:57:20] MaxSem: isn't $wgMobileFrontendLogo used by footer? [21:57:33] GREP INDICATES OTHERWISE [21:57:37] eh [21:59:17] MaxSem: ah that's a different icon [22:00:10] ok i stand corrected [22:02:55] New patchset: Dr0ptp4kt; "Bug 44436 - add warning interstitials for non-whitelisted langs." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62942 [22:03:45] ^yurik pushed new patchset after rebase. [22:04:37] dr0ptp4kt, k [22:08:51] New review: Dr0ptp4kt; "Patchset 4 works in apibeta." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 1 - https://gerrit.wikimedia.org/r/62942 [22:09:31] ^yurik, i confirmed against apibeta as working. lemme know if you have any questions for your code review. it is counterintuitive. [22:10:08] yurik (the code approach required, not the concept of having an interstitial). but it's small, too. [22:10:28] dr0ptp4kt, ok, i just need to check in something that dan was waiting for [22:10:30] sec [22:10:40] yurik, roger [22:13:46] New patchset: Jdlrobson; "Bug 47648: meta.m.wikimedia.org user login screen inexplicably has "W" icon" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63072 [22:14:38] New review: Jdlrobson; "MaxSem if you can setup the config change so we don't lose the W on enwiki this is good to go" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/63072 [22:17:34] brion: hmm won't let me push [22:17:58] mhurd: try push --force [22:18:01] may be needed after amending or rebasing [22:18:08] brion: ah [22:18:37] brion: that did it :) [22:18:40] woohoo [22:21:49] brion: i see the changes on my repo - but they didn't carry over to the prev pull req [22:22:17] jdlrobson, it's already set [22:22:27] MaxSem: it is? changeset..? [22:22:45] New patchset: Yurik; "tests and scripts cleanup" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62951 [22:22:47] since forever [22:22:59] guess we just need to increase the image sizes [22:23:19] is 72px height optimal? [22:25:53] MaxSem: that's what it was before - i don't want to change it [22:28:14] MaxSem: it's not been set forever [22:28:21] i suspect the existing value is different [22:28:27] you said earlier you repurposed the meaning of it [22:28:50] yeah, so I'm updating it to 72px [22:29:03] i just want to ensure what ever that config variable is exactly the same image as http://jonrobson.me.uk/images/W.png [22:30:35] MaxSem: so yeh http://upload.wikimedia.org/wikipedia/commons/8/84/W_logo_for_Mobile_Frontend.gif (existing value) is not the same as http://jonrobson.me.uk/images/W.png [22:30:41] it's a gif for one! [22:30:47] i don't see why you need to update anything to 72px.. [22:31:00] the image is suppose to be bigger than 72px and resized in css [22:31:04] gives a better resolution [22:31:25] so what needs to happen is http://jonrobson.me.uk/images/W.png needs to be uploaded to wikimedia.org and linked to in the config file [22:31:27] MaxSem: ? [22:31:48] we already have it in SVG [22:32:02] can render whatever size thumbs as we want [22:37:30] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/mlQIDw [22:37:30] Commons-iOS/master 2e71aad Monte Hurd: Background concurrent image fetch w/dynamic priority q... [22:37:30] Commons-iOS/master 3be9b21 Brion Vibber: Merge remote-tracking branch 'monte/over500Uploads'... [22:37:57] jgonera: http://demosthenes.info/blog/343/Forcing-A-Consistent-Appearance-For-the-HTML5-Search-Input-Across-All-Browsers [22:38:29] MaxSem: so i'm confused - what are you doing right now?! are you updating the config? [22:40:10] https://gerrit.wikimedia.org/r/63081 [22:59:26] MaxSem: this was what i was trying to explain.. [22:59:35] they should be the same as the existing image which is 129px [22:59:40] jdlrobson: the image is suppose to be bigger than 72px and resized in css [23:01:20] bigger download for everyone just because of a few retina users? [23:01:39] also, why such weird factor? [23:02:15] MaxSem: microoptimisation! [23:02:46]