[00:00:08] kk; that data is currently cloistered over here in the fundraising area -- but whenever you need the number just ping me -- it's easy to pull it up [00:00:28] thx d00d [00:00:53] New patchset: Dr0ptp4kt; "Bug 44436 - add warning interstitials for non-whitelisted langs." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62942 [00:01:10] brion: broke it again by doing another fast scroll then quickly going to login page  [00:02:31] oh yay :D [00:03:07] breaking all the things! [00:04:25] yurik, i +1'd 63077. is there something else that doesn't already have a +1 you need me to take a look at? [00:05:50] yurik, i'm going to do a quick test of the revised code on 62942. i fear use of doubly negated booleans with the && operator, but i guess it *may* be the lesser of two evils, the second evil being double if-else branching. [00:06:18] yurik, hopefully the inline comments will aid. there is a usefulness to comments sometimes. [00:06:22] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/q/owner:%22Yurik+%253Cyurik%2540wikimedia.org%253E%22+project:operations/puppet,n,z [00:07:34] dr0ptp4kt, sorry, forgot to add status:open [00:09:10] yurik, iirc we need to actually keep the X-Carrier due to cache variance settings not being modified yet. once we the cache variance update is deployed into MF in production, then the X-Carrier header augmentation can be set to be removed 32 days later. no? [00:09:13] dr0ptp4kt, will review later tonight. one thing i see already -- don't make the lines so long - the diff doesn't show them well [00:09:43] dr0ptp4kt, I am still setting X-Carrier -- to be equal to X-CS - at the bottom [00:09:53] this way the VCL is much shorter and more managable [00:09:59] and we will remove it in a few months [00:10:11] (remove the copying of xcs to xcarrier) [00:11:15] yurik, which line number? [00:11:24] https://gerrit.wikimedia.org/r/#/c/62942/5/includes/PageRenderingHooks.php [00:11:30] see some of them wrap [00:11:38] comments can go on the next line, etc [00:12:00] i am really considering switching all code to use 4 spaces instead of tabs [00:12:07] yurik, for *your* change, not mine [00:12:51] yurik, which line number has the assignment you refer to in the vcl? [00:12:53] since there are so many issues with the gerrit. [00:13:03] https://gerrit.wikimedia.org/r/#/c/62867/1/templates/varnish/mobile-frontend.inc.vcl.erb line 500 [00:13:12] 500 -- of the right file [00:13:47] dr0ptp4kt, gtg, back in a few hours [00:14:17] oops [00:14:20] notice the bug :) [00:14:52] yurik, agreed the wackiness with text not nicely wrapping or just getting cut off in gerrit is a pain. i believe wmf convention is tabs instead of spaces, though, for better or worse. [00:14:56] yurik, which bug? [00:15:09] copying X-ID instead of X-CS [00:15:31] yurik, good think your message came though before i read that line fully :) [00:16:29] dr0ptp4kt, fixed, talk later [00:19:33] yurik, cool, added asher and mr. bergsma and faidon as approvers [00:42:21] New patchset: JGonera; "Refactor search input and watchlist buttons CSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63098 [00:46:09] New patchset: JGonera; "Refactor search input and watchlist buttons CSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63098 [03:43:42] New patchset: Yurik; "Bug 44436 - add warning interstitials for non-whitelisted langs." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62942 [03:44:52] New review: Yurik; "Adam, I rewrote a bit -- this is what I am thinking of as "good", so now its your turn to pick at my..." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62942 [03:46:33] dr0ptp4kt, ping [06:34:37] [01:34:13 AM] Hello all! On Android, wikivoyage.org redirects to www.m.wikivoyage.org which does not exist [11:52:48] New patchset: Zfilipin; "Refactoring: introduced URL module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63122 [11:52:50] New patchset: Zfilipin; "Fixed Watchlist tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63123 [12:00:17] New review: Zfilipin; "All tests pass for firefox+en.m.wikipedia.beta.wmflabs.org" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63123 [12:03:43] New review: Zfilipin; "The same for firefox+en.m.wikipedia.org" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63123 [12:16:08] New review: Zfilipin; "Still a couple of failures for android:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63123 [12:57:32] New review: Zfilipin; "Four failures for ipad and iphone:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63123 [13:54:33] MaxSem: Zuul now enforces jslint for mobilefrontend :-) [13:55:13] https://gerrit.wikimedia.org/r/#/c/62825/ // Jdlrobson [13:58:25] luckily, I don't have to write JS;) [16:49:29] dr0ptp4kt, around? [16:50:01] New review: Cmcmahon; "consistent use of URL module" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63122 [16:50:31] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63122 [16:52:59] New review: Cmcmahon; "fix mobile watchlist tests" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63123 [16:53:00] Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63123 [16:58:22] New review: awjrichards; "jenkins? you there?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [17:00:47] yurik, i'm here [17:03:00] dr0ptp4kt, hey! I did a "few" changes to your patch, couldyou review :))) [17:03:14] i'm not sure that's the best way obviously [17:03:27] but was thinking that it will be more readable and logical [17:03:45] dr0ptp4kt, I have to step away for a bit, will check in in an hour [17:03:56] yurik, sounds good [17:04:02] yurik, will review [17:11:54] ok somebody's got to tell google/lg that the glass back on the nexus 4 isn't a good idea. thing keeps slipping off of tables i set it on [17:12:50] >_< [17:13:19] I guess that's why the bumper raises it and is textured... [17:13:42] rubber baby smartphone bumpers [17:14:17] maxsem: http://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Special:Nearby_on_Wikivoyage.3F [17:15:46] hahaha [17:15:57] hey brion did you buy a surface pro? [17:16:03] Maryana, sehr gut [17:16:09] jcmish: naw i still just have the surface rt [17:16:27] can you test desktop on it okay? [17:16:28] maxsem, i don't think i got the explanation quite right, so feel free to correct me [17:16:32] or should I go with a pro? [17:20:42] New review: JGonera; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63098 [17:23:28] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62942 [17:24:28] jcmish: what do you need tested? [17:24:55] nothing in particular but I think I want to try getting the testing framework working on [17:25:10] a window machine and I thought I'd just bite the bullet and buy one [17:25:21] I don't wanna do it all in a VM [17:25:26] jcmish: ah that almost certainly won't run on the surface rt [17:25:30] if you're gonna get one get the pro [17:25:33] :( [17:25:37] that's what I thought [17:25:41] of course I'm cheap though :D [17:25:42] New review: awjrichards; "last chance, jenkins." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [17:25:50] yeah the arm version is just too limited in what you can do on the desktop [17:26:10] you can run the debug tools in IE, but you can't install any plugins or other desktop programs [17:26:17] so no way to control the automation probably [17:26:35] that's what I thought :D alright it was worth a shot [17:27:00] if you do end up using a VM, win8 runs very well in the latest Parallels on mac [17:27:28] yeah if the cheapness get to me I'm probably just going to set it up that way [17:29:00] it *is* fun to play with the touchscreen though :) [17:29:12] hahahaha [17:29:21] well and I don't have to go putz with a vm [17:29:29] install fruit ninja and angry birds [17:29:34] I can let my tests run here and then kick them off on another machine [17:29:39] my nephew's 2, he *loves* fruit ninja [17:29:44] so I think I'll bite the bullet [17:30:21] :) [17:30:42] i haven't bought a windows machine in 3 years :D [17:30:45] so really I can't complain [17:31:12] hey maxsem, are we currently monitoring calls to the geodata API from nearby? [17:31:30] if not, can we add a story for it? [17:31:59] ok i'm gonna head into the office, see y'all in a bit [17:32:36] Maryana, define monitoring [17:32:50] just tracking call volume over time [17:33:31] tfinc is interested in getting a baseline, so he can know whether migrating the wp apps to geodata will have a significant impact [17:34:10] Maryana, https://graphite.wikimedia.org/dashboard/temporary-26 [17:34:38] nice! thanks :) [17:34:43] tfinc ^ [17:36:41] MaxSem: what does each count correspond to? raw queries ? [17:37:14] yurik, for when you're back and you look at your scrollback: nice revision. makes it even cleaner. i +2'd it for merge into master. [17:37:23] list=geosearch queries per... eh... a unit of time:) [17:41:55] Maryana: where in the desktop interface will nearby go ? [17:42:38] i don't think anyone's really thought through where to put an actual link to it yet, but it'll be in special:nearby [17:42:58] sounds like a candidate for left-hand sidebar.. [17:43:05] but there's already so much clutter there [17:43:14] we'd probably need to start an RfC [17:56:16] dr0ptp4kt, good, glad you liked :) [17:56:32] dr0ptp4kt, but is there a good way to test? [17:57:25] that it performs the way you want [17:58:18] yeah, it's easy to test on apibeta. i verified it behaves as expected. i'm going to do one more chec. [17:58:20] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61989 [17:59:12] jgonera: https://gerrit.wikimedia.org/r/#/c/63061/ this was the patch set we need to merge before deployment [17:59:21] ^yurik [17:59:35] New review: awjrichards; "LGTM but would like a sharper JS eye to take a look." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/62981 [17:59:42] dr0ptp4kt, thx :) [18:00:18] yurik, that additional check was good. [18:01:23] dr0ptp4kt, ? [18:02:07] yurik, i said above "i'm going to do one more chec." <-- i was referring to performing that [sic: chec] [18:02:13] [sic: check] [18:02:24] yurik, i sometimes think my 'k' key is broken [18:02:55] ah, never mind, gotcha [18:03:26] ok. it makes it my really happy to see this going out across different platforms [18:04:02] jdlrobson, should I change the "nag" in copyvio's code? [18:08:02] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62981 [18:09:21] Maryana, Siebrand's comment: https://gerrit.wikimedia.org/r/#/c/62129/5/MobileFrontend.i18n.php [18:10:03] dr0ptp4kt, unsure of your email reply. what should go? [18:10:30] New review: awjrichards; "this still does not work for me; i see no watchlist star on nearby; console is showing mw.config.get..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/58825 [18:12:20] jgonera, arg. that's so long. [18:12:54] tfinc: just received update passport! that was fast! [18:13:05] yurik, which e-mail subject is this? [18:13:08] mhurd: woot! [18:13:09] Well... you can't assume that whatever people choose to replace "dos and dont's" with in other languages is going to be shorter ;) [18:13:21] i know, but english wikipedia is 80% of our traffic [18:13:38] I see, reply to Siebrand's comment then? ;) [18:13:57] will do. i'm meeting with vibha and may later today. i'll ask for their input. [18:15:18] New patchset: Jdlrobson; "Fix nearby / Move nearby overlays to separate module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63061 [18:15:18] New patchset: Jdlrobson; "Add refresh button to nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63149 [18:18:16] New patchset: Jdlrobson; "Fix nearby / Move nearby overlays to separate module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63061 [18:22:19] oh god, commenting in gerrit... [18:23:55] how do i save in inline comment? [18:24:07] i know there are like 5 more unintuitive steps after this [18:24:16] jgonera ^ [18:25:09] you need to "review" the commit [18:25:15] so you go back to change's main page [18:25:20] and look for the review button [18:25:31] and then submit a form without filling in anything [18:25:42] ahh, right [18:25:43] thank you [18:26:08] New review: Maryana; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [18:27:35] MaxSem, yurik, have you seen the thread about APIStrat on wikitech-l? [18:28:08] yep [18:28:10] jgonera, yep, i was thinking of replying to apply [18:28:21] big concern - if i will be in SF during that time [18:28:35] ok, just checking [18:28:41] hey! MobileFrontend end patch will now be blocked if jshint does not pass . [18:28:54] * MaxSem bites hashar [18:28:58] I made the change a few hours ago, I thought you might like the notice [18:28:59] :-D [18:29:18] MaxSem: blame jdlrobson who +1 ed the jshint voting :-] [18:29:21] the organizers would like to know if someone from us will participate because they'd like to give some list of speakers and organizations when they announce the conference [18:29:28] dinner time ttyl [18:29:37] it's a good thing hashar thanks :D [18:29:43] but if we don't decide on it now, we can still participate later [18:33:30] New review: Jdlrobson; "making minor tweaks" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/63149 [18:34:15] jgonera: $wgMobileFrontendLogo = 'http://jonrobson.me.uk/images/W.png'; [18:35:27] jgonera: https://gerrit.wikimedia.org/r/#/c/63081/ [18:40:37] New patchset: Yurik; "Zero config regular font size" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63155 [18:41:11] dr0ptp4kt, [18:41:19] https://gerrit.wikimedia.org/r/#/c/63155/ [18:42:25] dr0ptp4kt, also, could i grab api [18:50:08] dfoy, around? [18:50:18] yurik: yes [18:50:31] yurik: What's up? [18:50:39] dfoy, there are two items on trelo that appear duplicate [18:50:46] regarding buttom links [18:51:07] dfoy, the "figure out solution", and "fee warning..." [18:51:10] are they the same? [18:51:12] dr0ptp4kt, ^^- [18:51:36] yurik: they are 2 stages of work on the same issue [18:52:04] yurik: the short-term fix is to flag the charge for the privacy and terms of service pages [18:52:15] dfoy, a, yes, gotcha [18:52:34] yurik: long-term is to find a a place to get it in a location where it won't need extra warning / whitelisting [18:52:42] dfoy, sorry, was slow [18:53:06] yurik: np, it's not clear since they are independent tasks [18:53:08] New patchset: Jdlrobson; "Alpha: Add watchlist star to nearby view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58825 [18:53:09] This repository is temporarily unavailable. [18:53:09] The backend storage is temporarily offline. Usually this means the storage server is undergoing maintenance. Please contact support if the problem persists. [18:53:11] booooo [18:53:27] * yurik shoots the messenger [18:53:37] * brion links to https://status.github.com/ with his dying breath [18:56:40] New patchset: Jdlrobson; "Bug 47103: Prevent undefined photos being added to the page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62981 [18:57:00] also jgonera when you get a moment i could do with your brain for https://gerrit.wikimedia.org/r/#/c/63002/ [18:58:27] Maryana: i lost vibha is she near you? [18:58:55] also Maryana any idea why https://mingle.corp.wikimedia.org/projects/mobile/cards/729 made it into this iteration? seems super low priority.. [18:59:05] the one below it is much more important.. [19:00:10] one below? [19:00:54] i'm in a mtg in r31, jdlrobson, but i assume vibha's upstairs [19:01:16] Maryana: on story wall #754 is lower than #729 which makes no sense to me [19:01:26] i don't think #729 should have even got into the iteration ;-) [19:01:40] i'm going to move back to in analysis [19:01:47] please don't [19:01:55] i'd really like to have consistent button design [19:02:10] it just makes things that aren't consistent look broken [19:02:21] like the submit button on settings [19:02:56] jdlrobson ^ [19:03:02] i reverted your move [19:03:10] we can talk later about this if you want [19:03:12] who's at teh hackathon meeting? [19:03:18] Maryana: that's a different bug.. [19:03:26] #728 [19:03:51] #729 is far more complicated - it means using core's button changes which are currently not compatible [19:04:04] ok, can we talk about this later? [19:06:26] Maryana: sure [19:06:35] k, i'll come grab you [19:26:13] New patchset: JGonera; "Story 483: Show intermediate copyvio/scope message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [19:38:07] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63061 [19:44:58] well, the hackathon hangout was a flop :( [19:47:10] New patchset: Jdlrobson; "Style the more link in watchlist so it doesn't look so ugly" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63168 [19:47:11] New patchset: Jdlrobson; "Story 757: Add upload photo CTA to watchlist view as well" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63169 [19:49:32] ugh galaxy tab 10.1 is the slowest tablet evar [19:49:46] i'll go back to testing on my nexus7 :) [19:49:49] too bad it doesn't have hdmi out [19:50:58] brion: quick question when you have a sec [19:51:05] sure [19:51:56] New patchset: Jdlrobson; "Fix nearby / Move nearby overlays to separate module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63061 [19:54:06] dr0ptp4kt, could you send me the info where you found that footer modification [19:59:34] New patchset: Jdlrobson; "Fix nearby / Move nearby overlays to separate module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63061 [20:05:50] New patchset: Jdlrobson; "Fix nearby / Move nearby overlays to separate module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63061 [20:09:51] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63061 [20:11:43] argg people have started sharing google quick view wikipedia links :-S [20:12:09] noo [20:14:01] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62981 [20:16:25] awjr: https://twitter.com/edsu/status/332816368674164737 [20:16:47] * awjr looks [20:19:17] you can't compare those load times apples-to-apples since quick view loads less of the article than the mobile site [20:22:27] i guess the only real issue i can think of with quick view is depressing contributions [20:24:24] i wonder what their criteria is for quickview as well; not all articles seem to get it (eg googling 'san francisco' doesn't return a result with quick view) [20:27:55] there's something weird about how they're caching the page too [20:28:48] awjr, ops haven't replied about caching :( [20:28:51] for instance, the footer is togglable (and toggled closed by default) on the articles i've looked at in quickview (even ones with recent last modified timestamps - oh, and they're still displaying 'last modified' :p ) [20:30:37] i wonder how they're doing this; tfinc contacted them last month and they reported that their 'latency is currently an hour on Wikipedia' (i dont really know what they mean by that but presumably they dont locally cache article content for more than hour without revalidating) [20:31:00] yurik: yeah it can sometimes take time to get a response; bugging people about it in person or in #wikimedia-operations can help [20:31:20] awjr, there is a problem with bugging in person... [20:31:30] i guess that's why we have dr0ptp4kt for ;) [20:32:39] exactly :) [20:39:47] yay, github repo for android is back online [20:57:33] New review: awjrichards; "According to story 757 this should happen in beta only; otherwise looks good." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63169 [21:03:34] New patchset: awjrichards; "Story 757: Beta: Add upload photo CTA to watchlist view as well" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63169 [21:08:04] awjr: need something from me ? [21:08:50] if so please leave a message after the beep for i need to get lunch *beep* [21:09:53] :p [21:09:56] im good thanks tfinc [21:11:22] jdlrobson: i updated https://gerrit.wikimedia.org/r/63169; if it looks ok feel free to merge [21:12:26] New review: awjrichards; "I updated this to be for beta only; if it looks good to you @jdlrobson, feel free to merge." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/63169 [21:12:55] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63168 [21:12:59] yay jenkins is alive again [21:16:16] jdlrobson: am i understanding correctly that https://gerrit.wikimedia.org/r/#/c/58825/8 should work on my local wiki even if my nearby endpoint is enwiki? [21:24:27] awjr: now it should - but only if you copy the article [21:24:34] ie. click on article in list of nearby and edit page [21:24:57] oh i think i understand, lemme try [21:25:32] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63169 [21:25:41] hmm page preview spins forever [21:25:51] but i can do it manually [21:26:23] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62643 [21:26:30] yeah seems to work, jdlrobson [21:26:42] awjr: page previews bug was fixed by https://gerrit.wikimedia.org/r/#/c/63061/ [21:26:43] but tapping the watchlist star just spins forever [21:27:08] (nb im not logged in) [21:27:30] if im logged in it seems to work [21:27:58] New review: JGonera; "Changing to +1 after discussing with Jon." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/63002 [21:29:57] New review: awjrichards; "Seems to work if I'm logged in. If I'm not logged in when I tap the star rom the nearby list, howeve..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: -1; - https://gerrit.wikimedia.org/r/58825 [21:32:30] New patchset: Jdlrobson; "Add refresh button to nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63149 [21:38:44] ok back. thanks awjr. i was starving. left over lunch pizza wasn't cutting it [21:39:05] did you have a question/comment/etc on quick view ? [21:39:48] i have a few tfinc [21:40:06] though i'd like to take some time to formulate them thoughtfuly before conveying them to google [21:40:12] ok [21:40:27] their pretty responsive. so just let me know. [21:40:32] i've heard some other rumblings here in IRC about it, and i suspect that others have questions/concerns too that would be good to get addressed (jdlrobson, Maryana, MaxSem, jgonera?) [21:40:57] tfinc do you htink it would be possible to have a mtg with them? i imagine responses to our questions may beget more questions [21:41:04] plus it would be nice to be able to dialog [21:41:21] are "they" people responsible for quick view? [21:41:33] yes [21:41:34] i'd like to answer those first if i can. they've already done and intro with me. then an intro with howie and me. [21:41:43] ok [21:42:18] but if we have to do a third intro then either i or howie are doing something wrong in giving you guys info [21:42:35] so jdlrobson just saw today that some people use the quick view links to share wikipedia articles and they don't even work, they just take you to the Google search results [21:42:38] jdlrobson: its always been the product and devs on the quick view project [21:42:54] their based mostly in japan [21:43:22] tfinc i'll put together my qs for them before the eod [21:43:27] ok [21:43:45] I'm either missing some IRC messages or didn't hear/see the beginning of the conversation [21:43:52] maybe the easiest thing would be to schedule a monthly with them so that we could introduce any new people [21:44:00] my main concern is they are taking away possible mobile editors and effecting our brand - if we push new styling changes will they surface on quick view? [21:44:21] based on what i was seeing today, the answer to your second question is no [21:44:31] jdlrobson: quick view wont update unless we tell them to [21:44:49] jdlrobson: their happy to add anything we want to it [21:44:55] but it wouldn't be automatic [21:45:07] my main worry is about effectiveness of our CTAs [21:45:27] tfinc, jdlrobson, awjr maybe we should ask them what was the main motivation for creating quick view. maybe our web site is loading too slow and we could do something about it? [21:45:39] i mostly want to understand how they're doing what they're doing and what their caching strategy is; so far all i know is their 'latency is currently an hour on Wikipedia' but i dont really understand what that means or the implications of it [21:46:13] 'latency is currently an hour on Wikipedia'? [21:46:29] awjr: sure. we can do a deeper tech dive as the next round. just put together the thoughts so that we can send them in advance [21:46:37] jgonera: from email subject 'Quick View for Wikipedia results in mobile Google search' [21:47:03] jgonera: they picked us because were at the top of their search results page and were cc by sa [21:47:11] their first pass was only on free content [21:47:26] did we ever find out how exactly it is effecting our traffic? [21:47:36] i'd be interested in knowing how many people click through [21:47:47] jdlrobson: they send us weekly quick view stats of the top 100 pages [21:47:59] those started last week [21:48:01] tfinc: where do these go - i've never seen them [21:48:14] right now to howie and me. we asked for them two weeks ago [21:48:36] tfinc: but surely our analytics team by now can tell how much our traffic dropped off due to this announcement? [21:49:29] we should poke Diederik about this again. actually, he asked about the exact date Google launched this feature [21:49:30] jdlrobson: sure. just look at google referrer traffic drop. [21:49:47] hm [21:50:09] but where do i look for this? i assume on stat1 somewhere? [21:50:34] jdlrobson: thats a good question for diederik [21:50:48] i'd say to mine the sampled 1000 log [21:50:51] but he would know best [22:03:28] brion: nice job going to town on jareds comments [22:03:36] yeah :D [22:03:45] i kinda used up the margin ;) [22:03:54] generally if i didn't comment, i agree :) [22:03:59] and if i did comment, i have some vague issue :) [22:04:05] or agree. [22:04:10] brion: what's going to be fun for me is to start rolling these up [22:04:15] lots of good things to work on [22:04:38] cards, wonderful cards [22:05:58] awjr: how hard would it be to rig bingle to trello ? https://trello.com/docs/ [22:06:44] * awjr looks [22:07:27] oo there's already a python wrapper for the trello API [22:09:22] hmm it doesn't look particularly mature, but it looks like you should be able to use it to add cards to al ist [22:09:29] * a list [22:09:43] i guess a challenge for you guys would be that you use a new board for each sprint [22:09:57] where would you want bugzilla bug cards to go, tfinc? [22:10:24] awjr: https://bugzilla.wikimedia.org/buglist.cgi?list_id=200916&resolution=---&resolution=LATER&resolution=DUPLICATE&query_format=advanced&component=General&product=Commons%20App [22:10:32] err [22:10:46] https://trello.com/board/mobile-app-backlog/517b115c243fd8d361000faa [22:11:11] although that means it wouldn't show up in the current spint [22:11:23] yeah [22:11:26] awjr: do you guys create it into the backlog or the current sprint ? [22:11:29] but at least you'd get em into your backlog i guess [22:11:49] tfinc they initially get created in current sprint with a status of 'in analysis', that way it's super obvious when a bug comes in [22:11:57] it will show up on the current story wall [22:12:14] then, we've been triaging and either dealing with it immediately, next sprint, or put it in the backlog [22:12:28] lets say backlog for now [22:12:42] ideally it would be current sprint [22:12:55] it looks like it *should* be pretty straightfroward but i'd have to spend some time playing with trello a bit [22:12:57] but we'd need a perm trello board for that [22:13:02] awjr: let me know [22:13:02] yeah i think so, tfinc [22:13:17] or some other way to determine what the current board is [22:13:56] tfinc: so, once i get through some more code review today i was going to spend an hour or two on improving how bingle gets bugs from bugzilla - i could either go down that road, or leave it as is now and explore trello integration [22:14:07] and then worry about improving how it interfaces with bugzilla later [22:14:39] tfinc i'll play with trello integration first, that's probably of more value [22:14:45] awjr: ok [22:15:31] might need to change name to bingello tho [22:17:47] New patchset: Jdlrobson; "Add refresh button to nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63149 [22:18:04] awjr: he. i like it as bingle as matter what the end point is [22:18:13] awjr can you call it gerbingello and add gerrit integration? [22:18:13] no* [22:18:21] lol [22:18:28] * jdlrobson is serious [22:18:56] how would bingle interact with gerrit/ [22:19:02] i mean, in what way? [22:19:19] i'd like to tackle mingle/gerrit integration once bingle's a little more mature [22:19:55] but i've been thinking of that as separate from bingle [22:20:15] awjr: when a commit comes in with 'story' or 'bug' in the commit heading it moves it to awaiting final code review. when it gets merged it goes to ready for testing [22:20:30] jdlrobson: but what if a story has multiple commits? [22:20:43] or bug, for that matter [22:21:09] jdlrobson: but yeah, that's kinda what i was thinking too; but i think that should happen separately from bingle [22:21:38] but i will likely use the same library i've been putting together for interfacing with mingle [22:21:45] awjr: the last one implements the story [22:21:58] we should get in the habit of putting story X only in commit heading for a commit that finishes the story [22:22:16] if some pre work is happening it might reference in the commit summary but not the heading [22:22:16] t [22:22:26] that's what i do anyway.. would be good to encourage consistency [22:22:30] interesting; but what if you *think* you've made the last commit then realize that no, you have to make another? [22:22:33] plus it would have a really cool name - gerbingello [22:22:39] lol [22:22:43] that is almost reason enough to do it. [22:22:46] awjr: shit happens - manual labour comes in again [22:23:27] hehe yeah [22:23:46] like i said, once ig et the bugzilla integration stuff taken care of, gerrit is next (unless someone else wants to take it on before i get to it) [22:24:26] i think they'll need to be separate pieces of software though anyway; one polls bugzilla and one should take an action once something comes into gerrit [22:26:12] New patchset: Jdlrobson; "Alpha: Add watchlist star to nearby view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58825 [22:26:40] awjr: its too bad that bugzilla/trello don't have post action hooks like github does [22:27:00] tfinc im hoping gerrit does (i *think* it does) [22:27:17] tfinc also, bugzilla might, but honestly that was a rabbit hole i wasn't excited about going down [22:27:55] i figured it would take much longer to get something working with bugzilla if that was the direction i went in; mostly i just wanted to get bugs automatically posting to mingle as fast as possible (hence current limitations) [22:33:54] brion: no more lockup :) [22:34:04] woohoo [22:34:56] New review: awjrichards; "@jdlrobson in reply to your reply to my comment:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63002 [22:37:16] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63003 [22:40:05] New review: awjrichards; "it is a relief to see the non-JS go button fixed, that has been annoying me when testing! LGTM, woul..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/63098 [22:42:47] New review: awjrichards; "w00t!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/58825 [22:43:23] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/58825 [22:45:39] [android-commons] brion opened pull request #16: Retry and delete buttons for failed items (master...delete-failed) http://git.io/EvX3rg [22:46:34] [android-commons] brion pushed 6 new commits to master: http://git.io/fqtuCQ [22:46:34] android-commons/master d7ea804 Brion Vibber: Add menu items for 'retry' and 'abort' on detail view [22:46:34] android-commons/master 143fc30 Brion Vibber: wip [22:46:34] android-commons/master cf86dc9 Brion Vibber: Click on failed item now shows detail view... [22:47:10] Project Android-Commons (mobile) - Nightly builds build #168: SUCCESS in 48 sec: https://integration.wikimedia.org/ci/job/Android-Commons%20(mobile)%20-%20Nightly%20builds/168/ [22:47:11] * Brion VIBBER: Add menu items for 'retry' and 'abort' on detail view [22:47:11] * Brion VIBBER: wip [22:47:12] * Brion VIBBER: Click on failed item now shows detail view [22:47:12] * Brion VIBBER: Update menu after rotation on detail view [22:47:13] * Brion VIBBER: Make delete button work [22:47:59] [Commons-iOS] brion pushed 3 new commits to master: http://git.io/gxAmWg [22:47:59] Commons-iOS/master 890d9f1 Monte Hurd: Bug fix - fast scroll on large image set then quick debug toggle... [22:47:59] Commons-iOS/master d161a6a Monte Hurd: Fixed comment typo [22:47:59] Commons-iOS/master 2d97235 Monte Hurd: Fixed fast scroll through big image set then back out to login page... [22:49:08] brion: did you get enough commits in to do a test flight build? [22:49:09] brion: just about to push the lockup patch [22:49:18] tfinc: one more quick merge :) [22:49:21] brion: i want to see if before i start creating cards with jareds feedback [22:49:27] ok [22:49:29] excellent [22:50:17] awjr: on subject of wgMFLeadPhotoUploadCssSelector [22:50:30] jdlrobson: see my pm ? [22:50:42] tfinc: now i have will take a look in a bit [22:50:58] awjr there are infinite permutations of it that it would be impossible to test various behavior it supports [22:51:20] brion: pull req sent [22:51:23] whee [22:51:26] [Commons-iOS] montehurd opened pull request #59: Fixed login lockup when no net connection (master...loginLockup) http://git.io/lUllbw [22:51:39] jdlrobson: i guess what's really tripping me up is the documentation around that variable, because it says (paraphrasing) "set to '*' to turn of feature" [22:52:44] but it doesn't really turn off the feature, does it? you could apparently set that to practically anything and have the feature 'turned off' [22:53:00] but the feature doesn't really get turned off, it just doesn't find the set criteria to be exposed [22:54:40] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/c5lEKw [22:54:40] Commons-iOS/master 1481fb4 Monte Hurd: Fixed login lockup when no net connection [22:54:40] Commons-iOS/master 93928b8 Brion Vibber: Merge pull request #59 from montehurd/loginLockup... [22:56:34] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/nudzqA [22:56:34] Commons-iOS/master f20f526 Brion Vibber: Xcode wants to move these files. Fine, whatever. [22:56:34] Commons-iOS/master 9a31276 Brion Vibber: Bump version to 1.0.3 [22:58:30] awjr: so the main reason i made it configurable is in case we have to deal with "The Return of Village Pump" [22:58:38] and need to quickly revert back to what it was previously [22:58:39] lol what does tha tmean? [22:58:59] well if people are unhappy with photos begin uploaded outside info boxes we need a flexible way to deal with that [22:59:11] oh i see [22:59:16] tfinc: i'm wondering if the double refresh issue could be thought of as a non-bug [22:59:18] i maybe say too much [22:59:19] yeah, i dont htink there's any problem with making that configurable [22:59:29] mhurd: hmm ? [22:59:36] awjr: i could just say "A css selector which is used to test whether to prompt the user photo uploads on the current page." [22:59:36] it's just the comment about 'turning it off' that i'm hung up on [22:59:44] perfect [22:59:51] tfinc: if you toggle and no connection is available it's good to know at that point [22:59:54] awjr: ok ill fix that up now so you can merge [23:00:02] jdlrobson: what happens if that's set to ''? [23:00:06] tfinc: and also when you go to my uploads is good to know [23:00:10] could change [23:00:20] between pages [23:00:31] yurik: during our 1:1 yesterday i forgot to mention that i haven't been able to find time to do the product rounds for the new API. your going to have to run that without me. [23:00:50] awjr: slightly confusingly it will always show as $( '' ) always equates to an empty list ;) [23:02:48] New patchset: Jdlrobson; "Story 578: Allow photo uploads on pages with infoboxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [23:02:56] cool will look in a big jdlrobson [23:02:58] ^ awjr how about this - i explained it a bit better and added a warning [23:03:00] thanks :) [23:04:23] tfinc: testflight pushed [23:19:36] jdlrobson: the docblock looks beter, thanks. what about updating that method in SkinMinerva? [23:19:50] or do you disagree with the approach i was suggesting? [23:24:16] awjr: ahh didn't see you commented thee [23:24:30] i'll change that too sorry [23:27:49] oh no big deal [23:29:04] tfinc would you want to create a separate list in the backlog 'bugs' or just stick bugs into android/ios lists? [23:29:04] New patchset: Dr0ptp4kt; "Enforce the JSON configuration page for each carrier's "enabled" field." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63242 [23:30:03] New patchset: Jdlrobson; "Story 578: Allow photo uploads on pages with infoboxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [23:30:50] lets try android/ios list [23:31:25] New patchset: Jdlrobson; "Handle all the Node.js dependencies the same way" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60601 [23:35:52] New review: Jdlrobson; "My node_modules directory was created as a sudo user" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60601 [23:35:52] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/60601 [23:40:20] New patchset: Jdlrobson; "Bug 48310: CC by SA not SA by CC" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63245 [23:56:56] tfinc looks like trello will be a little more challenging since we'll have to authenticate via oauth [23:57:02] [Commons-iOS] montehurd opened pull request #60: Suppress "Refresh failed" alert message for debug mode toggle (master...doubleRefresh) http://git.io/zQGNtw [23:57:28] so it will require some human intervention at some point but im currently investigating how long you can have an oauth token last for [23:57:49] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412