[07:57:36] MaxSem, around? [07:58:19] yep [07:59:21] wasup, yurik [07:59:25] MaxSem, good morning. Do you know if i can use $_SERVER["SERVER_NAME"] ? [07:59:34] or is there some magic rewrite going on [07:59:53] i need to find out if its en.zero.* or .m. or ... [08:00:02] the mobile site gets rewritten to desktop [08:00:18] and i don't really understand why we are currently relying on varnish to set the X-SUBDOMAIN [08:00:37] mobile gets distinguised from desktop by X-Device, but there are no more details [08:00:57] thus, X-Subdomain [08:01:01] MaxSem, that explains why the X-SUBdomain [08:01:23] ok, will live with that then [08:01:25] thx [08:01:26] ! [08:03:28] MaxSem, another silly question (i have accumulated tons of them over the weekend, but will ask just a few :)) -- wgZeroDisableImages -- is it possible for it to be non 1? [08:04:10] i was looking through site settings, and it seems like its qust a copy [08:05:31] LOLOLOLO [08:05:51] wat, register_globals in my codebazez? [08:06:28] the answer is no idea [08:06:57] sigh. the xkcd's WTF code review moment [08:08:51] gtg [08:08:55] cya [08:09:12] np ,thx [08:36:42] New patchset: Yurik; "Removed $wgZeroDisableImages dependency" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63420 [10:00:14] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63426 [14:28:43] * edsu waves [14:29:18] i was wondering if anyone had any insight into why a geodata api call on en doesn't seem to work on de, by just substituting the en for de in the URL [14:29:39] for example: http://en.wikipedia.org/w/api.php?action=query&prop=info%7Ccoordinates&generator=geosearch&ggsradius=5000&ggscoord=38.8951%7C-77.0363&ggslimit=250&format=json [14:30:02] the lat/lon in that example is berlin, so there ought to be results from de right? [14:30:19] am i doing something obviously wrong? [14:30:30] hm [14:30:49] it's also possible de.wikipedia just hasn't started using the coordinates storage thingy [14:30:54] which would be annoying :) [14:31:07] is there a good place for me to ask about de? [14:31:26] same is true of fr btw [14:31:40] i haven't tried any others [14:32:11] oh sorry that example wasn't berlin, it was dc [14:32:22] heh [14:32:26] still there should be some entries :) [14:32:58] yeah :) here's berlin fwiw http://en.wikipedia.org/w/api.php?action=query&prop=info%7Ccoordinates&generator=geosearch&ggsradius=5000&ggscoord=52.516667%7C13.383333&ggslimit=250&format=json [14:33:50] yeah, same [14:34:04] i'm not having any luck decyphering the german templates :) [14:34:18] heh [14:34:32] so you might just ask on their village pump equivalent if anybody knows how the geo coordinate templates work and if they can update them to use {{#coordinates}} [14:35:16] ok [15:15:09] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62129 [16:25:45] yurik, poke mark [16:34:13] MaxSem, poked. But why oh why does it take over a week to merge a few extra IP ranges is beyond me [16:34:14] that's ops [16:34:14] and yes, this is dysfunctional [16:34:14] even though they're overstretched [16:34:18] true, they are overstretched, but clicking +2 for a tiny obvious patch should take hours at most if there is a system of queues of sorts [17:55:09] hey jcmish, i'm looking at the story wall, and it looks like there's only one user-facing thing to review (footer change). do you wanna skip this week's qa/design checkin and wait till next week when there'll be a lot more designy stuff to look over? [17:56:48] nah looks like it will be light this week [17:56:48] opps yes :D [17:56:48] not no :D [17:57:58] Maryana, have you seen Adam today? [17:58:11] yurik: yes, he's at his desk [17:59:13] Maryana, oh, could you poke him to get on irc pls :) [18:00:04] Maryana: ^ we can wait [18:00:28] yurik: he says he is, but there appears to be a lot of netsplitting going on [18:00:34] brion: question about share feature when you have a sec [18:00:46] ask awayyyy [18:00:48] jcmish, ok, cool - can you send out a cancel email plz? [18:01:37] awjr: MaxSem: login.wikimedia == sul2 http://www.mediawiki.org/wiki/Auth_systems/SUL2 [18:01:54] awjr: MaxSem : chris streip is the lead and can answer any questions [18:02:02] cool, thanks tfinc [18:04:21] dr0ptp4kt, yei, you are here! [18:04:36] yurik, sounds like there have been netsplits [18:05:05] yeah, we should start hosting our own IRC servers :) [18:05:14] is anyone going to google i/o? [18:06:05] dr0ptp4kt, could you review the changes - i am working on majorly cleaning up the banner rendering code, and removing outside inputs like wgDisableIMage [18:06:12] awjr, I think tfinc will [18:06:25] awjr: I am [18:06:29] cool [18:06:44] stay tuned for my google glasses youtube feed j/k [18:07:10] yurik, right now? or toward the end of the day? [18:07:27] yurik, that is to say, would like the reviews right now, or toward the end of the day? [18:07:45] dr0ptp4kt, well, i was hoping to release both on wednesday, so earlier is better :))) [18:08:00] dr0ptp4kt, btw, could you elaborate on the option changes you made? [18:08:05] yurik, okay, will look at starting in 5 minutes or so [18:08:21] i incorporated the "enabled" in the refactoring, but didn't understand the options change [18:08:32] ok [18:08:37] thx :) [18:09:37] lol tfinc; maybe they'll give out google glasses this yaer [18:09:45] awjr: i think there is a high chance of it [18:09:53] that would be pretty amazing [18:09:58] and i bet some people bought their ticket banking on that [18:14:56] YuviPanda: your email just made me very happy [18:14:57] New review: Dr0ptp4kt; "No harm here." [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 2; - https://gerrit.wikimedia.org/r/62950 [18:15:20] New review: Yurik; "self merging maintenance scripts" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 2; - https://gerrit.wikimedia.org/r/62951 [18:16:36] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62950 [18:16:40] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/62951 [18:17:03] New review: Dr0ptp4kt; "No harm here." [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 2; - https://gerrit.wikimedia.org/r/63155 [18:17:57] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63155 [18:19:02] jdlrobson: re https://gerrit.wikimedia.org/r/#/c/63002/3, is $wgMFLeadPhotoUploadCssSelector something that should be used by both desktop and mobile skins? [18:20:24] awjr: all our js should work on desktop or should one day work on desktop so yes. At moment it should be used by both desktop and mobile skins of Minerva [18:22:07] yurik, the $options[] change is going to be for re-writing the footer links in MF and the skinning system. was going to split that out to a separate change. but will do the review of these two last substantial changes before returning back to that. [18:22:42] cool, thanks jdlrobson [18:29:58] awjr: any issues with that patch set then? [18:30:09] jdlrobson: nothing major that i see but i am making some small changes [18:30:25] also awjr jgonera could really do with https://gerrit.wikimedia.org/r/#/c/63003/ being merged - it's hard to add config variables in code at the moment knowing they will need to be moved in future :) [18:31:21] although that said if https://gerrit.wikimedia.org/r/#/c/63002/3/includes/skins/SkinMinerva.php gets merged i'm good for time being :) [18:36:58] jdlrobson, can you get designers' input on https://gerrit.wikimedia.org/r/#/c/63081/ ? [18:37:15] including an explanation of resize ratio [18:37:28] Change abandoned: Dr0ptp4kt; "Yurik took this one on in further ZRMA refactoring." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63242 [18:42:34] MaxSem: so my main issue is not the resizing but the fact you've removed the whitespace above which drastically changes the appearance and drastically degraded quality of the image (try yourself comparing existing login page with login page with your new image) - I don't want to waste Vibha's time at the moment on such a trivial issue as she is super busy with Echo stuff. [18:43:04] New patchset: awjrichards; "Story 578: Allow photo uploads on pages with infoboxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [18:44:15] New patchset: awjrichards; "Story 578: Allow photo uploads on pages with infoboxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [18:44:44] jdlrobson, MaxSem if that the changes i made to ^ look ok to you, i think it's fine to merge [18:46:26] New patchset: Jdlrobson; "Story 483: Show intermediate copyvio/scope message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [18:46:28] jdlrobson, okay. but the CSS should be able to handle non-square images - does it? [18:47:46] New review: Jdlrobson; "Looks good to me. Made a few tweaks which I oked with Juliusz in person." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62129 [18:47:46] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62129 [18:48:22] New review: awjrichards; "If folks are OK with my changes in patchset 5, this should be good to merge." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/63002 [18:48:59] awjr: so I don't really see the need for what you've done.. [18:49:07] why would we ever need to use setSkinConfigVariable ? [18:49:29] It seems pointless [18:49:50] to make it possible to set skin config vars from inheriting classes of SkinMinerva [18:49:54] Why not just use $out->addJsConfigVars then? [18:50:00] $out->addJsConfigVars('foo', 'bar') [18:50:13] i was trying to avoid this mess by just having a catch all function [18:50:21] oh [18:50:23] this is premature optimisation [18:50:25] :) [18:50:30] actually it's not an optimization then [18:50:38] i didnt know addJsConfigVars was a Thing [18:50:49] awjr: if you look at https://gerrit.wikimedia.org/r/#/c/63003/1/includes/skins/SkinMinerva.php [18:50:51] rather, addJsConfigVar [18:51:24] oh, i missed your response [18:51:54] i wanted to avoid lots of calls to $out->addJsConfigVars [18:51:58] inline responses to comments get eaten up by new patchsets [18:52:03] awjr: i know :( [18:52:04] that makes sense jdlrobson - one sec [18:52:46] MaxSem: the meta logo is low priority for me right now - i really think we are bike shedding at this point and should just leave it as it was - this is too expensive a conversation for something so trivial [18:53:27] so getSkinConfigVariables() is intended to always be Minerva-specific [18:53:31] jdlrobson, then we should revert it from MF cuz not all logos are square [18:53:47] I give up on W though:) [18:54:01] jdlrobson: can we call the method getMinervaConfigVariables() then, since otherwise it sounds like it's supposed to be a generic method [18:54:18] awjr: why add Minerva? It's in the MinervaSkin callss.. [18:54:19] *class [18:54:40] personal preference; getSkinConfigVariables() sounds like it's supposed to be generic [18:54:48] MaxSem: it should look fine as a square, I just don't want Wikipedia's login page to look different then it was [18:54:50] but, bikeshed1 [18:55:13] awjr: in theory a getSkinConfigVariables might be useful to upstream [18:55:17] jdlrobson, eh - "fine as a square"? [18:55:20] the existing mediawiki skin code is pretty messy so i wouldn't be surprised [18:56:13] jdlrobson: sure, but only by overloading it; it's not particularly reusable as-is [18:56:15] square/rectangle - any icon will look OK on the login page but the fact is the icon on the login page in the existing deployed code is not square so should remain not square [18:56:55] awjr: i call bike shed at this point - there might be opportunities to make it reusable but we should investigate when we have that need/time [18:56:56] anyway i dont really care; my changes are silly given $out->addJsConfigVar() so im fine to merge patchset 4 [18:57:01] totes [18:57:09] awjr: perfect. :) can you revert to 4 and merge? [18:57:11] yup [18:57:54] New patchset: awjrichards; "Story 578: Allow photo uploads on pages with infoboxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [18:58:12] whoops [18:59:11] New patchset: awjrichards; "Story 578: Allow photo uploads on pages with infoboxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [19:00:07] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63484 [19:02:02] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63002 [19:07:28] dr0ptp4kt, when you have a sec (no rush), could you run your script for the updated carrier's IPs in this patch-- https://gerrit.wikimedia.org/r/#/c/63500/ [19:08:38] New patchset: awjrichards; "Merge "Story 578: Allow photo uploads on pages with infoboxes"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63501 [19:09:02] der [19:09:17] New patchset: Yurik; "Maintenance scripts - optimize the VCL file's CIDR" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63502 [19:09:33] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63501 [19:14:06] New patchset: awjrichards; "Bug 44133: Cleanup how we do config" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63003 [19:16:03] yurik, i ran the script for apibeta. would you please qc and then let me know if it's okay to do the same for metaprod? [19:17:44] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63003 [19:23:09] New review: Yurik; "selfmerging maintenance scripts" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 2; - https://gerrit.wikimedia.org/r/63502 [19:23:36] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63502 [19:28:29] jgonera: is this still on your radar? https://gerrit.wikimedia.org/r/#/c/62166/ [19:28:38] (https://mingle.corp.wikimedia.org/projects/mobile/cards/728) [19:29:17] dr0ptp4kt, thx, checking [19:31:00] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63098 [19:47:57] dr0ptp4kt, Beeline name has changed [19:48:10] dr0ptp4kt, 250-99 [19:48:25] dr0ptp4kt, and what is this new value 999-99? looks wrong [20:09:46] New patchset: Jdlrobson; "Follow up to I3ae653ac2777e19843182b420d33cd8f3420fa29" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63561 [20:12:58] awjr_lunch: https://gerrit.wikimedia.org/r/#/c/63003/2/includes/skins/SkinMobileBase.php - so you want me to rename all the existing variables? Is that not dangerous? [20:14:04] ahh wait a minute i see what you mean - just $wgStopMobileRedirectCookie [20:16:34] yurik, ok, will update that to Beeline manually in apibeta and, right after i do this next run against metaprod, metaprod. 999-99 was just for illustrative purposes. [20:16:58] awjr_lunch, yes, working on it now [20:18:36] New patchset: Jdlrobson; "Promote transitions/transforms/animations to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63562 [20:20:16] yurik, i updated metaprod, and updated name[en] to Beeline for 250-99, which i also did on apibeta [20:21:57] jdlrobson: no, i dont think we should rename all variables now but just dont introduce new ones following that pattern [20:22:12] awjr_lunch: i'm introducing new variables ? o_O [20:22:52] oh, i see, wgUseFormatCookie was being used previously [20:23:20] i'm confused i might be.. but i can't remember [20:23:33] i dont think you are, it looks like you just moved some logic around [20:23:56] maybe $wgStopMobileRedirectCookie actually [20:24:33] actually no.. just moving stuff around [20:24:44] yeah - it would be nice to clean those up to not use the 'wg' prefix if it's trivial to do [20:25:11] i think it's something we can do incrementally [20:25:34] but if you're nervous about breaking stuff we can hold off and clean it all up wholesale at some point in the future [20:25:57] i'd rather cleanup later.. [20:26:05] New patchset: Jdlrobson; "Bug 44133: Cleanup how we do config" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63003 [20:26:16] i've fixed MaxSem's minor complaint (getSkinName() ) which btw is a horribly named function :) [20:26:39] no problem jdlrobson; sorry about that, i first thought you were adding those var names :p [20:26:44] * awjr_lunch goes back to lunch [20:26:53] no worries [20:28:11] dr0ptp4kt, awesome, thanks! [20:28:38] dr0ptp4kt, do you have any questions re refactoring? [20:29:08] yurik, maybe one, but i'm going to run it on apibeta first. [20:30:01] dr0ptp4kt, i think i already deployed it tehre [20:30:34] dr0ptp4kt, but feel free to checkout any version you need there [20:32:42] New patchset: Jdlrobson; "Run make less" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63567 [20:32:44] New patchset: Jdlrobson; "Bug 48352: Make dt bold" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63568 [20:32:53] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63567 [20:32:55] [Commons-iOS] montehurd opened pull request #64: Details page sharing support (master...detailsPageShare) http://git.io/CE_l1A [20:33:06] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63568 [20:33:25] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/hKOkeg [20:33:25] Commons-iOS/master de83bbe Monte Hurd: Suppress "Refresh failed" alert message for debug mode toggle... [20:33:25] Commons-iOS/master b8919db Brion Vibber: Merge pull request #60 from montehurd/doubleRefresh... [20:37:53] New review: Dr0ptp4kt; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -1; - https://gerrit.wikimedia.org/r/63353 [20:38:12] ^yurik, i think it just needs one tweak. see the comment in PageRenderingHooks.php. [20:38:20] dr0ptp4kt, checking [20:40:06] dr0ptp4kt,is that different from line 455 ? [20:41:03] because if i understand the logic, having an incorrect X-CS is the same as not having one at all, both would show a warning [20:41:19] and if its disabled, it will be hidden [20:41:38] i mean - if its disabled, its just like not having x-cs is set [20:43:21] dr0ptp4kt, btw, the line number is of the right hand side [20:43:44] yurik, good question. if it's a correct X-CS, but enabled is set to false, it should be treated the same, meaning there should be a 'your carrier isn't supported' warning. [20:45:21] yurik, on a related note, it seems if i put a non-existent X-CS in the query string it isn't giving the big red warning for some reason. [20:46:38] yurik, but that was with the pre-'remove-global-imgflag' version. i haven't tested the pre-'remove-global-imgflag' version yet. [20:47:40] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/ADSQMg [20:47:40] Commons-iOS/master 947580f Monte Hurd: Details page sharing support... [20:47:40] Commons-iOS/master d978f65 Brion Vibber: Merge pull request #64 from montehurd/detailsPageShare... [20:49:50] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/1uEneA [20:49:50] Commons-iOS/master 2d9ed6f Monte Hurd: Small tweaks [20:49:50] Commons-iOS/master 0b2b8d9 Brion Vibber: Merge pull request #63 from montehurd/refactor... [20:50:12] yurik, i changed 250-99 to have enabled set to false. then i also did an X-CS=900-99 (non-existent) to see what would happen. [20:51:14] New patchset: JGonera; "Bug 46804: Make button padding consistent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62166 [20:51:20] jdlrobson, ^ [20:51:33] thanks jgonera will check [20:54:03] hey jdlrobson how do I test the gender support for photoupload? [20:54:32] https://en.m.wikipedia.org/wiki/Special:Preferences jcmish [20:54:56] k i put my changed that do I need to do anything else? [20:55:09] will it show up in history or anything like that? jdlrobson? [20:55:24] shouldn't do.. [20:55:29] bah not put my :D I changed my preferences [20:55:40] k [20:55:54] jcmish: you'll probably want to check in polish too [20:56:00] obviously gender same in english.. [20:56:05] gonna be hard to test really :/ [20:56:05] ah okay [20:56:11] :D [20:56:55] dr0ptp4kt, api is using meta [20:57:09] its in localsettings [20:57:22] yurik, ok, will create a fake carrier modeled after beeline. [20:57:23] easy to change to local [20:57:31] dr0ptp4kt, don't change meta [20:57:52] i will reconfigure [20:57:58] yurik, ok, send the word... [20:58:14] New patchset: JGonera; "Follow up to I3ae653ac2777e19843182b420d33cd8f3420fa29" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63561 [20:58:26] jdlrobson, and this one ^ [20:58:34] dr0ptp4kt, changed [20:58:50] dr0ptp4kt, btw, i set up varnish on api - port 8080 [20:58:51] yurik, i see that in LocalSettings.php :) [20:58:59] New patchset: Jdlrobson; "Follow up to I3ae653ac2777e19843182b420d33cd8f3420fa29" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63561 [20:59:07] varnish forwards to local [20:59:13] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63561 [20:59:22] but at this point varnish doesn't do any of the elaborate logic yet [20:59:28] might do it a bit later [21:00:05] dr0ptp4kt, i'm trying to understand your comment [21:00:11] https://gerrit.wikimedia.org/r/#/c/63353/3/includes/PageRenderingHooks.php [21:00:26] line numbers are very confusing [21:01:36] yurik, just did Main_Page?X-CS=888-99&useformat=mobile with X-Subdomain of ZERO. no red 'not supported' :( [21:02:09] yurik, you able to do a Google Hangout? [21:02:52] yurik, irc client acting up. need to stop irc client than restart it. [21:04:01] yurik, need to walk for a couple of minutes, then will be back for a quick google hangout. i know it's getting later in the day there... [21:04:44] jcmish: any luck? [21:05:03] yup looks good [21:05:10] well as good as I can tell [21:05:13] ;) [21:05:59] dr0ptp4kt, sent you invite [21:07:51] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62166 [21:09:07] awjr: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=includes/MobileFrontend.hooks.php;h=a91b770c9f12db019ed969d2b13177ca5f08bf7a;hb=HEAD#l32 doesn't work.. [21:09:23] as a result i seem to have broken Mobile.css and Mobile.js again :-S [21:09:44] jdlrobson: sorry what specifically is broken? [21:10:24] $wgResourceModules['mobile.stable']['dependencies'][] = 'mobile.site'; [21:10:30] this doesn't seem to add mobile.site module to mobile [21:10:41] is there a way of achieving the above? [21:10:49] it's a dependency that should only be added to mobile [21:14:58] brion: i felt silly about this one haha : https://github.com/wikimedia/Commons-iOS/commit/0b2b8d97709a14b5144059b053d8d77c10586646#L0L290 [21:15:39] could be worse :D [21:15:55] ^ awjr ? [21:16:30] jdlrobson: yeah, i think that is happening too late [21:16:36] awjr: :( [21:17:02] lemme see [21:17:54] FYI the reason it is mobile only is to make Special:Nearby work on desktop :) [21:18:56] jdlrobson: would doing that in a post-setup function work, or is that too late as well? [21:19:11] i'm not sure awjr :/ [21:19:27] hmm [21:19:31] MaxSem: might know ^ [21:19:31] i tried moving the hook above adding mobile.stable to the OutputPage but that seems to have no effect :/ [21:19:47] yeah, too late; RL has probably already done its thing [21:20:37] jdlrobson: would it be possible to refactor the code in a way that you can still define the deps in MobileFrontend.php as per usual but still have nearby work on desktop? [21:20:52] you can try putting it in efMobileFrontend_Setup() [21:20:56] well it depends how mobile.site is supposed to work [21:21:10] i believe it should run before every bit of mobile code [21:21:22] in which case it needs to be a dependency of mobile.stable [21:21:33] but i believe it shouldn't run on desktop [21:21:52] if it was MediaWiki:Minerva.js and MediaWiki:Minerva.css I guess it would make more sense to run on both [21:23:26] jdlrobson, try ResourceLoaderRegisterModules hook [21:25:48] * jdlrobson looks [21:27:54] eek latest core and latest master of MobileFrontend gives me Fatal error: Cannot redeclare fn() (previously declared in /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/SkinMobileBase.php:149) in /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/SkinMobileBase.php on line 149 [21:28:38] ^ MaxSem awjr jgonera is that just me? [21:29:26] oh no just me.. i'd made a core change ;-) [21:29:31] i think so, jdlrobson [21:29:34] oh [21:29:37] yeah :p [21:30:12] New patchset: JGonera; "Bug 46804: Make button padding consistent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62166 [21:31:23] mm MaxSem not sure how ResourceLoaderRegisterModules will work here..seems messy [21:32:49] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62166 [21:40:20] New patchset: JGonera; "Promote transitions/transforms/animations to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63562 [21:41:03] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63562 [21:43:34] awjr: is that good to now? https://gerrit.wikimedia.org/r/#/c/63003/ (since i'm not introducing new variables?) [21:46:27] likely jdlrobson, but i need to look closer and test [21:46:33] roger! [21:47:03] jdlrobson: im about to run out and help with some errands but i should be back in ~45 mins; i'll take a look then [21:48:42] New patchset: JGonera; "Regression: Fix Login button in CTA drawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63579 [21:48:54] jdlrobson, ^ [21:49:12] New patchset: JGonera; "Regression: Fix Login button in CTA drawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63579 [21:54:10] New patchset: JGonera; "Remove unused CSS rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63580 [22:02:43] New patchset: JGonera; "Tweak disabled and cancel button colors" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63581 [22:40:09] New patchset: Jdlrobson; "Bug 47882: Redefine default modules for Minerva Skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63589 [22:40:25] New review: Jdlrobson; "Dependency first." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/63589 [22:45:42] New patchset: Shirayuki; "Give grep a chance to find the usages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63590 [22:54:40] New patchset: awjrichards; "Bug 44133: Cleanup how we do config" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63003 [22:56:48] New review: Jdlrobson; "Could you not put a comment into the i18n files mention that to find these keys one should grep for ..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63590 [22:59:21] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63579 [23:01:14] New patchset: Jdlrobson; "Remove unused CSS rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63580 [23:03:57] New patchset: Jdlrobson; "Remove unused CSS rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63580 [23:04:23] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63580 [23:08:19] New review: Jdlrobson; "Had a chat with Juliusz - this isn't that noticeable - if we really want the buttons to look more st..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63581 [23:16:37] New patchset: awjrichards; "Bug 44133: Cleanup how we do config" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63003 [23:16:58] jdlrobson: i made a few changes in https://gerrit.wikimedia.org/r/#/c/63003/4 [23:17:04] * jdlrobson looks [23:17:10] what's the summary? [23:17:27] oh, actually sorry patchset 5 [23:17:46] the critical one was renaming the method for fetching mobile-specific config vars [23:17:55] (it was using the old method name) [23:18:15] the other was fetching the host header from the request object rather than $_SERVER [23:19:22] awjr: it looks fine to me [23:19:28] cool ok, i'll merge then [23:20:06] awjr, is the login form html something we can change? I'm thinking about removing some unnecessary divs and CSS ids [23:20:53] yes jgonera [23:20:54] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63003 [23:21:38] take a look in skins/UserLoginMobileTemplate.php and skins/UserAccountCreateMobileTemplate.php [23:21:41] jgonera: ^ [23:21:44] er, includes/skins [23:22:22] we custom put together the HTML for the forms in the execute() method [23:22:25] I know, I just wasn't sure if changing that would mess up mediawiki ;) [23:22:36] oh [23:22:37] heh [23:22:39] i dont think so [23:22:50] just done take away any form elements without checking first :p [23:24:20] sure [23:26:08] New patchset: JGonera; "Regression: Make login submit button's corners rounded" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63593 [23:26:10] jdlrobson, ^ [23:31:56] New patchset: JGonera; "Tweak disabled and cancel button colors" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63581 [23:33:34] New patchset: JGonera; "Tweak disabled and cancel button colors" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63581 [23:35:01] did we ever decide what to do with our mobile lists situation? awjr, jdlrobson? [23:35:14] are we still using mobile-feedback-l, or mobile-l? [23:35:26] can you refresh my memory Maryana? [23:35:41] i think yuvi kicked off a discussion about this a couple weeks back [23:35:41] for feedback, you mean Maryana? [23:35:53] yeah, or for general mobiley things [23:36:06] for general mobiley things we should use mobile-l, team-specific stuff should be mobile-tech [23:36:18] i think mobile-feedback was set up specifically for feedback from our products [23:36:23] but im not sure of its current status [23:36:28] (jdlrobson might) [23:38:24] looks like the last email (not counting michelle's) came in january [23:38:35] to mobile-feedback-l [23:38:36] hmm [23:51:54] mobile-l-feedback was used by the contact form [23:57:45] oh for some reason i thought the apps were using it too [23:58:11] i think they are [23:58:27] i think yuvi added a link to it. i could be wrong, though.. [23:58:32] brion? [23:59:25] the 'email developer' link for the wikipedia app in the google play store points to mobile-l-feedback [23:59:45] er [23:59:48] mobile-feedback-l [23:59:54] as does the beta commons app [23:59:59] not sure about for ios tho