[00:00:09] just looking.. doesn't appear to be there for ios [00:00:13] commons app [00:04:27] jdlrobson, jgonera how have you guys liked working with hogan? max started a thread on wikitech-l about using the HTML class for generating HTML and Antoine mentioned something about using a template engine, i'm curious to hear your experiences/thoughts [00:05:00] [Commons-iOS] montehurd opened pull request #65: More jitter reduction (master...jitter) http://git.io/kOt1nw [00:06:10] New patchset: Jdlrobson; "Add refresh button to nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63149 [00:06:46] awjr: it's on my todo list [00:07:03] :) [00:07:53] New patchset: Jdlrobson; "Add refresh button to nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63149 [00:09:39] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63593 [00:09:41] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63149 [00:10:14] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63581 [00:12:57] New patchset: Jdlrobson; "Bug 47925: Let people toggle sections in editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63598 [00:13:35] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63598 [00:21:39] awjr, for me, using templates is always better than not using them, no matter what templating language I use. I hate embedding HTML in code (be it PHP or JS) [00:29:57] New patchset: JGonera; "Don't add parent property to Overlay's prototype" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63599 [00:47:23] jgonera: yeah, agreed. i think there's value in the MW HTML class, but it's an absolute nightmare [00:47:56] possibly for generating something really short, but not the whole HTML document [01:19:41] Maryana, ping [01:19:47] still there? [01:38:11] hey yurik [01:38:38] hi Maryana, would it be possible for us to meet before fri? [01:39:30] hmm, possibly [01:39:42] lemme check w/dan [01:39:53] kul, thx [01:40:39] you can't spell it that way. we have a kul :) [01:43:11] Maryana, yeah, i know, ever since i started working with him, something happened to my "c"s [05:08:41] New patchset: Yurik; "Cache invalid X-CS IDs" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63628 [08:38:24] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63426 [16:50:27] I heart Mingle [16:50:37] I heart Mingle so much! [16:50:51] can't find the card I've just created [17:05:53] MaxSem: still looking for your card? [17:06:35] nope [17:06:38] https://mingle.corp.wikimedia.org/projects/mobile/cards/784 [17:06:40] gooood [17:07:12] oo [17:07:38] Maryana: ^^ [17:07:57] w00t! [17:27:09] Maryana, I've left a comment at WV [17:27:18] much appreciated! [17:28:26] [android-commons] brion pushed 1 new commit to master: http://git.io/61EqVQ [17:28:26] android-commons/master c3600f6 Brion Vibber: update license in CREDITS file [17:28:29] tfinc, did you tak with Eric about OSM? [17:28:56] MaxSem: no, was i supposed to ? if so remind me and i'll talk with him [17:29:06] * brion watches jenkins… did we set up auto builds for android-commons? [17:29:40] you said that you'll discuss the timeline and ops involvement [17:32:11] MaxSem: remind me where we are at and then i'll get him involved. sorry about dropping the ball there [17:36:47] we're at the point where we neeed ops to move forward at a reasonable pace. while I and volunteers can continue modeling this stuff at labs, we need to get the packages reviewed - that's something only ops can do. also, what's the point of spending much time on puppet manifests if Faidon threatens to rewrite them for production? [17:39:01] New patchset: Jdlrobson; "Bug 47374: Deal with false positives" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63689 [17:39:53] Maryana, how does https://mingle.corp.wikimedia.org/projects/mobile/cards/784 look? [17:39:53] New review: Jdlrobson; "Brion Note: I haven't been able to test so would appreciate someone testing before merging :)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63689 [17:40:45] maxsem, the only thing i'm unsure of is how pageimages will work with that [17:40:50] is the answer "it won't"? [17:40:51] :) [17:41:05] yes [17:41:08] * jdlrobson is excited about the prospect of a wikivoyage nearby [17:41:18] wikivoyage far away is more fun! [17:41:22] well, that's ok. most of the POIs won't have an image anyway [17:41:24] jdlrobson, but it'll require some work [17:41:32] of course ;-) [17:41:42] MaxSem: is this still a bug = https://bugzilla.wikimedia.org/show_bug.cgi?id=46581 ? [17:43:00] * MaxSem looks up the logs [17:44:18] grrrr im afraid my galaxy nexus (or at least the battery) is dying - it hasnt been able to hold a charge for more than a few hours :( [17:44:39] maybe a s/w problem? [17:45:25] if some crappy app is constantly accessing the net, it will discharge lightning fast [17:46:10] yeah i was wondering about that - i havent added any new apps/made any changes though, so it seems unlikely, unless an update to some app introduced a bug or something [17:46:43] im tempted to just try a factory reset and see if the problem persists [17:46:47] New patchset: Yurik; "Removed 'partnerId' config setting" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63692 [17:46:50] New review: Brion VIBBER; "Confirmed this successfully blacklists Windows Phone 8 from the upload feature. (Tested on Lumia 920..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63689 [17:46:53] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63689 [17:47:50] MaxSem: got it [17:51:47] tfinc: ok i've got jared and maryana on test flight, but not yet vibha [17:52:09] brion: is she on chat? [17:52:12] oh, i'm checking in w/her in a minute - want me to bug her to do it? [17:52:25] Maryana: yes. i messaged her about it yesterday [17:52:29] no idea where she is online, i never see her on irc [17:52:56] me and jgonera are gonna go up to 6 and install adium on her machine :) [17:52:57] guys, https://gerrit.wikimedia.org/r/#/c/61809/2 isn't that wrong ? [17:52:59] by force [17:53:03] heheh [17:53:09] don't we have OutputPage->setCanonicalUrl() for that ? [17:53:44] thedj: what's wrong about it? [17:54:39] well for one, canonicalurl as used there includes the fragment identifier [17:55:21] dr0ptp4kt, i guess you can go ahead and re-run your script to remove partnerid at some point, although if you want we can do it after the deployment tmrw [17:55:58] eek [17:56:10] brion: canonicalurl in the wiki Title context != canonical url in the HTML context [17:56:23] fun times [17:56:28] well i'll leave that to the MF skin folks ;) [17:56:35] * brion sneaks back to apps ;) [18:00:02] hm, after this next add we'll only have about 10 slots left for new devices [18:00:05] stupid apple :P [18:01:43] brion: get an enterprise account [18:02:01] that's exactly what they are for :D [18:02:40] btw, if you ever do, make sure you name it differently then your primary account, or you'll go mental with the certificate maintenance :D [18:02:50] thedj: i don't follow - is there a web page which is showing up as having the wrong canonical url? [18:03:02] New patchset: MaxSem; "Add debug logging for bug 46581" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63693 [18:03:51] jdlrobson: i'm not sure about that. But out->setCanonicalUrl should be the way to do it regardless. [18:04:42] i'd be interested in why there are 2 ways to get canonical urls and how they differ.. why would a canonical url include a fragment id ?o_O [18:04:43] i'm just trying to wade trough all those canonicalness issues we seem to be having with google lately, and this introduces an uncertainty that should not have been there. [18:04:44] yurik, attempting a json load onto apibeta [18:04:48] thedj: eh? we have a company account [18:05:11] ah for enterprise private distribution [18:05:13] fuck that shit [18:05:15] we're open sooooource [18:06:14] apple is rather liberal with it. if you make an invite only sytem around it, they are more than satisfied. [18:06:43] it's how we deliver test builds to all customers. otherwise, we'd go crazy :D [18:07:05] ugh ugh ugh [18:07:20] they can never take… our freedom [18:08:53] jdlrobson: Title:canonicalurl describes all elements of a title in a canonical way. [18:09:09] jdlrobson: rel=canonical describes the canonical form of a data entity. [18:09:46] there is a strong overlap, but it's not really the same thing. [18:13:18] [Commons-iOS] brion pushed 3 new commits to master: http://git.io/opE08w [18:13:18] Commons-iOS/master aaabbff Monte Hurd: Further reduction in fast-scroll jitter... [18:13:18] Commons-iOS/master f2e8af6 Monte Hurd: Made the other places which call fetchThumbnails use dispatch_async... [18:13:18] Commons-iOS/master c98e036 Brion Vibber: Merge pull request #65 from montehurd/jitter... [18:13:34] it might be good if it were, but as far as I know, we don't have such a strong title -> data entity connection. [18:14:56] New patchset: Dr0ptp4kt; "Removing partnerId from Wikipedia Zero JSON configuration blobs and TSV." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63698 [18:16:39] thedj: don't we have a 1:1 title:entity connection? (with some titles mapping to redirects to another entity, referenced by title) [18:17:24] MaxSem: see the emails re using tin for deployments now? [18:17:37] yah:( [18:23:17] yurik, okay if i pull down your partnerId change to apibeta so i can verify the fix at runtime? then i'll +2 verified. [18:31:10] can someone review https://gerrit.wikimedia.org/r/63693 - I'd like to have it deployed today [18:31:47] New patchset: MaxSem; "Add debug logging for bug 46581" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63693 [18:32:56] looking MaxSem [18:35:33] MaxSem: why did you remove the call to tidy? [18:35:55] oh nm [18:36:00] you just moved it [18:36:15] oh shi [18:36:24] I shouldn't have [18:36:27] fixing [18:36:30] but still it seems like it's in the wrong place [18:36:31] yeah [18:36:31] k [18:37:33] New patchset: MaxSem; "Add debug logging for bug 46581" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63693 [18:39:05] MaxSem: i just noticed an unmerged config change of yours from a while ago: https://gerrit.wikimedia.org/r/#/c/23112/ [18:39:53] bug's still open… does that need to be pushed as well? [18:40:47] I've already forgot how to test it:P [18:41:25] heh [18:41:37] yeah thats like.. ancient history [18:42:12] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63693 [18:52:50] awjr: heads up that i may be late for our 4pm. i'm going to fight the google i/o pre register crowd 3-4 [18:54:41] np tfinc, i am totally free after deployment [19:04:46] eek awjr we never fixed the Mobile site module problem [19:04:58] eh, jdlrobson? [19:05:03] that dependency problem [19:05:31] oh, what we discussed yesterday? [19:05:33] where the hook was running too late [19:05:34] yeh [19:05:40] did tryin the hook max suggested not work/ [19:05:55] I tried it couldn't get it working for some reason, didn't get a response and then got sidetracked [19:06:01] ok [19:06:03] well [19:06:09] hmm [19:06:39] what about making nearby NOT work on desktop so we dont have this problem (and then figure out how to cope with nearby on desktop later)? [19:08:21] yurik, dr0ptp4kt are either or both of you on the ops mailing list? [19:08:34] awjr: no i promised nearby on desktop for people i think this is more important [19:08:47] awjr, i am not. should i be on it? [19:08:51] the other thing to do would be just to add the site module without making it a dependency of mobile.stable [19:09:15] jdlrobson: im not suggesting you break the promise, just that we find another way to fulfill it if the other alternatives are not working [19:09:31] ^ awjr other way is that [19:11:21] dr0ptp4kt yurik i ask because there's a discussion happening there about missing X-Analytics headers for some/many cache hits; have you guys been looped in to this discussion otherwise? [19:11:36] guys, can you explain what's the problem? [19:11:54] jdlrobson: is there any reason that might cause other problems? if not, go for it! [19:11:57] awjr, no. [19:12:28] dr0ptp4kt: andrew otto and evan rosen seem to be spearheading the convo; you might want to touch base with them [19:13:29] New patchset: Jdlrobson; "Re-enable mobile.site module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63714 [19:13:31] awjr: ^ [19:13:40] that's the other way [19:13:57] awjr, how do i get on that mailing list? [19:14:23] good question dr0ptp4kt i think you might need to have someone from ops add you, lemme dig [19:14:38] awjr, thx [19:15:03] vbamba: [19:15:30] jdlrobson: is juliusz around? [19:16:09] vbamba: [19:16:25] vbamba: [19:16:32] awjr & jdlrobson, can you explain what's the problem? [19:16:45] MaxSem: mobile.site is not currently being added [19:17:05] eh [19:17:10] it was being added as a desktop only dependency in the onEnableMobileModules hook but that wasn't working [19:17:51] https://gerrit.wikimedia.org/r/63714 should be acceptable for the time being [19:19:39] vbamba wooo! [19:21:56] dr0ptp4kt, yurik i forwarded you an email from back when the ops list was created, hopefully that should help - also, i'll forward you the thread i was talking about [19:23:56] awjr, thx. i'll email ct. look forward to the other message. [19:24:06] dr0ptp4kt: cool - sent [19:25:29] jdlrobson: how have things been working in master w/o mobile.site? [19:25:53] awjr: ? [19:26:00] awjr, thx again [19:26:04] awjr: mobile.site just adds Mobile.js and Mobile.css [19:26:30] these are optional modules but used on enwiki and various other projects [19:26:31] r [19:26:51] really they should only be used for live hacks but they are not typically used that way due to the fact MediaWiki makes it hard to add template specific css [19:27:40] oh, i see; i assumed it was also responsible for loading mobile.startup since that's a dep [19:27:50] but that gets added by the skin [19:28:44] it's badly named :) [19:29:09] awjr, i'm on the ops [19:29:40] dr0ptp4kt, sorry, stepped away for a bit, yes sure, pull away [19:30:24] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63714 [19:30:42] cool yurik, i just wnted to make sure you guys were aware of the missing X-Analytics header discussion [19:34:18] awjr_lunch, was just reading it [19:34:36] [Commons-iOS] brion opened pull request #66: Bug 48040: Check for filename conflicts before upload (master...namecheck) http://git.io/dhH3Cg [19:36:25] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/YmwH1g [19:36:25] Commons-iOS/master 0709b58 Brion Vibber: Bug 48040: Check for filename conflicts before upload... [19:36:25] Commons-iOS/master 2e00387 Brion Vibber: Merge pull request #66 from brion/namecheck... [19:45:52] dr0ptp4kt, i saw you merged one, but the parent is not yet merged [19:51:02] yurik, reviewing the dependency on apibeta atm [19:51:14] dr0ptp4kt, thx! [19:56:06] New review: Dr0ptp4kt; "Verified on apibeta with X-SUBODMAIN: ZERO for "enabled": false" [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63420 [20:01:14] Sorry I'm having firewall issues but am here on my ipad [20:07:03] w00t [20:07:34] MaxSem: greg-g wants us to let him know how things go with getting code up on testwiki [20:07:51] sure [20:07:54] thanks [20:08:09] today will be an annoying day (first day of new procedures), so, sorry all! [20:08:55] and sorry about the lack of communication with it.... :/ [20:09:03] especially re: clarity [20:09:07] brb [20:13:45] for those interested in the standup for zero, we had to change rooms. we're in r33 < Maryana, tfinc [20:15:16] all right awjr, jdlrobson, jgonera, Maryana - we're live on testwiki, please test:) [20:15:21] w00t [20:16:50] MaxSem: wtf happened to the logo… https://test.m.wikipedia.org/wiki/Special:UserLogin [20:16:54] jcmish: just fyi there were a couple of patchsets added to fix a couple of issues after cutoff/deployment log generation [20:16:55] sooo pixelated! [20:17:06] oof that looks bad. [20:17:08] rawr, need to sync that config change [20:17:30] phew.. i thought the logo had changed again [20:17:46] i wish action=history worked in mobile [20:17:57] some day [20:19:30] awjr: funny you say that.. ;-) [20:19:38] oh? [20:20:17] i've been spending time thinking about that - making it reuse watch list code [20:21:33] also I want MobileDiff to always be the default.. been bugging me loads [20:22:21] yess [20:22:53] im getting 404s for some image assets; are things sync'ing or something [20:24:01] New review: Dr0ptp4kt; "Dependent change fixes the -1 issue." [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 2; - https://gerrit.wikimedia.org/r/63353 [20:24:14] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63420 [20:24:14] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63692 [20:24:14] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63353 [20:25:59] awjr, what assets? [20:27:04] watch.png, show.png, logo-copyright-en.png [20:27:07] oh and geopilookup [20:27:24] and external-link-ltr-icon.pn [20:27:26] g [20:28:37] we gotta bug [20:29:06] caught and squished :) [20:31:07] i get an empty toast after logging in in beta :( [20:31:14] sad empty toast [20:31:21] New patchset: JGonera; "Make elements at the bottom of the nav clickable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63730 [20:31:58] awjr, MaxSem we should merge this fix ^ [20:32:50] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63730 [20:33:34] login icon on login page has gone missing again? are we doing a sync of some sort? [20:34:17] yeah there's been some weirdness; i wonder if it's related to the deployment/testwiki changes [20:35:27] [00:21:22] <+logmsgbot> !log maxsem synchronized docroot/bits/mobile/W.png [20:35:37] which apparently didn't work [20:35:43] New patchset: Jdlrobson; "Add message for toast to the module that uses it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63732 [20:35:51] grrr [20:35:58] yeah w.png is 404ing fo rme still [20:36:57] juliusz is working on one more fix [20:37:13] you can't actually tap the footer cos that weird invisible drawer is in the way [20:38:50] jdlrobson, do we need to deploy https://gerrit.wikimedia.org/r/63732 too? [20:39:59] fwiw i'm relaying most of this stuff to michelle (who cant get on IRC but is on gchat)s [20:40:02] yup [20:40:09] minor fix MaxSem was about to self merge [20:40:28] she says aside from the things we've seen things are otherwise looking ok in stable and she's moving on to beta [20:41:31] has she taken a look at the opera mini bug, awjr? [20:41:39] https://mingle.corp.wikimedia.org/projects/mobile/cards/698 [20:42:13] not sure Maryana; quick to test tho [20:42:24] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63732 [20:43:39] Maryana: i just tested using an opera mini user agent and it appears to work as expected (no js) [20:43:47] w00t [20:43:55] does that mean we can finally bury all those OM bugs? [20:44:06] (sidenote: i love bingle) [20:44:06] i just came across this entertaining testwiki article: https://test.m.wikipedia.org/wiki/Image_test [20:44:18] Maryana: yes; at least the JS-related ones [20:44:27] im glad bingle has been working out :) [20:44:48] the very word brings a general feeling of joy and well-being :) [20:45:02] ooo actually [20:45:10] there might be an opera mini problem [20:45:30] i just noticed im getting a JS error when im spoofing an opera mini UA in chrome desktop [20:45:42] i gotta set up a trellzilla … bugello? [20:46:50] blingle [20:46:52] desktop nearby! https://test.wikipedia.org/wiki/Special:Nearby [20:47:01] (yuk) [20:47:07] jdlrobson: whee! [20:47:10] brion: i started looking into trello integration with bingle… i was thinking bingello [20:47:14]

! [20:47:25] awjr: opera mini doesn't run js in the wild [20:47:36] jdlrobson: spoofing opera mini UA in chrome desktop on testwiki is giving me a jquery is not defined error [20:47:46] jdlrobson: so … don't worry about it? [20:47:58] awjr: should be harmless [20:48:01] but suspicious [20:48:21] hm how is test wiki fetching all these coordinates from articles on english wikipedia? [20:48:21] brion it looks like it should be pretty straightforward, hardest part looks like oauth integration [20:48:32] yeah jdlrobson [20:48:32] oauth! all riiiiight [20:49:25] awjr: https://test.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=173063&oldid=149080 :D [20:49:41] FTW [20:50:26] awjr: yeh so that $ undefined error is caused by jQuery.ready(); [20:50:31] that's added by core... [20:50:54] brion: aye :) [20:50:55] o [20:51:52] is there an article w/an infobox and no lead image on test? [20:51:59] mm [20:52:03] probably? [20:52:29] jdlrobson: michelle says 'tell jon the spinning watchlist star still tickles me :D' [20:52:38] i love it, too [20:52:39] New patchset: JGonera; "Make footer links clickable when drawer is hidden (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63734 [20:52:43] i want the refresh icon on nearby to spin [20:52:47] animate all the things!! [20:52:54] awjr, MaxSem, jdlrobson ^ [20:53:00] (I mean the change) [20:53:08] … and animate all the things [20:53:14] i'm taking that as a plus 1 :) [20:53:53] a ha! [[Test123]] [20:54:03] Krinkle: https://gerrit.wikimedia.org/r/#/c/61057/6/includes/OutputPage.php [20:54:11] and, well, thank you, the tickling star is mine [20:55:03] haha jgonera i'll tell michelle :) [20:55:13] jdlrobson: Thanks, fixing. [20:55:16] jgonera: i cant replicate the footer link clicking problem locally [20:55:26] so im not sure how to test that patchset; though it looks sane [20:55:38] awjr, the footer has to be close to the bottom of the screen for this problem to occur [20:55:48] if your browser window is too big, it won't happen [20:55:51] oh i see [20:56:56] huh, still can't jgonera - is it a problem in stable/beta/alpha … [20:56:56] ? [20:57:04] logged in/out? [20:58:18] slight fix required.. sigh [20:59:09] awjr, logged out, beta and alpha [21:00:17] ahha jgonera [21:00:20] got it [21:01:06] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63734 [21:01:22] jdlrobson: what is the fix needed? [21:01:32] awjr: minor css fix - refresh icon works weird [21:01:37] kk [21:01:48] have you tried uploading, awjr? [21:01:57] not yet Maryana [21:01:58] i'm getting an error, and it's a very angry red [21:02:01] not sure if michelle has [21:02:13] i feel like that's fairly standard on testwiki [21:04:06] yeah, true that [21:05:01] New patchset: JGonera; "Remove red border on error toast messages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63737 [21:05:09] jdlrobson, ^ [21:05:09] ok im seeing something weird RE uploads [21:05:34] i uploaded a photo from Special:Uploads; it appeared to upload fine (i got a success and it appeared on my uploads page) [21:05:51] but when i tapped the photo, it took me back to special:uploads rather than the file page, and i got a JS error [21:05:55] i feel like we've seen that before on testwiki... [21:05:56] Uncaught TypeError: Cannot read property '0' of undefined [21:06:06] i've seen other upload weirdness but not this [21:06:07] not sure about the last part, but the first part sounds familiar [21:06:09] hm [21:06:11] yeah [21:06:29] testwiki broken in new and exciting ways [21:07:00] jgonera said he had no trouble uploading [21:07:14] were you on android, awjr? [21:07:21] chrome desktop, Maryana [21:07:40] but now i cant load Special:Uploads [21:07:55] ok so uploads are a race condition on test [21:07:56] i see the chrome, but none of my images show up and i still get the same JS error [21:07:58] New patchset: Jdlrobson; "Animate refresh icon correctly" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63739 [21:08:30] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63737 [21:08:55] awjr: Maryana so the only reason uploads sometimes work on test is they upload to test wiki [21:09:22] awjr: Maryana this is due to https://test.m.wikipedia.org/wiki/MediaWiki:Mobile.js [21:09:41] jdlrobson: what about this: http://test.wikipedia.org/wiki/File:Emma_2013-05-14_14-04.JPG [21:09:44] however there is no guarantee this code will load before [21:09:48] ok. maybe we just shouldn't test uploads on testwiki at all, since it's always half broken [21:09:48] so the file got created but there's no image associated with it [21:09:50] but it will sometimes [21:09:52] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63739 [21:09:54] which i assume is what's causing the JS error im seeing [21:10:05] awjr: : This photo was uploaded with Commons Mobile App (Web). o_O [21:10:17] awjr: i'll take a look [21:10:18] jdlrobson: that's a local template issue on testwiki [21:10:27] coolcool [21:11:32] awjr i got an api error when i uploaded [21:11:40] "error":{"code":"internal_api_error_DBQueryError" [21:11:59] something funky going on in the api [21:12:02] jdlrobson, any details? [21:12:08] yup MaxSem [21:12:16] http://pastebin.com/ezkwx78n [21:12:18] huh interesting, i got no errors [21:13:14] 1290 is a deadlock [21:13:43] o_O [21:13:47] what would cause that on testwiki/ [21:13:54] Y U SO SCARED [21:14:20] heh [21:14:26] all i can say is it works fine on localhost latest master.. [21:14:31] i blame test wiki [21:14:36] GlobalUsage writes to a shared DB, hence high contention for every wiki [21:15:07] le sigh [21:16:16] ah [21:16:22] we're read-only [21:16:32] * MaxSem bites binasher [21:22:17] ok, should I deploy https://gerrit.wikimedia.org/r/63739 too? [21:22:27] it's pretty much cutof time now [21:22:46] * MaxSem prepares his reverting wrench [21:23:22] yes MaxSem [21:23:30] and read only makes this all make more sense [21:23:34] heh i love yuvi's debug messages [21:23:35] Log.d("Commons", "ZOMG I AM BEING KILLED HALP!"); [21:23:42] let's do it live! [21:23:44] lol [21:24:08] MaxSem: did you also pick up https://gerrit.wikimedia.org/r/#/c/63737/ [21:24:21] oh and https://gerrit.wikimedia.org/r/#/c/63734/ [21:24:28] updating to master now [21:24:36] groovy [21:25:43] MaxSem: sweet [21:25:47]