[01:00:19] New patchset: Yurik; "Use "sites" parameter to show banner" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64548 [09:37:04] [android-commons] siebrand pushed 1 new commit to master: http://git.io/zgvkvg [09:37:04] android-commons/master 772a528 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [09:39:07] [Commons-iOS] siebrand pushed 1 new commit to master: http://git.io/Ps73xA [09:39:07] Commons-iOS/master 630d720 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [09:42:39] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/xQIV0g [09:42:39] WikipediaMobile/master 146c4ab Siebrand Mazeland: Localisation updates from http://translatewiki.net. [16:08:33] New review: Yurik; "Please add a link to the MobileFrontend's patch that must be merged & deployed before this one." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63811 [16:48:29] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64463 [16:49:58] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/64464 [16:54:29] New review: MaxSem; "I think you're using the word "deprecated" in a wrong way: deprecated means "don't use this, we have..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64465 [16:55:26] New review: MaxSem; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64350 [16:56:42] New review: Jdlrobson; "yeh that better way is in the following commit - maybe I should put this after.." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64465 [17:00:11] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64350 [17:12:06] New review: Jdlrobson; "poke...^" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64249 [17:16:37] awjr, can you manage the tomorrow's deployment, please? [17:17:22] sure thing, MaxSem [17:18:12] MaxSem: did you have any further discussion with yurik or adam about deploying zero changes tomorrow vs some other day (beyond what's in the email thread 'Deployment Assistance Tuesday 21-May for ZeroRatedMobileAccess with MobileFrontend Dependency') [17:18:30] nope [17:18:41] k [17:36:18] awjr, MaxSem, if this is regarding that new hook that was added, they don't need to be deployed in sync [17:36:25] we can safelly do it on wednesday [17:36:28] cool [17:36:41] i'm traveling tomorrow, so might not be online [17:36:51] MaxSem, how's AMS? [17:37:03] yurik: do you guys need support with your weds deployment or will you be doing it on your onw? [17:37:05] *own [17:37:07] rainy [17:37:18] not very warm, also [17:37:57] awjr, i think i should be ok with the deployment, just need a confirmation that mobile has deployed [17:38:05] MaxSem, bleh [17:38:35] ok yurik, i should be available if you wind up needing anything [17:38:52] awjr, thx! [17:39:36] * yurik is thinking that chairs should have a built-in massage... [17:41:19] yurik, a feature direly needed by my hotel chair [17:43:47] MaxSem, http://www.youtube.com/watch?v=wrqoTnmoJRc [17:49:16] [android-commons] brion opened pull request #21: Use .jpg instead of .jpeg (master...jpg) http://git.io/E2f45w [17:52:17] New review: Jdlrobson; "localhost.alpha/w/index.php/San_Francisco_Pride?action=edit seems to still work in alpha..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/64466 [17:56:12] New patchset: Jdlrobson; "Drop Skin from names of templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64464 [17:56:25] New patchset: Jdlrobson; "Add FIXMEs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64465 [17:56:54] MaxSem: have you and yurik sync'd up about https://mingle.corp.wikimedia.org/projects/mobile/cards/784 yet? [17:57:15] i'm rebooting varnich caches for mobile, one by one and careful though [17:57:20] need for kernel upgrades [17:57:37] thanks for the head's up mutante [17:57:40] watching ganglia [17:57:48] * yurik hides [17:57:58] MaxSem: awjr any objections to https://gerrit.wikimedia.org/r/#/c/64350/ ? [17:58:43] havent had the chance to look closely yet, jdlrobson [17:58:46] jdlrobson, i am not very happy with the whole idea of "expose "this" for any kind of last stage modification", but don't think I can come up with a reasonable alternative in a short term [17:59:20] awjr, yes - I experimented a bit with it, so far it aggravates one already known problem in GeoData [17:59:26] jdlrobson, maybe, just maybe, it might make sense to have a hook "last stage rendering" that only gets "out" object [17:59:29] so I'll be stepping lightly [18:00:07] assuming that the OUT object has the entire page content, including footer [18:00:16] because we could, in zero, do a regex search replace for all links [18:00:48] MaxSem might come up with better idea on this one though [18:01:39] New patchset: Jdlrobson; "Alpha: Use diff page for history" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63908 [18:01:47] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64464 [18:01:52] in the long run, i really think we should have just wikipedia.org without the languages instead of all the zero & m, and do a last minute decision in varnish [18:02:18] eek [18:02:26] you're scaring me:) [18:02:35] this will solve google links, zero whitelisting, and lots of other stuff :) [18:03:29] wikipedia.org/ru/Title works just as well ;) [18:04:15] if we also do links like en.wikipedia.wmf.org we will also fix the cookies problem [18:04:34] good point [18:05:02] but ugly in terms of PR [18:05:11] wikipedia.org is a brandname [18:05:25] much bigger than cookie issue [18:05:25] yurik: Did the partial cache clearing have an entry in RT? [18:05:33] dfoy, don't think so [18:15:35] MaxSem, pls comment re patch above [18:16:46] yurik, which one, "in the long run, i really think we should have just wikipedia.org without the languages instead of all the zero & m, and do a last minute decision in varnish"? [18:17:00] MaxSem, no no, the one above [18:18:03] lovely, AMS will be sunny right after we leave [18:28:00] tfinc: hmmm… even on the web site i'm getting the "Hangouts has not been enabled for your account. Please contact your administrator to enable this service." [18:28:12] mhurd: let me come by and se [18:28:13] e [18:28:26] [android-commons] brion opened pull request #22: Disable spell suggestions in non-editable title view on detail page (master...spell) http://git.io/iKBxow [18:30:04] New patchset: awjrichards; "Add hook to allow template tweaks before rendering" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64350 [18:31:35] New review: awjrichards; "The template object doesn't need to be explicitly passed by reference (objects are pass by identifie..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/64350 [18:36:06] [android-commons] brion opened pull request #23: Fix title text color in detail view on Gingerbread (master...gingercolor) http://git.io/Y5Qx0A [18:36:26] [android-commons] brion pushed 2 new commits to master: http://git.io/CmflSg [18:36:26] android-commons/master ca92bd6 Brion Vibber: Fix title text color in detail view on Gingerbread... [18:36:26] android-commons/master 973ee82 Brion Vibber: Merge pull request #23 from brion/gingercolor... [18:37:36] New patchset: Jdlrobson; "Identify zero code that needs to move out of MobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64607 [18:38:05] New patchset: Jdlrobson; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608 [18:38:18] New patchset: Jdlrobson; "Identify zero code that needs to move out of MobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64607 [18:39:12] awjr: MaxSem can you give me some help on https://gerrit.wikimedia.org/r/#/c/63907/2 ? [18:39:16] i'm really keen to get this change in.. [18:40:24] sure [18:44:23] MaxSem: main issues are 1) deciding if url format A…B is ok and 2) helping me write a MobileContext php unit test - I'm not too familiar with writing tests for this sort of thing (assume it will need a stub of some kind?) [18:45:24] ok [18:48:54] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64373 [18:50:36] mutante - meant to ask you earlier but does rebooting the varnish boxes result in a purge? [18:51:01] [Commons-iOS] montehurd opened pull request #72: Smoothed upload progress bar so not so jumpy (master...uploadProgressBar) http://git.io/cCv9Kw [18:51:37] brion: pull req was from left-over stuff from this weekend [18:51:57] ok [18:52:02] New review: Yurik; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/64607 [18:53:02] tfinc, i sent a requset re day off tomorrow, is that ok? [18:53:12] i will be somewhat jetlagged [18:53:22] yurik: i'll take a look [18:53:26] will need a way to recover [18:53:30] thx [18:53:56] New patchset: Jdlrobson; "Move zeroRatedBanner to ZeroRatedMobileAccess / add FIXMEs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64607 [18:54:21] New patchset: Jdlrobson; "Bug 47882: Redefine default modules for Minerva Skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63589 [18:55:03] * tfinc is playing around with the new google maps interface and liking it [18:56:21] jdlrobson: im not sure why but for some reason the 'update location' feature doesn't seem to work right in https://gerrit.wikimedia.org/r/#/c/64453/1 [18:56:58] if i go to nearby, then update my location once, it seems to work fine. if it ry to update my location a second time, it spins forever (and doesn't appear to make a second network request) [18:57:30] hmm actually im seeing the same behavior in master [18:57:41] New review: JGonera; "Fixing the bugs now." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64466 [18:58:09] and jdlrobson it doesn't seem to be as consistent as i thought at first [18:59:03] so, occasionally hitting the 'update location' icon results in the icon spinning forever, and the 'loading topics near your current location' screen forever, with no apparent request made to the API [18:59:03] Change abandoned: Jdlrobson; "I e-mailed Shirayuki cc'ed Max. Seems silly to have this conversation in Gerrit as Gerrit is not goo..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64249 [18:59:31] awjr: ? [18:59:51] awjr: it's using JSONP so possible it might be sending a request without you knowing [19:00:41] jdlrobson: interesting; the 'network' browser in chrome dev tools does not show a request to the API when i see this behavior (but normally it does) [19:01:02] awjr: that's because it is jsonp [19:01:13] jsonp is a hack [19:01:37] actually awjr just noticed a problem with nearby.. [19:01:46] i forgot to promote some stuff i think [19:01:55] hi jdlrobson sorry, not going to SF this week [19:02:03] jdlrobson: regardless of whether or not the network request is occurring, the 'update location' feature appears to not always work. [19:02:07] qgil: :( [19:02:19] awjr: but you are using the /hacked/ version of nearby [19:02:19] I'm working from home after some tiny surgery last week [19:02:27] jdlrobson, working from home [19:02:53] jdlrobson: oh, you mean because im requesting things from enwiki rather than my local wiki? [19:02:56] awjr: no, it should not, they have persistent cache on disk [19:03:54] jdlrobson, maybe Dan Foy is going? He got an invitation as well [19:04:12] qgil: will check with him [19:04:14] awjr: yes [19:04:14] a [19:04:21] awjr: i'm taking another look at it now though [19:05:07] jdlrobson, if we is not going juts grab a pal and go there. I believe it's going to be interesting [19:05:33] jdlrobson: i see the same behavior in production [19:05:56] ok thanks mutante [19:06:15] awjr: on en.wikipedia.org current deployed version? [19:06:23] yes jdlrobson [19:06:57] well awjr the default timeout for getCurrentPosition is infinite :) [19:07:07] so i guess you've got no connection. We can always set a timeout though [19:07:15] not sure what is a suitable time frame to give up on though.. [19:08:23] awjr: try this patch: [19:08:48] New patchset: Jdlrobson; "Nearby: Timeout if location retrieving taking too long" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64618 [19:11:41] jdlrobson: that results in a toast message saying 'unable to find you. trying again….' which now never disappears either :( [19:11:56] awjr: so that's confirmed then [19:11:56] i think nearby needs to better anticipate and handle failure [19:11:57] y [19:12:00] awjr you can't get a location [19:12:08] it's telling you exactly what it should [19:12:10] it can't find you :) [19:12:15] jdlrobson: but then it doesn't do anything [19:12:17] so how is it going to show you nearby things :) [19:12:31] jdlrobson: it is inconsistent. it works *most* of the time [19:12:34] ohhh that's because now you need to hit refresh again - eek should change that wording [19:12:42] the varnish reboots are over, fyi [19:12:43] awjr: that's the browser's fault then - nothing we can controll [19:14:04] New patchset: Jdlrobson; "Nearby: When location lookup fails try again until location can be found" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64619 [19:14:13] this will help ^ [19:14:20] jdlrobson: we can control the behavior of failure [19:15:56] heh now it goes into an infinite loop of trying to find me [19:16:28] perhaps we ought to start being more explicit in stories for new features about what failure looks like and how to handle it [19:17:39] New review: awjrichards; "This can go on for eternity, and the user may not even realize it - particularly since the toast mes..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/64619 [19:17:59] jdlrobson, have you seen my replies on https://gerrit.wikimedia.org/r/#/c/64466/ [19:21:17] brion: quick layout preference question when u have a sec [19:22:26] New review: Jdlrobson; "It will go on until your location can be found - not an eternity." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64619 [19:23:14] New review: Jdlrobson; "If we were to stop at say 5 attempts what should happen? Another toast message? Can the refresh but..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64619 [19:24:14] New review: awjrichards; "Those are good questions for product." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64619 [19:25:44] New patchset: Dr0ptp4kt; "Adding interstitials for MobileFrontend 'Read in other language' section and footer." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63811 [19:28:47] New review: Dr0ptp4kt; "Latest patchset is merely to make the hook implementation's call signature not use a reference. This..." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 1 - https://gerrit.wikimedia.org/r/63811 [19:29:58] jdlrobson: cached view? [19:30:20] If you look at http://nl.zero.wikipedia.org/wiki/Chuck_Deely you'll see that canonical is present [19:30:36] But that might be a newer version and google hasn't picked it up yet [19:31:59] brion: mhurd : ran into these guys at i/o http://www.bugsense.com/ . let me know what you think. it looks interesting. [19:32:33] "Since it’s impossible to catch every bug before sending it out into the wild" [19:32:43] encoding error on their main page, nice ;) [19:33:20] tfinc: i'm trying to figure out what it…. does exactly [19:33:20] tfinc: huh! looks interesting [19:34:23] tfinc: i'll look at it some more and compare it with testflight's crash capture abilities [19:34:29] k [19:35:26] in theory we already have event logging for usage stuff… anything other than crash data an device information we'd want out of them? [19:37:33] looks like test flight's sdk for android isn't quite done yet [19:38:23] New review: Dr0ptp4kt; "This plays nicely with change 63811/7." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64350 [19:38:39] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64350 [19:46:38] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/_yCWeQ [19:46:38] Commons-iOS/master bf35585 Monte Hurd: Smoothed upload progress bar so not so jumpy [19:46:38] Commons-iOS/master 0bc9677 Brion Vibber: Merge pull request #72 from montehurd/uploadProgressBar... [19:59:04] New review: Dr0ptp4kt; "Verified on apibeta." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64269 [19:59:10] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64269