[14:31:04] what does "(Story 486)" mean in MF's commit messages [14:31:27] liangent: hey [14:31:29] it's our Mingle [14:31:57] yet another issue tracker? [14:32:08] https://mingle.corp.wikimedia.org/projects/mobile [14:32:12] well, not really an issue tracker [14:32:21] also it is for the Mobile Web team, so awjr_away might be the best person to ask about it [14:34:26] liangent: ^ [14:40:29] hey brion :D [14:40:41] * brion waves  [14:40:50] I still have 3 more exams left, but i've a week off. I'll probably still not be coding, but just roaming around and stuff... [14:41:12] well if you have any comments on my code give a shout :D [14:41:25] brion: also, we can now do Android Betas via the Play Store itself, but it is tied to G+ so I don't think we'll be using that for now :P [14:41:27] YuviPanda: got it [14:41:34] brion: I replied to the pull requests yesterday a bit [14:41:37] yeah [14:41:38] a spiff [14:41:38] did they not come through? [14:41:39] *ah [14:41:46] i haven't checked my email yet [14:41:48] :) [14:41:52] ah :P [14:42:17] liangent: :) You'll also start seeing some of 'Trello' links (trello.com/wikimediafoundation) at some point I think [14:43:42] brion: I responded to them from Email (GH does email to comment for Pull Requests), so need to check if they came through [14:43:53] i don't see em [14:44:49] brion: wow, a lot of mine seem lost [14:44:53] * YuviPanda becomes cross at GitHub [14:44:56] :( [14:45:08] * brion never trusts email [14:45:34] brion: redoing [14:46:16] whee [14:47:47] brion: that's it, i think [14:48:39] brion: ooh, one more [14:49:26] crazy idea #1: https://github.com/wikimedia/android-commons/pull/17#issuecomment-18213504 [14:51:33] oh dear, there's now GoDaddy ads on TV here [14:51:42] oh noooooo [14:51:55] now I not only need to mute the TV during ads but also try to look away [14:51:56] sigh [14:52:23] i gotta go through my domains and make sure i don't have any left, i just find go daddy too annoying to live [14:54:03] yup [14:55:14] ok that's it i'm going to starbucks. can't stand being out of coffee in the apartment [14:55:19] be back in a few :D [15:23:40] mmmm, coffe and pastries [15:23:55] heh [15:39:37] [android-commons] brion opened pull request #26: s/getSherlockActivity/getActivity/ in recent code (master...cleanup1) http://git.io/32v3kA [15:55:36] * brion gonna test rtl on 4.2… it'll make amir happy if we fix it :D [15:55:40] http://android-developers.blogspot.com/2013/03/native-rtl-support-in-android-42.html [16:12:25] hmmmm i think it keeps using the 4.0.3 sdk to build, it's giving me errors about the supportsRtl attribute [16:16:06] think i found the magic switch... [16:37:54] sweet, with rtl layout flipping enabled…. most stuff works as i expect [16:38:01] had to flip one icon, that wasn't hard [16:38:21] the paging on the detail view is backwards though (not flipped), will make a card to fiddle with that later if i can't figure it out in a few minutes [16:39:02] brion: it also needs us to replace all 'paddingLeft', 'marginLeft' typ eelements with 'paddingStart' 'marginStart' [16:39:26] well, it recommends it. but it doesn't seem to hurt leaving them as-is for now ;) [16:39:30] brion: as in, we need both paddingLeft and paddingStart. [16:39:31] since we don't have different left/right values [16:39:40] brion: well, it'll be sortof wrong when we do, no? [16:39:47] yeah yeah [16:39:47] but true [16:39:50] ok i'll be good :) [16:39:54] :D [16:40:21] like some day we'll make it different values and notice it is fine [16:40:27] and then it'll break on RTL and amir will be sad [16:40:28] New patchset: MaxSem; "Redirect page diffs to Special:MobileDiff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63907 [16:40:49] brion: oh, also try out the new Android flickr app. has an interesting 'mosaic' view [16:41:01] which is technically very easy to implement, but a bit, ugh. [16:41:02] ooh [16:41:12] YuviPanda: did you see the mockup i put together? [16:41:16] yes I did! [16:41:21] https://brionv.com/misc/commons-mockup/ [16:41:27] now with multiple device size simulation [16:41:30] I actually typed out a reply yesterday, but cleared it out to do more research before responding [16:41:35] ok [16:41:41] brion: so it looks great, but my manjor concern is one of effort [16:42:06] it might be a big fat amount [16:42:13] on iOS we'd only have to implement the layout and could i think use it with standard collection view without too much effort [16:42:16] not sure how hard on android [16:42:43] I'm not sure about iOS, but Android will need to do view recylccing [16:42:48] which is where the problem would be [16:42:57] yeah [16:43:35] so view recycling + appropriate layout behavior would be hard. [16:44:12] so, we should do an initial test run around it, but I'm skeptical of the effort we'll need [16:44:39] we shall see :) [16:44:49] :) [16:45:04] mosaic view on new flickr app is ok… but like the furniture app i looked at before it's got each row/column scrolling separately [16:45:10] not sure we can use that model as [16:45:14] *as-is [16:45:20] i like their detail view though [16:45:22] yeah, I don't like it that much [16:45:24] it's confusing [16:45:36] but I am yet to come across a single nice mosaic view on Android [16:45:38] tap to show controls, tap on info to shoot up a drawer/overlay with info [16:45:42] oh yup [16:45:43] that's nice [16:46:49] aaaaaah back button from a menu closed the app [16:46:53] * brion slaps flickr android developers [16:46:56] BAD developers [16:47:44] New patchset: Jdlrobson; "Make nearby a discovery tool" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64820 [16:47:44] New patchset: Jdlrobson; "Story 435: Left nav grouping (stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821 [16:47:50] brion: :D [16:48:14] brion: so I bet that the flickr implementation was chosen partly because it is also easy to implement :D [16:48:22] yeah [16:48:24] brion: it's a list view of a scroll views with a linear layout [16:48:27] :) [16:48:46] New review: Jdlrobson; "The bottom menu is called activity but this seems weird to me and I want this checked over by design..." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/64821 [16:49:57] hey Steinsplitter [16:49:58] welcome :) [16:50:10] hi :D [16:54:14] hmm [16:54:18] what do i do with a android:layout_gravity="center_vertical|right" [16:54:41] oh! i can add a layout variant for v17+ [16:54:45] mwahahah [16:54:54] ugh maintenance... [16:54:57] brion: nooooo! [16:55:03] where is that? [16:55:11] progress bar in the notification [16:55:23] ahem, we don't actually use the notification layout :P [16:55:24] kill it [16:55:28] i thought i had killed it [16:55:28] oh yay! [16:55:31] just delete the file? [16:55:33] we use the standard android one [16:55:34] yes [16:55:37] double check though [16:55:46] no wait [16:55:49] that's not the notification [16:55:57] that's the category fragment? i don't remember a progress bar [16:56:51] ah that's a circle thingy [16:57:02] brion: aah [16:57:15] brion: I bet there is a gravity 'start' perhaps? [16:57:18] or something like that? [16:57:24] there is, but will it work on <4.2? :P [16:57:48] well only one way to find out [16:57:54] i'll try putting them both in and see what explodes [16:58:07] New patchset: Jdlrobson; "Story 435: Left nav grouping (stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821 [16:58:43] brion: yes, android usually sortof disregards things [16:58:46] brion: if not, it is a bug! [16:58:49] :D [16:58:50] in Android, at least [17:07:10] new xbox is called "xbox one" [17:07:16] shouldn't it be… xbox 3? [17:07:54] brion: XBox(361) == XBox(1) [17:08:00] haha [17:08:37] oh good they haven't done something bizarre with the controller [17:08:48] * brion looks pointedly at nintendo [17:09:01] ok let's try this on android 2.3 [17:10:03] ok it doesn't explode [17:10:06] that's a good sign [17:11:22] heh :D [17:13:22] [android-commons] brion opened pull request #27: Initial RTL layout flipping support (master...rtl) http://git.io/IRpGaQ [17:13:37] i get the occasional crash with an IllegalStateException about the categorization fragment not being attached to an activity [17:13:51] might need to fix some of the background processes, i'll track it down later [17:13:57] brion: how occassional? [17:14:08] more often than i'd like, but not constantly [17:14:33] brion: I'm also not fully happy with how our fragments and activities are coupled [17:14:50] it is also possible, however, that that is just because I spent two days reading UML stuff. [17:15:00] heh [17:15:08] i still have to learn more about fragments, i don't grok it all yet [17:15:37] yeah, they're sortof interesting [17:15:52] they're not exactly just 'views' but more like full fledged activities, except almost not [17:16:05] fun [17:16:29] brion: oh, also, certificate pinning :P [17:17:12] spiiiiiies everywhere [17:17:19] indeeed [17:36:04] hahaha jdlrobson i like the 'you are in the middle of nowhere…' message [17:37:28] ? [17:37:29] does it say 'you are in a small town train station with no tickets out to anywhere'? [17:37:34] also, hi awjr, jdlrobson :) [17:37:37] i'm in the middle of nowhere? :) [17:37:40] hello jdlrobson [17:37:42] er [17:37:44] YuviPanda: [17:37:44] YuviPanda: is back! [17:37:57] awjr: oohh nearby [17:37:58] jdlrobson: in nearby [17:38:02] heheh yeah [17:38:10] :) [17:38:10] yes just a bit of jon robson copy text fun™ [17:38:18] lol [17:38:25] 10 more days before next exam, so relaxing a bit with IRC [17:40:06] YuviPanda: while we've got ya… anything you want to add to the android on the trello backlog list? [17:40:23] brion: oooh, let me look! [17:41:20] brion: ooh, we're 'business class' now [17:41:30] \o/ [17:41:50] i forget what we get for business class other than the warm-and-fuzzy feeling of supporting the nice folks at fog creek with money [17:43:26] brion: commenting [17:43:40] wheee [18:21:41] brion: you might find http://droidparts.org/ interesting [18:21:53] ooh [18:22:10] 'ImageFetcher to asynchronously attach images to ImageViews, with caching, cross-fade & transformation support.' ooh [18:22:12] although standard disclaimers about having to fight becoming GWT / UML Modeler Modelers [18:22:18] brion: we already have that :P [18:22:19] heh [18:22:23] :D [18:22:30] brion: https://github.com/nostra13/Android-Universal-Image-Loader [18:22:33] is what we use [18:22:36] yay [18:22:38] and the guy is *very* responsive [18:22:43] haven't dived into that part much yet [18:22:57] it's pretty nice, but the caching could really use some help [18:23:01] YuviPanda: i assume we're not using the caching yet? [18:23:06] brion: so, we are. [18:23:07] cause as far as i can tell we don't cache anything :D [18:23:12] except... it is sortof not that grea [18:23:15] heh [18:23:33] brion: I've not investigated it exactly, but we do use caching as provided by the library [18:24:07] well, for me it seems to not cache, and loads everything from the network [18:24:16] or else the cache is really slow and doesn't use any storage that i can find ;) [18:25:15] brion: that's both possible [18:25:29] brion: ooh, also, we're using an older version :P [18:25:33] brion: upgrade to latest and see? [18:25:39] ah good [18:25:40] (maven / pom.xml update, simple enough) [18:25:49] YuviPanda: link that in a comment on the card about caching [18:25:57] there's a card on caching? [18:26:01] okay will do [18:26:10] should be one in the backlog [18:26:20] https://trello.com/card/android-cache-thumbnails/517b115c243fd8d361000faa/50 [18:28:09] ooh the new chrome-based opera is out for android: http://my.opera.com/ODIN/blog/opera-14-for-android-is-out [18:28:21] oh good they support 2.3 [18:28:27] :D [18:28:36] nobody does 2.2 anymore [18:28:36] so yay [18:28:41] i'd looooove an updated default browser for 2.3 [18:28:42] sigh [18:41:56] brion: there's also this wonderful open source app called 'RedReader', I should steal their caching code [18:42:11] brion: oh, and you should try RedReader if you haven't. has a 'slide in toolbar' which is very nice [18:42:21] spiff [18:58:40] brion: i'm off to sleep now :) [18:58:58] i'll be around tomorrow too, but not for long. Also I'll be far more responsive on Email starting tomorrow [19:00:08] ok seeya later :) [19:12:10] "Yet we also want to move ahead and take advantage of modern browsers, especially the growing mobile market." lolz [19:12:17] wrong lolz [19:12:18] My website is in China and 22 percent of our users are still using IE6! Seems like some sort of human rights violation. Oh, and that wasn’t a question. [19:12:26] http://blog.jquery.com/2012/07/01/jquery-1-9-and-2-0-tldr-edition/ < [19:39:00] awjr: we should try out poetica for your blog post :) [19:39:16] awjr: perfect for this sort of thing! [19:39:33] yeah! can we? [19:39:47] i dont think i have an account yet (requested one a while back) [19:40:30] awjr: i'll invite you :) [19:40:35] \o/ [19:40:43] gmail or wikimedia ? [19:40:59] gmail plz [19:41:19] awjr: should have an invite [19:41:21] let me know if you don't :) [19:41:24] w00t thanks jdlrobson [19:42:23] [android-commons] brion pushed 6 new commits to master: http://git.io/SRwowA [19:42:23] android-commons/master 95ebe86 Brion Vibber: add RTL support to manifest... [19:42:23] android-commons/master 142ee8f Brion Vibber: Update build target to rev 17 (needed for RTL flipping) [19:42:23] android-commons/master a5017bb Brion Vibber: LTR and RTL versions of standard 'send now' action bar icon [19:43:04] mhurd: how's the animation going? :D [19:43:05] awjr: did you get it? [19:43:50] still waiting jdlrobson [19:44:11] jdlrobson: but im going to start prepping for deployment now; i'll check it out later [19:44:18] mmm [20:09:02] sorry folks, running into some deployment snaffus with the new deployment system [20:09:08] uhoh [20:09:53] awjr, neeed help? [20:10:24] MaxSem: getting a permissions error - see #wikimedia-tech [20:12:18] roan's looking into it [20:15:54] ok problem resolved [20:16:47] running sync-common on testwiki... [20:27:32] my upload count doesn't appear to be updating on testwiki; but i wonder if it might not work correctly on local uploads or testwiki in general (and be fine in prod) [20:28:01] i never get it to work consistently on testwiki [20:28:28] it's also wonky on betalabs; but hopefully will be fixed when we get uploads to betacommons working [20:28:37] yup [20:29:10] brion: sry didn't see you msg - changed irc clients and didn't have it configured to alert properly :( [20:29:17] no worries :D [20:29:23] brion: animation going really well! [20:29:32] cool [20:29:40] when you're near done i'll steal the assets and start on the android version :) [20:29:55] brion: sounds good! [20:37:42] awjr: are we supposed to be testing? [20:37:52] ! [20:37:54] yes [20:38:15] infinite spinner in userlogin [20:38:23] testwiki weirdness, I guess [20:38:34] MaxSem: during the handshake? [20:38:44] probably [20:39:19] i've seen that in the past, but intermittently; im not having any login probs [20:42:07] hmm what happened to michelle? [20:42:43] everything is look OK to me on testwiki, or at least nothing unusual - MaxSem, jdlrobson, jgonera - everything looking ok for you? [20:42:54] still checking [20:43:05] coolcool [20:43:39] i missed the call to begin testing! looking now [20:47:43] jcmish: think you might've missed it but yes, we're testing now [20:47:49] awjr: looks good to me [20:47:57] \o/ [20:49:13] hehe I checked [20:49:16] and it looks good [20:49:48] ok - i'm going to push if there are no objections MaxSem, jgonera, jdlrobson, jcmish [20:50:07] lgtm [20:50:08] awjr, everything seems to look ok [20:51:23] cool [20:55:24] ok, scapping [20:57:48] New patchset: Jdlrobson; "Make nearby a discovery tool" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64820 [20:57:48] New patchset: Jdlrobson; "Story 435: Left nav grouping (stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821 [21:11:06] jdlrobson, jcmish, jgonera, MaxSem: scap is complete; changes should be live in production [21:11:39] k checking [21:11:43] dr0ptp4kt: yurik (in case there were any zero changes) ^ [21:12:27] awjr: looks like the js has not updated yet [21:12:31] old js being served :-S [21:12:41] give it a few mins jdlrobson [21:13:00] yep just saying in case someone thinks we are broken (works with debug=true) [21:13:25] totes [21:14:44] looks good to me [21:16:25] WIN [21:16:43] waiting on last automation test to finish [21:16:46] so far so good [21:19:10] jcmish: https://commons.wikimedia.org/wiki/File:Two_dogs_napping-_2013-05-21_14-17.jpg [21:19:26] HAHAHHAHAHHA [21:19:26] and upload count seems to be working right in prod [21:19:38] look at the joy! [21:19:38] jcmish: this one's cooler: https://commons.wikimedia.org/wiki/File:Emma_looking_cool-_2013-05-14_15-06.JPG [21:19:45] and yup counts are right [21:19:57] Poor Emma [21:20:09] hahaha [21:20:15] she's gonna think those are hers [21:20:20] lol [21:20:23] and chew em! no one's fault but yours [21:20:53] hahah one thing i have to give her credit for is she is not much of a chewer [21:21:02] [android-commons] brion opened pull request #28: Kill beta labeling; include icon assets in scratch (master...killbeta) http://git.io/0m8aJQ [21:21:06] at least, not of things that are not explicitly given to her for chewing [21:22:20] all tests are green [21:22:25] I say we're all set [21:22:52] wow, smooth deployment! [21:22:55] good job, everyone :) [21:24:57] awjr, thanks a lot for taking care of it [21:25:03] no problem, MaxSem [21:26:38] MERGE UNFREEZE! [21:27:29] lgtm [21:27:40] jdlrobson, yurik: seems to be working normally. thanks! [21:35:50] New review: Dr0ptp4kt; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64548 [21:35:58] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64548 [21:36:39] MaxSem: thanks for the help with the diff stuff - gonna take a look at that now and see if i can get some tests written [21:37:04] welcome - poke me if more help is needed [21:41:25] jdlrobson: regarding your questions at MediaWiki:Mobile.css. [21:42:38] I assume the selectors related to IPA have to do with the International Phonetic Alphabet styling that is present in a lot of articles. [21:43:02] That could be any number of pages. [21:46:00] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64634 [21:50:34] New patchset: MaxSem; "UserLogin --> Userlogin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64865 [21:55:44] StevenW: OK to give some background I'd like better documentation to see if there are any candidates for upstreaming [21:55:55] I was also talking to Juliusz about allowing css per namespace [21:56:08] Gotcha. I wasn't sure if you were actually asking what those were for, if you were just asking for docs from ppl [21:56:09] I personally don't like adding unnecessary CSS to pages which don't need it [21:56:28] just more background so when we encounter bugs like one minor one we encountered today we can understand the damage [22:39:29] dr0ptp4kt: Question about new configs [22:39:57] dfoy, how may i help? [22:40:10] New patchset: Jdlrobson; "Alpha: Use diff page for history" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63908 [22:40:11] New patchset: Jdlrobson; "Redirect page diffs to Special:MobileDiff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63907 [22:40:11] ^ MaxSem :-D [22:40:37] dr0ptp4kt: It appears that if I don't specify a banner translation, one is drawn from some other source [22:41:11] dr0ptp4kt: not sure where that is or if it can be relied on. Any idea what this would be? [22:43:19] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64865 [22:43:49] New patchset: Jdlrobson; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608 [22:44:55] you're referring to the configuration element named 'banner', correct? iirc, it falls back to the default english translation. [22:46:16] dr0ptp4kt: Here's an example, http://meta.wikimedia.org/wiki/Zero:624-02 'eo' is whitelisted but no translation is present. If I see the banners on the page, it does show a translation [22:50:07] [android-commons] brion opened pull request #29: i18nize 'Download' menu item (master...i18n-fix) http://git.io/HJZpGw [22:50:31] [android-commons] brion pushed 2 new commits to master: http://git.io/oBSojQ [22:50:31] android-commons/master f24e013 Brion Vibber: i18nize 'Download' menu item [22:50:31] android-commons/master 8589aaa Brion Vibber: Merge pull request #29 from brion/i18n-fix... [22:54:21] New patchset: MaxSem; "Redirect page diffs to Special:MobileDiff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63907 [23:17:57] dr0ptp4kt: Hey Adam, I'm going to hold off from completing the setup on the 2 new partner config pages for today. I have placeholders in but I want to check things closely before it gets used to setup changes in varnish. [23:18:43] dfoy, thx. [23:31:23] tfinc one sec need to grab a glass of water [23:31:30] awjr: k [23:51:45] yurik & dr0ptp4kt, do you need my help during tomorrow's deployment? [23:53:55] MaxSem, i think yurik is sleeping right now. i will speak for him on this one: yes, your help would be appreciated. he's planning to deploy at the normal time. [23:54:12] from AMS?:) [23:54:25] MaxSem, yes! [23:54:27] I thought he's flying there soon [23:54:59] MaxSem, yeah, i think may already be in town. [23:56:52] dfoy, the general gist of the fallbacks is this. the Zero:XYZ-AB configuration pretty print renderer (as well as actual articles on zero-rated domains) will merge each language *code* found in 'name', 'banner', 'showLangs', and 'whitelistedLangs' into one list. with that list of language codes, it will try to generate as many banners as possible given the data that's already present. if it can't find a piece of information (e.g., there is no [23:56:52] entry in 'banner), it will then go to the localization cache to look for the next closest language, and it will try to see if it can find the missing piece of information from the JSON configuration corresponding to that fall back langauge. if it can't manage to find a fallback language that has a matching JSON configuration entry, then it will fall back to using the known 'en' value from the ZeroConfig.i18n.php file, which you can find in [23:56:53] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ZeroRatedMobileAccess.git;a=tree;h=refs/heads/master;hb=refs/heads/master. [23:57:03] dfoy, that's the 'simple' version ;) [23:58:38] dr0ptp4kt: cool - that's helpful to know. I won't have to piece the information together by hand from the same sources it would use anyway