[00:18:27] ecmabot-wm: commands [00:18:59] dfoy, for the sake of completeness, you can find language fallbacks in MediaWiki core. Go to languages/messages/MessagesGl.php to see an example of the fallback for language code 'gl'. it falls back to 'pt'. you can get to the latest core code from https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=tree;h=refs/heads/master;hb=refs/heads/master . yeah, fortunately, shouldn't be a need to piece together much of anything. i'll email yo [00:18:59] the current fallbacks based on a quick grep, simply because it's easy to grep! [00:20:48] dr0ptp4kt, great, thanks! [01:19:11] New patchset: Jdlrobson; "Redirect page diffs to Special:MobileDiff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63907 [01:20:26] New patchset: Jdlrobson; "Alpha: Use diff page for history" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63908 [01:27:10] New patchset: Jdlrobson; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608 [01:27:11] New patchset: Jdlrobson; "Adding interstitials for MobileFrontend 'Read in other language' section and footer." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63811 [01:28:20] New patchset: Jdlrobson; "Make sure banners are declared for purpose of desktop skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64879 [01:30:59] Change abandoned: Jdlrobson; "I think I made my point to Max, there's a bug open (bug 48551) and it references to this so no point..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64104 [01:32:17] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [01:32:47] New patchset: Jdlrobson; "Make nearby a discovery tool" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64820 [02:32:45] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/64820 [03:30:24] New review: Yurik; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -1; - https://gerrit.wikimedia.org/r/55813 [09:33:27] New review: Yurik; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -1; - https://gerrit.wikimedia.org/r/64608 [09:42:48] New review: Yurik; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -1; - https://gerrit.wikimedia.org/r/63811 [12:14:18] New patchset: Yurik; "Fixed last patch I853496a860742ba906b756b26f4c13b51bacb82f" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64920 [15:32:37] * MaxSem waves to yurik [16:28:48] * yurik waves back at MaxSem [16:29:29] aadam said you need help with deployment [16:29:56] (fraking sony keyboard) [16:30:29] yurik, ^ [16:30:57] hey MaxSem ! [16:31:45] well, i would like to deploy stuff, but the patches need to be fixed first as they have errors [16:31:54] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64820 [16:31:59] o_0 [16:32:31] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608 [16:32:42] i can still deploy, just without them :) [16:32:51] adam is not going to be happy :) [16:34:05] uh https://gerrit.wikimedia.org/r/#/c/64920/1/includes/CarrierConfig.php [16:34:12] that ternary is evil [16:34:51] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64920 [16:35:04] yurik, so you want to meet for deployment? [16:35:09] New patchset: Jdlrobson; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608 [16:57:48] New patchset: awjrichards; "Story 435: Left nav grouping (stable)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821 [16:58:22] jdlrobson, saw your patch, i can't commit until adam fixes his [16:59:01] jdlrobson, or if you tell me if the removal of the blank array is intentional [16:59:08] in his patch [17:06:46] sorry for yelling at the dogs through the mic - total reflex; should have muted - MaxSem i hope i didnt make you deaf [17:07:10] I wasn't wearing headphones [17:23:59] brion: given your travel which of the upcoming standups will you make it to ? [17:24:32] less… stand ups are … 19:15 in CEST? [17:24:43] can almost certainly do friday, we'll see what schedule looks like next week [17:24:50] if i can't come i'll send updates by email as usual [17:25:24] *lessee [17:26:21] ok gotta finish packing for the trip, i'll check in on irc later :D [17:29:39] tfinc: heading upstairs [17:34:13] mhurd: the white on white here is really hard to read https://trello.com/card/ios-use-featured-image-on-login/519a5940b8eb98591c000adf/41 [17:34:16] mhurd: cool [17:34:19] New patchset: Yurik; "Adding interstitials for MobileFrontend 'Read in other language' section and footer." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63811 [17:35:48] tfinc: back downstairs - they're mia. [17:36:05] mhurd: the white on white here is really hard to read https://trello.com/card/ios-use-featured-image-on-login/519a5940b8eb98591c000adf/41 [17:36:52] the white-on-white should be pretty easy to fix with same shading/shadow trick the bottom left "i" icon uses [17:37:56] yurik, about to vagrant up to check it [17:38:11] dr0ptp4kt, cool [17:38:45] yurik, will also pull it down to apibeta [17:38:54] ok [17:41:36] yurik, it's working on apibeta. uno momento on vagrant [17:42:41] awjr: blaine managed to fix the overlapping text bug :) [17:42:53] ha! sweet jdlrobson [17:43:36] yurik: removal of blank array is not intentional - i got some rebase weirdness [17:43:43] it seemed to be in the commit before [17:44:20] ok, but should it be removed? [17:44:36] in other words - is it ok to go in as it is right now? [17:44:39] dr0ptp4kt, ^ [17:44:42] yurik, it's working in vagrant as well. [17:44:51] ok, so +2 it [17:46:10] yurik: https://gerrit.wikimedia.org/r/#/c/64608/4/includes/PageRenderingHooks.php should be only changed needed i introduced [17:46:43] jdlrobson, ??? [17:47:17] jdlrobson, WAT? I have no clue what you just said :) [17:47:38] yurik: you've successfully confused me with talk of a blank array that has nothing to do with me :) [17:47:39] dr0ptp4kt, did you +2? [17:47:51] yurik, just did [17:47:52] great, its all my fault again [17:48:15] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/63811 [17:48:24] dr0ptp4kt, can jdlrobson's patch go in as well? [17:49:33] yurik, checking 64608 [17:49:43] jdlrobson, dr0ptp4kt , I just rebased your change [17:49:47] New patchset: Yurik; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608 [17:51:28] yurik, i believe we should hold off on 64608 for the next deployment. [17:51:36] dr0ptp4kt, ok [17:52:29] New patchset: Jdlrobson; "Beta: Story 435: Left nav grouping" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821 [17:53:09] New patchset: Jdlrobson; "Beta: Story 435: Left nav grouping" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821 [17:54:09] dr0ptp4kt: when's your next deployment? [17:54:33] jdlrobson, wednesday next week. cc: yurik [17:54:38] dr0ptp4kt: why wait then? [17:54:45] is there one today? [17:54:57] jdlrobson, doing it RIGHT NOW, 5 min left [17:55:02] haha [17:55:10] exactly [17:55:14] one word of caution - make sure 64608 gets merged before the MobileFrontend one [17:55:27] if next deployment is wednesday you might want to make it tuesday instead [17:55:54] i wouldn't merge it today though as i suspect with existing MobileFrontend code you will have the banner twice [17:56:23] New patchset: Jdlrobson; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608 [18:01:42] jdlrobson, good to know, will push it out in the next few days [18:01:51] dr0ptp4kt, just finished syncing [18:02:41] yurik, okay gimme a few minutes [18:02:55] dr0ptp4kt, no rush, don't be late to your flight [18:05:11] MaxSem: is https://gerrit.wikimedia.org/r/#/c/63907/ ready to go out? I got confused as Gerrit tried to merge it yesterday but I couldn't see the +2 that caused that attempt [18:05:30] (This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.) [18:06:09] I think it is - did anyone review it? [18:07:04] that patchset doesn't appear to have ever been +2'd [18:08:11] dr0ptp4kt, aaa [18:08:26] the confirmation boxbegan showing up [18:08:33] with an optional "close" [18:08:37] aaaaaaa [18:08:56] yurik, for which url and x-cs? [18:09:04] zero.en, 250-99 [18:11:36] yurik, will call after i get through the line. [18:11:49] dfoy, debating a revert [18:12:08] yurik: what is the issue? [18:12:29] pls check - the confirm pay-site (outside redirect, etc) began showing "hide" box [18:17:36] MaxSem: it wasn't clear to me if it got reviewed by you - it might be gerrit being confusing [18:18:01] dfoy, do you see the issue? [18:18:39] jdlrobson, I reviewed it, but since I'm now also involved I'd like someone else's eyes on it [18:18:57] i can take a look in a bit [18:19:15] yurik: What are repro steps? [18:20:01] dfoy, navigate to any zero site, click on "show in other lang", or any other link that would cause switchover to pay mode [18:20:21] (show image, external link, etc) [18:20:36] i see the "hide" message box at the top right [18:20:49] even though warnings are not suppose to be hidable [18:21:29] yurik: yes I see it as well [18:21:40] MaxSem: np [18:23:44] yurik: What's also a problem is that it isn't even supposed to show up. I used Digi which has all languages whitelisted and did read article in another language [18:24:11] yurik: also banner color was not red, but standard orange [18:26:38] dfoy, talking to adam on the phone [18:31:01] yurik: also noticed that for zero-only partners, clicking on image link the banner shows up in correct red color and no hide box [18:31:32] dfoy, debating full rollback, not worth it [18:31:44] not worth - debuggig in productio [18:32:00] yurik: agreed, if this is not extremely obvious fix then lets revert [18:32:06] ok [18:32:19] jdlrobson: around? [18:47:30] jdlrobson: is there a way to file bugs on poetica ? [18:47:46] i'm getting a 'Something's gone wrong!' page [18:48:58] tfinc: support and feedback link in lower left [18:49:22] awjr: due to the error that i'm seeing i don't even get that far [18:49:27] oh :( [18:49:32] tfinc: is Jared on IRC? [18:49:42] Direct or UX Jared ? [18:49:58] UX [18:50:02] there's a 'Direct' Jared? [18:50:10] oh [18:50:10] wait [18:50:13] Director UX you meant [18:50:18] yes [18:50:18] him [18:50:46] I just messaged him to join [18:50:51] lets see if he bites [18:50:56] YuviPanda: see my message about glass ? [18:51:06] on Facebook? [18:51:07] yes :) [18:51:18] tfinc: any way we can get my hands on a Unit? [18:51:26] or even if they have plans of a simulator [18:51:27] or something [18:51:47] argh jdlrobson i've made a ton of changes to the draft in poetica, but i can't copy/paste the text to another app and when i 'export' the draft, it exports a version that contains NONE of the changes i've made over the last hour :( [18:51:48] I spent 30 mins today drawing up plans for a 'Wikipedia Now', should put them up tomorrow [18:52:08] tfinc: ^ [18:52:52] YuviPanda: is there no emulator yet ? [18:52:57] tfinc: nope [18:53:10] tfinc: not even a simulator. [18:53:28] tfinc: closest is base_css that simulates how the cards in Glass will look like [18:53:36] (and a 'playground' based on said CSS) [18:53:37] but nothing more [18:54:13] New patchset: JGonera; "(Story 486) Add new editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64466 [18:54:44] tfinc: a few other people have added ideas to https://www.mediawiki.org/wiki/User:Yuvipanda/Glass_apps :) [18:55:58] yurik: Any idea on the timing for the revert? [19:00:33] YuviPanda: good. this strengthens my case to google in order to get glass. keep them coming [19:00:47] :) [19:09:24] New patchset: JGonera; "Run all mobile QUnit tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64972 [19:11:09] YuviPanda: i'm not seeing anything when i load http://mobile-reportcard.wmflabs.org/ . ideas ? [19:11:16] jgonera: ^ [19:11:52] jgonera: want to merge https://gerrit.wikimedia.org/r/#/c/64885/ for now so that tfinc can get his stats? [19:12:04] yes, it's broken now because Dan "fixed" the way we generate some files ;) I was going to fix it today but I wanted to talk to him first. Unfortunately, I don't see him online [19:12:37] yeah, I saw that thread. [19:12:52] so is that 'yes' for 'merge this now'? :P [19:12:56] ok, let's merge this for now [19:12:57] yes [19:13:49] jgonera: sweet. you'll also need to do a deploy once this gets merged [19:13:56] right [19:14:48] YuviPanda: mail jared. he's occupied right now [19:15:04] tfinc: nothing in particular, actually. Just wanted to know if he hangs out on IRC [19:15:17] YuviPanda: generally no [19:15:21] tfinc: I hope he turns up and idles, at least. People who are not on IRC are essentially cut off from our remoties :( [19:16:02] do ask him to idle on, if possible. [19:16:09] sure [19:17:00] hm, I deployed but it doesn't work... I vaguely remember that kripke was not the server we were using anymore but fabric deployed to kripke [19:17:07] wait, maybe I'll update limn-deploy [19:18:07] "ln: failed to create symbolic link `/var/lib/limn/mobile-reportcard/data/geo/mobile': File exists" :/ [19:22:38] tfinc, something's messed up with limn on the new server, I don't think I'll be able to fix it without Dan, not without wasting a whole day on it anyway [19:23:02] jgonera: ok. mail diederik and let him know [19:26:58] tfinc, done [19:31:20] jdlrobson: when you have a chance can you email the list about the outcome of your mtg about the blocked cards? [19:31:31] awjr: Howie is updating the card [19:31:36] is that not enough? [19:31:50] seems like the route of less confusion [19:32:13] i think that's fine jdlrobson [19:32:18] sweet [19:35:29] jgonera: did we change the data window on mobile-report to be monthly and not trailing 30 day ? [19:36:06] tfinc, no, not yet, I'm working on that now, but won't be able to deploy until Limn is fixed on the server [19:36:10] k [19:36:34] oh, wait, it seems to work now [19:37:55] the deploy command still gives me errors though [19:41:59] awjr: i can load lots of other drafts on poetica but can't load yours [19:44:02] tfinc yeah mine is totally f'd [19:44:20] im working with the poetica devs to get it sorted [19:47:59] i just tried to start a new draft and i cant' write anything in the body [19:48:01] just title [19:48:12] it seemed to working great yesterday :p [20:03:04] jdlrobson: so my automatic GitHub -> GerritPatchset bot is all set up and automatic now :) [20:03:12] is enabled for qa/browsertests. let me know if you want it enabled for MB [20:03:13] err [20:03:14] MF [20:04:44] jdlrobson: prioritization meeting? [20:05:07] jdlrobson: also can you grab howie i dont see him online [20:07:12] jgonera: ^^ [20:07:50] awjr: looking for howie and there was someone in our room and technical difficulties but loading up now [20:07:58] kk [20:24:00] jdlrobson: so, MobileFrontend now has GitHub Pull Requests -> Gerrit Patchsets enabled. [20:35:29] i'm going to go off to sleep [20:35:35] hopefully don't wake up to pitchforks on wikitech-l [20:37:09] YuviPanda: \o/ [20:37:16] jdlrobson: try it out! [20:37:22] jdlrobson: no comment syncing yet [20:37:29] and it's pretty fast. [20:37:33] YuviPanda: night Yuvi. good seeing you and nice job on the github patch feature [20:37:42] :D [20:37:47] i'm eager to see people use it [20:37:50] me too! [20:42:20] jdlrobson: try to use it and see if you like the current workflow ;) [20:42:21] nite [20:54:10] Change abandoned: Jdlrobson; "Abandoning after discussion with product" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64619 [21:31:26] Change abandoned: Jdlrobson; "Doing this in another patchset after discussion with product" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64618 [21:41:03] btw tfinc have you noticed fun things like = https://en.wikipedia.org/wiki/Special:MobileDiff/534318598, https://en.wikipedia.org/wiki/Special:MobileOptions and https://en.wikipedia.org/wiki/Special:Uploads? [21:41:07] (desktop browser required) [21:41:38] jdlrobson: diff page itself or specifically the coloring ? [21:41:46] the fact that these are all running on desktop [21:41:57] you might need to turn off that chrome extension :) [21:42:05] ahh. i wouldn't know as i'm in mobile always mode [21:42:18] nice [21:43:02] interesting the desktop version of uploads uploads to local wiki.. might want to change that [21:43:27] jdlrobson: but its count is for more [21:43:35] i see four of my photos but the count is 120 [21:43:38] tfinc: yeh confusingly count comes from commons [21:43:43] the list comes from local wiki [21:44:31] jdlrobson: does the watchlist work on desktop ? [21:44:42] no but it could [21:44:49] it's because we use the same special page [21:45:12] We should make Special:MobileWatchlist an alias to our mobile version [21:45:34] no reason it shouldn't work with vector [21:45:39] same html as nearby after all [22:17:52] New review: Jdlrobson; "MaxSem: jdlrobson, I reviewed it, but since I'm now also involved I'd like someone else's eyes on it" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/63907 [22:36:20] jdlrobson: why use the '…' notation for the mobile diff? [22:36:56] (particularly as opposed to how the diff pages work right now) [22:37:51] awjr: I had this discussion with jgonera - I believe a lot in readable urls and since diffs are a programming thing it made sense to me at least to be consistent with things like git [22:38:13] but i'm open to another url pattern if you have a better suggestion [22:38:40] i think it would be prudent to stay consistent with the current approach in MW [22:39:34] unless there's a particularly compelling reason not to [22:40:09] in this context, diffs are not a programming thing and while in some cases i think it's a very good idea to drift away from how MW does things, i do not think that is the case here [22:40:16] awjr: the current approach is sucky though [22:40:24] how? [22:40:26] ?diff=prev&oldid=5 [22:40:28] that is broken [22:40:43] how? [22:40:44] the old id is actually the revision before 5 [22:40:58] it's semantically incorrect and bothers me and i see this as an opportunity to fix [22:41:01] yeah it's not particularly semantic [22:41:14] well, this isn't fixing it, it's totally changing the behavior [22:41:20] and it's doing it unilaterally [22:41:20] awjr: no [22:41:36] i'm not changing any behaviour [22:41:49] i'm just presenting the url in a nicer form that a human brain can wrap there head round [22:41:59] 1…3 is the difference between revision 1 and revision 3 [22:42:08] If you can easily tell me what diff=8 [22:42:15] &old=50 means [22:42:16] I'll stand down [22:42:32] (and diff=next&oldid=130 [22:42:50] awjr: It's our page we can do what we want with the urls - I say we do this [22:42:52] well you wouldnt get diff=8&oldid=50 [22:42:58] but i understand your point [22:42:59] awjr: you can [22:43:05] reverse diff [22:43:14] 50…8 in our system [22:43:48] yeah, ok i meant from a history page or something [22:44:03] I'm happy to change the … to something else but I'd rather we didn't introduce query string parameters [22:44:19] i'm a strong believer in nice logical urls [22:44:32] there are indeed a lot of advantages to no qs params [22:44:51] aside from human grokkability; caching [22:46:04] ok, let's throw it out there. it's new enough that it will be easy to change if need be/desired and could be seen as worth incorporating into core mw [22:46:18] awjr: +1 i'd love to upstream :) [22:46:27] I think MobileDiff is better than the existing diff view anyway ;-) [22:47:07] yeah, my main concern is drifting to much from core functionality; but in cases where there's a good possibility of upstreaming smoething better, it's cool [22:47:37] now that i've looked through the code lemme do some testing [22:48:22] although [22:49:01] the way the logic is written in SpecialMobileDiff, if you had smoething like Special:MobileDiff/123…456…789 you'd only ...123 [22:49:07] is that intentional? [22:50:34] jdlrobson: also if you were to do Special:MobileDiff/...123 you would get …123 which is different than what you would expect from git behavior [22:50:46] same with Special:MobileDiff/123... [22:50:58] yeh your right should probably add some test cases for those.. [22:51:13] I hadn't thought of those edge cases [22:51:16] if we're going to emulate git behavior, let's do it all the way :) [22:51:20] i dunno if those are edge cases [22:51:32] actually yeah they are [22:51:39] because you'd have to manually type in a range like that [22:51:45] awjr: yup [22:51:50] but it's something i bet a lot of folks would do esp seeing the git syntax [22:52:00] but they are valid - we could 404 for the time being [22:52:22] …123 for example does that mean previous or initial revision ? [22:52:28] initial [22:52:35] in git parlance [22:52:44] and 123… means current [22:53:40] mmm git diff d4efc669a2d5c06b6dc17e78b20cd8869fc63292... does something else for me [22:53:52] it should diff against head [22:54:02] or to head [22:54:10] i'd rather just 404 for time being [22:54:17] seems like a fun future exercise but we can live without it [22:56:48] well you have to put in some extra logic anyway to catch those cases, but i dunno what the Revision class supports [22:56:48] awjr: yup i'll put some logic to 404 with FIXME's for future.. [22:56:49] kk [22:56:49] i'll add some comments for reference on the patchset [22:57:26] sweet thanks! [22:59:21] New review: awjrichards; "The logic in Special:MobileDiff won't handle cases such as Special:MobileDiff/...123 or Special:Mobi..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63907 [22:59:54] jdlrobson: i think you'd need to add some new magic to the Revision class to get the initial revision id [23:00:26] ok [23:00:42] just got to go see vibha