[00:04:16] <awjr>	 jdlrobson: can you look at https://gerrit.wikimedia.org/r/65163 ? this should fix the problem
[00:04:30] <gerrit-wm>	 New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/65163
[00:04:43] <jdlrobson>	 hah already did awjr few issues ^
[00:05:31] <jdlrobson>	 awjr: I assume http://localhost/w/index.php?title=New_page&oldid=2611 should redirect to MobileDiff/2611 ...
[00:08:32] <jdlrobson>	 awjr: any way we can keep the redirect tests in MobileContextTest they seem useful for this reason..
[00:09:16] <gerrit-wm>	 New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65163
[00:20:34] <awjr>	 jdlrobson: RE how i changed the tests… the original set of tests were not actually unit tests
[00:21:02] <awjr>	 but, what's missing from the updated tests?
[00:21:31] <awjr>	 mobile vs non-mobile redirection?
[00:22:14] <gerrit-wm>	 New patchset: awjrichards; "Move desktop->mobile diff redirect logic from to Special:MobileDiff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65163
[00:22:25] <awjr>	 jdlrobson: ^ fixes the new pages issue
[00:25:04] <gerrit-wm>	 New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65163
[00:25:18] <awjr>	 jdlrobson: probably burried in gerrit interface but i responded about the tests ^
[00:25:59] <awjr>	 jdlrobson: i need to go focus on some other stuff for the rest of the day and i am not going to pay very close attn to IRC
[00:26:01] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65163
[00:26:06] <jdlrobson>	 np i just merged awjr
[00:26:12] <awjr>	 w00t
[00:26:14] <awjr>	 thanks jdlrobson
[00:26:18] <gerrit-wm>	 Change abandoned: Jdlrobson; "not needed. jenkins is happy again." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65161
[00:26:30] <awjr>	 yay jenkins isn't barfing anymore
[00:29:54] <gerrit-wm>	 New patchset: JGonera; "(Story 486) Add new editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64466
[00:39:47] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64466
[00:40:29] <gerrit-wm>	 New patchset: Jdlrobson; "Treat template banner data as an array." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65138
[00:40:42] <gerrit-wm>	 New review: Jdlrobson; "rebased recheck jenkins! recheck!" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/65138
[00:40:57] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65138
[00:49:01] <gerrit-wm>	 New review: JGonera; "Last modified doesn't show up for me at all." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/63908
[00:55:14] <gerrit-wm>	 New patchset: Jdlrobson; "Alpha: Use diff page for history" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63908
[00:59:32] <gerrit-wm>	 New review: JGonera; "There are some small 1-2px glitches. Also, menu headings' font is a bit too small (comparing to jsfi..." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/64821
[01:10:37] <gerrit-wm>	 New review: JGonera; "The name $breadcrumbs (and .breadcrumbs) is confusing. Can we change it? Other than that, LGTM." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/63908
[04:32:59] <gerrit-wm>	 New patchset: Yurik; "Consolidated config, fixed bug in addWarning()" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/65164
[08:46:29] <brion>	 hey all
[08:52:32] <YuviPanda>	 hey brion
[08:52:33] <YuviPanda>	 :)
[08:52:37] <brion>	 YuviPanda: yo :D
[08:52:47] <YuviPanda>	 having fun at AMS?
[08:52:55] <brion>	 so far… hackathon's just starting
[08:53:02] <brion>	 spent most of yesterday recovering from the flight :P
[08:53:12] <YuviPanda>	 :)
[08:53:13] <YuviPanda>	 nice
[08:53:19] <YuviPanda>	 whatcha planning on working on?
[08:53:41] <brion>	 whatever interesting comes up, or more commons android work :)
[08:53:44] <YuviPanda>	 :D
[08:53:45] <YuviPanda>	 nice
[08:53:57] <brion>	 did you see the design for the intro pages? monte's working on the iOS implementation
[08:54:04] <YuviPanda>	 no, not in detail
[08:54:15] <brion>	 lemme take a screencast on the simulator
[08:54:16] <YuviPanda>	 brion: i've been neck deep in the github to gerrit bot
[08:54:18] <brion>	 it's pretty spiffy
[08:54:20] <brion>	 nice :D
[08:57:09] <brion>	 YuviPanda: https://brionv.com/misc/commons-intro.mp4
[09:12:42] <brion>	 YuviPanda: I noticed that the 'up'/back arrow on the action bar in detail view disappears if i rotate the screen
[09:12:47] <brion>	 any ideas offhand before i dig in?
[09:20:46] * brion  waves tfinc 

[09:59:44] <jerith>	 yurik: Where do I find the API code?
[09:59:52] <jerith>	 I want to look at what it's doing.
[10:01:07] <brion>	 jerith: the mediawiki server api code, or client code?
[10:01:27] <wikipedia-github>	 [android-commons] brion opened pull request #30: Fix for actionbar 'up' fix when rotating (master...upfix)  http://git.io/_cdgUw
[10:01:50] <jerith>	 brion: Server. yurik's sorting me out, though.
[10:01:56] <brion>	 ok
[10:02:00] <jerith>	 He's sitting right next to me. :-)
[10:02:03] <brion>	 \o/
[10:02:42] <wikipedia-github>	 [android-commons] brion pushed 2 new commits to master: http://git.io/UMLfXw
[10:02:42] <wikipedia-github>	 android-commons/master c7f8186 Brion Vibber: Fix for actionbar 'up' fix when rotating...
[10:02:42] <wikipedia-github>	 android-commons/master e6fd988 Brion Vibber: Merge pull request #30 from brion/upfix...
[10:03:40] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Make addWarning() return the provided link if no pattern match." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/65238
[10:12:37] <wikipedia-github>	 [android-commons] brion opened pull request #31: Fix for crash report if network down when upload starts (master...upload-fail-fix)  http://git.io/7GrMZg
[10:12:57] <wikipedia-github>	 [android-commons] brion pushed 2 new commits to master: http://git.io/eF_9LQ
[10:12:57] <wikipedia-github>	 android-commons/master c1191ac Brion Vibber: Fix for crash report if network down when upload starts...
[10:12:57] <wikipedia-github>	 android-commons/master 830545a Brion Vibber: Merge pull request #31 from brion/upload-fail-fix...
[10:48:24] <gerrit-wm>	 New patchset: Yurik; "Consolidated config, fixed bug in addWarning()" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/65164
[11:24:28] <liangent>	 how do you test pages for iphone/safari without a physical iphone around?
[11:27:19] <jerith>	 liangent: Someone just mentioned http://iphone4simulator.com/ in my work channel, but I have no idea what that's actually doing.
[11:27:59] <jerith>	 Apparently the site they wanted to test is broken in there, but broken differently from an actual iPhone.
[11:30:00] <YuviPanda>	 liangent: you can also find someone with a simulator :P
[11:30:16] <YuviPanda>	 liangent: also saucelabs
[11:31:39] <liangent>	 jerith: that website is actually loading my website in an iframe, then give that iframe an iphone border
[11:32:06] <jerith>	 liangent: Ah. So it's just testing sizing or whatever.
[11:34:22] <liangent>	 YuviPanda: the actual case: someone is saying a page on zhwiki is not rendered properly on iphone/safari, and I have no idea how to debug it
[11:34:45] <liangent>	 I guess I don't know what to do even I have an iphone in hand
[11:34:55] <YuviPanda>	 ah hmm
[11:35:04] <liangent>	 because there's no handy element inspector etc on it...
[11:35:06] <jerith>	 I have an iPod Touch handy if that helps.
[11:35:28] <jerith>	 liangent: Are you at the Amsterdam hackathon?
[11:36:05] <liangent>	 jerith: no
[11:36:19] <jerith>	 Then my iPod won't help you. :-/
[11:36:34] <YuviPanda>	 aw
[11:36:39] <YuviPanda>	 liangent: there's an inspector available
[11:36:53] <YuviPanda>	 since iOS 5.x I think
[11:41:01] <liangent>	 anyway is there any known mediaquery related issue on iphone?
[11:41:20] <liangent>	 they say this css is problematic https://zh.wikipedia.org/wiki/MediaWiki:Common.css/mp-2012.css
[11:41:49] <YuviPanda>	 jdlrobson or jgonera would be the people to know
[11:41:54] <YuviPanda>	 and neither of them are online ;(
[11:41:55] <YuviPanda>	 SF
[11:41:57] <YuviPanda>	 time
[11:42:19] <liangent>	 so they must be sleeping
[11:47:11] <YuviPanda>	 liangent: yeah
[11:51:50] <jerith>	 MaxSem: Ping?
[11:52:31] <jerith>	 It looks like the MobileFrontend extracts API is including link text in the plaintext response.
[11:54:31] <jerith>	 Hrm. It's including " [edit]" for section header edit links and various other links for things like pronunciation guides.
[12:08:13] <gerrit-wm>	 New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/63426
[12:08:13] <gerrit-wm>	 Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63426
[12:08:33] <gerrit-wm>	 New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/64284
[12:08:33] <gerrit-wm>	 Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64284
[12:09:45] <MaxSem>	 jerith, looking
[12:09:52] <MaxSem>	 sigh
[12:17:56] <gerrit-wm>	 New patchset: MaxSem; "Rm edit section links from extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65251
[12:18:07] <MaxSem>	 jerith, ^^
[12:22:44] <gerrit-wm>	 New review: Jerith; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/65251
[12:47:49] <gerrit-wm>	 New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65263
[12:48:50] <gerrit-wm>	 New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/65263
[12:48:51] <gerrit-wm>	 Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65263
[13:47:25] <gerrit-wm>	 New patchset: MaxSem; "Rm edit section links from extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65251
[13:50:37] <gerrit-wm>	 New review: Jerith; "Looks good now." [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/65251
[14:34:27] <gerrit-wm>	 New patchset: Yurik; "Consolidated config, fixed bug in addWarning()" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/65164
[14:34:53] <MaxSem>	 yurik, gogogogog
[15:12:41] <yurik>	 MaxSem, ?
[15:13:03] <MaxSem>	 I called you, you came
[17:15:43] <gerrit-wm>	 Change abandoned: Dr0ptp4kt; "Superseded by 65164." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/65238
[17:21:22] <jdlrobson>	 jgonera: did we decided on camel case or hyphens in class names?
[17:21:35] <jgonera>	 CSS classes?
[17:21:41] <jdlrobson>	 yup
[17:21:44] <jdlrobson>	 (also we should link to style guidelines in README)
[17:21:51] <jgonera>	 hyphens AFAIR
[17:21:57] <jgonera>	 we should merge those guides
[17:21:59] <jdlrobson>	 that's what i thought
[17:22:12] <jgonera>	 I think we saw that hyphens are dominant in core ;)
[17:22:55] <gerrit-wm>	 New patchset: Jdlrobson; "Alpha: Use diff page for history" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63908
[17:24:01] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65251
[17:27:03] <jdlrobson>	 i'm special everyone seems to be having an issue with wifi except me
[17:27:16] <awjr>	 and me!
[17:27:25] <jdlrobson>	 (in office :P)
[17:27:27] <awjr>	 :p
[17:29:49] <tfinc>	 wifi FAIL
[17:42:14] <gerrit-wm>	 New review: Dr0ptp4kt; "Runs in local VM." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/65164
[17:42:26] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/65164
[17:49:03] <gerrit-wm>	 New patchset: Jdlrobson; "Beta: Story 435: Left nav grouping" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821
[17:49:03] <gerrit-wm>	 New patchset: Jdlrobson; "Kill dead CSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65312
[17:50:48] <gerrit-wm>	 Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65312
[17:54:03] <jdlrobson>	 jgonera: does the watch list view on master show crappy timestamps for you?
[17:58:36] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 48758: Remove hover effect" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65313
[18:03:31] <jgonera>	 jdlrobson, in what way crappy?
[18:04:52] <jdlrobson>	 jgonera: it says MODIFIED 00:43 / MODIFIED 16 MAY
[18:04:59] <jdlrobson>	 i'm sure it used to say modified 4 days ago etc ..
[18:05:14] <jgonera>	 yes, we talked about it, it must be a change in the core
[18:05:29] <jdlrobson>	 awjr: so to get round the shitty office wifi i am now tunneling through a uk vpn lolz
[18:05:39] <awjr>	 @_@
[18:06:35] <jgonera>	 see Wmfsf jdlrobson, there's a problem with ISP
[18:06:54] <jdlrobson>	 jgonera: i know
[18:06:58] <jdlrobson>	 this is my way of getting round the problem
[18:06:59] <tfinc>	 there we go :D
[18:07:02] <jdlrobson>	 and it works
[18:07:12] <tfinc>	 woot for SOCKS proxy through my home connection
[18:07:22] <tfinc>	 ssh -D is wesome
[18:07:24] <tfinc>	 awesome*
[18:12:27] <jdlrobson>	 jgonera: issues with older patch sets are fixed now can you take another look ^
[18:12:27] <jdlrobson>	 would be nice to get new ui grouping out on tuesday
[18:12:52] <jgonera>	 jdlrobson, I'm in the middle of figuring out the last graph to be changed in limn
[18:12:58] <jdlrobson>	 k
[18:13:01] <jgonera>	 I will look at them in 20 min
[19:15:39] <gerrit-wm>	 New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/65313
[19:17:37] <jgonera>	 jdlrobson, which patchsets exactly?
[19:34:51] <jdlrobson>	 ok sorry jgonera was working on getting nearby errors done which it now is
[19:34:55] <gerrit-wm>	 New patchset: Jdlrobson; "Improve error handling when location lookup fails" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65001
[19:40:49] <gerrit-wm>	 New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65313
[19:42:06] <gerrit-wm>	 New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65313
[19:42:11] <jdlrobson>	 ^ jgonera
[19:43:43] <jgonera>	 ok, sec
[19:43:52] <gerrit-wm>	 New patchset: Jdlrobson; "Beta: Story 435: Left nav grouping" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821
[19:49:09] <jgonera>	 jdlrobson, as I said "Needs new copy text, then good to go.", so I'm not sure what I should review there
[19:49:18] <jgonera>	 has anything else besides the copy text changed?
[19:51:18] <gerrit-wm>	 New review: awjrichards; "This patchset results in style changes of the nav in stable; is that intentional? I was under the im..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821
[19:51:42] <gerrit-wm>	 New review: JGonera; "Heading font size still too small (remember about our 90% font-size in <html>)." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/64821
[19:51:44] <awjr>	 jdlrobson: ^^
[19:51:59] <jdlrobson>	 jgonera: the styling
[19:52:16] <jdlrobson>	 awjr: soon terms of the new nav
[19:52:22] <awjr>	 ?
[19:52:51] <jdlrobson>	 jgonera: can you just do the fix up for the font size i need to bail right now for a bit
[19:52:54] <jdlrobson>	 awjr: :"This patchset results in style changes of the nav in stable; is that intentional? I was under the impression this was all supposed to happen only for beta."
[19:53:09] <awjr>	 yes, i didn't understand what you said though :p
[19:53:14] <awjr>	 'soon terms of the new nav'
[19:53:17] <jdlrobson>	 it was meant to read "in terms"
[19:53:19] <jdlrobson>	 so awjr it is intentional
[19:53:27] <jdlrobson>	 the reason is it helps us out with caching problems going forward
[19:53:36] <jdlrobson>	 but there should be NO visible styling changes
[19:53:42] <jdlrobson>	 and correct me if i'm wrong there are not..
[19:53:47] <awjr>	 ah, but there are visible styling changes
[19:53:48] <awjr>	 minor though
[19:53:54] <jdlrobson>	 which ones?
[19:53:55] <awjr>	 i'll make screenshots
[19:54:00] <jdlrobson>	 and how minor
[19:54:26] <jdlrobson>	 anyway i have to go grab lunch/get back home i'll be back in an hour
[20:06:56] <gerrit-wm>	 New patchset: JGonera; "Fix white gaps around the photo CTA image in article lists" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65329
[20:11:59] <gerrit-wm>	 New review: JGonera; "We should also get a higher res asset. Who prepared it?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65329
[20:15:37] <gerrit-wm>	 New patchset: JGonera; "Bug 48758: Remove left rag hover effect" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65313
[20:16:05] <gerrit-wm>	 Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65313
[20:44:30] <gerrit-wm>	 New patchset: JGonera; "Fix a typo in new editor CSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65336
[20:48:46] <gerrit-wm>	 Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65336
[21:01:43] <jdlrobson>	 jgonera: on https://gerrit.wikimedia.org/r/#/c/65329/ what change did you make to the camera image?
[21:01:52] <jdlrobson>	 not clear from the commit
[21:03:54] <gerrit-wm>	 New patchset: Jdlrobson; "Story 484: Push nearby to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64453
[21:05:02] <jdlrobson>	 jgonera: ?
[21:05:25] <jgonera>	 jdlrobson, I made it vertical, so that it extends if the row is taller
[21:05:39] <jgonera>	 but anyway, it would be good to get it 2x higher res
[21:05:46] <awjr>	 tfinc got a sec?
[21:05:51] <tfinc>	 awjr: sure
[21:05:55] <jdlrobson>	 yeh i saw that - so i'm wondering whether to wait on that on merge as is?
[21:06:01] <jdlrobson>	 May was the one who did it jgonera
[21:06:01] <awjr>	 im trying to figure out the best behavior for bugello
[21:06:10] <tfinc>	 k
[21:06:24] <jgonera>	 jdlrobson, is she in the office? if yes, can you ping her and ask if she could prepare one quickly?
[21:06:32] <jdlrobson>	 jgonera: i'm no longer in the office
[21:06:33] <awjr>	 tfinc at the moment, we are constrained in an obnoxious way by how bingle checks for bugs in bugzilla
[21:06:37] <jdlrobson>	 but i have pinged her
[21:06:45] <jgonera>	 jdlrobson, oh, ok
[21:07:06] <gerrit-wm>	 New review: Jdlrobson; "May. I've asked for new asset. What change occurred to this image? It's not clear from the commit......" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/65329
[21:07:10] <jgonera>	 it can wait or be merged, doesn't matter
[21:07:35] <awjr>	 tfinc so, bingle takes an RSS feed and will takea ctions on the bugs that that feed returns. for mobile web, we're looking for all bugs that are 'new' that have a last-modified timestamp fresher than the last time bingle ran
[21:07:56] <awjr>	 one obvious problem with this model is that it introduces the possibility of getting duplicate bugs
[21:08:22] <awjr>	 i protect for that by checking in mingle for the existence of a mingle card that already maps to a bugzilla bug
[21:08:30] <awjr>	 if bingle doesn't find a match, then it processes the bug into a mingle card
[21:08:55] <awjr>	 im still not totally clear on how trello organizes cards
[21:09:05] <tfinc>	 awjr: through its api or just in general ?
[21:09:13] <awjr>	 tfinc through Mingle's api
[21:09:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65001
[21:09:30] <awjr>	 oh, tfinc sorry i think i misunderstood
[21:09:34] <awjr>	 i meant in trello, in general
[21:10:04] <awjr>	 tfinc reading through the api docs it looks like i can treat a card as a totally autonomous etntity; that is, it is not tied to a board
[21:10:11] <awjr>	 (or something else)
[21:10:28] <tfinc>	 k
[21:11:18] <awjr>	 tfinc which is useful for our purposes, but i am curious what you want to have happen with incoming bugs
[21:11:29] <awjr>	 should they go into their own 'apps bugs' board?
[21:11:37] <tfinc>	 all cards should be part of a board
[21:11:40] <awjr>	 do you want more control so you can put them into the current sprint board?
[21:11:45] <tfinc>	 otherwise their orphaned and i wont find them
[21:11:56] <awjr>	 yeah
[21:11:58] <tfinc>	 it would be great to see them in the current sprint
[21:12:07] <tfinc>	 that's ideal
[21:12:10] <tfinc>	 as we can triage them as they come in
[21:13:02] <awjr>	 i wonder how can bugello could tell what board maps to 'current sprint' without any human intervention
[21:13:15] <tfinc>	 awjr: our naming is predictable
[21:13:31] <tfinc>	 Mobile App - Sprint #
[21:14:11] <tfinc>	 awjr: can you just search on that and pick the highest #'d one ?
[21:14:39] <awjr>	 the api is difficult to decipher; searching doesn't seem straightforward but im still digging through the docs
[21:14:57] <awjr>	 but… bugello could look for the extistence of mobile App - Sprint 1; if it finds it, try to find sprint 2; if it doesn't find it, current sprint is sprint 1. it could save that value in a file to use for next time
[21:18:48] <gerrit-wm>	 New patchset: JGonera; "Fix white gaps around the photo CTA image in article lists" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65329
[21:25:08] <gerrit-wm>	 New patchset: Jdlrobson; "Beta: Story 435: Left nav grouping" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821
[21:25:30] <gerrit-wm>	 New patchset: Jdlrobson; "Fix white gaps around the photo CTA image in article lists" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65329
[21:25:56] <gerrit-wm>	 New patchset: Jdlrobson; "Fix white gaps around the photo CTA image in article lists" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65329
[21:26:23] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65329
[21:26:25] <jdlrobson>	 ok just need to merge https://gerrit.wikimedia.org/r/#/c/64453/ awjr and jgonera and nearby is ready for tuesday
[21:28:37] <tfinc>	 awjr: works for me
[21:31:45] <gerrit-wm>	 Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64879
[21:44:59] <jdlrobson>	 awjr: jgonera https://gerrit.wikimedia.org/r/64453 still needs to be looked at and merged...
[21:45:18] <awjr>	 yeah jdlrobson, im in the middle of something else, will look when i can
[21:45:37] <jdlrobson>	 awjr: bear in mind me and juliusz are off in just over an hour
[21:46:11] <awjr>	 then i hope it won't need any followup!
[21:46:49] <jdlrobson>	 me too..
[21:54:26] <jdlrobson>	 awjr: i also need to let Matthew Roth know if it is going out Tuesday
[21:56:06] <jgonera>	 jdlrobson, what is to review there?
[21:56:18] <jdlrobson>	 just a sanity check.. it shouldn't take too long https://gerrit.wikimedia.org/r/64453
[21:56:26] <jdlrobson>	 check it works on wikipedia
[21:56:47] <jdlrobson>	 * check it works on stable
[21:57:32] <jgonera>	 I don't think that's the point of code review
[21:57:50] <jdlrobson>	 jgonera: what do you mean?
[21:58:16] <jdlrobson>	 i suspect there is nothing wrong with the above patch set but maybe i've forgotten something important
[21:58:29] <jgonera>	 I mean, code review should be more about code hygiene and spotting mistakes, not about checking if the fundamental functionality of the commit is present
[21:58:57] <jdlrobson>	 jgonera: yeh but although it might be on stable maybe something isn't working correctly - this is exactly the point of code review - catching things the first person didn't
[21:59:52] <jdlrobson>	 i'm also a little concerned about caching issues and whether that's going to be a problem here..
[22:00:30] <jdlrobson>	 it would also be good to get someone who's not been so closely tied to nearby to check the thing we are pushing looks good :)
[22:00:30] <awjr>	 okidoke, looking jdlrobson
[22:00:33] <jgonera>	 can be, I guess we won't see the nearby menu item on all pages until 30 days pass
[22:00:37] <awjr>	 jdlrobson: what are you concerns RE caching?
[22:00:42] <jdlrobson>	 awjr: well it's in the left menu
[22:01:00] <jdlrobson>	 so certain users who are not logged in on certain cached pages won't see it until cache gets flushed - not sure if that's a big deal
[22:01:26] <awjr>	 or until the item expires
[22:01:38] <awjr>	 i dont think it is a big deal; although product may feel differently
[22:01:48] <awjr>	 it might be a weird experience sometimes seeing the nav element and other times not
[22:05:38] <jdlrobson>	 i don't think we should block on it
[22:06:01] <awjr>	 jdlrobson: is howie around? i havent seen him online all day
[22:06:08] <awjr>	 but we should probably confirm with him
[22:06:12] <jdlrobson>	 awjr: i'm not in office and didn't see him earlier
[22:06:16] <awjr>	 oh ok
[22:06:52] <jdlrobson>	 how did we manage pushing uploads to stable?
[22:06:58] <jdlrobson>	 as that would have been a similar situation ..
[22:07:03] <jdlrobson>	 i guess we didn't worry about it ?
[22:07:31] <jgonera>	 hm, good question
[22:09:57] <awjr>	 we didn't worry about it
[22:10:04] <awjr>	 iirc maryana didn't care
[22:10:08] <awjr>	 same with the footer changes
[22:10:37] <awjr>	 ok i think this looks good, jdlrobson :)
[22:11:10] <jdlrobson>	 ok cool
[22:11:40] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64453
[22:11:44] <awjr>	 when it comes time to do the left nav grouping to stable, we'll probably want to plan ahead for a cache flush
[22:12:00] <awjr>	 though we'll definitely want to coordinate at least ac ouple weeks prior with ops about it
[22:12:41] <awjr>	 at least i'm guessing product won't want mixed nav styles out in the wild
[22:13:59] <jdlrobson>	 awjr: agreed
[22:14:24] <jdlrobson>	 we should coordinate as many changes as possible - new page nav as well
[22:14:37] <awjr>	 yeah
[22:14:53] <awjr>	 since we know we're going to need a cache flush for those two, we should try to release at the same time so we only have to do it once
[22:29:51] <jdlrobson>	 so in terms of tuesdays deployment https://gerrit.wikimedia.org/r/64821and https://gerrit.wikimedia.org/r/63908 would be great to get merged
[22:30:12] <jdlrobson>	 ^ awjr jgonera
[22:34:39] <gerrit-wm>	 New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/63908
[22:36:31] <gerrit-wm>	 New review: awjrichards; "LGTM; @jgonera if you can dbl check styling/js/etc and it looks good, feel free to +2." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1;  - https://gerrit.wikimedia.org/r/64821
[22:39:24] <jgonera>	 jdlrobson, so why the width of the heading bar changed in patchset 9 in https://gerrit.wikimedia.org/r/#/c/64821/ ?
[22:39:33] <jgonera>	 is this intentional?
[22:39:52] <jdlrobson>	 jgonera: heading bar?
[22:40:00] <jgonera>	 well the new thingie
[22:40:06] <jgonera>	 lightly greyish
[22:40:11] <jgonera>	 with gradient
[22:40:16] <jdlrobson>	 i'm confused.. what width did i change?
[22:40:19] <jgonera>	 where the headings are
[22:40:34] <jgonera>	 well it now has this black left margin like menu elements
[22:40:38] * jdlrobson  refamilarises himself

[22:41:07] <jgonera>	 so patchset 8 looked ok except for the font size, but font size is not the only thing changed in patchset 9
[22:41:15] <jgonera>	 and I'm asking if this is intentional
[22:41:29] <jdlrobson>	 well awjr asked me to make the styling in stable more consistent
[22:41:36] <jdlrobson>	 so i made a few other tweaks
[22:42:00] <awjr>	 i just thought the styling in stable wasn't supposed to change
[22:42:06] <jgonera>	 I'm looking at beta
[22:42:18] <jdlrobson>	 that said i made a mistake with
[22:42:19] <jdlrobson>	 	&:last-child {
[22:42:20] <jdlrobson>	 		height: 100%;
[22:42:21] <jdlrobson>	 	}
[22:43:18] <jdlrobson>	 as i said before i wasn't sure how the headers should behave with respect to the left bar
[22:43:33] <jdlrobson>	 i can either make the left bar stay to the left of them or not
[22:45:11] <jdlrobson>	 it's also not clear if left black bar should go right to bottom of menu or just for the 2 menus
[22:45:58] <jdlrobson>	 basically jgonera lots of ambiguity that i can't get answered pre tuesday
[22:46:26] <gerrit-wm>	 New patchset: Jdlrobson; "Beta: Story 435: Left nav grouping" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821
[22:46:44] <jdlrobson>	 ^ that makes stable consistent but on beta makes the black bar stop at end of 2nd menu
[22:47:11] <jdlrobson>	 pick which patch set you prefer and merge and we can perfect it later
[22:47:20] <jgonera>	 I'd say black bar goes to the bottom and it doesn't stay to the left of headers, but I'm no expert
[22:47:47] <jdlrobson>	 also awjr good spot on git fetch ssh://jdlrobson@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/08/63908/6 && git checkout FETCH_HEAD
[22:47:48] <jgonera>	 I liked patchset *8 + font size change
[22:48:04] <jdlrobson>	 jgonera: that's no good
[22:48:15] <jdlrobson>	 jgonera: as awjr pointed out we shouldn't make stable look different
[22:49:05] <jgonera>	 yes, I see now. not sure though why the left bar / headings issue is related
[22:49:32] <gerrit-wm>	 New patchset: Jdlrobson; "Alpha: Use diff page for history" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63908
[22:49:33] <jgonera>	 ok, gotta eat sth
[22:50:10] <jdlrobson>	 jgonera: i think you'll like patch set 10 - the black bar doesn't go down to the bottom of the page but that looks like it might be problematic for the time being
[22:50:35] <jdlrobson>	 i'm not sure how to make the last menu take up all the remaining height of the left menu
[22:53:23] <jdlrobson>	 feck it i'll use a negative margin
[22:54:13] <gerrit-wm>	 New patchset: Jdlrobson; "Beta: Story 435: Left nav grouping" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821
[22:54:14] <jdlrobson>	 ^ no excuses on this one.
[22:54:17] * jdlrobson  goes out to get coffee

[22:56:57] <awjr>	 tfinc can you do me a favor and add me to the Wikimedia Foundation as a member on a trello?
[22:57:11] <awjr>	 s/a trello/trello
[22:57:50] <tfinc>	 done
[22:58:04] <awjr>	 thanks tfinc
[22:58:17] <awjr>	 it's interesting; even though the boards are 'public', i apparently need to be a member of the org to see them via the API
[22:58:53] <awjr>	 the api documentation is missing an awful lot, so mostly im just figuring out what i can and can't do from trial and error
[23:01:00] <wikipedia-github>	 [Commons-iOS] montehurd opened pull request #75: New Getting Started pages based on designer mock-ups (master...gettingStarted)  http://git.io/TGBenQ
[23:13:18] <gerrit-wm>	 Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64821
[23:41:09] <gerrit-wm>	 New review: awjrichards; "I don't think this approach is going to fly in the long run since there's no way at-a-glance to see ..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/63908
[23:41:24] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63908