[00:46:41] tfinc: just leveled up my git skills :) [00:47:00] oh yeah. what did you do to level up? [00:47:10] tfinc: v1 i believe [00:48:15] dr0ptp4kt, is dfoy around? [00:49:30] dr0ptp4kt, you are welcome to take it [00:57:35] dr0ptp4kt, still there? [12:11:22] New review: MaxSem; "I thought we intentionally don't redirect wmf.o" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66039 [16:10:17] MaxSem, around? [16:15:58] yup [16:28:55] yurik, wasup? [17:06:17] dr0ptp4kt, there? [17:06:19] joining? [17:06:38] yurik, si, i'm here. dfoy cancelled the meeting. he said to just send email notes. [17:06:50] dr0ptp4kt, ah, ok [17:06:50] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [17:09:34] New patchset: Jdlrobson; "Add renderPage function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66051 [17:20:51] jdlrobson: what do you think we should do about https://bugzilla.wikimedia.org/show_bug.cgi?id=46241? [17:21:20] it sounds like this guy's device is a nightmare… and im not sure what we can really do if we cant repro [17:25:31] MaxSem: how do I check event logging on betalabs and test.m? [17:26:26] 1 sec [17:30:59] http://mashable.com/2013/05/30/wikipedia-nearby/ [17:31:39] jdlrobson: link? [17:31:43] http://mashable.com/2013/05/30/wikipedia-nearby/ [17:32:26] New patchset: Jdlrobson; "Add renderPage function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66051 [17:32:27] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [17:36:55] jcmish, on labs, ssh to deployment-eventlogging and run zsub localhost:8600 [17:37:19] due to buffering, you will see events in small batches only [17:42:11] k thanks MaxSem [18:01:41] jdlrobson, re detection: you pointed at a few issues that were here before that change [18:02:27] MaxSem: Are you sure? Even so would be cool to fix them in a rewrite... [18:02:27] my main worries are still about firefox [18:02:44] seems wrong to group it under android [18:02:49] FF was killed before [18:03:19] FF or Fennec? [18:03:28] anything FF based [18:03:52] i'm happy for you to overrule my -1 - i just wanted to point out new test cases [18:04:12] yeah [18:04:32] and I'm trying to figure out which of them are worth fixing in that commit [18:04:36] thanks [18:07:20] the problem with webkit browsers is that they all identify as Safari [18:07:27] ...and KHTML [18:07:32] ...and Gecko [18:07:56] thus! [18:08:05] CAN WE MERGE THEM ALL???? [18:39:24] jdlrobson, I left comments at https://gerrit.wikimedia.org/r/#/c/61942/ [18:40:04] MaxSem: cool will take a look in a bit [18:41:26] hrm [18:41:38] take a look at this lovely string: Mozilla/5.0 (Linux; Android 4.1.1; Galaxy Nexus Build/JRO03C) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.166 Mobile Safari/535.19 [18:41:55] now guess how much of this is b/c bullshit? [18:43:09] and why can't it be Chrome/18.0.1025.166 Mobile (Android 4.1.1; Galaxy Nexus Build/JRO03C) AppleWebKit/535.19 [18:43:58] is there a person on planet Earth insane enough to look for 'Mozilla' in UA? [18:53:25] * brion waves [19:08:14] brion: hey brion! [19:08:25] hey hey! [19:12:23] i've been online less than i expected this week sorry :) [19:15:06] mhurd: i see you got adam excited about the android app :) [19:34:12] New patchset: Jdlrobson; "Story 768: Add previews to editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66152 [19:59:40] New review: Jdlrobson; "A few issues" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/66152 [20:12:08] New patchset: Jdlrobson; "Story 768: Add previews to editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66152 [20:18:15] New patchset: Jdlrobson; "Tweak add topic page for talk" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65862 [20:18:40] New patchset: Jdlrobson; "Story 485: Promote talk overlay to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65863 [20:18:59] New patchset: Jdlrobson; "Editor (beta): Refresh the page after an edit" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66053 [20:20:51] New patchset: Jdlrobson; "Add renderPage function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66051 [20:35:19] dr0ptp4kt, not joinging us? :) [20:36:11] yurik, nah, you guys got it covered. i explained to dan that there may be a slight performance tweak we can make in ZRMA pertaining to X-CS handling once more requests are flowing with the X-CS header coming through, but otherwise know you guys got a handle on it. [20:38:29] tfinc: are we meeting today [20:40:45] New patchset: Jdlrobson; "Bug 48514: Always redirect to desktop when hitting history url" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66162 [20:41:05] ^ MaxSem awjr any objections before i self merge? [20:41:39] yes [20:41:41] don't self merge :) [20:41:50] awjr: really? On something this trivial..? [20:42:14] +2d [20:42:27] Juliusz was moaning at me the other day about not merging small changes like this - would be good to have a discussion during retrospective around if and when it is acceptable to self merge [20:42:30] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66162 [20:42:31] thanks MaxSem [20:42:36] omg I self-merged +6 lines of code the other day [20:42:44] tsk tsk [20:42:47] [Commons-iOS] montehurd opened pull request #78: Thumb titles expand. Progess bar fixes. Thumb spacing tweaks. (master...designInput) http://git.io/yyRV9g [20:42:51] * MaxSem runs away, dancing merrily [20:43:03] SHOOT HIM~ [20:43:13] jdlrobson: i think that makes sense but until we agree on somehting differently as a team we should be following general mw/wmf guidelines on this [20:43:22] i reserve the right to self merge minor css fixes [20:43:44] I reserve the right to shoot you!:P [20:44:00] MaxSem: not if I shoot you first! [20:44:17] * jdlrobson looks at the stack of awaiting final code review that relates to him and decides to work on minor bug fixes [20:45:26] actually, im not (quickly) finding a documented policy on self merging [20:45:59] oh, i found this: http://www.mediawiki.org/wiki/Gerrit/%2B2#Very_few_changes_are_trivial_enough_to_self-merge [20:46:30] awjr: MaxSem this has your name on it: https://gerrit.wikimedia.org/r/63589 [20:47:46] oh good that core change was finally merged [20:48:19] jdlrobson: personally (not speaking policy-wise) i don't care much about CSS changes, but i dont think you should ever self-merge logic change [20:48:30] no matter how trivial it seems [20:48:49] it's pretty easy to really screw things up with very 'trivial' changes [20:52:45] holy crap it's supposed to be 108F (42C) here on saturday [20:53:26] \o/ [20:53:47] bbq [20:54:03] yeah, the kind where you are the main course [20:58:34] tfinc: the getting started screens are on my ipad on my desk if you want to demo. getting foods [20:59:56] dr0ptp4kt, oki, have you seen my arch thoughts to wikitech-l? [21:00:15] yurik, no, will go look [21:01:33] yurik, this is the "purging parts of varnish cache" thread, correct? [21:01:47] dr0ptp4kt, no, wikitech - zero architecture [21:01:55] on the mailing list? [21:02:46] yurik, oh i see. at the bottom of the archives... [21:03:05] yurik, i have wikitech in digest. just needed to go all the way to the end. [21:07:32] New patchset: MaxSem; "Device type rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [21:08:07] okay, FF is not detected as android any more [21:08:34] also, iPhone detection in nanoseconds faster:P [21:09:13] we have 3 problems: Chrome detected as android (who cares?) [21:09:36] Opera Tablet (WTF is that?) not recognised [21:09:58] Fennec not detected (show me a single user of it) [21:12:04] i used fennec once [21:12:24] but i think it was literally only once [21:13:22] and it was 3 years ago? [21:13:52] hehehe that sounds about right [21:14:03] maybe a 1.5 years ago [21:22:56] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/63589 [21:28:38] New patchset: awjrichards; "Bug 47882: Redefine default modules for Minerva Skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63589 [21:29:04] is gerrit going super slow for anyone else? [21:30:26] yurik, read it. mostly makes sense. two comments: [21:30:33] New review: awjrichards; "I fixed the declaration of $device." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63589 [21:30:35] yurik, (1) "Since each carrier has its own list of free languages, language links on feature phones will point to origin, which will either silently redirect or ask for confirmation." < This will require some engineering finesse for article content, Read in Another Language, and dropdown links. Anything's achievable, just gotta be careful. [21:30:50] yurik, (2) "In general, we should manipulate image links in M for carriers who don't allow them, and always redirect ZERO to M unless M is not whitelisted, in which case convince carrier to change their whitelist." < You probably want to check with dfoy on that piece, in case there are contractual obligations or bandwidth considerations. [21:40:11] awjr: I'm confused by your -1 on https://gerrit.wikimedia.org/r/#/c/63589/ [21:40:31] oh, i should have reiterated my previous comment: [21:40:32] what do you need me to do? But i agree tests for skins would be a good thing [21:40:33] 'For some reason, nav doesn't appear to work as expected in stable with this patchset - even though I have JS enabled, when I tap the nav burger I get taken to Special:MobileMenu instead of the usual slide out nav. Also, I do not seem to get the upload CTA in articles.' [21:40:37] jdlrobson: ^ [21:40:51] awjr: is that on desktop, mobile, beta or alpha [21:41:01] desktop chrome in stable [21:41:53] * jdlrobson looks [21:42:03] desktop chrome or stable mobile [21:42:08] careful with your terminology :) [21:42:18] heh [21:42:21] browser = desktop chrome [21:42:28] mode = stable mobile [21:42:58] awjr: it works for me... [21:43:04] are you sure you are not having cache issues? [21:43:18] no, i might be though i refreshed everything before testing [21:43:22] give me a minute and i'll try again [21:44:26] note on desktop skin the upload cta will not work until Max fixes the formatter [21:45:43] awjr: if you click the hamburger before the javascript has fully loaded it will also take you to MobileMenu [21:45:48] but yeh.. works fine for me [21:46:01] jdlrobson: yeah i'll look again when i finish what im doing now [21:46:05] awjr: k [21:46:15] keen to get the skin changes in so i can work on Minerva some more [21:46:37] so MaxSem we are not going to run any javascript on Firefox mobile devices? [21:47:01] we run JS on all devices not blacklisted by RL [21:47:25] I can even make it detect as s60 and it will still run JS [21:47:27] MaxSem: oh yeh [21:47:29] sorry i'm being dumb [21:47:31] ok +2 [21:48:20] argg Max +2 fail [21:48:38] mm test still failing?! [21:48:59] also why doesn't phpunit run before a submit [21:49:17] New review: Jdlrobson; "Apparently PHP unit tests are failing" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/61942 [21:50:49] yup [21:53:56] New review: Jdlrobson; "We should indeed have phpunit tests - I'll raise a bug but let's not do this now." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63589 [21:58:06] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/65840 [22:02:19] jdlrobson: re https://gerrit.wikimedia.org/r/#/c/63589/, i am sure it's not a caching problem. [22:02:32] i am still getting sent to Special:MobileMenu [22:02:38] dr0ptp4kt, valid points, do you want to reply to the list? [22:03:08] awjr: anything in console? [22:03:11] nope [22:03:18] yurik, will do. [22:03:19] also have you enabled cache in chrome dev tools? [22:03:26] also what url are you using? [22:03:35] also have you tried a different browser? [22:03:38] enabled cache in chrome dev tools? [22:03:45] the URL is local to my machin [22:03:46] e [22:04:06] and the same thing happens for me in my ios simulator [22:04:13] developer tools -> cog -> general -> disable cache [22:04:25] what url are you using on your local machine? [22:04:35] wait… do you want me to disable or enable cache via dev tools? [22:04:39] disable cache [22:05:01] jdlrobson: it happens for me on *any* article view locally [22:05:17] and are you sure you are in desktop mode? [22:05:27] so for instance http://m.virtualbot.com/testing/core/index.php/Main_Page [22:05:30] no, i am mobile mode [22:05:41] this is in stable mobile [22:05:50] have you turned off memcache and turned in back on again? [22:05:55] yes [22:05:57] i don't know what to say.. it works perfectly for me [22:05:58] and varnish [22:06:17] and it's happening in both desktop chrome and ios safari [22:06:23] jdlrobson: i don't know what to say.. it works perfectly for me [22:06:31] your using patch set 6? [22:06:44] yep [22:06:46] did you check out or cherry pick? [22:06:59] checkout [22:07:16] can someone else take a look? [22:07:21] MaxSem: ^? [22:08:45] wifi died sorry [22:08:47] jdlrobson: did you check out or cherry pick? [22:08:48] [3:07pm] jdlrobson: and you're sure js is running? [22:08:49] awjr: [22:08:50] could you look at your network tab and tell me what js is being loaded? [22:09:13] jdlrobson: checkout; i am positive js is running [22:09:33] jdlrobson: do you want me to send you the load.php query strings? [22:09:48] load.php?debug=false&lang=en&modules=startup&only=scripts&skin=minerva&target=mobile&* [22:09:54] awjr, jdlrobson - i'm getting mobile menu too [22:09:55] load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20130506T230538Z [22:10:03] load.php?debug=false&lang=en&modules=jquery.client%2Ccookie%2CmwExtension%7Cmediawiki.notify%2Cutil%7Cmediawiki.page.startup&skin=vector&version=20130530T220133Z&* [22:10:07] yay im not crazy! [22:10:20] load.php?debug=false&lang=en&modules=jquery.checkboxShiftClick%2Chidpi%2CmakeCollapsible%2Cmw-jump%2Cplaceholder%7Cmediawiki.hidpi%7Cmediawiki.page.ready&skin=vector&version=20130530T220134Z&* [22:10:37] problem persists with ?debug=true [22:16:15] jdlrobson: did you get my load.php query strings and see MaxSem's msg that he is also getting mobile menu? [22:16:50] * jdlrobson looks at debug=true [22:17:16] arrgg awjr it still works for me... [22:17:24] i'm so confused [22:17:27] what am i doing differently?!! [22:17:57] awjr: you are running latest core yeh? [22:18:00] remember there was a core change... [22:18:04] hacktually [22:18:07] no [22:18:17] grrrrrlol [22:18:40] * awjr facepalm [22:19:11] i updated core on my dev tree but i forgot to update the codebase that my webserver is running [22:19:23] ahem [22:19:25] yeah now it works [22:19:35] sorry for the wild goose chase, jdlrobson [22:22:37] * jdlrobson facepalm [22:25:54] awjr: can we do a spike around upload errors ? [22:26:47] tfinc: totally; i can bring it up with product to see about getting it scheduled [22:27:48] New review: awjrichards; "Totally forgot to update core >_< Looks to be working just fine now :)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63589 [22:28:06] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/63589 [22:32:27] New patchset: Jdlrobson; "Remove code that does nothing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66175 [22:32:38] ^ awjr see this would be a good candidate for self merge :) [22:34:19] awjr: on subject of https://gerrit.wikimedia.org/r/#/c/65840/4/includes/skins/SkinMinerva.php < it's weird but I wanted it in desktop and mobile beta [22:40:49] * jdlrobson is also surprised that MaxSem hasn't pounced on https://gerrit.wikimedia.org/r/65134  [22:43:52] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66175 [22:46:07] New review: Jdlrobson; ""but it looks like both photo upload and watchlist changes may change HTML."" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65840 [22:47:06] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/65862 [22:52:51] New patchset: Jdlrobson; "Story 580: New page menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65840 [22:55:07] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65862 [22:55:10] New patchset: Jdlrobson; "Tweak add topic page for talk" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65862 [22:55:19] New patchset: Jdlrobson; "Story 485: Promote talk overlay to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65863 [23:07:34] phew [23:07:35] i've been having weird problems with my vps where my irc bouncer lives [23:07:38] but i think it's all back to normal now [23:25:35] New patchset: Jdlrobson; "Story 580: New page menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65840 [23:29:04] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65862 [23:29:09] New patchset: awjrichards; "Tweak add topic page for talk" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65862 [23:29:21] New patchset: awjrichards; "Story 485: Promote talk overlay to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65863 [23:39:23] New review: awjrichards; "Thanks for the updates, LGTM. Would be nice to get a second pair of eyes on JS." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/65840