[00:04:07] New patchset: MaxSem; "Device type rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [00:07:05] tfinc i am getting ready to run bugello for the first time - but when i do, it's going to fill up the sprint 9 'ready for dev' column with bugs so i figured i'd check with you first [00:07:18] i think there are going to be ~66 bugs on the first run [00:29:19] dfoy, pnig [00:29:34] dfoy, so all the users of 410-01 are now shown banners? [00:29:44] yurik: hi Yuri [00:30:11] yurik: Yes I activated this for a test [00:30:32] ok, btw, dfoy, don't define something identical to "en" - they are the same [00:30:41] no point - and much easier to read :) [00:31:16] so for that page -- "ur" is not needed for either banner nor name [00:31:32] yurik: I'll check again but I believe that I wasn't able to get past the config check without defining a string there [00:31:49] dfoy, not sure what you mean [00:32:02] i am not saying you should remove "en" [00:32:21] just remove the "ur" name & banner [00:32:30] yurik: ok I removed the ur text - I had confused the need for that with the error of the trailing comma [00:32:40] hehe :) [00:33:09] dfoy, tell you the truth, that error got me many times as well - i am used to all modern languages allowing it [00:33:38] yurik: yes it's an easy thing to miss, especially if you use copy/paste from another as a tempalte [00:33:40] template [00:34:01] yurik: So I don't need the ur name as well? [00:34:02] dfoy, yep. And you don't need "name" either - both of them use fallbacks [00:34:27] if you want to see the fallback rules, you will have to look inside the /Language files [00:34:35] yurik: cool - Adam sent me the fallback rules, very helpful [00:34:38] each language has a huge list of them [00:35:20] dfoy, oh, and one last thing -- you don't need to set "enabled":true -- unless you plan to revert it to false at some point [00:35:27] yurik: ok, removed [00:35:29] because it is by default [00:35:42] but up to you - it might be easier to add it back in later on [00:36:04] yurik: I understand, but since I set this up well before testing, I will always need to have that in to have it off until needed for actual tests [00:36:33] dfoy, sure, whichever is more convinient - not like it uses lots of resources :) [00:36:53] yurik: ok :) [00:51:59] New patchset: Dr0ptp4kt; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608 [00:56:20] New review: Dr0ptp4kt; "This works with 64608/8. Both 65135 and 64608 need to be deployed at the same time." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65135 [00:57:07] New review: Dr0ptp4kt; "This works with 65135/3. Both 65135 and 64608 need to be deployed at the same time." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/64608 [11:35:53] FYI, I'm going to start moving the mobile documentation on meta to mediawiki.org, per my mailing list post earlier. [13:59:39] tbharath: hey [13:59:39] 'sup? [16:54:30] YuviPanda, get back to grindstone! :-P [16:54:39] what what what! [16:54:39] i thought you won't be back until later? [16:54:45] yurik: i won't be :) [16:54:52] yurik: i just finished an exam today [16:54:54] so taking a break [16:54:56] we have a ghost in our midst [16:55:00] and chattering away on IRC [16:55:02] hehe [16:55:28] its strange what you consider "break"... nah, not really, we are all like that [16:58:03] yurik: :D [16:58:06] yurik: indeed. [16:58:17] yurik: you haven't heard me whine about college much yet have you? [16:58:21] it gets old fast :P [17:01:07] dfoy, i spoke with analytics, have a pretty good idea of what/how they do things [17:01:50] (of course that's relative to how much they actually understand themselves about what is going on, which is far from 100%) [17:02:45] yurik: good [17:03:27] yurik: So will you be holding the change for the X-CS scope for now? [17:04:31] dfoy, their data is already split up into different languages, so it won't be that hard to ignore irrelevant data IMO [17:04:58] the bigger problem is convincing ops to do it [17:05:44] yurik: ok, have you confirmed the work involved with Evan? They are under a tight deadline and may not be ready for any changes at this point. [17:05:46] the only reason we MUST have that (as oppose to "nice to have"), is if we have to show a warning "this language is not whitelisted" [17:06:20] dfoy, they don't really need to make any changes at this point, its ok [17:06:41] yurik: ok [17:07:12] dfoy, so it is up to you to decide on how the site should behave -- do we want to show any warnings or not for users that don't have a full list of zero-rated languages [17:07:59] ah michelle sent an ooo email yesterday that i didnt notice, saying she was driving home from texas [17:08:32] yurik: My understanding of the current behavior is that we do have warnings on the zero subdomain when the content is not whitelisted by the carrier [17:08:55] yurik: It's different on the m. subdomain, we just provide the content, no banners, no warnings. [17:08:58] dfoy, we have a big red warning on zero, and no warning on m [17:09:06] correct [17:09:29] yurik: we'd like it to continue to work that way [17:09:31] there is one big issue though - the red banner on all non-whitelisted domains is currently incorrect [17:09:32] awjr, I tried joining the standup but something is wrong with my Internet (that I unfortunately share with neighbors) [17:09:40] doh [17:09:41] couldn't see or hear anyone [17:09:50] dfoy, it does not give correct IP address in some cases [17:09:50] i never saw you join :( [17:09:56] jgonera: can you send your notes? [17:09:58] :/ [17:09:59] sure [17:10:06] thanks! [17:10:07] yurik: you mean that it's inaccurate that the operator is part of the zero program, just the language is not whitelisted [17:10:17] I will send them and head to the office [17:10:40] also, as is becoming typical on fridays, code review backlog is large, so it would be great if you can find some extra time for review [17:10:46] sounds good jgonera :) [17:10:50] dfoy, i mean that the red banner for zero is shown correctly, just that the IP address in it could be cached from another user [17:11:16] so if a user calls the carrier, and reports an IP, it could be totally off [17:11:26] like it could come from a different carrier alltogether [17:11:32] yurik: Is that typical? rare? [17:11:45] i would think this is typical [17:12:28] yurik: Will moving the banners to ESI fix that? [17:12:44] it would be cached per article & per whatever headers mobile frontend adds to variance [17:13:01] i would think so [17:13:57] yurik: I think that's the direction we're heading to avoid banner/caching problems anyway [17:14:04] yep [17:14:50] hence i won't push ops to merge that change, and we will continue maintaining two separate places for configuring which subdomains & languages are whitelisted [17:15:00] not happy, but oh well [17:22:16] New patchset: Jdlrobson; "Alpha: Introduce a page banner concept on tablets and desktop Minerva skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66277 [17:22:17] awjr: want to help me with the TODO ? :) - this would be fecking awesome. ^ [17:22:28] * awjr looks [17:23:15] jdlrobson: maybe after lunch! i have a few things i need to finish this morning and wanted to get through some code review first [17:24:15] New review: Jdlrobson; "I'm not sure if there is any reason why we don't redirect but to be consistent I think we probably *..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66039 [17:24:26] awjr: code review first yes :) [17:24:42] awjr: maybe i can get kaldari interested ;-) [17:24:53] you should jdlrobson! [17:30:57] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 1; - https://gerrit.wikimedia.org/r/64608 [17:37:59] New patchset: Jdlrobson; "Alpha: Introduce a page banner concept on tablets and desktop Minerva skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66277 [17:39:25] awjr: http://www.mediawiki.org/wiki/Wfmessage#Parameters < what do you mean by that? [17:39:39] are you telling me to use wfMessage ? [17:39:52] no, $this->msg() in that case is basically the same thing as wfMessage() [17:40:07] what im saying is you need to use one of the Message class methods for dumping out the message text and making sure it's escaped [17:40:16] (like you would with wfMessage()) [17:41:10] ah ok [17:41:27] escaped i guess? [17:41:32] tfinc: i have a microphone packed up here for you but i'm not making it into the office today. [17:41:36] that sounds right - lemme dbl check [17:41:46] jdlrobson: what's the patchset again? [17:41:49] jorm: aww bummer. will you be in sf at all this weekend ? [17:41:57] jorm: bart delays i assume [17:42:00] no. i have to go to santa cruz tomorrow. [17:42:06] yeah. i'm not dealing with a train crash. [17:42:23] ^ awjr [17:42:25] New patchset: Jdlrobson; "Story 495: Add about and disclaimer links to menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66013 [17:42:29] ty [17:42:29] ^ awjr [17:43:08] oh lol jdlrobson sorry, i linked you to the wrong subsection of that article [17:43:13] should have been http://www.mediawiki.org/wiki/Wfmessage#Output_modes_and_escaping [17:43:20] awjr: yeh that makes more sense ;-) [17:43:26] anyway fixed [17:43:42] escaped() should be fine unless there's any parsing that needs to happen [17:43:49] New patchset: Jdlrobson; "Don't lazy load sections on the first load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65134 [17:44:30] * jdlrobson hopes that jgonera will get in the office soon and be in the mood for code reviewing [17:45:27] maybe we need a viagra equivalent for code review [17:50:18] awjr: that would be awesome [17:50:44] shame viagra is a brand - would make a good name for a skin or something [17:50:59] lol [17:51:01] wikiagra [17:51:34] why has jenkins not kicked in here > https://gerrit.wikimedia.org/r/#/c/61942/ ? [17:51:44] New review: Jdlrobson; "oih jenkins stop being lazy and get to work" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [17:51:55] New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [18:01:02] jdlrobson: would you mind covering me for standup on 12 June? I'm giong to be at a training in sunnyvale [18:02:52] sure thang [18:03:16] * jdlrobson just realizes it's his sister's birthday in 10 days and he hasn't sent a card SHIT [18:04:19] thanks! [18:04:23] oh dude you've still got 10 days [18:04:38] better than remembering the day after [18:07:32] awjr: do you arrive on the 10th or the weekend before? [18:07:39] we should grab some drinks if the weekend.. :) [18:07:40] jdlrobson: afternoon of the 9th [18:07:50] ah ok [18:07:58] but yeah i'll be around sunday evening [18:08:14] monday evening will be tricky because i have to get down to sunnyvale somehow and check in to my hotel there [18:08:40] ok cool well keep me posted if you are grabbing food/drink [18:08:52] will do :) [18:20:34] awjr: any idea why jenkins isn't kicking in for https://gerrit.wikimedia.org/r/#/c/61942/ ? [18:20:38] should i just submit it? [18:21:11] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/61942 [18:21:18] awjr: whoops for the record i didn't mean to do that without jenkins [18:21:24] (the submit button is confusing) [18:23:02] New patchset: Jdlrobson; "Story 755: Add event logging to editing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65842 [18:23:07] heh [18:23:11] I have some mobile bugs. before I report them, just wanted to check if these were known things... [18:23:17] https://commons.wikimedia.org/wiki/File:Wikipedia_mobile_bug_screenshot_-_1.png [18:23:18] ragesoss: go for it :) [18:23:36] AHRGHH INLINE STYLES [18:23:37] jdlrobson: jenkins might just be out to lunch [18:23:52] that's {{chess diagram}} [18:24:01] ragesoss: https://bugzilla.wikimedia.org/show_bug.cgi?id=35704 [18:24:06] so, yeah, the other will be inline styles too. [18:24:12] this is one of the oldest and most horrible bugs [18:24:12] inline styles are evil [18:24:18] https://commons.wikimedia.org/wiki/File:Wikipedia_mobile_bug_screenshot_-_2.png [18:24:28] should be an sag! [18:24:30] *svg [18:24:54] ragesoss: what extension is that? [18:25:20] (that does ggplot() ) [18:25:32] ohh wait that's code [18:25:37] so the bug is that it's not inline? [18:26:12] can we rename svg to sag? [18:26:16] jdlrobson: that's from the ggplot2 article [18:26:22] ragesoss: yep i know [18:26:24] https://en.m.wikipedia.org/wiki/Ggplot2 [18:26:27] googled the text :) [18:26:53] that is an easy one to fix - but to be clear you mean the bug is that the code block is styled ugly? [18:27:09] yes, to the point that it overlaps other text. [18:28:10] okay, so new bug. shall I report it? [18:29:01] yurik, dr0ptp4kt, any idea on when we can deploy a fix for the Mobilink (410-01) IP range? [18:29:26] we should totally have an extension for making ggplots on-wiki. [18:29:34] ARFGGH ragesoss - that's Mobile.css sigh [18:29:41] dfoy, wasn't it already deployed? checking... [18:29:58] actually wait.. maybe it's not. [18:30:00] * jdlrobson confused [18:30:52] dfoy, current ranges are: "119.160.116.0"/22; [18:30:53] "119.160.125.0"/27; [18:30:55] "119.160.126.96"/28; [18:30:56] "119.160.126.128"/25; [18:31:04] ragesoss: fixing now.. [18:31:21] sweet [18:31:59] yurik: Is that in varnish? I made the correction on the meta config page, but that doesn't apply to the real world yet (AFAIK) [18:33:09] yurik: ok I see it in the vcl file [18:34:01] New patchset: Jdlrobson; "Allow inline code and pre tags" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66287 [18:34:04] dfoy, yes, that's in varnish, should it be fixed according to the Zero page? btw, it might be the same ranges, just optimized [18:34:05] ^ ragesoss done [18:34:47] I feel remarkable productive, for someone who simply complained. [18:35:27] yurik: so is this change live now? [18:37:37] "this file should not need to exist" heh [18:40:43] dfoy, should be [18:42:11] yurik: ok wasn't sure since this is Friday and changes are not typically pushed out. Thx. [18:42:32] dfoy, everything in the puppets project gets auto-pushed out every 30 min [18:42:38] so it should be live [18:42:48] regardless of when it was chaned [18:42:54] *changed [18:43:11] yurik: ok great, thanks for catching that, they launched this with very little testing on their side. [18:43:33] dfoy, i caught something? :) [18:43:43] yurik: nothing bad :) [18:54:20] dfoy, i fixed the Zero page to reflect what has been done to the varnish -- the IPs were not canonical, i fixed them. Btw, i have added a watch to every zero page so that meta sends me an email whenever one of the zero pages changes. You might want to do that too [19:00:52] New patchset: Jdlrobson; "Apply new watch star and talk assets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66290 [19:01:13] dfoy, what's the urgency on the stc and kenya IP addresses for Varnish? [19:06:46] awjr: lets just dump in all the bugs [19:06:53] better to get it over with now [19:06:58] tfinc ok, will do in about an hour - in a mtg now [19:07:38] ok. if it slips past an hour i'll have to delay it by about a week as were planning for our next sprint @ 2 [19:07:43] awjr: --^ [19:07:44] thanks [19:08:06] ok tfinc no problem, i'll let you know [19:18:28] jdlrobson: do we have tracking for how many people are adding images through nearby ? [19:18:46] distinct from lead image [19:44:39] mhurd: i'm putting in a thai food order at osha. are you interested ? [19:44:48] dr0ptp4kt: --^ [19:46:56] tfinc, mhurd: Mussamun Lamb, please [19:47:20] dr0ptp4kt: did you see the price ? [19:48:42] https://order.zonicordering.com/MTQ1OA%3d%3d.zhtml?str=Osha-Thai-Delivery [19:49:50] jdlrobson: --^ [19:50:11] jgonera: --^ [19:50:39] tfinc, mhurd, jdlrobson: pumpkin curry w/ chicken, please [19:50:54] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/65842 [19:54:49] errg gerrit down? [19:55:11] nope just me being silly [20:02:08] tfinc bugs are in! [20:08:26] awjr: they certainly are .... [20:08:46] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65842 [20:09:42] awjr: i think jenkins is broken [20:09:48] or on vacation today [20:09:51] jdlrobson: yeah it seems to be fubard today [20:10:16] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65842 [20:10:25] guess we'll have to submit for him [20:10:29] jdlrobson: ask in the ops channel [20:10:36] i dont see ^demon or hashar around [20:10:40] wikimedia-operations ? [20:10:45] but Krinkle|detached or Reedy may be able to help [20:10:46] yeah [20:11:07] looks like other people are noticing same problem [20:17:53] mhurd: is this still a valid bug https://bugzilla.wikimedia.org/show_bug.cgi?id=48027 ? [20:20:43] tfinc: i believe it's fixed [21:03:49] jdlrobson: i've been slow to get to code review due to other things stealing my attention, but im about to dive in. is there anything in particular i should look at first/ [21:07:50] awjr: https://gerrit.wikimedia.org/r/#/c/65843/ would be high [21:08:04] and take another look at https://gerrit.wikimedia.org/r/66013 [21:08:16] i'm hoping i can pair with jgonera and clear out this backlog if he's free [21:08:51] tfinc: i saw most of the bugs got moved to the sprint 10 board - just so you know, until bugello_wmf gets added to that board with write permissions, it will continue adding new bugs to the sprint 9 board (maybe that's what you want, but just wanted to dbl check) [21:08:57] cool jdlrobson, on it [21:09:26] jdlrobson: do you know of a way to force jenkins to re-check without having to do a new patchset? [21:09:39] commenting recheck usually [21:09:46] oh [21:09:47] cool [21:10:18] New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66013 [21:10:18] ^ like so [21:16:19] didnt seem to work :( [21:23:31] New review: awjrichards; "Loos good; however, while testing it occurred to me... what happens if either the about or disclaime..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66013 [21:26:56] jdlrobson: apparently jenkins is just slowly catching up with a huge backlog [21:33:47] New review: Jdlrobson; "404s I guess.. :) " [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66013 [21:48:03] New review: awjrichards; "Yeah, you can test a page's existence with Title::exist():" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66013 [21:49:30] jdlrobson: just found an issue with Special:MobileDiff [21:49:38] add it to bug report :) [21:49:44] working on page menu right now [21:49:54] kk [22:16:32] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=49029