[00:21:41] <gerrit-wm>	 New review: Jdlrobson; "14px should probably be derived from a variable but meh" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/66309
[00:22:00] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66309
[09:03:19] <gerrit-wm>	 New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66388
[14:38:47] <wikipedia-github>	 [Commons-iOS] brion pushed 23 new commits to master: http://git.io/Qaympg
[14:38:47] <wikipedia-github>	 Commons-iOS/master 03c910c Monte Hurd: Work-in-progress on getting started screens...
[14:38:47] <wikipedia-github>	 Commons-iOS/master 126e0b4 Monte Hurd: Fixed bug with CALerpLine related to redrawing shorter lines
[14:38:47] <wikipedia-github>	 Commons-iOS/master 55ec1f8 Monte Hurd: Layout tweaks
[14:49:36] <wikipedia-github>	 [Commons-iOS] brion pushed 1 new commit to master: http://git.io/mGze8Q
[14:49:36] <wikipedia-github>	 Commons-iOS/master 7e563bf Brion Vibber: Allow non-portrait orientations for intro screen on iPad....
[14:52:32] <wikipedia-github>	 [Commons-iOS] brion pushed 4 new commits to master: http://git.io/FzdHGQ
[14:52:32] <wikipedia-github>	 Commons-iOS/master bb50f30 Monte Hurd: Added logout button...
[14:52:32] <wikipedia-github>	 Commons-iOS/master ce5c5c9 Monte Hurd: Login keyboard Done button submits login credentials...
[14:52:32] <wikipedia-github>	 Commons-iOS/master f5acdb0 Monte Hurd: Added recover password button to login page
[14:55:17] <wikipedia-github>	 [Commons-iOS] brion pushed 2 new commits to master: http://git.io/ddr-5A
[14:55:17] <wikipedia-github>	 Commons-iOS/master 47419f1 Monte Hurd: Made My Uploads thumbs scroll to top upon upload...
[14:55:17] <wikipedia-github>	 Commons-iOS/master 80236e7 Brion Vibber: Merge pull request #77 from montehurd/scrollToTop...
[15:00:22] <wikipedia-github>	 [Commons-iOS] brion pushed 2 new commits to master: http://git.io/sICeKQ
[15:00:22] <wikipedia-github>	 Commons-iOS/master a02cb52 Monte Hurd: Thumb titles expand. Progess bar fixes. Thumb spacing tweaks....
[15:00:22] <wikipedia-github>	 Commons-iOS/master 9412459 Brion Vibber: Merge pull request #78 from montehurd/designInput...
[15:09:04] <wikipedia-github>	 [Commons-iOS] brion pushed 4 new commits to master: http://git.io/JdoUAA
[15:09:04] <wikipedia-github>	 Commons-iOS/master 9d9fbd2 Monte Hurd: Fixed issue with download operation preventing proper cancellation...
[15:09:04] <wikipedia-github>	 Commons-iOS/master 6b2df47 Monte Hurd: Fixed eternal spinner bug on details page
[15:09:04] <wikipedia-github>	 Commons-iOS/master 2c44887 Monte Hurd: Prioritized details page thumbnail download - much quicker...
[15:10:42] <wikipedia-github>	 [Commons-iOS] brion pushed 2 new commits to master: http://git.io/eghl9A
[15:10:42] <wikipedia-github>	 Commons-iOS/master e9ec0bc Monte Hurd: Made add media button shrink and fade when toggled
[15:10:42] <wikipedia-github>	 Commons-iOS/master 9a1b44c Brion Vibber: Merge pull request #81 from montehurd/fadeAddImageButton...
[16:19:23] <MF-W>	 hi there
[16:19:36] <MF-W>	 are gadgets (or any JS, for that matter) currently functioning in mobile view?
[16:24:17] <MaxSem>	 Mobile.js/.css for site stuff
[16:25:18] <MaxSem>	 Gadgets should have "targets=mobile" or |targets=desktop|mobile" in description to work on mobile (and support ResourceLoader)
[16:29:45] <MF-W>	 ah ok, thanks!
[17:10:11] <gerrit-wm>	 New review: Cmcmahon; "maintenance" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/66388
[17:10:11] <gerrit-wm>	 Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66388
[17:34:28] <awjr>	 MaxSem: would it make more sense to use tagging for this? https://mingle.corp.wikimedia.org/projects/mobile/cards/826
[17:34:55] <awjr>	 i guess the advantage to branching is backporting is easier
[17:35:00] <MaxSem>	 awjr, tag=fixed point, branch=something we can backport to
[17:35:04] <awjr>	 yeah
[17:36:01] <MaxSem>	 since we don't do releases, tags aren't needed
[17:36:10] <awjr>	 yeah i think you're right
[17:36:17] <awjr>	 it makes more sense
[17:43:44] <MaxSem>	 jdlrobson, are you going to the ops meeting?
[17:44:37] <jdlrobson_>	 MaxSem yup
[17:45:29] <MaxSem>	 since Tomasz asked me to participate too - are we both needed?
[17:46:00] <jdlrobson>	 umm what did Tomasz ask you to participate for?
[17:49:01] <MaxSem>	 jdlrobson, osm
[17:49:24] <jdlrobson>	 MaxSem: I usually use the meeting just to give a brief outline of what mobile is doing over next 2 weeks
[17:49:30] <jdlrobson>	 usually just a 5 minute update
[17:51:54] <tfinc>	 MaxSem: jdlrobson: CT asked me to bring it up at the TechOps meeting so that he could get context
[17:52:46] <awjr>	 it sounds like it would be good for both of you to be there, MaxSem and jdlrobson
[17:59:29] <gerrit-wm>	 New patchset: awjrichards; "Story 485: Promote talk overlay to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65863
[18:01:01] <jdlrobson>	 is jgonera coming into office?
[18:01:36] <awjr>	 he didnt say so but i assumed that was the case
[18:01:41] * jdlrobson  nods

[18:01:45] <awjr>	 i havent seen him online since standup tho
[18:02:17] <tfinc>	 brion: mhurd: sprint kick off in R33
[18:02:34] <brion>	 tfinc: now or in 15?
[18:02:54] <brion>	 calendar says 11:15
[18:02:59] <tfinc>	 11:15
[18:03:22] <brion>	 ok we'll be there :D
[18:04:29] <ScaredPanda>	 brion: happy your day :)
[18:04:34] <brion>	 \o/ thx
[18:04:38] <jdlrobson_>	 \o/ apparently some russian site wants to turn one of my flickr photos into a magnet and sell it haha
[18:04:48] <awjr>	 !
[18:04:55] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65863
[18:04:57] <jdlrobson_>	 http://www.world-wide-gifts.ru/index.php?page=shop.product_details&flypage=flypage.tpl&product_id=5002324&option=com_virtuemart&Itemid=6 < MaxSem does this look legit?
[18:05:56] <gerrit-wm>	 New patchset: Jdlrobson; "Cleanup fixBrowserBugs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66571
[18:05:57] <gerrit-wm>	 New patchset: Jdlrobson; "Lock viewports in overlay mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66572
[18:06:09] <MaxSem>	 jdlrobson_, they do. however I don't see international delivery here
[18:06:21] <awjr>	 jdlrobson: are anons supposed to be able to post on talk pages?
[18:06:29] <yurik>	 jdlrobson, MaxSem, dr0ptp4kt  -- since we need to push out a synced version of our code, do you want to push them together as part of your next deployment?
[18:06:43] <MaxSem>	 why not
[18:06:43] <jdlrobson_>	 awjr: https://gerrit.wikimedia.org/r/#/c/66308/
[18:06:52] <awjr>	 :)
[18:07:09] <jdlrobson>	 awjr: currently no
[18:07:13] <jdlrobson>	 but in future why not
[18:07:18] <awjr>	 yup
[18:07:30] <jdlrobson>	 the state of login on mobile depresses me a lot - get logged out so much
[18:07:35] <dr0ptp4kt>	 yurik, i think that would be great if MaxSem and jdlrobson oblige.
[18:07:45] <awjr>	 i think it's state of login on the projects in general
[18:08:02] <awjr>	 yurik, dr0ptp4kt ?
[18:08:03] <MaxSem>	 CentralAuth, be it damned
[18:08:31] <yurik>	 awjr, ??
[18:08:37] <jdlrobson>	 https://twitter.com/pigsonthewing/status/341599221536944129 :(
[18:08:46] <dr0ptp4kt>	 awjr, what say you?
[18:09:00] <dr0ptp4kt>	 awjr, er, what's up?
[18:09:12] <awjr>	 yurik, dr0ptp4kt i was curious for more info about the code you need sync'd
[18:09:39] <yurik>	 awjr, jdlrobson has made some changes to further separate mobile & zero
[18:09:47] <yurik>	 but they need to go in at the same time
[18:10:11] <awjr>	 hmm
[18:10:19] <jdlrobson>	 https://twitter.com/psubhashish/status/341387320928399360 WIN
[18:10:37] <awjr>	 are those changes isolated so that the zero-specific changes go out separately?
[18:10:50] <jdlrobson>	 awjr: need to go out exactly same time
[18:10:58] <jdlrobson>	 otherwise chance that there will be 2 zero banners
[18:11:35] <awjr>	 we need to get out of the habit of these kinds of changes
[18:11:57] <awjr>	 and support some backwards compatability
[18:12:07] <awjr>	 changes like this make deployment too high-stakes
[18:13:41] <awjr>	 yurik, dr0ptp4kt were you hoping to thave these specific changes go out with other Zero-code, or can we isolate *just* the specific changes in question?
[18:15:42] <jdlrobson>	 MaxSem: awjr https://gerrit.wikimedia.org/r/66584 < think this should be right
[18:18:07] <awjr>	 jdlrobson: is commons on betalabs in state where that will work?
[18:19:16] <jdlrobson>	 1s awjr
[18:19:22] <awjr>	 np
[18:21:24] <jdlrobson>	 awjr: i haven't tested it but have no reason to believe it will not work
[18:21:29] <awjr>	 jdlrobson: also i think you'll need to set wgMFPhotoUPloadWiki otehrwise upload counts won't work
[18:21:49] <awjr>	 jdlrobson MaxSem had expressed some doubts when we were discussing that work during planning
[18:22:05] <jdlrobson>	 mm hadn't seen $wgMFPhotoUploadWiki before
[18:22:29] <awjr>	 it's used in SpecialUploads.php
[18:23:46] <jdlrobson>	 awjr: so no need to set $wgMFPhotoUploadWiki
[18:23:52] <jdlrobson>	 on labs: 'commonswiki'   => '//commons.wikimedia.beta.wmflabs.org',
[18:24:14] <jdlrobson>	 commonswiki seems to point to beta already
[18:24:20] <awjr>	 er
[18:24:25] <awjr>	 the value of that var should not be a URI
[18:24:31] <awjr>	 but the name of the wiki
[18:24:38] <awjr>	 i think
[18:24:46] <awjr>	 (see how it's configured for prod)
[18:25:05] <yurik>	 awjr, i don't think we have made many changes since the last deployment (they are still unmerged, so shouldn't be an issue to merge them all :)
[18:25:34] <yurik>	 dr0ptp4kt, could you answer jdlrobson comment in https://gerrit.wikimedia.org/r/#/c/64608/8/includes/PageRenderingHooks.php
[18:25:35] <jdlrobson>	 exciting news - cross domain api tokens :D - we should be able to kill the handshake! :D
[18:26:00] <yurik>	 jdlrobson, they are in? who was working on them?
[18:26:04] <jdlrobson>	 awjr: yes but i'm saying it looks like commonswiki is configured to be beta
[18:26:11] <gerrit-wm>	 New review: awjrichards; "This makes the Talk page show as a regular page for me (as opposed to overlay) and I do not see an '..." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/66308
[18:26:15] <jdlrobson>	 chris steipp
[18:26:26] <jdlrobson>	 almost in it seems gonna chat to him in a bit
[18:26:34] <awjr>	 jdlrobson: oh i see, you mean that 'commonswiki' already maps to beta; roger
[18:26:39] <jdlrobson>	 awjr: roger
[18:26:42] <awjr>	 w00t
[18:26:49] <jdlrobson>	 awjr: why wouldn't photo uploads work on beta labs?
[18:27:01] <dr0ptp4kt>	 awjr, jdlrobson, yurik, sorry, will reply to your messages. probably in reverse order. strange, i had submitted a reply already. do i need to do something besides click 'save'?
[18:27:08] <awjr>	 dunno, MaxSem had some doubts but i don't recall hearing anything specific
[18:27:09] <jdlrobson>	 dr0ptp4kt: submit
[18:27:13] <dr0ptp4kt>	 jdlrobson, thx
[18:27:20] <MaxSem>	 what are you discussing?
[18:27:21] <awjr>	 jdlrobson: ^^
[18:27:31] <awjr>	 MaxSem: https://mingle.corp.wikimedia.org/projects/mobile/cards/767
[18:27:48] <gerrit-wm>	 New review: Dr0ptp4kt; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608
[18:28:25] <yurik>	 jdlrobson, i don't see it in logs, are you sure about it?
[18:29:20] <gerrit-wm>	 New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608
[18:29:24] <jdlrobson>	 ^ dr0ptp4kt
[18:29:37] <jdlrobson>	 yurik: i'll update when i know more
[18:37:10] <awjr>	 yurik: ok cool; it's totally up to MaxSem since he'll be deploying
[18:42:32] <gerrit-wm>	 New patchset: Jdlrobson; "Cleanup fixBrowserBugs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66571
[18:42:32] <gerrit-wm>	 New patchset: Jdlrobson; "Lock viewports in overlay mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66572
[18:43:44] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 48732: Add $wgMFPhotoUploadEndpoint to Special:Uploads for desktop view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66667
[18:44:39] <jdlrobson>	 dr0ptp4kt: did you see my comment about the array_merge ?
[18:46:50] <dr0ptp4kt>	 jdlrobson, yes. looking at it now. if i'm not mistaken, around line 124 in MinervaTemplate $this->data['banners'] is cycled through by a foreach loop to echo the HTML for the banner section of the page?
[18:57:10] <jdlrobson>	 awjr: cannot compute your -1 https://gerrit.wikimedia.org/r/#/c/66308/
[18:57:30] <jdlrobson>	 are you sure you are in alpha?
[18:57:38] <awjr>	 jdlrobson: i was in beta
[18:57:43] <awjr>	 i didnt try it in alpha
[18:57:45] <jdlrobson>	 awjr: well there you go then..
[18:57:45] <jdlrobson>	 :)
[18:57:54] <jdlrobson>	 talk pages haven't been promoted to beta yet
[18:57:55] <awjr>	 er
[18:57:56] <awjr>	 but
[18:57:56] <awjr>	 https://mingle.corp.wikimedia.org/projects/mobile/cards/485
[18:58:01] <jdlrobson>	 yeh but it's not been merged
[18:58:04] <awjr>	 yes it has :)
[18:58:17] <jdlrobson>	 well let's do a rebase then..
[18:58:20] <gerrit-wm>	 New patchset: Jdlrobson; "Only show add topic button if logged in" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66308
[18:58:21] <jdlrobson>	 ^ done
[18:59:33] <jdlrobson>	 always rebase ;-)
[18:59:37] <gerrit-wm>	 New review: awjrichards; "Looks like it just needed a rebase against master." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/66308
[18:59:59] <awjr>	 jdlrobson: i just assumed since it was a later patchset it was built on top of the other stuff
[19:00:01] <awjr>	 my mistake
[19:00:13] <jdlrobson>	 no worries just confused me :)
[19:01:08] <jdlrobson>	 MaxSem: what needs to be done for https://mingle.corp.wikimedia.org/projects/mobile/cards/784 ?
[19:02:03] <MaxSem>	 jdlrobson, I'll need to work on the API, then some frontend work will be needed
[19:02:51] <gerrit-wm>	 New patchset: Jdlrobson; "Don't lazy load sections on the first load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65134
[19:08:43] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66308
[19:09:07] <yurik>	 jdlrobson, dr0ptp4kt so have you decided if you want it changed? https://gerrit.wikimedia.org/r/#/c/64608/
[19:16:06] <yurik>	 jdlrobson, dr0ptp4kt i think that patch needs two minor improvements, pls check. thx!
[19:16:42] <dr0ptp4kt>	 yurik, will check.
[19:16:46] <dr0ptp4kt>	 yurik, later..
[19:20:55] <awjr>	 http://etherpad.wikimedia.org/MobileShowcase
[19:24:49] <awjr>	 jdlrobson: you should show off the article actions too
[19:25:16] <awjr>	 oh and talk
[19:25:17] <awjr>	 jdlrobson: ^
[20:01:23] <yurik>	 dr0ptp4kt, this patch did not merge -- https://gerrit.wikimedia.org/r/#/c/65135/
[20:01:32] <yurik>	 jdlrobson, ^
[20:05:25] <dr0ptp4kt>	 yurik, are you saying there was an unresolvable merge conflict?
[20:05:36] <yurik>	 dr0ptp4kt, seems that way
[20:05:55] <yurik>	 dr0ptp4kt, i accidently noticed that you +2 it
[20:05:59] <yurik>	 but it didn't go in
[20:06:32] <dr0ptp4kt>	 hmm. i think we'll probably need jdlrobson to look at it for any rebasing since the last patchset.
[20:33:29] <tfinc>	 brion: its good to see you back in here
[20:33:31] <tfinc>	 :)
[20:33:42] <brion>	 \o/
[20:49:51] <mhurd>	 brion: api question when you have a sec
[20:50:13] <brion>	 moment
[20:53:12] <jdlrobson>	 awjr: question..
[20:53:24] <awjr>	 jcmish: you've got a handful of commits for MobileFrontend that are unmergable - it looks like they just need rebasing (and since they can't be auto-rebased, presumably merge conflicts need to be dealt with)
[20:54:02] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=48949 < What about the alpha and beta cookies?
[20:54:21] <awjr>	 what about em?
[20:54:30] <awjr>	 jdlrobson: ?
[20:54:38] <jdlrobson>	 well as i understood the bug was that by having more than 1 cookie we were introducing performance issues
[20:54:43] <jdlrobson>	 "as there's no actionable bug or problem here. if the
[20:54:44] <jdlrobson>	 request for investigation was motivated by some specific issue, let's file a
[20:54:45] <jdlrobson>	 bug for that."
[20:54:49] <jdlrobson>	 so i'd suspect that was the motivation...
[20:55:03] <jdlrobson>	 isn't the action to merge the cookies?
[20:55:52] <jdlrobson>	 judging on your analysis in answer to "I received a request to investigate whether we need both stopMobileRedirect and mf_useformat cookies." we don't need both..
[20:55:53] <awjr>	 oh, the action as i understood it was to investigate whether or not they were needed
[20:56:07] <tfinc>	 jdlrobson: what was the outcome of the noble vs sprint kick off review scheduling ?
[21:42:12] <jcmish>	 ah awjr  I'll take a look
[21:54:30] <awjr>	 groovy thanks jcmish
[21:55:23] <jcmish>	 awjr: you bet
[21:55:36] <jcmish>	 I'll probably get stuck and ping since my git fu is severely lacking
[21:55:41] <jcmish>	 but for now i'll try it myself :D
[21:56:19] <awjr>	 happy to help i fyou need it :)
[22:02:26] <MaxSem>	 awjr, are you familiar with XPath?
[22:02:34] <awjr>	 MaxSem: a little
[22:02:48] <awjr>	 it's been a while
[22:02:50] <awjr>	 why?
[22:03:13] <MaxSem>	 does //div[contains(@class, "foo")] look ok?
[22:04:44] <awjr>	 MaxSem: doesn't 'contains' search text, or does it search tags too?
[22:05:02] <awjr>	 i think you would do //div[@class='foo']
[22:05:19] <MaxSem>	 yeah. if there's just one class
[22:05:23] <awjr>	 OH
[22:05:50] <awjr>	 so you want it to match on something like <div class="foo bar baz">
[22:05:55] <MaxSem>	 yep
[22:06:05] <awjr>	 im not sure that would work
[22:06:14] <awjr>	 but i need to read about contains
[22:06:14] <MaxSem>	 it was a major source of subtle bugs before
[22:08:38] <awjr>	 actually that might work MaxSem
[22:08:42] <awjr>	 MaxSem: http://cowburn.info/2009/06/15/xpath-css-class/
[22:08:52] <MaxSem>	 it doesn't however:(
[22:09:14] <awjr>	 eh sorry, your approach may work but not the syntax :p
[22:09:41] <awjr>	 see the blog post i linked
[22:10:39] <MaxSem>	 you mean //li[contains(concat(" ", normalize-space(@class), " "), " active ")]?
[22:10:51] <awjr>	 yeah but s/active/foo
[22:11:04] <MaxSem>	 I thought something like this would be too slow and tried filtering in PHP
[22:11:29] <awjr>	 at the very least MaxSem //div[contains( @class, 'foo' )]
[22:11:48] <awjr>	 but you might get false positives (eg it would match <div class="foobar">
[22:12:14] <awjr>	 actually i guess the other approach would too
[22:12:50] <MaxSem>	 however, even //div[contains(@class, "foo")] can't find <div id="foo"> for me
[22:13:08] <awjr>	 haha MaxSem because id not class
[22:13:33] <awjr>	 in your div you are setting 'id' not 'class'
[22:13:37] <MaxSem>	 meh, calss of course
[22:14:19] <MaxSem>	 the test was correct, not what I typed there:)
[22:14:30] <awjr>	 oh
[22:14:31] <awjr>	 hm
[22:14:58] <awjr>	 can i see real code and a text sample?
[22:18:23] <MaxSem>	 https://dpaste.de/kjuLP/
[22:23:46] <awjr>	 hmm
[22:24:09] <awjr>	 looks like that should work
[22:24:47] <awjr>	 lemme poke this a bit in the formatter
[22:27:03] <awjr>	 hmm git apply doesn't like that diff
[22:28:07] <awjr>	 oh i see it looks like that's done against something other than master
[22:35:05] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608
[22:38:30] <mhurd>	 brion: novocaine… gah!
[22:38:44] <gerrit-wm>	 New patchset: JGonera; "Story 768: Add previews to editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66152
[22:38:47] <brion>	 whee
[22:38:54] <gerrit-wm>	 New review: Dr0ptp4kt; "See comments. Later patchset submitted." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608
[22:40:09] <yurik>	 dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/64608/8..9/includes/PageRenderingHooks.php looks much better, but what about the isset() ?
[22:40:25] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608
[22:40:51] <awjr>	 so MaxSem im not sure what's wrong with the code (i can't really tell all what's going on in that diff), but something like $xpath->query( '//*[contains(@class, "foo")]') run on
[22:41:02] <awjr>	 <table><tr><td>foo</td></tr></table><div class="foo">foo</div><span id="bar">bar</span>
[22:41:03] <awjr>	 <strong class="foo" id="bar">foobar</strong><div class="notfoo">test</div><div class="baz"/>
[22:41:03] <awjr>	 <span class="baz">baz</span> <span class="foo" id="jedi">jedi</span>
[22:41:08] <awjr>	 gives me expected results
[22:41:14] <dr0ptp4kt>	 yurik, you able to do a quick google hangout?
[22:41:20] <yurik>	 dr0ptp4kt, also, annother thing -- when you unshift, you usually place a single item in front of an array, but here its an array itself, not the same as array_merge. are you sure about it?
[22:41:21] <MaxSem>	 ugh
[22:41:37] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66152
[22:41:38] <MaxSem>	 thanks, will experiment further
[22:41:40] <awjr>	 that is, it gives me 4 elements that contain 'foo' in the class tag (div, strong, div, span)
[22:41:49] <awjr>	 good luck MaxSem, sounds like it might be something else in the code that's breaking
[22:42:12] <yurik>	 dr0ptp4kt, calling
[22:51:34] <jgonera>	 awjr, will we have a retrospective some time soon?
[22:51:55] <awjr>	 jgonera: we will have our quarterly retrospective during the quarterly/annual planning things
[22:52:03] <awjr>	 it's currently scheduled for 6/19 i believe
[22:52:08] <jgonera>	 ok
[22:55:45] <tfinc>	 mhurd: i showed kaldari the new version of the app
[22:55:50] <tfinc>	 he was very impressed
[22:55:56] <tfinc>	 and loved tho photo re-use
[22:58:56] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Use the hook Luke." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608
[23:00:41] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/64608
[23:04:03] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/66027
[23:04:44] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/66028
[23:05:28] <mhurd>	 tfinc: awesome! :)
[23:07:35] <yurik>	 MaxSem, will you do the deployment tomorrow?
[23:07:50] <MaxSem>	 on Wednesday
[23:08:14] <yurik>	 MaxSem, right, when you add mobile, please make sure you also add Zero master
[23:08:21] <yurik>	 otherwise banners will break
[23:08:24] <MaxSem>	 sure
[23:08:28] <yurik>	 thx
[23:20:06] <gerrit-wm>	 New patchset: Jdlrobson; "Move zero banner to Zero extension" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65135
[23:21:24] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65135
[23:45:13] <yurik>	 dfoy, this card seems to be very important https://trello.com/card/ensure-x-close-and-mobile-star-buttons-are-aligned/514257806eac40565e000883/79
[23:45:27] <yurik>	 i noticed that the close button and the search box no longer right-allign
[23:45:43] <yurik>	 not sure when it happened, seemed like a CSS bug
[23:54:18] <gerrit-wm>	 New patchset: Jdlrobson; "Code hygiene: Use more generic nicer variable name for headings" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66885
[23:55:01] <gerrit-wm>	 Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66885