[00:14:42] <gerrit-wm>	 New patchset: Jdlrobson; "Code cleanup: Separate Overlay, Drawer and CtaDrawer from mf-navigation.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66887
[00:17:21] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66887
[00:23:22] <gerrit-wm>	 New patchset: MaxSem; "Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888
[00:24:28] <gerrit-wm>	 New patchset: Jdlrobson; "use M.require('Overlay')" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66889
[00:28:14] <gerrit-wm>	 Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66889
[00:30:49] <gerrit-wm>	 New patchset: JGonera; "Story 770: Add notifications (user) icon" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66890
[00:33:11] <gerrit-wm>	 New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888
[00:34:33] <gerrit-wm>	 New patchset: JGonera; "Story 770: Add notifications (user) icon" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66890
[00:38:26] <gerrit-wm>	 New review: MaxSem; "getMobileUrl() is for local URLs only. While it may accidentally work if both the local and remote s..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66039
[00:46:57] <gerrit-wm>	 New patchset: JGonera; "Story 770: Add notifications (user) icon" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66890
[00:51:43] <gerrit-wm>	 New review: Jdlrobson; "Weird issue where if logged in and you click the watch star icon after the notifications icon the wa..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/66890
[00:52:04] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66890
[01:06:06] <tfinc>	 mhurd: even if the only slideshow we added was on login we'd have images all the way back to 2004 :)
[01:07:17] <tfinc>	 the imagery from years past is equally as stunning
[06:36:00] <gerrit-wm>	 New patchset: Jdlrobson; "Kill dead template code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66898
[06:36:00] <gerrit-wm>	 New patchset: Jdlrobson; "Code hygiene: Consolidate menu creation code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66899
[06:36:00] <gerrit-wm>	 New patchset: Jdlrobson; "Cleanup: Move login page handling into own special page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66900
[06:36:03] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 49030: Make WML self dependent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66901
[06:51:56] <gerrit-wm>	 New patchset: Yurik; "Fix banner CSS to prevent close button overlaping search" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/66903
[13:56:00] <gerrit-wm>	 New patchset: Zfilipin; "Explicitly require json gem to avoid warning message on Linux and Windows" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66969
[14:45:55] <gerrit-wm>	 Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66969
[17:01:07] <yurik>	 dr0ptp4kt, could you +2 minor patch pls
[17:04:33] <yurik>	 dfoy, dr0ptp4kt are we meeting ?
[17:09:34] <ty221>	 Hello
[17:10:02] <ty221>	 I'm interested in create app for Wikipedia Editors
[17:11:16] <mhurd>	 ty221: hi! what do you have in mind?
[17:11:49] <ty221_>	 My target is fully working app which can edit Wikipedia for mobile
[17:12:20] <ty221_>	 Sorry for my bad English ;)
[17:13:32] <mhurd>	 ty221_: it's fine :)
[17:13:34] <ty221_>	 Can I use Wikipedia logo in my project ?
[17:13:35] <ty221_>	 Will WMF support my project ?
[17:14:26] <mhurd>	 ty221_: hmmm i'm not sure
[17:14:49] <ty221_>	 Yes,  I know ;) I often want to edit Wikipedia from my phone, but I haven't got tool to this
[17:14:50] <ty221_>	 Editing from browser isn't comfortable
[17:15:15] <mhurd>	 ty221_: ask tfinc if you see him here later today. he'd have more information.
[17:15:28] <ty221_>	 In what ?
[17:15:39] <jdlrobson>	 ey ty221_
[17:15:44] <ty221_>	 Hellp
[17:15:44] <mhurd>	 in #wikimedia-mobile
[17:15:50] <ty221_>	 Hello *
[17:16:05] <jdlrobson>	 I think there may be issues in you using the wikipedia logo
[17:16:26] <jdlrobson>	 (i believe it should be clear it the app is unofficial)
[17:16:29] <ty221_>	 yes, i know,  so I ask
[17:16:43] <jdlrobson>	 as mhurd says when tfinc arrives he can let you know for sure
[17:16:50] <jdlrobson>	 as for WMF support - that is usually linked to community around your project
[17:17:03] <jdlrobson>	 if your project gets a lot of community interest I suspect WMF would be interested
[17:17:36] <jdlrobson>	 I suspect we would be able to help with version control however if you need that
[17:17:45] <ty221_>	 I wanna be my project official
[17:18:05] <jdlrobson>	 also the mobile web team (my team) is adding editing at the moment - would be great if you want to get involved in that :)
[17:18:21] <jdlrobson>	 https://en.m.wikipedia.org/wiki/Special:MobileOptions < if you opt into beta and login you'll be able to edit :)
[17:19:09] <ty221_>	 Wait please...
[17:19:47] <jdlrobson>	 ty221_: 'official' projects would need to prove themselves. So if you make an app and it is extremely popular then I imagine there might be a discussion around "should this be official?" - this is a community decision however so no guarantees :)
[17:20:44] <ty221_>	 But if my application is official that means that WMF accept that
[17:22:17] <ty221_>	 I tested your edit mode. It's fine,  but I think that good solution is adding visual editor
[17:23:05] <ty221_>	 Only somebody know MediaWiki text formatting
[17:23:51] <ty221_>	 Currently on Play Store there is Wikipedia official app,  bj
[17:24:10] <ty221_>	 But it doesn't have edit mode
[17:24:38] <ty221_>	 And it isn't updated regularly
[17:25:12] <ty221_>	 I wanna create app more comfortable in using, whic
[17:25:23] <ty221_>	 With *
[17:25:53] <ty221_>	 Visual editor, fully wikipedia interface
[17:26:00] <mhurd>	 ty221_: also, there are apps under development here https://github.com/wikimedia/Commons-iOS and here https://github.com/wikimedia/android-commons for contributing images to wikimedia commons. if you'd like to contribute to either of these apps that would be great!
[17:26:45] <ty221_>	 And publish it on play Store
[17:28:26] <ty221_>	 Mhurd: I'm using this app
[17:29:00] <ty221_>	 And I think it works correctly
[17:29:35] <ty221_>	 I wanna create app to edit and read Wikipedia
[17:31:28] <mhurd>	 ty221_: understood.
[17:32:38] <ty221_>	 ping 1500 ms...
[17:33:09] <mhurd>	 ty221_: you may already have these, but in case not they helped me get familiar with data access: http://commons.wikimedia.org/w/api.php   http://www.mediawiki.org/wiki/API:Properties  http://commons.wikimedia.org/wiki/Special:ApiSandbox
[17:34:05] <ty221_>	 My apl
[17:34:12] <ty221_>	 App *
[17:34:19] <ty221_>	 Will you API
[17:34:48] <ty221_>	 Use *
[17:35:50] <mhurd>	 ty221_: anyone can use the api i believe. double check with tfinc later though
[17:36:13] <yurik>	 dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/66903/
[17:37:19] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/66903
[17:37:23] <ty221_>	 Anyone can, but no everybody can
[17:37:30] <dr0ptp4kt>	 yurik, +2'd.
[17:37:35] <yurik>	 thx!
[17:37:48] <MaxSem>	 anyone can use our API. that's the whole point of it
[17:38:01] <ty221_>	 I know
[17:39:11] <ty221_>	 jdlrobson: are you available now ?
[17:40:08] <jdlrobson>	 ty221_: yes
[17:40:09] <mhurd>	 MaxSem: i heard you made the sandbox?
[17:40:15] <MaxSem>	 yep
[17:40:23] <mhurd>	 MaxSem: it is awesome
[17:40:28] <jdlrobson>	 ty221_: you should just make it but no one can promise it will be official - that's a decision community will need to make
[17:40:31] <MaxSem>	 thank you:)
[17:40:36] <mhurd>	 MaxSem: thank you!!!
[17:40:45] <mhurd>	 MaxSem: i use it a lot
[17:41:44] <ty221_>	 jdlrobson :  who can give me consent to use Wikipedia logo ?
[17:42:27] <ty221_>	 jdlrobson : can I publish my app as me or W
[17:42:36] <ty221_>	 WMF * ?
[17:43:03] <MaxSem>	 ty221_, contact our legal team
[17:43:29] <ty221_>	 MaxSem : will they send me a consent ?
[17:43:44] <MaxSem>	 most likely, they won't:)
[17:45:20] <mhurd>	 ty221_: but you can publish it yourself and use the api. i think you just can't use the logo and claim it's official until the community and the foundation consent
[17:46:12] <mhurd>	 ty221_: and that consent would depend on the quality, number of users, etc
[17:49:02] <jdlrobson>	 MaxSem: https://gerrit.wikimedia.org/r/#/c/66039/ can we just redirect wmf.o
[17:49:38] <jdlrobson>	 MaxSem: also could you take a look at my template cleanup ? https://gerrit.wikimedia.org/r/#/c/66898/ and friends..
[17:50:39] <MaxSem>	 jdlrobson, https://mingle.corp.wikimedia.org/projects/mobile/cards/194?referrer%5Bq%5D=redirect&referrer%5Bq_type%5D=&referrer%5Bquery_id%5D=q_ddc888b81&referrer%5Brank%5D=10&referrer%5Bsize%5D=19&referrer%5Bts%5D=06%2F04%2F13+17%3A49%3A42
[17:51:46] <jdlrobson>	 MaxSem: hmm i don't think there's much value in fixing this bug - what's wrong with showing the desktop site if it doesn't redirect anyway?
[17:52:02] <MaxSem>	 bad UX?
[17:52:29] <jdlrobson>	 MaxSem: so personally i'd close https://bugzilla.wikimedia.org/show_bug.cgi?id=48857 as WONTFIX. The entire site doesn't redirect so why should these pages?
[17:52:36] <jdlrobson>	 it should be a decision of the site itself not MobileFrontend
[17:53:05] <MaxSem>	 MF should display these pages in a mobile-friendly way, what's wrong about it?
[17:53:26] <jdlrobson>	 MaxSem: sure but then why does https://wikimediafoundation.org/ not redirect to mobile? I can use the same argument
[17:53:45] <MaxSem>	 let's leave this to Howie then:)
[17:53:53] <jdlrobson>	 ok i'm gonna add my comments to the story :)
[17:56:55] <gerrit-wm>	 New review: Jdlrobson; "Pending further discussion on the bug.." [mediawiki/extensions/MobileFrontend] (master) C: -2;  - https://gerrit.wikimedia.org/r/66039
[17:59:56] <jgonera>	 jdlrobson, http://mislav.uniqpath.com/2010/05/semicolons/ http://benalman.com/news/2013/01/advice-javascript-semicolon-haters/#comment-777915923 http://dailyjs.com/2012/04/19/semicolons/
[18:44:08] <gerrit-wm>	 New patchset: Jdlrobson; "Editor (beta): Refresh the page after an edit" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66053
[18:44:08] <gerrit-wm>	 New patchset: Jdlrobson; "Add renderPage function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66051
[18:45:12] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 49146: Use min height on user info box rather than height" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66995
[20:25:18] <tfinc>	 mhurd: is brion around today?
[20:25:51] <mhurd>	 tfinc: not so far
[20:26:42] <mhurd>	 tfinc: *in balloon form he remains, however
[21:05:59] <gerrit-wm>	 New patchset: Jdlrobson; "Editor (beta): Refresh the page after an edit" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66053
[21:06:00] <gerrit-wm>	 New patchset: Jdlrobson; "Add renderPage function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66051
[21:14:24] <gerrit-wm>	 New patchset: Jdlrobson; "Editor (beta): Refresh the page after an edit" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66053
[21:14:24] <gerrit-wm>	 New patchset: Jdlrobson; "Add renderPage function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66051
[21:18:05] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66051
[21:19:26] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66053
[21:25:47] <gerrit-wm>	 New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412
[21:25:47] <gerrit-wm>	 New patchset: Jdlrobson; "Don't lazy load sections on the first load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65134
[21:37:03] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Normalize interstitial for images." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67018
[21:57:19] <jdlrobson>	 MaxSem: btw i think the wap site is broken in master
[21:57:37] <MaxSem>	 like?
[21:57:38] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66898
[21:57:50] <jdlrobson>	 MaxSem: missing template variables https://gerrit.wikimedia.org/r/#/c/66901/ seems to solve it
[21:58:23] <MaxSem>	 I'd love to merge it, but it's chained
[21:58:33] <jdlrobson>	 i can try cherry picking now
[21:58:40] <jdlrobson>	 but the chained ones are all rather small patches
[22:01:22] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 49030: Make WML self dependent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66901
[22:01:25] <jdlrobson>	 MaxSem: WIN ^
[22:01:54] <jdlrobson>	 ergg although it has added an unnecessary new line 1s
[22:02:38] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 49030: Make WML self dependent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66901
[22:02:44] <jdlrobson>	 MaxSem: done
[22:05:31] <MaxSem>	 jdlrobson, did you test it?:P
[22:05:42] <jdlrobson>	 MaxSem: well i set X-Device header and viewed the xml
[22:05:53] <jdlrobson>	 i didn't try it on a wap phone though as i haven't got one
[22:05:59] <MaxSem>	 but not PHP errors log?:)
[22:06:25] <MaxSem>	 you can force wml view with ?useformat=mobile-wap btw
[22:08:00] <MaxSem>	 jdlrobson, initPage() isn't getting called
[22:08:46] <jdlrobson>	 MaxSem: is initPage needed?
[22:09:05] <MaxSem>	 per https://gerrit.wikimedia.org/r/#/c/66901/3/includes/skins/SkinMobileWML.php yes:)
[22:09:14] <jdlrobson>	 MaxSem: note lang and dir not set on here btw: http://en.m.wikipedia.org/wiki/Battleship?useformat=mobile-wap
[22:09:17] <MaxSem>	 Notice:  Undefined index: code in /home/max/Projects/MediaWiki/includes/SkinTemplate.php on line 1330
[22:09:22] <MaxSem>	 Notice:  Undefined index: mainPageUrl in /home/max/Projects/MediaWiki/includes/SkinTemplate.php on line 1330
[22:09:27] <MaxSem>	 Notice:  Undefined index: randomPageUrl in /home/max/Projects/MediaWiki/includes/SkinTemplate.php on line 1330
[22:09:31] <MaxSem>	 Notice:  Undefined index: searchField in /home/max/Projects/MediaWiki/includes/SkinTemplate.php on line 1330
[22:09:40] <jdlrobson>	 MaxSem: that's with this patchset?!!
[22:09:44] <MaxSem>	 yep
[22:09:55] <jdlrobson>	 err
[22:09:56] <jdlrobson>	 it shouldn't be..
[22:10:58] <jdlrobson>	 MaxSem: it's working for me :/
[22:11:43] <jdlrobson>	 MaxSem: i'm confused...
[22:11:59] <jdlrobson>	 initPage gets called by default by outputPage in core
[22:12:10] <jdlrobson>	 are you running latest core?
[22:12:19] <jdlrobson>	 and you're sure those errors weren't before this patchset?
[22:14:17] <MaxSem>	 yes/I'm sure
[22:27:46] <jdlrobson>	 MaxSem: I don't know what to say.. it's working fine for me on this side - no errors on wap site :-S
[22:28:31] <gerrit-wm>	 New review: Dr0ptp4kt; "CSS no longer loaded in test against MediaWiki Vagrant. Redirects appear to work for variants of X-S..." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 1 - https://gerrit.wikimedia.org/r/67018
[22:28:44] <dr0ptp4kt>	 ^yurik, would you please test and review 67018? this is the hack to avoid premature commons.wikimedia.org stylesheet loading.
[22:45:45] <yurik>	 dr0ptp4kt, trying to understand your patch
[22:47:20] <dr0ptp4kt>	 yurik, lemme know if you wanna talk on a google hangout
[22:50:47] <gerrit-wm>	 New review: Yurik; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -1;  - https://gerrit.wikimedia.org/r/67018
[22:51:36] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Normalize interstitial for images." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67018
[23:24:33] <jdlrobson>	 jgonera_: where did you go?
[23:24:46] <jgonera_>	 r3X something
[23:24:49] <jgonera_>	 the small one
[23:24:51] <jgonera_>	 behind you
[23:25:06] <jgonera_>	 I'm still with the 360 feedback though...
[23:25:37] <jdlrobson>	 code review break time?
[23:25:40] <jdlrobson>	 we have 30 mins.. :)
[23:28:28] <jgonera_>	 jdlrobson, I know you'd really want the history commit to be reviewed today, but could we start with it tomorrow? I'm starting to get a headache (literal one) and I kind of lack of inspiration in 360
[23:28:48] <jdlrobson>	 jgonera_: code cutoff is 5pm :/
[23:28:58] <jdlrobson>	 jcmish would have to ok
[23:29:22] <jgonera_>	 I know that, but couldn't we do without it for a week more?
[23:29:54] <jdlrobson>	 :( i've already waited a month... desperate to see this in production
[23:32:31] <jgonera_>	 jdlrobson, if you manage to extend the deadline for 360 for me, I can switch to code review now
[23:32:52] <jdlrobson>	 i really don't think this will take long..
[23:36:53] <jgonera_>	 I know, but I have 30 minutes left to finish 360 (I need to get to mechanic before 6pm) and I have 4 people left
[23:37:00] <jgonera_>	 and I seriously don't know what to write
[23:37:15] <jgonera_>	 and the headache is not making it easier either :/
[23:42:40] <jdlrobson>	 :(
[23:42:42] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67018
[23:42:47] <jdlrobson>	 i'm struggling too… 3 left now i think
[23:58:59] <jgonera_>	 I have still 2 left to go
[23:59:22] <jgonera_>	 I think I'll do the self assessment last just before 7pm after getting my car back...
[23:59:27] <jdlrobson>	 2 left \o/