[00:00:05] "Try not to spend more than 15-20 minutes per feedback." ha [00:06:37] i'm calling it a day [00:06:40] submitted them all [00:23:59] jdlrobson, are you alive after this?:P [00:24:15] yep all done OuKB :) [04:33:07] New patchset: Yurik; "Re-added legacy compatibility for 'sites' setting" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67048 [04:35:18] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67048 [04:44:48] New patchset: Dr0ptp4kt; "Revert "Use the hook Luke."" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67050 [04:49:49] New patchset: Dr0ptp4kt; "Revert "Move zero banner to Zero extension"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67051 [04:51:33] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67051 [04:51:43] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67050 [14:01:05] hello, can you give me email to leglay team of WMF ? [14:03:27] hello, can you give me email to leglay team of WMF ? [14:04:28] hey ty221 [14:06:20] ty221: you probably want to email legalwikimedia.org [14:06:22] and see https://en.wikipedia.org/wiki/User:WMF_Legal [17:17:25] yurik, sorry for delay. i was gonna chec if you had talked to jdlrobson on the git reverts. but when i got vm prompt, i figured i would bump into him, and i did, so i gave him a heads up [17:18:10] MaxSem, thx, pls remember to pick up zero master. [17:18:12] sure [17:18:17] please be around then [17:18:24] MaxSem, thanks once more for being so helpful. we appreciate it! [17:18:41] oh, wm-bot [17:18:41] i forgot we had one [17:19:17] MaxSem, also, dr0ptp4kt and I had to rollback patch yesterday that moved some stuff from mobile to zero [17:19:24] because it wasn't working in some cases [17:19:26] MaxSem, what time is the depl? [17:19:27] need a merge? [17:19:31] nope, i already merged :) [17:19:41] (hope i didn't break mobile :-P) [17:19:53] https://wikitech.wikimedia.org/wiki/Deployments 2-4 PST [17:24:44] Maryana: welcome back :) [17:24:54] to follow up what we started during standup, here's the bug we were talking about: https://bugzilla.wikimedia.org/show_bug.cgi?id=48857 [17:24:56] thanks! good to be back [17:24:59] ah darn i just missed zz_YuviPanda :) [17:26:01] mhurd: is ready to go or are you still adding to it? [17:26:06] * brion starts reviewing from where he left off [17:26:33] there are a few options: 1) write some ugly code to force mobile format on the links 2) make wikimediafoundation.org automatically redirect for mobile (we don't currently really know the issues/feasiability; like MaxSem mentioned there might be fundraising complications, etc) 3) do nothing (let privacy and about point at desktop version of wikimediafoundation.org) [17:26:37] Maryana: ^ [17:26:58] i agree with jon that we shouldn't worry about hacking it to display mobile on one page [17:27:25] i'm betting that fr-tech is just worried about the donate page on wikimedia foundation wiki - could we special case that to never display mobile? [17:27:43] Maryana: not without more hacks [17:27:44] cos it would be really nice to have all of wmf wiki display nicely on mobile [17:27:50] sigh [17:28:09] I'm wary of complications of displaying destop pages on m subdomains [17:28:51] yaeh that too (although i think the donate stuff for fundraising is handled by special pages [no caching], though that may have changed since i was in fundraising) [17:29:08] oh actually i take that back [17:29:16] the donation stuff on wikimediafoundation.org is the landing pages [17:29:28] which are main namespace articles [17:29:42] so yeah, Maryana special casing for FR pages is not good [17:30:06] bleh [17:30:12] but [17:30:19] maybe we should talk to fr-tech [17:30:26] yeah, a spike might be good [17:30:41] i imagine if they run a mobile fr banner campaign, they'll want to direct people to mobile landing pages... [17:30:45] at some point in the future [17:31:03] yeah; and now CentralNotice supporst this kind of thing :) [17:31:04] so they may be totally cool with it. [17:31:19] indeed [17:31:44] ok, so i think we should wontfix the privacy policy bug and create a spike around mobilifying wmf wiki [17:31:50] with fr pages special casing [17:33:00] that sounds good :) [17:33:24] problem solved; so MaxSem i guess we should abandon that patchset - and Maryana can you comment on that bug? [17:33:37] Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66039 [17:34:16] awjr, will do [17:36:07] thanks Maryana! [17:36:13] mhurd: hmm I'm thinking we might want to make a MWTitle class to abstract the adding/removing of 'File:', 'Category:' etc [17:36:23] i'll add it to the backlog for code hygiene [17:36:59] my first day back and the first thing i do is WONTFIX a bug - vacation makes me so mean! [17:37:04] :) [17:37:33] daaaaamn girl [17:37:39] ahahahahaha [17:37:44] you're gonna make somebody sad [17:38:14] jdlrobson: i found the cross domain stuff [17:38:22] Maryana: https://gerrit.wikimedia.org/r/#/c/67111/ was the change that makes the upload cta show on pages visiting from nearby [17:38:28] awjr: cool link? [17:38:28] it's in CommonSettings.php; $wgCrossSiteAJAXdomains [17:38:47] there doesn't seem to be any overrides in CommonSettings-labs.php so you'll probably need to set that up [17:39:37] New review: MaxSem; "Can we remove it from SkinMinerva then?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66667 [17:40:55] New review: Jdlrobson; "All SkinMinerva pages use it for page lead photo uploads. This patch is for non-Minerva based skins." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66667 [17:41:13] ahh awjr are you doing that or you want me to update that? [17:41:27] also MaxSem did you ever work out why https://gerrit.wikimedia.org/r/66901 wasn't working for you? [17:41:31] jdlrobson: if you can do it that would be great as i have a efw balls in the air at the moment [17:41:36] i checked multiple times and there is no reason why it shouldn't work [17:41:38] awjr: roger [17:41:41] jdlrobson: if you're busy too i can get to it probably in 20 mins or so [17:43:39] Maryana: quick probe of the fundraisers makes it sound like it shouldn't be a problem, but there may be some exceptions (Eg a couple of chapters might still be using landing pages on foundationwiki), but sounds like it might not be a huge deal. [17:43:58] ok, sweet [17:46:20] MaxSem: are you able to test this somehow? =>https://gerrit.wikimedia.org/r/67119 [17:46:30] I'm not sure how I can [17:46:57] you may just need to merge and hope for the best :p [17:47:12] it's a testing environment, just merge it [17:47:52] ok want to give it ago (since i can't merge :)) [17:48:00] i got it [17:48:25] soooo… im not sure how often labs config changes get syncd out to betalabs [17:49:22] pretty often [17:49:52] is there any way to double check what config is actually running on betalabs? [17:50:42] just wait for it;) [17:51:08] gahhhhh the antici……….pation! [17:53:30] mhurd: i've got a few notes but i'm happy to merge as is so we can show it off and make fixes later [17:53:30] New review: Maryana; "Let's go for it! Since Nearby is in the left nav and only a subset of articles need images, this new..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67111 [17:54:01] brion: sounds good! just fixed the https and pushed it [17:54:07] spiff [17:54:42] brion: so excited [17:54:56] :D [17:55:25] tfinc_: need me to come in and unlock the cabinet? [17:55:38] brion: lets give chip some time to respond [17:55:44] ok :D [17:56:00] jgonera: https://gerrit.wikimedia.org/r/#/c/67111/ [17:56:03] uploading on betalabs now works jdlrobson, MaxSem :) [17:56:09] http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Ghost_hunting [17:57:43] oh actually maybe not [17:57:55] ugh i use :D in my review comments too much. github keeps suggesting an emoticon for :dancer: or something [17:58:33] [Commons-iOS] brion pushed 23 new commits to master: http://git.io/snoKxA [17:58:33] Commons-iOS/master 7746a0a Monte Hurd: Shows picture of the day on login screen... [17:58:33] Commons-iOS/master 120a07c Monte Hurd: Fixed picture of the day resolution issue... [17:58:33] Commons-iOS/master f3b71df Monte Hurd: Fixed url encoding issue [17:58:33] ah yes, yes it does [18:06:33] New patchset: Jdlrobson; "Show upload cta to anonymous users who come from nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67111 [18:06:46] awjr: MaxSem I just reviewed this patch with jgonera and this is the end result if you want to merge (jgonera in a meeting now) ^ [18:07:23] we're past cutoff, right? [18:08:01] yeah but michelle said she didn't mind if that got merged [18:08:26] okay [18:08:44] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67111 [18:09:16] it's erally cool to see the notifications in beta :D [18:09:25] jgonera: ^ [18:10:14] awjr: MaxSem found a few bugs [18:10:14] awjr, in a meeting with tfinc now [18:10:21] gonna fix up now [18:10:27] np jgonera, just giving you an e-high-five [18:10:28] effecting preview and uploads [18:12:37] bugs found 1) Preview fails on large chunks of text [18:12:44] 2) Photos get inserted above the page menu [18:12:54] 3) Michelle's bug she raised about styling issues [18:13:16] is 2 in stable jdlrobson? [18:13:23] awjr: no [18:13:40] where did michelle go? [18:14:34] jdlrobson: ok; quick fixes-ish? [18:14:54] awjr: yup [18:15:01] New patchset: Jdlrobson; "Use post for getting previews" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67127 [18:15:01] there's 1 for previee ^ [18:15:01] sweet [18:15:02] * awjr looks [18:16:03] unit tests break [18:17:11] oh nm [18:17:17] my local checkout was dirty [18:18:28] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67127 [18:21:05] ok let's build a test flight build… whee [18:21:20] ok, non-debug… device build... [18:21:25] check the code signing... [18:21:38] oh increment version [18:21:58] brion: awesome! [18:22:26] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/WFKgNQ [18:22:26] Commons-iOS/master 65c000b Brion Vibber: bump to 1.0.5 [18:24:27] New patchset: Jdlrobson; "Photo upload tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67130 [18:24:42] awjr: ^ so i just want to run this past jgonera when he's back - have a question for him [18:24:57] k [18:25:59] hey there :-] [18:26:14] hi hashar! [18:26:33] I came here to get a recommendation for a new phone :-] [18:26:46] last time proven to be successful (got a Galaxy Nexus) [18:28:50] heh i still use my galaxy nexus :p [18:28:55] i bet brion has a good recommendation [18:29:59] seems the nexus is no more sold :/ [18:30:28] i'm pretty happy with nexus 4 [18:30:33] three main complaints: [18:30:42] 1) it's physically large. but that's the trend these days [18:30:51] 2) the back is slippery and sometimes it slides off things [18:30:57] 3) no LTE, but hspa+ is pretty good [18:31:54] yeah i find nexus 4 to be too large :/ [18:35:31] i want a nexus 3.5 :) [18:35:41] i was using my old nexus one a lot in amsterdam [18:35:44] I might borrow a Galaxy S3. [18:35:48] i kinda miss its size [18:36:00] but its screen is awful and google maps keeps crashing on its ancient android 2.3 :) [18:36:50] you get 2.3 on the Nexus ? [18:36:59] I got 4.1 iirc [18:37:02] went with the phone [18:37:15] nexus s i think has 4.1 or at least 4.0 [18:37:16] not nexus one [18:38:10] I got that one : http://en.wikipedia.org/wiki/Galaxy_Nexus [18:38:20] released in nov 2011 [18:38:30] ah and there is http://en.wikipedia.org/wiki/Nexus_One [18:38:43] so many models, it is hard to keep track of all of them [18:38:51] jdlrobson, so we haven't deployed eventlogging for editing yet, right? [18:38:51] http://en.wikipedia.org/wiki/Nexus_S <- this was the intermediate one i didn't get [18:39:19] so i got both the brokenness of the Nexus One (shitty screen, tiny partition, no 4.x upgrade) AND the brokenness of the Galaxy Nexus (CDMA version has no GSM support, crappy build quality) [18:39:33] much happier with the 4 [18:39:38] Maryana: that will go out today [18:39:44] gotcha [18:39:58] just going through the stories in ready for signoff [18:40:00] Maryana: today we do :D [18:40:04] sweet [18:45:00] brion: gonna add a few bundled images. tomasz suggested end of day we push one more test flight update so tomorrow at demo if people download they'll see a nice image set [18:45:10] sounds good [18:46:46] New patchset: Jdlrobson; "Photo upload tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67130 [18:51:07] New patchset: Jdlrobson; "Photo upload tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67130 [18:52:31] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67130 [18:55:36] hmm, MW 1.21 + REL1_21 MF === fail:P [19:43:05] mwahaha Allowed memory size of 524288000 bytes exhausted [20:03:20] wtf i have to close Xcode to upgrade itunes? [20:03:25] * brion slaps apple [20:08:29] brion: you were right. their is no key to the cabinet at the office [20:08:34] figures [20:08:36] when could you get in tomorrow to test? [20:08:45] i can swing by this afternoon or i can come in fish tomorrow [20:08:48] 9ish [20:08:54] autocorrect wtf [20:08:55] 9'ish works [20:09:02] ok [20:09:04] that'll give us about an hour [20:09:20] emergency fallback is to use screen sharing and the iOS simulator on monte's laptop [20:09:26] yeah [20:09:36] but we should get it working it's been pretty reliable last couple of demos [20:09:43] we want to use the app to take a photo of hte metrics meeting and need a real device for that [20:09:51] ah yeah [20:09:56] makes for a way cooler demo :D [20:09:57] but worst case we do it all in simulator [20:10:34] i've done a pretty big overhaul of the android column in the backlog. moved a few items to brainstorming, rearranged a lot, and did some general ordering by importance [20:10:45] merged a number of items that were dupes :) [20:11:12] also added more text tags to make it easier to filter the list [20:11:18] brion: did monte talk to you about holding off on 1.0.6 till this afternoon ? [20:11:34] tfinc: yeah, he was going to add some more sample images [20:12:52] grrr Google Play is *aggressively* prompting me to auto-update apps when on wifi. i just want to see the 'what's new' before i install things, is that so wrong? [20:20:08] what is up brion [20:23:55] hey zz_YuviPanda [20:24:20] zz_YuviPanda: i did a big refactor of the 'android'c column in the trello backlog, pls take a peek and give comments :) i sorta prioritized it top to bottom [20:24:53] man i'm AFK for five minutes and he wakes up and goes back to sleep ;) [20:32:23] brion: thanks for the triage pass. let me know when its good for me to do a final prioritization pass [20:32:46] tfinc: go for it [20:34:17] mhurd: oh that bug about slow performance on the iPod touch transition reminds me; i've got a couple old iPhone 3Gs's. that's our minimum supported hardware, we should probably test on it :) [20:35:24] brion: its funny. if you tap cc then the transition is super fast [20:35:35] wacky [20:35:53] brion: it's critical to make that faster as the experience is stunning when it transitions correctly [20:36:02] *nod* [20:36:08] let's bump that to the top! [20:39:19] i will as soon as bugello picks it up. awjr_lunch .. is it running ? [20:40:03] o_O [20:40:04] should be [20:40:38] i'll take a look after this mtg [20:41:02] awjr: i'm waiting for it to pickup https://bugzilla.wikimedia.org/show_bug.cgi?id=49207 [20:41:06] did it choke on it ? [20:41:26] tfinc it currently runs every hour [20:41:33] last run was about 45 ins ago [20:41:50] brion: ya good idea [20:42:05] ahh ok [20:42:09] awjr: on the hour ? [20:42:20] on the 55 [20:42:22] then lets wait for it to be picked up [20:42:23] thanks [20:42:28] np [20:46:23] mhurd: has the bundle of images been pushed to master ? [20:46:59] tfinc: not yet [20:47:45] mhurd: lemme know when pull req is ready :D [20:48:03] brion: will do [20:50:01] k [20:50:11] i want to start showing it off :D [20:54:52] mhurd: can you confirm the quality of the bundled 6/5 image. it looks low res on the iPad simualator (non retina) [20:55:53] yurik & dr0ptp4kt, should Zero be deployed from master? [20:56:00] MaxSem, yep [20:56:05] gut [20:56:30] unless jdlrobson has any objections to dr0ptp4kt 's revert last night [20:57:31] mhurd: for simplicity can you also bundle those as a .jpg file and a .json or .plist file with the metadata? will make it easier to find/maintain the bundled files [20:57:47] looks like right now it's a plist containing both the dictionary data and an nsdata with the jpeg :) [21:01:13] tfinc: ya [21:06:05] dr0ptp4kt, is it live? [21:06:12] oops, i meant MaxSem [21:06:28] no [21:10:07] team, do you have config changes to deploy? [21:10:17] awjr, jdlrobson, yurik, dr0ptp4kt^^ [21:10:27] MaxSem: yeah jdlrobson had one [21:10:49] MaxSem: i've started using this query to double check: https://gerrit.wikimedia.org/r/#/q/operations/mediawiki-config+(owner:jdlrobson+OR+owner:maxsem+OR+owner:jgonera+OR+owner:awjrichards)+is:open,n,z [21:11:44] MaxSem, nothing additional beyond the tip of master for both extensions. [21:15:26] awjr, dr0ptp4kt, jcmish, jdlrobson, jgonera, yurik - new code is live on testwiki, please test:) [21:15:33] w00t! [21:15:49] \o/ [21:16:17] MaxSem: just to check are you cherry picking the core change? [21:16:30] what core change? [21:16:35] it seems you didn't [21:16:39] 1s i'll find it [21:17:11] errgg [21:17:15] * jdlrobson hates hunting for dependencies [21:19:16] https://gerrit.wikimedia.org/r/63584 < MaxSem [21:20:17] yurik, are you seeing zero banners? [21:21:50] automation tests passed [21:22:11] mhurd: brion: legal stories for attribution are now in the backlog. can we easily pull what kind of license an image has been donated with ? [21:22:28] 'easily' :) [21:22:28] Manually testing now [21:22:31] semi-easily [21:22:37] yurik, got booted from irc. sorry. you see zero banners? [21:22:41] if it uses known category or template we can manage [21:22:52] deploying that change [21:22:52] er [21:22:53] dr0ptp4kt yep - on test [21:22:55] brion: it really should be an api feature [21:23:00] yeah [21:23:02] MaxSem: did you pick up that core change? [21:23:06] its dumb if we have to parse for it [21:23:08] ^^^ [21:23:10] well that's a future step -- to make that machine-readable on commons [21:23:19] dr0ptp4kt - i don't think zero is set up on the test domain [21:23:25] brion: background on the cache file format - they're serialized dictionaries with "image", "user", "metadata" and "date" keys. getting all associated data is a single "NSKeyedUnarchiver unarchiveObjectWithData:" call which returns the original dictionary. did it this way so everything about the image, including all of the metadata is quick at hand. made bundling easier too. [21:23:26] doh sorry MaxSem, i am blind [21:23:28] as we'll need to detect the license and provide a link to its terms [21:24:07] yurik, yeah, i think you're right. i thought it did work at one point, but it behaves differently now. [21:24:12] mhurd: well you need some sort of tool to fetch them and create that data format [21:24:16] awjr: bugello failed to pickup the new bug :( [21:24:24] cherry-picked and deployed [21:24:26] what's the bug tfinc? [21:24:37] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=49207 [21:24:44] brion: "NSKeyedUnarchiver unarchiveObjectWithData:" does it all :) [21:24:44] eek, just realized i'd been logged out of IRC for the past 20 min [21:25:02] what's up w/deployment? are we live on test? [21:25:26] mhurd: well we may fiddle with that later so it's easier to share the files with the android app, which isn't cocoa-based ;) [21:25:31] but that'll be fine for now, continue... [21:25:33] Maryana, it's on test. [21:25:43] brion: everything in the dict is NSCoder compliant so serialization is free [21:25:47] brion: ah gotcha [21:25:54] thanks dr0ptp4kt [21:26:11] that is weird tfinc, it shows up in feed so i have no idea what happened [21:26:21] tfinc i'll have to dig into it later after deployment [21:26:23] awjr: did it not make it onto the board ? [21:26:24] brion: *NSCoding* not coder [21:26:32] tfinc looking through the logs, no [21:26:53] New patchset: MaxSem; "Lots of minor fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67157 [21:26:53] New patchset: MaxSem; "Rm unused language selection stuff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67158 [21:26:53] New patchset: MaxSem; "Reduce $wgMFCustomLogos cruft" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67159 [21:26:56] quick look shows nothing obvious went wrong, so will require a little sleuthing [21:28:43] dr0ptp4kt, btw, i accidently discovered cool FF tool - Alt+Command +M-- it allows very easy way to rotate and resize screen for mobile testing [21:29:00] yurik, sweet [21:29:26] it might even be built-into Firefox [21:33:28] i just got a JS error when trying to watch a page in beta [21:33:34] yurik: the responsive view mode? yeah that's new in the dev tools [21:33:37] i use it a lot :D [21:33:40] jdlrobson: ^^ [21:33:51] jcmish: ^^ [21:33:52] awjr: what page? [21:33:55] sec [21:34:00] that would be useful to know :) [21:34:08] https://test.m.wikipedia.org/wiki/Sandbox/css1?debug=true [21:34:44] jdlrobson: here's the error: http://pastie.org/8011914 [21:35:52] awjr: bug is on the trello board now [21:35:59] did you do something to make it show? [21:36:04] tfinc er [21:36:11] only if tailing log files counts :p [21:36:54] tfinc i did also change the cronjob to run every 5 mins so i can keep an eye on it better [21:36:59] so, i dunno what happened [21:37:04] i'll take a closer look after deployment [21:37:15] awjr: works for me [21:37:44] sorry awjr was looking at my ipad didn't see this [21:38:02] jdlrobson: are all your resources loading with 200 or are some 304s? maybe you're using some cached js [21:38:04] let me give it a shot... the automation didn't break on adding to the watchlist [21:38:27] huh, it just worked for me o_O [21:39:17] dunno what happened, it seems to be working reliably for me now [21:39:26] maybe a race condition? [21:39:52] edit eventlogging doesn't appear to be working :-/ [21:40:23] config change will need to go out first, i think Maryana [21:40:29] ah, gotcha [21:42:07] awjr I can't get it to happen either [21:42:11] I tried it with different UAs [21:42:14] meh [21:42:15] which one are you using? [21:42:40] Maryana: MobileWebEditing schema was added in a config change [21:42:53] https://gerrit.wikimedia.org/r/#/c/65843/ < should work once live [21:42:56] roflmao; my dog just turned on the roomba [21:43:04] hahahaha [21:43:13] omg she just did it again after it docked on its own [21:43:13] pix or it didn't happen [21:43:17] damn! [21:43:22] pix uploaded via mobile [21:43:26] this is a notable event [21:43:31] lol [21:43:42] HHAHAHAHHAHA [21:43:44] is it chasing her? [21:44:04] it wiggled around for a sec, freaked her out, then docked :p [21:44:13] jgonera points out we broke the refresh button on beta for nearby page [21:44:20] we now see the echo button [21:44:36] oops [21:44:39] indeed [21:44:53] something we need to fix now or can live with? [21:44:59] perhaps the notification dude should not be present in overlays [21:45:02] Maryana: ^^ [21:45:49] it's not an overlay, it's a special page [21:45:56] what jgonera said :) [21:46:11] oh [21:46:13] I think it should be present on all pages, but we could squeeze in the refresh button next to it in nearby [21:46:26] we should have the goal of making special page headers consistent with normal pages [21:46:41] yeah, and i'd like to know when i have notifications even when i'm on a special page [21:46:55] yeah, i get confused because special pages looks more like overlays than regular pages [21:47:04] awjr: we're working to fix that [21:47:07] Maryana: can we live with it as-is or fix before deploy? [21:47:31] (problem is not in stable) [21:47:31] i think it's nbd [21:49:16] cool [21:49:22] i will file bug [21:51:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=49214 [21:51:35] New patchset: Jdlrobson; "Beta: Reinstate refresh button on nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67164 [21:51:37] ^ fix [21:51:41] \o/ [21:51:42] okay how's it looking for everyone I just finished stable and beta and look pretty good [21:51:53] oh, jdlrobson already fixed it. hehe [21:51:54] New patchset: Jdlrobson; "Bug 49214: Reinstate refresh button on nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67164 [21:52:32] otherwise things are looking OK [21:52:44] looks good tom e [21:52:54]