[00:00:45] clearly :D [00:02:02] jdlrobson: ah, hlist is meant for readable, 'bulleted' list in a horizontal format. [00:02:17] so it's adding, after each list element. [00:02:20] Maryana: http://www.deathandtaxesmag.com/195348/18-obsolete-words-which-should-have-never-gone-out-of-style/ [00:02:32] but that's not what you want. [00:03:21] jdlrobson: we didn't write it with your usecase in mind :D [00:03:43] well to me hlist means horizontal list - I've used it commonly like that in various projected [00:03:55] I would expect in a perfect world you have hlist bulleted [00:04:05] or some other class that introduces the bullets [00:04:12] (obviously i know this is a big undertaking in this case) [00:04:17] *i suspect [00:04:30] yeah, that would renaming all uses in en.wp :D [00:05:06] oh tfinc we didn't reschedule 1:1 - are you up to doing it now? [00:05:56] done [00:06:43] jdlrobson: we use this class like this in UI and content btw... :/ [00:06:50] tfinc im busy 1-3 on Fri [00:06:55] actually 12-3 now [00:07:05] oh doh [00:07:06] can't read [00:07:11] you scheduled for 3 :) [00:07:14] tfinc: ahahah [00:07:19] thedj: so I'm going to rejig the skin html so that the page menu and h1 is not inside #content [00:07:29] that way we can limit the scope of this css rule to the content element [00:08:13] did somone say changing the page html? [00:08:45] jdlrobson: well the skin html shouldn't be inside content regardless... [00:08:54] eh menu/h1 i mean [00:11:25] awjr: don't worry beta only :) [00:11:36] thedj: we are saying the same [00:11:54] phew! [00:12:22] hmm, it's a shame we added all this extra meaning onto hlist inside en.wp [00:12:24] New patchset: Jdlrobson; "Beta: After a successful edit reinitialise the last modified timestamp" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67199 [00:12:24] New patchset: Jdlrobson; "Beta: Reinitialise talk overlay after a page refresh" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67200 [00:12:24] New patchset: Jdlrobson; "Make talk overlay use M.history.retrievePage" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67201 [00:12:59] i remember we had a discussion on this when we introduced it, but i believe 'let's keep the name simple'-camp won that... [00:13:25] thedj: i think it's a good thing that we are identifying commonality [00:14:18] btw, in dragons mode, the diff footer is not staying at the bottom when i scroll... [00:18:20] and i see there is now notifications under a 'person' icon. That guy needs a talk bubble, i'm thinking 'account' every time I look at it :D [00:18:56] thedj: the notification number only shows if you have some - i agree i think it should say 0 [00:19:26] thedj: yeh the fixed positioning code is really buggy :( [00:19:45] like the new page controls. [00:20:57] the spinner of the watch action, is a bit too low positioned for me. [00:21:14] thedj: yeh it still needs some tweaks [00:21:22] i'm excited by it though :) [00:22:25] contrast of those icons can be a bit stronger in my opinion. [00:25:56] thedj: you should raise these concerns on the design list to make sure they don't get lost! [00:29:18] mobile-l [00:29:34] since i'm not on the design list, and it's sooo zzz time at 02:29 AM [00:29:50] thedj: roger and that definitely is zzz time :) [00:32:03] Maryana: when did we run the commons banners ? [00:32:35] 4/29 to 5/6 [00:32:40] k [00:34:24] jdlrobson: on the topic of template css btw. ideally, we could do multipart contenthandler for that... instead of adding a new ugly thingie. [00:34:52] thedj: i'll start a wikitech thread on it in the next few days :-) [00:35:33] k, nite ! [00:36:06] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [00:36:21] nite thedj :D [00:36:28] New patchset: Jdlrobson; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [00:44:16] New patchset: Jdlrobson; "Search results hook fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209 [00:47:02] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/62412 [01:13:36] New patchset: JGonera; "Rename View#initialize to View#postRender" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67217 [03:00:33] New patchset: Yurik; "Redirect Special:Zero=>Main_Page if 'showZeroPage'" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67226 [03:01:37] New patchset: Yurik; "Redirect Special:Zero=>Main_Page if 'showZeroPage'" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67226 [03:56:13] New patchset: Yurik; "Expanded Zero logging to case of zero->zero referee" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67228 [05:39:27] [Commons-iOS] montehurd opened pull request #82: More featured image goodness - 10 bundled image (master...featuredImage) http://git.io/LBpJcg [10:07:42] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67096 [13:48:20] [Commons-iOS] brion pushed 5 new commits to master: http://git.io/BZpfqQ [13:48:20] Commons-iOS/master 9cb74f3 Monte Hurd: Made picture of day attribution update as the image transitions [13:48:20] Commons-iOS/master 69bb76d Monte Hurd: Fixed bug with picture of the day's having no metadata [13:48:20] Commons-iOS/master 3b349de Monte Hurd: Added ability to bundle multiple pics of the day [14:50:17] * YuviPanda waves at brion_ [14:50:22] * YuviPanda also waves at brion [14:50:28] you were talking about a trello board y'day? [14:50:46] heyy [14:51:14] YuviPanda, i did a big overhaul on the android backlog column on https://trello.com/board/mobile-app-backlog/517b115c243fd8d361000faa [14:51:22] also there's some cool stuff under 'brainstorming' column [14:51:33] ah, okay [14:51:45] feel free to make comments or add stuff [14:51:48] i will! [14:52:03] brion_: one of the biggest things we should do once I start back again is campaign support, to make sure it is in in time for wikimania [14:52:21] yeah [14:53:23] YuviPanda, have you seen the visual updates on ios? it's looking pretty awesome. we'll do a demo on the metrics meeting today [14:53:29] no haven't [14:53:31] should do soon [14:53:36] i'll go off in another hour though [14:53:39] last exam on saturday [14:53:41] ok :) [14:54:27] so you're back fulltime next week right? [14:55:07] brion_: yup! [14:55:14] yayy [14:55:31] brion_: I want to move the 'volley' card on top [14:55:37] brion_: it'll definitely clean up our code a lot [14:55:43] *nod* [14:55:48] and that has some caching infrastructure too? [14:55:49] will also help with the cache situation [14:55:51] yes! [14:55:55] yesssss [14:56:18] brion_: well, UIL has caching too. we just haven't configured it properly, I Think [14:56:40] brion_: but moving is gonna be a little biggish, since I'll have to rewrite java-mwapi [14:56:50] and since Volley is Android-only [14:56:55] i'll probably write volley-mwapi [14:57:04] and considering the extension points on Volley, should be pretty simple [15:01:10] brion: commented on a few [15:01:16] replied on em ;) [15:01:30] i like trello's real-time updates, i don't have to sit there and refresh [15:01:53] if only fog creek did open source :) [15:01:57] they make good stuff [15:03:53] brion: yeah [15:03:57] YuviPanda, btw the latest gmail updtae does have a pull to refresh ;) [15:05:13] ok i gotta get ready and head into the office to set up for the demo [15:05:20] i'll try not to spread my plague [16:36:46] New review: MaxSem; "Why do this in a hook while this can be done in the special page itself?" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -1; - https://gerrit.wikimedia.org/r/67226 [17:27:35] New patchset: Yurik; "Added optional 'comment' field at the top of the zero config" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67277 [17:33:11] dr0ptp4kt, dfoy - should i name it "comment" -- http://api.beta.wmflabs.org/wiki/Zero:624-02 [17:33:20] or is "note" a better word? [17:33:43] yurik, i'm indifferent. [17:33:52] dfoy, ? [17:33:54] yurik, that is to say i'm indifferent on the name, not on the concept :) [17:34:05] understood [17:34:20] yurik: note would be fine [17:34:49] dfoy, you think "note" is better? [17:35:24] * yurik loves bikeshed questions... [17:35:37] yurik: really I don't think there's much difference. Go ahead and leave it as comment [17:35:45] k [17:35:50] yurik: thx [17:36:08] done, dr0ptp4kt review [17:36:16] yurik: BTW, we do have additional IP ranges for Tunisia. I'll email you the updates [17:36:31] dfoy, please add them to the zero page [17:36:42] (i meant config) [17:37:01] yurik: I'll update both :) [17:37:13] MaxSem, i'm not exactly sure i understood your concern. [17:37:51] do that from ZeroSpecialPage [17:38:13] MaxSem, sure, but currently zero special page shows is a stub [17:38:22] so it would involve rewriting all the logic [17:38:32] wouldn't it? [17:38:48] I see no reason why new functionality shouldn't go there [17:40:34] yurik, see email re: code cutoff and lightning deploy. yurik, working through gerrit reviews now. [17:40:53] MaxSem, sure, do you have any pointers on special page implementation? Also it would still be a lot of refactorings -- currently the hook page has all the config state in it :( [17:41:04] dr0ptp4kt, thx [17:41:59] New patchset: JGonera; "Rename View#initialize to View#postRender" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67217 [17:46:00] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67199 [17:50:43] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67200 [18:02:47] MaxSem: hookaborted - in what cases would that error happen on editing? [18:03:01] AssertEdit? [18:03:15] are you seeing it on WP or locally? [18:03:55] seeing it in the logs [18:04:08] on en.wiki [18:04:37] also rvnosuchsection on persian wiki [18:04:41] meh, worst part of edit api where you can't tell wtf is going on [18:05:09] I opened a bug about it like 5 years ago [18:05:24] rvnosuchsection is ok [18:10:27] MaxSem: there is a high chance i'll have to move your review again. Prep for the metrics meeting ran longer then expected [18:10:38] np [18:12:19] lolz: "(Upload log); 13:46 . . Ashley nolasco (talk | contribs) uploaded "File:I am selling a french poodle for $50 call (956)588-6118 2013-06-06 08-46.jpg" ‎(Donated image from mobile) (Mobile edit)" [18:12:31] sadly deleted [18:18:01] New patchset: Jdlrobson; "Lock viewports in overlay mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66572 [18:18:48] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66572 [18:18:54] New review: Jdlrobson; "Max why -1. I don't understand why this doesn't work for you as discussed before..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66901 [18:20:15] New review: Jdlrobson; "These patches have been -2ed from some time. Should they be abandoned?" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/64510 [18:20:24] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67228 [18:23:19] New review: Jdlrobson; "This is actually used from the language overlay in beta when a search return no results due to a lan..." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/67158 [18:27:51] New review: Jdlrobson; "Haven't tested but trust this will work - code looks fine :)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/67159 [18:33:48] New patchset: Jdlrobson; "Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888 [18:40:02] New patchset: MaxSem; "Bug 49030: Make WML self dependent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66901 [18:40:10] jdlrobson, ^^ [18:40:58] MaxSem: what did you change? [18:41:31] https://gerrit.wikimedia.org/r/#/c/66901/3..4/includes/skins/SkinMobileWML.php [18:41:31] oh i see.. but initPage gets called by outputPage [18:41:51] so why should this make a difference? [18:41:56] your code outputted the needed section and then whole html again [18:42:07] * awjr high-fives Maryana [18:42:12] :D [18:42:15] (cheers for that link though didn't realize gerrit allowed you to compare patches) [18:42:21] erik tried to cut me off but i resisted! [18:42:22] Maryana: likewise :) [18:42:39] Maryana: "(Upload log); 13:46 . . Ashley nolasco (talk | contribs) uploaded "File:I am selling a french poodle for $50 call (956)588-6118 2013-06-06 08-46.jpg" ‎(Donated image from mobile) (Mobile edit)" [18:42:40] it's like you planted vibha there to plug the wikimania talk jdlrobson [18:42:41] sadly deleted.. [18:43:02] New patchset: Dr0ptp4kt; "Added optional 'comment' field at the top of the zero config" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67277 [18:45:41] MaxSem: how will wikidata geo tags affect us ? [18:45:51] denny just mentioned their going out next week [18:45:57] not sure I understand [18:46:04] ah [18:46:38] when they have the coordinate data type we can integrate with them [18:47:17] but from discussions with them I understood that they will _start_ working on it next week... [18:48:14] yurik, patches approved. rebased the 'comment' field one. [18:48:25] k [18:48:41] MaxSem: what coordination work will we ned to do with them? [18:49:05] jdlrobson, so where do we use Special:MobileOptions/chooseLanguage, exactly? [18:49:14] MaxSem: in beta click blue button [18:49:21] type in 'maxsemlanguage' [18:49:26] click the link [18:50:07] MaxSem: i think we should split it into a separate special page and use it to fix bug 40678 [18:50:12] tfinc, worth discussing with them [18:50:17] jdlrobson, bleh [18:50:40] Change abandoned: MaxSem; "meh" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67158 [18:51:11] I grepped for 'chooseLanguage'... fail [18:52:41] btw yeeyyy we made bbc http://www.bbc.co.uk/news/world-radio-and-tv-22736689 [18:58:26] hangout-ception! [18:59:22] New review: MaxSem; "> Won't this result in this var being set twice?" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66667 [18:59:22] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66667 [18:59:35] New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66901 [19:04:18] MaxSem: can i leave with with you to do ? [19:04:27] MaxSem - is wgHtml5 deprecated? https://m.mediawiki.org/wiki/Manual:$wgHtml5 "Removed in version still in use" [19:04:46] but deprecated and doesn't do anything [19:05:07] tfinc, sure - I'll keep in touch with them [19:05:22] commit message should be clearer it;s very confusing can you at least link to a wikitech thread [19:05:32] New patchset: Jdlrobson; "$wgHtml5 is deprecated" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67096 [19:06:12] ^ MaxSem if you can expand the commit message to give it more context I'll merge [19:06:52] MaxSem: do you mean it's now the default? https://m.mediawiki.org/wiki/HTML_5 [19:06:53] it is deprecated as its doxygen docs say - sounds pretty clear [19:07:11] MaxSem: where are said docs? [19:07:22] DefaultSettings [19:07:29] all i'm asking for is a link :) [19:09:12] New review: awjrichards; "This has a dependency on an abandoned changeset. You'll need to make this change based off of someth..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67159 [19:10:43] New patchset: Jdlrobson; "Reduce $wgMFCustomLogos cruft" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67159 [19:11:04] New review: Jdlrobson; "Arthur I cherry picked it. Can you review now?" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/67159 [19:15:13] New review: Jdlrobson; "I'm confused I can't find any record of this being deprecated" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67096 [19:16:17] New review: Jdlrobson; "jenkins is dead. Ran PHP unit tests locally" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66901 [19:16:17] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66901 [19:16:45] New review: Jdlrobson; "jenkins appears to be dead again" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67201 [19:16:45] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67201 [19:18:01] New review: awjrichards; "This looks OK, but should also update documentation for the varaible in MobileFrontend.php. We shoul..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/67159 [19:20:40] New review: MaxSem; "Pfft https://git.wikimedia.org/blob/mediawiki%2Fcore.git/d7a61d72231861755f0ccdaf80d7b4388cebd5df/in..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67096 [19:20:40] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67096 [19:32:42] New review: MaxSem; "From looking at the code, the purpose of it appears to be that Patrick didn't know about per-project..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67159 [19:40:31] New patchset: Jdlrobson; "Add some full stops" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67298 [19:49:33] New patchset: awjrichards; "Reduce $wgMFCustomLogos cruft" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67159 [19:50:30] awjr_lunch, I was working on the same:P [19:50:42] lol doh sorry! [19:51:06] no, thank you:) [19:51:09] :D [19:53:11] MaxSem: https://gerrit.wikimedia.org/r/#/c/67300/1 [19:55:00] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67298 [19:57:19] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67159 [19:57:50] is jenkins dead again? [19:58:08] yep [19:58:11] :( [20:02:53] yurik: ping [20:03:08] dfoy, hey [20:03:10] MaxSem: I said add it in the commit message o_O [20:03:19] https://gerrit.wikimedia.org/r/#/c/67096/1 < adding as a comment is no help [20:03:24] yurik: you on the call? [20:03:28] dfoy, yep [20:03:35] especially when it gets mangled.. [20:05:28] sigh [20:11:24] MaxSem: https://gerrit.wikimedia.org/r/#/c/67266/1/includes/api/ApiParse.php < I'm trying to pass preview: true as a parameter to the parse api but it still gives me the error [20:11:41] §ion=0 [20:11:52] you're previewing a section, right?:) [20:12:11] api.post( {action: 'parse', preview: true, title: options.title, text: options.wikitext, prop: 'text' } ).then( function( resp ) { [20:12:41] ^ MaxSem i'm doing that [20:13:19] (this is the bit where you tell me i should be using another api call and i throw my head on the table) [20:15:07] yurik, i'm gonna start a page on the mediawiki site regarding ESI and JavaScript stuff [20:15:19] yurik, i'm making some other link updates, incidentally [20:15:24] jdlrobson, ^^ [20:15:46] dr0ptp4kt, would it make sense to reply to my original architecture email with your ideas? [20:16:22] yurik, yes. i plan to do that, but also want to make sure we get a blueprint out there of sorts. [20:16:45] yuri, er, s/out there of sorts/of sorts out there/ [20:16:47] sure thing. If you want, we can put it as an RFC into our RFC page system? [20:16:52] MaxSem: ? o_O [20:17:15] [00:11:43] §ion=0 [20:17:16] dr0ptp4kt, http://www.mediawiki.org/wiki/RFC [20:17:47] dr0ptp4kt, could even re-use the Zero arch page [20:17:57] and move complete sections to archive [20:17:58] yurik, yeah, cool. i probably should create the article in my own userspace, then migrate the contents. [20:18:03] yurik, gotcha [20:18:25] MaxSem: what does section=0 mean? [20:18:41] i don't see why i need 2 parameters.. this is just weird [20:19:23] this means that you're previewing a section [20:19:33] but to me that means initial section [20:19:44] Parser has 2 preview modes [20:19:46] section=true or section=1 should mean this is a section [20:20:09] (or section=yes) [20:20:27] this parameter is a number [20:20:39] so it could be anything? [20:20:50] a number [20:25:24] New patchset: Jdlrobson; "Bug 49218: Hide errors in preview output" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67310 [20:35:10] Change merged: Yurik; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67277 [20:37:47] jdlrobson, regarding card 800: it's being a bit used in api.php?action=parse&mobileformat=... usage stats: https://graphite.wikimedia.org/dashboard/temporary-27 [20:38:00] guess we can deprecate it [20:38:18] but it's not instantaneous [20:50:22] New patchset: MaxSem; "Lots of minor fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67157 [20:57:55] [Commons-iOS] montehurd opened pull request #83: Login page swipe up or down to show or hide keyboard. (master...featuredImage) http://git.io/oPMRHQ [20:59:25] dr0ptp4kt, deployed [20:59:33] already getting tons of zero log entries [21:11:39] yurik, thx - would you please send some my way? [21:15:10] dr0ptp4kt, sent [21:15:18] yurik, thx [21:15:39] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66899 [21:18:50] lol http://blogs.windows.com/ie/b/ie/archive/2013/06/05/internet-explorer-10-is-the-most-energy-efficient-browser-on-windows-8.aspx [21:18:52] dr0ptp4kt, did you see it? [21:19:29] (i meant the log, not the troll bait MaxSem is sending :-P [21:19:33] yurik, it didn't come at first, but i see it now [21:19:57] p.s. ha. [21:20:42] of course ie10 is the most energy efficient!!! they should have also compared FF with a computer that has been turned off [21:21:04] awjr_lunch: any reason why jdlrobson isn't listed as a tech lead here http://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/Team/Roles_and_responsibilities ? [21:21:40] nope, must've missed updating the document when that happened [21:22:32] actually a lot of the 'who' is out of date [21:22:33] fixing now [21:23:06] New review: MaxSem; "Note that the dependency doesn't have to go live before this change, the API will simply issue a war..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67310 [21:23:07] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67310 [21:23:12] awjr: thanks, i'm about to refer to it in a meeting. [21:24:23] tfinc, brion is still listed as the dev in zero [21:24:45] tfinc: fixed [21:25:29] i think we came up with that one immediately after the thoughtworks training; that's not linked with the rest of our docs on http://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web [21:26:15] perhaps we ought to replace http://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web/Roles_and_responsibilities with that [21:26:20] since it looks sexier [21:27:08] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/66277 [21:30:37] awjr: do we have any breakdown of titles for mobile like we do for roles ? [21:30:50] tfinc titles? [21:31:02] software dev. sr. software dev. architect [21:31:10] tfinc no [21:31:14] not that i know of [21:31:15] k [21:31:21] that'll be homework for me then [21:31:21] can I be an evil overlord?:P [21:31:29] lol [21:31:33] MaxSem: it's a wiki, be bold! [21:31:43] MaxSem: no, i have that title [21:31:43] :D [21:31:53] i sense a fight to the death coming on... [21:32:01] awjr: prep the cage [21:32:03] eh? I thought you're the good guy [21:32:11] lol [21:32:14] MaxSem: then i'm played my cards well if you think that [21:32:15] ;) [21:32:37] awjr: didn't we do a sr. job desc for you ? [21:32:44] yeah tfinc [21:32:56] link me [21:33:07] og gawd you're going to make me search on office wiki [21:33:31] oh actually that was easier than it has been in the past [21:33:34] https://office.wikimedia.org/wiki/Job_descriptions/Senior_Software_Engineer [21:34:23] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66900 [21:39:05] hmm it's approaching 41C here [21:39:09] New patchset: Jdlrobson; "Return watch list star to search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340 [21:39:41] 42C forecasted through the weekend. [21:39:51] * awjr can't wait for SF [21:40:29] New patchset: JGonera; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [21:41:36] New patchset: Jdlrobson; "Return watch list star to search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340 [21:42:37] hey awjr btw have seen your mail just haven't had time to reply :) [21:42:46] no rush jdlrobson [21:43:19] New patchset: JGonera; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [21:44:00] New patchset: JGonera; "Alpha: Lazy load pages using History.js from search and page content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [21:47:58] New review: Jdlrobson; "Reviewed with Juliusz." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62412 [21:50:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/62412 [21:54:30] [Commons-iOS] montehurd opened pull request #84: Sprint 9 Leftovers. "jpg" extension. Refresh failed l10n. (master...sprint9leftovers) http://git.io/-nUyvg [21:58:03] awjr: can you and an attends ops meeting component to the tech lead ? [21:58:09] something to that effect [21:58:17] coordination and such [21:58:29] tfinc it's already on the other doc; we need to merge those [21:58:38] awjr: which doc ? [21:59:01] http://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web/Roles_and_responsibilities [21:59:03] tfinc ^ [21:59:18] oh yeah, these have to be collapsed [21:59:21] yah [22:01:15] awjr: we should take a lunch when your here and collapse them [22:01:37] totally tfinc [22:05:12] New patchset: MaxSem; "Get rid of several pointless returns" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67352 [22:05:12] New patchset: MaxSem; "Move UnitTestsList handler to MobileFrontendHooks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67353 [22:13:10] awjr: MaxSem New token stuff live from 3pm today :D \o/ [22:13:18] wee [22:13:24] jdlrobson: sul2? [22:13:33] buther time for login handshake? [22:13:39] *butcher [22:13:49] yep :D [22:13:53] just checked with greg [22:14:02] w0000000t! [22:14:23] New patchset: Jdlrobson; "Return watch list star to search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340 [22:14:29] is it available on wmf5 too? [22:18:41] dfoy, you can start adding comments btw [22:19:00] dfoy, its life [22:19:05] live [22:20:38] yurik: thanks, I'll start using it [22:22:56] tfinc do you still have planning poker cards? [22:24:10] MaxSem: Greg thinks so but he's gonna check [22:24:56] New patchset: Jdlrobson; "Hijack Search result links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209 [22:24:56] New patchset: Jdlrobson; "Alpha: Make search results lazy load pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67356 [22:25:40] New patchset: Jdlrobson; "Hijack Search result links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209 [22:25:48] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67356 [22:26:06] New patchset: Jdlrobson; "Alpha: Hijack Search result links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209 [22:26:19] New patchset: Jdlrobson; "Don't lazy load sections on the first load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65134 [22:26:28] MaxSem: i'm surprised you haven't jumped on https://gerrit.wikimedia.org/r/#/c/65134/ ... [22:26:59] but it has JS!:P [22:28:13] MaxSem: only a little and it's all red - the important thing is if it works ;-) [22:28:23] awjr: nope [22:28:29] awjr: just buy a pair [22:28:43] yah [22:30:36] yurik, sent a few simple notes on analysis of select entries. will page through some more. then back to the wiki. [22:30:47] MaxSem: any movement on https://bugzilla.wikimedia.org/show_bug.cgi?id=48551? [22:31:33] jdlrobson, I poked you about it today [22:31:40] o_O when? [22:32:00] MaxSem: poke 404ed [22:32:07] [00:37:48] jdlrobson, regarding card 800: it's being a bit used in api.php?action=parse&mobileformat=... usage stats: https://graphite.wikimedia.org/dashboard/temporary-27 [22:32:07] [00:38:01] guess we can deprecate it [22:32:07] [00:38:20] but it's not instantaneous [22:32:59] MaxSem: any idea what's using it? [22:33:07] is it just people playing with ApiSandbox for instance? [22:33:58] too much load for apisb, must be real users:) [22:34:16] is that 4 users?! (i'm guessing not) [22:34:53] is there anyway we could cleanup html usage without effecting API usage? [22:35:50] we can pull it to somewhere else but not to skin. unless you want the API to cinstruct the skin which is even more kludgy [22:36:10] by the way... http://i44.tinypic.com/67kqkz.png [22:36:25] csteipp: greg-g / jdlrobson: Ah, sorry... that's another part of "SUL". The part mobile wants (centralauth token) should be in wmf6 [22:36:48] sorry all, I misunderstood what was going out/what was wanted [22:37:05] MaxSem: what wiki is that and what browser? [22:37:05] MaxSem: can you file a bug? [22:37:17] my dev wiki, master, opera [22:40:35] New patchset: Jdlrobson; "Rename View#initialize to View#postRender" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67217 [22:41:31] no worries greg-g thanks for clarifying :) [22:42:11] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67217 [22:45:51] jdlrobson, https://bugzilla.wikimedia.org/show_bug.cgi?id=49279 [22:46:02] MaxSem: yup seen it already ;-) [22:47:32] dfoy, come to think of it, you can keep unoptimized IPs in the zero config pages -- i will optimize them in varnish/python script later [22:48:19] yurik: ok that will simplify things. I'd rather keep the IP's out of the partner wiki page [22:48:25] New patchset: MaxSem; "Move some code out of ExtMobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67361 [22:48:44] yurik: What about the ordering? I think they are being sorted right now [22:49:24] dfoy, yes, that's automatic so its easier to compare versions [22:49:43] awjr: bingle doesn't seem to be working [22:49:50] Bug 49218 isn't anywhere to be found in mingle [22:50:01] * awjr looks [22:50:20] dfoy, i could turn it of in theory, but i would rather keep it sorted so that we can easily see what changed [22:50:29] hmm i wish i could see the full history of a bug [22:50:46] there are a variety of ways that can happen jdlrobson [22:50:54] should i just manually create? [22:51:06] sure jdlrobson (try to follow the same card naming convention) [22:51:13] otherwise we may get a dupe at some point in the future [22:51:29] yurik: leave it as it is for now, I'm undecided about that right now [22:51:58] jdlrobson: im not sure specifically why this one got missed, but updating bingle to use the Bugzilla API (rather than an RSS feed) should greatly reduce the number of missed bugs [22:52:05] k [23:06:11] New patchset: Jdlrobson; "Return watch list star to search results Change-Id: Ia4cf3b74694f6e0f43dc80fcfc30cac197827478" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340 [23:06:11] New patchset: Jdlrobson; "Alpha: Hijack Search result links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209 [23:17:50] hmm, I've almost beaten jdlrobson by number of open commits:) [23:18:24] something must have gone sideways in the univers [23:18:25] e [23:18:53] can you guys at least review https://gerrit.wikimedia.org/r/#/c/67157/ because it is prone to merge conflicts like hell [23:19:10] MaxSem: i can take a look when i get to a good stop point [23:19:37] thanks [23:24:38] yo gang, i am super brain dead from jet lag, so i'm heading home - will be online later [23:24:52] anybody need anything from me before i duck out? [23:25:32] we need you to take rest, Maryana [23:25:36] New patchset: Jdlrobson; "Bind the history state change event after replace state" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67374 [23:25:41] maxsem :) [23:25:52] look who's talking! [23:25:55] how are you still awake [23:26:11] it's normal for me [23:26:34] how do you liiiive [23:26:35] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67374 [23:26:43] New patchset: Jdlrobson; "Cleanup: Get rid of several pointless returns and if statements" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67352 [23:27:10] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67352 [23:27:41] New patchset: Jdlrobson; "Move UnitTestsList handler to MobileFrontendHooks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67353 [23:28:20] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67353 [23:28:49] New patchset: Jdlrobson; "Return watch list star to search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340 [23:29:11] New patchset: Jdlrobson; "Alpha: Hijack Search result links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209 [23:36:23] MaxSem: can we kill enableRemovableSections in change https://gerrit.wikimedia.org/r/#/c/65134/6/includes/MobileFrontend.body.php ? [23:37:46] we could [23:37:52] or in a follow-up [23:38:06] New patchset: Jdlrobson; "Don't lazy load sections on the first load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65134 [23:38:09] MaxSem: :D [23:38:22] - code wooooo [23:38:38] MaxSem: merge at will! [23:41:23] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67157 [23:41:41] MaxSem: ^ [23:41:49] awjr, thanks [23:41:52] np [23:42:24] jdlrobson, when I load a non-mainspace page dynamically, the page name in title changes several times to prefixed and unprefixed form [23:42:51] MaxSem: git pull origin master [23:43:00] New patchset: JGonera; "Return watch list star to search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340 [23:43:11] New patchset: Jdlrobson; "Return watch list star to search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340 [23:43:14] jdlrobson, that's in https://gerrit.wikimedia.org/r/#/c/65134/ [23:43:41] New patchset: Jdlrobson; "Don't lazy load sections on the first load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65134 [23:43:48] try it now MaxSem [23:45:00] New patchset: Jdlrobson; "Return watch list star to search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340 [23:45:00] New patchset: Jdlrobson; "Alpha: Hijack Search result links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209 [23:46:15] MaxSem: any good? [23:50:33] jdlrobson, now it doesn't seem to load dynamically at all [23:50:41] o_O [23:53:08] MaxSem: did you kill memcached ? [23:53:28] also the only time a page will load lazy in that patch set is if you have a link in the article [23:53:48] (and a good enough browser - just in case you are using some weird version of opera ;-)) [23:53:56] important thing is can you read the content of sections? [23:54:05] hah, works now [23:57:01] \o/ [23:57:13] MaxSem: so merge at will ;-) [23:59:28] mhm, does it load only mainspace now?