[00:00:05] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67340
[00:00:22] <gerrit-wm>	 New patchset: JGonera; "Alpha: Hijack Search result links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209
[00:02:34] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67209
[00:05:29] <jdlrobson>	 MaxSem: yes.. only namespaced links are hijacked for time being
[00:05:30] <jdlrobson>	 being more careful this time
[00:05:40] <MaxSem>	 ok
[00:06:17] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/65134
[00:06:34] <jdlrobson>	 \o/
[00:07:31] <jdlrobson>	 next deployment is gonna  be awesome
[00:07:35] <jdlrobson>	 alpha is now my favorite mode
[00:07:57] <jdlrobson>	 MaxSem: you will need to rebase https://gerrit.wikimedia.org/r/#/c/67361/ now
[00:08:25] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 49214: Reinstate refresh button on nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67164
[00:09:31] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888
[00:18:44] <gerrit-wm>	 New patchset: MaxSem; "Move some code out of ExtMobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67361
[00:30:02] <awjr>	 oo my nexus 7 just arrived
[09:15:30] <gerrit-wm>	 New patchset: MaxSem; "Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888
[09:15:51] <gerrit-wm>	 New patchset: MaxSem; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888
[13:12:59] <gerrit-wm>	 New review: Zfilipin; "Hi Michelle, do you still need help with this?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[13:23:22] <gerrit-wm>	 New patchset: Zfilipin; "Figured out the css issue this can be merged" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64500
[13:23:22] <gerrit-wm>	 New patchset: Zfilipin; "Zeljko review not merging" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[13:25:00] <gerrit-wm>	 New review: Zfilipin; "Should this commit be abandoned, and https://gerrit.wikimedia.org/r/#/c/64500/ merged?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[13:26:12] <gerrit-wm>	 New review: Zfilipin; "Marking this commit -1 so I know I have reviewed it." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/64473
[13:38:44] <gerrit-wm>	 New review: Zfilipin; "This should be squashed with https://gerrit.wikimedia.org/r/#/c/64473" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/64500
[13:38:58] <gerrit-wm>	 New review: Zfilipin; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[13:50:54] <gerrit-wm>	 New review: Zfilipin; "Please see inline comments." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/64508
[14:03:06] <gerrit-wm>	 New review: Zfilipin; "The commit was not -2ed, but -1ed (verified) by jenkins-bot (as far as I can see)." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/64510
[16:02:50] <gerrit-wm>	 New patchset: Yurik; "rewrote vcl script to verify and fix varnish file" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67450
[16:32:22] <greg-g>	 MaxSem: heya, is there a bug/rt ticket for the osm tile server I can link to?
[16:56:46] <MaxSem>	 https://rt.wikimedia.org/Ticket/Display.html?id=4563
[16:56:51] <MaxSem>	 https://rt.wikimedia.org/Ticket/Display.html?id=3989
[16:57:11] <MaxSem>	 greg-g, ^^
[16:57:25] <greg-g>	 MaxSem: thank you
[17:12:11] <brion_>	 ughhhhhh internet's shit today
[17:12:12] <brion_>	 20% packet loss on comcast
[17:12:28] <brion>	 and crappy latency on t-mobile
[17:12:38] <awjr>	 stupid internet
[17:12:59] <brion>	 on the plus side, if i lose my irc logs i can get them back from the nsa
[17:13:05] <awjr>	 hahahaha
[17:14:19] <awjr>	 Maryana: i manually created a bug card for the bug we were just discussing and added it to this iteration. it's currently at the bottom of the priority ilst; if it's higher priority, can you move it to the right place?
[17:14:28] <Maryana>	 will do
[17:15:03] <awjr>	 oh yeah, bingle is definitely broken
[17:15:25] <awjr>	 jdlrobson: bingle has been dying with the following error:
[17:15:25] <awjr>	 requests.exceptions.ConnectionError: HTTPSConnectionPool(host='mingle.corp.wikimedia.org', port=443): Max retries exceeded with url: /api/v2/projects/mobile/cards/execute_mql.json?mql=SELECT+number+WHERE+Type%3D%27Bug%27+AND+name%3D%27%5BBug+49163%5D+Reader+feature+no+longer+works+on+iOS%27 (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)
[17:16:08] <Maryana>	 also, mono is yelling at us about the bug to redirect users to mobile commons. we probably should just pull the trigger on that
[17:16:41] <awjr>	 it might actually be done Maryana
[17:16:46] <Maryana>	 orly?
[17:16:48] <Maryana>	 that would be nice
[17:16:55] <awjr>	 the code has been merged
[17:16:59] <Maryana>	 w00t!
[17:17:20] <awjr>	 but apparently hasn't been deployed yet
[17:17:28] <awjr>	 (that's on ops)
[17:17:36] <Maryana>	 wanna add a link to gerrit on this? https://bugzilla.wikimedia.org/show_bug.cgi?id=43628
[17:17:44] <MaxSem>	 it has been merged but squids haven't been restarted so it didn't take effect yet
[17:18:37] <awjr>	 don Maryana
[17:18:38] <awjr>	 *done
[17:18:41] <Maryana>	 thx!
[17:19:19] <jdlrobson>	 awjr: MaxSem https://bugzilla.wikimedia.org/show_bug.cgi?id=45517 < have you seen aude's comment and do you know what it means / if we are ?
[17:26:00] <awjr>	 looking, jdlrobson
[17:26:31] <awjr>	 i know nothing about that but MaxSem may
[17:27:01] <MaxSem>	 me neither
[17:27:26] <awjr>	 jdlrobson: aude appears to at least be lurking in the channel though :)
[17:27:58] <MaxSem>	 http://upload.wikimedia.org/wikipedia/commons/5/54/Mobile_W_beta_light.png <-- I guess we don't need it anymore?
[17:28:18] <jdlrobson>	 MaxSem:guess not
[17:28:28] <awjr>	 looking over the exmples that tfinc provided in that bug though, i think it''s something unrelated
[17:28:59] <awjr>	 and it's totally unclear if it's even still an issue
[17:29:09] <awjr>	 perhaps we should cloes that bug for now until someone reports it again and/or it can be replicated
[17:29:21] <aude>	 huh?
[17:29:38] <aude>	 i'll need to take a look at the mobile frontend code to see what you are doing
[17:29:40] <awjr>	 aude: jdlrobson was unclear about your comment in https://bugzilla.wikimedia.org/show_bug.cgi?id=45517
[17:29:57] <awjr>	 and so are me and MaxSem :p
[17:30:02] <aude>	 what do you use for the watchlist query?
[17:30:28] <brion>	 ahhhhhh internet's much better now
[17:30:42] <aude>	 anything with rc_type = 5 could need some special handling
[17:31:05] <aude>	 best to omit it at this point, if for any reason you include it
[17:31:49] <MaxSem>	 do such changes happen outside of wikidatawiki?
[17:32:38] <aude>	 we integrate them into the client watchlist and recent changes
[17:32:39] <aude>	 so yes
[17:33:11] <aude>	 e.g. they change some interwiki link or property of the item and that info is used in wikipedia on some page
[17:33:17] <tfinc>	 awjr: when will 'Mobile redirect for Commons and Wikimania2013' get deployed ?
[17:33:34] <awjr>	 tfinc: MaxSem has been coordinating that
[17:33:39] <tfinc>	 we originally decided not to move that with the bug push as we wanted some dedicated dev time on commons
[17:33:44] <tfinc>	 did you guys decide not to do that ?
[17:33:49] <awjr>	 yes
[17:33:59] <tfinc>	 k
[17:34:08] <aude>	 do rc_type != RC_EXTERNAL if you are not, unless you would like to handle those
[17:34:10] <MaxSem>	 tfinc, all that remains is to restart squids
[17:34:11] <awjr>	 yeah that was a call from howie and Maryana
[17:34:38] <tfinc>	 awjr: MaxSem: then you guys should update http://www.mediawiki.org/wiki/Mobile_default_for_sister_projects
[17:34:52] <tfinc>	 awjr: thats fine. i just need to pass a date to everyone else
[17:35:02] <tfinc>	 MaxSem: when will that happen ?
[17:35:09] <jdlrobson>	 but aude i'm confused - how would this cause https://en.m.wikipedia.org/wiki/Special:MobileDiff/533732066...534318598 to show up in watch list as being an edit by an anonymous user?
[17:35:17] * aude  looks

[17:35:43] <jdlrobson>	 (i'm just not clear if you're asking a question about an unrelated issue or saying is this the reason for the bug)
[17:35:44] <MaxSem>	 ops are very reluctant to do this, so possibly not immediately
[17:35:47] <aude>	 jdlrobson: we have no good way at the moment to know which user is connected on wikidata and the wikipedias
[17:35:59] <tfinc>	 MaxSem: days, weeks, months ?
[17:36:13] <aude>	 so they are considered "anon" at the moment (not great though and we want to do another way)
[17:36:28] <aude>	 there is anon or some user id
[17:36:49] <aude>	 there is no id for external user from another wiki
[17:37:05] <aude>	 unless, with single login, then we could be able to connect them
[17:37:06] <MaxSem>	 asking the ops....
[17:37:19] <jdlrobson>	 aude: what special handling would rc_type 5 require?
[17:37:51] <aude>	 well, we are looking into improving the recent changes code in core than handles rendering
[17:38:02] <aude>	 right now we link the user to their page on wikidata
[17:38:06] <aude>	 link the diff correctly
[17:38:07] <aude>	 etc.
[17:38:17] <aude>	 we stuff some extra params in the rc_params blob
[17:38:31] <aude>	 use that to handle rendering but it's not super pretty yet
[17:39:01] * aude  wants to separate some of the formatting and other code in ChangesList class to make this nicer

[17:39:06] <jdlrobson>	 aude: so are you saying that we could either 1)filter out rc_type != 5
[17:39:13] <aude>	 i would filter out for now
[17:39:18] <jdlrobson>	 or 2)  if item has rc_type == 5 don't say anonymouse?
[17:39:19] <aude>	 by default we filter out
[17:39:26] <aude>	 right
[17:39:27] <jdlrobson>	 ok. This sounds promising - thanks aude  :)
[17:39:39] <aude>	 there is a toggle or preference which allows users to see these changes
[17:39:51] <awjr>	 MaxSem: since mark is off for the weekend, perhaps an rt ticket?
[17:40:41] <aude>	 someday maybe what we do could also enable seeing changes on commons for example if an image got deleted, changed, etc.
[17:40:47] <aude>	 and it's in use on a wikipedia page
[17:40:54] <aude>	 or a template changes
[17:41:08] <aude>	 we are starting simple as possible though
[17:41:46] <aude>	 or maybe there is a global watchlist :)
[17:43:22] <jdlrobson>	 aude: is there an open bug for that?
[17:43:27] <jdlrobson>	 (the fact that they show us anon?)
[17:43:50] <jdlrobson>	 aude: i'm doing a bug fix now :)
[17:43:54] <aude>	 ok
[17:44:04] <aude>	 i think there is a bug
[17:45:19] <aude>	 ok, making new bug
[17:45:22] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=42289 < aude ?
[17:45:36] <jdlrobson>	 oh no that's something else..
[17:48:08] <aude>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=49315
[17:48:27] <aude>	 the other one is related
[17:52:13] <jdlrobson>	 thanks aude :)
[17:52:30] <aude>	 sure
[17:52:52] <aude>	 hope this is the only reason for your issue
[17:52:54] <aude>	 and it's fixed
[17:53:09] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 45517: Filter out recent changes that are RC_EXTERNAL" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67471
[17:53:12] <jdlrobson>	 ^ aude
[17:53:46] <aude>	 looks good
[17:53:58] <aude>	 it think you will want to do that anyway
[17:54:17] <aude>	 until we have a nicer way to integrate them....
[17:54:42] <jdlrobson>	 aude: thanks for he help :)
[17:54:44] <aude>	 sure
[17:54:49] <aude>	 they are like bot edits etc.
[18:04:16] <gerrit-wm>	 New patchset: MaxSem; "Completely remove the $wgMFCustomLogos['logo'] stuff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67472
[18:08:20] <mhurd>	 tfinc: android commons building and pushing to device! yay!
[18:08:56] <tfinc>	 mhurd: good start
[18:09:18] <mhurd>	 tfinc: and within my one hr time window :)
[18:09:33] <tfinc>	 one hr time window ?
[18:09:35] <tfinc>	 oh
[18:09:39] <tfinc>	 time slice
[18:09:40] <tfinc>	 great
[18:31:56] <MaxSem>	 weeeeeee
[18:32:10] <MaxSem>	 we've got Using index; Using temporary; Using filesort on watchlist queries
[18:50:33] <awjr>	 MaxSem: for what action/query?
[18:50:41] <MaxSem>	 feed
[18:50:48] <MaxSem>	 I'm investigating
[18:50:49] <awjr>	 oof
[19:03:03] <gerrit-wm>	 New patchset: MaxSem; "Force index to avoid filesort in feed query" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67481
[19:03:32] <MaxSem>	 awjr, ^^^
[19:03:36] <MaxSem>	 bleh
[19:03:49] <awjr>	 will take a look later today MaxSem, im stepping into like 4 hours of mtgs
[19:04:02] <MaxSem>	 I remember for sure that we profiled that query
[19:04:38] <awjr>	 but.. im still waiting for other participants to show up.
[19:04:44] <awjr>	 i remember for sure that we profied a query for the upload dashboard page
[19:04:48] <awjr>	 *profiled
[19:04:50] <MaxSem>	 but stupid mysql optimizer chooses on its own when it wants to use a sane index and when it doesn't
[19:05:10] <awjr>	 huh
[19:05:13] <awjr>	 so you force it with USE INDEX?
[19:05:26] <awjr>	 joins do weird things to indicies
[19:05:31] <MaxSem>	 actually, internally it gets changed into FORCE INDEX
[19:05:50] <awjr>	 and the use of a limit may change how the indexes are used
[19:05:58] <MaxSem>	 because USE INDEX is not convincing enough
[19:49:36] <Maryana>	 if i want to raise a limn bug, should i use bugzilla?
[19:49:49] <Maryana>	 specific to our mobile monthly reports
[19:50:53] <gerrit-wm>	 New patchset: Yurik; "rewrote vcl checker and upload scripts" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67450
[19:56:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67471
[19:59:44] <Maryana>	 jdlrobson, question about mobile editing - if i'm editing a section and save the change, do i get taken back to the top of the article?
[19:59:51] <Maryana>	 or to the section i was on?
[20:00:30] <jdlrobson>	 top of article at moment Maryana
[20:00:45] <Maryana>	 is that one of those things we have to wait for VE to solve for us?
[20:12:40] <MaxSem>	 jdlrobson, remind me - which part of zero interaction you tried to rewrite?
[20:19:25] <jdlrobson>	 errrr moving getZeroRatedBanner to use the minerva hook
[20:39:04] <Theo10011>	 Hello folks
[20:39:37] <Theo10011>	 I wanted to ask about the Zero namespace on Meta.
[20:39:59] <Theo10011>	 There was a recent discussion about namespaces there, and someone pointed out that no one has access to that namespace.
[20:40:05] <Theo10011>	 just zeroadmins
[20:40:43] <Theo10011>	 I just wanted to know for my own curiosity why it's on meta if it doesn't require any non-staff participation?
[20:42:36] <Theo10011>	 yurik, ^
[20:46:05] <yurik>	 Theo10011, the reason for it is two fold: first, it might get non-staff participation later - we might grant change rights to various trusted carriers
[20:46:33] <yurik>	 the technical reason is that meta is hosted on the same cluster as production wiki
[20:47:08] <yurik>	 and meta needs to reset memcached servers when zero config is updated
[20:47:29] <yurik>	 on top of that, it has to have the same resiliency as the rest of wikis
[20:47:39] <yurik>	 hope that answers your question :)
[20:47:56] <Theo10011>	 I think so, Thanks!
[20:48:11] <Theo10011>	 One last thing, you need a separate namespace for that?
[20:48:23] <Theo10011>	 I mean it couldn't have resided in the Main
[20:48:58] <Theo10011>	 Or was that to restrict access...
[20:51:07] <jdlrobson>	 yes! http://t.co/EMdfseTxpt
[20:53:44] <yurik>	 Theo10011, its both - the restricted access and due to a different content handler -- allowing json parser/formatter
[20:58:45] <gerrit-wm>	 New patchset: Dr0ptp4kt; "Constrain redirects to Wikipedia Zero partner-sourced requests." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67504
[21:05:44] <Theo10011>	 Thanks yurik!
[21:18:48] <yurik>	 is dr0 (adam) in the office today?
[21:20:36] <tfinc_>	 yurik: he is. he just stepped away from his desk.
[21:20:49] <yurik>	 tfinc_, thx
[21:21:53] <gerrit-wm>	 New patchset: Jdlrobson; "Standardise on 'plumbing'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67507
[21:21:53] <gerrit-wm>	 New patchset: Jdlrobson; "Story 488: Add pageimages to search results (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508
[21:26:15] <tfinc_>	 yurik: he's getting back on now
[21:26:31] <yurik>	 tfinc, yei!
[21:26:40] <yurik>	 dr0ptp4kt, welcome back :)
[21:26:51] <dr0ptp4kt>	 yurik, what's up?
[21:26:51] <dr0ptp4kt>	 gotta run in 3 mins
[21:26:57] <dr0ptp4kt>	 ^yurik. just a heads up
[21:27:06] <dr0ptp4kt>	 yurik, thanks for pinging to get me on irc. connection...
[21:27:08] <yurik>	 hehe, no worries, just wanted to ask you for +2 for a script update
[21:27:40] <yurik>	 dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/67450/
[21:27:46] <yurik>	 when you have time
[21:28:00] <yurik>	 its a funky script that does all sorts of minor checks in vcl
[21:28:06] <dr0ptp4kt>	 yurik, cool, looking for an accuracy cross-check, right?
[21:28:20] <yurik>	 dr0ptp4kt, more so that you know what scripts we have
[21:28:24] <yurik>	 and thx for your analysis of the log
[21:28:37] <yurik>	 we should write a short script that does some of those steps for the whole script
[21:28:40] <yurik>	 whole log
[21:29:19] <dr0ptp4kt>	 yurik, you're welcome. yeah, agree, script would be good.
[21:29:36] <gerrit-wm>	 Change abandoned: Jdlrobson; "Try again later" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66287
[21:29:51] <dr0ptp4kt>	 yurik, will add card to Trello. just emailed myself a reminder to do so
[21:30:23] <yurik>	 dr0ptp4kt, btw, i am working on moving stuff to the special page
[21:30:29] <yurik>	 just like max suggested
[21:30:43] <yurik>	 what's on your plate?
[21:31:07] <jdlrobson>	 awjr_away: i see bingle is bringing in old bugs into the current iteration now :(
[21:44:24] <yurik>	 dr0ptp4kt, still there?
[21:58:48] <MaxSem>	 yurik, maybe you understand what MobleFrontend is doing with zero banners here? --> https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/6a43eb24b18c579057f6cc5c88ec0949f7aa4b30/includes%2FMobileFrontend.body.php#L105
[21:59:17] <MaxSem>	 and on line 15...
[21:59:26] <yurik>	 MaxSem, of course, it makes it look important!
[21:59:32] <gerrit-wm>	 New patchset: Jdlrobson; "Story 488: Add pageimages to search results (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508
[21:59:34] <yurik>	 looking...
[21:59:36] <MaxSem>	 bingo!
[22:00:56] <yurik>	 MaxSem, re 15 - i think this is how it gets shown - the banner is always rendered using display:none
[22:01:04] <yurik>	 and javascript shows it
[22:01:08] <awjr>	 bah jdlrobson i tried something that may have backfired; i'll deal with it in an hour or so
[22:01:28] <yurik>	 if this code is for non-js capable browsers, the work is done on the server
[22:02:37] <MaxSem>	 but it always gets shown
[22:02:49] <MaxSem>	 so kinda pointless
[22:02:56] <MaxSem>	 also,
[22:02:57] <MaxSem>	 str_replace( 'id="zero-rated-banner"><span', 'id="zero-rated-banner"><span', $zeroRatedBanner );
[22:03:04] <MaxSem>	 is beautiful
[22:03:29] <yurik>	 MaxSem, no idea why its there tell you the truth
[22:04:17] <MaxSem>	 replace the string with itself - makes sense!
[22:06:43] <yurik>	 MaxSem, https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroRatedMobileAccess.git/ea9d350c33b1d8518cbe2dfb3483b0acd89c63f0/includes%2FPageRenderingHooks.php
[22:06:52] <yurik>	 display:none is always rendered
[22:07:23] <yurik>	 the only exception (that i put in there) is when it renders for the Zero config pages on meta
[22:07:53] <MaxSem>	 yurik, and then it gets mandatorily removed in MF
[22:08:07] <yurik>	 guess so :)
[22:08:28] <yurik>	 except that it i think i saw it in HTML result
[22:08:31] <MaxSem>	 mmm, stuff to refactor to /dev/null
[22:08:40] <yurik>	 my thoughts exactly
[22:08:47] <yurik>	 try to spoof headers to see what is actually returned
[22:09:14] <yurik>	 set X-CS to 250-99 and User Agent to android
[22:10:38] <MaxSem>	 <span id="zero-rated-banner-text" class="mw-mf-message" style="">
[22:18:29] <yurik>	 MaxSem, yep :)
[22:20:25] <yurik>	 to be refactored <tm>
[22:24:03] <gerrit-wm>	 New patchset: MaxSem; "The id 'zero-language-search' is not used anymore" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67539
[22:24:18] <MaxSem>	 yurik, ^^
[22:24:32] <yurik>	 MaxSem, ??
[22:24:34] <MaxSem>	 appears to be another rudiment
[22:25:41] <yurik>	 MaxSem, not sure i understand
[22:26:23] <MaxSem>	 yurik, can you confirm that Zero is not using it so we can stop caring about it? ^^
[22:28:29] <yurik>	 MaxSem, i can't easily - not until i finish all refactorings and gain full understanding of this spaghety code
[22:28:31] <yurik>	 see https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroRatedMobileAccess.git/ea9d350c33b1d8518cbe2dfb3483b0acd89c63f0/modules%2Fbanner.js
[22:29:06] <yurik>	 as you can see, it dynamically changes display:none
[22:29:24] <MaxSem>	 yurik, I'm asking about https://gerrit.wikimedia.org/r/67539
[22:32:37] <yurik>	 MaxSem, this is very first time i even hear about such id
[22:32:50] <MaxSem>	 so +2?:)
[22:32:57] <yurik>	 did you see it anywhere else?
[22:32:57] <MaxSem>	 hmm, can we use GetMobileNotice hook for zero banners?
[22:33:01] <MaxSem>	 no
[22:33:17] <yurik>	 it depends what that hook does :)
[22:33:24] <yurik>	 sure, can kill it
[22:34:22] <gerrit-wm>	 New review: Yurik; "Couldn't find any references to that id" [mediawiki/extensions/MobileFrontend] (master) C: 2;  - https://gerrit.wikimedia.org/r/67539
[22:34:27] <yurik>	 MaxSem, done
[22:34:36] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67539
[22:34:39] <MaxSem>	 thnz
[22:34:45] <MaxSem>	 *thnx
[22:37:36] <gerrit-wm>	 New patchset: Jdlrobson; "More descriptive error messages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67545
[22:39:09] <gerrit-wm>	 New patchset: MaxSem; "Remove Zero banner cruft" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67546
[22:39:34] <gerrit-wm>	 New review: MaxSem; "Waiting for Zero support." [mediawiki/extensions/MobileFrontend] (master) C: -2;  - https://gerrit.wikimedia.org/r/67546
[22:57:27] * MaxSem  howls

[22:57:35] <MaxSem>	 I need reviewwwwwwwwwww
[22:57:52] <MaxSem>	 or there will be merge conflicts
[22:59:49] <gerrit-wm>	 New patchset: MaxSem; "Move ExtMobileFrontend::parseContentFormat() to MobileContext" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67549
[23:07:18] <gerrit-wm>	 New patchset: MaxSem; "Move some code out of ExtMobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67361
[23:08:43] <dr0ptp4kt>	 MaxSem, are you saying that this needs to be +2'd in order to avoid merge conflicts? it seems to result in the Wikipedia Zero banners not rendering. we had a partially working solution last Friday and earlier this week, but it was broken in that it was displaying two banners. why the merge conflict?
[23:08:50] <gerrit-wm>	 New review: Dr0ptp4kt; "Thanks." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67546
[23:10:12] <MaxSem>	 I thought it got reverted
[23:10:42] <dr0ptp4kt>	 MaxSem, yes, it did get reverted. which change do you need reviewed to avoid a merge conflict?
[23:11:03] <MaxSem>	 and I was meaning my other commits, cause 67546 is not ready as evidenced by -2
[23:11:04] <dr0ptp4kt>	 MaxSem, sorry if you're not talking about Zero. thought you may be talking about Zero, and wanted to jump on it...
[23:11:13] <MaxSem>	 heh:)
[23:11:24] <MaxSem>	 we've got a stampede:)
[23:12:14] <dr0ptp4kt>	 MaxSem, got it, i think. lemme know if you need anything on the Zero front.
[23:22:46] <tfinc>	 mhurd: http://www.engadget.com/2013/06/07/apple-ios-7-banner-wwdc-2013/
[23:28:41] <tfinc>	 notices that he has mobile notifications :D
[23:28:49] <mhurd>	 tfinc: :)
[23:28:52] <tfinc>	 why can't i dismiss them if i tap the icon again ?
[23:29:24] <tfinc>	 nasty layout https://en.m.wikipedia.org/wiki/Special:WhatLinksHere/San_Francisco_Fire_Department_Auxiliary_Water_Supply_System
[23:30:38] <awjr>	 jdlrobson: i cleaned up the bugzilla dupes
[23:31:12] <awjr>	 and am now taking a closer look at wtf is going wrong in bingle
[23:31:31] <tfinc>	 jdlrobson: will tapping the user icon dismiss notification eventually ?
[23:48:00] <jdlrobson>	 awjr: sweet
[23:51:28] <gerrit-wm>	 New patchset: Jdlrobson; "Story 488: Add pageimages to search results (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508