[08:45:31] [android-commons] siebrand pushed 1 new commit to master: http://git.io/4_Ufpw [08:45:32] android-commons/master e11c1f2 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [08:47:53] [Commons-iOS] siebrand pushed 1 new commit to master: http://git.io/yT5YZw [08:47:53] Commons-iOS/master 869a91c Siebrand Mazeland: Localisation updates from http://translatewiki.net. [08:48:12] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/buojNA [08:48:12] WikipediaMobile/master e78d52d Siebrand Mazeland: Localisation updates from http://translatewiki.net. [11:20:21] morning [11:26:10] I have a problem with my mainpage using mobilefrontend [15:22:53] YuviPanda: heyyyyy [15:23:08] not too sick i hope :( [15:23:31] brion: I still am. [15:23:40] bluh [15:23:41] brion: more than the flu, the tablet I took for it seems to have put me in a state of living death all day [15:23:47] yuck [15:23:53] could hardly open my eyes or stay awake for more than a minute [15:24:03] nor could I actually sleep [15:24:05] 'twas horrible [15:24:15] i'm feeling well enough i think i'll go into the office to escape my sick wife and flatmate for a while :) [15:24:19] heh [15:24:21] nice [15:24:22] and tfinc will be happy to see me not out [15:24:39] heh yeah [15:26:01] you gonna be around today or just checking in briefly? [15:59:43] brion: i'll be around [15:59:48] brion: i'm also a GSoC backup mentor :) [16:21:33] spiff [16:21:37] i'll head into the office in a bit [16:30:37] ugh, still feel crappy. staying home to work [16:33:42] brion: <3 feel better [16:33:59] whee [16:34:03] you too :P [16:35:10] will do [16:35:38] going to the doctor was, in thie case, definitely more dangerous than the diseas itself [16:35:45] :( [16:39:15] brion: is today the beginning of a sprint? [16:39:19] or am I joining in mid sprint? [16:39:23] i… think so [16:39:35] i've been pretty out of it between amsterdam and being sick after [16:39:38] ah [16:39:39] right [16:39:40] so i'm off-sync :D [16:43:26] MaxSem: staging appears to suddenly be read-only [16:43:27] awjrichards@staging:~/var/bingle$ cat /dev/null > bingle.err [16:43:27] -bash: bingle.err: Read-only file system [16:43:37] know anything about that [16:43:38] ? [16:43:47] ask on #-labs [16:43:47] * YuviPanda mumbles about moving bingle to tools [16:44:28] awjr: gluster is probably stuck, Coren or someone can 'nudge' it back for you [16:45:21] YuviPanda: bugello is running on tools and bingle will be too - when i've got the time to migrate:) [16:45:28] :) [16:45:37] i've sortof become a tools-labs fanboy of late [16:45:48] remote: Unexpected system error after push was received. [16:45:49] remote: These changes may not be reflected on github.com! [16:45:50] remote: Your unique error code: a693f66c01a7cb84710d777b9600d3eb [16:45:51] ... [16:45:59] brion: try again maybe? :D [16:46:06] mmm MaxSem the sugestion was to turn it off and on again. [16:46:13] ugh [16:46:18] so im gonna reboot staging - any objections MaxSem? [16:46:32] nope [16:47:10] * brion looks for github bot [16:47:45] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/VpGnLw [16:47:45] Commons-iOS/master 21d2452 Brion Vibber: tweak [16:47:52] \o/ [16:51:39] [Commons-iOS] brion pushed 7 new commits to master: http://git.io/rqT_yA [16:51:39] Commons-iOS/master e4dbce6 Monte Hurd: Added long-press auto entry of username and pwd stub for presentations [16:51:39] Commons-iOS/master 1ebaefe Monte Hurd: Swipe up or down on login page calls up or dismisses keyboard [16:51:39] Commons-iOS/master 57dc610 Monte Hurd: Changed attribution icon from creative commons to copyleft [17:08:01] brion: also see https://github.com/yareally/Java7-on-Android [17:13:15] nice [17:20:00] wheeeeeee [17:20:22] :) [17:20:29] brion: has there been a release to market since I left? [17:20:52] YuviPanda: nope. planned it a couple times but we didn't quite get to it [17:21:08] should do that, some small fixes are in for things like the file overwrite [17:21:09] would be nice to get jared on IRC :( [17:21:31] heading to the office [17:21:38] does he hang out on a different chat system? [17:21:45] i suppose i could turn on my IM client :) [17:22:42] Maryana: i can sync up with you any time this afternoon other than 3-4 [17:22:57] would 5 work? [17:25:39] brion: any luck on the Create Account API work? [17:25:45] mhurd: do you have any specific time you're catching up with the design folks or do you just wander up there when i'm not looking? :) [17:25:45] would like to get some of the menu plans hammered out before we replicate too much UI [17:26:10] haven't touched it, we deprioritized [17:26:29] brion: it's been fairly random [17:27:45] brion: i hope they'll have some menu stuff for us today [17:28:29] YuviPanda: as i mentioned in the standup. lets take this week lightly with you building back our android backlog, catching up on where iOS is, and starting to plan the backlog for campaigns [17:28:58] mhurd: brion: what have the apple overlords delivered so far ? [17:29:10] tfinc: oh that's right [17:29:16] tfinc: today's the day [17:29:18] mhurd: wwdc kicked off 30min ago [17:29:52] tfinc: so close… and yet... [17:30:25] tfinc: new os x with...... tabs in finder! [17:30:34] (yes. really.) [17:31:19] tfinc: some goodies in the new mac os x release [17:31:19] airplay works as an external monitor now \o/ [17:31:30] tfinc: alright. But I'm going to focus more on some fundamental fixes rather than UI ones + planning for campaigns [17:31:30] looking at the backlog now, will move things over to the current thing now [17:32:10] MaxSem, i have been testing a few things, and noticed that there is a "add image to this article" blue banner appearing at the top when X-Subdomain is ZERO, but not appearing if its "M" [17:33:05] this happens regardless if X-CS is detected or not [17:33:44] hmm, this is a question to jdlrobson [17:34:22] YuviPanda: fixes are part of the backlog. [17:34:41] yurik, actually, it may be cookie path - are you logged in and have beta enabled on both subdomains? [17:34:57] its up to you wether you want them going into sprint 10 or if you want to manage your own backlog for this week and prep next weeks [17:34:59] MaxSem, nope, local testing [17:35:09] YuviPanda: as your catching us mid sprint [17:35:41] MaxSem, wait [17:35:51] spoke too soon, might be cookies [17:36:13] not showing in privacy mode [17:36:21] brion: so image's of the day usually have a template, but not necessarily? [17:42:40] MaxSem: the code review you need is all in MobileFrontend, correct? [17:43:43] yep [17:52:48] awjr, do you have any ideas why do we have ExtMobileFrontend::disableCaching() for? [17:53:05] not off the top of my head [17:53:07] lemme take a look [17:54:25] New patchset: Yurik; "Redirect Special:Zero=>Main_Page if 'showZeroPage'" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67226 [17:58:01] MaxSem: im not sure what the reasoning was behind that - my guess is that it was intended to prevent caching of requests coming from Squid servers [17:59:00] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67450 [17:59:34] mmm, watching the WWDC makes me want to get a Dell XPS 13 Developer Edition so bad... [17:59:35] awjr, but Varnishes are also in wgSquidServersNoPurge [17:59:42] mobile varnish? [17:59:48] yep [17:59:54] that might explain low cache hit rate :p [18:00:15] hmm [18:00:40] MaxSem: double check with asher or mark i guess; they may have more historical context [18:01:06] im hesitant to just kill it until we have a better idea of the implications [18:01:30] but i have a hunch it's something we'll want to nuke [18:01:57] 'Varnishes are also in wgSquidServersNoPurge'… what a poorly named variable :( [18:02:25] ideally, we should rely on core for headers [18:02:57] awjr, is it related to the caching problem you previously investigated? [18:03:06] heh which one? [18:03:42] i clearly contributed some code to that method but i have *no* recollection of it or why [18:03:52] it looks like it was pre-git [18:04:21] heh [18:05:01] actually my changes were post-git [18:05:08] but gerrit can't find the patchset [18:06:32] hmm for some reason i can't read the full commit message for my commit either [18:06:56] but i think i was probably just cleaning up some hardcoded stuff and probably didn't really know what that method was for [18:06:57] YuviPanda: that dell xps is starting to be standard around here [18:07:15] tfinc: yeah, it's a sweet machine [18:07:27] tfinc: the macbook air is showing its age, longish android compilation times now [18:07:53] YuviPanda: i wish we had gotten a retina macbook air [18:08:43] tfinc: heh. [18:08:55] tfinc: it's hard to go back to a 'normal' laptop once you get used to the macbook air format [18:09:24] YuviPanda: the macbook air is the normal format. everything else is a strange twist on reality [18:09:34] yeesh yeah investigation shows that that function is from a *long* time ago, MaxSem [18:09:55] tfinc: heh [18:10:06] tfinc: i'm done with OS X though. Need to get back to Linux [18:10:14] YuviPanda: how come ? [18:10:32] tfinc: it's hard to do much non-web development on OS X. [18:10:47] build systems are a pain [18:10:52] and no apt-get [18:11:58] so here's when it was added: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/MobileFrontend/MobileFrontend.php?r1=93404&r2=93405& [18:12:07] "add disable images support and disable caching for trial deployment as well as remove automatic mobile view selection" [18:14:54] :O [18:15:14] but that's not helping to understand it [18:15:58] MaxSem: lemme take a look at the contents of wgSquidServersNoPurge [18:16:07] maybe that will shed some light on this [18:18:16] huh so all mobile varnish caches are in there [18:18:24] so… why doesn't that happen *all* of the time? [18:18:37] do the cache headers get re-written later in the call chain? [18:20:08] MaxSem: ^ [18:20:40] why doesn't happen? [18:21:03] Expires: Sat, 26 Jul 1997 05:00:00 GMT [18:21:07] Pragma: no-cache [18:21:49] s-maxage=300, must-revalidate, max-age=0 [18:22:04] s-maxage might've been added in varnish [18:26:45] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67226 [18:26:48] oh you're right MaxSem [18:27:28] MaxSem: we can/should probably get rid of that [18:28:07] but it would be prudent to dbl check with ops first [18:29:23] mhurd: they really did hit the os with a hammer to flatten it. i can't wait to see this in action [18:29:56] tfinc: cool! [18:30:08] tfinc, you can see it in action right now - just get a WP phone, mwahaha [18:30:16] MaxSem: rofl [18:30:25] hahaha [18:32:08] jcmish: waiting on visual editor team to vacate our mtg room [18:33:59] the guys whose liveblog on WWDC I'm reading have expressed a desire to kill themselves with a broom after seeing iOS 7 [18:35:25] ha [18:35:27] MaxSem: verge? [18:35:29] always taking over! [18:35:40] no, a russian one [18:35:49] ah [18:36:21] wtf for do they have a large 'UNIX' on one of their screens/! [18:37:50] uhoh Maryana lost you :D [18:38:07] yeah, switching to wired connection.. [18:38:07] grr [18:38:34] no prob [18:43:44] tfinc: really like the new swipe-from-bottom control center [18:44:24] mhurd: i'm eager to see how well airdrop works [18:45:01] tfinc: ya [18:53:13] New review: awjrichards; "I think this looks OK, but have some open questions." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/66888 [18:55:09] maxsem broke it [18:55:11] New patchset: JGonera; "Fix watchstar alignment in stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67856 [18:55:12] jcmish ^ [18:55:23] awesome [18:55:25] yay!1111 [18:56:01] something you're doing with eventlogging made watchlist star and editing disappear from beta labs [18:57:18] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888 [18:57:23] awjr, ^^ [18:58:02] moar details?] [18:58:04] iOS 7 drops support for iPhone 3gs, iPod touch before 5th-gen [18:58:45] New review: awjrichards; "alright, i *think* this is ok; how can i reliably test this?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888 [19:07:56] New review: MaxSem; "ExtractFormatterTest.php ;)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888 [19:08:28] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67545 [19:10:27] jdlrobson: hey, do you already have any plans for "nearby articles" on Google Glass? [19:12:09] do we have the glasses themselves?;) [19:12:51] MaxSem: who is "we"? :) I know 1 person who is already developing for GG and 1 who's about to [19:14:41] sumanah: I floated a 'request for ideas' on mobile-l [19:14:49] I need to run to the Denver airport to pick up a friend and will be back in a couple hours [19:14:55] sumanah: I'd love to, but they have no way of developing for it without a device [19:15:27] sumanah: preilly has one and has offered to help test, so I'll prolly hit some up in a while. [19:15:29] YuviPanda: Argh! No simulator? [19:15:34] sumanah: no simulator, no [19:15:54] sumanah: the most they have is a css file that 'sortof makes it look like how it might look like', which... is not too useful [19:16:17] sumanah: there is a debug console of sorts, but that again requires that you have a device [19:16:53] sumanah: it also doesn't actually run code *on* the device - the glass hardware reports your current location to google every 10minutes, and we can subscribe to those 'pings' and send people back interesting content (via Google) [19:17:09] sumanah: you can, of course, root it (and run android), but that again - requires device [19:17:10] :( [19:18:08] sumanah: why were you asking, btw? [19:18:51] YuviPanda: so I could give better information to the developer I know who is interested in doing Wikimedia/Wikipedia/GG work [19:18:56] ah :) [19:19:20] sumanah: http://lists.wikimedia.org/pipermail/mobile-l/2013-May/006022.html was the mail i sent last month [19:19:24] no activity after that, however [19:19:45] http://blog.stenoknight.com/2013/06/preliminary-impressions-of-google-glass.html is by my friend Mirabai. She hooked up her steno software to it so she can help her deaf clients better [19:19:49] subtitles for the world :) [19:19:56] wah, wonderful! [19:20:11] niice! [19:20:37] sumanah: wiki also can have tons of new things - 'nearby articles', 'nearby articles that might interest you', 'nearby articles that were recently changed', etc [19:20:59] * sumanah wants Wikivoyage integration maybe [19:21:11] * sumanah heard Wikivoyage "nearby" does not work yet [19:21:15] jdlrobson is working on Wikivoyage integration into our nearby system [19:21:30] (there is a discussion on some mailing list started by jdlrobson, IIRC (unsure)) [19:21:51] yay that it is on the way :D [19:22:21] sumanah: long term, however, they should all go into wikidata [19:23:10] sumanah: which... has already started happening too :) (https://www.wikidata.org/wiki/Wikidata:Project_chat#Geocoordinates_are_here.21) [19:23:52] I might be saying "integration" wrongly - what I am suggesting is just the reasonably obvious "give me nearby Wikivoyage articles" and I do not personally have a stake in where the lat/longs live [19:24:48] thank you YuviPanda for all the links & info! [19:24:52] :) [19:25:10] tfinc: today is apparently not the best day for adding a device to the provisioning portal [19:25:13] sumanah: yeah, I was just pointing out the various developments :) [19:26:20] sumanah: do ask them to ping me / us if they're end up wanting to do something about Google Glass. Be happy to help in any way possible [19:27:53] New patchset: Yurik; "Hooks class description" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67864 [19:29:08] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67864 [19:29:18] sumanah: ergg google glass :P [19:29:32] but yeh i think wikivoyage asked to enable nearby [19:29:49] ^ MaxSem did you see that?? [19:30:09] jdlrobson: google glass is all html / css, btw [19:30:26] (at the highest level, at least) [19:30:35] no JS or 'traditional' rendering engine, so yay [19:30:37] YuviPanda: i have no interest in wearing silly glasses for technology sake in my life :P [19:30:58] *shrug* sure. [19:31:27] I wear regular glasses. why not add a display? [19:31:44] i'd prefer a google helmet [19:32:03] should eventually push it down until it hits contacts :) [19:32:12] safety first [19:32:27] or even a welding mask form factor [19:32:29] technological problems are always fixable [19:32:46] boba fett approves [19:32:49] people calling others names like 'glasshole' are harder to fix :) [19:32:58] hahaha [19:33:13] http://www.oculusvr.com/ [19:33:31] ummm… wow [19:33:36] stick a camera on the front [19:33:51] they should put googly-eye stickers on that [19:34:08] google acquisition! [19:34:08] mhurf did you watch the wwdc keynote? [19:34:20] mhurd :p [19:34:30] brion: i read a blog summary [19:34:30] 'look, android 4.2 now copies from iOS 7!?' [19:34:39] heh [19:34:49] brion: did they really need to start with 'LOOK AT FINDER IT HAS TABS NOW WOW AMAZING FEATURE NO?' :) [19:35:16] okay, now to go do productive work than just trolling [19:35:16] multitasking for all and smart sync scheduling sounds useful [19:35:21] ya [19:35:25] lol [19:35:36] 'true multi tasking, first time on a mobile OS!' [19:35:43] haha [19:36:38] i'm hoping it's true multi tasking for first time on any mobile os not killing battery life [19:36:46] all I wanted was WebGL and a retina air [19:37:19] 12 battery air is nice [19:37:20] only thing that eats my android battery life is the almost 5" ducking screen [19:37:28] haha [19:37:37] heh [19:37:49] *12hr* [19:38:05] yeah the battery life is getting great [19:38:37] wasn't expecting such a jump [19:38:47] Yuvi what you gonna work on next? [19:39:16] jdlrobson: ok, so it sounds like you're not interested in doing GG work yourself, so my friend wouldn't be stepping on your turf :) YuviPanda I'll let you know if she decides to move forward on this [19:39:23] or she'll let you know, rather, so you can team up [19:39:37] brion: looking through, prolly on replacing our image loader with Volley [19:39:45] ah sweet [19:39:47] brion: that should also let us fix the 'no images smaller than 640px' bug [19:40:04] brion: let me add a car [19:40:04] d [19:40:09] any thoughts on how to handle: https://bugzilla.wikimedia.org/show_bug.cgi?id=45460 [19:40:12] I'll finish up the basic category editing and we'll redo the ui later [19:40:21] brion: mm, ok [19:40:33] sumanah: sweet, thanks! Will be happy/excited to help :) [19:40:51] or I can work on the pretty ux featuees [19:41:07] brion: mmm, the initial view? [19:41:10] that'll be nice :) [19:41:28] mhurd hmm tricky [19:41:30] brion: ooh, also - thoughts on moving it to Gerrit? [19:41:41] brion: we can still keep pushing to GitHub and have it mirror back to Gerrit [19:41:43] we may not have a good way to test against the blacklista [19:42:00] brion: more internal awareness + we still get to use github [19:42:08] Yuvi no rush on gerrit but let's poke it later [19:42:29] after tfinc's wedding maybe :) [19:42:31] brion: mind if I set it up this week? would be nice to test our GitHub -> Gerrit workflow too [19:42:42] brion: sadly I'll still be stuck here :( no cake for me! [19:42:43] sure try it out [19:42:47] aww [19:44:54] mhurd start with a file exists check [19:45:14] we'll figure out blacklist testing later [19:45:47] there's already some code that gets called onnuploaf to check existence you can steal that [19:45:53] jdlrobson, replied on that bug [19:47:23] brion: now you're renaming appending a number after the title if it's a dupe. do you think this validation patch should supersede that presenting some kind of dialog? [19:48:19] dialogs are icky. maybe keep it down to a red warning msg nonmodal [19:48:25] brion: ya i'd almost say the way it works now is preferable [19:48:44] brion: in lieu of guid file names [19:48:55] uuid [19:49:03] maim thing is that if you're getting rejected by a filename block, appending isn't likely to fix it [19:49:15] ah [19:50:27] New patchset: Jdlrobson; "Reduce API errors related to anonymous tokens (hopefully)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67867 [19:50:52] MaxSem: which bug? always give me a link! :) [19:50:59] like "fuckfuckfuck" won't be fixed by "fuckfuckfuck 2" ;) [19:51:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=49288 [19:51:13] bahahaha [19:51:49] MaxSem http://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Special:Nearby_on_Wikivoyage.3F "Sounds good, Max. In the short-term, if the WMF wants to implement Nearby just for destinations, that'd be great" [19:51:58] can we do this? [19:52:38] why not [19:52:47] it's pretty useless however [19:52:50] we'd have to increase range from 10000 i'd guess [19:52:53] is there a limit on it? [19:53:24] i suppose it will also vary per country :( [19:54:31] no, there's a limit for perf reasons, but there was no research on how its changes affect the servers, so I'm definitely keen on trying to increase it [19:57:36] have anyone decided upon their extra days before/after wikimania? [20:03:18] MaxSem: I can't leave Hone Kong because that's the only country that lets me visit without a visa :( [20:03:25] jdlrobson is planning on hitting Philiphines, I think [20:08:09] i gotta save money this year, no more sightseeing for me outside the main days i think [20:08:11] New review: awjrichards; "Overall I like where you're headed with this. I don't think the commit message quite lines up with w..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67472 [20:10:48] yurik & dr0ptp4kt, any feedback on https://gerrit.wikimedia.org/r/#/c/67546/ ? [20:11:43] MaxSem, nothing further yet. hope to code up the stuff that will make this work sometime this week. [20:11:55] cool, thanks [20:15:53] New patchset: Jdlrobson; "Allow configuration of range in Special:Nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67877 [20:15:54] ^ MaxSem [20:16:54] MaxSem: brion: any pointers on getting the api to tell me if a potential title will result in file name block? [20:17:17] jdlrobson: your name mentioned in enwiki VPT https://en.wikipedia.org/wiki/Wikipedia:VPT#Passing_a_location_to_Special:Nearby.3F (just a headsup) [20:17:18] New review: MaxSem; "Please use $wgMaxGeoSearchRadius" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67877 [20:17:59] mhurd: try * action=titleblacklist (tb) * [20:18:06] ah! [20:18:15] that should help with at least one thing... [20:18:47] New review: awjrichards; "this still results in a filesort: https://gist.github.com/awjrichards/2bb0978edb655df73591" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67481 [20:20:46] New review: awjrichards; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67549 [20:21:51] mhurd: oh while it's at mind… how are you fetching the precached images? this process should probably be documented :) [20:22:18] ah good point [20:22:49] New patchset: Yurik; "Added count param for PLURAL to zeroconfig-sites msg" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67878 [20:23:04] awjr, why LSB? [20:23:25] why not? what if someone winds up extending that? [20:23:55] MaxSem: ^ [20:24:04] what if I made it final?:P [20:24:50] lol [20:25:09] then i would shuttup [20:25:33] brion_: the PictureOfTheDay object contains all the fetching logic presently [20:25:49] s/class/final class/g [20:26:54] New review: awjrichards; "How about a unit test? Looks good otherwise!" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67361 [20:26:57] mhurd: don't suppose we could add a fetcher tool as a secondary build target? or could sneak it into the main app behind a debug wall :) [20:27:01] New patchset: Jdlrobson; "More descriptive error messages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67545 [20:27:33] MaxSem: $wgMaxGeoSearchRadius is something different [20:27:39] surely? [20:28:06] for performance reasons surely we want to keep the radius value as low as possible in our requests? [20:28:12] no it's not - what's the use case for having the radius in MF different from the one in GD? [20:28:53] well $wgMaxGeoSearchRadius defines the maximum value of the limit [20:29:02] brion_: fetching tool already bundled via "FORCE_PIC_OF_DAY_DOWNLOAD_FOR_DATE" [20:29:04] so if $wgMaxGeoSearchRadius is 5000 and I give 6000 it complains [20:29:32] If $wgMaxGeoSearchRadius is set to say 100km on a project [20:29:57] that'll do for now as long as it's documented mhurd :D [20:30:23] and i'm in the middle of nowhere, the Special:Nearby page which claims to show me articles near me might show me things 80km away [20:30:27] that's not nearby.. [20:30:42] they should be separate values [20:31:18] also by asking for things within 100km i'm doing a much more expensive geosearch [20:31:25] Siri has Wikipedia integration ... interesting [20:31:29] i assume geodata uses a boundng box optimization? [20:31:40] (if not it should) [20:31:45] ^ MaxSem ? [20:32:05] in iOS7 <-- mhurd, brion [20:32:13] i wonder how they did it [20:32:31] we may never know [20:32:35] need an AppleLeaks ;) [20:32:57] i'm guessing its simply 'search wikipedia' [20:33:04] :) [20:33:06] brion_: there's too much pic-of-the-day logic in the login view controller for my taste presently - will do a quick refactor soon for better encapsulation [20:33:13] ok [20:33:20] New patchset: Yurik; "Added count param for PLURAL to zeroconfig-sites msg" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67878 [20:33:25] New review: Jdlrobson; "We should make this a less variable in future..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67856 [20:33:33] tfinc: huh! [20:34:28] New patchset: Jdlrobson; "Bug 49214: Reinstate refresh button on nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67164 [20:34:47] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67856 [20:35:21] New review: Jdlrobson; "jdlrobson: MaxSem: $wgMaxGeoSearchRadius is something different" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67877 [20:39:04] New patchset: Jdlrobson; "Bug 49214: Reinstate refresh button on nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67164 [20:39:39] brion_: does this look about right: https://commons.wikimedia.org/w/api.php?action=titleblacklist&tbtitle=sometitle&tbaction=create [20:40:00]