[00:04:48] New patchset: Jdlrobson; "Remove #mw-mf-sq css rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67912 [00:05:00] New review: Jdlrobson; "rebased" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67912 [00:05:15] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67912 [00:08:02] New patchset: Jdlrobson; "Story 789: First time user upload tutorial revamp" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68013 [00:08:02] New patchset: Jdlrobson; "Beta: Make panels of uploads tutorial slide in and out" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68014 [00:08:02] New patchset: Jdlrobson; "Story 790: Standardise use of words" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68015 [00:10:15] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68013 [00:10:41] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68014 [00:28:00] [Commons-iOS] montehurd opened pull request #87: Fixes for various missing i18n (master...missingI18N) http://git.io/cmjXnQ [00:57:19] New patchset: JGonera; "Uploads tutorial CSS fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68124 [04:32:55] yurik: im around now [04:33:50] awjr, yep [04:34:01] you pinged earlier? [04:34:48] awjr, i think i had a question re auth, but someone answered it [04:34:53] ok good :) [13:08:09] * brion is having fun playing with siri's wikipedia integration [13:08:33] if i ask anything Apple-related it doesn't look up the article, it just tells me to go to apple.com [13:08:41] i wonder if they found something unfavorable in the articles ;) [13:09:52] brion: thanks very much for your great contribution in reviewing the translatewiki mobile app! [13:10:05] sure :D [13:10:12] thanks for making it! [13:10:19] brion: we will definately use this while working on the next build [13:10:28] :) [13:10:56] :D [13:21:28] https://brionv.com/misc/siri-ios7-surfing-wikipedia.jpg [13:48:21] YuviPanda: did you close the sprint 11 board by accident? [13:48:25] it's easy to hit the wrong button :D [13:50:51] brion: no [13:50:56] brion: there's another sprint 11 button [13:51:01] aha [13:51:03] we had two :D [13:51:08] brion: tfinc had just opened a new board [13:51:08] twice as much work! never [13:51:12] brion: lost our labels, etc [13:51:18] noooooo [13:51:25] brion: so I closed that, cloned the current board into a new one, and cleared out the last 3 oclumns [13:51:33] hmm [13:51:37] i don't see a new sprint 11 [13:51:52] can you add me to it? [13:52:18] brion: looks like I didn't add [13:52:21] brion: thought users copied over. grr [13:52:22] adding now [13:52:32] tx [13:52:39] okay I think I got everyone [13:52:54] whee [13:53:04] brion: also, how does the iOS app handle width of image thumbnails? [13:53:11] you use highres versions if the device is 'retina' right? [13:53:42] Wikipedia iOS app doesn't replace the images with high-res versions as i recall [13:53:43] web site does [13:53:52] (but right now there's a bug in it that makes it break in some browsers) [13:54:21] brion: commons app I mean [13:54:42] commons app yeah it scales the resolution it fetches by the display density [13:55:24] brion: alright. Android app didn't do that so far, I'm making it do that with the Volley move. [13:55:29] \o/ [13:55:39] * brion looks forward to sharper images [13:55:49] brion: so are you first doing a request that fetches you the width and then doing a thumbnail? [13:56:28] first fetch asks for 'imageinfo' with given max thumbnail width and height, it comes back with a URL [13:56:34] second fetch loads the URL of the thumbnail [13:56:42] first fetch can batch up to 50 titles together [13:56:53] second fetch is the actual image fetch so have to do those one at a time :) [13:57:35] brion: ah, right [13:57:48] brion: I am just requesting a thumbnail, and if it 500s I 'fallback' to raw image size [13:57:59] hmm [13:58:11] that's probably bad if you turned out to be a 50-megabyte tiff [13:58:13] currently I just request a thumbnail, and if it fails I do nothing :P [13:58:32] brion: if it was a 50mb TIFF, it'll render me a thumbnail, no? [13:58:49] brion: on my s3, request size is 712px, so it'll 500 only if the image is smaller than that [13:58:49] maybe [13:59:02] you should also get a 500 if you got the pattern wrong [13:59:10] like missing page on multipage or time on video [14:00:10] brion: those are all 'bugs' and should be fixed [14:00:17] heh [14:00:18] brion: and IIRC I already check for video (if not I should) [14:00:33] your life gets waaay easier if you let the server worry about these things :) [14:00:50] brion: yeah, but... but 2 requests! [14:00:56] hehe [14:01:25] brion: plus this also operates on the assumption that on average, the file raw sizes are going to be bigger than what you will want to see on your display [14:01:38] ie. if everyone had S3s, files are, in general, larger than 712px wide [14:01:48] since if it is smaller it results in 2 requests [14:01:52] *nod* [14:01:59] I think that's a safe assumption [14:02:11] some files are legit smaller like icons [14:02:11] brion: I can also put a 'disable high res display images' option in settings [14:02:17] brion: sure, but 'on average' [14:02:19] options. bah! [14:02:25] yeah, i'm not leaning towards that [14:02:32] hehe [14:04:11] brion: though currently I'm running into... concurrency issues. [14:04:14] * YuviPanda keeps bumping them [14:04:24] hmmm [14:05:42] brion: also, I'm thinking of removing some of the tracking info that we collect [14:05:44] (but do not use) [14:05:48] brion: specifically, device name [14:05:52] ok [14:06:03] brion: and in the future, perhaps hash and salt username [14:06:04] i'd kinda like to drop username, it's creepy ;) [14:06:06] yeah [14:06:20] NSA is watching your uploads anyway though ;) [14:06:30] brion: so I was thinking we could salt the username with the device name [14:06:35] oooh [14:06:44] so if we wanted to debug, we can ask people to give us their username + device [14:06:49] and then we can use that to identify them [14:07:08] brion: how does that sound? [14:07:16] could do that yeah [14:08:00] brion: however, it's still trivial to find out who uploaded what, since it is public on the file on common [14:08:00] s [14:08:03] yeah :D [14:08:05] brion: so if we technically wanted to, we could bruteforce the model name :P [14:08:11] hehe [14:08:43] brion: thoughts on the salting? Okay with implementing username + device salting? [14:08:58] fine by me [14:09:00] brion: it'd also be nice if you could start a mobile-tech thread about it - mobile web is capturing usernames too... [14:09:07] less creepy than plaintext [14:12:03] brion: updated https://meta.wikimedia.org/wiki/Schema:MobileAppUploadAttempts [14:12:18] ooh jon's recommending a new style thingy. i'll have to dive into that discussion later [14:12:31] brion: tim starling left a nice comment on gerrit about that :) [14:12:37] i'm watching WWDC videos about background multitasking… in the background [14:12:46] hehe, 'yo dawg' etc [14:15:53] added some notes on the gerrit too [14:28:58] hehehe http://www.downloadmoreram.com/downloading.html [16:09:00] YuviPanda: when do we get feature parity with iOS on the Commons app? [16:09:03] ;) [16:09:10] ragesoss: which ones exactly are you looking for? [16:09:17] * YuviPanda hasn't checked out the commons app in a while [16:09:32] those iOS folks have been busy. [16:09:32] currently fixing: Image Caching + sharper/proper-res images [16:09:41] ragesoss: yeah, and they've almost caught up with Android :P [16:09:55] they get pic of the day on the login background. [16:09:55] *almost* :P [16:10:05] mostly iOS is much prettier now :) [16:10:28] yeah, other than the 'prettiness' department :P [16:10:49] brion: we also seem to have nobody in the design team who actually use Android, so I'm at an inherent disadvantage here :( [16:11:01] (except Pau) [16:11:26] luckily iOS 7 looks like android 4.2 [16:11:34] so we're on track to design parity ;) [16:11:40] :) [16:11:45] ragesoss: but feature wise, is anything missing? [16:11:46] I guess I should install this 1.0.5 on my 3Gs [16:11:59] YuviPanda: I consider the pic of the day a feature. [16:12:00] ragesoss: I'm going to spend this week doing underlying fixes, and then on to campaigns. [16:12:21] * YuviPanda eyes brion [16:12:26] whee [16:12:42] brion: I'm currently moving to volley by building a 'MediaWikiImageView', to which you can simply set a filename and it'll automatically do everything else :) [16:12:52] perfect [16:12:56] i was gonna suggest that :D [16:13:02] requests appropriate image size, does caching, etc [16:13:16] and the caching apparently fully respects HTTP Caching Headers (as it should) [16:13:54] ragesoss: I think it'll be trivial to do 'image of the day' once that thing is done, but I'm going to leave that to brion :P [16:14:06] yeah i'll have fun doing that [16:14:14] ragesoss: and as for 'feature' - I'd consider 'change my desktop wallpaper to image of the day' to be a feature, not that image in the login screen :P [16:14:42] well, it doesn't matter as much for Android, since theirs no quick way back to the login screen once you're logged in. [16:15:11] but now with the "continue as ragesoss" on the Account screen on iOS, I think that's a good in-app feature. [16:15:13] ragesoss: there is *no* way to the login screen now, IIRC [16:15:21] we should have an easier way back to accounts... [16:15:27] yeah [16:15:29] YuviPanda: have you seen the updated Gmail app with multiple accounts? [16:15:33] brion: yes yes :) [16:15:35] it's pretty neat [16:15:36] it shows them as radio buttons in the sidebar, kinda neat [16:15:56] yeah, but our underlying infrastructure isn't setup to handle multiple accounts yet [16:16:11] brion: on this old iPhone, it is still incredibly tedious to get up to date on a long upload history. [16:16:19] ragesoss: i believe it [16:16:32] it'll still be sluggish on newer phones too, but not as broken as before [16:16:36] and it complicates things a fair bit, so I'm loathe to do that without a fair reason (testwiki switching doesn't count :P) [16:16:38] it stops loading when the app closes, which it does automatically when the screen times out. [16:16:43] ragesoss: see? iOS yet to reach parity with Android on that :P [16:16:44] we have to figure out how to fetch just the beginning and then fetch more in bg [16:16:55] :) [16:17:07] in iOS 7 we'll be able to wake in background \o/ [16:17:25] but even on 6 we should be able to pick up from where we left off downloading. it's not rocket science, it's just some work [16:17:26] INNOVATION! [16:17:44] YuviPanda: i hear they have animated lock screens with multicolored blurry circles moving around too [16:17:47] with thinner fonts on the clock [16:17:52] SUCH BRILLIANCE [16:17:53] there are also several people now going 'now that iOS7 has come out, Samsung and GOogle will now be set up to copy them soon!' [16:17:59] lol [16:18:11] for real too - that is what they sincerely believe. [16:18:17] *headdesk* [16:18:59] brion: screenshots in http://www.droid-life.com/2013/06/10/ios7-vs-android-a-quick-comparison-after-the-wwdc-keynote/ show it pretty neatly :) [16:28:41] brion: I find the greyed out Upload button on iOS Commons a little confusing. I want to upload something, I see a button that advertises what I'm looking for, but I can't press it. [16:28:54] ragesoss: yeah i think we're going to kill it [16:29:08] I imagine it's even more confusing on iPhone 5, since, the real button is sooo far down. [16:29:13] heh [16:29:30] iPhone 6 should be even taller… let's go for a 3:1 aspect ratio [16:29:50] want! [16:30:51] http://justinhileman.info/article/the-iphone-icon-ceiling/iphone-7-prototype.png ? [16:31:15] yes please [16:31:32] eat your heart out, Galaxy Note II [16:31:56] i'm just gonna carry my iPad around and Skype on it [16:32:03] SCREEN WARS [16:32:29] iPod + Skype, aka the NSA tricorder [16:32:44] haha [16:33:16] I should probably start running MIUI on my android devices. [16:33:38] I'm guessing the developers took out the NSA backdoors when they were installing the chinese ones. [16:34:16] :D [16:36:38] New review: Yurik; "Approving despite my gut feeling that this might not be a good idea :( - most of the log entries hav..." [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 2; - https://gerrit.wikimedia.org/r/67504 [16:36:44] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67504 [16:44:06] dr0ptp4kt, i +2ed your !=null patch, but really not sure why we would need that [16:44:27] most of the zero log entries have that conditiotn [16:47:43] New patchset: Jdlrobson; "Spike 820: Reduce API errors related to anonymous tokens (hopefully)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67867 [16:47:49] New patchset: Jdlrobson; "Spike 820: Reduce API errors related to anonymous tokens (hopefully)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67867 [16:50:58] humm, no standup today? [16:53:36] New review: Jdlrobson; "Something not quite right with this. On iOS the margin is now increased between the image and the fi..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68124 [16:54:31] dr0ptp4kt, around? about to start deployment [16:55:53] need help? [16:58:02] MaxSem, thx, i don't think we have any sync changes, minor updates [16:58:37] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68038 [17:02:10] MaxSem: standup now.. [17:02:19] have we seen jcmish? [17:02:29] link? it's not on my calendar [17:02:58] jdlrobson, ^^^ [17:04:06] yeh we just noticed that [17:04:08] very weird [17:04:26] https://plus.google.com/hangouts/_/6ed7ec0df73fbd7ad192402c6e0dc9bb3886848a < MaxSem [17:16:34] MaxSem, 2 Warning: preg_match() [function.preg-match]: Compilation failed: regular expression is too large at offset 58 in /usr/local/apache/common-local/php-1.22wmf5/extensi [17:16:35] ons/MobileFrontend/includes/api/ApiQueryExtracts.php on line 261 [17:16:48] noticed in fatalmonitor [17:16:49] known bug [17:16:53] ok [17:18:12] yurik, here [17:18:18] yurik, thx for the heads up [17:23:16] dr0ptp4kt, deployed [17:24:04] yurik, now, as to that patch, it's to protect 50 cent. i'll leave it at that. [17:27:45] yuvipanda, i'd like to have tfinc back with us for a broader discussion on data we're collecting across apps/web, so let's aim for sometime next week [17:28:28] i'm happy to ditch usernames if we don't need them, but i don't want to give them up if it makes us lose key metrics [17:28:33] Maryana: sure! setup an event on the calendar? [17:28:37] will do [17:29:00] and i'll try to set up a doc with an audit of what we're collecting & what kinds of questions it helps answer [17:29:06] Maryana: do we have a 'list of key metrics'? then easier to figure out what else we can drop [17:29:07] yeah [17:29:19] we made one at some point on a whiteboard, but i don't think we ever retained it [17:29:24] (ironically :-P) [17:30:30] Maryana: :D [17:31:08] prepare to have your minds blown: ios7 has dynamic wallpaper [17:32:05] congrats! out of stone age, a dark age is coming:P [17:32:34] and then there will be Renassiance [17:32:39] MaxSem: you misspelt 'supercharged' and 'innovation' [17:33:12] so.. it's basically the os equivalent of myspace? [17:33:21] * MaxSem spits his sarcastic poison at YuviPanda [17:34:12] MaxSem, you know what they say - if your knee hurts, come over to my house for dinner, my mother in law will spit and rub, and it works better than snake poison ;) [17:41:35] hmm, i can't seem to find a morning time on tfinc's calendar for the next 2 weeks, yuvipanda... [17:41:46] including this one? [17:41:58] he's out the rest of this week for getting marriaged :) [17:42:43] Maryana: :D yeah, but I meant 'this week plus next week' or 'this week plus next plus next' [17:43:02] this week, next week, and the week after [17:43:47] maybe i'll just email him and let him set something up... [17:43:50] Maryana: alright [17:44:00] no distractions from the mawwyage though :) [17:44:07] haha [17:44:07] yeah [17:44:24] i'll put "do not read until after married" in the subject line [17:44:35] that sounds... ominous :P [17:44:41] hahaha [17:45:07] New patchset: MaxSem; "Bug 49463: "Mobile view" link should be protocol-relative" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68202 [17:45:35] Maryana: is there info on the mobile-disambiguation thing somewhere? [17:45:41] I assume it'll be web based... [17:46:09] it's just going to be a prototype - we only have 2.5 weeks to work with them, so we don't have time to build a real thing [17:46:18] ah, okay [17:46:39] hmm, https://fbcdn-sphotos-c-a.akamaihd.net/hphotos-ak-prn1/946962_209577002524597_14634642_n.jpg is missing a laptop [17:50:26] New review: Jdlrobson; "My main concerns:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67934 [17:52:41] MaxSem: any way I can test this or should I just take your word for it :)? https://gerrit.wikimedia.org/r/#/c/68202/1 [17:52:42] * jdlrobson doesn't have an https localhost [17:53:04] just set $wgServer to be protocol-relative [18:23:03] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68202 [18:37:19] New patchset: Jdlrobson; "Story 488: Add pageimages to search results (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508 [18:49:36] whee updates for android studio [18:49:59] brion: :) [18:58:54] New patchset: Jdlrobson; "Move language selector specific css to separate file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67914 [19:00:18] man i need a better firefox os test phone. like that supports 3g in america [19:00:22] MURICA [19:04:54] brion: is there a 'mobile team lunch' thing going on right now? [19:05:10] YuviPanda: according to the calendar, but we seem to all be sitting and working :) [19:05:19] well, good enough for me :) [19:06:34] New patchset: MaxSem; "Replace MakeGlobalVariablesScript hook with skin code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68215 [19:08:35] ooh geeksphone Keon is in stock again [19:08:42] trying to order one [19:09:49] jdlrobson, did we ever come to consensus around what to do w/cross-wiki tokens? [19:10:19] this card (https://mingle.corp.wikimedia.org/projects/mobile/cards/828) is still empty, and we can't emilinate special:handshake w/o doing something about those tokens :) [19:11:17] brion: I haz high res imagery :) [19:11:26] \o/ [19:11:33] brion: it looks like crap on my phone though, mostly because all my test images aren't that big [19:11:36] still, yay [19:13:40] now to add circles to it [19:13:52] brion: it's also slower on my slow-ish connection [19:15:31] geeks phone's payment processor won't take my visa. bank says there's nothing on their end, it must be on their end. sighhhh [19:15:49] paypal? [19:20:06] no paypal option [19:20:16] also i closed my paypal out of protest a couple years ago [19:20:23] i rely too much on the big banks or i'd close that too :P :) [19:34:46] New patchset: Yurik; "Reworked zero validation and array sorting" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68221 [19:47:44] brion: got it :) [19:47:49] whee [19:52:30] brion: should I PR or just commit? [19:52:34] nah, I'll PR [19:52:35] PR [19:57:28] dr0ptp4kt, grr, api1 got config issues :( [19:58:36] yurik, you're not supposed to have those ;) [20:00:35] dr0ptp4kt, i think they re-provisioned that instance [20:00:38] loosing all configs :( [20:00:51] yurik, OUCH [20:00:58] MaxSem: hangout [20:00:58] i just re-created the settings file (zeroSettings.php) [20:01:06] MaxSem: howdy [20:01:10] yo [20:01:12] dr0ptp4kt, but something is still missing :( [20:01:20] meeting [20:01:21] ? [20:01:33] brion: pushing [20:01:43] yurik :( [20:02:59] brion: the 'scratch' directorry makes everything slow :( [20:03:02] YuviPanda: i don't see it at https://github.com/Wikimedia/android-commons/pulls [20:03:08] brion: it's still pushing [20:03:10] YuviPanda: once it's downloaded it'll be much faster :) [20:03:10] ah [20:03:23] or pushed once [20:03:23] to your clone [20:03:26] i just prefer not to lose those files [20:03:51] ooh we can add game controller support in iOS 7 [20:04:00] brion: https://github.com/wikimedia/android-commons/pull/33 [20:04:05] right trigger: delete image [20:04:11] [android-commons] yuvipanda opened pull request #33: Volley images (master...volley-images) http://git.io/uBzUSg [20:04:17] \o/ [20:04:19] looking [20:04:24] brion: look look :) [20:04:37] brion: both detail view and list view have been migrated [20:04:58] oh yay volley's in maven so we don't have to import it? [20:05:19] brion: volley isn't in maven central, but I put it in *my* maven repo (yuvi.in/maven) :P [20:05:31] heh [20:05:33] sigh [20:05:52] does the in-memory LRU cache clear if we get told of memory pressure? [20:05:57] or does that concept exist in android [20:05:58] brion: yup yup. [20:06:00] ok [20:06:18] brion: it doesn't actually wait for memory pressure. if it exceeds 1/8th max VM size, it starts clearing out [20:06:36] ah i see [20:06:39] dr0ptp4kt, do you think you could figure out what is wrong with it? zero namespace is not working for that instance :( I need to step away for a bit [20:06:39] brion: we could play with it more, sure. [20:06:46] that'll do for now i'm sure [20:06:53] brion: also, in detail view - every time you see something the -1 and +1 images are also fetched. [20:07:04] makes it look slower to load initially [20:07:28] brion: how's it on the phone? [20:07:34] still peeking at code [20:07:58] ok :) [20:08:00] yurik, can this wait until later today? i'm working on the banner decoupling stuff atm. [20:08:08] brion: the old UIL stuff is still there - we're using Volley only for 'remote' stuff now [20:08:20] brion: will change tomorrow, once I figure out how to fake HTTP over content:// [20:08:34] ok [20:09:01] YuviPanda: is the caching in-ram only or do we get storage-backed cache as well? [20:09:08] brion: both! [20:09:14] brion: there's a default disk based cache :) [20:09:26] \o/ [20:09:29] awesome [20:10:30] 'git fetch yuvipanda' [20:10:33] brion: hmm, limited to 5M to begin with. I'm thinking of expanding it [20:10:46] 5M doesn't get you very far in large jpegs :) [20:11:20] brion: true [20:11:50] brion: how should we determine it? [20:12:08] 5% of total free storage? [20:12:10] make up some nice number i guess :) [20:12:31] brion: https://git.wikimedia.org/summary/?r=apps/android/commons.git :) [20:14:47] YuviPanda: pictures in the my uploads list look AWESOME on the nexus4, but they def load slower [20:14:56] brion: indeed. [20:15:02] brion: what's the average size of those? [20:15:05] small test images? [20:15:09] or large 'regular' ones? [20:15:15] mostly full-size photos [20:15:21] ironically larger images should be faster here, since they take only 1 [20:15:25] brion: so, thoughts? [20:15:31] brion: should I not load full sizes? [20:15:35] brion: do you observe caching behavior? [20:15:42] caching behavior is much better yet [20:15:43] brion: I'm increasing caching size, moment [20:15:45] *yes [20:15:55] it used to have to refetch everything when i scrolled down and back up [20:15:57] much better now [20:16:31] YuviPanda: also i think we're requesting an odd size (768px is the raw width of this phone) which might be causing it to render the images for the first time [20:16:36] it = the server [20:16:40] so they're slower the first trip through [20:16:44] brion: ah, right. we should probably bucket it? [20:16:53] brion: to closest multiple of something? [20:17:02] brion: mine asks for 712px [20:17:15] maybe… like pulling 320*density for all phones maybe [20:17:30] 640 will still look nice on a 720 or 768px-wide screen [20:17:32] brion: we could just bucket it to closest multiple of 320 downwards [20:17:34] indeed [20:17:36] yeah [20:17:39] brion: also [20:17:41] in your terminal [20:17:44] adb shell setprop log.tag.Volley VERBOSE [20:17:45] then [20:17:49] adb logcat | grep D/Volley [20:17:52] shows you wonderful stats [20:17:55] on cache hits [20:17:57] network timings [20:17:58] etc [20:18:01] for everything :) [20:18:02] also something we've talked about on iOS -- we could pull smaller images while scrolling, then replace them with high-res when you settle somewhere [20:18:57] brion: ah [20:18:59] sweet [20:19:03] brion: could do, yeah [20:19:15] brion: okay, enlarging disk cache size. moment [20:19:18] oh hey i see your fallback behavior on some small images. yay! [20:20:15] YuviPanda: does it not start loading things until i'm done scrolling? or is it just taking a while for the round-trips and it feels like that... [20:20:25] round trips [20:20:36] brion: volley also does this 'batching' thing [20:20:41] which I personally don't like [20:20:49] a little batching is nice, but you don't want too long a delay on that [20:20:51] brion: where it tries to minimize 'number of times images appear' [20:20:55] brion: yeah, true [20:20:57] especially scrolling [20:21:22] brion: so fun thing is that Volley's support currently consists of just the git repo [20:21:23] nothing more [20:21:24] at all [20:21:28] but I feel comfortable switching [20:21:39] now that's open source [20:21:43] since every Google app (Play Store, Music, etc) uses this [20:21:47] and the code base is small enough [20:21:55] and it'll probably get rolled into Support Library at some point [20:21:59] i'm surprised it's not in the support library [20:22:00] yeah [20:22:02] and most importantly, the code is much better than UIL [20:22:15] plus it is written by one of the original android engineers [20:22:27] brion: plus it sortof has SPDY support :P [20:22:36] (sortof, since I'd need to include the OKHTTP backend) [20:22:40] \o/ [20:22:48] but we don't have SPDY support, so meh. [20:22:58] ok it's fetching 760px, we must have a slight border :) [20:23:26] brion: it's just different sizes for you and me, I think [20:23:34] brion: i'll round it down to the nearest 360 [20:23:35] yeah different phone widths [20:23:45] 320, I think? [20:23:59] 320 is canonical 'classic phone width' since iPhone :D [20:24:28] hehe [20:24:42] it's taking like 4-9 seconds to fetch each image for me. ick! [20:24:56] brion: what network are you on? [20:24:59] most sizes in 80-160kb range [20:25:11] brion: can you do the adb stuff I showed above, see if it is because of cache miss or network? [20:25:18] for that slow i assume the server's generating them on cache misses [20:25:25] YuviPanda: well it's back-end that'll be doing those [20:25:32] yeah i'm watching the volley log info [20:25:38] okay, moment, pushing update [20:25:58] for regular users of the app this shouldn't be a huge problem [20:26:07] since once they're generated they'll load much quicker from the server next time [20:27:05] brion: pushed [20:27:08] hmm i don't see any response on things that appear to be cache hits [20:27:11] *any logging [20:27:29] brion: I think in memory cache hit won't show you anything, but disk cache hit should [20:27:44] ok lemme kill/restart [20:29:05] ok i'm seeing like 150-250ms on what appear to be cached requests [20:29:09] that's much better :) [20:29:47] i'm not sure if it's doing a backend cache validation check or if it's actually taking a quarter second to read from storage [20:30:12] brion: hmm? [20:30:17] hmm, I see it [20:33:22] ok looks like uncached (but already rendered) items take 500-1000ms, which is more reasonable for a static file fetch [20:33:39] well more like 700-1000ms :P [20:33:48] dr0ptp4kt, sure thing, no rush [20:33:59] yurik, thx man [20:34:13] brion: the ~100ms+ thing might be the batching [20:34:19] yeah [20:34:40] YuviPanda: anything else you want to poke in the branch before merging? [20:35:19] brion: nah, merge it :) [20:35:25] brion: is a definite improvement, I think [20:36:19] hmm [20:36:31] if width is *less* than 320 will we end up rounding to 0? [20:36:49] i'm thinking of LDPI phones... [20:36:55] brion: ah, hmmm [20:37:01] brion: whelp, probably right :P [20:37:05] heh [20:37:19] hmm, is there a nice mathematical way to handle that? [20:37:30] nah, fuck it, I"ll just add a conditional [20:37:37] :) [20:37:44] math is hard [20:37:59] lemme bring up a VM at 240x320 ldpi [20:38:18] brion: added fix. pushing [20:39:07] brion: from next patch, workflow is going to be a *little* different, but not by much. we'll still use pull requests, just on a different repository (https://github.com/wikimedia/apps-android-commons) and final 'merge' button will be on Gerrit [20:39:18] ooooooh [20:39:23] one of the primary reasons I'm doing it is to test the G2G Bot (SuchABot) [20:39:33] \o/ yay [20:39:36] to find, fix and squash bugs :) [20:39:51] brion: so we keep discussion, etc on GitHub itself (For now), just do final 'merge' on gerrit [20:39:59] brion: let's do that from next patch. [20:40:07] ok [20:40:47] brion: actually, let's do this starting this time itself? [20:40:52] gimme a moment, let me set that up [20:40:55] you keep reviewing :) [20:41:04] heh ok [20:41:14] then i'm gonna get a burrito [20:41:52] brion: ah, lunch. what a queer concept :P [20:42:17] hm did you push that fix? i don't see it [20:43:35] brion: to what? [20:43:45] YuviPanda: for the <320 [20:44:41] brion: https://github.com/wikimedia/apps-android-commons/pull/1 [20:44:48] :) [20:45:01] ah right [20:45:10] hmm [20:45:44] ah it's cloned from the other repo? [20:46:05] brion: yup [20:46:13] ok lemme change this setup :D [20:46:18] brion: the base is the same, so you can just set it up as a remote and do a fetch. [20:46:33] will updates go to the same master? [20:46:33] brion: let's forget gerrit even exists, except for the final merge :) [20:47:14] brion: they have same history, so we can just treat them same. [20:47:23] brion: so if you setup a remote 'github2' for this one, you can do 'git pull github2 master' and that should work [20:47:53] ok i'll probably clean it up later, this'll do for now :D [20:48:12] brion: heh, okay [20:48:38] ok quick test in the emulator... [20:48:48] mmm [20:49:57] yay it shows images instead of crashing [20:50:00] that's an improvement \o/ [20:50:05] ok so i merge on gerrit? [20:50:17] brion: yup [20:50:36] ... [20:50:37] let me update CI [20:50:43] how/where? [20:50:57] brion: gerrit? [20:50:58] https://gerrit.wikimedia.org/r/#/c/68282/ [20:51:06] brion: that link was left as a comment on the PR :) [20:51:11] YuviPanda: other than asking you how the fuck do i find that? [20:51:18] ah there it is [20:51:19] :D [20:51:21] brion: it was a link on the pull request! :P [20:51:39] a comment, rather [20:52:02] brion: we also link back from Gerrit to the PR URL, so it isn't fully lost [20:52:10] brion: should we edit the commit message? [20:52:43] ok i pushed the merge button [20:52:45] let's see what happens [20:53:10] wooooooo it merged [20:53:12] brion: well, it's merged :P [20:53:16] brion: no notifications here though [20:53:20] yeah [20:53:25] that's fixable [20:53:25] it did ping #wikimedia-dev though [20:53:35] sweet [20:53:58] brion: i'm updating Jenkins to pull from Gerrit [20:55:25] brion: hmm, looks like I'll need hashar's help to switch this over :( [21:01:00] heh ok [21:04:46] ok it's burrito time [21:06:16] New patchset: Jdlrobson; "Add FIXME to barely used piece of CSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67909 [21:35:23] New patchset: Jdlrobson; "Remove unused css/ module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68292 [21:41:40] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68215 [21:45:53] MaxSem: any ideas of better images for https://gerrit.wikimedia.org/r/#/c/66277/4/MobileFrontend.php? [21:46:21] ask designers? [21:46:57] also, nothing in UI should point to uploaded images, or we will rob lots of zero users [21:47:19] ? [21:47:44] alpha only for time being [21:47:58] not a reason to make them pay [21:47:59] i don't want to invest too much time in something that might not get traction [21:48:20] so if I add a flag to take into account disabled images are you cool with it [21:48:24] bearing in mind it only triggers on ipads [21:48:29] and other larger screens [21:48:55] yes. and load the default one from bits or appservers [21:49:19] yurik & dr0ptp4kt ^^^ [21:49:31] MaxSem: how do i get http://upload.wikimedia.org/wikipedia/commons/6/63/Wikipedia-logo.png on to bits? [21:49:44] anything else we need to know to make this zero-friendly? [21:50:01] mediawiki-config/images [21:50:07] MaxSem: it may never make it to mobile - this might just be a desktop thing [21:50:36] if there is a creative way someone might see this on mobile be sure they will [21:51:37] MaxSem: #wikimedia-operations [21:52:36] already there:) [21:56:49] MaxSem, sorry, what's up? [21:58:20] yurik, discussing serving large pics in page header for wide-screen devices - need to avoid making zero users pay for them [22:00:37] MaxSem, not sure zero users will be happy :) [22:00:42] New patchset: Jdlrobson; "Alpha: Introduce a page banner concept on tablets and desktop Minerva skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66277 [22:01:00] unless images are coming from bits [22:01:03] New patchset: Jdlrobson; "Alpha: Introduce a page banner concept on tablets and desktop Minerva skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66277 [22:03:01] New review: Faidon; "I checked a few URLs from cp1041/cp1043 and I don't seem to be able to get such headers. This is pro..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/68009 [22:04:56] New review: MaxSem; "Full discussion: https://dpaste.de/jwcQp/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68009 [22:05:44] bahhhhh i shouldn't get in Facebook fights about NSA spying, it just works me up [22:06:15] brion: fights? [22:06:26] * YuviPanda has never seen an Angry brion [22:06:58] arrrrrrr [22:15:02] MaxSem: https://gerrit.wikimedia.org/r/#/c/68116/ < is that ready to go? [22:16:37] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68116 [22:16:45] yep [22:19:47] New patchset: Jdlrobson; "Spike 820: Reduce API errors related to anonymous tokens (hopefully)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67867 [22:19:54] jgonera: ^ when you get a chance would be good to finish off this spike [22:24:04] New patchset: Jdlrobson; "Bug 48792: Left align edits text for large numbers" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68299 [22:24:47] MaxSem: any progress with the preview bug? [22:24:57] will do [22:25:05] brion: link to your API account creation patchset/ [22:25:06] ? [22:25:34] YuviPanda: https://gerrit.wikimedia.org/r/#/c/53794/ [22:25:42] haven't touched it in ages, don't know if it's still ok [22:25:55] yeah, someone asked for it [22:48:03] brion: found their 'batch'ing tweaks, removing it now ;) [22:51:16] mhurd: do you remember off the top of your head what pieces of info legal needed from us on image overlay attribution? [22:52:45] New patchset: Dr0ptp4kt; "Further decouple banners from MobileFrontend. Dependent on change 67546." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [22:53:11] Maryana: the license for the image and a link to it [22:53:36] sweet, thx [22:53:41] and the username, right? [22:53:53] or no..? [22:53:58] ya [22:54:08] New review: Dr0ptp4kt; "See change 68304 for the corresponding ZeroRatedMobileAccess code." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67546 [22:54:24] ok this burrito is putting me to sleep and my design ideas are getting way off track. gonna go home, nap, and then get back to my detail view plans [22:54:32] YuviPanda: need anything poked real quick or ok to do later? [22:54:53] New review: Dr0ptp4kt; "See See change 67546 for the corresponding MobileFrontend code." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [22:55:24] brion: nothing major, and I'm going to self-merge small things [22:55:27] so it's fine :) [22:55:31] ok [22:55:33] catch ya later [22:55:37] Maryana: oh and they said the copyleft icon would be better than the cc icon i was using [22:56:00] gotcha [22:56:02] thank you! [22:56:32] New review: Dr0ptp4kt; "Jon noted that we should look at the HTML concatenation as well. Will add a TODO for that in a forth..." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [22:58:46] New patchset: Dr0ptp4kt; "Further decouple banners from MobileFrontend. Dependent on change 67546." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [23:02:23] New patchset: Jdlrobson; "Story 774: Allow people to navigate to nearby places" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68306 [23:04:09] New patchset: Jdlrobson; "Story 774: Allow people to navigate to nearby places" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68306 [23:22:02] New review: Dr0ptp4kt; "MUST ONLY BE MERGED IN CONJUNCTION WITH CHANGE 68304." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/67546 [23:24:32] New review: Yurik; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [23:37:25] yurik, i think apibeta is working now [23:38:29] oh, yurik, i see you started on a separate zero config file. [23:38:39] yurik, hang on will update [23:39:41] New review: Yurik; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67546 [23:44:38] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68306 [23:49:20] yurik, ok, LocalSettings.php points at ZeroSettings.php on apibeta. for long that will last i'm unsure! [23:52:12] yurik, beware autoredirects for X-CSes with only one whitelisted lang when visiting Special:ZeroRatedMobileAccess [23:54:09] jgonera: is this fixed https://bugzilla.wikimedia.org/show_bug.cgi?id=49223 :)