[00:01:22] dr0ptp4kt, thx!lets keep all settings in a separate file so that puppet runs don't erase all changes [00:02:38] yurik, got ya [00:23:38] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68306 [06:15:31] [Commons-iOS] montehurd opened pull request #88: Pic of day refactor and bug fixes (master...picOfDayRefactor) http://git.io/F9ahXA [11:32:00] I'm just wondering: why isn't there an option to change the license? I'm using CC BY more for photos on Commons…. [11:33:47] ter_burg: there's a bug for it [11:33:57] ter_burg: also, iOS or Android? [11:34:23] iOS [11:34:25] (https://bugzilla.wikimedia.org/show_bug.cgi?id=47937 and https://bugzilla.wikimedia.org/show_bug.cgi?id=47938) [11:34:31] which are different bugs for sortof the same thing [11:34:44] just uploaded http://commons.wikimedia.org/wiki/File:Poortgebouw_Huis_Doorn.jpeg [11:35:00] mm sweet! [11:35:15] ter_burg: I think we'll probably add an option to specify license at some point [11:36:09] thank you for the information YuviPanda, add me to the list of people that really would like this option ;-) [11:36:25] ter_burg: of the two, which would you consider more important? [11:36:31] letting you change it in 'options'? [11:36:33] or change it per image? [11:36:59] I'd say options [11:37:36] yeah, me too [11:37:54] I've got more than 11.000 photos on Flickr and it took me years to go from CC BY-ND-NC to CC BY [11:38:21] on Flickr it is also something you can put in as a default option and you've got the option to change te license later [11:38:26] yeah, we'd like more people to get to CC BY [11:42:21] Wouldn't it be possible to set it in options and still have the possibility to change it with every individual upload? [11:42:22] ter_burg: you should maybe comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=47938 then :) [11:43:12] ter_burg: sure, it's just that we have limited number of people hacking on it and need to prioritize [11:52:44] YuviPanda: done! [11:52:47] ty [12:03:20] YuviPanda: this must be coincidence! [12:03:27] ? [12:03:34] which? [12:03:41] I used a photo of you in my TEDx talk... [12:04:16] Wait a moment, I'm putting the slides online [12:09:29] ter_burg: wah?! [12:10:45] YuviPanda: I've used this photo http://www.flickr.com/photos/yuvi/2382458417/ [12:11:06] haha [12:11:07] nice [12:11:09] in what context? [12:11:17] man that shot is almost, 8 years old now [12:11:20] from high school! [12:14:11] it's on slide 26: http://www.slideshare.net/terburg/ted-x-final [12:14:28] I give talks about business models for creatives [12:15:20] I'm a professional photographer that has been using CC from the start of my career as a professional in 2007. [12:16:45] the context is that it can be scary to publish your work under a free license because you don't know in what context it will be reused [12:18:31] my talk will be online next week [12:27:58] ter_burg: nice :) [14:09:04] New patchset: MaxSem; "Remove Zero banner cruft" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67546 [14:09:44] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67546 [14:53:12] New patchset: MaxSem; "Warn about exlimit being adjusted down" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68401 [15:56:59] [Commons-iOS] brion opened pull request #89: Detail page style adjustments (master...detail-style) http://git.io/BNb7PA [15:57:28] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/7Ob_LA [15:57:28] Commons-iOS/master 016e3f2 Monte Hurd: Big performance boost on pic of the day transistions on old devices [15:57:28] Commons-iOS/master ce89152 Brion Vibber: Merge pull request #86 from montehurd/choppyLogin... [15:58:28] [Commons-iOS] brion pushed 5 new commits to master: http://git.io/NifyWw [15:58:28] Commons-iOS/master 2eed0ad Monte Hurd: Fix for i18n, details page, "Categories" heading [15:58:28] Commons-iOS/master 4f91c4e Monte Hurd: i18n for queued images which have yet to have a title entered... [15:58:28] Commons-iOS/master fe3f5bb Monte Hurd: i18n for "Read about licensing" label on License page... [16:27:38] Fatal error: Call to a member function saveXML() on a non-object in /usr/local/apache/common-local/php-1.22wmf5/extensions/MobileFrontend/includes/HtmlFormatter.php on line 290 [16:29:04] thx, looking [16:29:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=49534 [16:29:59] Logged with stacktrace [16:30:51] lol [16:31:20] I noticed that piece of code some time ago, wondering why there are no fatals from it:P [16:41:46] New patchset: MaxSem; "Bug 49534: Call to a member function saveXML() on a non-object" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68429 [16:48:04] * YuviPanda waves at brion [16:58:42] New patchset: MaxSem; "Move some code out of ExtMobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67361 [16:58:42] New patchset: MaxSem; "Split MobileFormatter to separate classes for HTML and WML" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68434 [17:01:20] New review: MaxSem; "I really want to reorg the file structure, but am blocked on pending commits. Will do that after eve..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68434 [17:17:44] mhurd check out my detail page branch there's a pull req [17:18:22] I'm thinking we can combine the zoom detail view into the top section of the detail page with a little more work [17:21:49] brion_: will do! [17:21:49] Hey folks. I have a guy who wants to report a bug with the mobile UI. Where should I direct him? [17:22:21] halfak right here if on irc :) [17:22:28] otherwise bugZilla works [17:24:18] Thanks Brion. For BugZilla, which product should it be filed under? [17:25:07] I see "MobileFrontend" under Mediawiki extensions. Is that right? [17:25:59] brion_: ^^^ [17:26:00] halfak yes [17:26:06] OK. Thanks :) [17:34:13] brion_: hey! Can you try the speed of the image fetching on your nexus 10? [17:34:15] brion2: ^ [17:34:19] brion: ^ [17:34:40] its at the office I'm at home atm [17:34:56] ah, okay [17:35:02] do try that out when you can :) [17:35:34] ok :D [17:35:51] if i keep things at home i don't have em at the office [17:35:56] if i keep them at the office i don't have them at home [17:35:59] it's a pain in the ass [17:36:12] why do we even have an office except for the occasional meeting? it's a waste of donor money [17:36:17] [17:41:06] grrrr my screen recording ain't working [17:41:12] * brion applestab [17:44:30] mhurd: YuviPanda: ok here's a picture since my screen recording won't work https://brionv.com/misc/detail-page.jpg [17:44:46] basic idea is to make the view scroll-uppable [17:44:50] stick the title at the bottom [17:44:51] brion: playing w the branch now [17:44:58] maybe kill the toolbar or change it [17:45:14] brion: mmm the categories stuff looks sweet brion [17:45:15] one could also have the detail information slide up *over* the image, which might look awesome [17:45:31] i also changed the table view style to be less old-fashioned [17:45:31] brion: ya that would be cool! [17:45:48] brion: we should also move to starting the download without title / description, and adding those later [17:45:51] (stashed downloads?) [17:46:04] YuviPanda: in android can we do a scroll view that sits on top of a still view? or would that be weird :D [17:46:07] yes we should def do that soon [17:46:13] brion: we arleady do that :P [17:46:14] makes the workflows easier [17:46:18] heh [17:46:18] oh vibha's stopping by at 11:30 to talk about design [17:46:39] i'll probably go to sleep earlier today, not feeling so great. [17:46:42] ok [17:46:44] she may have something for details page too [17:46:47] picking up the legal stuff for wikipedia mobile though [17:46:53] yay legal [17:47:04] * YuviPanda feels a little sad about nobody in the design team using Android [17:47:48] brion: I'm also thinking of using some 'research time' '20% time' or whatever to build a parallelax effected wallpaper for Android that shows you POD [17:47:56] hehe [17:51:36] brion: did you see a calendar invite? not sure i did it correctly... [17:52:09] mhurd: don't see it :( [17:52:13] brion: gah! [17:53:01] brion: it may be because i didn't create the event? [17:53:22] hah [17:53:39] MaxSem: i saw some notes fly by in my IRC logs from you - do you need some help with code review or anything else? [17:53:59] yes please - I'm stuck on CR [17:54:23] MaxSem: what should i start with? [17:54:29] all your previous concerns are either addressed or replied to [17:54:33] ok cool [17:55:15] brion: are you heading this way or working from home? [17:55:16] with any refactoring commit out there [17:55:46] mhurd: i won't make it there by 11:30 so i'll just stay here i guess [17:56:52] brion: cool. hangout or should i report back [17:56:56] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68401 [17:57:09] mhurd: let's try hangout and if you guys are just sketching stuff i can't see i'll tell you to report back ;) [17:57:20] brion: sounds good! [17:57:21] but i'll show off a couple things quick i guess :D [17:58:14] ok i definitely like the idea of the detail info "sliding" up over the image [17:58:25] i'm not quite sure how to implement it but we'll figure it out :D [17:58:50] New patchset: Jdlrobson; "Bug 48760: Remove br tags from diffs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68456 [17:59:27] brion: i'm thinking i should hold off for a bit on this card: https://trello.com/card/make-ipad-pinch-zoom-work-with-lower-resolution-image-presently-it-s-requesting-a-large-image/51a538008058288a1a0006db/89 [17:59:32] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67361 [17:59:38] brion: until designs finalized [17:59:46] heh yeah [17:59:53] thats likely to change :) [18:00:04] thought the loading logic should be keepable [18:00:25] brb [18:00:40] brion: yesterday's refactor should make it really simple to get the aspect fill size needed for whatever we come up with [18:00:40] oh -- also i'm gonna take some screenshots under iOS 7 sdk with new style [18:00:55] see if we want to use the new standard nav bar or go wildly custom [18:01:15] brion: ohh that would be interesting to see [18:02:53] MaxSem: im confused about https://gerrit.wikimedia.org/r/#/c/67481/ [18:03:02] dfoy, are we meeting? [18:03:07] the query i used i just wrote myself based on the code [18:03:26] don't do that [18:03:29] kk [18:03:41] yeah, i should use the query dumper thing [18:03:45] yes just getting the conference camera set up for you :) [18:03:55] for example, USE INDEX gets rewritten internally to FORCE INDEX etc [18:04:55] where does that happen? [18:05:00] does mediawiki do that?? [18:05:41] buh the sql dump is noisy [18:05:43] yes [18:06:43] MaxSem: that query should happen on watchlist load, right? [18:06:59] yes, feed button [18:09:23] i hate that my phone drops network in the bathroom :) [18:09:45] lemme turn off irc there anyway, i've got my laptop open [18:09:49] brion: even touching PhoneGap again makes me feel dirty [18:10:23] aww [18:13:17] ooh i've also got a crazy idea for the my uploads view, let me whip up a mockup screenie [18:17:09] MaxSem: does mediawiki change 'use index' to 'force index'? [18:17:21] brion: https://github.com/wikimedia/WikipediaMobile/pull/327 [18:17:26] [22:03:55] for example, USE INDEX gets rewritten internally to FORCE INDEX etc [18:17:55] yeah, but what does that rewriteing? [18:18:05] DatabseMysql [18:18:20] but you should believe your debug log, not me [18:18:25] not even the code [18:18:35] lol i know, but i want to make sure it will still work the same way in production [18:18:51] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/keYb0g [18:18:52] WikipediaMobile/master eaa1524 YuviPanda: Make sure that the contributors link always opens in external browser... [18:18:52] WikipediaMobile/master 8198d7c Brion Vibber: Merge pull request #327 from yuvipanda/bug/49402... [18:20:33] i find it a little weird that mediawiki converts 'use index' to 'force index' [18:20:58] brion: any chance to kick the tires on the picOfDayRefactor branch from last night? [18:21:12] but, it works [18:21:30] New patchset: MaxSem; "Remove custom caching headers" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68009 [18:21:38] mhurd: didn't seem to explode yet, i'll poke it shortly :D [18:21:50] almost thought i merged it already :D [18:21:57] brion: i strive for non-explodiness :) [18:22:05] huh Database.php doesn't seem to support a 'force index' clause [18:22:27] :D [18:22:27] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68009 [18:23:21] New review: awjrichards; "ok yeah; didn't realize that mediawiki converts 'use index' to 'force index'. looks right after chec..." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67481 [18:23:33] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67481 [18:25:53] MaxSem: minor nitpicky question: https://gerrit.wikimedia.org/r/#/c/66888/5/includes/api/ApiQueryExtracts.php [18:26:51] YuviPanda: mhurd: ok crazy idea something like this: https://brionv.com/misc/commons-mock-sidebar.jpg [18:27:08] the two sides are at different scales, but scroll together so scrolling the sidebar a little scrolls through the big list fast [18:27:10] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888 [18:27:19] replied [18:27:21] tap on an image to zoom in to the detail view [18:27:40] oh i used the wrong template image. bah oh well :) it says details ;) [18:27:41] brion: whoa… that's cool [18:28:13] i got the idea from the iOS 7 multitasking apps list [18:28:23] brion: that would even work on iPad [18:28:23] it's got screens on the top, icons on the bottom [18:28:36] yeah i was thinking this might be cleaner than the multicolumn layouts we were thinking before [18:28:49] brion: yeah [18:28:55] brion: wow [18:29:16] brion: i'd love to implement that [18:29:18] brion: that flew over me [18:29:19] :D [18:29:31] brion or YuviPanda, do you have the WP Android app versions breakdown? [18:29:32] yeah i worry it's too complex [18:29:47] MaxSem: breakdown in terms of install base? [18:29:48] hard to visualize without a demo, and it's hard to mock up in html :) [18:29:54] yes [18:29:56] MaxSem: i've access to that, yes. [18:29:57] moment [18:30:52] brion: i'll run this by vibha and may when we talk [18:30:58] excellent [18:31:48] brion: oh hangout. *you* can run it by them haha [18:32:05] \o/ [18:32:45] brion: hopefully they're on their way... [18:33:07] just ping me and drop me the hangout url when they're here :) [18:33:13] MaxSem: email'd CSV [18:33:19] thanks! [18:33:32] MaxSem: let me know if you just want me to explain / or get more stats [18:34:26] ehm, unit test failure [18:38:01] lemme switch to laptop :D [18:38:13] brion: do you see hangout? [18:38:37] i see you [18:39:11] New patchset: MaxSem; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888 [18:41:46] frak. ^^^ works on my machine but fails on jenkins [18:41:48] APC? [18:45:30] huh works for me too locally, MaxSem [18:46:21] could be apc, i guess - has that been a problem before? [18:47:09] hmm, it's already disabled [18:47:50] o_O [18:50:03] both my VM and fenari have the same libxml version [18:50:07] could it be something weird with libxml? [18:50:08] oh [18:50:35] are the tests run on fenari tho? [18:50:45] and/or could it be something weird with DOMXpath? [18:51:10] the tests are eun on some other server [18:53:41] hmm [18:53:50] i dunno MaxSem [18:54:06] trying on staging [18:54:25] part of me is tempted to merge anyway, but i think we should figure out what the problem is first in case the issue is present in prod [18:57:43] https://gerrit.wikimedia.org/r/#/c/68015/ < awjr can you take a quick look [18:57:55] yeah one min [18:58:39] MaxSem: test failing here https://gerrit.wikimedia.org/r/#/c/66888/ [18:58:47] (in case you missed it) [18:59:16] no, you missed what we're discussing^^^:) [19:01:55] jdlrobson: just needed to remove qqq messages for the msgs you removed; i'm uploading a new patchset now [19:02:00] New patchset: awjrichards; "Story 790: Standardise use of words" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68015 [19:02:01] awjr, works on staging [19:02:04] hmm [19:02:58] New patchset: awjrichards; "Story 790: Standardise use of words" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68015 [19:03:00] whoops missed one [19:03:43] MaxSem: i think we should still sync up with hashar or someone before merging that change [19:03:57] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68015 [19:04:19] he's away, will be back only after the merge threshold [19:04:34] i guess the worst that will happen is that extracts remains broken [19:04:42] meh [19:05:01] MaxSem: can you send an email about the weirdness anyway? i'll go ahead and merge it [19:05:14] MaxSem: also https://gerrit.wikimedia.org/r/#/c/67472/ needs a rebas [19:05:15] e [19:05:45] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888 [19:05:49] New patchset: Jdlrobson; "Bug 49277: Make wgIsPageEditable more accurate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68483 [19:06:39] New review: awjrichards; "Not sure why the tests fail via Jenkins; they pass everywhere else we've checked. We should sync up ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/66888 [19:09:45] brion: suggestions on bluetooth keyboard to use with a tablet? [19:09:53] (friend coming from the US, thinking of having them get me sone) [19:10:19] YuviPanda: apple BT keyboard is ok, though i've had trouble pairing it with some computers [19:10:33] any non-apple suggestions? [19:10:43] i've got some weird off-brand one that seems to work [19:10:44] I think I have a self-imposed 'do not give money to apple' thing going on [19:10:47] hehe [19:14:49] New patchset: MaxSem; "Completely remove the $wgMFCustomLogos['logo'] stuff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67472 [19:17:23] brion: oh forgot to show them https://brionv.com/misc/commons-mock-sidebar.jpg [19:17:47] mhurd: still wanna get lunch? [19:17:50] ah we'll get em later :) [19:17:56] awjr: ya! [19:18:09] brion: so cool [19:18:13] mhurd: sweet, ready when you are :) [19:18:34] i think awjr and i have switched places this week :) [19:18:37] he's in and i'm mostly remote [19:18:48] hehehehe and im using ALL YOUR DEVICES [19:18:55] hahaha [19:19:02] lol [19:20:09] awjr_lunch, muhaha - https://gerrit.wikimedia.org/r/#/c/67472/ now fails due to that test [19:20:39] New patchset: MaxSem; "Revert "Bug 48917: Fix extracts" - breaks tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68487 [19:21:12] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68487 [19:23:37] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67472 [19:36:30] New patchset: JGonera; "EventEmitter tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68531 [19:36:41] jdlrobson, is it possible to use Minerva on mobile domain? [19:37:03] MaxSem: hmm? [19:37:09] New patchset: JGonera; "EventEmitter tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68531 [19:37:35] I mean the desktop version of it [19:40:22] New patchset: JGonera; "EventEmitter tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68531 [19:42:32] New patchset: Raimond Spekking; "Revert "Localisation updates from http://translatewiki.net."" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68532 [19:42:35] MaxSem: Not if i'm understanding you correctly [19:42:46] if you want to try out the desktop version you can set something in local settings though if that's what you mean [19:43:01] $wgValidSkinNames['minerva'] = "Minerva"; [19:43:02] $wgDefaultSkin = 'minerva'; [19:44:32] heh [19:44:44] okay [19:45:52] * jdlrobson is confused - all scripts seems to be loading at the top of the page now :( [19:46:09] MaxSem, any idea why I get Fatal error: Call to a member function removeChild() on a non-object in /home/jgonera/www/extensions/MobileFrontend/includes/HtmlFormatter.php on line 252 on master now? [19:48:28] jgonera, try updating again [19:48:58] ok, now it's fine, thanks [19:49:36] New patchset: JGonera; "EventEmitter tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68531 [19:49:43] * jdlrobson puzzled why all javascript is loading at the top on my instance [20:01:31] dfoy, i'm getting busy signal [20:02:00] yurik: I got in at 1-650-475-6700 [20:03:00] yurik: I can inquire about the memory if you are unable to attlend [20:03:51] dfoy, i keep calling, and getting either busy signal or disconnected [20:04:08] yurik: no problem - I'll take the call [20:04:52] dfoy, ok, let me know what they say about dumb splitting [20:05:09] dfoy, make sure to say that the JSON will be well formed [20:05:21] just that the payload will be split [20:17:40] New patchset: Yurik; "Minor cleanup to use ->inNamespace()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68551 [20:18:54] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68551 [20:22:48] New patchset: Yurik; "Smaller banner close box - shrunk width, not height" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68553 [20:31:41] New patchset: Jdlrobson; "Allow other projects to define their own mobile skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68556 [20:31:42] ^ MaxSem [20:32:08] background: GSoC developer wants to create a WikiData mobile skin - this should allow him to do so [20:32:27] also you can now run on Minerva on the mobile domain ;-) [20:32:29] tripppyyy :) [20:33:45] gahh MaxSem, i was afraid of that [20:34:13] we should bug hashar [20:34:55] heh, beautiful cascade of bots [20:34:57] I opened up https://github.com/wikimedia/apps-android-commons/pull/7 [20:35:04] New review: MaxSem; "Why remove the factory when you can alter it instead?" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68556 [20:35:05] which opened up https://gerrit.wikimedia.org/r/#/c/68557/ automatically [20:35:10] which left a comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=46761 :) [20:37:34] * YuviPanda heads to sleep [20:37:56] YuviPanda: goodnight! :) [20:40:09] New review: awjrichards; "I'm with Max on this - it's nice having the detection built into the factory method to keep things s..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68556 [20:53:21] MaxSem: so the factory method seems weird now to me.. [20:53:28] SkinMobileWML and SkinMobile are not related.. [20:53:44] ^ awjr [20:53:54] (in reference to https://gerrit.wikimedia.org/r/#/c/68556/1/includes/skins/SkinMobileBase.php) [20:54:25] also none of the other skins have a factory method.. [20:54:26] w [20:54:26] they're related in the sense that you get one of them [20:54:26] hy [20:54:34] why would we create one if we want to make mobile skins into desktop skins? [20:55:25] going forward SkinMobile should be the same as Skin with no other methods [20:55:28] this goes against that [20:58:08] It just seems an icky way to do things.. [20:58:30] and i don't see what advantage using the factory has over this way? [20:58:47] ^ awjr MaxSem [20:59:07] (note SkinMobileBase and SkinMobile should be merged in future) [21:12:03] New patchset: Jdlrobson; "Bug 48793: CSS issue on watchlist feed view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68560 [21:27:43] New review: awjrichards; "Jon convinced me that his approach is better - mostly because if we rely on the factory method, then..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68556 [21:29:29] New patchset: Jdlrobson; "Bug 49539: Don't load stable modules on nearby page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68565 [21:45:05] New patchset: awjrichards; "Allow other projects to define their own mobile skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68556 [21:47:36] New review: awjrichards; "I inverted the if() logic and removed the class_exists check. If the class doesn't exist, the whole ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68556 [21:53:35] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68556 [21:57:12] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68483 [22:10:56] New patchset: MaxSem; "Fix spacing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68571 [22:21:29] New patchset: Jdlrobson; "Bug 49218: Hide errors in preview output" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68575 [22:22:23] New review: MaxSem; "section: 0 is not needed (and will cause problems again)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68575 [22:23:23] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68221 [22:26:06] New patchset: MaxSem; "New hook, MobileSkinCreated" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68577 [22:27:06] New patchset: Jdlrobson; "Bug 49276: Disable accidental clicking of links in preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68578 [22:29:59] New patchset: Jdlrobson; "Bug 49218: Hide errors in preview output" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68575 [22:32:16] New review: Jdlrobson; "Could we not repurpose EnterMobileMode ?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68577 [22:33:10] New review: awjrichards; "As coded, this hook will also fire for WML content (not just HTML). Is that intentional? If so, comm..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68577 [22:33:15] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68571 [22:33:43] New review: MaxSem; "Yes, because Zero needs to work for WAP users too;)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68577 [22:34:03] MaxSem: per your comment on https://gerrit.wikimedia.org/r/#/c/68434/, were you planning to reorg as part of that patchset, or in a later one? [22:34:46] depending on how much PITA would merges be;) [22:35:41] haha http://www.buzzfeed.com/erinchack/why-no-one-should-mess-with-the-ocean [22:36:09] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68429 [22:36:22] New patchset: MaxSem; "Move Vary: headers setup from MF" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68581 [22:39:55] New patchset: awjrichards; "New hook, MobileSkinCreated" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68577 [22:42:08] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67909 [22:42:46] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68299 [22:44:55] heh. WML is just a subset of XHTML [22:52:11] New review: awjrichards; "Unit tests need to be updated to reflect these changes. Also, please split the formatter classes int..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68434 [22:55:41] New patchset: Dr0ptp4kt; "Smaller banner close box - shrunk width, not height" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68553 [22:59:06] New review: Dr0ptp4kt; "Sent screencap to dfoy for approval of close box." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/68553 [22:59:38] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68565 [23:00:39] ^yurik, let's wait for dfoy to approve, then hoping you can review and merge i modified it to use the css file instead of inline styling the padding. [23:01:42] New review: awjrichards; "Please separate into two patchsets, one that fixes the bug and one that enables on all namespaces. I..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68483 [23:06:01] New patchset: JGonera; "EventEmitter tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68531 [23:06:14] MaxSem: did you ever get a date from ops about enabling the automatic .m redirection for commons? [23:06:27] ugh [23:07:47] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68560 [23:09:40] New review: awjrichards; "Can we create a test for this?" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/68578 [23:10:42] New review: awjrichards; "Marking -1 due to Jon's outstanding question." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68577 [23:11:02] MaxSem: i take that as a no? :p [23:11:11] is there an RT ticket or something? [23:12:19] created https://rt.wikimedia.org/Ticket/Display.html?id=5296 now [23:14:50] New patchset: Jdlrobson; "Code cleanup: Kill talk.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68590 [23:16:33] cool thanks MaxSem [23:18:49] New review: MaxSem; "We can't repurpose EnterMobileMode for this because it gets run eg when we use the api.php?useformat..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68577 [23:20:35] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68577 [23:20:40] jdlrobson: do you mind if i break this into two commits? https://gerrit.wikimedia.org/r/#/c/68483/1 [23:24:23] New patchset: MaxSem; "Split MobileFormatter to separate classes for HTML and WML" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68434 [23:34:58] New patchset: awjrichards; "Bug 49277: Make wgIsPageEditable more accurate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68483 [23:37:01] New patchset: awjrichards; "Merge "Bug 48792: Left align edits text for large numbers"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68595 [23:38:17] New patchset: Dr0ptp4kt; "Smaller banner close box - shrunk width, not height" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68553 [23:38:20] New patchset: awjrichards; "Bug 49277: Make wgIsPageEditable more accurate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68483 [23:39:29] awjr, now you changed back from inNamespace() to getNamespace() ^^ [23:39:50] gah yeah MaxSem, merge conflict resolution fail [23:42:40] New patchset: awjrichards; "Bug 49277: Make wgIsPageEditable more accurate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68483 [23:42:55] MaxSem: ^ [23:44:04] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68483 [23:45:43] New patchset: Jdlrobson; "Bug 49462: Position fixed cleanup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68597 [23:45:56] New patchset: awjrichards; "Enable page creation and editing in all namespaces (with proper perms)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68598 [23:46:14] jdlrobson, https://gist.github.com/jgonera/5154384#file-localsettings-php-L32 [23:47:16] MaxSem: awjr there has been no movement on https://gerrit.wikimedia.org/r/#/c/67877/ ... [23:47:17] thanks jgonera [23:47:42] MaxSem: ill look in a sec [23:47:43] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68597 [23:48:33] New review: awjrichards; "Awaiting approval from product." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/68598 [23:49:11] wtf https://gerrit.wikimedia.org/r/#/c/68595/1 [23:49:17] MaxSem: what did i do?! ^ [23:49:51] mmm:) [23:50:15] is it safe to abandon that? [23:50:26] I guess [23:50:50] Change abandoned: awjrichards; "er..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68595 [23:53:42] New patchset: JGonera; "Story 692: Support for closing overlays with back button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67934 [23:56:22] MaxSem: are you fundamentally opposed to https://gerrit.wikimedia.org/r/#/c/67877/ ? [23:56:39] no [23:56:47] reservations? [23:57:30] none,I'm satisfied with Jon's rationale [23:57:37] now [23:57:48] im not sure it *really* satisfies the bug though [23:57:59] i mean, the real problem is the POIs in a single article [23:58:05] if i understand correctly [23:58:21] i guess im not really clear on the value that patchset adds for wikivoyage specifically [23:58:33] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68292 [23:58:46] but, i can see it being nice to be able to configure that variable [23:59:24] Change abandoned: JGonera; "Jon says to abandon." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68590