[00:02:57] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67877 [00:02:58] New patchset: Jdlrobson; "Bug 49276: Disable accidental clicking of links in preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68578 [00:04:50] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68578 [00:07:16] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68456 [00:08:28] New patchset: awjrichards; "Split MobileFormatter to separate classes for HTML and WML" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68434 [00:12:38] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68434 [00:13:22] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67914 [00:36:22] New patchset: Jdlrobson; "Story 774: Allow people to navigate to nearby places" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68306 [00:37:28] New patchset: Jdlrobson; "Story 774: Allow people to navigate to nearby places" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68306 [00:38:21] New review: Jdlrobson; "Reviewed in person with jgonera" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/68306 [00:38:49] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68306 [00:39:48] New patchset: JGonera; "Uploads tutorial CSS fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68124 [00:40:21] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68124 [01:29:23] New patchset: Jdlrobson; "Code cleanup: Merge mixins, use vertical-gradient" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68609 [01:29:24] New patchset: Jdlrobson; "Use 'agora' styling for button on settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68610 [01:30:27] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68609 [01:30:44] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68610 [13:58:16] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68575 [15:48:33] New review: MaxSem; "Wait a sec." [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -2; - https://gerrit.wikimedia.org/r/68581 [15:51:34] New patchset: MaxSem; "Revert "New hook, MobileSkinCreated"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68679 [15:52:06] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68679 [15:57:28] gerrit-wm, you're a slowpoke! [17:07:42] jdlrobson: hello! [17:08:05] hey pragunbhutani :D [17:08:20] did you make it to langkawi? [17:08:29] ah yes I did [17:08:33] beautiful place, this! [17:08:40] so are you on a beach now with your laptop :)? [17:08:55] haha, I was while I was writing you the mails [17:09:06] It's 1 am now and the hotel just closed their beach bar [17:09:13] now I've got no business there :p [17:09:18] :) [17:09:23] nice [17:09:37] the weather isn't much better than India's, unfortunately! [17:09:48] pragunbhutani: you should try living in the uk for a bit ;-) [17:09:49] okay, whose introduction did I miss [17:09:51] ? [17:10:11] MaxSem: this is pragunbhutani he's working on a Wikidata MobileFrontend skin [17:10:25] wee [17:10:30] gonna be a skin guinea pig :) [17:10:40] jdlrobson: haha, I've been to the UK twice, both times during beautiful summer weather [17:10:43] hello MaxSem [17:10:45] :) [17:10:55] jdlrobson, bit I mean, at the standup [17:11:18] ohhh lol i missed the start of that - awjr ? [17:11:33] eh? [17:11:34] so what can i help with you MobileFrontend wise pragunbhutani ? Have you made a MediaWiki skin before? [17:11:46] awjr: basically MaxSem would like to know who was the lady in the standup [17:11:52] oh! [17:11:59] jdlrobson: no I haven't, that's what I thought I'll do today [17:12:06] that is dr0ptp4kt's wife [17:12:12] ahhhh [17:12:16] give the skinning process a go and then I'll see how to bring it together with wikidata [17:12:20] apparently she works with OWASP [17:12:27] and is going to be spending a day a week or so hanging out in the WMF offices [17:13:04] pragunbhutani: this might be a good starting point https://github.com/jdlrobson/Minerva [17:13:08] (minus the mustache) [17:13:47] hey [17:13:51] only class SkinMinerva extends SkinTemplate should be class SkinPragun extends SkinMobile [17:13:51] what do you have against mustaches [17:14:11] public service announcement: do not share helium balloons with your coworkers [17:14:14] and class MinervaTemplate extends BaseTemplate would be PragunTemplate extends MinervaTemplate [17:14:21] it's fun and exciting at first, and then you get stomach flu [17:14:23] jdlrobson: so if I'm making a skin of my own, it gets included like an extension? [17:14:23] end of PSA [17:14:37] pragunbhutani: yup so you can package the skin in the extension you are writing [17:14:53] the code i sent should be relatively easy to read and give you an idea of the wireframe for a skin [17:15:09] jdlrobson: okay I'll go browse through that once [17:15:55] note this is a desktop skin so there are a few caveats for a mobile skin as these are currently still relatively new and in the process of being defined :) [17:16:15] jdlrobson: yeah, I'll be extending SkinMobile wouldn't I? [17:16:20] yep for the time being [17:16:29] since mobile skins are somewhat special right now [17:16:42] special as in? [17:17:00] alternatively if you really wanted to you could start a skin from scratch and simply extend SkinTemplate but that might be a bit too ambituous [17:17:19] jdlrobson: yeah, definitely not something to do as a first experiment [17:19:24] if you extend SkinMobile you'll get a lot of ui for free and won't have to worry too much about styling apart from the content area. [17:20:24] jdlrobson: so I think I'll give that a spin today [17:20:32] see if can draw up some wikidata style tables [17:20:42] the mobile skins are special in that they behave slightly different from desktop (different markup, urls which usually need to be logged in are still rendered but with links to the login form) [17:20:49] awesome [17:21:02] and then I can worry about fetching entity data once aude is back [17:21:11] i'll be here all day so grab me if you have any questions - if there is anything difficult we can jump on a skype/hangout [17:21:41] i'd start with something simple - create a skin where you change something in the page - e.g. add a hello world paragraph at the top or change the title of the page [17:22:08] you'll probably want to replace the template attribute bodytext with something [17:22:44] that way you could create an entirely different interface for wikidata pages [17:23:08] pragunbhutani: do you have any sketches of what you want to make the wikidata mobile page look like? [17:23:53] nope, I plan to do that after I try out the skin [17:24:14] I'm going to draw tables with some dummy text to get a realistic idea of size and positioning [17:24:47] jdlrobson: do you suggest I do mock-ups first? [17:25:37] pragunbhutani: it would be useful to see what you want to achieve as we can predict any issues you might run into beforehand. I think as a first step just understanding how skins work and how you can change them would be a good achievement though so I'd do that first :) [17:26:31] yurik, "The banner is an ESI link to */w/api.php?action=zero&banner=250-99*" - when I tested stuff for ESI before, I discovered that an empty special page loads faster than an empty API module [17:26:43] jdlrobson: yeah that's what I thought. I'm anxious to get over the 'fear' of skinning [17:27:00] yeh but don't worry too much it's not as scary as it first seems :) [17:27:02] and what I'm doing today is definitely not going to be an iteration of my solution [17:27:09] pragunbhutani: sounds great :) [17:27:21] MaxSem, good to know... although i have no idea why it is :) [17:27:37] jdlrobson: awesome! I'll ping you if I get stuck somewhere [17:27:50] MaxSem, can special page output partial incomplete HTML? [17:27:57] yes [17:28:11] we had an example in the esisupport branch [17:28:22] dr0ptp4kt, ^ [17:28:22] ymmv of course [17:28:54] MaxSem, any other thoghts on that? btw, pls reply with your comment, might help others too [17:29:32] pragunbhutani: great :) [17:29:42] New review: Jdlrobson; "I think my brain just melted.. :)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68531 [17:30:02] Maryana: awjr https://gerrit.wikimedia.org/r/#/c/68598/ so we can do this?! :D [17:30:30] err, page creation? i thought this was just about editing [17:30:37] how is that going to work? [17:30:42] Maryana: same way [17:30:48] you just click the edit button [17:30:50] but we don't currently display redlinks [17:31:03] so how would a user get to a nonexistent page? [17:31:15] we actually already have page creation..https://en.m.wikipedia.org/w/index.php?title=Foobarzzzz [17:31:42] yeh navigating to it is the way you create a page [17:31:46] red links are still not shown [17:32:14] ok - i guess that makes sense w/talk pages going out especially [17:32:21] since you can't start a talk page w/o creating it [17:33:12] in terms of the button bar - i'd expect on things like templates to see a grayed out upload button that when clicked on says "This page doesn't currently need an image" or something like that [17:33:33] likewise if you can't edit a page we show a grayed button that when clicked says something like "you are banned from editing this page you naughty boy" [17:33:41] heheh [17:33:43] or girl! [17:33:54] yeh it would be gender translateeable of course ;-) [17:33:57] vandals can be girls. don't discriminate :-P [17:34:04] i vandalize wikipedia all the time! [17:34:05] err.. [17:34:07] i mean... [17:34:58] anyway i think that would be fun :D [17:35:36] anyway.. so let's enablez the editing on all namespaces ya? [17:35:46] let's do it [17:36:05] New review: Jdlrobson; "jdlrobson: anyway.. so let's enablez the editing on all namespaces ya?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68598 [17:39:29] jdlrobson: make it so [17:41:27] made [17:41:35] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68598 [17:45:28] ok, there we go: https://mingle.corp.wikimedia.org/projects/mobile/cards/856 [17:45:56] i'm gonna talk to megan to see which fundie things specifically need to be added to this list, too [17:46:55] fundies... this word usually has a different meaning:P http://www.fstdt.com/ [17:47:08] Maryana: some questions about editing [17:47:21] yeah, i just like to tease them, maxsem :) [17:47:48] if i click the edit button to load the editor and then refresh the page or share the link - what is the expected behavior? [17:47:52] *behaviour [17:48:31] share the link should probably not go to the edit view, but i doubt it's going to be a very common scenario [17:48:38] refresh the page - hmm. probably stay in the editor? [17:51:56] i can definitely see the latter happening. some person who's never edited a wiki before will open it, be like "what are all these curly brackets? is it broken?" and try to refresh [17:52:01] so currently both happen [17:52:08] (but the edit is lost) [17:52:16] eep [17:52:29] and the only way to escape is to close [17:52:32] we should warn the user that they're abandoning their changes, then [17:52:41] actually i lie.. [17:52:59] if you go to http://localhost.beta/w/index.php/Duel_Masters#editor-0 and click back you go to the page you were on before - so there is no way of seeing the article [17:53:06] isn't back behavior fun :D [17:53:17] double eep [17:53:22] (likewise with hitting cancel) [17:53:32] triple eep [17:53:40] you can still edit though and save [17:53:58] so to see the article you have to make an edit? heh. well, that's one way to make people contribute! [17:54:04] but it doesn't take you back to the article :D [17:54:09] aaahh [17:54:11] funny enough it takes you back to the editor [17:54:14] haha [17:54:18] with the message your edit was saved [17:54:35] ok, that's weird. let's not do that. [17:54:41] infinite edit loop! [17:55:29] can we just make shared &action=edit links take you to the article view by default? [17:55:42] also can we add edit summaries [17:55:47] i miss being able to add edit summaries on mobile :( [17:55:54] i like to explain what i'm doing [17:55:56] yeah, i told vibha to work those into her design [17:55:58] me too [17:56:06] is there a story in the works? [17:56:14] part of the improve editing story for next iteration [17:56:42] if we get 5000 mobile edits a day that are all just tagged "mobile edit", the community will hate us [17:57:24] i was gonna try to catch her today and ask how the design work is going for that [17:58:02] so Maryana what should we do about this back behaviour story [17:58:10] should we merge and try it out or rethink it [17:58:12] dr0ptp4kt, around? [17:58:30] yurik, yup. hola. [17:58:38] yurik, and, HOLLA! [17:58:49] holalalala [17:58:57] * Maryana looks at the story [17:59:06] dr0ptp4kt, did you see my email? [17:59:48] so the scenario of going straight to the edit window doesn't seem to be in the current story (https://mingle.corp.wikimedia.org/projects/mobile/cards/692) [18:00:04] it probably needs to be its own thing [18:00:07] jdlrobson ^ [18:00:22] yurik, the one to wikitech or the on that zero: config blob? read the latter, but *just* opened the former [18:00:35] wikitech [18:00:40] new story for next iteration? [18:00:55] dr0ptp4kt, i don't think config blob is a big deal really [18:01:11] yurik, agreed, just gotta remember when visiting meta [18:01:12] seems like its only there for the zero namespace [18:01:19] from a mobile phone [18:01:32] yurik, yeah, or with forged headers [18:01:49] yep. let me know what you think about architecture email [18:02:31] Maryana: not quite sure - i guess i'll talk to Juliusz when he gets in [18:03:40] i think we should merge what we've got and then do an intense test round with design [18:03:49] trying out all possible scenarios [18:03:56] back button party, if you will :) [18:05:12] it could be that it works 90% of the time, and 10% of the time it's weird… and maybe we can live with that [18:05:29] or it could be that it works 60% of the time and the other 40% is weird and needs another mental model or something [18:06:37] yeh i'm not sure what should happen in this situation [18:07:38] you unlock the easter egg of jimmy shooting lazers out of his eyes? [18:07:54] :D [18:08:02] Maryana: hahaha [18:08:29] yurik, it looks good! lthe only feedback is maybe those should be 302s instead of 301s, because the behavior is dependent on the carrier on which the user operates, so we wouldn't want "permanent" storage of a redirect in the UA; granted, the Vary: header should dictate the conditions under which the UA would retain the 301, but better to not leave that to change. i propose that on june 21 we should send a final call for suggestions, and then [18:08:30] close discussion on june 28. that measn that people will have had roughly three business weeks to provide feedback. meanwhile, if other higher priority items aren't blocking us, then work on this provisional plan seems wise to me, even if we end up having to rework some of it based on community feedback. make sense? [18:08:51] New review: Jdlrobson; "We should probably also use the following:" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67934 [18:09:15] Maryana: we do need to add some easter eggs.. [18:09:35] dr0ptp4kt, 302 & 301 - had no idea of the difference, just threw it in there for the point :) [18:09:48] i think we should just do jimmy lazers instead of error messages [18:09:51] (kidding) [18:09:53] (mostly) [18:10:09] mhurd: may has some icons for y'all! https://www.dropbox.com/sh/av689jgjqx9urip/_zItCBbkvt [18:10:21] yurik, i'll make a quick reply on that, unless you would prefer to do so [18:10:33] Maryana: any idea which bug about fonts jared and vibha have been participating in? [18:10:45] bug about fonts? [18:11:07] dr0ptp4kt, sure. also, did you see max's comment above re ESI? [18:11:16] (i pinged you on that) [18:12:03] it might be https://bugzilla.wikimedia.org/show_bug.cgi?id=46437 Maryana not sure [18:12:26] yurik, yeah, so Special: would be faster than an api call, huh? absent something in the actual code causing a drastic difference, i usually see slower connections when there's a Connection: close that seves the open tcp socket. [18:12:50] Maryana: awesome! [18:13:22] dr0ptp4kt, hmm, possibly. There is an ESI branch somewhere too, will have to look at it [18:13:33] jdlrobson, i know they've been wrestling with the community around the account creation/login page changes, but i don't know which specific bugs those are [18:13:33] yurik, sometimes pipelined requests and responses can go boom, too, depending on errors introduced by concurrency bugs on some platforms, although that's less likely to cause an issue if the webserver pipelines things in order. [18:13:41] agreed, interesting stuff! [18:13:49] ^yurik [18:25:29] jdlrobson, do you want to go through those back button commits together on Monday or you prefer to do a regular code review instead? [18:25:41] jgonera: i just commented on the patch [18:25:45] we have a situation :) [18:25:52] oh [18:26:11] seems there are other situations we didn't think about [18:26:26] annoyingly gerrit has messed up the rendering though :( [18:26:52] ooh Maryana good catch on updating the empty watch list you rockstar you [18:27:09] that's what i get paid the medium-sized bucks for [18:37:25] New review: JGonera; "I think we're just trying to make something look like it's something else right now. All the problem..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67934 [18:38:28] MaxSem: what specifically are you waiting on from partners to finish up https://mingle.corp.wikimedia.org/projects/mobile/cards/800 ? [18:38:35] updating empty watchlist? [18:38:46] anyway, jdlrobson, Maryana, I posted my reply at https://gerrit.wikimedia.org/r/#/c/67934/ [18:39:03] to adapt for https://gerrit.wikimedia.org/r/67546 [18:39:14] jgonera: this story: https://mingle.corp.wikimedia.org/projects/mobile/cards/867 [18:39:32] since we're changing where the watchlist star shows up, we need to change the instructional image for users with no watched pages [18:40:02] oh, right, good catch indeed [18:40:09] thanks MaxSem [18:42:37] jdlrobson: have you had a chance to test https://gerrit.wikimedia.org/r/#/c/67867/ on betalabs yet? [18:43:37] gahhh betalabs is busted again :( [18:43:57] New review: Maryana; "I think you're right, Juliusz, and Vibha's been talking about needing a rethink of this, too. I'll t..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67934 [18:44:13] MaxSem: is it easy to test an umerged change on betalabs, or do we need to merge to test? [18:44:39] the latter [18:44:39] k [18:44:53] it's automatically updated from master, no manual stuff is allowed [18:45:38] yurik, can you give https://gerrit.wikimedia.org/r/#/c/68304 the Yuri Treatment? [18:46:47] yurik, i believe MaxSem has some other stuff related to its cousin 67546 he's sitting on, and those two changes go together. [18:47:19] New patchset: Jdlrobson; "Make desktop Minerva mobile Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68720 [18:47:21] dr0ptp4kt, oh yeah, need to review that. I think i already added a minor comment there [18:48:51] yurik, yeah, see that comment on the TODO. agree, we'll need to be cautious when removing id fields on page elements. wanted to defer that change to a later date and keep this one pretty focused on the minerva hook for the various banner / warning stuff [18:48:58] New patchset: Jdlrobson; "Make desktop Minerva mobile Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68720 [18:50:19] New review: Jdlrobson; "I predict a riot" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67934 [18:51:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67934 [18:51:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68531 [19:03:29] New patchset: JGonera; "Make editor disappear after a successful save" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68721 [19:03:34] jdlrobson, ^ [19:20:59] New review: awjrichards; "This looks good to me - is there any zero-specific CSS that we should remove as well?" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/67546 [19:24:43] [Commons-iOS] montehurd opened pull request #90: Increased about, settings and attribution buttons hit areas. (master...iconTargetSize) http://git.io/LrM7Sg [19:26:08] New review: awjrichards; "There is a 'GetMobileNotice' hook in MobileFrontend (includes/skins/SkinMobileBase.php) that you may..." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [19:27:43] New patchset: JGonera; "Make editor disappear after a successful save" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68721 [19:29:44] New patchset: Jdlrobson; "Refactor template code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68724 [19:29:45] New patchset: Jdlrobson; "Separate page-actions from #content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68725 [19:29:45] New patchset: Jdlrobson; "Use bodyContent to be consistent with desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68726 [19:31:19] New review: MaxSem; "Not that I know." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67546 [19:34:07] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/68721 [19:45:13] alright mobilistas, im preparing to head out - lemme know now if you need anything from me! [19:45:21] i will likely be on for a bit later this aftenoon [19:47:32] jgonera, jdlrobson, MaxSem ^ [19:47:49] nope [19:48:35] cool - see you all later, have a great weekend :) [19:50:32] New patchset: Dr0ptp4kt; "Smaller banner close box - some whitespace around box tappable." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68553 [20:06:29] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68721 [20:13:45] yurik, ping, wanna make sure netsplits are gone [20:13:51] yurik, gonna get lunch soon, btw [20:20:56] dr0ptp4kt, yep, all good [20:21:02] checking the pixel issue [20:22:13] dr0ptp4kt, nope, the issue is still there with the close box - have the latest mobile ext [20:26:50] mhurd: hey! [20:26:55] any idea where is brion? [20:31:04] YuviPanda: hey! no he's working from home today [20:31:11] hmm, okay [20:33:37] hmm, sent him some review stuff [20:33:45] mhurd: does the released iOS app have categories? [20:37:46] YuviPanda: no the released one doesn't [20:37:50] hmm ok [21:02:39] New review: Yurik; "Doesn't work on my windows machine - the close box now appears above the banner text, centered. Late..." [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -1; - https://gerrit.wikimedia.org/r/68553 [21:12:25] okay, i'm off - drawing ideas for the app + related tools on paper :) [21:12:26] cya [21:26:27] YuviPanda: later! [21:29:29] hey mhurd [21:29:31] are we doing the backlog meeting now? [21:29:33] or should we just pick our cards and move them to sprint 11? [21:29:35] I'm hoping we could do the latter, since then I'll just sleep and work tomorrow ;) [21:30:04] New patchset: Jdlrobson; "Bug 49279: Style upload button correctly in Opera and Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68736 [21:30:09] YuviPanda: ya w/o brion i think that later is the way to go [21:30:18] mhurd: alright, sweet [21:30:34] mhurd: if brion turns up later tell him he has a couple of gerrit patchsets :) [21:30:38] i'm off again [21:30:39] thanks [21:30:43] will do [21:37:05] New patchset: Yurik; "Added default text of the zero config page" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68737 [21:37:35] dr0ptp4kt, did you set notification in gerrit to monitor zero extension repo? [21:37:58] i believe so, yes. why? [21:38:01] i'm too lazy to add you to each patch :)) [21:38:19] just curious - did you just receive an email about a new patch? [21:38:24] (trying to figure out how it works) [21:38:32] dr0ptp4kt, ^ [21:38:59] yeah, i got an email [21:39:23] cool, it works :) [21:39:35] New patchset: Jdlrobson; "Bug 49557: Fix talk topic add overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68739 [22:05:31] New patchset: Dr0ptp4kt; "Smaller banner close box - some whitespace around box tappable." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68553 [22:26:10] New review: Dr0ptp4kt; "I had an illegal // CSS comment that I added after testing. That'll teach me!" [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 1 - https://gerrit.wikimedia.org/r/68553 [23:13:02] New patchset: Yurik; "Show default and fallback values in zero config page" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68819 [23:24:10] New patchset: Yurik; "Added "enableHttps" flag support to zero configuration" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68824 [23:25:29] dr0ptp4kt, looking at your fix [23:25:36] dr0ptp4kt, if you have a sec, i have a number of patches [23:29:00] yurik, which ones are stable? [23:29:18] dr0ptp4kt, all of them :) [23:29:26] dr0ptp4kt, except the "move to special" [23:29:30] which i haven't touched yet [23:29:33] since my comment [23:30:20] yurik, ok. gotta step away from desk for a while. realized i hadn't moved around like i'm supposed to. brb. gotta balance time on review and the decoupling thing. should have time, i think. [23:30:50] dr0ptp4kt, sure. let me know if you have any q [23:57:00] New patchset: Yurik; "Smaller banner close box - some whitespace around box tappable." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68553