[00:27:13] wow, the commons-ios app got really nice looking while i wasn't paying attention [09:26:50] Rolken: heh, yeah. almost has 2 people and some designers on it now [11:31:22] [Commons-iOS] siebrand pushed 1 new commit to master: http://git.io/gztjjQ [11:31:22] Commons-iOS/master a1e3e0a Siebrand Mazeland: Localisation updates from http://translatewiki.net. [11:32:01] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/0uVgtA [11:32:01] WikipediaMobile/master 3212020 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [15:33:23] MaxSem: hey if mobile is down on beta labs and Antoine is out do I send something out on the wikimedia-tech channel? [15:33:52] * MaxSem looks [15:34:28] thanks [16:14:01] https://bugzilla.wikimedia.org/show_bug.cgi?id=49700 [16:14:03] meh [16:45:10] MaxSem, ping [16:45:16] pong [16:45:18] have you seen my patch for paging? [16:45:24] any thoughts? [16:45:33] yep, will review shortly [16:53:34] brion_: [16:53:36] brion: [16:53:40] hmm, only two nicks? [16:53:42] tch tch [16:53:56] heyyy [16:54:14] brion_: there are a couple of gerrit patchsets for you :) [16:54:27] \o/ yay [16:54:30] brion_: also the GitHub bot has more functionality now - merging it on Gerrit should close it on GitHub, also comments on Gerrit will get synced to GitHub [16:54:41] brion_: I did self merge some of the smaller ones tho [16:54:59] nice [16:55:18] brion_: also I've a cat now :) [16:55:29] kitttyyyyyy [16:56:06] need to train it to not walk on the keyboard [16:56:31] if(mMedia.getWidth() != -0 [16:56:33] -0? [16:56:54] eh it's harmless i suppose :D [16:56:59] brion_: meh, let me fix [16:57:07] brion_: it was -1, then i figured wtf, changed it to 0 [16:57:12] ha [16:59:14] brion: pushed, should sync in a moment. [16:59:51] brion: yeah, sync [16:59:52] d [17:06:53] java: javacTask: source release 1.6 requires target release 1.6 [17:06:54] wtf? [17:08:54] sighhhh [17:10:48] java: package android.app does not exist [17:10:50] awesome [17:10:57] android studio is not my friend today [17:11:03] brion_: heh why? [17:11:08] no fucking clue [17:11:09] brion_: also weren't you using IntelliJ? [17:11:19] not since android studio came about [17:11:22] oh [17:11:23] hmm [17:11:46] I'm staying put on IntelliJ until Gradle supports apklib or people start putting up aar versions of their libarries [17:11:54] brion_: also standup in 4 mins [17:12:13] well it worked fine friday [17:12:17] heh [17:13:18] ok fuckit i'll try on the mac again [17:13:23] heh [17:15:30] * jgonera is running to the office now [17:15:56] sweet - let's take a look at the back behavior during the QA review today, jgonera [17:20:53] awjr_away: so i think the issue is that MobileFrontend (beta) bugs don't go into mingle e.g. https://bugzilla.wikimedia.org/show_bug.cgi?id=49647 [17:20:54] jdlrobson: re bingle, i can run it 'manually' and have it backfill missing bugs [17:20:57] ^ awjr [17:21:12] is that intentional? [17:21:19] lemme double check the feed it's using [17:22:06] correct jdlrobson, it's just using 'MobileFrontend' [17:22:20] brion: there's also https://gerrit.wikimedia.org/r/#/c/69118/ but is smaller [17:22:54] jdlrobson: i can add the beta component to the feed [17:23:07] jdlrobson: why do we have two separate components in bugzilla though? i think that's just confusing [17:24:06] awjr: it's because beta features don't always go to stable [17:24:15] it keeps the important must fix right away bugs from the less important ones [17:24:32] we don't have an 'alpha' component either [17:24:46] awjr: yeh so alpha bugs are also beta bugs - this list predates alpha [17:24:56] and we do prioritization internally - it's entirely possible that a bug in beta is more important to fix than a bug in stable [17:25:12] i think it would be worthwhile to just have one bugzilla component [17:25:18] rather than two [17:25:20] sure - we should talk about it during the retrospective [17:25:32] to this point it has been useful but now the bug lists are getting smaller maybe it's unnecessary [17:25:43] good idea :) [17:25:51] (we could instead prefix bugs with [beta] or [alpha] now to tell them apart) [17:26:23] there are other ways of setting them in BZ, IIRC? [17:26:39] Keyword? [17:26:51] even we have been reporting beta bugs in the main component though [17:27:32] "even we" ? [17:27:50] keywords in bugzilla are shitty [17:27:56] keywords are lame in bugzilla [17:28:05] anyway not a conversation for now :) [17:28:16] i think prefixing the title or just mentioning in the description would be satisfactory [17:32:06] thanks MaxSem [17:32:06] Maryana: http://www.mediawiki.org/w/index.php?title=Extension_talk:MobileFrontend&offset=20130617125318&lqt_mustshow=29130&useformat=desktop#Uploads_related_message_texts_29130 [17:32:32] Maryana: can we meet tomorrow morning? I need to play catchup because of betalabs being down [17:33:16] YuviPanda: thinking about multiple image selection stuff. there's no way to request multiple selection initiated from our end is there? :( [17:33:21] jcmish - sure thing. [17:33:23] brion: nope [17:33:25] i was hoping to play around w/the back behavior stuff today w/juliusz. is that in staging? [17:33:29] brion: unless we want to implement our own gallery [17:33:31] unless we do something like read from the content provider ourselves and provide our own UI…. [17:33:34] which... I don't want to do [17:33:36] brion: yeah [17:33:36] jcmish ^ [17:33:40] brion: but we can do 'add another image' [17:33:42] but that is one by one [17:33:46] yeah we're basically having to do that on iOS for multiple selection [17:33:54] luckily there's only one photo library to deal with on ios [17:34:30] jdlrobson, meh, these are tricky concepts. i'll respond [17:34:40] technically CC licenses are copyleft :) [17:35:13] brion: yeah [17:35:16] brion: heh. [17:36:22] Maryana: you can use betalabs it "should" be there [17:36:26] i looked at the commits [17:36:51] ok - worse comes to worse, we can just look at it on juliusz's local instance [17:37:01] k [17:37:12] let me get started testing see if anything is missing [17:37:29] cool, thx [17:37:49] brion: we could do 'add another image' type stuff [17:38:08] brion: but I think educating people about how to do it 'right' is a better idea [17:38:30] well the 'right' way is a multi-select intent to supplement the single-select intent [17:38:35] but it don't exist [17:38:42] brion: yeah [17:38:43] * brion glares at Android [17:39:49] brion: maybe with 2.3 [17:39:50] err [17:39:51] 4.3 [17:40:08] they didn't announce anything about 4.3 at google io. how crazy is that [17:40:13] just new google play services :P [17:40:15] MaxSem: event logging was enabled on betalabs, right? [17:40:47] brion: heh [17:40:56] brion: yeah, but I'm unsure about if we can actually depend on just play services stuff [17:41:00] them being not OSS, et [17:41:00] c [17:42:03] im getting the following JS error on en.m.wikipedia.beta.wmflabs.org: https://gist.github.com/awjrichards/6761b6b4bde243b750bf [17:42:12] yeah we could probably optionally use the maps but we'd need a fallback for non-googly devices [17:42:18] * brion glares at Amazon [17:43:42] MaxSem, jcmish, jdlrobson ^^ [17:43:47] brion: yeah [17:43:49] brion: also fdroid [17:43:52] yup [17:43:54] and replicant [17:44:08] awjr: event logging does not seem to be installed - flagged this to maryana last week [17:44:30] yeah, but i thought we installed it a few weeks back - MaxSem do you know about this? [17:44:43] yes it is [17:45:32] so is eventlogging broken, config messed up, or something broken on our end [17:45:32] but just the logging part, not the API [17:45:33] ? [17:45:45] anyone have anything to raise in next TechOps staff meeting? [17:45:57] MaxSem: then it's not fully installed :) [17:46:19] jdlrobson: they are going to want to know more about when we're planning our deployment that will require cache flush [17:46:28] https://rt.wikimedia.org/Ticket/Display.html?id=5267 [17:46:28] sure - do we still need one? [17:46:47] we will still need it when we deploy the features that will require it [17:46:48] awjr: we discussed in last planning meeting that we are going to spend next iteration polishing rather than deploying [17:47:01] yup but if i understand correctly we are looking at maybe 4 weeks time now? [17:47:14] jdlrobson: yeah i know, im just saying you'll need to update ops :) [17:47:22] (half way through iteration after the one kicking off today) [17:47:28] cool just checking i understand correctly [17:47:30] i told folks via email and the rt, but let them know in the mtg [17:48:17] MaxSem: is it trivial to get the rest of EventLogging working on betalabs? [17:48:33] hmm [17:48:34] the mobile experience is broken on betalabs at the moment, which means we cant test there [17:48:42] 'can't downgrade database from version 6 to 5' guess i need to rebase [17:48:48] not trivial [17:49:45] hmm [17:50:08] ok, then let's disable event logging for mobile frontend on betalabs so we can actually use it [17:51:55] what does it break? [17:53:47] MaxSem: JS [17:54:04] YuviPanda: the pull reqs still don't seem to close on their own [17:54:09] brion: yes, bug [17:54:10] need to fix [17:54:11] that [17:54:11] though they grab the 'change merged' etc messages [17:54:12] ah ok [17:54:14] yeah [17:54:18] i'll close em out manually of rnow [17:54:19] jdlrobson: mobilefrontend beta bugs are now getting populated in mingle [17:54:27] awjr: \o/ [17:54:44] brion: i could test abandon / restore, but not merge, since I didn't have an experimental changeset that was mergeable [17:54:53] heh [17:55:20] man, no Moogsi [17:55:43] ragesoss: around? [17:55:55] ohai [17:56:28] ragesoss: ohai [17:56:28] YuviPanda: what's up? [17:56:32] ragesoss: i'm adding license selection :) [17:56:35] to options [17:56:47] oh, cool. [17:57:04] ragesoss: is it important to have them sync to preferences? [17:57:08] or should they be phonelocal? [17:57:16] I think phonelocal is fine. [17:57:27] it's for powerusers only, anyway. [17:57:35] ragesoss: and i'm going to have only BY SA, BY, and CC0 [17:57:45] yes, good. [17:57:59] alright [17:58:06] well, as in - only own work as well [17:58:11] so that's fine I guess [17:58:28] ragesoss: and if I default it to CC BY I'll have people scream at me, I think [17:58:29] accurate? [17:58:44] Fatal error: Call to a member function saveXML() on a non-object in /usr/local/apache/common-local/php-1.22wmf6/extensions/MobileFrontend/includes/HtmlFormatter.php on line 290 [17:58:47] Did that one get fixed? [17:59:08] YuviPanda: yep [17:59:24] ragesoss: okay, will leave BY SA as default then [18:01:03] actually, it looks like moilbefrontend event logging is disabled already on betalabs… [18:02:16] jdlrobson: http://en.m.wikipedia.beta.wmflabs.org/wiki/0.4171307280313894_Moved?debug=true [18:02:16] Yup, https://bugzilla.wikimedia.org/show_bug.cgi?id=49534 [18:02:19] do you get a JS error on that page, jdlrobson? [18:03:08] awjr: yup - on all pages. it tells me event logging is not installed [18:03:25] jdlrobson: yeah, $wgMFLogEvents == false on betalabs [18:03:44] so why are we getting js errors? [18:05:12] maybe ext.navigationTiming ? [18:05:16] that seems to be installed [18:05:46] some module on labs is stating ext.eventLogging is a dependency [18:05:52] *as a dependency [18:05:59] huh [18:06:09] NavigationTiming i think has dependency on EventLogging [18:06:43] yeh but it seems to be installed for some reason [18:06:44] mw.loader.load(["mediawiki.hidpi","mobile.startup","mobile.stable","ext.navigationTiming"],null,true); [18:06:50] hmm [18:06:55] that's the only one i can think that might do that [18:09:33] [Commons-iOS] brion pushed 7 new commits to master: http://git.io/19LSsQ [18:09:33] Commons-iOS/master 834664d Monte Hurd: Refactored aspect fill pic of day thumb retrieval code... [18:09:33] Commons-iOS/master 2e52294 Monte Hurd: Updated bundled cache files so they work w/changes from last commit... [18:09:33] Commons-iOS/master e21efe8 Monte Hurd: Shows pic of day in reverse chron order. Other transition fixes.... [18:10:53] jdlrobson: im explicitly disabling eventlogging and navigationtiming in betalabs, hopefully that should solve the problem [18:12:12] MaxSem: https://gerrit.wikimedia.org/r/#/c/69130/ [18:14:41] New patchset: JGonera; "Clean up uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69131 [18:14:45] New patchset: JGonera; "Rewrite parts of the uplaods dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69132 [18:15:37] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/-Z66-g [18:15:37] Commons-iOS/master 525a4b6 Monte Hurd: Increased about, settings and attribution buttons hit areas. [18:15:37] Commons-iOS/master 90bc48a Brion Vibber: Merge remote-tracking branch 'monte/iconTargetSize'... [18:16:17] New patchset: JGonera; "Rewrite parts of the uplaods dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69132 [18:22:47] awjr, I've merged your change, should go live shortly [18:22:51] jcmish, ^^ [18:22:54] w00t thanks MaxSem [18:23:04] hopefully that will fix the problem and betalabs will work again [18:23:31] sweet [18:23:38] MaxSem: you're the best [18:23:51] looks like it went live, seems to work now jcmish, MaxSem :) [18:24:00] yup :D [18:27:06] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68943 [18:32:08] STOP. Falafel time. [18:32:22] jcmish, Maryana is the acceptance review happening? [18:32:36] yup google is fighting me [18:32:38] but I'm coming! [18:35:04] we're doing a modified version of it, awjr, since betalabs is freaking out [18:35:09] i'm just meeting w/jgonera & vibha to talk about back behavior [18:35:19] wait; i think we fixed betalabs :) [18:36:26] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68850 [18:41:02] arggg jgonera we're gonna have a huge edit conflict on our hands :-S [18:41:18] jdlrobson, in a meeting now [18:41:24] np we can talk in a bit [18:44:25] New review: Dr0ptp4kt; "Arthur, I see the later patchset, just wanted to submit this because I'm not sure whether my replies..." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [18:55:04] New patchset: Jdlrobson; "Remove scrollTo call" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69140 [18:55:07] New patchset: Jdlrobson; "Big photo reorganisation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69141 [19:01:42] brion: redesign for github repo pages :) https://github.com/blog/1529-repository-next [19:02:37] fancy [19:02:42] New patchset: Jdlrobson; "Big photo reorganisation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69141 [19:02:45] New patchset: Jdlrobson; "Only add Uploads page in mobile mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69142 [19:03:14] * brion is still pissed at google for shutting down reader in a week or two [19:03:25] i need an alternate server-side sync provider for reader :( [19:04:03] New patchset: Dr0ptp4kt; "Further decouple banners from MobileFrontend. Dependent on change 67546." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [19:05:52] New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69141 [19:07:46] brion, freedly seems nice [19:07:56] ijust switched to them [19:08:20] *feedly [19:12:19] yurik: i'm confused, do they have a web interface or only firefox/chrome plugins? [19:13:21] brion, the plugin is talking to the webinterface [19:13:27] or something like that :) [19:13:32] http://feedly.uservoice.com/forums/192636-suggestions/suggestions/3744181-make-feedly-available-as-full-web-service-no-plug [19:13:43] they seem to have a suggestion to support regular web browsers [19:13:51] but don't do it presently, requiring add-ons to browsers [19:13:55] that's a big no-no for me then [19:27:32] ragesoss: also [19:27:35] ragesoss: in the options [19:27:48] ragesoss: would it be enough to just say 'CC BY-SA', 'CC BY', CC0? [19:27:53] we should have some explanatory text, right? [19:28:25] YuviPanda: on iOS i have a selector (with currently only one option) on the detail page when uploading new image [19:28:31] dr0ptp4kt, hey, have you had any change to review my weekend changes? [19:28:33] brion: screenshot? [19:28:43] it's got a info disclosure button on the item which opens the CC license page in a browser [19:28:44] moment [19:28:59] brion: we're gonna have only those three, and only the own-work types [19:31:32] YuviPanda: screens on this card: https://trello.com/card/android-add-license-selctor/51b8360dc86b2c4b49011ddc/32 [19:31:41] yurik, which ones? [19:32:44] brion: sweet [19:35:21] jdlrobson, is there anything holding up moving centralnotice code from beta to stable? [19:35:29] (mtg w/FR folks now) [19:36:54] dr0ptp4kt, sorry, in the middle of a demo to our two new GSoC students in NYC, could you search gerrit pls :) [19:38:01] yurik, if you're talking about the two editor things, i reviewed and +2'd them earlier [19:41:01] New patchset: Dr0ptp4kt; "Further decouple banners from MobileFrontend. Dependent on change 67546." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [19:45:34] java: /Users/brion/src/wiki/android-commons/commons/src/main/java/org/wikimedia/commons/CommonsApplication.java:18: package com.android.volley does not exist [19:47:04] aaarrrrrrrrrrrrrr [19:48:20] Maryana: well.. did we ever run a test campaign? [19:48:33] Maryana: nothing that i know of apart from more adequate testing [19:48:55] YuviPanda: got to say thanks boss when i got my lunch today [19:49:05] brion: try doing a 'mvn compile' from the commandline [19:49:06] might fix that [19:49:13] jdlrobson: :D Were you called a friend? [19:49:56] YuviPanda: nope, still fails in the ide [19:49:59] no but i got the indian smile [19:50:05] brion: mvn clean and then a compile? [19:50:13] i'll just kill it and import the project fresh [19:50:16] brion: and close and re-open idea maybe? :D [19:50:21] jdlrobson: ah, nice :) [19:50:27] dr0ptp4kt, awesome, thx! :) pls take a look at the script api.php -- i'm thinking of incorporating YuviPanda's and other people's changes there to make one simple framework to rule them all ;) [19:50:40] on the paneer YuviPanda [19:50:50] yurik: well, http://xkcd.com/927/ :P [19:51:00] YuviPanda: closed and reopened a couple of times already yes [19:51:05] brion: :( [19:51:14] jdlrobson: nice :) [19:51:25] YuviPanda, trust me, i will soon remember that xkcd by heart, at least i don't even need to click it to know what it is ;) [19:51:27] jdlrobson: I had McDonalds for lunch and dinner, so... [19:51:35] yurik: :D [19:51:37] ok now i think it builds…. but i have no run configuration. nice. [19:51:45] o_O spicy paneer wrap?! [19:51:50] hopefully i can add that sanely [19:51:54] jdlrobson: no, burger + fries + coke [19:52:04] brion: \o/ [19:53:02] jdlrobson: we are swapping cuisines, I think :) [19:54:18] aha, it's just a really shitty UI in intellij/android studio [19:54:31] you can select all the options you want, but you have to find the hidden "+" button to make something that works [19:57:22] brion: heh [20:00:19] aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaah [20:00:19] MaxSem: any reason why we can't do this? https://gerrit.wikimedia.org/r/#/c/68720/ [20:00:26] java: /Users/brion/src/wiki/apps-android-commons/commons/src/main/java/org/wikimedia/commons/CommonsApplication.java:18: package com.android.volley does not exist [20:00:33] again [20:00:39] jdlrobson: do you know what happened to all the bugs that bingle pulled in from mobile frontend (beta)? almost all appear to have disappeared [20:00:47] New patchset: Jdlrobson; "Zeljko review not merging" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473 [20:01:31] jdlrobson, why? we need to kill the HTML transformations instead of introducing them in more places [20:01:36] New review: Jdlrobson; "The commit message isn't too clear - could you clarify it?" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/64473 [20:01:43] or Maryana ^^? [20:01:48] ok now it's just making up random errors. [20:01:50] android-apt-compiler: [commons] /Users/brion/src/wiki/apps-android-commons/commons/res/values/styles.xml:3: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.Sherlock'. [20:02:07] MaxSem: agreed - but this makes the desktop version of the skin the same as mobile in the meantime [20:02:20] pretty please don't [20:02:46] awjr: i pushed them to next iteration / got rid of dupes [20:03:02] desktop screens and input methods don't have the limitations of mobile devices [20:03:14] jdlrobson: ok - did you go over them with Maryana? [20:03:16] we don't need to casttrate anythingh for them [20:03:52] awjr we've talked about them in the past but can't remember exactly what we agreed apart from we'd clean up all editing related bugs in next iteration [20:03:53] ok let's clone fresh [20:04:00] MaxSem: ? [20:04:17] MaxSem: we still should converge to the same section headings though no? [20:04:22] same html markup [20:04:39] I see this as an interim solution until the template handles the rendering of content [20:04:44] why? desktop doesn't have these problems with scrolling [20:05:07] MaxSem: the html markup should be the same [20:05:12] why? [20:05:20] MaxSem: so things like photo uploader can work [20:05:28] We rely on HTML markup in all our javscript [20:05:47] how is photo uploader related to sections? [20:05:52] we look in the lead section [20:06:03] a lot of our code needs to identify the lead section [20:06:06] New review: MaxSem; "Please don't - we should be deprecating HTML transformations, not vice versa." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/68720 [20:06:12] the default html markup doesn't allow us to do this [20:06:31] so they should be the same [20:06:37] the thing is - mobile uploads are for _mobile_ [20:06:45] jdlrobson: https://mingle.corp.wikimedia.org/projects/mobile/cards/873 somehow got orphaned - what did you mean to do with it? [20:07:01] on desktop you have UploadWizard which is billion times more functional [20:07:23] MaxSem: it's different [20:07:53] And a trillion times more buggy [20:07:55] MaxSem: this is totally the wrong attitude - we should be aspiring to make mobile run and useful on a desktop browser [20:08:03] (pinged on "UploadWizard" [20:08:10] the lead photo uploader is useful in a desktop context [20:08:15] it has nothing to do with UploadWizard [20:08:49] also if we want Minerva to be a skin it needs to work the same as mobile [20:09:04] so one way or the other we need to get the section markup on the desktop version [20:10:50] New review: Jdlrobson; "As discussed on IRC we however need section markup. Currently the section HTML markup is closely cou..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68720 [20:11:43] New patchset: Jdlrobson; "Make desktop Minerva mobile Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68720 [20:11:57] MaxSem: not having sections on the desktop version is seriously hindering any work on the skin [20:12:09] and since we don't enable the skin I don't see why this is a big deal [20:15:14] jdlrobson: should https://mingle.corp.wikimedia.org/projects/mobile/cards/873 just be in the backlog? [20:15:20] * jdlrobson looks [20:15:30] awjr: yeh not even worth considering at current time [20:15:57] jdlrobson: ok, next time please put it in the bug backlog, otherwise it will get lost [20:16:05] what did i do wrong? [20:16:15] where is the bug backlog [20:16:18] i don't see it under iteration [20:16:56] sometimes when you go to choose iteration, it applies a filter that only shows iterations associated with the current release [20:17:08] yeh i didn't see any bug backlog [20:17:08] so if you clear the filter, you should see 'bug backlog' [20:17:19] it's there, just gotta update the filters to make it show up :) [20:18:52] yeyyyy mingle and it's incredible ui! [20:36:50] ok the office is crazy loud today and i forgot my headphones, i'm gonna work the rest of the day from the home office before i go mad [20:41:02] is gerrit being wonky for anyone else? [20:42:33] jgonera: when you have the chance, can you help review https://gerrit.wikimedia.org/r/#/c/67508/ and https://gerrit.wikimedia.org/r/#/c/67867/? it would be swell if we can get those out for tomorrow's deployment [20:42:34] isn't it always? [20:42:48] touche, YuviPanda [20:43:00] ty "_ [20:43:04] awjr, ok, I was about to review something with jdlrobson but he got kidnapped by someone [20:43:06] the wifi in my hotel is crap so im having a hard time distinguishing if problems are on my end or elsewhere :p [20:43:07] awjr: but the android app is also on Gerrit now, so... [20:43:13] possibly VIbha [20:43:13] ha jgonera, good luck :p [20:54:11] MaxSem: is getting https://gerrit.wikimedia.org/r/#/c/68304/5 merged the only thing that you need before finishing up https://mingle.corp.wikimedia.org/projects/mobile/cards/800 ? [20:54:22] New review: awjrichards; "LGTM!" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 1; - https://gerrit.wikimedia.org/r/68304 [20:55:12] no, but it's needed for me to continue down this road [20:56:43] New review: MaxSem; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [20:57:25] cool - what else is needed MaxSem? [20:57:25] dr0ptp4kt, yurik https://gerrit.wikimedia.org/r/68304 looks OK to me (though i didn't test); it would be great to get merged soon so we can unblock MaxSem [20:57:45] yurik, did you wanted someone else's opinion on https://gerrit.wikimedia.org/r/#/c/68869/ besides me? I can merge otherwise [20:57:46] :) [20:58:28] MaxSem, we won't know untill our partners test it, and they won't test it on test wiki - might as well put it out in production :) [20:58:38] awjr, thx. yurik, you wanna take a last look at 68304? [20:58:46] in case it prooves to be useless, fairly easy to delete it later :) [20:58:53] awjr: i need to run back to the dealership they lost the key for my tires [20:59:00] awjr, looking again ... [20:59:00] and need me to bring my extra [20:59:07] jcmish: can it wait til after the kickoff? [20:59:16] I'm talking to them now to see [20:59:27] but may not be able to they're not open late on mondays [20:59:49] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68869 [21:00:18] meh:) I have just a little comment [21:01:45] dr0ptp4kt, so is the api. labs instance working now? [21:02:43] jgonera: kickoff! [21:03:33] awjr, dr0ptp4kt - do you know if that patch fixed the issue of not showing banner under some weird conditions that we experienced last time on api server? (or was it production?) [21:04:04] MaxSem, comment re what? [21:04:14] ^^^ [21:05:39] yurik, not sure about apibeta. haven't jumped on there today. yurik, awjr, not sure about banner display. but for this testing, you'll want to checkout the dependent change from MaxSem in order to see it working. otherwise you may run into strange results. [21:08:18] yurik, the banner non-display and double display had to do with display:none and double inclusion of HTML. it should work now, although you'll want to double check the common scenarios. i did the same, but your independent test would be best. [21:10:48] New review: Yurik; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68869 [21:11:17] MaxSem, answered, does it answer your question+ [21:11:35] I'll take a look after a mtg, thanks [21:32:10] YuviPanda: we fail on gingerbread now [21:32:21] NoSuchMethodError: android.graphics.Bitmap.getByteCount [21:32:21] brion: since when? [21:32:25] ah [21:32:26] hmm [21:32:37] that's our L1 in memory cache [21:32:47] used in LRU cache yeah [21:32:56] brion: file a bug / put it on trello? [21:33:10] should be a shortish fix, I'll fix it once I get the License stuff in [21:33:24] k [21:35:03] https://bugzilla.wikimedia.org/show_bug.cgi?id=49716 [21:35:16] brion: sweet [21:35:40] aaand added a card on sprint 11 ready for dev [21:35:53] sweetagain [21:35:53] :) [21:36:15] brion: merged a short patch now that should make rotation performance better, methinks [21:37:30] ooh [21:37:52] on some cases only, that is [21:37:57] (when size is small) [21:38:05] ah [21:38:35] brion: thanks for all the screenshots! [21:38:42] happy to oblige :D [21:43:36] New patchset: Dr0ptp4kt; "Display clickthrough URL in case user accidentally accessed Zero." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69248 [21:46:19] New patchset: Dr0ptp4kt; "Display clickthrough URL in case user accidentally accessed Zero." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69248 [21:50:38] dr0ptp4kt, MaxSem awjr -- my perspective on that patch - i don't know enough about mobilefrontend - zero interaction, but seems good. It has to go live in sync with mobile, so you guys deploy it tomorrow, and if something breaks we fix it the day later. Please get it up on some server in the mean time to test it out again [21:50:46] New patchset: Jdlrobson; "New assets for first time user upload tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69250 [21:50:50] New patchset: Jdlrobson; "Uploads page: remove out the progress indicator" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69251 [21:50:54] New patchset: Jdlrobson; "Center left and right arrows on uploads first time user tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69252 [21:51:09] or we could try to get api.labs server up (i think re-puppetizing has messed it up a bit) [21:51:36] YuviPanda|brb: how long does it take for that script to pick up a pull req? [21:52:18] oh there it is, nevermind [21:52:19] :D [21:56:39] MaxSem, please go ahead and merge https://gerrit.wikimedia.org/r/#/c/68869/ [21:56:50] unless there is a bug of course :) [21:57:32] yurik, so when maxlen is < 0? [22:01:15] MaxSem, maxlen=-1 at 132 [22:01:59] mhm, but the check for it is above:) [22:01:59] maxlen is basically how much is LEFT to output [22:02:10] MaxSem, its a member var ;) [22:02:37] it will keep decreasing every time something is output [22:02:53] meh [22:03:07] this module is giving me the creep [22:03:17] try this: do some api call that outputs text in multiple sections, and then add offset=1 & maxlen=100 [22:03:23] and then keep increasing offset, etc [22:03:24] no surprise I wrote it [22:03:35] you will see how it works [22:03:47] its like a sliding viewing window on top of all the text screens [22:03:53] i meant - text sections [22:04:10] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68869 [22:04:24] yurik, my concern is that they need to know somehow if they need to request more [22:04:57] they do - there is an eleement at the top [22:05:05] continue something [22:05:10] with the new offset [22:05:20] MaxSem, ^ [22:05:56] yurik, 68304 (zrma) and 67546 (mf) on apibeta. you can give those a whirl there. [22:06:07] bah, what did I look at [22:07:19] MaxSem, you looked at the limiting patch, right? :) [22:07:35] i am hoping to have it go live today so that we can tell our partners to start testing [22:07:41] dr0ptp4kt, thx, will do [22:07:45] also merged some stuff, not sure which;) [22:08:29] * yurik starts throwing things at MaxSem [22:09:00] fun all around me btw, about to listen in on dotdotgo [22:09:08] presentation in NYC [22:09:11] brion: a couple of secs [22:09:32] brion: most time consuming part is the 'git review' call :) [22:09:40] brion: should be there less than 10-15s tho [22:09:45] whee [22:12:10] brion: commented [22:12:42] YuviPanda: gotcha [22:12:46] update coming :D [22:12:48] :) [22:13:36] brion: left another comment :) [22:15:04] ok [22:21:45] YuviPanda: ok i pushed a second commit to the branch the pull req was made from. let's see what happens :D [22:21:57] "new patch set" \o/ [22:22:30] brion: :) [22:22:42] brion: That is how it is supposed to work, right? [22:22:48] brion: in mapping the GitHub model to the Gerrit model? [22:22:49] looks like [22:23:56] brion: one more tiny fix :) [22:23:58] comment left [22:25:43] YuviPanda: 'make this module level' … not sure i understand? [22:26:01] brion: 'app' shouldn't be a local variable [22:26:10] member variable is the Java parlance, I think? [22:26:19] move it up one level, and set it up in onCreate or similar [22:26:32] onActivityCreated if it is a Fragment [22:26:33] brion: ^ [22:26:34] well, why save it? [22:26:43] that's just and extra few bytes of memory used for nothing surely [22:26:45] well, why not? it is probably going to be used elsewhere. [22:27:02] hmm, we could move it when it is next used [22:27:24] in this particular case it is ok [22:27:30] since that is going to be called only once per activity [22:27:39] but if we keep getting in the habit, then some times it might be called multiple times [22:27:39] so [22:27:40] don't store anything as a member variable you can recalculate on a non-critical path [22:28:06] MY PRECIOUS BYTES [22:28:19] brion: going 'MY PRECIOUS BYTES' after going to Java... :P [22:28:24] lol [22:28:29] could be worse could be php [22:28:30] brion: merging anyway, but it is just a pointer, so shouldn't be that bad [22:28:51] I bet the call is more expensive in terms of time (casting, method dispatch) than the memory saved [22:29:22] ooh, now we're into battery vs ram [22:29:39] brion: merged [22:29:46] \o/ thx [22:29:47] brion: indeed, and battery wins :P [22:30:00] same thing, for example, with caching bitmaps [22:30:01] freakin' java [22:30:02] okay, *not* the same thing [22:30:06] since it is a lot more expensive [22:30:07] but still [22:30:32] * brion tosses around a 2560x1600 screen [22:30:46] that'll be an expensive bitmap [22:32:40] hehe [22:32:41] yeah [22:32:46] bitmaps be expensive [22:33:21] i got 99 cached problems and a bitmap's one [22:34:17] well if it is cached the bitmap ain't really a problem... :P [22:34:25] brion: have you compared the volley image performance with previous ones? [22:34:28] anectodinally, at least? [22:34:37] if not, can you? you have enough devices of similar size, I suppose :D [22:34:46] load market release in one, master in another... [22:35:15] seems decent enough, i haven't done any detail comparisons [22:36:16] hmm, okay. do a cursory superficial one when you can [22:36:34] ok [22:38:57] hmm [22:39:19] YuviPanda: detail page image looks very pixelated on kindle fire in portrait mode [22:39:30] i think it's our locking to 320px multiples [22:39:38] screen is 1024x600 [22:39:52] so it's probably pulling a 320-wide image instead of 600-wide [22:40:01] brion: ah, dammit [22:40:04] stupid kindle fire [22:40:05] maybe best to round up, grab 640px [22:40:15] probably same problem on the nexus 1, also 600dp wide [22:40:17] *nexus 7 [22:40:41] mmm [22:40:42] it's charging at the office so can't test it just now [22:40:42] yes [22:40:45] i'll add a bug [22:40:48] yes! [22:51:42] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69140 [22:56:28] New patchset: JGonera; "Big photo reorganisation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69141 [22:57:24] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69141 [23:01:26] New patchset: Jdlrobson; "Only add Uploads page in mobile mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69142 [23:02:06] argh this hotel wifi is killing me [23:04:05] New patchset: Jdlrobson; "New assets for first time user upload tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69250 [23:04:24] gerrit is killing me with its slowness awjr :( [23:04:47] oh so it's not just me then;i thought the gerrit issues were a byproduct of this busted wifi [23:04:55] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69142 [23:05:28] New patchset: Jdlrobson; "Uploads page: remove out the progress indicator" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69251 [23:06:01] no it's terrible today [23:06:20] sigh [23:06:28] jdlrobson: is there a copy of team geek floating around in the office? [23:06:49] ummm i've got my copy in my bag [23:06:53] ohh wait no i dont [23:06:57] it's at home.. sorryy [23:07:04] no worries [23:07:44] i thought there might be one floating around; if one turns up in the next 30 minutes or so, can you give it to alolita to give to me? im going to be seeing her for a mtg at 5 [23:08:21] jdlrobson & awjr: so I wanted SkinMobile and SkinMobileWML to have a base class again - thoughts? [23:09:27] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69250 [23:09:48] MaxSem: wait, im confused - dont they already have a base class? [23:09:49] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69251 [23:09:59] not anymore:P [23:10:14] well, not including SkinTemplate [23:10:37] * awjr updates code [23:10:44] SkinMobileWML does not inherit from SkinMobileBase anymore [23:10:58] MaxSem: no.... [23:11:00] don't do it [23:11:03] keep them separate [23:11:09] throw SkinMobileWML into a separate extension [23:11:13] will reply later [23:11:15] but then there will be copypasta [23:11:22] no [23:11:41] we must support WML whether we like it or not [23:12:09] MaxSem: what's your case for mobile/wml sharing a base class? [23:12:42] banner and HTML transformations [23:13:17] doing templatey stuff in base class was indeed prone to breakages as nobody looks at WML [23:13:18] New patchset: Dr0ptp4kt; "Display clickthrough URL in case user accidentally accessed Zero." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69248 [23:14:15] what else is there besides the templatey stuff (sorry not really familiar with wml) [23:15:04] and i guess more specifically, what would regular mobile/wml share? [23:16:00] banner, HTML transformations and headers [23:17:59] not knowing the specifics it's hard to make a call from where im sitting, but i can imagine it being rather useful - particularly for removing the need for redundancy if WML stuff was ever moved to it's own extension or whatever [23:18:51] in general i'd rather have a base class then have a bunch of code duplication - and even better if the base class can be an abstract [23:20:18] a shared base class still allows the components to be separate [23:20:43] so, im curious to hear why jdlrobson is opposed [23:21:09] this goes against making mobile a desktop skin [23:21:09] W [23:21:10] M [23:21:12] WML is special [23:21:40] i'm currently doing code review with juliusz so can't go into too much detail but this is a terrible idea in my opinion [23:21:59] "yay" for code duplication? [23:22:22] you're adding unnecessary complexity for the sake of 4 lines of code [23:23:19] MaxSem: since jdlrobson is busy, maybe send out an email to the team with your thoughts and he can reply when he's free [23:24:03] meh, I'd just write a sketch of a would-be hierarchy [23:24:44] i think that's fine, just something that we can have a discussion around [23:24:57] otherwise it will probably fall off the radar [23:25:16] and then come up again at some other not-so-opportune time :p [23:25:53] can we merge the banners stuff meanwhile? [23:26:26] * awjr slaps gerrit [23:28:04] MaxSem: you mean https://gerrit.wikimedia.org/r/#/c/68304/ and https://gerrit.wikimedia.org/r/#/c/67546/? [23:28:38] yes [23:29:12] yeah, i wanted to leave https://gerrit.wikimedia.org/r/#/c/68304/ for dr0ptp4kt or yurik to merge in case there was anything else (also, im not sure how to test it, so i didnt) [23:29:41] is that the only blocker for the MF change, MaxSem? [23:29:53] awjr, MaxSem, yurik, i've tested it, but i leave it to yurik for +2 [23:30:01] poke poke, yurik [23:30:13] (i believe yruik is testing for any regressions) [23:30:14] s/yruik/yurik/ [23:44:37] New patchset: awjrichards; "Center left and right arrows on uploads first time user tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69252 [23:45:56] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69252 [23:52:30] New patchset: JGonera; "Spike 820: Reduce API errors related to anonymous tokens (hopefully)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67867 [23:55:52] dr0ptp4kt, yurik is out partying [23:55:58] its 8pm ;) [23:56:28] dr0ptp4kt, i will +2 it later today [23:57:15] meanwhile, /me rebases it [23:57:20] New patchset: Jdlrobson; "Spike 820: Reduce API errors related to anonymous tokens (hopefully)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67867 [23:58:21] New patchset: JGonera; "Make editor disappear after a successful save" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68721 [23:59:02] New patchset: MaxSem; "Remove Zero banner cruft" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67546 [23:59:24] yurik, party on!