[00:03:26] awjr: need to test some stuff on beta labs… what's the best way to do that? [00:03:53] jdlrobson: in theory, once you merge something to master it will be deployed to betalabs inside of a few minutes [00:04:02] mmm ok [00:04:27] if you have something that you want to test but aren't ready to merge to master, you'll need to go elsewhere (maybe the 'staging' labs instance) [00:13:51] New patchset: Dr0ptp4kt; "Further decouple banners from MobileFrontend. Dependent on change 67546." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [00:15:21] Change abandoned: Dr0ptp4kt; "Functionality moved to change 68304." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69248 [00:17:34] New patchset: MaxSem; "Merge SkinMobileBase into SkinMobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69270 [00:17:40] jdlrobson, ^^^ [00:21:31] New patchset: JGonera; "Bug 49279: Style upload button correctly in Opera and Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68736 [00:26:56] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67867 [00:27:20] New patchset: Dr0ptp4kt; "Further decouple banners from MobileFrontend. Dependent on change 67546." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [00:27:46] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68736 [00:28:55] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68721 [00:31:47] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68739 [00:38:21] awjr: did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=49653 ? [00:38:54] @_@ [00:39:03] no that's disconcerting [00:39:05] * awjr tests [00:42:08] dude's probably got cookies disabled [00:43:03] awjr: i commented [00:43:15] i assume that the request desktop site feature of chrome sends a header or spoofs user agent [00:43:21] either way it sounds like an issue with the redirector [00:45:15] it's probably a cookie issue [00:54:55] New patchset: Jdlrobson; "Merge SkinMobileBase into SkinMobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69270 [05:15:20] New patchset: Yurik; "Allow debug params X-CS and X-SUBDOMAIN in URL" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69280 [06:29:47] New patchset: Yurik; "Fixed link to mobile homepage" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69283 [06:41:30] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/68304 [06:44:11] MaxSem, dr0ptp4kt awjr_away -- both iiky patches have been merged, please make sure you deploy zero in sync tomorrow. [06:44:25] aha [06:44:34] which is today for me:) [06:44:57] hey max [06:45:02] you want to remove your -2? [06:45:14] i think its not https://gerrit.wikimedia.org/r/#/c/67546/ [06:45:18] not merging because of it [06:45:22] or because of gerrit ... [06:45:41] the zero is merged ok [06:46:14] MaxSem, and while you are at it, could you +2 https://gerrit.wikimedia.org/r/#/c/69280/ [06:46:33] in case adam is not around tomorrow morning [06:46:54] done [06:47:14] you can remove other people's -2 yourself, btw [06:48:10] Change merged: Yurik; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67546 [06:48:23] you can? how [06:48:33] MaxSem, regardless, i published & submitted [06:48:38] sick and tired of that thing really [06:48:41] it should just work (TM) [06:49:49] click on X neare reviewer's name [06:50:29] oh, hmm.. wouldn't that remove that person alltogether? [06:50:38] regardless, let me know if you have any q with 69280 [06:50:43] or i'm going to bed [06:50:53] MaxSem, ^ [06:53:17] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69280 [06:53:41] thanks! [06:58:50] MaxSem, it is all live on api.beta.wmflabs.org -- just fake the headers [06:59:30] or supply X-CS and X-SUBDOMAIN as url params [07:00:51] MaxSem, just make sure you deploy them together!!! =) [07:01:06] * yurik zzzzz [07:07:13] sweet dreams yurik [15:07:35] brion: was a rebase needed? [15:07:52] YuviPanda: it simplified my life. .iml files conflict pulling the branch otherwise [15:07:57] ah [15:07:57] ok [15:08:41] brion: anything you want me to look at now? I'm going to go grab a bunch of paper and start trying to fiure out how campaigns should be [15:09:42] just doing some code review before i go in [15:09:51] alrighty [15:09:56] brion: tfinc comes back tomorrow? [15:10:04] i'm not sure [15:10:05] maybe :D [15:12:42] YuviPanda: https://gerrit.wikimedia.org/r/#/c/69309/ needs a fix. i can do it or you can :) [15:12:44] brion: heh [15:13:00] brion: grrr [15:13:12] brion: I think you should, since if I now push to GitHub it'll fuck up a little bit [15:13:15] because of the rebase [15:13:18] hehe [15:13:18] (it will undo your rebase) [15:13:19] ok [15:13:56] poop [15:15:24] oh we should also *use* bucketedWidth [15:15:27] that should help ;) [15:17:07] ok this seems to work https://gerrit.wikimedia.org/r/#/c/69309/3/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java [15:17:34] interestingly Math.round returns a long for a double, or an int for a float [15:17:57] brion: yeah [15:18:26] sometimes i miss javascript's single 'number' type. then i wake up and remember that's insane too [15:18:50] brion: lgtm, +2ing [15:18:56] brion: also found bug why merging isn't closing PR, fixing now [15:19:00] aha [15:19:06] oh you already merged [15:19:07] sweet [15:27:36] hmm [15:27:43] can people reliably use non-breaking space on translatewiki? [15:27:48] brion: unsure. [15:28:06] brion: but I'm also unsure if it is translated into its character [15:28:11] istr some problem with firefox not passing them through text edit fields reliably… but that might be old [15:28:12] brion: or just left as \u [15:28:17] pretties rue that'll be a literal character yeah [15:28:31] bleh. [15:28:39] not having it splits it up pretty badly [15:28:59] let me ask nike [15:29:19] YuviPanda: i don't see a version number update for the db change [15:29:36] brion: ah, so I don't think that is needed, since we didn't do any changes since the last release [15:29:49] brion: I think that's okay to break non-released apks [15:29:56] didn't you add something that saves the width/height? [15:30:03] ah ok i'll just have to delete/reinstall [15:30:04] *sniff* [15:30:05] :) [15:30:12] brion: yeah, but we didn't put out a release after that :) [15:30:45] yup :) [15:31:54] android-apt-compiler: [commons] /Users/brion/src/wiki/apps-android-commons/commons/res/values-qq/strings.xml:83: error: Error parsing XML: not well-formed (invalid token) [15:31:55] brion: I think we might have to spend some time on the translate extension ourselves, we keep running into little broken stuff and IIRC the language engineering team doesn't have the resources to do this for us :( [15:32:02] brion: wat [15:32:03] missing a > [15:32:05] wtf [15:32:07] wtf [15:32:18] how did that pass through?! [15:32:43] res/values-qq/strings.xml:81: error: Apostrophe not preceded by \ (in CC Attribution-Sharelike License display name. Use the non-breaking space character(\u00A0) between 'CC' and 'Attribution-Sharealike') [15:33:12] i fucking hate your strings, android [15:33:15] HATE THEM [15:33:26] sigh [15:37:09] http://developer.android.com/guide/topics/resources/string-resource.html#FormattingAndStyling [15:37:15] "If you have an apostrophe or a quote in your string, you must either escape it or enclose the whole string in the other type of enclosing quotes. For example, here are some stings that do and don't work:" [15:37:16] what... [15:37:17] the... [15:37:19] fuck? [15:37:33] brion: yes. I don't understand that [15:37:35] rather, why [15:37:41] we put a \ beforeq uotes though [15:37:48] which usually works [15:38:18] we'll probably have to fuck with the TWN format plugin or we'll get those with \s in TWN [15:38:19] sigh [15:38:25] it'll do for now to just put them in tho yeah [15:39:00] and in the qq's we don't need to copy anything so…. it shouldn't explode [15:39:09] brion: TWN already handles \ I think [15:39:24] I remember Niklas swearing at android precisely because of the quotes issue [15:39:24] so [15:39:34] ok [15:39:37] good then :D [15:39:42] now what was i testing [15:39:44] license! [15:40:22] brion: heh [15:43:06] ok license selector seems working with these changes :D [15:43:11] lemme push a patchset [15:44:13] meeeeeeerged [15:45:54] brion: :D [15:46:34] brion: okay, merging should autoclose now, I think [15:46:40] whee [15:46:43] I think [15:46:44] :P [15:46:47] it's hard to test, sortof [15:48:21] brion: did you change the topic on https://gerrit.wikimedia.org/r/#/c/69309/ manually? [15:48:28] brion: or was that automatic? [15:48:39] didn't change it that i know of [15:48:39] (it would've been github/pr/something) [15:48:45] goddamn gerrit [15:48:58] YuviPanda: is there an automatic thing that detects 'bug 12345'? [15:49:09] brion: in Gerrit, yeah [15:49:09] but I didn't know if it will change topic [15:49:11] bwahaha [15:49:11] let's find our demon [15:49:28] i'll refill my coffee :) [15:55:11] brion: :) [15:55:15] brion: I fixed that too. [15:55:20] \o/ [15:55:21] yay [15:55:22] now we just need to write some more code to find out [15:55:35] brion: you should drop by tools labs sometime, pretty sweet it is :) [15:55:39] wild-westish [15:56:03] yeah i've started a setup to do some svg stuff, just haven't finished it yuet [15:56:04] yet [15:56:19] nice [16:15:04] http://arstechnica.com/gadgets/2013/06/how-cyanogenmods-founder-is-giving-android-users-their-privacy-back/ :D [16:24:16] wooo [16:27:49] New patchset: MaxSem; "Fixed link to mobile homepage" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69283 [16:39:06] New patchset: MaxSem; "Merge SkinMobileBase into SkinMobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69270 [16:40:32] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69283 [16:56:19] MaxSem, deploying? [16:56:26] ? [16:57:17] * yurik goes to see the depl schedule [16:58:07] MaxSem, yep, aren't you deploying mobile now? [16:58:21] no, my window is in 3 hours [16:58:26] * awjr waves [16:58:44] hmm anyone seen michelle? [16:58:54] ooooh, NY time vs SF time. It moved [16:59:36] wasn't she helping fix a bus or something? I remember seeing something about a bus breaking... [17:00:00] ! [17:00:09] bus or bug?:P [17:00:32] i think it was a bus - she was going somewhere and got stranded... but ... being the awesome tester she is... [17:01:04] i'm sure bus debugging is nothing compared to our code ;) [17:01:39] jcmish! how's it going? [17:01:46] looking good [17:02:07] cool - im actually a little concerned about the upload issue on betalabs [17:02:13] :) yep [17:02:27] I'm thinking that might bite us but I will work around [17:02:44] alright, im going to investigate [17:05:20] it appears the login handshake wasn't enabled on betalabs [17:06:51] aha! [17:07:08] hmm is there an easy way for me to check that kind of stuff without bugging you guys? [17:08:23] you can always check config [17:09:30] * awjr slaps git [17:12:23] ha git might slap you back [17:14:04] hehehe it already slapped first [17:15:22] hahahhaha [17:16:52] ok, i've merged the config change to enable the handshake on betalabs [17:17:00] it should get pushed shortly [17:17:02] sweet thanks! [17:17:12] jcmish: do you know how the configuration works for prod/labs? [17:17:18] i do not! [17:18:06] here are some out of date docs: https://wikitech.wikimedia.org/wiki/Configuration_files [17:18:25] brion, when language:factory is being called, does it load all localizations right away? [17:18:54] I think it pulls data lazily [17:19:02] but I'm not certain [17:19:15] check with Aaron or tim [17:19:32] ok, thx [17:19:48] bookedmarked and looking through it [17:19:50] rendering 20 banners in multiple languages takes forever [17:20:00] and sometimes crashes [17:20:14] jcmish: most mobile-specific settings are managed in wmf-config/mobile.php (rather than wmf-config/CommonSettings.php) [17:20:49] so what about the handshake [17:21:13] jcmish: also, betalabs will follow configuration in wmf-config/InitialiseSettings.php, wmf-config/CommonSettings.php and wmf-config/mobile.php, but values can be overridden in labs-specific files (wmf-config/InitialiseSettings-labs.php, wmf-config/CommonSettings-labs.php, and wmf-config/mobile-labs.php) [17:21:22] you can see what i did here, jcmish: https://gerrit.wikimedia.org/r/#/c/69322/ [17:21:25] Yurik in production or dev? [17:21:36] http://api.beta.wmflabs.org/wiki/Zero:624-02 [17:21:47] once its cached, it goes fast [17:21:52] if dev make sure you're using cdb caching for localizations [17:21:57] but the first load returned a blank screen [17:21:57] jcmish: i didnt test but in theory the handshake was probably working on labs, but the redirect was to production commons rather than commons on betalabs [17:22:08] k gotcha [17:22:09] reload returned result [17:22:32] brion, i don't use any caching - simply render stuff when needed [17:22:38] rarelly visited pages [17:23:05] Yurik there's separate caching for localization data [17:23:17] optionally I think :) [17:23:43] about to go in subway catch ya later [17:24:00] brion, thx, will send you the link to the code in a bit [17:25:01] brion, https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroRatedMobileAccess.git/a1657079172c96e33e933a71f568180229d931dd/includes%2FZeroConfigContent.php#L162 [17:25:09] oh no, jcmish, the handshake works but i still get the upload error [17:25:17] yup just tried it [17:25:20] and was typing that here [17:25:25] is that something different? [17:27:00] not sure, jon just walked in [17:27:18] k cool [17:34:47] jcmish: so the problem appears to be that centralauth is not configured (or fully configured) on betalabs [17:35:00] ah okay [17:38:04] jcmish: and i dont think that's something we can pull off this morning [17:38:17] :( [17:38:30] these new rules are in effect now: https://gerrit.wikimedia.org/r/#/c/66991/1/templates/varnish/text-frontend.inc.vcl.erb [17:38:41] do I need to worry about it for the push tonight? [17:38:44] or can we just punt? [17:38:48] i think we can punt [17:38:52] (it pains me to say) [17:38:54] k sounds good :D [17:39:04] i just used http://www.mobilephoneemulator.com/ to test as well, you might already know it being mobile guys, but it gives you a virtual iPhone/Android/Blackberry/bla bla [17:39:08] as long as we know then I'm cool and i'll do extra focus on it [17:39:12] during deployment [17:39:50] yeah, perfect [17:49:23] jcmish: so i just made a config change on betalabs that should allow us to test the new authentication method for photo uploads (using the new token system) - the original idea was to have it running in tandem with special:loginhandshake until we're sure the new token stuff is working well and reducing upload errors [17:51:33] and it looks like it works :) [17:51:41] at least on betalabs [17:51:56] ok let's try apps-android-commons on linux again [17:52:05] jcmish: (this is for card 820) [17:52:22] brion: http://www.mobilephoneemulator.com/ [17:52:57] nice [17:53:00] sweet thanks [17:53:09] sorry heads down testing [17:54:37] heh i still have a dutch SIM in my android 2.3 phone. it's welcoming me to the US and telling me roaming rates [17:54:56] np [17:55:10] horrible rates too [17:56:19] New review: Jdlrobson; "Merge after deployment. I got some rebasing to do now.." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/69270 [17:57:14] oh heyyy, nexus one doesn't like the new wifi settings either [18:05:24] brion: https://gerrit.wikimedia.org/r/#/c/69327/ [18:05:31] brion: do you have a GB device nearby/ [18:05:32] ? [18:05:52] jcmish: what's the state of those 4 gerrit patch sets (branch elementChanges) they've been sitting there for a while now… [18:06:00] New patchset: Jdlrobson; "Use bodyContent to be consistent with desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68726 [18:06:00] New patchset: Jdlrobson; "Refactor template code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68724 [18:06:01] New patchset: Jdlrobson; "Separate page-actions from #content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68725 [18:07:01] I need to talk with Zeljko [18:07:07] New patchset: Jdlrobson; "Story 488: Add pageimages to search results (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508 [18:07:09] YuviPanda, pulling up on my n1 right now [18:07:14] lemme grab the patch [18:07:18] mm sweet [18:09:25] jcmish: I can take a look, not sure what the issue was but maybe I can sort it [18:10:01] chrismcmahon: k [18:10:06] I'll follow up tomorrow [18:10:14] too much testing going on right now [18:10:51] YuviPanda, https://www.mediawiki.org/wiki/File:Commons_app_Gingerbread_with_menu_icons.png [18:10:53] OH SHI~~~ [18:11:08] icons look good but it's kinda weird having a three-item menu laid out vertically [18:11:08] brion: lgtm [18:11:20] we'll worry about that part later :D [18:11:20] i'll merge [18:11:20] yurik & dr0ptp4kt, have zero been tested on WAP phones recently? [18:11:20] :) [18:11:37] MaxSem, nope [18:11:39] MaxSem, no that i know of [18:11:46] brion: I am *pretty* sure that's because 'Send Feedback (via Email)' is long? [18:11:52] New patchset: Jdlrobson; "Story 488: Add pageimages to search results (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508 [18:11:59] it could still stack the other two [18:12:00] but [18:12:22] YuviPanda, i suspect yeah [18:12:37] we should have an in-app form instead of email [18:12:44] could use eventlogging lol [18:13:14] brion: problem with in app is where do we store them? [18:13:17] EL has a byte count limit :P [18:13:29] and smallish, too. Unsure how small tho [18:13:39] yurik & dr0ptp4kt, cause it seems WAP doesn't get ANY Zero processing - images, links, banners [18:14:26] MaxSem, which header(s) need to be forged to reproduce? [18:14:42] EL has a byte count limit? shit [18:14:44] what's the limit :) [18:15:19] hmm i need to bring in a bluetooth mouse. got my nexus 10 hooked up to keyboard and monitor, it's kinda cool [18:15:54] brion: we havne't gone over it yet, I think [18:16:03] brion: ori-l would remember the limit, I'm unsure [18:16:05] tho [18:16:21] brion: also I forgot to start my tool again when I fixed the bugs, and so this merge didn't get processed. grr [18:16:21] User-agent: kddi Accept: application/vnd.wap.xhtml+xml [18:16:26] dr0ptp4kt, ^^^ [18:16:28] darn [18:16:49] brion: should add better monitoring at some point [18:16:54] MaxSem, thx [18:17:09] MaxSem, will need to get this on the backlog to address. yurik, will add to Trello [18:17:09] brion: good thing about this is that I'm able to actually do these in a 'general' way that all of tools-labs can use :) Everyone has Redis now, for example. Need to figure out a proper logging framework tho [18:17:39] jgonera - want to weigh in on editing stuff w/may and vibha? it's ok if you don't :) [18:18:06] Maryana, now? [18:18:14] MaxSem, yurik: card created [18:18:24] yeah, we're just going over vibha's designs now [18:18:29] 5 feet away from you [18:18:49] 2 min ;) [18:19:10] dr0ptp4kt, yurik, MaxSem: are all the zero changes merged that need to go out with today's mobile deployment? [18:19:12] just for fun, checking out apps-android-commons in AIDE on my nexus 10 [18:19:22] yes, afaik [18:19:31] brion: nice [18:19:32] eggcellent [18:19:42] don't think it'll work through, it doesn't have mvn support that i can see [18:19:53] brion: ah [18:19:59] brion: yeah, I doubt mvn will run on Android [18:20:03] brion, set X-CS=250-99&X-SUBDOMAIN=ZERO or M -- url params [18:20:09] maybe gradle in future though :D [18:20:29] although i'm not sure if betalabs has been set properly [18:21:09] there was an ungodly number of bugs squashed this last iteration [18:22:00] brion: true, needs more work now though [18:22:17] brion: gradle is I think better than maven in most aspects, but needs time to get proper android support in libs [18:23:01] dude I know nice jobs folks [18:23:03] heh yeah aide does NOT like the project. :) [18:23:03] someday... [18:23:03] gradle support? :D [18:23:26] brion: no, android support. [18:23:40] brion: maven-android used a format called apklib to package android libs [18:23:47] brion: gradle invented its own called aar :P [18:23:57] brion: in the long run people will switch to aar because, well, Google did it :P [18:24:00] yeah, no rush [18:24:00] i just like the idea of compiling android apps on android :D [18:24:01] but currently everything is apklib [18:24:01] so [18:24:04] heh [18:24:07] YO DAWG, etc [18:24:26] yay new formats :P [18:24:34] New patchset: JGonera; "Rewrite parts of the uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69132 [18:24:35] New patchset: JGonera; "Clean up uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69131 [18:24:35] New patchset: JGonera; "Story 434: Add infinite scroll to uploads dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69333 [18:24:55] are bugs now getting created with a default status of 'unconfirmed' now? [18:25:17] or is andre just setting them as such [18:25:59] you know I think default [18:26:06] I'l have to ask hin tis week in our meeting [18:31:19] YuviPanda, we could probably use a subtitle for the 'License' line in the settings screen [18:31:27] brion: true that. put on trello? [18:31:31] will do [18:31:55] brion: eventually we should actually have a full fledged 'choose your destinylicense' activity [18:32:00] which explains the licenses [18:32:21] will probably need design, but at the pace android design work is getting done I'll probably have to wait a couple of months on that [18:32:22] so [18:32:23] :) [18:32:34] brion: put on trello and assign to me [18:34:24] nice, my phone crashed. i have to reboot to get my google confirmation code [18:34:30] * brion slaps two-factor authentication [18:34:58] brion: heh [18:35:10] brion: coming up next should be 2 factor auth codes on your glass :D [18:35:45] will i need to get contacts to use glass? or does it play nice with eyeglasses... [18:36:00] brion: the current version doesn't but there's one in the works [18:36:11] brion: there were people walking around IO with prescription glasses turned Google Glass [18:36:22] brion: so I bet that by the time I can get my hands on one it'll have that solved [18:37:59] :D [18:38:10] and in the meantime, we'll make do with NSA glass [18:38:32] they probably turn on all our webcams all the time O_O [18:38:49] brion: heh [18:38:50] New patchset: MaxSem; "WIP: create a thin base class for all our skins" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69336 [18:50:48] brion: https://gerrit.wikimedia.org/r/#/c/69338/ [18:51:54] testing... [18:52:32] so i've got my second monitor hooked up to my nexus 10. i wish it was a touchscreen though ;) [18:52:49] ugh wifi keeps dropping [18:53:02] brion: yeah, that explains I think why there was black space in that screenshot [18:53:21] ok looks good [18:53:59] mergified [18:55:13] heh my firefox phone says 'last updated 01/14/1980' i think its clock has been funky [18:55:39] let's set that form the network.... [18:55:47] brion: bleh, didn't close again (https://github.com/wikimedia/apps-android-commons/pull/19) but at least I've a better error message :) [18:55:52] \o/ [18:56:07] YuviPanda, should i close it manually or leave it for you to experiment with [18:56:16] brion: oh close it. No more experimentation possible [18:56:27] brion: it is triggered on merge from gerrit [18:56:31] so we need to wait for another one [18:56:36] brion: i closed it [18:56:39] ok [18:59:06] odd that the wifi is totally stable on my xps 13 and totally unstable on my n10 [18:59:14] they're adjacent, shouldn't be a reception issue [18:59:19] brion: clearly an Apple + Dell conspiracy [18:59:37] they can have my android tablet when they pry it from my cold dead hands [18:59:42] hehe [18:59:54] i'll try the guest network, i don't need the fileserver [19:01:47] i'm suspecting the volley cache is too small for these full-size detail images on n10 [19:02:26] eh we'll fudge it later [19:02:26] brion: hmm, probably. [19:02:40] brion: what I need to do is to actually profile the thing [19:02:46] so we can set something more educated than (1/4) [19:02:47] err [19:02:48] 1/8 [19:02:53] ya [19:02:55] brion: but disk cache should be fine? [19:02:59] hmm, or not - it is still 5mb [19:03:15] yeah 5mb is.... not a lot of 2560x1440ish images [19:03:41] brion: true [19:03:50] i'll add a card to backlog [19:03:52] brion: thoughts on how it sohuld be determined? [19:03:56] brion: nah, add it to current sprint [19:04:02] brion: and file a bug. backlog seems to get...lost [19:05:02] hrm [19:05:10] well i filed a card, now if i file a bug it'll make a dupe card [19:05:13] * brion headdesk [19:05:20] brion: heh [19:05:27] brion: I think we really should just use bugzilla as backliog [19:05:43] brion: i'll bring that up when tfinc has recovered from mawwiage [19:06:05] we'll just have to remember to do it in the right order i guess :D [19:06:09] New patchset: JGonera; "Story 434: Add infinite scroll to uploads dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69333 [19:06:23] brion: I don't see what the backlog gives us that bugzilla doesn't [19:06:39] cards we can move to columns. [19:07:03] and i guess we can prioritize by moving them in order [19:07:04] sorta [19:07:13] hey there :) [19:07:20] ohai hashar [19:07:21] :D [19:07:22] welcome! [19:07:29] hey [19:07:29] YuviPanda: working on integrating the commons app in jenkins :) [19:07:34] <3 [19:07:38] maven is ****** me of :) [19:07:51] mainly because I don't know about that build tool. So I get a couple questions for you guys [19:07:55] sure! [19:08:08] ^demon probably knows more maven than I do, but. [19:08:15] the result of 'mvn package' produce the apk : /commons/target/commons-1.0-SNAPSHOT.apk [19:08:26] I would like it to be in / or maybe /commons [19:08:40] and (2), can we get rid of SNAPSHOT and replace that with the git sha1 ? :-] [19:09:00] hashar: why for (1)? [19:09:03] and (2), let me check [19:09:27] the path is because I use a Jenkins plugin that copy the artifacts (aka the apk / jar generated file) from a path to anotherone [19:10:00] New patchset: JGonera; "Story 434: Add infinite scroll to uploads dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69333 [19:10:17] my wildcard is **/*.apk , so that ends up creating a subdirectory /commons/target/ : https://integration.wikimedia.org/nightly/mobile/android-commons/commons/target/ [19:10:59] New patchset: JGonera; "Story 434: Add infinite scroll to uploads dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69333 [19:11:18] hashar: ah, hmm. path should be possible, but easier as a cp after the build target, I think [19:11:33] hashar: as for sha1, it is possible with a maven plugin, so I can add that if you want [19:12:23] (http://mojo.codehaus.org/buildnumber-maven-plugin/ being the maven plugin [19:12:24] ) [19:13:18] * YuviPanda searches [19:13:21] :) [19:14:08] I wish it was build in [19:14:17] or that maven let you forge the version by using some shell command [19:14:23] (aka git rev-parse HEAD) [19:14:31] hmm, I think it migt [19:14:32] moment [19:15:52] and there is another one http://stackoverflow.com/a/13470163/639804 [19:15:56] hashar: okay, that is possible too, with a different plugin [19:16:02] "Furthermore it is available from Maven Central Repositories." [19:16:28] hashar: http://mojo.codehaus.org/versions-maven-plugin/set-mojo.html might be simpler [19:16:32] since it lets you set version from commandline [19:17:10] and https://github.com/ktoso/maven-git-commit-id-plugin :) [19:17:21] so there is a ton of material available at least [19:17:51] hashar: true [19:18:43] let me check something [19:23:39] YuviPanda: or mvn versions:set versions:commit -DnewVersion="0.0.25" :D [19:23:48] http://stackoverflow.com/a/14484503/639804 [19:24:21] hashar: that will modify the pom file, so you'll need to do a git reset or similar after [19:25:02] New patchset: Jdlrobson; "Make editing work on pages other than main namespace" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69347 [19:25:04] the work path is wiped out between each builds [19:25:10] hashar: heh, I'm trying out that command. Maven is, as usual, downloading the entire internet [19:25:12] ah, wonderful [19:25:40] ^ jgonera awjr_lunch MaxSem jcmish would be good to get that merged before today's deployment.. will create lots of confusion in current state : [19:25:43] mvn versions:set versions:commit -DnewVersion="git~`git rev-parse HEAD`" [19:25:43] trying that one now [19:26:50] hashar: yeah, mvn versions:set versions:commit -DnewVersion="0.0.25" package [19:26:54] hashar: produces appropriately named apk [19:26:56] :) [19:26:58] what's that one jdlrobson? [19:34:59] YuviPanda: that still build the SNAPSHOT version for me :((( https://integration.wikimedia.org/ci/job/apps-android-commons-build/29/console [19:35:17] * YuviPanda looks [19:36:03] both pom.xml got updated [19:37:01] but maven archiver has the old one : ./commons/target/maven-archiver/pom.properties has version=1.0-SNAPSHOT [19:37:15] hashar: weird. [19:37:15] hashar: also [19:37:16] 19:33:30 Executing Maven: -B -f /srv/ssd/jenkins-slave/workspace/apps-android-commons-build/pom.xml versions:set versions:commit clean package [19:37:25] i don't see -DnewVersion there? [19:37:32] ahh hmm [19:37:36] it is passedtojava above [19:37:42] ah [19:37:45] java -DnewVersion=git~00c0ccea…. [19:38:06] yeah, i see it now [19:39:04] hmm, it is also the same version of maven I have [19:39:27] maybe related to jenkins [19:40:03] hashar: maybe. it seems like first the versions are being accepted and then they are cleared before 'clean' runs [19:40:29] lets try without the clean target :) [19:40:53] hashar: that's it i thnk [19:40:57] i tried with clean, am getting SNAPSHOT [19:41:04] it does not particularly make sense to me tho [19:42:26] I should have worked for Sun when I had an opportunity like 15 years ago [19:42:34] I would be a java guy nowadays :) [19:42:47] you aren't? :P [19:43:09] nop I fill bug and CC my team members :) [19:43:19] hehe [19:43:31] well, another way to look at it would be that you'll be working for Oracle now [19:44:38] New patchset: JGonera; "Rewrite parts of the uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69132 [19:44:39] New patchset: JGonera; "Story 434: Add infinite scroll to uploads dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69333 [19:44:39] New patchset: JGonera; "Clean up uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69131 [19:45:14] why doesn't android support a vector image format natively. sighhh [19:45:42] cue music... "i want my.... i want my... i want my SVG..." [19:45:45] YuviPanda: the lame jenkins job definition is at https://gerrit.wikimedia.org/r/#/c/68566/ [19:46:11] * YuviPanda reads [19:46:16] brion: that is how I find the cute site http://caniuse.com/svg [19:46:38] seems it lands in Chrome 25 [19:46:49] hashar: he's talking about native Android, I think :) [19:47:08] brion: I think you might want to take a look at the 9patch format, which Android sortof supports [19:47:11] annnnnd i thought Google was providing chrome [19:47:29] hashar: taking out clean produces proper builds, I take it? [19:47:29] that website claims Android Browser supports SVG since 3.0 :/ [19:47:39] YuviPanda: oh no, same issue [19:47:43] ? [19:47:51] YuviPanda: because the workspace is wiped out before the build begin [19:48:06] YuviPanda, that doesn't help for the welcome images, which i'd rather do as animated svg than manually draw everything like monte is on ios... but no svg in webview in 2.3 so i'll have to do that eventually [19:48:18] for now i'll just use static images though :) [19:48:22] brion: true, yeah [19:48:31] brion: we could eventually OpenGL it :P [19:48:37] hehe [19:48:44] then use common C code between platforms ;)) [19:48:45] hashar: hmm, so on my local machine, if I take out 'clean' it 'works' [19:48:53] brion: isn't there a SVG to APNG converter ? *smiles* [19:48:54] WEBGL [19:48:56] and gives me appropriately named ones [19:49:26] brion: hehe, WEBGL. "Let us add about 7 layers of abstraction on top of this, and then see the amazing performance we get!" :) [19:53:31] * brion hogs all the office bandwidth updating his win8 tablet [19:54:49] YuviPanda, a Pager holds fragments, right? [19:54:53] hashar: any thoughts on workaround? wrap the thing in a bash script? [19:55:01] brion: yes, usually [19:55:05] * brion trying to get the hang of new android bits whee [19:55:22] brion: we usually use one of its subclasses [19:55:22] which hold fragments, yes [19:55:54] brion: btw, IIRC there are native svg renderers for android [19:55:57] that you might want to look at [19:56:09] android.support.v4.view.ViewPager [19:56:12] ooh i might check that out [19:56:14] brion: specifically https://code.google.com/p/svg-android/ [19:56:28] man i wish a Chrome-based WebView were in the compat libraries [19:56:32] brion: it hasn't had updates in a month, tho [19:56:49] the big question is, can i animate the svg :) [19:56:50] YuviPanda: no idea. Might have to do something ugly indeed [19:57:01] hashar: sigh. let's ask demon? [19:57:04] brion: doubt it ;) [19:57:07] err [19:57:08] :( [19:57:16] feel free to ping him [19:57:22] having an audio right now then I will get to sleep [19:57:27] hmm, it turns them into ImageDrawables so probably static [19:57:27] might talk about it with him tomorrow :) [19:57:28] hashar: alright [19:57:31] hashar: okay [19:57:35] brion: yeah [19:57:43] brion: android has a pretty sweet animation framework, though [19:57:47] brion: and it works on 2.3 too, [19:57:48] so [19:57:53] might not be that bad :) [19:58:00] not supported "Interactivity, linking, scripting and animation. " [19:58:02] d'oh [19:58:09] heh, yeah [19:58:10] guess not [19:58:14] (svg, that is) [20:02:38] MaxSem: heads up i'll be in a meeting from 3pm but will be in irc [20:02:58] we should end by then [20:04:36] let the games begin! [20:04:38] :D [20:05:15] awjr, jcmish, jdlrobson, jgonera, Maryana - we're live on testwiki, please test:) [20:05:20] w00t [20:05:23] on it [20:06:19] ugh, zoom bug [20:06:29] but that reminds me to file it [20:06:41] YuviPanda, omg drawable resource names can't have '-' in them. guess they have to be java identifiers. sigh [20:07:58] uhh, is logging in broken for anyone else? [20:08:00] i'm getting a spinner [20:08:08] "redirecting..." [20:08:21] "please wait while we redirect you to the login form" [20:08:41] this is in stable [20:09:17] brion: yeah, hence the _ [20:10:25] also deployed today's config changes [20:11:03] umm [20:11:15] dr0ptp4kt: https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:11:16] Maryana: I loged in fine [20:11:26] *logged [20:11:30] hmm, weird [20:11:32] lemme try again [20:11:40] let me try on my browser I'm on my ipad [20:11:40] mmm nearby navigate to not working for me on android [20:12:45] just cleared my cookies and tried again - same thing :( [20:13:57] MaxSem, deploying? [20:14:05] yup [20:14:12] no, I didn't forget [20:14:15] awjr, https://gerrit.wikimedia.org/r/#/c/64629/ [20:16:08] Maryana: what browser are you using and what emulation? [20:16:28] mmm links on watch list feed do not seem clickable in alpha [20:16:30] safari/iphone 4 [20:16:49] it finally worked the third time i tried to log in.. [20:16:53] how weird [20:17:21] BUG: links on watch list feed do not seem clickable in alpha [android] [20:17:31] BUG: Navigate to doesn't work on Android [20:18:13] jdlrobson: Navigate to is that in android? [20:18:24] yup [20:18:28] duh [20:18:31] (nearby pagE) [20:18:31] I meant alpha [20:18:32] :D [20:18:39] jcmish: beta [20:18:42] k [20:21:54] everything else looks ok to me so far.. [20:22:07] did we enable nearby on wikivoyage MaxSem? or is that later? [20:24:07] jdlrobson, can do now [20:24:51] awjr, will you be there after the deployment window? [20:25:33] yes [20:26:07] MaxSem: ^ [20:26:14] MaxSem: we've got a config change that we need to make [20:26:42] since commons now has auto-mobile redirect, the handshake appears to get screwed up [20:26:51] I'll need to get up really early tomorrow so I would appreciate if you keep an eye on stuff for me [20:26:58] since the endpoints are all commons.wikimedia - hopefully changing them to commons.m should fix it [20:27:03] MaxSem: sure thing [20:27:06] thanks [20:27:16] yeah, i'll be free for an hour after the window [20:29:26] MaxSem: https://gerrit.wikimedia.org/r/#/c/69392/ [20:29:38] lulz [20:29:42] abandon whatever [20:30:19] oh Maryana I finally got log in to fail [20:30:31] then the next time it worked [20:30:52] awjr: MaxSem could the login weirdness be because of test.m? [20:31:05] it certainly could... [20:31:39] : since commons now has auto-mobile redirect, the handshake appears to get screwed up [20:31:44] MaxSem, still deploying? [20:31:47] that's the prevailing theory ^ [20:31:54] yep [20:32:24] jcmish, can we squeeze in a small css fix [20:32:24] ? [20:32:57] sure [20:33:01] what's it for? [20:33:17] awjr, deployed [20:33:22] ok testing [20:33:25] the bottom bar in diffs is not position fixed anymore [20:33:49] BUG: diff view not position fixed [20:33:49] New patchset: Jdlrobson; "Regression: Make diff user info box position fixed again" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69394 [20:33:50] (the one with user name and number of edits) [20:33:56] there's a fix ^ [20:34:00] ah go for it [20:34:05] I can live with that [20:34:10] appears to have worked, MaxSem :) [20:34:16] * jdlrobson testing complete [20:34:17] wee [20:34:44] MaxSem: did that config change go out everywhere already? this is probably also an issue in production at the moment [20:35:01] Maryana: the login issue appears fixed now [20:35:05] jcmish: ^ [20:35:08] sweet [20:35:11] awesome! [20:35:20] I'll kick off the automation tests one more time [20:35:32] awjr, will be deployed with scap [20:35:40] w00t [20:37:25] ok i've got some drawables, layouts, and strings for the welcome screen (non-animated). now i have to hook them up to an activity... [20:37:33] brion: \o\ [20:37:34] err [20:37:36] hmpf [20:37:45] brion: also don't use an activity per screen :P [20:38:19] k i'm not seeing anything else scary [20:38:26] ok, again there's a regression in editor css, preparing a fix now [20:38:27] so just the bugs that jdlrobson found? [20:38:28] YuviPanda, how's this look? https://github.com/brion/apps-android-commons/compare/welcome?expand=1 [20:38:42] i'm using fragments for the inside and an activity for the outside [20:38:50] potentially the activity could be replaced with a fragment, i'm unsure [20:38:57] since it needs to be able to launch from the login screen [20:39:26] (no code yet on that link :) [20:39:32] brion: hmm, in this case I think just using normal views should be fine [20:39:32] jgonera: are you trying to get that in now? [20:39:51] it would be good... the editor kind of looks broken when you open the keyboard [20:40:00] YuviPanda, in place of the fragments? [20:40:10] brion: fragments are good when we want to handle full lifecycles ourselves, but in this case I'm not sure if tehy'rne hhhhh nbb [20:40:12] grr cat [20:40:15] brion: yeah [20:40:19] jcmish: also are you cool with us merging https://gerrit.wikimedia.org/r/#/c/69347/ ? otherwise editing will be broken on all namespaces other than main :( [20:40:20] ^ marktraceur [20:40:21] yeah they're very simple, just an image and some text [20:40:25] sorry wrong autocomplete [20:40:27] ^ Maryana [20:40:28] K yup go ahead [20:40:29] ok i'll see if i can make em plain views :D [20:40:33] brion: +1 [20:40:48] brion: also I'm a bit unsure if all the blue will match up to our colorscheme, which looks... black? [20:40:52] but that is fixable I guess [20:40:55] but first... lunch! [20:40:57] MaxSem: can you +2 https://gerrit.wikimedia.org/r/69347 ? [20:40:59] brion: heh [20:41:02] well we can fiddle with that [20:41:15] brion: yeah [20:41:17] New patchset: Jdlrobson; "Regression: Don't attempt to hijack links in special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69396 [20:41:23] brion: also how do you keep your cats off the keyboard?! [20:41:50] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69347 [20:44:18] jdlrobson, deployed [20:44:25] thanks MaxSem [20:48:17] New patchset: JGonera; "Regression: hide button bar in editor when keyboard visible" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69398 [20:48:20] jdlrobson, ^ [20:48:28] back in one sec [20:49:18] MaxSem, ^ [20:57:53] jdlrobson: Great jerb [20:59:59] New patchset: Jdlrobson; "Fix navigate to link in Android" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69399 [21:00:00] faillllllll jcmish jgonera MaxSem ^ [21:00:10] uhoh [21:00:12] what failed? [21:00:35] my code [21:00:48] MaxSem, any issues with deployment? [21:00:55] i don't see our changes on meta yet [21:01:06] oh bummer [21:01:17] i dont think max has scapped yet yurik, we're still sorting out some issues [21:01:26] awjr, thx [21:01:33] as long as zero goes in together :) [21:03:15] yurik, I announce my scaps loudly! [21:03:24] no announcement, no scap [21:03:28] ;) [21:03:30] :) [21:07:18] i'm confused did we decide not to merge the position fixed diff? [21:07:32] and jgonera's patch? [21:08:00] (and if there we might as well merge https://gerrit.wikimedia.org/r/69399) [21:08:02] ^ MaxSem [21:08:06] ^ jcmish [21:08:53] jdlrobson, I can't review frontend stuff [21:14:12] MaxSem: juliusz has reviewed it - you want me to +2 ? [21:14:53] where's he himself? [21:14:58] https://gerrit.wikimedia.org/r/#/c/69398/ < MaxSem ? [21:15:05] are you saying you want me to +2 then [21:15:06] I've no probs with merging it if it's reviewed [21:15:12] *myself [21:16:02] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69398 [21:16:25] https://gerrit.wikimedia.org/r/69394 and https://gerrit.wikimedia.org/r/69399 are both reviewed max [21:16:31] i think gerrit bot is playing up [21:16:52] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69394 [21:17:13] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69399 [21:17:20] jdlrobson, anything else? [21:17:37] umm not that is urgent [21:18:18] okay, last merge today. either this or revert [21:19:58] YuviPanda, i just push em away from the keyboard when they get close :) [21:20:26] brion: heh, alright. i managed to get her off the keyboard and on to the lap, so that's okay I guess [21:21:06] lay down on the couch -> cat sits on legs also works [21:21:35] jdlrobson, synced to test [21:22:31] brion: heh, no couch here tho [21:22:39] jcmish & Maryana - are we set to deploy? [21:22:54] i'm all set [21:23:07] we should pitch in and get YuviPanda some furniture :) [21:23:44] brion: heh, problem is i'm at $randomFriend's place every other week [21:23:57] brion: okay, so campaigns - I'm talking it out with a friend, drawing / writing things on cards. [21:24:09] brion: also apergos is helping with determining current campaign use on desktop (is grepping logs for me) [21:24:21] brion: i'll have something up on a page before you guys turn up tomorrow, I think [21:24:41] jcmish ? [21:24:44] yessir [21:24:51] sorry didn't hit enter [21:24:56] can we deploy? [21:25:04] yup [21:25:23] yup [21:27:25] New review: Jdlrobson; "As discussed on IRC I'm really against this. I think the WML class is fragile and special and we sho..." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/69336 [21:27:59] YuviPanda, awesome, give a ping and i'll read over it when ready :D [21:28:03] brion: sure [21:28:12] brion: also, http://imgur.com/a/1NkNa :) [21:28:34] that's a lot of star trek :D [21:28:34] jdlrobson, any ideas how it should look then? ^^ [21:29:09] brion: can never have too much star trek :) [21:29:42] awjr: what days are our planning meeting [21:29:44] jdlrobson, and can you elaborate on "This also breaks the desktop skin version of Minerva as the desktop skin shouldn't inherit any of the mobile skin code."? [21:29:51] and times again? [21:29:55] jcmish: weds, thurs, fri - should be on your calendar [21:30:01] MaxSem: let's get deployment out the way first [21:30:02] 10am-2pm PDT [21:30:12] but as stated i'd rather we had a big discussion on a mailing list about this [21:30:16] it seems are goals are misaligned [21:30:17] I'll go to bed after it [21:30:30] my goal is to stop breaking WML [21:30:32] opps sorry thanks awjr I don't think I saw them there [21:30:34] last lweek [21:30:44] but how does that help this Max? Currently the code is completely sandboxed which is a good thing [21:30:53] this ties it up to code used for mobile and desktop skins. [21:30:54] your refactorings have completely broken Zero support for it, for example [21:31:16] no prob jcmish :) [21:31:22] some basics must be precisely the same [21:31:30] and we broke it before with cleaning up the HTML skin before that.. [21:31:40] all three days are kinda burly (4 hours), but we'll have lots of breaks and 30-60 mins for lunch each day [21:31:54] now, there's nothing template-related there [21:32:03] (plus there should be no zero code in our code base) [21:32:19] there's no Zero code in my refactorinf [21:32:31] awjr: cool I'm trying to coordinate time with Zeljko so I can get those commits down so trying to find a spot :D [21:32:41] no problem :) [21:32:43] however, we need to call all the needed hooks. unlike what' we're doing now [21:33:09] MaxSem: well call them in WML - maybe we need an abstract common class when constructing skins for the time being but they shouldn't be part of the skin itself [21:33:32] no wai, this duplication is the root of evil [21:33:58] well anyway you're existing patch set undoes all the upstreaming skin work i've been done - it replaces the desktop skin with a page which just has a script tag with window["_GOOG_TRANS_EXT_VER"] = "1"; [21:34:09] we already have a common class, called MobilleFormatter [21:34:34] well, that's why it's marked with WIP;) [21:34:35] i'm not saying duplicate i'm saying rethink/discuss what the skin architecture should be rather than rushing a solution like this [21:34:48] my main point was to show how the code would look like [21:34:58] I'm not rushing [21:35:07] I'm showing you a sketch [21:37:40] MaxSem: I will take a closer look and come up with a counter proposal - i'd really like to see our skin classes shrinking though due to upstreaming rather than growing in numbers [21:40:17] jdlrobson, thanks:) [21:40:41] MaxSem: https://gerrit.wikimedia.org/r/#/c/68309/1/files/misc/beta/sync-site-resources this is a silly reason for a -1 :/ [21:42:18] YuviPanda: still there ? :D [21:42:28] hashar: yessir [21:42:33] Archiving /srv/ssd/jenkins-slave/workspace/apps-android-commons-build/commons/target/commons-00c0ccea49900e943fc319f3daf99954c28b6491.apk [21:42:37] I am definitely a hacker :-) [21:42:38] \o/ [21:42:41] so [21:42:55] if you run: versions:set versions:commit package [21:43:04] the pom is updated with the new version [21:43:22] but that is not reread by maven, and 'package' is build with the old version (aka 1.0-SNAPSHOT) [21:43:28] brion: aaah [21:43:29] err [21:43:31] hashar: aah [21:43:33] makes sense. [21:43:37] the trick is to run 'mvn versions:set versions:commit' as a pre building step [21:43:40] I also guess that I was running the same command... [21:43:40] ok [21:43:42] then run the 'mvn package' [21:43:47] sweet! [21:44:06] console: https://integration.wikimedia.org/ci/job/apps-android-commons-build/41/console [21:44:25] \o/ [21:44:35] yeah the evil is there https://integration.wikimedia.org/nightly/mobile/android-commons/commons/target/ [21:44:48] :D can it copy it without the target? [21:44:52] or maybe a symlink of some sort? [21:47:31] I will find a way :-) [21:48:34] ahh [21:48:50] I had a stacktrace because the job used maven2 when it needs maven3 \O/ [21:49:37] MaxSem: all the things deployed now [21:49:38] ? [21:49:57] hashar: aha! :) [21:49:59] ok [21:50:05] awjr, finished seconds ago [21:50:17] w00tyw00t [21:50:17] YuviPanda: could use something that would nicely define you to add an easter egg :) [21:51:12] hashar: hah, tz=MiddleOfAtlantic maybe? [21:51:21] should we test? [21:51:54] hashar: or you can leave an easter egga about yourself :D [21:52:01] jcmish, yes please:) [21:52:09] on it [21:52:17] YuviPanda: talking of easter eggs next april fools we should make nearby pop up strange results as being nearby such as https://en.m.wikipedia.org/wiki/Utopia and https://en.m.wikipedia.org/wiki/Holy_grail [21:52:30] Maryana, jdlrobson, jgonera scap is done [21:52:33] \o/ [21:53:01] jdlrobson, heheh [21:53:04] that's pretty good [21:53:24] jdlrobson: :D the Beast of Aaaarrrrgghhh too, maybe :) [21:53:28] fuuuu... sync fail again, fixing... [21:53:44] YEHHHH nearby has navigate to links [21:53:52] yeeii, its life! [21:53:58] jdlrobson: nice :) [21:54:02] how is it possible to suck as much as our deployment system does... [21:54:18] MaxSem: any reason why i;m only seeing 7 nearby pages in the nearby view now!? [21:54:42] GeoData update bug [21:54:56] been hunting for it for a long time [21:55:05] https://en.m.wikipedia.org/w/api.php?format=json&action=query&colimit=max&prop=pageimages%7Ccoordinates&pithumbsize=180&pilimit=50&generator=geosearch&ggscoord=37.7871695%7C-122.399686&ggsradius=10000&ggsnamespace=0&ggslimit=50 < MaxSem :( [21:55:20] 10km in SF should show up more than 9 [21:55:28] I know;) [21:57:06] MaxSem: is there a bug open? [21:57:17] nope. probably, should be [21:57:23] will do that tomorrow [21:57:24] zoom bug is messing w/my view again. thanks for filing it, jgonera [22:00:43] jcmish, looks good? [22:00:53] yup automation tests just passed [22:01:02] I'm giving a bit of extra love to uploads just to be sure [22:01:14] Maryana: anything jumping out at ya? [22:01:19] i can't seem to upload… image loading screen has been spinning a long time for me [22:02:22] canceled and tried again with a different filename and it seemed to work [22:02:31] jdlrobson, are we accepting commas in file descriptions? [22:02:39] in theory we should.. [22:02:54] yup just worked for me... [22:03:11] i tried to upload a file w/a comma in the filename and it wasn't working [22:03:19] but without the comma it went through [22:03:21] lemme check the logs [22:03:22] https://commons.wikimedia.org/wiki/File:Test_upload_from_wikipedia_to_commons,_yo_2013-06-18_15-02.png [22:03:37] remind me… what's the deletion category? [22:04:25] {{Test upload}} [22:04:57] or just send me the link & i delete :) [22:05:31] well, i got no error, so who knows [22:05:54] have a call back in a bit folks [22:07:23] why does the read in another language button now say "EditRead in another language"…? [22:07:28] in beta [22:08:03] okay, I'm going to bed - awjr, it's yours:) don't be scared of what you're seeing in fatalmonitor, it was a deployment glitch and now the number of errors is dropping [22:08:17] good night, maxsem! [22:08:29] alright MaxSem, thanks for the head's up :) sleep well! [22:09:15] thanks:) [22:10:38] everything's looking good to me, with the exception of that weird extra word on the languages button [22:11:05] YuviPanda, any idea why this isn't working? https://github.com/brion/apps-android-commons/commit/1eac1a4ffa633befe15c13cded8144c5b455b115 [22:11:14] * YuviPanda looks [22:11:20] i get 3 pages in the pager, but they're all empty [22:11:42] i'm probably doing something dumbass [22:11:53] brion: try passing null to second param of getLayoutInflater().inflat [22:11:54] e [22:11:55] ? [22:12:11] IIRC the container isn't supposed to be used for inflating, but only for 'mysterious other things' [22:12:17] hmmm ok [22:12:23] and then add it to the container manually, lemme try [22:13:33] almost... [22:13:49] works until i get to the end of the pager, then sorta stops working o_O [22:14:24] ah going backwards breaks shit for some reason [22:14:47] i bet the container's not per-page or some shit [22:15:15] brion: no you don't need to add anything to the container [22:15:24] brion: ignore the container [22:15:24] :) [22:15:47] brion: hmm, wait. that looks fishy to me, I'm not sure if you're overriding the correct thing [22:15:47] moment [22:16:55] yurik, dr0ptp4kt are the deployed changes looking ok on your end? [22:17:07] * yurik is scared to look [22:17:13] zero config pages look nice [22:17:19] brion: no, you seem to be doing them right [22:17:21] YuviPanda, ok this is working for me https://github.com/brion/apps-android-commons/commit/9b44862c2b668a30d8fc8064f12ce1940f7dc6b1 [22:17:24] brion: what is the exception? [22:17:25] * YuviPanda looks [22:17:39] had to remove just the right view instead of all views from the container [22:17:40] awjr, will check. cc: yurik, MaxSem. [22:17:59] groovy; max is off to bed, so feel free to follow up with me dr0ptp4kt, yurik [22:18:01] brion: ah, sweet :) [22:18:25] now to try on every form factor :P [22:18:47] brion: :) [22:19:27] hmm the yes button looks crap on 2.3 for some reason [22:19:38] it's very tiny, just barely wraps the text [22:19:42] i can add some padding maybe [22:19:53] or just give it a fixed size :P [22:20:04] brion: eek fixed size :P [22:20:21] yeah feels dirty. i'll try padding first [22:20:22] brion: try out relativelayouts? [22:20:26] awjr, seems ok on my quick tests [22:20:51] :) [22:21:29] awjr, yurik, agree, seems to work here, too [22:21:35] woohoo! [22:23:22] eh heck with it i'll give a default size, and assume 'yes' isn't more than ABCDEFG-ish in length [22:23:29] * brion is lazy today [22:23:35] brion: we can relativelayout it later :) [22:23:42] :D [22:24:11] ok that's better on the n1 [22:26:37] bah android studio on my linux box doesn't like the kindle fire [22:26:41] it sees it as ??????????????? [22:27:12] oh well [22:27:15] * brion tests others [22:28:15] brion: heh, drivers maybe? [22:28:15] hmm [22:28:16] doubt it [22:28:36] it used to need some manual adjustment in the adb settings [22:28:36] might still need that [22:28:38] ah [22:28:39] i'll fudge it later [22:28:39] ok [22:30:18] wish i had two display outs :( maybe i'll go back to my linux desktop at the office [22:30:28] i was gonna take it home and make it a gaming box :) [22:30:53] and/or fileserver [22:31:36] brion: :) [22:31:48] ok no huge surprises on the tablets, that's good [22:33:01] hmm, now is there a default way of getting little pager dots or do i have to do that manually... [22:33:18] * brion looks up docs [22:34:29] brion: no, there isn't [22:34:35] brion: but, there's a library for that [22:34:39] from the excellent Jake Wharton [22:34:44] \o/ [22:34:56] brion: https://github.com/JakeWharton/Android-ViewPagerIndicator [22:35:18] brion: you can include the XML from there in our pom.file (commons/pom.xml, not the one outside) [22:35:18] nice [22:35:25] brion: and doing a mvn compile, closing and re-opening your IDE [22:35:55] Maryana: oops i'll raise a bug for EditRead in another language [22:35:56] heading bed, YuviPanda ping me whenever you need :-] [22:36:06] hashar: good night, and thank you, hashar :) [22:36:10] jdlrobson, i already did :) [22:36:11] ooh you already did ;-) [22:36:14] jinx [22:36:16] double jinx! [22:36:29] * hashar google for 'define jinx' [22:37:10] http://www.urbandictionary.com/ <-- one of the most useful resource for a non native english speaker [22:37:24] hashar: hahah :) [22:37:29] I wonder what it says about wiki [22:37:50] that dict is more useful to me than any other dict :- [22:37:51] ) [22:37:56] haha, not bad http://www.urbandictionary.com/define.php?term=Wikipedia [22:37:58] http://www.urbandictionary.com/define.php?term=wiki [22:38:46] if there is one thing I regret, is that we launched so many projects but haven't gave them the love they deserves (wiktionary / wikisources / commons ) ;D [22:39:08] oh yeah, hashar, me too [22:39:22] but that is slowly changing :] [22:53:28] all right, maven wants to install a billion packages. yay for apt-get [22:53:41] didn't actually have it on my xps :D [22:57:20] YuviPanda, ok for some reason I can't get this to build in the IDE, it whinges that it can't find the pager indicator classes [22:57:21] https://github.com/brion/apps-android-commons/commits/welcome [22:57:37] brion: close IDE, open again? [22:57:46] brion: usually a 'mvn clean compile' with the IDE closed, then re-opened works for me [22:57:48] (usually) [22:57:56] * brion tries :) [22:58:35] brion: either way, I think this is still much better than the 'other' way of cloning it yourself, importing it to the IDE, then adding a reference by hand :) [22:59:00] yeah i just have to get it worknig :P [22:59:07] YuviPanda, can you check my pom.xml and make sure it looks right? [22:59:12] looking [22:59:35] brion: you can always use http://search.maven.org/ to check that [22:59:36] * YuviPanda looks [22:59:39] * brion tries reimporting whole project :P [22:59:58] brion: yes, pom.xml is fine [23:00:29] brion: if dex throws errors, you would need to add the tag from the previous dependency to this too [23:00:32] ok reimport almost worked [23:00:33] java: duplicate class: com.viewpagerindicator.BuildConfig [23:01:54] brion: try the exclusion? [23:02:12] brion: we use a newer version of support lib, and IIRC they all bring with them an older version [23:03:06] trying exclusion [23:03:38] yessss it builds [23:03:45] * brion learned to add things to a pom.xml today \o/ [23:04:29] ok something failed horribly [23:04:31] but.... it's a start [23:06:24] adb not responding. nice [23:09:44] when in doubt, restart the ide \o/ [23:11:42] brion: heh, works? [23:12:32] so i've got it allegedly hooked up but... i see no indicator [23:12:44] brion: at least it compiles :) [23:12:51] yes this is an improvement ;) [23:12:58] :) [23:37:45] * YuviPanda heads to sleep [23:43:03] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69270 [23:43:05] New patchset: Jdlrobson; "Clean up uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69131