[00:14:46] New review: Jdlrobson; "Some minor improvements to make before merging." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/69131 [00:21:55] New review: Jdlrobson; "* Doesn't seem to work on an empty user (just shows an infinite spinner)" [mediawiki/extensions/MobileFrontend] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/69333 [00:22:53] New review: Jdlrobson; "recheck" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64510 [00:36:57] New patchset: Jdlrobson; "Make desktop Minerva mobile Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68720 [00:38:30] New patchset: Jdlrobson; "Alpha: Toggle open all sections on larger screens by default" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69440 [00:39:55] New patchset: JGonera; "Rewrite parts of the uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69132 [00:39:56] New patchset: JGonera; "Story 434: Add infinite scroll to uploads dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69333 [00:39:56] New patchset: JGonera; "Clean up uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69131 [01:03:06] Can you post to https://bugzilla.wikimedia.org/show_bug.cgi?id=49790 giving a time when it's okay to try to get NavigationTiming working on Labs [01:03:08] ? [01:03:19] As stated there, it might result in some temporary Mobile Labs breakage. [01:04:43] superm401: sure thing [01:04:46] thanks :) [01:04:52] Thank you [01:07:27] New patchset: Yurik; "Moved Special:Zero... code to Special page" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/67947 [10:53:05] I added https://bugzilla.wikimedia.org/49804 for good meassure [10:53:37] I assume no one uses Dolphin Browser any more? [10:54:03] (I use it because it's the only blody browser on android you can actually exit logically) [16:48:10] AzaToth: does it happen only in beta? [16:54:03] YuviPanda: haven't tested non-beta [16:54:07] ah, ok [16:54:17] can test if you want [16:54:29] AzaToth: i'm not going to be of much help, jdlrobson is the guy you want :) [16:54:41] (just got gack from de-fat proc so I'm a bit tired) [16:55:37] YuviPanda: "beta" is "experimental mode" right? [16:55:46] AzaToth: yeah [16:56:34] jdlrobson: I see you just commented [16:57:14] what's the problem? [16:57:55] AzaToth: mobile has stable, beta and experimental modes [16:58:14] happens in all three modes [16:58:23] AzaToth: what does? I only just joined.. :) [16:59:02] jdlrobson: the bug you just commented on regarding "Ä" and dolphin browser [16:59:10] ahh that's experimental only [16:59:20] happens in beta and normal as well [16:59:22] it's a problem in a library we're using History.js - i expect we will stop using it [16:59:35] AzaToth: are you sure you're not loading a cached page? [16:59:45] could be [16:59:49] sometimes when you switch from alpha to beta it caches alpha for a while [16:59:59] way to check is the placeholder in the search box - should say the mode [17:00:18] ok, it doesn't redirect now after restart of dolphin [17:00:26] yep caching then [17:00:38] the code only belongs to experimental - this is why it's experimental ;-) [17:00:42] mobile web team!!! r31 please [17:00:44] it only happend in dolphin though, not in firefox or chrome [17:00:51] jdlrobson, jgonera ^ [17:01:04] jgonera sounds like a disease [17:01:19] ohai tfinc [17:01:29] YuviPanda: greetings [17:01:33] YuviPanda: how goes it ? [17:01:47] hey tfinc! [17:01:48] tfinc: not bad at all. i heard your life is presently wonderful :) [17:02:04] jdlrobson: is it per design you cant go from experimental to normal directly? [17:02:27] yep to make it more difficult AzaToth :) [17:02:31] heh [17:02:38] Do we have an apps standup today? I know web guys are meeting separately [17:02:52] jdlrobson: as I said, it doesn't happen on chrome android [17:02:57] I guess I should blame my parents, AzaToth [17:03:06] jgonera: ツ [17:03:27] * AzaToth instinctly thinks of robin hood men in tights [17:04:06] http://etherpad.wikimedia.org/2012-2013-Q4-Retrospective-Mobile-Web [17:04:52] when I'm here anyway, perhaps it's time for me to release my frustration: Why can't you practically access talk pages from mobile view? [17:06:28] AzaToth: I believe jdlrobson & co are working on making that suck less. [17:06:54] hehe [17:08:48] * AzaToth accidentally entered "Ä" on simplewiki [17:09:00] I cannot fathom why such wiki even exists [17:09:17] simple english? yeah… it's…. odd. [17:09:38] I assume I'm not intelligent enough to understand the content there [17:13:14] brion: no standup today? [17:13:47] YuviPanda: web guys are in a bigger meeting, i guess we don't have a standup :) [17:13:53] brion: ah, hmm, okay then [17:13:57] mhurd: poke [17:14:09] you guys want to do our own standup or just sync in irc? :) [17:14:19] hey brion! [17:14:29] i'll be right there [17:14:45] brion: irc is good to me [17:14:50] can do video fi you want [17:15:55] thomasz is adding the hangout now [17:16:47] whee calendar links easier than trying to push a URL to the chrome box :D [17:26:14] whee [17:30:00] hmm, I wonder if there's a Google TV box that supports MiraCast [17:41:14] brion: YuviPanda: heads up that I just pruned https://trello.com/board/mobile-app-sprint-11/51b8360dc86b2c4b49011ddc Ready for dev column [17:41:39] and i moved up the server card as license pulling is critical to a lot of our features [17:41:43] plus mobile web would use it [17:41:53] tfinc: alright. [17:41:54] spiff [17:42:12] tfinc: I'll generate cards for the Campaign stuff in a while. [17:42:29] tfinc: I also replied asking you if we could move the 1-on-1 to next week, since tehre are already longish meetings tomorrow and day after [17:42:36] YuviPanda: sure [17:46:15] YuviPanda: is the only thing blocking https://trello.com/card/release-android-remove-beta-text-from-market-info/51b8360dc86b2c4b49011ddc/26 the icons ? [17:50:56] tfinc: yeah [17:57:13] tfinc: YuviPanda: brion: just talked to vibha about the android icons - she's on it [17:57:21] \o/ awesome [17:57:23] mhurd: sweet. [17:58:11] mhurd: can you also point her to https://developer.android.com/design/style/iconography.html#launcher, since that's why we can't use the current one :) [18:00:02] oh goodie, they want us to create xxhdpi icons now? [18:00:33] eventually they'll need an xxxhdpi for 4k tvs... [18:02:13] brion: :D the S4 [18:02:19] is xxhdpi, IIRC? [18:02:23] yep [18:02:35] oh great do i need to buy another device? :PPP [18:03:17] brion: RESIST! :P [18:03:32] i'm trying to buy a house later this year so…. don't need to spend the money :) [18:03:51] yurik: ping [18:04:32] there's a white nexus 4 now? :P [18:11:41] YuviPanda: i messaged vibha the link [18:12:19] mhurd: sweet [18:12:26] mhurd: did you find the icons ? [18:13:34] tfinc: only for iOS [18:16:12] jgonera, Maryana: http://etherpad.wikimedia.org/ep/pad/create?padId=mobileweb-wsj [18:16:36] jgonera: http://etherpad.wikimedia.org/mobileweb-wsj [18:17:10] Wall Street Journal? [18:20:21] tfinc: there's a link to the license selector build of android in the card. [18:24:16] YuviPanda: link me to the card so that i can get back to it later today [18:24:32] tfinc: https://trello.com/card/android-add-license-selctor/51b8360dc86b2c4b49011ddc/32 [18:24:33] mhurd: why didn't they do Android as well ? [18:24:35] thanks YuviPanda [18:24:59] tfinc: they did, i just couldn't track down the link [18:25:21] mhurd: please email them and attach them to the card [18:25:26] tfinc: already did [18:25:28] :) [18:25:34] let me know if you have any trouble getting them so that we can unblock YuviPanda [18:26:39] tfinc: mhurd munaf made an Android icon a long time ago, but it was just a derivative of the iOS icon, and did not follow Android Icon guideliness. Talked to Jared about it, he agreed we should have it set according to Android guidelines, so I guess a new one is being made now [18:27:03] YuviPanda: do we have a story card for it? i want to make sure it doesn't get lost [18:27:49] there's https://trello.com/card/redesign-icons-for-mobile-web-and-apps-iconset-should-include-wikipedia-commons/5112b893d0cd43cb370062bd/51 but it isn't specific enough [18:27:52] let me make a new one [18:28:11] tfinc: can we get rid of the 'mobile design' board? would be easier to just keep it in the sprint board [18:28:16] * YuviPanda make sthe icon card in sprint board [18:28:20] may just gave me the dropbox link, which i attached to this card: https://trello.com/card/release-android-remove-beta-text-from-market-info/51b8360dc86b2c4b49011ddc/26 [18:28:31] YuviPanda: the designers created it that. if they no longer want it then lets get rid of it [18:28:36] we don't use it during our planning [18:29:02] tfinc: https://trello.com/card/android-make-icons-for-commons-android-app-app/51b8360dc86b2c4b49011ddc/48 [18:29:53] tfinc: YuviPanda: did i attach the dropbox link to the correct card? [18:30:02] mhurd: which one? [18:30:24] mhurd: ah, see it now [18:32:16] mhurd: is it supposed to be greyscale? [18:32:33] YuviPanda: not sure... [18:32:42] mhurd: can you verify? [18:32:55] * YuviPanda hopes that the design team turn up on IRC someday :( [18:34:14] YuviPanda: i message them on hangout chat - they respond there pretty quickly [18:38:58] YuviPanda: may confirms the greyscale [18:39:04] mhurd: alright [18:40:00] hmmmm [18:41:00] i think we need some shading to fit with android style [18:42:36] brion: can you fiddle with it and see how it looks like on the device? I think it'll go much better than me trying it out and then daisy-chaining-feedback remotely [18:43:01] ok [18:43:51] brion: YuviPanda: i asked may if she's on irc... [18:44:01] brion: ty [18:44:04] agh gotta switch machines and charge. brb [18:45:17] violetto: hey may [18:45:22] hey monte [18:45:36] * brion waves [18:45:38] YuviPanda: may's here [18:45:46] ohai violetto :) [18:46:14] hello guys [18:46:21] violetto: any particular reason for the commons app icon to be grayscale? [18:46:31] violetto: brion mentioned it needs shading to look better on the screen [18:46:35] * YuviPanda waits for brion to turn back [18:47:01] * brion_ waves from linux [18:48:15] it's in line with what we're headed towards with a flatter and more grayscale UI [18:48:42] may i take a look how it might not look better on the screen? [18:48:55] brion_: ^ [18:49:07] taking screenshots now :) [18:52:14] current icon: https://upload.wikimedia.org/wikipedia/mediawiki/5/5e/Commons-android-Current-icon.png [18:52:22] new icon: https://upload.wikimedia.org/wikipedia/mediawiki/0/0f/Commons-android-Flat-icon.png [18:53:18] violetto: ^ [18:53:55] i actually kinda like our current icon better, it's nicely shaded and pretty :) [18:54:13] what do you mean by shading? [18:54:34] to show dimension at the top? [18:54:52] gradients and shadows giving impression of dimension and 3-dimensional shape [18:55:45] yeah, 'Use a distinct silhouette. Three-dimensional, front view, with a slight perspective as if viewed from above, so that users perceive some depth.' [18:55:48] (from https://developer.android.com/design/style/iconography.html#launcher) [18:59:04] did you mean you don't see a more pronounced shading at the top to fulfil the "Three-dimensional, front view, with a slight perspective as if viewed from above" guideline? [18:59:44] i don't think there is a safe color we can go with to accommodate to the kinds of backgrounds users will be using [19:00:01] violetto, compare with the messaging icon on the bottom row [19:00:15] we've had this discussion within our department and we've agreed to use that [19:00:15] it's got a brighter top (indicating lighting from the top) [19:00:22] and a nice subtle gradient along the front [19:00:33] not sure what you mean by safe color [19:01:06] im assuming you're not able to view the shaded top because of the darker background [19:01:28] here's the recommended color palette for android: https://developer.android.com/design/style/color.html [19:02:03] violetto, i see exactly three colors in that icon. flat white, medium gray, and a lighter gray at the top [19:02:15] i see all of them on both light and dark backgrounds [19:04:03] the color guideline page is just a guideline for their brand [19:04:14] we have our own branding and we'd want to keep it in line with ours [19:04:42] much more important is the general guidelines on the look [19:04:58] if we plaster some flat ugly icon it's not going to fit well on screen [19:05:21] dropping shading and colors loses some of our visual distinction [19:05:30] i definitely don't like the medium-gray-on-white, its very washed-out looking [19:07:20] within the design group we have a consensus to roll these out as a change and we will respond to the community as we go [19:08:47] * YuviPanda agrees that it looks fairly out of place among the other icons. [19:10:02] well, i don't consent [19:10:28] it's totally out of place and is a regression from the current icon [19:10:54] did you guys look at other android and iOS icons when coming up with this consensus? [19:11:59] yes we have looked at other icons. Jared can speak with you more in details after lunch [19:12:13] thanks. will he be available on irc regularly? [19:12:50] (+1 to IRC over Hangout / GTalk, because it is publicly archived + osmosis) [19:13:44] no, he's usually on gchat/hangouts, but he'll get on irc if anyone needs to speak to him here [19:14:35] irc is our primary real-time chat system, he really should be online consistently while working [19:15:31] gchat will be basically limited to random subset of employees and contacts, i guess [19:47:24] brion_: updated https://www.mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace_proposal, also responded on talk page [20:14:23] tfinc: do you know if those 4 takeout containers in the fridge are up for grabs? [20:33:32] okay, jdlrobson - meetings are over, did you have a chance to formulate your view on how should skin refactoring look like? [20:34:34] not yet Max haven't done any coding since last deployment :) [20:49:05] YuviPanda, http://www.mediawiki.org/wiki/User_talk:Yuvipanda/Campaigns_namespace_proposal#More_notes [20:49:37] brion: hmm, what is the talk page convention for replying 'point by point'? [20:49:41] whatever I used, or... [20:49:41] ? [20:50:09] YuviPanda, indent and maybe italicize? :) [20:50:16] ah, hmm [20:50:21] brion: but it'll break your sig [20:50:28] aww [20:50:32] like, how do we know which is me and which is you [20:50:56] * brion [20:50:59] ** ''yuvi'' [20:51:02] hehe :P [20:51:06] maybe add sigs on each line :) [20:51:10] I should write all my messages in pink [20:52:04] brion: i think that works [20:52:48] heh [20:54:38] New patchset: MaxSem; "Rm unused vars" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69584 [20:55:55] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69131 [20:57:04] New patchset: MaxSem; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [21:02:50] brion: https://www.mediawiki.org/wiki/User:Yuvipanda/Mobile_campaigns is a little bit better devleoped now [21:03:55] brion: if it looks okay to you, I'll start adding trello cards for Phase 1 [21:05:35] YuviPanda, +2 :) [21:05:43] brion: sweet, let me write it up then :) [21:06:07] brion: can I assign the Android bugs to you in the meantime? :D [21:07:06] shure [21:08:00] brion: ty :) they're all small ones [21:09:29] brion: done [21:09:37] \o/ [21:16:57] New patchset: MaxSem; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [21:17:28] awjr, I've resurrected the change with failng tests [21:17:30] ^^ [21:18:11] hooboy [21:18:38] OuKB: im in a mtg i'll take a look later [21:20:15] bbiab charging [21:33:38] New patchset: JGonera; "Rewrite parts of the uploads dashboard code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69132 [21:33:38] New patchset: JGonera; "Story 434: Add infinite scroll to uploads dashboard" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69333 [22:03:44] New patchset: JGonera; "Don't load Hogan twice" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69592 [22:05:28] jdlrobson, where are you? [22:14:30] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69592 [22:15:20] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69132 [22:16:17] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69396 [22:21:05] jdlrobson: before i leave today i want to talk to you minerva and the big picture planning for tomorrow. come grab me when you have a minute. i'll be around till 6 [22:22:19] k tfinc grab me at 4/4.30 depending on how long you need as i need to leave at 5 [22:22:28] k [22:22:36] New patchset: Jdlrobson; "Refactor template code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68724 [22:22:37] New patchset: Jdlrobson; "Separate page-actions from #content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68725 [22:22:37] New patchset: Jdlrobson; "Hygiene: Remove unused data parameter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69594 [22:23:32] New patchset: Jdlrobson; "Hygiene: Remove unused data parameter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69594 [22:23:32] New patchset: Jdlrobson; "Refactor template code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68724 [22:23:33] New patchset: Jdlrobson; "Separate page-actions from #content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68725 [22:25:58] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68724 [22:30:40] New patchset: Jdlrobson; "Separate page-actions from #content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68725 [22:31:31] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68725 [22:31:36] New patchset: JGonera; "Hygiene: Remove unused data parameter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69594 [22:32:10] New patchset: JGonera; "Use bodyContent to be consistent with desktop" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68726 [22:32:18] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69594 [22:35:53] Change abandoned: JGonera; "Let's keep #content for now as the markup of #bodyContent is not exactly the same as #content." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/68726 [23:10:12] New patchset: Dr0ptp4kt; "Reinstate WML support for Wikipedia Zero." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69603 [23:12:31] ahhhhhhrgh android [23:12:40] ViewPager lets you *set*OnPageChangeListener [23:12:44] but not *add* one [23:12:57] New patchset: Jdlrobson; "Story 488: Add pageimages to search results (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508 [23:13:16] ooooh [23:13:21] i can pass it through the page indicator [23:13:25] yayyyy api sanity [23:14:36] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/67508 [23:17:19] brion: https://minus.com/l0CTLXq85t8DA [23:17:20] \o/ [23:17:22] contenthandler [23:21:39] wheee [23:22:15] brion: needs fixing, etc, but I think Phase 1 of Campaign stuff should be up for review before weekend :) [23:22:39] sweet [23:22:57] brion: it also will fix a long running bug the WLM folks were complaining about, which was lack of revision history in the current implementation [23:23:08] brion: apparently there are edit wars that happen on Camapigns and nobody is sure what happens :D [23:23:11] yeah [23:23:12] hah [23:23:26] https://gerrit.wikimedia.org/r/#/c/69606/ <- man that's a wide commit summary [23:23:47] brion: sweet [23:23:48] saw it :D [23:24:00] brion: I'll need to implement wrapping automatically [23:24:01] soon [23:24:07] brion: i'll review tomorrow [23:24:38] ok [23:49:45] New review: Jdlrobson; "Does Zero ensure banners are added in wap format?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69603 [23:50:30] New patchset: Jdlrobson; "Hygiene: Rm unused vars" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69584 [23:51:31] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69584