[01:11:20] <Reedy>	 [00:39:20] <pde> we're having a hack day at Mozilla SF tomorrow:
[01:11:20] <Reedy>	 [00:39:21] <pde> https://effmozillahackathon.hackpad.com/Plans-for-EFF-Mozilla-hackathon-2013-06-20-sngmhwuEElN
[08:18:04] <gerrit-wm>	 New patchset: Yurik; "Zero config sorts & deduplicates showLangs & whitelisted" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69631
[09:57:28] <gerrit-wm>	 New patchset: Zfilipin; "Updated Ruby gems" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69636
[15:19:27] <gerrit-wm>	 New patchset: Zfilipin; "Zeljko review not merging" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[15:28:08] <gerrit-wm>	 Change abandoned: Zfilipin; "moving useful code to https://gerrit.wikimedia.org/r/#/c/64473/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64500
[15:32:25] <gerrit-wm>	 New patchset: Zfilipin; "Feature: Setting User Agents" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[16:14:30] <gerrit-wm>	 New patchset: Zfilipin; "Feature: Setting User Agents" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[16:19:36] <gerrit-wm>	 New patchset: Zfilipin; "Feature: Setting User Agents" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[16:21:40] <gerrit-wm>	 New review: Cmcmahon; "merging" [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/64473
[16:24:28] <gerrit-wm>	 New review: Cmcmahon; "check" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[16:24:29] <gerrit-wm>	 Change merged: Cmcmahon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64473
[16:59:18] <brion>	 just got off subway be there in 5m
[17:03:20] <YuviPanda>	 awjr: isn't the planning meeting supposed to start now?
[17:03:30] <YuviPanda>	 or did I get my tz math wronnng
[17:03:31] <YuviPanda>	 ?
[17:03:33] <awjr>	 yes it is YuviPanda
[17:03:39] <awjr>	 hop on the hangout :)
[17:03:41] <YuviPanda>	 awjr: I have no invite
[17:03:44] <awjr>	 wat
[17:03:48] <YuviPanda>	 yeah
[17:03:50] <awjr>	 oh no
[17:03:56] <YuviPanda>	 was wondering why I never got a reminder from calendar
[17:04:04] <YuviPanda>	 add me awjr?
[17:04:08] <awjr>	 just did YuviPanda
[17:04:25] <YuviPanda>	 awjr: sweet, hopping on
[17:04:33] <awjr>	 sorry about the YuviPanda :(
[17:04:46] <YuviPanda>	 awjr: if there's an invite for tomorrow's thing, add me too
[17:04:46] <YuviPanda>	 :)
[17:04:57] <awjr>	 beat you to it YuviPanda
[17:06:23] <YuviPanda>	 awjr: :)
[17:06:53] <awjr>	 jgonera: we're i r37
[17:08:10] <YuviPanda>	 tfinc: is that natural lighting outside that door?!
[17:08:27] <yurik>	 dfoy, dr0ptp4kt sorry, had tons of networking issues today
[17:08:37] <yurik>	 back somewhat :)
[17:09:02] <dfoy>	 yurik: np, I was delayed due to traffic anyway
[17:09:05] <dr0ptp4kt>	 yurik, i believe all three of us had issues. dfoy traffic, you internet, me brain.
[17:11:24] <gerrit-wm>	 Change abandoned: Mgrover; "cleaned this up but putting it into the original request" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64510
[17:12:02] <gerrit-wm>	 Change abandoned: Mgrover; "cleaned these up in a different commit" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/64508
[17:12:15] <YuviPanda>	 awjr: can you ask howie to be closer to the mic next time? I can hear maryana very clear, but not howie.
[17:12:30] <awjr>	 sure thing YuviPanda
[17:26:41] <awjr>	 YuviPanda: can hear howie ok now?
[17:26:46] <YuviPanda>	 awjr: yes! Thank you
[17:26:49] <awjr>	 :)
[17:28:34] <jdlrobson>	 MaxSem: Geodata keeps shrinking the amount of things nearby to me :(
[17:28:40] <jdlrobson>	 only 6 articles nearby me right now :(
[17:28:54] <MaxSem>	 damn people editing pages...:P
[17:29:43] <jdlrobson>	 anyway we can fix this? worries me … :( it was 9 yesterday
[17:29:48] <jdlrobson>	 maybe tomorrow nothing will be nearby?! :D
[17:29:53] <awjr>	 is there a bug open for that?
[17:30:18] <MaxSem>	 I promised to open one yesterday
[17:32:08] <YuviPanda>	 jdlrobson: have you checked to make sure that those places are still nearby?
[17:32:36] <jdlrobson>	 YuviPanda: it asks for up to 50 things within 10km
[17:32:46] <jdlrobson>	 i'm sure in downtown sf there are more than 6 that match that :)
[17:33:52] <MaxSem>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=49893
[17:35:22] <awjr>	 MaxSem: should i configure bingle to pull in bugs for geodata?
[17:35:41] <MaxSem>	 you could:)
[17:35:47] <awjr>	 ok, it's on my todo list :)
[17:36:50] <jdlrobson>	 awjr: MaxSem looking for a keyword mobile would be better - i just raised a centralauth bug
[17:37:04] <awjr>	 hmm could do both
[17:41:59] <jdlrobson>	 oohh this is awesome http://imgur.com/paS28XO which team did this?
[17:43:24] <brion>	 niiiiice
[17:45:40] <awjr>	 i would guess that was an e3 thing but not sure
[17:50:31] <gerrit-wm>	 New review: Dr0ptp4kt; "The banners use <div>s, <span>s, and <button>s in the WML output _before_ the search box instead of ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69603
[17:57:21] <tfinc_>	 jdlrobson: i'm sure maryana would know
[18:03:24] <yurik>	 dfoy, have you had a chance to look at the other config pages i sent you an email about?
[18:04:00] <yurik>	 would be good to submit changes to varnish all at once
[18:05:59] <dfoy>	 yurik: Yes I'll do the housekeeping tasks there but it may not be until much later today
[18:11:33] <YuviPanda>	 brion: send new hangout link?
[18:12:57] <YuviPanda>	 tfinc: bew hagnout link?
[18:12:58] <YuviPanda>	 err
[18:13:00] <tfinc>	 YuviPanda: i'm inviting you to a hangout now
[18:13:02] <YuviPanda>	 new hangout linK?
[18:13:02] <YuviPanda>	 ok
[18:14:05] <tfinc>	 YuviPanda: https://plus.google.com/hangouts/_/0e208bb0f7cffe9ae7d43385c98453a79581a1cc?authuser=0&hl=en
[18:14:31] <YuviPanda>	 tfinc: doing the 'relogin' dance, gimme a min
[18:14:47] <tfinc>	 awjr_away: we were rebels and just went to the collab area. feel free to free up R64
[18:16:05] <awjr>	 tfinc: are you guys in r66?
[18:16:10] <awjr>	 oh ok perfect thanks
[18:16:17] <awjr>	 tfinc which collab? on 6 or 3?
[18:16:27] <brion>	 awjr, we're out in collab space 3rd
[18:16:27] <awjr>	 (i have them both reserved
[18:16:27] <tfinc>	 3
[18:16:27] <awjr>	 kk
[18:17:14] <YuviPanda>	 brion: tfinc definitely at least a 10s lag.
[18:17:20] <brion>	 ouch
[18:17:24] <brion>	 yeah we're moving to a wired connection
[18:18:43] <brion>	 remember when you didn't need a dongle for ethernet?
[18:18:46] <brion>	 yeah those were the days
[18:18:51] <YuviPanda>	 haha :P
[18:21:02] <brion>	 we're going upstairs it sounds like :(
[18:23:20] <brion>	 YuviPanda, join the standup hangout link fr tomorrow
[18:23:26] <brion>	 well use that hangout
[18:23:26] <YuviPanda>	 lol k
[18:23:43] * YuviPanda  goes to find that

[18:52:51] <Reedy>	 db1049 doesn't seem happy
[18:53:04] <Reedy>	 Most of the queries are SpecialMobileWatchlist
[18:53:07] <Reedy>	 awjr: ^
[18:53:24] <awjr>	 hmmm i thought we fixed a problematic watchlist query a coupla weeks ago
[18:53:39] <awjr>	 Reedy: are they all basically the same?
[18:53:50] <awjr>	 i reproted in ops a bit ago that we were seeing 504s and 503s
[18:53:56] <Reedy>	 Yup
[18:53:58] <Reedy>	 SELECT /* SpecialMobileWatchlist::doFeedQuery MGalloway (WMF) */  `recentchanges`.*,ts_tags,fp_stabl
[18:54:10] <Reedy>	 Numerous users with numerous sql queries on sending data
[18:54:25] <Reedy>	 80-90% of the queries seem to be mobile watchlist
[18:55:02] <awjr>	 MaxSem: ^^
[18:55:09] <awjr>	 Reedy: can you do an explain on one of those"
[18:55:09] <awjr>	 ?
[18:55:11] <MaxSem>	 yeah, already looking
[18:55:14] <Reedy>	 Nope
[18:55:21] <Reedy>	 It only shows a truncated query
[18:55:27] <YuviPanda>	 hehe, everytime we have a large-ish meeting we have one of these, don't we? :)
[18:55:59] <MaxSem>	 grrrr, Ishmael is so slowwwwww
[18:56:09] <tfinc>	 YuviPanda: https://plus.google.com/hangouts/_/calendar/cmZhcnJhbmRAd2lraW1lZGlhLm9yZw.3oqmqj04i09lbeug37e4n4rtn0
[18:56:27] <Reedy>	 awjr: Got it
[18:56:30] <awjr>	 sweet
[18:56:37] <Reedy>	 http://p.defau.lt/?DS8zBJt47ttbDeEn8leQeA
[18:57:11] <Reedy>	 There's a few normal watchlist queries in "Copying to tmp table"
[18:57:23] <tfinc>	 awjr: Campaigns and Micro contribs are winding down
[18:57:34] <tfinc>	 awjr: are we meeting before breaking for lunch ?
[18:57:35] <awjr>	 cool tfinc, hang tight - lunch should be arriving shortly
[18:57:42] <awjr>	 nah, let's break for lunch and we'll reconvene after
[18:58:13] <tfinc>	 awjr: what time should we be back from lunch then ?
[18:58:18] <tfinc>	 and who's bringing lunch ?
[18:58:59] <YuviPanda>	 tfinc: https://www.wikidata.org/wiki/Wikidata:Cultural_heritage_task_force
[18:59:03] <YuviPanda>	 is the wikidata stuff
[18:59:05] <YuviPanda>	 for WLM
[19:00:51] <YuviPanda>	 mhurd: https://www.mediawiki.org/wiki/User:Yuvipanda/Mobile_campaigns
[19:00:52] <awjr>	 tfinc: lunch should arrive at noon
[19:00:57] <awjr>	 rachel coordinated the order
[19:01:01] <awjr>	 we'll be down in a minute
[19:01:03] <tfinc>	 k
[19:02:31] <YuviPanda>	 jdlrobson: hehe, nobody trying to get your autograph while having lunch :P
[19:02:46] <jdlrobson>	 autograph? huh?
[19:03:20] <YuviPanda>	 jdlrobson: some guy asked you to sign his book while we were having lunch in some city...
[19:03:24] <YuviPanda>	 for some reason this reminded me of that
[19:03:24] <YuviPanda>	 ignore
[19:03:30] <jdlrobson>	 oh yeh completely forgot about that
[19:03:32] <jdlrobson>	 that was odd
[19:03:35] <YuviPanda>	 hehe
[19:03:41] <YuviPanda>	 'big in Aurangabad', etc
[19:04:58] <YuviPanda>	 tfinc: jdlrobson i'm going off the hangout, can you ping me on IRC when you guys are done eating?
[19:04:59] <YuviPanda>	 mhurd: ^
[19:05:36] <MaxSem>	 same for me
[19:06:03] <MaxSem>	 Reedy, are you able to load ishmael?
[19:06:29] <Reedy>	 Not tried. Faidon couldn't though
[19:06:45] <mhurd>	 YuviPanda: ok
[19:06:50] <YuviPanda>	 mhurd: ty
[19:22:55] <gerrit-wm>	 New patchset: Jdlrobson; "Update javascript template to reflect changes in PHP" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69756
[19:25:11] <gerrit-wm>	 New patchset: Yurik; "Detect IP conflicts in config pages" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69757
[19:30:09] <jdlrobson>	 YuviPanda: MaxSem
[19:30:46] <gerrit-wm>	 New patchset: Yurik; "Detect IP conflicts in config pages" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69757
[19:31:54] <awjr>	 MaxSem, come on back to the hangout :)
[19:33:43] <gerrit-wm>	 New patchset: MaxSem; "Revert "Force index to avoid filesort in feed query"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69765
[19:33:52] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69765
[19:34:55] <awjr>	 YuviPanda: we're back :)
[19:35:00] <awjr>	 MaxSem: can you hear maryana ok?
[19:35:02] <YuviPanda>	 awjr: yeah, I am too! :)
[19:35:07] <MaxSem>	 yep
[19:35:09] <awjr>	 sweet :)
[19:39:28] <gerrit-wm>	 New patchset: MaxSem; "Revert "Force index to avoid filesort in feed query"" [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/69766
[19:39:50] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (production) - https://gerrit.wikimedia.org/r/69766
[19:40:20] <tfinc>	 YuviPanda: you back on the hangout ?
[19:40:35] <YuviPanda>	 tfinc: yeah, i've been there for 15 m ins now, since before the beginning :)
[19:41:11] <tfinc>	 great. YuviPanda brion mhurd heads up if i haven't said it already. one thing that we'll talk about as a group after this is native wikipedia reader app and wether were going to do it next year
[19:41:35] <YuviPanda>	 wonderful. I've some ideas on that (we should make a 'Wikimedia' app rather than just Wikipedia)
[19:41:51] <tfinc>	 YuviPanda: good. i wanted to prep you guys for it
[19:42:12] <tfinc>	 we'll do this as part of the big picture talk
[19:42:39] <YuviPanda>	 tfinc: nice
[19:45:31] <brion>	 whee
[19:45:40] <brion>	 i'd use the Wikipedia branding though. nobody knows what a Wikimedia is :)
[19:47:21] <YuviPanda>	 brion: true, but idea is to integrate more into WikiData + Commons + Interwiki
[19:47:36] <brion>	 yes that sounds lovely :D
[19:47:38] <YuviPanda>	 brion: imagine surfacing Wikidata info side by side, and letting people explore out in a graph manner
[19:47:38] <YuviPanda>	 yeah
[19:47:43] <brion>	 nom nom nom
[19:47:49] <brion>	 wikidata + microcontributions
[19:47:53] <YuviPanda>	 brion: indeed.
[19:49:42] <YuviPanda>	 brion: https://gerrit.wikimedia.org/r/#/c/69770/
[19:50:43] <brion>	 heh
[19:50:52] <brion>	 dismissable progress dialog seems .... like a bad default ;)
[19:51:33] <YuviPanda>	 brion: yeah, surprised me when I was showing off to a friend a few days ago
[19:51:51] <YuviPanda>	 brion: it also only hides the dialog, doesn't actually cancel the operation
[19:51:54] <YuviPanda>	 so... weird
[19:52:11] <YuviPanda>	 awjr: who is talking?
[19:52:20] <brion>	 YuviPanda, kaldari
[19:52:20] <awjr>	 ryan kaldari
[19:52:24] <YuviPanda>	 ah, ok
[19:53:19] <brion>	 YuviPanda, when you have a chance please give me feedback on https://gerrit.wikimedia.org/r/#/c/69606/ :)
[19:53:21] <brion>	 no rush
[19:54:13] <YuviPanda>	 brion: will do! At the back of my mind I'm trying to figure out how we should relase it, I want us to have at least one beta cycle with that patch in before we push to '1.0'
[19:54:40] <brion>	 ok
[19:54:41] <yurik>	 dfoy, is the meeting on today/
[19:54:49] <yurik>	 re nokia?
[19:55:05] <dfoy>	 yurik: I've requested an email update since I'm in a different meeting today
[19:55:11] <dfoy>	 yurik: no response back yet
[19:55:21] <dfoy>	 yurik: no need to attend though
[19:56:03] <awjr>	 everyone hearing howie ok, MaxSem YuviPanda?
[19:56:16] <YuviPanda>	 awjr: yeah, mostly. could be a little better tho :)
[19:56:33] <YuviPanda>	 awjr: much better! :)
[19:56:34] <awjr>	 better YuviPanda?
[19:56:35] <awjr>	 :)
[19:56:42] <YuviPanda>	 ty
[20:04:47] <YuviPanda>	 brion: can't hear you :P
[20:05:31] <brion>	 YuviPanda, just told jared to look up 'wiki takes manhattan' for background
[20:05:35] <brion>	 i'll be louder next time ;)
[20:05:39] <YuviPanda>	 brion: yeah ;)
[20:06:05] <awjr>	 jdlrobson: pm
[20:07:09] <brion>	 hope i didn't mumble too bad
[20:09:33] <YuviPanda>	 heh, i never had to talk 'coz brion and tfinc covered pretty much everything
[20:09:42] <tfinc>	 :)
[20:12:05] <awjr>	 MaxSem, YuviPanda are you guys hearing a lot of the construction noise outside? or more to the point… are you hearing tomasz OK?
[20:12:07] <YuviPanda>	 tfinc: "Write once, debug everywhere" - PhoneGap
[20:12:18] <YuviPanda>	 awjr: yeah, hearing tfinc okay. Don't hear construction noise at all
[20:12:19] <MaxSem>	 no/yes
[20:12:25] <awjr>	 wow, aewsome
[20:12:37] <awjr>	 im having a hard time hearing tomasz over the construction noise outside :p
[20:12:40] <YuviPanda>	 hahaha
[20:13:43] <YuviPanda>	 brion: closer to the table?
[20:15:02] <tfinc>	 YuviPanda: you going to jump in on this ?
[20:15:08] <tfinc>	 you should*
[20:15:10] <YuviPanda>	 tfinc: yes, waiting for a pause at some point :D
[20:15:44] <YuviPanda>	 tfinc: damn, hangout dropped. refreshing.
[20:15:46] <YuviPanda>	 back in a moment
[20:16:58] <YuviPanda>	 tfinc: I'm talking, can you guys not hear me?
[20:16:58] <YuviPanda>	 awjr: ^
[20:17:01] <tfinc>	 YuviPanda: nope
[20:17:11] <awjr>	 you may have been auto-muted YuviPanda
[20:17:17] <YuviPanda>	 i checked i wasn't
[20:17:18] <YuviPanda>	 grr
[20:17:24] <awjr>	 :(
[20:20:24] <brion>	 aww
[20:21:07] <brion>	 \o/
[20:27:59] <YuviPanda>	 brion: yeah, -2 for any UI that's not native
[20:28:42] <awjr>	 jdlrobson: see my pm?
[20:39:05] <awjr>	 tfinc: we've got about 22 minutes left - should we wrap up this convo and move on to minerva, etc or keep going forward with this?
[20:42:56] <YuviPanda>	 brion: +1
[20:46:58] <YuviPanda>	 tfinc: yeah, makes sense to me (2Qs for Commons, and then figure out right after)
[20:47:10] <brion>	 yeah
[21:01:55] <YuviPanda>	 brion: at some point you should blog about PhoneGap :)
[21:02:04] <YuviPanda>	 (different than that email to wikitech-l, I think)
[21:17:16] <YuviPanda>	 brion: i'm going to head off in bout 10 mins, want anything before that?
[21:17:29] <YuviPanda>	 brion: I'll look at the patch tomorrow, left some minor nits today there on GitHub
[21:17:37] <YuviPanda>	 (So much more easier to review code on GitHub) :D
[21:17:44] <brion>	 ok
[22:36:01] <gerrit-wm>	 New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/69756
[22:42:42] <Krinkle>	 jdlrobson: there's 44 resource loader modules registered on target=desktop for 'mobile'.
[22:43:07] <Krinkle>	 Perhaps a bit too much? Even for mobile they should probably be merged (separating classes in files is fine, but a separate module for each seems excessive)
[22:43:35] <Krinkle>	 and even then, they're probably not intended to be targetted to desktop, right?
[22:50:20] <jgonera>	 Krinkle, 44 resource loader modules registered on target=desktop for 'mobile'? What does it mean? That we load mobile modules on desktop?
[22:51:10] <Krinkle>	 jgonera: No, that they are registered and making the startup module grow for every request cluster wide
[22:51:25] <Krinkle>	 on the client side
[22:51:37] <Krinkle>	 I thought the idea of target is to not register modules for mobile mobile on desktop
[22:51:47] <Krinkle>	 (only mobile.desktop and some others should be needed)
[22:51:57] <jgonera>	 I see, jdlrobson is there any reason we're registering our modules for target=desktop? Does it have something to do with Minerva?
[22:51:58] <Krinkle>	 and visa versa of course
[22:52:18] <Krinkle>	 It looks like something regressed recently
[22:52:30] <Krinkle>	 en.wikipedia's startup module grew from 20kb to 50kb over the last moth
[22:52:43] <Krinkle>	 almost 200 new modules registered on every request. 90 for wikidata and 50 for mobile.
[22:53:03] <jgonera>	 I suspect that this is part of the effort of making our skin desktop-compatible, but I agree that this is a problem
[22:54:49] <jgonera>	 jdlrobson is now in a meeting I guess
[22:59:48] <jgonera>	 awjr, do JS tests pass for you on master when running them in Chrome?
[23:00:46] <awjr>	 jgonera: will check in a minute, just finishing a mtg
[23:00:51] <jgonera>	 ok
[23:06:47] <gerrit-wm>	 New patchset: MaxSem; "Don't register module called "mobile.device."" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69811
[23:06:59] <MaxSem>	 one module less ^_^
[23:07:57] <jgonera>	 awjr, false alarm, it's fine
[23:11:11] <Krinkle>	 MaxSem: How does that change cause the module not to be registered? Does mf have a module for each file? And that property is set but empty?
[23:11:27] <MaxSem>	 yep
[23:11:35] <MaxSem>	 but wait a sec:)
[23:12:53] <Krinkle>	 Why not remove that property from the array if it is empty? Seems like asking for trouble... or does empty have a special meaning?
[23:12:57] <Krinkle>	 like using a default instead of nothing?
[23:13:32] <gerrit-wm>	 New patchset: MaxSem; "Don't register device modules if not needed" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69812
[23:14:15] <MaxSem>	 -8
[23:16:01] <MaxSem>	 Krinkle, we could remove a lot of modules if RL handled addResourceStyles() properly
[23:16:41] <Krinkle>	 You mean have it be broken? ;P
[23:17:08] <Krinkle>	 You're referring to dependency resolution, right?
[23:17:16] <MaxSem>	 is not a man entitled to have a dream?:P
[23:17:19] <MaxSem>	 y
[23:17:23] <MaxSem>	 es
[23:18:47] <MaxSem>	 if you have a module with styles and scripts, and add styles with the aforementioned function, you will have the second copy of them if you add the scripts with addModules()
[23:19:21] <MaxSem>	 that's why mobile has a lot of mobile.foo.scripts and mobile.foo.styles modules
[23:19:27] <Krinkle>	 That can't be done without having proper javascript interaction. By design we need the variance to avoid breaking pages when modules' content change (no timestamp, filenames, dependencies etc. can be inside the page html)
[23:19:28] <Krinkle>	 brb
[23:20:48] <MaxSem>	 also, what the hell is EmbedPlayer doing in startup?
[23:27:45] <jdlrobson>	 Krinkle: it gets complicated as certain pages (e.g. Special:Nearby work on both desktop and mobile). We do need to clean up our modules however so if you raise a bug I can make sure this gets looked into and trimmed down
[23:28:30] <Krinkle>	 yes, indeed. Though that is nothing new it is a known artefact from the mess of doom that is MWEmbed and anything related from mdale. The code itself is pretty good but it's way of loading it is outdated and could've been better in the first place
[23:28:34] <Krinkle>	 it being seemingly unmaintained now isn't helping
[23:29:07] <Krinkle>	 its*
[23:41:38] <gerrit-wm>	 New patchset: Jdlrobson; "Story 488: Add pageimages to search results (beta)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508
[23:41:38] <gerrit-wm>	 New patchset: Jdlrobson; "Hygiene: Remove unnecessary suggestions-result class" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69815
[23:42:05] <gerrit-wm>	 New patchset: Jdlrobson; "Hygiene: Remove unnecessary suggestions-result class" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69815
[23:49:14] <MaxSem>	 hmm, TMH has jgerber as a default CC in Bugzilla - that's someone from prehistorical times
[23:55:15] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/67508
[23:55:41] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69815
[23:58:01] <MaxSem>	 created https://bugzilla.wikimedia.org/show_bug.cgi?id=49920