[13:46:10] [Commons-iOS] siebrand pushed 1 new commit to master: http://git.io/pYRn7A [13:46:10] Commons-iOS/master 8798361 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [13:48:40] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/f3TykQ [13:48:40] WikipediaMobile/master 2982939 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [16:15:16] eh, forgot about irc [16:15:26] yurik, around? [17:12:29] brion: am I in the wrong hangout for standup? [17:12:45] YuviPanda, we don't start for 3 mnutes do we? [17:12:49] or are you in the web one? [17:12:52] aww, grr. [17:12:54] web guys are still going [17:12:55] no I'm in the correct one [17:12:56] then [17:13:08] heh [17:21:14] hey dr0ptp4kt - why does Zero add banners on MinervaPreRender instead of GetMobileNotice? [17:21:44] Maryana: it seems likely that some of the bugs are not prioritized correctly in the 'ready for development' column for this iteration. when you have a second, can you double check priority orders? (ps i moved #872 close to the top since it's a blocker for #883 which jgonera has already started working on) [17:22:58] MaxSem, from what i could tell, only MinervaPreRender granted easy access to wipe out the entire banner (e.g., if CentralNotice or other banners are runnning). [17:24:09] mmm, you have access to a string - you can replace it instead of appending [17:24:23] awjr, sure thing [17:24:29] Maryana: thanks! [17:24:40] and now you're trying to run a minerva-specific hook from an unrelated class [17:27:47] MaxSem, yeah, didn't like doing that :) restarting ide, and am going to take a look at whether the preconditions and postconditions are met. one thought i had was passing additional context in GetMobileNotice, but again, lemme take a look at the preconditions and postconditions for hook execution. will add it to my task list, too, so i don't forget about it if i get sidetracked! [17:28:56] tfinc, any clarity on Ryan's schedule of joining us? Any chance it will happen before awjr's vacation?:P [17:29:05] July 1st [17:29:28] so, the day before vacation starts :p [17:29:46] weee:) [17:30:09] MaxSem: kaldari should be able to help out a bunch with PHP review (esp once he starts to wrap his head around the code base) [17:30:29] yes, that was the soonest time he could wrap up flow and have some vacation time [17:30:39] anything else would have meant he would have had to juggle two things at once and i didn't want that [17:30:51] New review: MaxSem; "Please don't call Minerva-specific hooks from WML. Instead, GetMobileNotice shouls be used." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/69603 [17:30:51] he needs a clean break and july 1st fit great with that [17:32:33] awjr, bugs 872 & 843 look to be dupes [17:32:42] * awjr looks [17:33:07] yeah they are - the bug must've had a title change [17:33:23] Maryana: keep 843 [17:33:28] it's the most up to date title [17:33:39] oh wait, they have the SAME title! [17:33:40] argh! [17:33:51] but one says blocked and one doesn't [17:33:57] oh [17:34:01] good point [17:34:10] that's probably what caused the dupe entry in mingle [17:35:26] ok Maryana i cleaned it up [17:35:28] brion: reviewing android stuff now [17:35:33] sweet, thx [17:36:05] spiff [17:36:37] ok, reprioritized, awjr [17:36:58] w00t [17:37:00] thanks Maryana! [17:38:36] brion & YuviPanda, what are Apps' plans regarding this year's WLM? [17:39:05] MaxSem: we don't have a solid plan yet. We've not made any promises either. [17:39:09] tfinc: ^ [17:39:41] MaxSem: no plans for supporting WLM [17:40:14] okay, so no need to worry about monuments API this year:) [17:40:22] last year we saw very low contribution amounts through wlm relative to the amount of work that we put in [17:40:24] anyone want some of these if i order a few for myself? : http://www.monoprice.com/products/product.asp?c_id=112&cp_id=11213&cs_id=1083101&p_id=10557&seq=1&format=2 [17:40:41] (4 inch lightning cables) [17:42:14] mhurd: feel free to expense those [17:42:37] tfinc: ah. thanks! [17:44:05] i want wireless :D [17:48:40] the plural of "virus" is "viruses" [17:49:03] "virus" is not latin. even if it was, in latin, "virii" means "men" - the plural form of "vir", meaning "a man" [17:49:43] actually [17:49:45] virus is latin [17:49:48] but it's 4th declension [17:49:53] the plural is "virus" [17:50:14] jorm, Wikipedia disagrees [17:50:27] "The word is from the Latin virus referring to poison and other noxious substances, first used in English in 1392." [17:50:30] man, this was a whole major thing when I was at organic and we had McCaffee as a client. [17:50:46] and i'm gonna be pissed if i was right. [17:51:31] okay. the plural *is* viruses, though. [17:51:50] MaxSem did you ping? [17:51:51] not in l33t5p3ak [17:52:07] man. the fact that the wiktionary link is buried at the bottom sucks. [17:53:36] yurik, already got the answer from Adam [18:09:03] can someone pass me the gitweb link for MF. this no longer works https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=tree;h=refs/heads/master;hb=refs/heads/master [18:09:26] tfinc: https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FMobileFrontend.git [18:09:32] thanks [18:19:00] New patchset: Jdlrobson; "When receive bad file name errors print filename in error response" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70221 [18:19:00] New patchset: Jdlrobson; "Don't allow consecutive apostrophes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70222 [18:19:10] New patchset: Jdlrobson; "Bug 49544: Allow margin of error in filename generation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70223 [18:19:10] New patchset: Jdlrobson; "Prevent uploading of anything other than images" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70224 [18:28:00] New patchset: JGonera; "Open first section in editor when lead section empty" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70225 [18:28:32] * MaxSem pokes jdlrobson [18:31:52] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70225 [18:32:57] hey MaxSem what's up [18:33:45] jdlrobson, so what's your vision of https://gerrit.wikimedia.org/r/69336 alternatives? [18:34:42] So MaxSem firstly I'm not sure why we are spending time rearchitecting SkinMobileWML right now… it's not in the iteration and has no bug. I agree that WML needs its banners back but I'm not sure how that fits into the priority of this iteration [18:34:56] as a result I haven't had too much time to think around it [18:35:34] the change is intended to get rid on ExtMobileFrontend dependency [18:35:52] s/on/of/ [18:36:10] but fundamentally I worry about the complexity of having too much skin inheritance [18:36:18] we recently got rid of SkinMobileBase for that reason [18:36:31] and separated SkinMobileWML to avoid breaking the WAP site with changes to the mobile site [18:36:49] yeah, and we broke the WML view badly inprocess [18:37:54] yeh but it was broken before that as well. All I'm saying is I'd like to get an idea of how important this is at the moment so I can prioritize accordingly [18:38:20] personally I'd like WAP in a separate extension [18:38:45] I also don't think skin's should have formatters full stop [18:39:06] WAP still needs mobile detection, headers and HTML transformations - it definitely belongs to MF [18:40:45] with this change, I ensured that WAP got all it needed in an uniform fashion [18:41:41] MaxSem: so I guess the question is how does this help unblock 883 and 843 which are blocked on 800? The main pressing thing in this iteration seems to be getting to a stage we can do https://gist.github.com/jdlrobson/5439509#file-gistfile1-diff-L95 so we can do these things [18:41:54] YuviPanda: what do you think of my iterated version of design's monochrome icon? I made it less ….. gray. http://lists.wikimedia.org/pipermail/design/2013-June/000700.html [18:43:11] sigh [18:43:14] * Platonides initially read that brion made it less gay, lol [18:43:21] hah [18:43:29] this icon kisses other icons lol [18:43:53] looks like somebody changed WMF-Guest's password. nice. [18:44:01] * Platonides apologises to the icon for having doubted about its manhood [18:44:11] who says it's a man? [18:44:36] jdlrobson, MaxSem: for the sake of simplicity, sanity, and priorities, let's keep WAP in MF for now. we can focus on migrating it elsewhere at some point in the future [18:44:46] how can a no-man be gay? :) [18:45:14] (wait, does English have a word for 'homosexual its'?) [18:45:26] awjr: MaxSem so as i understand it "we broke wap zero" but i'm not sure what this means and how important this is to fix [18:45:37] my point is that no matter how much we hate it, we still need to support it. moving it to a separate extension will not mean that we don't need to support it [18:45:39] Platonides: oh there'll be pages and pages on wikipedia for that :) [18:45:51] i'd rather not recouple wap with mobile if we can avoid it [18:45:54] Platonides: 'ze' is a gender-neutral pronoun in english (though it's not widely used) [18:46:04] MaxSem: that's fine. this is not my problem. My concern is why are we working on this [18:46:08] and i don't know how 'official' it is… but it's becoming more common :) [18:46:20] No one in Zero has flagged me as an issue yet so i'm not sure what we've broke and how important it is [18:46:59] awjr: i thought ze was just the result of a bad accent? [18:47:00] yurik, dr0ptp4kt: ^^ [18:47:29] awjr, reading... [18:47:41] awjr: and if this zero problem is important there should be a bug open and prioritized alongside other stuff so i can work out what i should be spending my time on [18:47:42] jdlrobson, MaxSem, awjr, yurik: MaxSem identified the issue. what needs to be put in place is hook invocation such that zero can be told to create the banner. i've put in a patch. MaxSem would like the banner hook for WAP to use GetMobileNotice. so i'm refactoring right now. [18:47:44] jdlrobson, Platonides: interesting reading re pronouns: http://en.wikipedia.org/wiki/Pronominal_gender [18:48:14] so dr0ptp4kt, yurik, MaxSem, jdlrobson: anything mobile web needs to do? [18:48:28] jdlrobson, MaxSem, awjr, yurik: i don't know what the % of hits impact is, but for any matter, the refactored patch will be issued today, and i hope +2'd so that we can restore service for the user on impacted carriers. [18:48:45] nothing on my side just yet [18:48:51] cool dr0ptp4kt, let us know if/when you need help with review [18:49:07] dr0ptp4kt, and what I'm trying to achieve is that things like these didn't happen that often [18:49:22] jdlrobson, MaxSem, awjr, yurik: dfoy is aware of the wap breakage, so the business team has notificaton. MaxSem, good catch, BTW. subtle issue. [18:49:29] jdlrobson, Platonides: in particular: http://en.wikipedia.org/wiki/Pronominal_gender#Invented_pronouns [18:51:42] MaxSem, so what happened and how a common abstract skin class helps in resolving it? I'm just afraid that if we have common code for normal site and wap, we are more likely to break wap since we're not testing it (or are we?) [18:52:44] jgonera, the practice (we broke WAP while decoupling it) speaks otherwise [18:54:19] anyway, we need to move forward. jdlrobson, how about a base class for templates to solve the formatter issue? [18:59:34] brion: sorry, was in meeting [19:00:09] brion: well, it's better than the greyed out one (which looked to me like 'this icon is disabled') [19:00:19] brion: but sitll, we can just as well use the commons colors [19:00:32] brion: the problem with the current icon is definitely not the color [19:01:10] MaxSem: well your base class makes the desktop skin Minerva inherit from mobile… this is weird [19:01:30] the whole point of SkinMinerva was it could be moved out of MobileFrontend at any point and showcase what could potentially be upstreamed [19:02:25] MaxSem: i don't think "we broke wap" so we should recouple them is the right way to think about this [19:02:57] if it's just banners we broke why are we moving all this other stuff in [19:03:07] nah, it would inherit from a class that defines a basic interface for section-transforming template. I *need* some sort of common ground to prevent breaking the API [19:03:54] we broke not only banners btw, also HTMl processing - which is much more severe as it results in Zero users paying money [19:05:19] ^ jdlrobson, MaxSem, awjr, yurik: my patch to MobileFrontend adds the BeforePageDisplay into the WML skin. [19:05:40] s/BeforePageDisplay/BeforePageDisplay hook implementation/ [19:05:54] s/implementation/call/ !!! [19:06:16] s/understood/confused [19:06:29] s/// [19:06:39] s/./ [19:06:52] btw jgonera awjr MaxSem tfinc_ another win https://twitter.com/hamishmckenzie/status/348846668789194752 [19:07:02] :) [19:07:56] MaxSem: to be honest I'm totally confused about the problems we are addressing here - maybe you should work on a separate branch so the why you are making these changes becomes clearer [19:08:40] jdlrobson, every commit is a separate branch in gerrit;) [19:09:05] MaxSem: yeh but i can't see the end goal so to me i don't see what value it is giving - all i see is argggh the skin code is getting more messy and a nightmare to manage [19:09:10] (and broken Minerva desktop skin) [19:09:18] awjr, the only change in https://gerrit.wikimedia.org/r/69585 is a rebase - can we attempt to merge it once again? [19:09:41] aye MaxSem; im in a meeting now but can take a look later [19:10:25] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69812 [19:12:37] brion: left comments :) [19:12:38] New patchset: Jdlrobson; "Prevent uploading of anything other than images" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70224 [19:12:45] tx [19:14:44] brion: :) [19:15:03] brion: major thing being use of explicit dp values [19:15:27] YuviPanda: will wrap_content work as i expect for sizing those images to their natural size? [19:15:57] brion: yup, wrap content does it assuming you have put the appropriate sized ones on drawables [19:16:11] brion: also you'll want to use relativelayouts + perhaps a scrollview, rather than a framelayout [19:16:31] New patchset: Jdlrobson; "Refactor nearby into reuseable modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70235 [19:16:31] New patchset: Jdlrobson; "Alpha: Surface nearby articles" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70236 [19:17:05] YuviPanda: not sure i understand hat's wrong with the frame layout? [19:17:23] brion: no, because with relative layouts you can do positioning easier [19:17:45] brion: and can avoid overlapping stuff with a scrollview [19:17:51] brion: hmm, perhaps not required here. [19:17:59] i'm lost, where would i want a scrollview? [19:18:27] brion: overlapping viewpager + text? [19:18:39] brion: hmm, actually, ignore everything I said about scrollview + relative layout :) [19:18:48] hehe [19:19:03] brion: but yeah, the overlapping is a problem that needs fixing. [19:19:17] brion: the code otherwise looks alright (with one nitpick about location of a clickhandler) [19:19:24] hmmmmmm [19:19:37] wrap_content ain't working for me so far. do i have to manually specify the size of the image somewhere? [19:20:32] New patchset: MaxSem; "Don't register module called "mobile.device."" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69811 [19:21:14] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69811 [19:22:25] brion: hmm, try adding adjustbounds = true for the imageview? [19:22:44] doesn't seem to help [19:22:46] * YuviPanda looks at code agian [19:23:17] tfinc: http://commons.wikimedia.org/wiki/File:Mobile_Update_(June_2013).pdf [19:23:20] jgonera: you'll like this one https://twitter.com/lucasshrew/status/349153648347078656 [19:27:04] brion: are you using any of the scale parameters? [19:27:09] brion: is it just not showing up? [19:27:42] brion: if you're not using any of the scale paramters, try using one? [19:27:48] YuviPanda: it seems to scale up to the width of the screen [19:27:53] tried several, all wrong so far [19:28:25] even with wrap_content? [19:28:27] of course this is assuming the renderer in android studio isn't fucked up [19:28:31] are the images properly sized/ [19:28:34] brion: oh, don't rely on that! [19:28:35] only with wrap_content, didn't try anything else [19:28:35] yes [19:28:36] at all! [19:28:37] 240x240 mdpi [19:28:37] no no no [19:28:42] 360x360 hdpi [19:28:44] see it on device! [19:28:44] 480x480 xhdpi [19:28:50] don't trust the renderer! [19:28:52] will try that next. just…. much slower to try them all [19:28:56] IIRC it's a re-implementation [19:29:00] not a straight port [19:29:02] that's pretty shitty [19:29:27] yeah, that's why I'm still on IntelliJ :P [19:29:42] plus gradle still needs work [19:29:48] i wish i still had my old desk [19:29:52] i hate the new desks [19:29:57] 3rd floor is too fucking cramped [19:30:40] yeah, looks like the renderer's fucked [19:30:41] siiiiiiiiiigh [19:33:04] YuviPanda: for landscape should i make the images smaller, maybe? [19:33:16] which…. probably means setting an explicit size on them, or else copying the images at smaller size ;) [19:33:16] brion: I think we should move them sideways [19:33:25] brion: for landscape, move it left/right [19:33:26] hmmmmmmm, that could work [19:33:29] brion: portrait, top-bottom [19:33:43] yup [19:33:43] brion: you can create a folder called 'layout-land', create same named layout files in there, and just swap orientation [19:33:47] brion: should load automagically [19:34:02] +1 [19:34:08] brion: YuviPanda mhurd : were looking at http://mobile-reportcard.wmflabs.org/graphs/successful-logins and im curious how often do app uses have to re-login ? [19:34:28] on android pretty much never [19:35:12] just when reinstalling [19:35:14] or changing password i guess [19:35:17] in fact the user can't actually re-login :P they have to delete their old account and re-install [19:35:26] heh [19:35:29] brion: changing password doens't throw up login window. That's a bug that's filed and just sitting htere [19:37:12] YuviPanda: would it be hard to add a uploader daily to the report card ? [19:37:25] 'uploader daily'? [19:37:48] YuviPanda: we have upload monthly but not uploader daily [19:37:59] YuviPanda: we have uploader* monthly but not uploader daily [19:38:11] we had them, but I think jgonera removed them at some point [19:38:17] should be easy to bring that back, I think? [19:38:44] tfinc, I guess the story told me to remove it, but I can bring it back [19:39:05] jgonera: how hard would it be to get it back? [19:39:14] and which team is the right one for the story ? [19:39:37] tfinc, not too hard I suppose, if Limn doesn't misbehave, then half an hour at most [19:39:57] uh, no idea, you mean apps or web? any, it's either me or YuviPanda [19:40:05] jgonera: how is your time this week to get it in ? [19:40:18] tfinc, I can get it back later today [19:40:21] I think it'll be easier for jgonera, since I never managed to get a working limn local instance. [19:40:24] jgonera: thanks [19:40:30] sure [19:40:59] tfinc, uploader daily, not the average from 30 days, right? [19:41:18] now that I'm thinking, have we ever had a graph like that? or it was only the 30-days one? [19:41:21] I'd actually like both, since the average 30 shows trends. [19:41:29] (that doesn't change the difficulty much) [19:41:45] plus the current graph is impossible to read [19:41:55] YuviPanda, I guess Maryana decided that the monthly one also shows trends [19:41:55] i've no idea how many android uplaods there were [19:41:58] which one? [19:42:13] New patchset: Yurik; "removed 'disabled' and 'wmf' from the script" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/70244 [19:42:21] jgonera: 'unique uploaders per month' [19:42:38] the bar graph. i've no idea how many uploaders there are without clicking through to the CSV [19:42:53] YuviPanda, you just hover the right month and the legend updates [19:43:08] hmm, didn't notice that before [19:43:09] still [19:43:11] or am I misunderstanding? [19:43:19] no you are correct. I just didn't notice that before [19:43:30] still, would be nice to have both of them back, jgonera :) [19:43:43] ok, I'll try to get them both if I have time [19:43:56] jgonera: <3 [19:43:56] ty [19:44:49] hm, however, we should consult this with Maryana, where should it go now? to the Uploads monthly tab? [19:44:59] uploads daily [19:45:20] since it's a daily metric :) [19:52:43] YuviPanda: some updates on https://github.com/wikimedia/apps-android-commons/pull/20 [19:52:48] brion: looking! [19:52:49] do we really need LDPI images? [19:53:04] brion: we should, yes. [19:53:09] meh ok [19:53:43] brion: unless we decide 'we are no longer going to support ldpi phones' at which point we can get rid of all of 'em [19:55:42] YuviPanda: well it'll scale em down [19:55:47] good enough :) [19:55:52] and all i'm doing is scaling em down :P [19:56:05] goood enough [19:56:12] yay [19:56:20] lemme boot up an emu just to see tho [19:56:23] jdlrobson: i just saw your comment on the languages bundled in HTML bug - should we deprioritize it for this iteration (why was it prioritized for this iteration in the first place? it seems outside the scope of the stuff we're working on) [19:56:25] ? [19:56:42] awjr: it was tied to promoting the language overlay [19:56:51] oh that makes sense [19:56:58] jdlrobson: is it necessary for promoting the overlay? [19:57:07] the language overlay /can/ be promoted without it but is likely to need a big rewrite in future [19:57:23] brion: :) [19:58:02] jdlrobson: what would the impact of not addressing the bug now be if we promote the overlay to stable? [19:58:19] second page is reallllly cramped, but it'll do for now :) [19:58:20] silly ldpi [19:58:29] awjr: the main issue is code debt [19:58:40] awjr: actually now i think again about this we /could/ introduce a new action value - action=languages that shows them [19:59:10] jdlrobson: well we already have the debt, right? so not doing it would leave us in the same place we're in now? [19:59:18] awjr: correct [19:59:43] jdlrobson: if there's a quick way to take care of it, we should probably do it now but if not, i dont think it should slow down promoting the language overlay [20:00:00] awjr: agreed [20:00:13] i was playing around with the code to see if that was feasible but alas i don't think it is [20:00:26] Maryana should weigh in, but I'd really like to see us get all the features promoted so we can kick off the new (fiscal) year with a bit of a tabula rasa [20:00:55] probably worth descoping from this iteration [20:01:39] cool let's do it then, jdlrobson [20:02:01] brion: looks cool brion :D doing some more testing [20:02:04] and then will merge [20:02:05] jdlrobson: is there a wiki page or something somewhere tracking the things we need to be focussing on for hygiene etc? [20:02:14] brion: also on iOS, does this come before or after login? [20:02:31] brion: also does it also have only these 3 steps? [20:02:35] * MaxSem pulls out a thumb drive out of washing machine [20:03:09] hahaha MaxSem i've done that before - numerous times, and fortunately have never had a problem [20:08:12] brion: we should do a release soon [20:11:46] brion: it still has hardcoded widths? [20:12:04] YuviPanda: only on the one page so far as i know [20:12:11] and that's because i don't know of a way to say "show at half size" [20:13:16] * YuviPanda looks some more [20:18:14] brion: actually i see hardcoded values on layouts? [20:18:27] final, copyright.. [20:18:33] even on the textview? [20:18:44] YuviPanda: you mean the padding? [20:19:14] brion: nope. Commented there [20:19:22] New patchset: Dr0ptp4kt; "Reinstate WML support for Wikipedia Zero." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69603 [20:19:57] no idea [20:20:07] ah [20:20:17] so they don't get really long and look like shit on tablet, probably [20:20:47] New patchset: Dr0ptp4kt; "Add extra WAP preprocessing. Independent change, but requires 69603 for effect." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69824 [20:22:04] ^^ MaxSem, jdlrobson, yurik: please review 49603 and 69824 for the wap-centric stuff. cc: awjr [20:22:22] brion: ah, hmm. [20:22:41] could maybe use maxwidth or something if that's available [20:23:30] brion: it is, yeah. we should use that for clarity [20:24:29] brion: okay, 1. remove unused autogenerated ids 2. make all hard-coded numbers to be fractions / multiples of 48dp [20:24:32] and then we can merge it :) [20:24:51] whee [20:25:20] brion: and we should get the icon sorted out so we can do a release. no releases for 2 months now :( [20:26:18] New patchset: Dr0ptp4kt; "Add extra WAP preprocessing. Independent change, but requires 69603 for effect." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69824 [20:32:37] brion: poke when updated :) [20:32:44] ok [20:39:37] YuviPanda: ok pushed some updates [20:39:45] ok looking [20:39:48] didn't change all the hardcoded sizes (image-related ones are image-related, i don't wanna mess with em) [20:39:58] but i did change the 240dp widths to wrap_content and used maxWidth [20:40:05] seems to work :) [20:42:13] brion: :) ok [20:46:05] brion: okay, looks good to me :) [20:46:08] brion: did you test it on a tablet? [20:46:11] \o/ [20:46:18] yeah but lemme double-check the latest build [20:46:38] brion: :) [20:47:08] doesn't explode yay [20:47:34] :D [20:47:39] brion: rotate it 'round and 'round? [20:47:44] and see if that still doesn't explode? [20:48:16] round n round n round [20:48:25] MaxSem, jdlrobson, yurik, i meant change 69603 (not 49603) and 69824. cc: awjr [20:50:06] brion: let me know if it doesn't blow up, I'll merge :) [20:56:58] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69603 [21:05:41] YuviPanda: didn't blow up :) [21:05:51] brion: mmmkay, let me merge! [21:06:06] wheeee [21:08:07] brion: double checking to make sure the bot got everything [21:08:13] ok [21:09:32] brion_: bleh, needs rebase [21:09:40] brion_: let me handle that [21:09:42] thhhhhpt [21:09:43] yay [21:11:48] grrrrrrrrrrr [21:11:58] WML section formatting is a mess [21:16:17] New patchset: MaxSem; "Remove support for api.php?action=parse&mobileformat=wml" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70320 [21:16:45] New review: MaxSem; "Don't merge before tomorrow's deployment." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/70320 [21:18:16] brion_: meh, gerrit sucks [21:18:18] can't push [21:18:20] rebased it tho [21:18:21] lulz, we have an animal theme for our iterations next FY? [21:18:23] * YuviPanda tries again [21:18:23] awjr ^ [21:18:37] :P [21:18:46] hehehe yeah Maryana i forgot to bring it up during planning meetings - i thought it might be easier to remember than numbers. [21:18:54] i like it! [21:19:17] i dunno, i got tired of remembering big cat names for osx ;) [21:19:40] we should start naming them in order of old mw committers [21:19:43] 'magnus' [21:19:45] 'brion' [21:19:45] etc [21:19:48] aww [21:19:57] * brion_ feels old now [21:20:05] git off my lawn [21:20:05] lol [21:20:14] * MaxSem paints brion_'s beard gray [21:20:31] i get gray beard hairs sometimes :( [21:21:39] gasdgjasdg gerrrriititt [21:21:45] brion_: can you do the rebaseing? it's minor [21:21:47] enjoying your gerrit bot? [21:21:48] heh ok [21:21:52] brion_: the bot is fine [21:22:04] brion_: i'm trying to push to gerrit using git review, adn that's the problem [21:22:06] hm it doesn't come up on my outgoing reviews [21:22:09] i'll find it... [21:22:19] brion_: https://gerrit.wikimedia.org/r/#/c/69606/ [21:22:21] awjr: did you get praveena the rollup for our talk on friday? [21:22:29] brion_: plus it's there as a comment on the pull req [21:22:30] tfinc im working on it right now [21:22:55] awjr: great. she just came by asking. i told her that were keeping the 10-6 timeline so that she could mail invites [21:23:18] perfect thanks - i wanted to get the planning recaps done first, but should have the mail for praveena shortly [21:25:09] YuviPanda, ok try newpatchset [21:25:17] New patchset: Jdlrobson; "Sandbox alpha and beta skins from stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70323 [21:25:34] brion_: ok, tessting [21:25:44] 'conflict' in qq/strings.xml :P [21:25:55]