[00:00:25] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70350 [00:00:53] Maryana: ok bingle's fixed, and the fix has been deployed; im giong to clean up the dupes now [00:02:18] Maryana: mingle should be sane again [00:04:24] awesome. thanks, awjr [00:07:36] tfinc, so I just checked, we've never had a unique uploaders per day graph, only the 30-day average. as I understood you're interested in the former? [00:10:25] Maryana, I didn't see your previous reply until now, so I guess tfinc wants a unique uploaders per day which would of course go to Uploads daily tab, but YuviPanda wants unique uploaders over last 30 days, should that go to daily tab too? [00:14:26] New patchset: JGonera; "Update CSS file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70355 [00:15:06] ah, i see, jgonera - i don't care so much about it, but i suppose it should go in daily, too [00:15:13] ok [00:18:49] jgonera: https://www.w3.org/Bugs/Public/show_bug.cgi?id=20246 [00:26:24] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70355 [00:49:09] tfinc, so I just checked, we've never had a unique uploaders per day graph, only the 30-day average. as I understood you're interested in the former? [00:49:18] yup [00:50:42] ok [00:58:57] hey awjr [00:59:22] sorry the 'ext.eventLogging' issue is giving you grief on beta again. i'm baffled as to why it wouldn't manifest on the nonmobile site [00:59:25] but looking into it [01:00:57] awesome, thanks ori-l :) [01:03:28] awjr: do you know what the status of the 'targets' & 'mobileTargets' keys is? [01:03:56] ext.eventLogging declares both, but I recall there was some thought of revisiting these [01:04:09] i don't off the top of my head ori-l, jdlrobson probably does [01:05:09] k, i'll ask [01:15:37] awjr: [01:15:39] // disable event logging module on mobile [01:15:39] if ( !$wgMFLogEvents && isset( $wgResourceModules['ext.eventLogging'] ) ) { [01:15:41] $wgResourceModules['ext.eventLogging']['targets'] = array( 'desktop' ); [01:15:43] } [01:15:49] in MobileFrontend.hooks.php [01:16:18] so if '$wgMFLogEvents' is false you actually tamper with the module definition, which prevents it from registering on mobile [01:16:53] huh, i thought $wgMFLogEvents was true on betalabs, will confirm shortly [01:18:24] doh $wgMFLogEvents is false on betalabs [01:18:49] but… shouldn't that prevent ext.eventLogging from being part of the mobile dependency chain? [01:19:04] yes, but you're not the only game in town :) [01:19:07] navigationtiming depends on it as well [01:19:59] if you unregister a module's availability for mobile, you need to iterate through the dependency tree and unset target=>mobile for anything that depends on it [01:20:01] >_< [01:20:16] i'll file a bug [01:20:29] lemme set wgMFLogEvents = true on betalabs [01:20:40] awjr: already on it :) [01:20:44] badass [01:23:45] aaaand no more errors :) [01:24:18] you are my hero ori-l [01:24:20] thanks! [01:24:24] np! [01:29:44] 'night folks [03:55:43] New patchset: Jdlrobson; "Register sinon as a true global make qunit work without debug=true" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70369 [14:57:04] oh yay, new ios 7 beta just dropped, with ipad support [14:57:18] * brion wanders off to download a couple gigs of xcode [15:00:41] so, brion. look at https://commons.wikimedia.org/wiki/Commons:Wikidata_for_media_info :) [15:01:42] oooh you've been busy [15:02:19] brion: so I talked to the WIkidata folks, but they are planning for this work to start only next year [15:02:25] brion: because of lack of people [15:03:14] brion: and that they would be happy to get some help. [15:03:31] brion: also Wikidata queries are at least a few months away - 'end of year' is the response I got [15:04:12] hmmmm ok [15:23:28] grrrr [15:23:38] ios 7 simulator doesn't include safari, wtf? [15:39:34] don't you hate it when you spend a day working on something, but then facepalm yourself, git stash the whole thing, and fix it in 3 lines of code? [16:00:33] anybody have experience with the Chinese android phones? [16:00:56] I dropped and broke my phone yesterday. Was thinking about getting an HDC One (sic). [16:02:04] ragesoss: ... HDC one? [16:02:05] really/ [16:02:10] offbrand phones \o/ [16:02:35] yeah, it's (obviously) the HTC One clone. [16:02:46] ooh supports dual sim [16:02:50] but it's actually quad core with a nice screen, etc. [16:03:13] comes with free chinese spying in addition to the free US spying! [16:03:19] exactly! [16:03:34] :D [16:03:43] I'll probably just use our retired iphone 3gs for a while. [16:03:54] we'll see how long I can last. [16:03:57] chinese phones are weird. they often beat most brand-name phones by tech specs (they can supprt 3 sims AND TV) [16:04:12] they can be of variously bad quality [16:04:45] there's this sortof half-indian half-chinese one [16:04:47] Micromax [16:04:55] has this S3 / HTC One hybrid [16:04:58] called Canvas 2 HD [16:05:02] is pretty great, for about 250$ [16:05:07] been buying it for all my relatives [16:05:16] it is an 'off brand' phone I can reccomend :) [16:05:17] so the question is how much $$$ and how soon are you prepared to throw it away once it breaks [16:05:34] MaxSem: it's been thrown around for 6 months now, and been doing great [16:06:04] I'll probably be better off getting a used phone on craiglist. [16:07:11] but I'm really curious to try out an offbrand phone, since I got an android tv stick about a month ago and it's been great. [16:07:48] (it runs my quassel-core for irc) [16:08:22] most of the non-Canvas brand Micromax ones aren't that great, though [16:08:44] http://translate.google.com/translate?sl=auto&tl=en&js=n&prev=_t&hl=en&ie=UTF-8&u=http%3A%2F%2Fmysku.ru%2Fblog%2Fothers%2F16231.html [16:10:29] http://www.flipkart.com/micromax-canvas-hd-a116/p/itmdjhwueg4jvtsx?pid=MOBDJSG2SVNDGR72&ref=7760f00c-495e-4d66-930f-73311561776b&srno=t_3&otracker=from-search&query=Micromax%20Canvas%203 [16:47:08] whee http://php.net/?setbeta=1&beta=1 [16:48:05] ooooooh [16:48:09] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/HJadtA [16:48:09] Commons-iOS/master 26e74d2 Monte Hurd: Custom view controller for selecting gallery images... [16:48:09] Commons-iOS/master 02c8cd7 Brion Vibber: Merge pull request #91 from montehurd/multiGallerySelect... [17:23:26] awjr: sorry just saw your message :) [17:23:35] no worries jdlrobson, i got it all sorted out [17:23:44] problem your end? [17:25:27] yeah, something was wonky with my irc bouncer [17:35:28] * brion stabs java in the face [17:36:03] * java installs ask toolbar on brion's computer [17:36:14] lol [17:37:17] brion: what did it do now? [17:37:34] brion: also, any updates on the icon situation? we really should be doing a release every other week... [17:37:37] having trouble getting the project to build in android studio…. going back to intellij for now :D [17:37:49] brion: if we don't have it by end of week, I'm going to revert back to the *old* icon, and push out another beta [17:38:01] YuviPanda: i agree with that [17:38:03] we should push out another beta anyway. Shouldn't push to a '1.0' without beta. [17:38:10] for whatever reason jared doesn't like to reply to things on-list [17:38:14] brion: sweet :) [17:38:22] brion: you got an offlist reply? [17:38:23] * YuviPanda grumbles [17:38:37] asking if i'm in the office wednesday [17:38:39] people outside the office exist, y'know. [17:38:44] so i'll try to get him to use the electronic tools [17:38:47] ok :) [17:38:48] brion: <3 [17:39:13] brion: i'm trying to con marktraceur into reviewing stuff for me :) [17:39:27] brion: and since we aren't in a rush to do WLM this year, I'm actually fixing Campaigns properly :) [17:39:42] whee [17:39:46] brion: no more 6 'idField1' 'fields' and then 6 more for 'idField2' [17:39:46] :) [17:39:56] sowwy [17:40:54] YuviPanda: Yeah explaining that it's a con is less than ideal [17:41:09] marktraceur: ow. [17:41:21] :P [17:42:16] marktraceur: realistically, there isn't anyone who works on UW much. [17:42:20] except you and Nischay [17:42:24] arrfffgh the tax man [17:42:33] 3 phone calls - each one telling me that they are busy and i should phone later [17:42:40] YuviPanda: kaldari also reviews for it, but yeah [17:43:32] tfinc: around? [17:43:47] tfinc: I talked to the Wikidata folks (Danny) [17:44:12] tfinc: queries aren't coming until end of year. [17:44:15] tfinc: plus they just proposed https://commons.wikimedia.org/wiki/Commons:Wikidata_for_media_info [17:44:24] tfinc: which is what we wanted to do (Image Info API) [17:44:41] tfinc: we should setup a meeting / email thread / IRC-thingy and co-ordinate [17:44:51] * YuviPanda hopes tfinc actually sees these, and he wouldn't have to repeat again [17:46:22] grrr [17:46:24] that sucks. [17:47:51] New review: Jdlrobson; "Some more thoughts around why I don't like this..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69336 [17:57:03] New patchset: Jdlrobson; "Minor tweaks to PHP ResourceLoader modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70447 [18:09:24] New review: awjrichards; "To me, this is the *least* fragile the WML stuff has ever looked. I really don't see how moving WML-..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/69336 [18:09:52] MaxSem: have you heard back from antoine yet re https://gerrit.wikimedia.org/r/#/c/69585/ ? [18:10:07] he has no idea:P [18:10:22] I was going to post to wikitech [18:10:31] ok - it looks like he's around now, MaxSem [18:15:06] New review: Krinkle; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70447 [18:23:17] Maryana, do we have QA review today? [18:23:27] yeah, we have a couple of things [18:23:34] i'm in 35 w/vibha [18:23:42] r35? [18:23:57] do you want me to come now or can I join in 5 mins? [18:24:49] r35 was in 2003, before even phase3, wasn't it? [18:29:27] MaxSem: Do we still have Special:Code deployed, to lookup r35? [18:29:49] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/35 [18:30:03] $page->special ( "Yikes! An error!" ) ; [18:30:11] MaxSem: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/35 [18:30:13] hehe [18:30:13] :D [18:30:26] $wikiDontSaveChanges [18:30:58] 19 November 2001 [18:31:27] this would be what, phase2? [18:32:07] yyyyups [18:32:24] :) [18:32:31] Maryana: I'm going to drop and come back on in 10 mins [18:32:35] brion: how come magnus doesn't really contribute to mw as such anymore, but still writes a lot of tools? [18:32:41] ok, just getting set up [18:32:45] dunno [18:32:55] cool I'm on but my computer is fighting me [18:33:02] so gonna reboot and relocate [18:33:12] brion: heh. [18:39:23] ***siren sound*** Deployment in 1.5 hours - any confog changes we need to deploy? Zero guys - shall I push it too? [18:39:53] awjr, jdlrobson, jgonera, dr0ptp4kt, yurik ^^ [18:39:55] i'll let yurik speak to that. yurik^ [18:40:21] MaxSem, dr0ptp4kt reviewing adam's changes [18:41:03] MaxSem, you +2ed the WML-related change, right? [18:41:09] yup [18:41:49] jdlrobson - yt? [18:48:36] hey Maryana sorry was chatting with arthur [18:48:49] you need me for QA or are yu ok with juliusz? [18:48:55] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/69824 [18:49:02] np - we're talking about the copyvio nag in the QA review [18:49:20] it needs animation to work, so either we pull it from this deployment or we add animations just to that one feature [18:49:45] just add it [18:49:47] jdlrobson, in summary, are you strongly against enabling animations in stable _only_ for the nag overlay? [18:49:54] add it for everything [18:49:57] :) [18:50:00] be bold [18:50:01] animation everywhere [18:50:09] or italic [18:50:17] or blink? [18:50:45] http://unicodesnowmanforyou.com/ [18:50:47] jdlrobson, I'll add it only to the nag overlay for now with a fixme because the blurry text in chrome-thing is not fully fixed yet [18:51:12] bahahahaah jgonera everything must blink! [18:54:08] [18:54:11] jdlrobson: is 'fortnight' a word used in everyday british parlance? [18:54:24] or are you from the 19th centruy? [18:54:43] fortnight? we use it a lot yes why? [18:54:45] awjr: I hear it being used reasonably regularly around here [18:54:51] @_@ [18:55:14] is it not used in the usa? [18:55:24] to be fair you use pounds and ounces [18:55:32] no, they're scared of forts and nights. [18:55:37] jdlrobson: i just saw you drop it in the middle of an email, and i think the last time i heard it was watching a pirate movie or something [18:55:49] jdlrobson: touche [18:57:54] argh could you guys not hear me? [18:57:58] Maryana: jgonera but yeh i think we should enable it everywhere if possible and special case things that are broken (e.g. blurry text in chrome-thing) [18:58:04] Maryana: ? sorry : [18:58:07] :D [18:58:22] seems silly to me to just promote animation for one thing [19:00:27] i thought we were done, but at the last minute jgonera noticed the uploads tutorial is gone [19:00:33] he's investigating now [19:00:49] k cool thanks [19:03:16] MaxSem, go ahead and deploy both pls [19:03:22] ok [19:03:25] thx :) [19:04:48] jdlrobson, so is the answer to this spike "yes, so let's kill special:handshake"? https://mingle.corp.wikimedia.org/projects/mobile/cards/828 [19:05:01] time to charge & lunch. bbiab [19:05:01] Maryana: yup [19:05:01] sweeeeeeet [19:05:09] The answer is yes. [19:05:09] http://lists.wikimedia.org/pipermail/mobile-l/2013-June/006063.html [19:05:11] do we need a separate story for that? [19:05:12] (see comments) [19:05:23] the "let's kill special:handshake" part [19:05:32] Maryana: yup story would be good [19:05:40] awesome. will add to next iteration [19:06:00] when we disable we should also double check error rate doesn't increase without it [19:06:13] Maryana: we could actually disable it during today's deployment [19:06:16] and then kill the code next iteration [19:06:37] awjr, you comfortable w/that? [19:06:41] ^ [19:06:46] one sec Maryana on the phone [19:06:49] np [19:08:18] gerrit-wm_: New patchset: Jdlrobson; "Stop handshaking with commons" [operations/mediawiki-config] (master) - https://gerrit.wikimedia.org/r/70458 [19:08:54] ^ Maryana [19:09:07] heh [19:09:08] jdlrobson, why https://gerrit.wikimedia.org/r/#/c/70350/ you're adding a global instead of per-page var? [19:10:03] MaxSem: it's because of the fact it should work on desktop nearby as well [19:10:30] "This should be used for variables which vary with the html and for variables this should work cross skin and for variables this should work cross skin" [19:10:30] but that's still Special:Neraby, right? [19:10:43] yup [19:10:54] it should basically be served where wgMFNearbyEndpoint is served [19:10:56] so it should be added for that page only [19:12:13] yeh your right - currently it should. [19:12:16] Although that said https://gerrit.wikimedia.org/r/#/c/70236/ will make it necessary on all pages [19:12:31] i'm not sure why it was originally added here.. [19:13:28] mmm, okay [19:14:00] New patchset: JGonera; "Regression: show uploads tutorial for users with no uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70459 [19:16:00] New patchset: MaxSem; "Tweak variable description" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70460 [19:17:20] Maryana, jdlrobson i think that sounds fine :) [19:17:23] let MaxSem know ^ [19:17:56] wat? [19:18:21] jdlrobson wants to disable the handshake today and remove the code next iteration [19:18:47] https://gerrit.wikimedia.org/r/70458 <- maxsem [19:19:06] ok [19:19:07] dr0ptp4kt, MaxSem - we have a bit of a problem - a patch two weeks ago (decoupling) seemed to have caused halving of zero traffic across the board [19:19:16] jdlrobson: how bout we break that commit up into two and test first on betalabs [19:19:18] MaxSem: ^ [19:20:08] awjr: i'm fine with that - but i don't foresee any problems [19:20:29] me neither but it would still be good to test :) [19:21:57] New review: Jdlrobson; "Are you sure about the upload count thing?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70459 [19:22:13] New review: Jdlrobson; "(Feel free to +2 if you are sure about above)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/70459 [19:22:38] if it doesn't work in labs we'll have to revert the whole thing anyway no? [19:23:22] New review: Jdlrobson; "+2 if allowed (never sure on deployment day whether to +2 or not)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/70460 [19:23:35] * jdlrobson super excited about nearby on commons [19:23:58] awjr: you got mail [19:24:01] Maryana, regarding https://mingle.corp.wikimedia.org/projects/mobile/cards/856 - should main pages in other languages be whitelisted too? [19:24:02] i'm going to grab some lunch quickly [19:24:39] maxsem, are there main pages in other languages on wmf wiki? [19:24:48] New patchset: JGonera; "Temporarily enable animations in nag overlay in stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70464 [19:25:08] yurik, which patch? [19:25:16] i don't see them... [19:25:21] jdlrobson, jcmish we need to merge those two small patches before deployment: https://gerrit.wikimedia.org/r/70459 and https://gerrit.wikimedia.org/r/70464 [19:25:28] http://wikimediafoundation.org/wiki/Приёмная [19:25:54] woah.. how do you get to that? [19:26:12] jgonera: https://gerrit.wikimedia.org/r/#/c/70464/ i'd rather we promoted the javascript responsible [19:26:17] this is not what i had in mind.. [19:26:28] oh, weird. when you look at it in english, there's no language navigation box [19:26:28] the thing i'm worried about is browsers getting laggy due to bad animation support [19:26:29] jdlrobson, this would enable all animations everywhere on stable [19:26:36] jgonera: and i'm all for that.. [19:26:37] maxsem: http://wikimediafoundation.org/wiki/Home [19:26:42] me too, that's why I don't want to promote the JS [19:26:52] * i want the js [19:26:59] anyway, yes, if there's some way to know which pages those are [19:26:59] we should whitelist them, too [19:27:04] i want protection for shitty android 2 browsers [19:27:12] yes, but right now, all the CSS rules have only .animations prefix, not .beta or .alpha [19:27:29] so moving JS enables animations in all browsers that _claim_ support [19:27:34] go for jgonera [19:27:38] maxsem, added that to the card [19:28:39] that's why I put a FIXME there, it's not a permanent solution, just a workaround for now to get nag overlay into stable, jdlrobson [19:31:13] mmm Maryana - technically, these aren't considered main pages internally. so the only way is to whitelist them individually which will be unmaintainable [19:32:28] too many of them [19:32:59] what if they were all in one category? [19:33:56] brrb gonna grab food before we deploy [19:34:00] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70459 [19:34:13] ugh. we determine whether we should display mobile so early in initialisation that I'm worried about implications [19:35:03] but this seems the only sensible option [19:35:52] category, you mean? [19:36:00] yep [19:36:07] that should be easy. i can ask thehelpfulone if he has better ideas [19:36:51] jgonera: we'll need to test this on android 2 before deploying - last time we let -webkit- css animations/transitions into mobile web it caused serious lag - i would like to check this first - this is why i always preferred use of the animation class to control where it runs [19:37:12] * Thehelpfulone was poked [19:37:31] also just checking jgonera https://gerrit.wikimedia.org/r/#/c/70459/ you saw my first comment right? [19:37:35] jdlrobson, sure, but if we simply move the animations JS to stable, it will be even worse, because all the animations will run on android 2 ;) [19:37:58] I did [19:38:29] hey Maryana, so I've been discussing and trying to get an answer from communications staff with regards to how we want to handle translations on wmfwiki (and how much Meta will be used). I've not had a response yet but I've heard now that Jay and Heather are working on a redesign of Foundation wiki, so perhaps you'd like ask them what their plans are for the Main Page etc too (I don't hav [19:38:30] e any idea what they've got planned - just that they're discussing things!) [19:39:13] gotcha - we were discussing this in the context of flipping wmf wiki to a mobile view for mobile readers [19:39:26] there are some pages that look horribly broken on the mobile view currently [19:39:33] jgonera: i'm not sure i understand - with the .animations class we limit it to those browsers that support translate3d [19:39:40] in this patch you apply it to every browser [19:39:49] thehelpfulone: we've tried to anticipate the high-priority ones, but there are stragglers like translated main pages which are hard to identify programmatically [19:39:51] this is far worse then enabling all animations imo [19:39:57] jdlrobson, and android 2 doesn't claim support for translate3d? [19:40:08] thehelpfulone: maxsem was saying that adding them all to a category would help in the short term [19:40:34] jgonera: http://caniuse.com/transforms3d [19:40:38] there used to be links to alternate translations on pages such as the main page, staff page etc but we removed those links because the pages were so horribly out of date and didn't look good on the desktop sites in terms of formatting either [19:40:42] and will allow to change this stuff on wiki, without digging in site config [19:41:06] ok, jdlrobson, I see, but I still don't think animations are stable-ready [19:41:18] one sec I might be able to get a few lists from templates [19:41:18] I'll test the nag overlay with animations on android 2 device [19:41:21] well then why are we enabling it for the nag overlay? [19:41:23] in 3 mins [19:41:24] jgonera: ok [19:41:39] we do have categories for different languages atm, but I'm not too sure how effectively they're used [19:41:47] i thought vibha said the pulse was not vital anyhow? [19:42:01] (as this is not going to work on all browsers anyway...) [19:42:22] we need pulse on the main browsers, which we know are safari and top shelf android [19:42:59] Maryana: but does that mean the design is broken with no pulse ? [19:43:11] okay so Maryana we used to have https://wikimediafoundation.org/wiki/Template:HomeLang transcluded on the Main Page, you can see that's in a category called https://wikimediafoundation.org/wiki/Category:Other_languages_templates - but to take https://wikimediafoundation.org/wiki/Portada as a random example from that first link, you see it's only got the report from 2009/10 [19:43:37] meh [19:44:05] oh goodness. that's a lot of random pages. [19:44:11] that are way out of date anyway [19:44:42] can we just add the dozen or so home pages that are in this template (https://wikimediafoundation.org/wiki/Template:HomeLang) and add them to a new category? [19:44:51] cat:translated home pages or something? [19:45:20] and then if someone complains/raises a bug, we can whitelist other pages by request? [19:45:25] the thing is the pages are *so* outdated that arguably it'd be better if they saw fully english only [19:46:10] to me this is black and white - we either push all animations into stable (special casing any we are not confident about) or we don't push it [19:46:16] there's no middle ground [19:46:26] sorry maybe I missed it, by adding these pages to the category:translated home pages (or whatever), who will this effect? [19:46:41] thehelpfulone: users on mobile phones viewing wmf wiki [19:46:52] that should have been affect* sorry [19:46:57] otherwise we will just forget this particular example is special cased and i worry about browser specific issues that will be harder to capture [19:46:58] so they'll see the page in mobile view? [19:47:11] thehelpfulone: if it's whitelisted, they'll see the desktop view [19:47:17] otherwise, they'll see the mobile view [19:47:29] ah okay, yeah that makes sense [19:47:29] but in mobile, the home page formatting is all borked [19:47:51] yeah, so we just want to make sure these pages are still usable if readers are searching for/landing on them on mobile :) [19:48:10] https://wikimediafoundation.org/wiki/Template:StaffLang would probably need to be included - although I think heather's working on making that more mobile friendly? [19:48:16] or maybe it's the jobs pages she's working on [19:48:40] i think they're trying to do everything, but it will obviously take awhile [19:48:50] jgonera: bear in mind we had $wgMFEnableCssAnimations : [19:48:57] *we have $wgMFEnableCssAnimations :) [19:48:59] hm [19:49:09] but still, some animations are glitchy [19:49:13] I want to fix them first [19:49:18] well prefix those with alpha/ beta [19:49:25] it's more future proof [19:49:35] Sure - is mobile view enabled as a beta right now? [19:49:41] I don't want to do that now, going through all the animations we have on all the popular browsers? [19:50:10] thehelpfulone - sort of. you can go down to the bottom of any wmf wiki page and click mobile view. and then do it again, and you're in the mobile view :) [19:50:18] so not a beta, exactly, but very not discoverable [19:50:57] heh I tried doing it once but didn't realise you needed to do it twice [19:51:35] the FAQ looks a bit ugly too Maryana [19:51:52] yep. it's in our list: https://mingle.corp.wikimedia.org/projects/mobile/cards/856 [19:51:55] but that page could probably be fixed by someone who knows what they're doing [19:52:45] "hella janky", btw, is highly technical jargon specific to the bay area ;) [19:52:48] in case you were wondering [19:53:16] :D [19:53:29] anything you can do with the summary box on the ToU? [19:54:17] the privacy policy and ToU generally look okay on mobile view I think [19:54:27] yeah, surprisingly so [19:54:39] i think they look way more readable in mobile than desktop, to be honest [19:55:06] okay that's a bit awkward, if you try the random page feature on wmfwiki through mobile you can end up hitting a fundraising page [19:55:11] that was the main impetus for doing this - we link to the ToU and privacy policy all over the place [19:55:15] and they look "hella janky" :P [19:56:21] yeah, i got the fundies to give me the most important ones they wanted to make sure were whitelisted. there might be some old/outdated ones that aren't listed, but i don't care so much about those [19:56:57] even things like https://wikimediafoundation.org/w/index.php?title=Thank_You/Viswa_Prabha&mobileaction=toggle_view_mobile [19:57:10] I just mean people using the "random page" feature in the mobile web interface itself [19:57:25] well, those people are weird and i don't like them [19:57:29] (just kidding) [19:57:35] (but seriously - who does that?) [19:57:49] (on wmf wiki, anyway) [19:58:03] but that's a good point [19:58:05] Thehelpfulone: we can force a page to always show in desktop. So clicking random and landing on a fundraising page would take them to desktop which i guess is weird... [19:58:10] hey they might experiment with the new interface :p [19:58:36] yeah. is there a nearby on wmf wiki, too? :) [19:58:41] can you disable the nearby? [19:58:43] Maryana: if enabled :) [19:58:55] easy to turn off though [19:58:59] we probably shouldn't show it on wmf wiki, yeah [19:59:03] thanks thehelpfulone [19:59:08] and if you could hide uploads too [19:59:12] hehe [19:59:13] poor wikivoyage doesn't have it for instance [19:59:56] well, maybe someone will want to donate an image to commons from the wmf wiki [20:00:08] that's all uploads really does [20:00:20] doesn't associate it w/any article [20:00:33] Maryana, if you click on it logged out though it tells you that you need to login [20:01:08] then if people try to login the majority won't be able to, they'll try to "create account"and will get a horrible permissions error message [20:01:09] yeah, true. i guess wmf wiki isn't part of our SUL ring [20:01:19] and then they'll leave our projects forever ;-) [20:01:56] i think these cases are going to be pretty rare (cos you'd have to find yourself on wmf wiki somehow, for one, and be the really outgoing/exploring type, for two [20:02:03] but yes, good to point out [20:02:31] awjr & jdlrobson, so are we merging https://gerrit.wikimedia.org/r/#/c/70458/ or something?:) [20:02:52] agreed [20:03:05] oh; MaxSem jdlrobson did that not get tested on betalabs yet? [20:03:27] oh i thought you were doing that awjr i misunderstood.. [20:03:27] to test, you have to merge [20:03:54] MaxSem: i suggested earlier that the patchset be broken into two - one specificaly for beta labs, the other for production, so we could do them separately [20:04:00] but no big deal [20:04:59] alright awjr, dr0ptp4kt, jcmish, jdlrobson, jgonera, Maryana, yurik - we're live on testwiki, please test:) [20:05:02] New patchset: JGonera; "Temporarily enable animations in nag overlay in stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70464 [20:05:25] crap [20:05:25] ok [20:05:27] jdlrobson, ^ [20:05:27] please review [20:05:35] on it [20:05:42] oh do we need to wait jgonera ? [20:06:48] jcmish, we should merge it if jdlrobson has nothing against it [20:06:49] thanks jgonera much better [20:06:59] kayo [20:07:24] jdlrobson, I didn't update the commit message, but I see you merge already [20:07:38] MaxSem: i +2'd https://gerrit.wikimedia.org/r/#/c/70458/ [20:07:47] New patchset: Jdlrobson; "Enable animations in nag overlay in stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70464 [20:07:59] not too late when jenkins is slow ;-) [20:08:25] New patchset: Jdlrobson; "Enable animations in nag overlay in stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70464 [20:09:09] thanks jdlrobson [20:10:35] hm, still not merged... [20:10:35] come on jenkins [20:10:37] MaxSem: manually merged https://gerrit.wikimedia.org/r/#/c/70458/ (jenkins too slow) [20:10:58] should I also merge the other one? [20:11:10] jgonera: did you already run unit tests, etc on it:? [20:11:18] yep [20:11:22] i think it's fine then [20:11:25] awjr, done [20:11:26] to manually merge, that is [20:11:30] aka deployed [20:11:46] Change merged: JGonera; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70464 [20:12:06] MaxSem, ^ [20:15:50] jgonera, deployed [20:16:04] everything's looking good to me so far [20:16:08] ooohhh pageimages [20:16:09] mushahahahahah [20:16:25] wat? [20:16:33] search results [20:16:38] just enjoying the feature [20:17:10] im still seeing the handshake in use on betalabs [20:17:24] awjr: with that config change? [20:17:34] awjr, yeah, me too [20:17:46] jdlrobson: well i dunno if the config change has been applied to betalabs yet or not [20:17:53] erfgg office wifi not working for me today making testing hard [20:17:57] jdlrobson, MaxSem: i am also seeing the handshake in action on testwiki [20:17:58] awjr: well i haven't applied it as i'm not able to.. [20:18:07] grrr [20:18:13] jdlrobson, the delay on pageimages is weird [20:18:14] jdlrobson: it's supposed to happen automatically on merge [20:18:16] it's really long [20:18:36] Maryana: we can tweak this - but there will always be some kind of delay due to connection [20:18:43] we maybe need to think about an ajax loader [20:18:52] also, they're so small i can barely see the actual image.. [20:19:21] Maryana: this is why we do things in beta first :) [20:19:33] awjr: the handshake issue is this going to happen in Prod as well? or do I not have to worry? [20:19:35] jdlrobson, now deployed for realz [20:19:37] we may want to only show them on smaller lists [20:19:38] yep [20:19:58] i'd rather have more results then page images to be honest [20:20:10] MaxSem, yurik, test.m seems to be working for me when putting X-CS and X-SUBDOMAIN as name-value pairs. the useformat=mobile-wap seems to be working as expected. cc: jcmish, jdlrobson, jgonera, Maryana. yurik, seem to be working on your side? [20:20:15] it shouldn't jcmish, it shouldnt be happening anywhere [20:20:34] awjr: bummer k [20:20:55] yeh i'm still seeing handshakes.. mm [20:21:28] MaxSem, jcmish is there anyway to double check if https://gerrit.wikimedia.org/r/#/c/70458/ has been applied on betalabs? [20:21:53] awjr, since it's not working in prod either...:P [20:22:08] MaxSem: you sync-filed the change already? [20:22:14] mw.config.get( 'wgMFLoginHandshakeUrl' ) is still set [20:22:16] on test only [20:22:27] (on beta labs) [20:22:33] awjr: I just look at the latest commit that was pulled [20:22:48] where can you see that, jcmish? [20:23:22] null on testwiki [20:23:46] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version [20:23:59] ah yeah, indeed MaxSem, no more handshake happening on testwiki [20:24:17] maybe it was cached JS [20:25:40] jcmish: Special:Version doesn't show currently checked out version of conf files though :( [20:25:53] oh no sorry [20:25:58] I was thinking gerrit commits in general [20:26:19] hmm MaxSem do you have ssh access to betalabs? [20:26:28] i wonder if the merge didn't get applied because manually merged it since jenkins was taking forever [20:26:38] I do. you should have it also [20:27:11] oh is there a way to just look and see what the latest files ie maybe ls? [20:27:13] just testing an upload but that aside looks good to me [20:27:27] or is that not going to work awjr and MaxSem [20:27:28] upload worked fine [20:27:44] as an aside automation tests for test wiki passed [20:28:11] mmm, betqa and prod have the same tip [20:28:40] RELEASE THE CLONES! [20:29:29] MaxSem: so betalabs really hasn't been updating? [20:29:36] jdlrobson, you have a typo in "clowns"...:P [20:29:45] hahaha [20:29:48] jcmish, the contrary [20:29:49] New patchset: Jdlrobson; "Minor tweaks to PHP ResourceLoader modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70447 [20:30:00] oh good [20:30:07] I read it wrong started to panic :D [20:31:48] jcmish, MaxSem betalabs now is not showing the handshake, just took a while i guess [20:31:56] ah [20:31:57] whew [20:41:31] are we moving to prod now? [20:41:37] we're good on test? [20:42:12] all good by me [20:42:23] and i'm officially kicking off an april fools day ideas doc [20:42:43] because we just had a really good one that i don't want to forget :) [20:43:12] what was it? [20:43:27] you will see in a second.. [20:43:49] uhoh [20:43:51] are you? [20:45:18] just good to keep a list so we can be prepared for next year :D [20:46:01] feel free to add! [20:46:20] lulz [20:47:57] HAHHAHA [20:48:05] very nice Maryana! [20:48:26] Think geek still has the most classic ones in my book [20:49:53] gank them and add them to this list :) [20:50:21] we are not above theft. i mean, uhhh, fair use with attribution! [20:50:48] 'please download the app and sign in with facebook to continue reading this section' [20:50:59] :P [20:51:07] hehe [20:51:07] we don't actually have to do it, just announcing it on the wikis would be fun :) [20:51:10] agreed! [20:53:14] oooh, that gives me another good idea [20:54:43] New patchset: MaxSem; "Card 856: Allow to disable mobile view on some pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70539 [20:59:26] awjr: Maryana I need to run to the airport [20:59:28] to pick up a friend [20:59:33] are we good to go? [21:00:28] MaxSem: scap done yet? [21:00:40] what scap? [21:00:45] I'm not scapping [21:01:01] oh; just a sync-dir? are changes live now? [21:01:25] I didn't get a permission to deploy yet [21:01:35] Maryana, can we? [21:01:43] MaxSem: she said yes :D [21:01:44] yes [21:01:49] oh, she gave the all clear a while ago [21:01:53] sorry I asked earlier and didn't add you :D [21:02:10] sorry, i thought we were already scapping [21:02:12] d'oh [21:02:27] :) [21:02:39] scap is what now 30min - 1hr? [21:02:42] jcmish: is there a way we can run tests in prod if you're not back before scap is done? [21:03:18] can chrismcmahon run them? [21:03:27] yup if you're setup [21:03:38] scap timing is… variable, though it seems it's been < 30mins lately [21:03:59] ? [21:04:21] chrismcmahon: can you run the mobilefrontend tests for me on prod [21:04:35] you just have to export MEDIAWIKI_URL [21:04:45] and bundle exec cucumber [21:05:18] jcmish: I should be able to [21:05:27] sweet ping me if you run into anything [21:05:33] I need to make it to the Denver airport :D [21:05:46] chrismcmahon: MaxSem can let you know when our sync is done [21:06:19] I'll have my phone Chris and I'll have my ipad and can remote into my machine here at home [21:08:18] you know, the android emulator is much faster now with the 'native gpu' option [21:08:34] not half bad anymore [21:19:09] MaxSem awjr poke me on IRC after the sync please, I [21:21:19] hmmmmm [21:21:47] android ListView/Adapter doesn't support multiple sections? do i have to roll that myself? bleh [21:26:29] i shall… reconsider this layout [21:28:45] awjr, chrismcmahon, jdlrobson, jgonera, Maryana - scap complete, please test:) [21:29:04] thanks MaxSem [21:29:14] w00t [21:29:52] soooo prettttyy [21:30:11] i'm finding so many articles to add images to ;-) [21:30:29] fatals shot up [21:30:36] [25-Jun-2013 21:26:24] Fatal error: require() [function.require]: Failed opening required '/usr/local/apache/common-local/php-1.22wmf7/extensions/MobileFrontend/includes/skins/SkinMobileBase.php' (include_path='/usr/local/apache/common-local/php-1.22wmf7/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/usr/local/apache/common-local/php-1.22wmf7:/usr/local/lib/php:/usr/share/php') at /u [21:30:36] sr/local/apache/common-local/php-1.22wmf7/includes/AutoLoader.php on line 1155 [21:31:00] I wonder if that's just a side-effect of deployment leaving each host in an inconsistent state for a brief moment [21:31:01] basile: multiple sections as in? [21:31:02] err [21:31:03] sorry [21:31:06] brion left [21:31:11] i think it might be, ori-l [21:31:13] a side effect, i mean [21:31:38] http://commons.m.wikimedia.org/w/index.php?title=Special:Nearby :D [21:31:43] CAKE [21:32:01] brion with cake! http://commons.m.wikimedia.org/wiki/File:Wikivoyage_cake_photo_1.JPG [21:32:07] wooo came [21:32:13] *wooo cake [21:32:17] uh [21:32:30] jdlrobson: i see the add image CTA to … images on commons nearby [21:32:41] something is funny with Search but not sure what, could y'all do some sanity checking for searching? [21:32:41] before you ask PageImages doesn't seem to work on the file namespace and I wasn't able to file a bug as there is no product for it in bugzilla [21:32:54] awjr: ^ [21:33:12] chrismcmahon: i believe there's currently a search dos attack happening right now; or at least there was earlier [21:33:12] chrismcmahon: funny in what way? [21:33:18] that makes sense jdlrobson [21:34:27] awjr: the Search test passed before scap but fails after, something that should be a link is not present. looking further but shouldn't take long (I'm not intimately familiar with Michelle's tests) [21:34:40] * chrismcmahon looks, brb [21:34:40] awjr: yeah, seems to be flattening, which supports this being a scap side-effect [21:34:57] ori-l: yeah i believe that file was removed during this deployment [21:38:19] MaxSem, wikipedia zero seems to be basically working as expected. yurik, MaxSem scap'd - not sure if you had a chance to review. [21:39:07] dr0ptp4kt, i already +2ed your change [21:39:55] yurik, saw that. thx, seems like the wap stuff - useformat=mobile-wap - is working in production [21:41:17] awjr: seems OK, the element we see now "" used to be a "ul" not a div, that made the test fail. I'd say a drive-by sanity check of search would be in order though. [21:42:22] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=50139 [21:42:27] andre said he'll probably get to it tomorrow [21:42:38] cool chrismcmahon, thanks [21:42:43] i'll poke it now [21:43:48] seems ok chrismcmahon :) [21:44:19] awjr: great, nice to see a test fail for a good reason [21:44:26] :) [21:44:43] everything's looking good for me in stable. uploads work without handshake! [21:44:44] im surprised that wouldn't have failed on testwiki though [21:44:49] or betalabs for that matter [21:44:56] chrismcmahon: ^ [21:46:43] awjr: not sure, looking, I've had a bit of a meltdown in the beta and test2 browser test builds this week (nothing to do with mobile) [22:00:54] awjr: yep, we didn't run the search test in beta labs :-/ not sure why, I'll follow that up [22:01:06] thanks chrismcmahon [22:12:22] Maryana, I think I know what's wrong with the tutorial in Safari, I can reproduce on the iPod, will verify that later [22:13:49] it's probably related to infinite scroll and the bug/feature I showed you (tutorial reappearing when you scroll to the bottom) [22:46:02] New patchset: MaxSem; "Remove support for api.php?action=parse&mobileformat=wml" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70320 [22:46:02] New patchset: MaxSem; "WIP: decouple heading formatting from MobileFormatter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70558 [22:46:32] awjr & jdlrobson, can you tak a look at ^^^ please so that I knew how to proceed [22:47:50] sure thing MaxSem, in a bit [23:01:00] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70460 [23:01:27] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70369 [23:02:17] New review: Jdlrobson; "This looks promising a few discussion points I'd like to make" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70558 [23:07:18] jgonera Maryana: happy hour drinks tonight [23:07:20] ? [23:08:09] in like an hour or two? [23:08:34] aww can you guys set up a hangout and i'll drink with you from here? [23:10:03] New review: MaxSem; "ParserOutput/OutputPage is not a realistic solution, moving transformations to skin involves https:/..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70558 [23:19:16] Maryana: yes [23:19:19] awjr: maybe [23:29:37] brion: i'm off to sleep :) [23:29:45] night night [23:30:48] brion: :) talked to mark traceur a lot, and got reviews on the WIP code too. should be in heavy-CR state by end of week. [23:30:56] awesome [23:31:05] and hopefully get deployed before middle of next month :) [23:31:13] :D [23:31:24] brion: i'm fixing the campaign data model so it is not 'one large set of key/value pairs' :) [23:31:33] much nicer now [23:31:50] okay, off to sleep for real now [23:31:52] cya [23:31:55] hehe [23:32:14] actually I'm tempted to stay up [23:32:19] being awake during the day is horrible [23:32:27] asbestos roof + ~110F is... not good [23:33:03] YuviPanda: you should come to tucson, it's still just under 110F here [23:33:15] awjr: well, you probably have Air Conditioning :P [23:33:20] and do not have an asbestos roof :P [23:33:27] heheh both of those are true [23:33:33] it's 110F outside, but inside feels more like 150-160 [23:33:46] very similar to standing near a very hot bus engine [23:33:53] yuck! [23:34:03] yeah, without A/C buildings here turn into ovens [23:34:04] so might as well stay up till 7-8am, get more work done, and sleep through the heat! [23:34:19] yeah, and asbestos makes it a very effective oven! [23:34:34] that will never catch on fire [23:34:43] also carcinogenic :P [23:34:50] ahhh good times [23:35:19] :) [23:36:38] New patchset: Jdlrobson; "Rewrite language overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70565 [23:36:38] New patchset: Jdlrobson; "Correct left padding on headers and footers in 'list' overlays" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70566 [23:36:38] New patchset: Jdlrobson; "Story 836: Promote language search to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70567 [23:37:59] New patchset: Jdlrobson; "Story 836: Promote language search to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70567 [23:56:12] New patchset: Jdlrobson; "Story 867: Update copy for empty watchlist (1/2)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70570 [23:56:12] New patchset: Jdlrobson; "Story 867: Update assets to reflect new article action bar (2/2)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70571 [23:56:24] New review: Jdlrobson; "Needs new assets from Vibha" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/70571