[00:15:44] New patchset: Jdlrobson; "Story 884: Add CTA for edit icon" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70574 [00:17:32] awjr: how do i add https://mingle.corp.wikimedia.org/projects/mobile/cards/703 to bug backlog [00:17:52] also awjr https://mingle.corp.wikimedia.org/projects/mobile/cards/880 is done no? [00:18:29] jdlrobson: from the 'iteration' selector, click 'select card', then select '#736 Bug backlog' [00:18:47] no, jdlrobson [00:18:57] wow select card who knew [00:19:03] awjr: is it in development? [00:19:08] awjr: i'm not clear what needs to be done for it [00:19:14] yeah, that's a weird one [00:19:52] we added that infrastructure card for one of us to help shepherd the resolution of the bug along [00:20:03] i'll move it to in development since i've been pushing it forward [00:20:04] also does anyone feel strongly about not saying WONTFIX to this bug - https://bugzilla.wikimedia.org/show_bug.cgi?id=50005 [00:20:11] awjr: k [00:21:26] jdlrobson: im not sure i understand what you mean by 'not saying wontfix'? are you asking if we think we should tackle it? [00:21:45] awjr: I'm saying I personally don't think we should ever do this. [00:22:22] (i worry that if things are left as an enhancement they linger too much) [00:22:26] jdlrobson: agreed; geoip doesn't give sufficient precision for it to be usful for nearby [00:22:39] but, Maryana should make the call [00:24:17] jdlrobson, yeah, let's not mess with that [00:27:13] doh [00:27:19] ~~~~ doesn't do anything in the visual editor [00:27:53] lol hitting backspace in the visual editor also appears to delete the entire line rather than one char... [00:28:19] it uses vim keybindings [00:28:34] just kidding [00:28:50] hahaha i was about to file a bug saying that didn't work :p [00:29:00] hmm, does trying to close the tab make it beep? [00:29:04] how do i sign my name with VE? [00:29:10] awjr: you can't [00:29:13] this bit me last week :P [00:29:17] huh [00:29:48] Maryana: awjr i closed that bug -https://bugzilla.wikimedia.org/show_bug.cgi?id=50005 - don't know if you have anything to add [00:29:58] awjr: you need to go to source to do that [00:30:04] (always helps to get other views in so i don't look like the only person against it :)) [00:30:33] no, you can play bad cop in bugzilla [00:30:35] :) [00:31:33] lol [00:31:54] you already dirtied by name by mentioning me in your comment [00:32:53] :p [00:32:55] awjr: double checked, signatures aren't going to come to VE anytime soon [00:33:05] but i think all the important stuff's been covered in that bug alrady [00:33:12] sadness YuviPanda [00:33:23] ~~~~ is like my favorite feature [00:33:38] awjr: we can always do as enwiki does, and write a gadget to add that feature back in :P [00:34:00] make an api call to expand ~~~~, insert resulting html! [00:34:00] hahahaha and we should be sure to style it with inline styles [00:34:09] awjr: by inline styles you mean ? [00:34:10] :) [00:34:18] naturally :p [00:34:32] :) [00:35:36] flow will auto-sign [00:35:47] so just wait about 6 months and you'll get your feature [00:35:57] \o. [00:35:59] aww [00:36:01] \o/ [00:36:01] (flow will also make you a sandwich and fluff your pillows) [00:36:11] * awjr dusts of his time machine [00:36:17] i can't wait! [00:48:44] New review: Jdlrobson; ""ParserOutput/OutputPage is not a realistic solution"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70558 [00:54:21] it's a day of excellent bug names [00:54:28] best bug ever [00:54:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=50205 [00:54:49] i dunno, mine's pretty good, too: https://bugzilla.wikimedia.org/show_bug.cgi?id=50201 [16:38:57] well hello windows 8.1 preview [16:39:07] * brion breaks out parallels [16:55:01] * tfinc yawns [17:15:21] brion: am I in the wrong hangout for standup? [17:16:09] so let me find a room awjr [17:16:22] ok jdlrobson - when you've found one, send MaxSem and i a hangout link :) [17:17:44] * jgonera going to the office now [17:18:34] https://plus.google.com/hangouts/_/2e528c392e312ed5e1984d4b807e311078a42f51 [17:18:51] ! [17:18:55] it says im not allowed to join the call [17:19:06] jdlrobson: ^ [17:19:18] are you using wikimedia account awjr ? [17:19:38] unclear [17:19:43] try again now [17:19:43] awjr: happens to me all the time, I've to open it in incognito + sign in with wmf account [17:20:08] YuviPanda: same [17:20:16] jdlrobson: can you invite me to the call? [17:20:23] * MaxSem simply uses a dedicated browser [17:20:54] awjr: any luck? [17:20:58] incognito is a pain because of 2factor auth [17:20:59] yup [17:21:22] tfinc: https://commons.wikimedia.org/wiki/Commons:Wikidata_for_media_info [17:21:28] is the image info proposal from wikidata [17:23:15] whee [17:25:02] MaxSem, dfoy had placed a card in trello saying something about you changing some images for wikipedia zero login to be served from bits instead of upload. can i archive that card? [17:25:20] ^ cc yurik [17:26:58] YuviPanda: mhurd brion : heads up about our retrospective @ 11 [17:27:08] tfinc: yup, 30 mins [17:28:33] ok [17:46:16] awjr: MaxSem https://gerrit.wikimedia.org/r/#/c/70323/ < can you review this? will help with the mobile formatter stuff [17:46:51] MaxSem: if you can't look at it now, i can take a look in about 30 mins [17:46:55] lmk [17:46:55] dr0ptp4kt, i think i will revert your patch that checks before redirect, because that is the easiest way to track if stats return to previous levels [17:47:02] looking [17:47:58] dr0ptp4kt, yes - I did it. we need however somekind of verification that we're not serving other images from upload to unsuspecting users [17:48:48] man, iOS 7b2 update is taking foreeeeevahhhhh [17:48:57] brion: in the meantime, http://166.78.139.29/ :) [17:49:02] is verrry sweet [17:49:16] brion, time to switch to the light side of the force! [17:49:21] ooh [17:49:41] New patchset: Yurik; "Revert "Constrain redirects to Wikipedia Zero partner-sourced requests."" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/70659 [17:50:25] brion: it's docker based. I'm going to set it up on Labs soon [17:50:26] Maryana: when you have a sec can you double check the priority order of stuff in 'ready for dev' since we added a few bugs today? [17:50:36] nice [17:51:31] awjr, will do! [17:51:37] Change merged: Yurik; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/70659 [17:55:25] yurik, okay, although i don't really care to declare that the culprit in the absence of hard data. (a) it fixes a serious phishing problem (granted, people can examine their omnibar post-click; counterpoint: once a drive-by download has been kicked off it is irrelevant). (b) i thought about this some more and it doesn't make sense that there would be a measurable reduction in 301 hits (p.s., why would 301s be counted?). bu [17:55:25] guess we'll see what the data bears out. [17:55:50] dr0ptp4kt, i am in no shape or form blaming that patch :) [17:55:56] s/data bears/data bear/ [17:56:09] yurik, i know…we just gotta throw some darts at the wall :) [17:56:44] yurik, i'm gonna bug the guys about some extra data... [17:57:49] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70323 [18:02:26] awjr, any thoughts on ^^^ ? [18:03:17] YuviPanda: https://plus.google.com/hangouts/_/29998ec811b644a7375cdee4b97fc3c97fcd0553 [18:03:51] tfinc: that isn't the one from the calendar? [18:03:54] anyway, let me join [18:03:56] mhurd: joining us for the retrospective ? [18:04:03] were in R33 [18:04:15] YuviPanda: your invited [18:04:26] so there shouldn't be a reason why its not on your calendar [18:04:36] tfinc: it is in my calendar, it is just a different hangout [18:14:35] dr0ptp4kt, reverted, will see :) [18:16:09] looking now, MaxSem [18:22:59] man i hate templates in mediawiki [18:23:11] ^ said everyone [18:23:25] hehehe [18:25:21] brion: so new Firefox has webrtc enabled by default. we should try using one of those instead of hangout 'experimentally' [18:29:12] ooooooh [18:29:21] does chrome have it enabled now too? [18:29:34] eventually hangout should migrate to use webrtc i hope [18:29:43] brion: it does, I think [18:29:45] but we should also be able to not use proprietary services ;) [18:29:46] brion: maybe not by default [18:30:00] brion: indeed. hence the experimental move :) [18:31:15] :D [18:32:07] New review: awjrichards; "See inline comments, and please be a little more liberal with comments for methods you're adding thr..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/70323 [18:32:33] tfinc: ping? pm? [18:32:41] YuviPanda: sure [18:32:42] YuviPanda: so IE 11 apparently includes webgl, but no webrtc yet i think :) [18:35:03] New review: awjrichards; "Also, rather than repeating 'function getModeClass() {' everywhere, why not just set an object prope..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70323 [18:38:16] brion: yeah. Considering they own Skype... [18:38:25] hah [18:48:57] awjr: great to already see you on the contribus quarterly review presentation [18:54:25] :D [18:58:44] MaxSem: are we able to access parserOutput from the skin? [18:59:24] no, OutputPage pulls it apart and gives you only its contents separately [18:59:38] ergg ok [18:59:48] jdlrobson: i forget - is there a way to force CN to show a banner in mobile? i'd like to get a screenshot of the banner that we used for the commons app [19:00:30] i forget awjr - pretty sure there is a special query string parameter [19:00:33] will be same as desktop [19:00:39] ask mwalker [19:01:20] yah thanks jdlrobson [19:27:24] New patchset: MaxSem; "WIP: create a thin base class for all our skins" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69336 [19:27:48] HTTP header generation moved to a more appropriate place^^^ [19:39:18] jdlrobson, jgonera, MaxSem what all do we have only in alpha right now aside from the diff enhancements? [19:39:33] dynamic sections [19:39:42] awjr: there's a wikipage for this.. [19:39:50] JS that breaks non-latin titles [19:39:51] orly [19:39:55] lol MaxSem [19:40:12] JS that removes inline styles [19:40:30] jdlrobson: what's the wikipage? [19:40:35] https://m.mediawiki.org/wiki/Mobile/Release_history [19:41:14] So MaxSem this refactoring is a lot harder than i thought :(. I don't see how we can get what we need without using a hook… have a patch set to share so you can see what is needed [19:42:05] sure [19:46:59] MaxSem: okay this patch set is massively broken but here we go.. [19:47:04] New patchset: Jdlrobson; "WIP: decouple heading formatting from MobileFormatter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70558 [19:47:05] New patchset: Jdlrobson; "Define explodeBodyHtml function to allow us to action section info from template" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70736 [19:47:05] New patchset: Jdlrobson; "fxup1" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70737 [19:47:05] New patchset: Jdlrobson; "fx2" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70738 [19:47:07] New patchset: Jdlrobson; "Bug 49208: Make sure edit link targets the correct section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70739 [19:47:11] actually let me rebase [19:47:40] aieee, chains again [19:47:42] New patchset: Jdlrobson; "WIP: decouple heading formatting from MobileFormatter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70558 [19:47:43] New patchset: Jdlrobson; "Define explodeBodyHtml function to allow us to action section info from template" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70736 [19:47:43] New patchset: Jdlrobson; "Bug 49208: Make sure edit link targets the correct section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70739 [19:47:52] so MaxSem take a look at the last one first [19:47:59] that's where we need to get to (somehow) [19:48:30] the patch before that is how we should be doing rendering. I'm not sure what's the best way to get there :( [19:49:04] you want to read through that while i grab lunch and then maybe have a hangout to sort this out? [19:49:51] ^ MaxSem ? [19:50:15] hmm, reading [19:50:41] ok i notice story prioritization is in 10 so definitely need to grab food ;-) [19:50:45] jdlrobson, prioritization in 10 minutes [20:00:41] jdlrobson, MaxSem, jgonera, jcmish: Maryana_brb and i are gonna be a minute or two late, stuck in another mtg [20:00:50] k [20:00:54] it's okay jgonera running late too [20:01:02] I'm setting up now awjr [20:01:13] cool thanks [20:02:19] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70737 [20:02:25] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70738 [21:19:29] YuviPanda: i see 8 times in my chat window. impressive [21:19:40] tfinc: ? [21:20:03] let me post a screenshot [21:20:38] New patchset: Jdlrobson; "Bug 49208: Make sure the edit link chooses the correct section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70751 [21:20:45] tfinc: yes, yes, you should! :) [21:21:22] YuviPanda: http://imgur.com/HV0IYxr [21:21:41] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70739 [21:21:41] if i scroll there are more of you [21:21:43] tfinc: :D [21:22:07] tfinc: what can I say, there are reasons India is the second most populous country in the world :P [21:22:23] YuviPanda: wait, are you telling me i can hire more of you? [21:22:26] :D [21:22:35] :P maabee :P [21:22:46] tfinc: filling out the H1B stuff now, btw. [21:22:48] looot of forms [21:23:27] "Have you, within the past 10 years, ever been a prostitute or procured anyone for prostitution?" [21:23:31] interesting types of questions :P [21:24:05] "Do you intend to engage in any acitivies intended to overthrow the Government of the U.S. by force, violence or other unlawful means?" :) [21:49:19] awjr: dont treat any of the images as final in the q4 review. i needed images to see the narrative better. so if you have better ones feel free to replace them [21:57:58] MaxSem: what's going on with this change: https://gerrit.wikimedia.org/r/#/c/70558/3/includes/formatters/MobileFormatter.php ? [21:58:48] stuff gets moved to another class [21:59:10] tfinc: kk [22:01:54] MaxSem: do you mean includes/skins/SkinMinerva.php? [22:02:22] to a base class too [22:02:38] is that includes/skins/SkinBootstrap.php? [22:02:42] we want to render headings in skins as opposed to formatter [22:03:11] most likely, it will be called differently [22:03:13] :) [22:03:24] What about jdlrobson's idea with ParserOutput/OutputPage? [22:05:14] we're not aiming at it at the time [22:05:39] hmm [22:05:50] Wouldn't it sort of make sense in a perfect world? [22:05:56] Or am I missing something [22:06:45] tfinc or Maryana_brb can one of you move the chair in front of the camera? [22:06:45] emphasis on perfect world:) [22:06:58] thank you:) [22:07:12] MaxSem: ha ha [22:08:25] MaxSem: What's going on with the special case code like WML? [22:10:05] no special case, just different classes inheriting from the same base [22:10:32] Okay that makes sense then [22:14:41] MaxSem: If you don't mind me asking what was the reason to refactor: https://gerrit.wikimedia.org/r/#/c/69336/2/includes/MobileFrontend.body.php [22:15:17] removing unneeded cross-dependency [22:15:35] New review: preilly; "Needs to be rebased." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/69336 [22:15:46] MaxSem: where is DOMParse now? [22:15:57] in skins [22:16:34] Doesn't that seem a little weird to you? [22:16:43] Or am I just missing something [22:19:15] Skins control what HTML they want, some of them want specific transformations, Minerva doesn't. note that DOMParse itself is almost empty [22:19:34] New patchset: Jdlrobson; "Sandbox alpha and beta skins from stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70323 [22:20:12] Still seems like it should be a preprocessor or something [22:20:26] But if it makes sense to you it's probably a good thing ;-) [22:21:44] preilly, we're moving away from a lot of conditionals in favor of inheritance [22:22:03] for example, there's now SkinMobileBeta [22:22:23] MaxSem: generally I think that's a great idea [22:32:48] New patchset: Jdlrobson; "Introduce Class" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69959 [22:33:30] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69959 [22:39:00] New patchset: Jdlrobson; "Story 884: Add CTA for edit icon" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70574 [22:39:53] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70574 [22:41:20] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70570 [22:49:11] New patchset: Jdlrobson; "Bug 49208: Make sure the edit link chooses the correct section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70751 [22:54:44] New patchset: Jdlrobson; "Bug 49208: Make sure the edit link chooses the correct section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70751 [22:56:11] New patchset: Jdlrobson; "Bug 49208: Make sure the edit link chooses the correct section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70751 [23:07:51] New review: MaxSem; "Can we hide them in a more reliable way, like style="display:none" or some HTML manipulations?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70751 [23:10:01] New review: JGonera; "They're hidden in CSS using display: none (mf-hacks.less)." [mediawiki/extensions/MobileFrontend] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/70751 [23:10:33] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70751 [23:12:01] dr0ptp4kt, found a nasty bug with configs :( [23:12:06] need to do a quick depl [23:12:22] yurik, cool [23:17:12] New review: Jdlrobson; "POC do not merge" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/70736 [23:17:45] New review: Jdlrobson; "POC do not merge" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/70558 [23:21:27] New patchset: Yurik; "Fix config whitelistlang sorting" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/70770 [23:21:44] dr0ptp4kt, could you review this urgently ^ [23:21:52] yurik, on it. [23:21:59] thx [23:28:04] New review: Krinkle; "Dont' set Verified if jenkins is working. I'll disable it if that makes it easier for you." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70751 [23:28:58] dr0ptp4kt, any issues? [23:28:59] New review: Krinkle; "Don't set Verified on repos with Jenkins gate-and-submit. I'll can disable if you prefer." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70751 [23:29:12] need to deploy asap [23:29:50] yurik, about to test. [23:32:20] New review: awjrichards; "Is this related to bug 49208 or bug 48551 - or both? It seems to me it's more related to the latter." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70558 [23:34:13] New review: awjrichards; "PS the reason I ask is because the topic for this patchset is bug/49208" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70558 [23:36:13] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/70770 [23:36:26] yurik, i code review +2'd [23:36:32] dr0ptp4kt, thx [23:36:35] deploying [23:40:29] yurik, cool. be sure to go back in and set the all-languages-supporting ones to have an empty value! [23:40:39] of course [23:45:52] New patchset: Jdlrobson; "Rewrite language overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70565 [23:47:31] New patchset: Jdlrobson; "Correct left padding on headers and footers in 'list' overlays" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70566 [23:47:49] New patchset: Jdlrobson; "Story 836: Promote language search to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70567 [23:55:23] New review: Jdlrobson; "All issues are now addressed" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70323 [23:57:18] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70567 [23:57:18] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70566 [23:57:18] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70565