[09:43:26] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71326 [16:02:17] brion: imma prep for app store update. Help test final bits? [16:02:42] \o/ sure [16:05:51] * brion downloads windows 8.1 ver of visual studio to see what's changed [16:06:29] brion: the gerrit bot won't work because labs is down [16:06:36] nooooooo [16:18:57] visual studio 2013 syncs settings in the cloud, oh my [16:19:01] software privacy is dead! [16:20:41] course my software's all open source and mostly on github [16:20:51] so i don't much care if they're scanning my code s3kr1tly [16:21:50] brion: maybe color schema and key bind discrimination will be a thing [16:22:21] i dream that someday developers will be judged on the quality of their code, not by the color of their editor windows [16:22:50] :D [16:23:05] so the good news is, we don't have to update the app to windows 8.1 stuff to get it to work with their new search goodie. [16:23:15] * YuviPanda waits for the bad news [16:23:16] but i should still do a bug fix release at some point [16:23:23] it'll take a half hour :) [16:23:31] :D [16:23:36] no bad news yet :P [16:23:41] well that was it [16:23:44] not so bad i guess [16:30:08] hmmm [16:30:23] it sounds like we'll eventually need separate app builds for windows 8 and 8.1. that seems….. lame if true [16:36:55] brion: two patches coming up [16:37:03] +2? [16:37:10] gaarojasgk;sdgjagasgs gerrit [16:37:13] pos [16:37:23] cat again? :) [16:37:36] no that's just me swearing at gerrit [16:37:40] hah [16:43:00] brion: https://gerrit.wikimedia.org/r/71368 [16:43:07] https://gerrit.wikimedia.org/r/71369 [16:43:11] * brion looks [16:44:13] YuviPanda: +2'd [16:44:20] both? [16:44:22] yeah :) [16:44:23] ya [16:44:25] let me prep release [16:44:34] brion: can you throw the master on 2.3 and test? [16:44:45] i just booted up my nexus1 :D [16:44:51] wonndeerrful [16:48:12] no obvious probs [16:48:17] New patchset: MaxSem; "Card 856: Allow to disable mobile view on some pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71299 [16:49:25] brion: upload stuff? [16:49:31] brion: also rotate screen around? [16:50:01] brion: okay, I've signed apk, can you put them on dumps? [16:50:08] mailing you nao [16:50:55] no surprises on photo upload with lots of rotating [16:50:57] ok [16:51:19] brion: sent [16:51:43] brion: MD5 (commons/commons-v1.0-beta9.apk) = 4001f4f5faebf0f3cc831ecfb562aa88 [16:53:27] YuviPanda: http://download.wikimedia.org/android/wikimedia-commons-1.0beta9.apk [16:54:13] brion: \o/ [16:54:38] testing release version on 2.3 [16:54:42] wooot [16:54:48] i'm tesitng on my 4.1 phone [16:55:00] nobody deleted my upload called "Test test test delete me" [16:55:02] oh commons [16:55:20] at this rate I'm pretty sure apps' deletion rate is lower than it should be [16:55:33] because web has taken ire away from us [16:55:43] heh [17:00:30] The error that the other server returned was: [17:00:31] 550 Address mobile-feedback-l@wikimedia.org does not exist [17:00:34] hmm [17:01:06] YuviPanda: forwarded you a crash report that apparently isn't making it to the feedback address [17:01:10] brion: should be lists. [17:01:23] i hear LDAP's partially fucked today, it might be related [17:01:37] brion: mobile-feedback-l@lists.wikimedia.org [17:01:39] is the correct URL [17:01:42] we need to rebuild [17:01:43] garrr [17:01:49] whee [17:02:27] i knew it would be a pain to remember @lists. :) [17:03:01] brion: does that happen everytime you type in the title field? [17:03:31] YuviPanda: every time when selecting that image, at least [17:03:44] dat eezzhh weiird [17:03:46] try another one? [17:03:59] tried a fresh photo [17:04:05] typed "s" into title field, CRASH [17:04:28] 2.3, right? [17:04:30] yeah [17:04:35] okay looking [17:05:34] brion: do you see an 'upload' button in the action bar at all? [17:05:38] let me bust out my 2.3 device [17:05:45] lemme check [17:06:01] yeah i see it [17:06:12] ok, must be an orering issue. let me check [17:06:49] also crashes if i rotate on the title/desc input screen [17:08:07] brion: looking [17:08:54] nothing looks obviously wrong to me… menu resource looks ok [17:09:01] only change i remember making to it was switching the icon out [17:09:06] and it displays ok so... [17:10:33] brion: so just this crash then? [17:10:45] yeah but it's kinda a doozy :D [17:10:48] yes [17:10:54] found my 2.3 device, testing now [17:11:20] ;'[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[/y6gt [17:11:21] cat [17:11:32] doesn't crash in a fresh local build from master [17:12:20] hahaha [17:12:24] some smiley from the cat [17:13:02] no crash in local build off master plus upload-to-commons.patch [17:13:06] weeeeeeeeird [17:13:11] waaat [17:13:29] lemme refill my coffee for the standup, brb [17:14:47] dr0ptp4kt, GRR, now we have two dr* - you and drdee :( [17:15:40] brion: can repro crash on fresh master build [17:15:50] dr0ptp4kt, that first patch is ready (cleanup), but it really needs another cleanup - making it so that there is only one func to call render*() methods [17:16:15] yurik, :) , okay, will take a look at that after i get through email. cool? [17:16:25] sure, thx! [17:16:34] brion: standup starting [17:16:51] Maryana, how did you get to the office today? [17:17:07] i spent the night w/friends in the city :) [17:17:14] though now i'm not sure when i can go home... [17:17:23] tomorrow? ;) [17:17:24] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=49288 has been marked as fixed as of https://gerrit.wikimedia.org/r/#/c/67877/2 [17:17:30] (maybe) [17:17:41] hopefully! i only have enough clothes for another day [17:18:13] I'm going to try and take a bus and hope that it's no longer going to be overcrowded [17:18:24] hrm, do we need anyrhing else? (eg that card about WV-specific nearby mode) [17:19:08] MaxSem: i think the bug itself is resolved (making sure that we can specify a nearby 'range' in config) [17:19:28] the rest is an enhancement that's covered in the story card and i think is fairly low priority [17:20:16] ok, so I'll enable it tomorrow [17:20:24] :D [17:20:41] mr foursquare tweeting about nearby now.. :) : https://twitter.com/naveen/status/351724312224481280 [17:21:05] Maryana: what is the other sticker on the right of your screen? other than the wiki globe sticker? [17:21:21] {{citation needed}} :D [17:21:24] aaah [17:21:29] nice :) [17:22:05] ^ jgonera awjr MaxSem YuviPanda [17:22:29] :) nice [17:23:00] cool, but then he says he prefers an app from itunes though... [17:23:03] jcmish: are you coming to the ops meeting today? (if it's on with the BART strike?) [17:23:54] would love too [17:23:57] can I get the invite? [17:24:01] jcmish: sure [17:24:26] jdlrobson, do we need to extend the nearby range for WV now? [17:24:29] Maryana: can we move our meetup to tomorrow again? [17:24:30] jcmish: got it ? [17:24:38] MaxSem: yeh i'm not sure what to though.. [17:24:40] jcmish i was just gonna ask :) [17:24:45] MaxSem: maybe 10km to start with? [17:24:54] the web nearby is awesome, but only because the one in the app is comparitively from the stone ages :) [17:24:54] :P [17:25:08] YuviPanda: I think the app went wrong by making a map the default personally [17:25:10] Maryana: damn betalabs D [17:25:10] :D [17:25:21] betalabs + quarterly review [17:25:29] OH YEAH [17:25:29] agree, jdlrobson [17:25:31] YuviPanda: I think the map should be secondary and the list is typically the most interesting [17:25:36] agree again [17:25:53] YuviPanda: tuesday we will have nearby on EVERY geolocated page (alpha) [17:25:53] jdlrobson, it's already so [17:25:56] I wish we had re-evaluated a lot of the fundamental assumptions of the app a fair amount of time ago [17:26:17] MaxSem: we should just turn it on then :) http://en.m.wikivoyage.org/wiki/Special:Nearby [17:26:24] wee [17:26:38] jdlrobson: I see it is it the one on the wikimedia calendar Tech Ops Staff meeting? [17:26:46] jcmish: that's the one - you got the email? [17:26:58] brion: grr, my air isn't powerful enough apparently to both run intelliJ and power my external monitor at the same time [17:27:05] ;_; [17:27:13] indeed [17:27:20] jdlrobson: just got it now [17:27:20] thanks [17:30:09] so any requests from ops today? [17:30:23] apart from the upcoming cache flush [17:32:03] jgonera: https://www.dropbox.com/sh/oytuxmzo3nvx8sz/s3v8qbH2fm#f:Edit.png < looks bad quality? [17:32:28] jgonera: or is that just me? [17:32:42] jdlrobson, it does, and I'm not sure about that non center alignment with lots of margin... [17:32:48] ergg [17:33:16] Maryana: jgonera i thought we were going to go with reddy gray for disabled state? [17:33:19] I asked May to send me SVGs to play with that myself and understand better what the problem is but I still haven't got them [17:33:38] jgonera, i saw a fb update from may saying she was in atlanta [17:33:45] i think she has some family emergency going on [17:33:56] oh... [17:34:15] I see, I'll ask Vibha later, maybe she has those files too [17:34:26] Maryana: oh dear [17:35:53] ok, let's see how quick that colourful Mission bus takes me to the office, see you there [17:36:39] brion: in what I call 'WTF?!?!', the bug appears only in release versions :| [17:36:41] or rather [17:36:45] only when not in debug mode [17:36:57] that's….. awesome? [17:37:05] where by awesome i mean "not awesome" [17:40:06] brion: oh dear. now the same code I used to build the first apk works :| [17:40:08] no modifications [17:40:09] whatsoever [17:40:10] needed [17:40:13] i'm... very confused now [17:40:18] might be a build artifact [17:40:23] O_O [17:40:24] ugh [17:40:24] * YuviPanda cleans [17:40:28] when in doubt, clean it out [17:40:29] jcmish: you can talk about beta labs problems today if that's good with you? [17:40:35] brion: let me make another build and send you, and then test on your 2.3 [17:40:39] ok [17:40:39] yup! [17:43:36] brion: I like our separate landscape views. we should do that for login screen too! :) [17:43:51] :D [17:45:54] brion: works now [17:45:56] meh [17:46:00] different md5 too [17:46:02] emailing you now [17:46:10] whee [17:46:24] well of course the md5 is different, zip format includes timestamps and crap [17:46:31] great for consistency eh? :) [17:47:07] brion: :P [17:47:11] very much, yeah [17:47:19] brion: emailed. test and dump? [17:47:57] moment [17:49:44] tfinc: re: 'tablet app' - if we do it we will do it as adding support to current apps to be better on tablets, rather than full fledged separate app. [17:50:18] no crashy [17:51:13] brion: that makes me sad. [17:51:14] :( [17:51:23] brion: okay, check on other devices too! I'm checking on S3 now [17:51:31] MD5 (wikimedia-commons-1.0beta9.apk) = 992fdefb7f58133ed40532c89737ad38 [17:51:34] http://download.wikimedia.org/android/wikimedia-commons-1.0beta9.apk [17:51:54] testing nexus7 [17:55:11] seems working [17:55:46] to me too [17:55:49] final test before I push [17:56:02] brion: can you do 'upgrade' testing? [17:56:13] brion: uninstall, install market version, then install new apk? [17:56:18] YuviPanda: uh…… ah yeah [17:56:26] was thinking "all my data's been deleted a hundred times" [17:57:08] hehe :D [18:00:19] aharoni: the android 3 letter code bug is now been assigned to someone to work on :) [18:00:49] YuviPanda: ok no obvious explosions on update. it sees all my photos [18:01:24] jcmish: joining? [18:01:33] already here [18:01:39] hmm, got an 'out of memory' error on nexus1 from volley when paging quickly through the detail view [18:01:53] I don't see you though jdlrobson [18:02:01] ha [18:02:02] now I do :D [18:03:00] brion: crashes? [18:03:10] YuviPanda: intermittent, only got it once today [18:03:19] brion: file a bug, I think. we need to work on the image caching a bit more, i think [18:03:21] brion: i'm going to release now. [18:03:26] ok wheee :D [18:05:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=50509 [18:06:31] brion: hit publish [18:06:40] \o/ [18:06:41] wheeeeee [18:06:46] now to email [18:13:32] jdlrobson: is it a known bug that on experimental, on Android, articles continually reload? [18:13:46] ragesoss: which page? [18:14:05] but i can imagine that being a problem… we're working on a solution to a related problem [18:14:08] https://en.wikipedia.org/wiki/%22Weird_Al%22_Yankovic [18:14:32] I guess it has to do, again, with characters that are supposed to be rewritten. [18:14:41] or not rewritten. [18:18:29] ragesoss: android app update just went out, btw :) [18:18:49] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71136 [18:19:05] YuviPanda: sweet. [18:19:31] that reminds me, I've yet to test it on my android tv stick + webcam. [18:19:40] ooooo [18:19:40] please do :D [18:19:47] yesss [18:19:47] dooo eettt [18:19:54] man i should dig up an official Google TV product somewhere [18:20:22] though i think i've used up all my HDMI ports [18:20:36] "4 hdmi ports ought to be enough for anybody" [18:20:51] brion: you need one of those 3-way hdmi switches. [18:21:13] well that gets me to… 6? [18:21:18] then i can plug the PS3 back in [18:21:29] i only use it for katamari [18:21:59] these fancy data buses should have daisy-chaining like thunderbolt [18:22:23] of course, i've yet to see a thunderbolt widget other than a monitor that actually has a passthrough [18:22:27] maybe some of those drive enclosures and things [18:22:34] yeah, but unlike thunderbolt they actually have devices that use them :P [18:22:43] burrrrrn [18:23:20] what's server for the nightlies? [18:23:26] who's needed at that "QUARTERLY REVIEW MEETING"? [18:23:34] (are they still pointed to test?) [18:23:39] ragesoss: yes, [18:23:45] and err, nightlies in topic are wrong [18:24:22] integration. found it. [18:25:17] ragesoss: and yeah, they're pointed to test [18:25:26] ragesoss: oh, and you can find out where they are poitned to at the bottom of about now [18:30:11] ragesoss: delete https://commons.wikimedia.org/wiki/File:Gfdz.jpg? :) [18:31:32] ^ tfinc awjr what MaxSem said [18:33:21] YuviPanda: deleted. [18:33:24] ty [18:33:27] crash report coming your way shortly. [18:33:33] :) [18:33:33] ow [18:33:41] bad! hopefully not in something very common :) [18:33:48] ragesoss: did you see the campaign plans? [18:33:58] a bit [18:35:18] enough to form thoughts? [18:35:22] on usefulness? [18:37:30] YuviPanda: you mean https://www.mediawiki.org/wiki/User:Yuvipanda/Mobile_campaigns ? [18:37:50] yeah [18:37:53] that's the one [18:37:56] yeah, totally useful. [18:38:49] can you help tell me some more use cases that are more concrete? [18:39:02] bioblitzes [18:39:04] and more 'it happened at this event at this place' [18:39:09] waah? [18:39:15] those would be a cool thing to support. [18:39:55] ah [18:39:56] nice! [18:39:56] basically, an even where a bunch of people take pictures of, and upload, and try to identify, different living organisms [18:39:59] yes, it would be [18:40:05] it even has a wikipedia entry, looks like :D [18:40:20] ragesoss: also seen https://www.mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace_proposal which is associated? [18:40:25] and which is what I'm currently working on? [18:40:33] I did a bioblitz with Haitham and Kaldari when I was in SF, and we used an app called iNaturalist [18:40:51] but I thought, this is the kind of thing that WMF infrastructure ought to be able to handle. [18:40:57] indeedy! [18:41:11] should be easy to do with campaigns, methinks [18:41:24] yeah, I saw that namespace proposal too. makes sense to me. [18:41:30] jdlrobson should stick around for the whole quarterly review in case there are questions, everyone else (MaxSem, etc) is optional but highly encouraged to be there (particularly for the first half or so) [18:41:44] ok [18:41:52] in an "I'm just looking at coder gobbledegook" kind of way. [18:42:27] awjr, can you review https://gerrit.wikimedia.org/r/71299 and https://gerrit.wikimedia.org/r/71381 before the meeting then? [18:42:31] ragesoss: just this section at least? https://www.mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace_proposal#Proposed_System [18:42:35] i'll try MaxSem [18:42:47] awjr: ok [18:43:33] ragesoss: what device was that crash at? and what were you doing? [18:43:54] ragesoss: and are the images visibly 'sharper' than before? [18:43:58] they're loading at a higher resolution [18:45:37] YuviPanda: it's a mk808b android stick. [18:45:47] aaah [18:45:49] rk3066 chipset [18:45:55] ragesoss: so it tries to fetch an image as big as your screen, I think [18:45:57] and then fails hard [18:46:03] my screen is not that big. [18:46:09] well, resolution anyway. [18:46:13] how big? [18:46:18] and RAM on the stick? [18:46:22] 1GB [18:46:24] hmmm [18:46:27] it's running at 720p. [18:46:43] well, we still want to tune the cache anyway [18:46:43] it crashed when I opened the camera [18:47:06] but then, when I opened it again, it was already open to camera [18:47:06] and I took a pick [18:47:06] pic [18:47:11] and it crashed again [18:47:20] sent crash report again? [18:47:24] then, it kept trying to reopen, and would immediately crash. [18:47:41] I can't get the crash report off, because underneath, it reopens and pops up a fresh crash report dialog. [18:47:59] and my interface is an awkward DroidMote connection. [18:48:16] gah [18:48:30] I gotta go, but I'll play with it again later. [18:51:21] at least my quassel server that runs on that stick stayed up. :) [18:53:19] ragesoss: :D [18:54:00] $46.84 on amazon? i may as well get one :) [18:54:32] brion: :D double check on reviews there and elsewhere before buying though. Some have bad parts [18:55:53] ok, food and stuff. brb [18:58:47] hmmm it's not clear to me that it's actually got the google tv interface. from the screens i see there it's acting more like a tablet o_O [18:58:52] eh i'll fiddle later :) [19:02:02] New patchset: Jdlrobson; "Bug 50255: Talk page shows a talk button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71389 [19:03:14] MaxSem: can you provide more context about https://gerrit.wikimedia.org/r/#/c/71381/3? the reason for this change is not clear to me [19:05:23] awjr, we need a non-null title object, whic is not possible with $wgExtensionFunctions [19:05:45] because we need the title now for page blacklisting [19:06:25] MaxSem: from just looking at the code though i don't see how wmfSetupMobileLoadScript has any impact on title? [19:06:58] oh because of shouldDisplayMobileView() [19:07:08] that's where you're handling the blacklisting [19:08:12] MaxSem: then why the separation for $wmfRealm? [19:08:35] this stuff is very fragile, I want to test on labs first [19:08:50] ah i see [19:09:03] can you make that clear in the code and/or commit message? [19:10:00] New patchset: Jdlrobson; "Bug 50212: Enable talk on project pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71390 [19:12:21] done [19:13:19] tfinc: am I required for the meeting later today or optional? [19:13:24] (just checking) [19:14:49] MaxSem: can i +2 it or should i just +1 for now? (https://gerrit.wikimedia.org/r/#/c/71381/4) [19:14:55] +1 [19:15:31] done MaxSem [19:15:45] thanks!:) [19:16:32] im looking at the other now - MaxSem can you explain what happened with the reversion of https://gerrit.wikimedia.org/r/#/c/71098/? [19:16:49] title was null [19:16:50] or rather, why that reversion happened? ^ [19:16:58] broke labs [19:17:01] gotcha [19:17:22] so now we check for title https://gerrit.wikimedia.org/r/#/c/71299/3/includes/MobileContext.php [19:17:32] and it should be fine in either labs or prod [19:17:37] regardless of that config change [19:17:38] this one is revised, will not explode in such situation (but neither will it blacklist) [19:17:42] yeah [19:19:22] we could just pass $title in from the BeforeInitialize hook too [19:36:31] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71154 [19:39:29] awjr: greetings from the hangout [19:39:29] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71299 [19:39:35] ahoy tfinc [19:50:46] New patchset: Dr0ptp4kt; "Reduce number of clicks to see an image on .zero from 3 to 2." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71406 [19:51:47] "iTunes will erase and restore your iPad to iOS 7.0 and will verify the restore with Apple." [19:51:50] wooooo living on the edge [19:51:51] yurik, would you please review change 71406? [19:52:48] dr0ptp4kt, why this change? it was never needed before [19:52:59] (the clearHTML() [19:53:40] yurik, i think you're right, only the url probably needs to change. uno momento [19:54:40] awjr: I can hear your echo [19:54:50] dr0ptp4kt, i am fairly reluctant to make a change like this because that last change for Minerva skin hook, it now appears the render code runs twice, and looks extremely suspicious, so it needs to be fixed first [19:54:53] New patchset: Dr0ptp4kt; "Reduce number of clicks to see an image on .zero from 3 to 2." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71406 [19:55:28] awjr: echo gone :) [19:56:21] dr0ptp4kt, what if $zeroRatedLinkHref already contains a query with a question mark? [19:57:34] yurik, will get back to you on that. gotta think through the case where the link class is 'image' [19:58:54] New review: Yurik; "(1 comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: -1; - https://gerrit.wikimedia.org/r/71406 [20:00:09] awjr: who? [20:00:25] YuviPanda: kenan, new product manager [20:00:29]