[00:10:18] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71389 [00:11:03] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/71514 [00:23:52] New review: Dr0ptp4kt; "Tested on local VM." [mediawiki/extensions/ZeroRatedMobileAccess] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/71134 [05:51:01] New patchset: Mgrover; "fixed partial search test" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71578 [06:38:21] New review: Mgrover; "ul element changed" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/71578 [06:38:43] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71578 [09:25:45] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71326 [16:04:06] New patchset: Jdlrobson; "Bug 50571: Make plural work for mobile-frontend-diffview-editcount" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71630 [16:10:59] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71630 [16:21:42] hi YuviPanda [16:21:48] hey orsa [16:22:09] familiar with the android studio revision control? [16:22:33] i try to commit to our new project [16:23:10] don't use that [16:23:13] just use git from the command line [16:23:26] the integrated version control stuff is sortof buggy and convoluted [16:24:31] orsa: ^ [16:24:50] also did you read the docs on git review and gerrit? the workflow is slightly different than that of GitHub [16:24:57] ahh alright [16:25:13] do poke niklas too, he has a lot more experience with Gerrit than I do :)) [16:25:20] i did, partially.. :)\ [16:25:44] ok, ill poke him [16:25:47] thanks [16:26:40] there's a meeting in 30mins too [16:26:47] i better get some stuff done before that [16:26:48] brb [16:43:25] orsa: managed to push? [16:43:51] no [16:44:31] problems? [16:45:07] YuviPanda: actually, where should i see it? [16:45:29] it should be there in mediawiki.org [16:45:39] https://www.mediawiki.org/wiki/Gerrit [16:45:41] has tutorials, etc [16:46:03] orsa: you should also join #wikimedia-dev :) [16:49:39] thanks, ill look at that [16:50:36] but i meant where should i see my successful commit? [16:51:25] search through http://git.wikimedia.org/ [16:51:33] or gerrit.wikimedia.org [16:51:36] but read the tutorials first [16:52:18] no problem, see you in 5 [16:52:23] or 8 [16:52:37] :) [17:05:34] heyyyyy kaldari [17:05:44] hey [17:06:03] are you at the office? [17:06:10] yes [17:06:15] at my home office [17:06:19] :) [17:06:26] that's right, dumb question :) [17:06:27] kaldari: welcome to the team :D [17:06:38] thanks [17:07:54] do you already have a crash course scheduled? [17:08:17] Sort of, Jon is supposed to be on-boarding me, but haven't heard from him yet [17:08:46] one thing I'd like to know is how do you use Bingle? [17:09:55] Bingle or Mingle? [17:10:18] Bingle, already know how to use Mingle [17:10:37] is Bingle automatic or does it have some sort of interface? [17:10:56] automatic afaik [17:11:48] does it just import everything assigned to the MobileFrontend component or is there a tag you use? [17:12:26] probably just need to read the documentation for it in github :) [17:13:02] Are we deploying anything today? [17:14:55] yes [17:15:55] we usuall use every our window [17:16:49] Do you usually just deploy MobileFrontend (plus core dependancies) or are there other extensions that you guys work on commonly? [17:18:06] MF is closely related to ZeroRatedMobileAccess, so if there is a breaking change we deploy both [17:18:22] otherwise the Zero team have their own window [17:18:42] good to know [17:20:40] kaldari, how much do you know about MF? [17:20:58] almost nothing :) [17:21:55] if you know of any easy bugs I can start on, to get my feet wet, let me know [17:23:29] there's an easy bug https://bugzilla.wikimedia.org/show_bug.cgi?id=50397 in this iteration, however it has nothing particulary mobile:) [17:24:59] I'll take it :) [17:26:00] Hmm, looks like someone needs to add my Mingle user to the Mobile project [17:26:09] Maryana, ^^^ [17:26:12] brion: https://itunes.apple.com/il/app/translatewiki.net/id661133065?mt=8 [17:26:30] woooo [17:26:50] ruh roh… i sure hope i'm an admin on mobile mingle... [17:27:56] :D [17:28:13] Maryana: can you make me a mobile mingle mogul? [17:29:05] Maryana: https://itunes.apple.com/il/app/translatewiki.net/id661133065?mt=8 is TranslateWiki.net mobile app, student project with mentoring from the language engineering team (and a little bit of me) [17:29:06] :) [17:29:12] iOS, so do check that out some time [17:29:47] oooh [17:31:00] Maryana: same student is now doing GSoC (me and Niklas are mentoring), to do the app for Android [17:32:31] Maryana: my mingle user is "Kaldari" [17:33:13] looks like you are a project admin [17:33:29] as is Michelle Grover. Who's Michelle Grover? Have I met her? [17:33:42] kaldari: jcmish is Michelle. [17:33:50] kaldari: Michelle Grover == jcmish our resident QA [17:33:55] ohai tfinc. [17:34:03] ah [17:34:10] howdy kaldari :D [17:34:15] hello [17:34:45] YuviPanda: yo, just got in. give me a couple minutes to get settled and we'll get going @ 10:45 [17:34:45] tfinc: re: 1-on-1, I'm in the hangout. [17:34:47] sure [17:34:50] tfinc: no issues [17:34:58] jcmish: I just started with the mobile team. Are you local in SF or remote? [17:35:18] "kaldari has been added to the mobile team successfully" :) [17:35:29] Maryana: rapid! [17:35:37] yeah, we're pretty agile [17:35:40] no big deal [17:36:00] I'm remote in CO [17:37:46] I just assigned myself a mingle card for development [17:37:53] hope that's cool [17:38:05] dr0ptp4kt, remove GetMobileNotice in favor of what, MinervaPreRender? [17:38:18] so we usually have stand-ups every other day? [17:38:36] yep - do you see them in your calendar? [17:38:46] jcmish: cool, I'm remote in Oakland, but only during the BART strike :) [17:39:08] MaxSem: Yep, looks like Arthur added me on them [17:40:22] greg-g, can you add kaldari to "MobileFrontend updates [Arthur / Max]" in GCal? [17:41:21] MaxSem: to the invite, not the subject, right? [17:41:30] ha kaldari HILARIOUS [17:41:34] how goes the strike? [17:41:45] mhurd: see https://itunes.apple.com/il/app/translatewiki.net/id661133065?mt=8 [17:41:48] * greg-g reads scrollback and assumes [17:41:49] yes [17:41:53] mmm, prolly worth dropping everyone out of the subject? [17:42:08] oh, kaldari is already on the invite list [17:42:11] mhurd: translatewiki.net app built by a student in collaboration with the language team (and some help from me) [17:42:33] owchie [17:42:39] MaxSem, MinervaPreRender is already called from the html rendering context. so the thought is instead of both MinervaPreRender and GetMobileNotice for the html rendering context, just use MinervaPreRender. [17:43:10] dr0ptp4kt, it's not available in WML [17:43:30] MaxSem, what's not available in wml? [17:43:39] MinervaPreRender [17:44:40] MaxSem, exactly - in the wml context GetMobileNotice is called. [17:45:04] YuviPanda: nice!!! [17:45:10] yep - so you should remove banners from MinervaPreRender, not GetMobileNotice [17:46:01] are you saying that the MinvervaPreRender hook should clear out banners? it already does that? [17:46:33] don't do anything banner-related in MinervaPreRender, that's what I'm saying [17:46:59] the MinervaPreRender hook implementation *has* to empty the banners array in order to prevent display of central notice banners. GetMobileNotice does not provide access to the banners array, it only passes a string. [17:47:27] mmm, so GetMobileNotice needs to be modified;) [17:47:29] ^MaxSem, i'm not sure if the timing of GetMobileNotice would provide late enough access to overwrite banners even if it did pass them. [17:48:19] MaxSem, so are you saying that GetMobileNotice should be moved to both/all skins (or their superclass), and then the banners should be passed from the hook caller to the hook callee? [17:48:57] $notice = ''; if ( $displayCN ) $notice .= '
'; wfRunHooks( 'GetMobileNotice', array( $notice ) ) [17:49:41] please understand one thing: if you want to use only one hook, MinervaPreRender can't be that hook [17:51:23] MaxSem, we need MinervaPreRender for treating other aspects of the *html* page, which is fine. i don't mind having one hook *specific to banners*, just want the explicit okay to modify MobileFrontend. zero has to wipe out central notice banners - we don't want to be asking the poorest people who are getting free access to pay wikimedia. [17:52:36] sure [17:53:10] as the matter of fact, I already have a commit centralising GetMobileNotice in bikeshedding [17:53:48] MaxSem, where? [17:54:05] MaxSem, wasn't sure if this was the other thing jdlrobson emailed about the other day. [17:55:08] yes it is [17:59:26] dfoy, yt? [18:01:42] MaxSem, when will you guys have a "final" decision on what you're doing with change 69336? [18:02:09] sigh [18:02:15] we can... [18:02:20] :_) [18:19:35] jgonera: MaxSem when I try to edit in iphone and/or ipads I'm getting the swirl of death [18:19:46] it's not coming back on [18:19:49] betalabs [18:20:06] swirl of death? [18:20:12] :D [18:20:39] spinner keeps spinning [18:20:46] never let's me edit [18:20:54] jgonera, ^^^ [18:21:18] works on chrome without a UA [18:22:48] hm [18:22:56] a new article or existing one? [18:23:01] existing [18:23:08] in beta [18:23:51] just checked, works for me on a testing ipod we have [18:24:04] although, wait, I'll fetch the latest master [18:26:08] Thehelpfulone, so we've prepared a system to blacklist pages on wmf.org ased on category membership - does "Category:Desktop-only pages" sound right? [18:26:46] anyone seen jon yet ? [18:27:07] he's here [18:27:38] jcmish, checked on iPhone 4 too, works for me on most recent master on my local dev instance [18:27:54] :( alright I'll clear my cache [18:27:58] and try again on all the devices [18:27:59] thanks [18:28:00] brion: ping? [18:28:07] YuviPanda: yo [18:28:17] brion: did I already send you that UploadWizard patch link? :) [18:28:27] yeah i'll look over it this afternoon [18:28:33] brion: ty! [18:28:36] :) [18:28:37] Elsie, any comments on that category name (see MaxSem)? [18:28:51] brion: it has like, -1600, so am pretty happy :) [18:34:22] yo jdlrobson [18:34:33] hey MaxSem ! [18:37:36] jgonera: it's working out well [18:37:47] now that I cleared the cache again [18:37:54] ok, glad to hear that ;) [18:37:58] MaxSem: betalabs is giving me an error on upload [18:38:17] jgonera: it sucks because i automatically do that :D oh well [18:38:22] it's better than it being a bug [18:38:48] looking [18:39:06] "Wikipedia doesn’t have an app, just a mobile website" https://twitter.com/allenshull/status/352134230727344129 [18:39:08] Win. [18:39:27] thanks MaxSem [18:41:29] Unhandled Error: Cannot convert 'this.$el' to object [18:41:39] jdlrobson, jgonera ^^^ [18:42:43] hm [18:42:47] file and line? [18:43:40] try yourself on beta [18:43:47] well, again, wfm on master on my local dev env... [18:44:41] huh [18:45:04] empty user or user with uploads? [18:45:20] the problem is that when deployed it will be muuuch closer to beta, not your dev wiki [18:45:26] no uploads [18:45:37] I get a different one though... [18:45:43] Uncaught TypeError: Cannot call method 'appendTo' of undefined [18:46:00] somewhere in Overlay [18:46:12] lunch, bbiab [18:46:27] oh, it's the same error I guess, just different JS engine [18:47:59] what browser MaxSem ? [18:48:10] Opera/desktop [18:50:01] I'm working on a fix [18:50:05] it's every browser [18:58:19] New patchset: JGonera; "Regression: fix a JS error on upload with a nag" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71656 [18:58:29] jdlrobson, MaxSem, jcmish ^ [18:59:23] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71656 [18:59:44] thanks jgonera [19:48:27] yurik & dr0ptp4kt, do we need to deploy Zero? [19:48:50] MaxSem, i will push it out tomorrow - fairly unsure of the result, want to do it separatelly :) [19:53:11] New patchset: Jdlrobson; "Remove echo specific css to reflect html changes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71709 [19:55:02] mhurd: https://twitter.com/MikeLeePearl/status/352113202215133184 :) [19:55:18] selfiepocalypse! [19:57:30] MaxSem: are we ready for deployment? [19:57:35] yup [19:57:44] \o/ [19:57:47] New patchset: Dr0ptp4kt; "Remove superfluous GetMobileNotice call." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71710 [20:02:49] Maryana: jdlrobson jgonera Max is gearing up :D [20:03:34] all right jcmish, jdlrobson, jgonera, Maryana - we're live on testwiki, please test:) [20:03:34] wait [20:03:59] now for real [20:04:02] roger [20:04:08] kayo [20:05:25] heh [20:11:56] Automation Tests all set on to manual testing [20:13:39] something's up with our servers [20:14:16] "Saving edit, please wait." [20:15:17] PHP Warning: filemtime() [function.filemtime]: stat failed for /usr/local/apache/common-local/php-1.22wmf9/extensions/MobileFrontendMobileFrontend.i18n.php in /usr/local/apache/common-local/php-1.22wmf9/extensions/MobileFrontend/includes/modules/MFResourceLoaderModule.php on line 151 [20:15:22] duh [20:18:58] MaxSem: so it's just the servers? [20:19:12] so it's just our code:) [20:19:19] HA! [20:19:21] okay [20:19:49] New patchset: MaxSem; "Argh" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71714 [20:19:54] ^^^^ [20:20:06] jdlrobson, jgonera, kaldari ^^^ [20:20:33] New patchset: Jdlrobson; "Add missing / in filenames" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71714 [20:20:45] good catch MaxSem [20:21:13] looks like jon beat me to it [20:21:45] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71714 [20:24:14] deployed [20:25:31] looks good to me jcmish [20:25:48] rounding the lest test jdlrobson but so far looking good [20:27:59] jdlrobson: I'm good, jgonera Maryana how goes it? [20:28:11] yeah, everything's working fine for me [20:28:58] wait, less than in half an hour? [20:29:12] suspiciously fast! [20:29:59] i know… kaldari must have done some voodoo [20:30:26] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/71710 [20:30:46] I sprayed from WD-40 on tin [20:30:51] from = some [20:31:14] * MaxSem throws a match [20:31:19] :) [20:31:31] Maryana & jcmish, are we ok to scap? [20:31:53] insert obligatory link to scatman on youtube [20:31:53] hahaha MaxSem I say go for it :D [20:32:06] ha Maryana [20:32:17] jon's not doing it, so it looks like i have to.. [20:32:42] http://www.youtube.com/watch?v=y2wMsnE2cvI [20:32:43] http://www.youtube.com/watch?v=3cnQCk0u49w [20:32:44] ^ marktraceur [20:32:48] ^ Maryana [20:32:57] sorry marktraceur for bringing you into our mad world [20:33:39] kaldari we play that song while we wait for scap ^ [20:33:49] sometimes we dance.. [20:34:39] * marktraceur sings you the song of his people [20:34:49] jdlrobson: This happens, like everywhere. [20:34:54] Don't worry about it [20:35:16] oh hahahha [20:37:07] MaxSem: looks like E2 had some css/js file updates that didn't get picked up by all the servers [20:37:14] I just retouched the files [20:37:21] grrr [20:37:22] not sure if you've started the scap yet or not [20:37:40] thaks kaldari [20:38:13] it's rebuilding localisation cache, so it'll get caught up [20:38:21] cool [20:49:37] New patchset: Dr0ptp4kt; "Remove superfluous GetMobileNotice call." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71710 [20:52:15] New review: Dr0ptp4kt; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71710 [20:56:09] New review: Krinkle; "Don't use the "Verified" field on repositories that have a stable jenkins-bot pipeline, it a pointle..." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71134 [20:56:15] New patchset: Krinkle; "Restrict Verified/Submit to JenkinsBot and l10n-bot" [mediawiki/extensions/ZeroRatedMobileAccess] (refs/meta/config) - https://gerrit.wikimedia.org/r/71720 [20:56:23] New review: Krinkle; "Fixed in I67c56648." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71134 [20:56:35] Change merged: Krinkle; [mediawiki/extensions/ZeroRatedMobileAccess] (refs/meta/config) - https://gerrit.wikimedia.org/r/71720 [20:57:28] jcmish, jdlrobson, jgonera, kaldari, Maryana - the scap is over:) [20:57:40] wow [20:57:45] thanks [20:57:46] that was kinda quick no? [20:59:30] I have to keep parity with your testing;) [21:00:36] HA [21:00:37] :D [21:06:48] Automation Tests passed moving on to manual testing [21:11:54] all looks good to me [21:12:01] anybody seeing issues? [21:12:34] Maryana: I'm running through my last tests [21:12:38] but so far looking good [21:17:30] MaxSem: anything to add to this? - http://www.mediawiki.org/wiki/Mobile_support_in_MediaWiki_core - I was hoping we could start defining some RFCs and some sort of roadmap off the back of this [21:17:30] Maryana: MaxSem looks good to me jgonera jdlrobson ? [21:17:38] jcmish: yeh all good with me [21:17:42] seems good [21:17:50] k thanks folks! [21:18:38] jdlrobson, lol - I'm working on https://www.mediawiki.org/wiki/User:MaxSem/Mobile_HTML_transformationns [21:19:21] jgonera: how does tomorrow look for pairing on automation tests? [21:19:47] jdlrobson, one caveat - WAP never heard of CSS;) [21:20:06] oohh true dat MaxSem [21:20:07] mm [21:20:14] well maybe MobileFormatter should be WAP only? [21:20:30] yes, that's what I was thinking about [21:20:53] we've always talked about wap being a standalone thing [21:21:19] s/we/jdlrobson/ [21:21:24] ;) [21:21:37] noo.. brion was the initiator of that idea :) [21:21:45] jcmish, what would be the agenda? [21:22:02] "Brion's dream: One codebase to do everything except WAP" [21:22:05] http://www.mediawiki.org/w/index.php?title=Mobile_support_in_MediaWiki_core&oldid=541313 [21:22:21] jgonera: go through your environment just to make sure everything is working okay [21:22:49] and walk through my backlog of things to automate and get your take on priority etc [21:25:14] jcmish, yeah, we can do that tomorrow, how about 2pm just after story review? [21:25:22] yup that works [21:25:32] jdlrobson, so what are you suggesting to move from DeviceDetection.php? we will eventually kill device CSS - what will remain, mobileness detection? [21:25:58] how moving it to the core will help? [21:27:15] oh WAP [21:27:19] it's a silly thing [21:28:12] MaxSem: it may or may not :) Please add that to the page to explain how it may be unnecessary. The only reason I can see is it may be useful in future if skins become context aware (ie. running in mobile or desktop) [21:29:15] brb [21:30:10] * MaxSem would like us to clean up the stuff first [22:08:28] New patchset: Jdlrobson; "Remove device specific stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71731 [22:08:38] New review: Jdlrobson; "Needs more testing" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/71731 [22:09:34] * MaxSem wets his pants ^_^ [22:09:40] New review: Jdlrobson; "Change got reverted" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/71709 [22:12:01] New review: Jdlrobson; "Looks good to me... Max?" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/71710 [22:21:33] New patchset: MaxSem; "Remove device specific stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71731 [22:24:22] New patchset: Jdlrobson; "Bug 50410: Enable new page creation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71514 [22:33:51] New review: MaxSem; "This change means much more - without per-device CSS, X-Device can die, and $wgMFVaryResources with it." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71731 [22:36:41] kaldari, how are you doing?:P [22:37:13] good. Almost finished with the bugfix. [22:38:08] seen the scary parts already? [22:46:38] nothing too scary yet, but I haven't gone very deep :) [22:59:19] New patchset: Kaldari; "Fixing link to login page so that it returns users to upload page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71736 [23:00:38] MaxSem, jdlrobson: checked in my bugfix. How does code review usually work for MobileFrontend? Do I need to explicitly assign reviewers, and if so should I assign certain people for certain types of changes? [23:02:06] I personally don't need to be added as a reviewer to changes to any of our extensions, I try to monitor all the backend changes. If it doesn't work, just nudge me:) [23:02:33] New patchset: Kaldari; "Fixing link to login page so that it returns users to upload page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71736 [23:02:57] kaldari: i usually just watch gerrit/bugzilla - no need to add me i'll find it [23:03:16] kaldari: can you do translation in that way? [23:03:37] with part of a sentence you mean? [23:04:38] it's usually not a good idea, but in this case, it's the lesser of two evils [23:04:48] yehh [23:04:53] * jdlrobson checks how watch list does it [23:05:11] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/71736 [23:05:28] New patchset: Dr0ptp4kt; "Stop showing 'free' banner for images served on .zero." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71738 [23:05:29] otherwise you would have to have HTML in the i18n message [23:05:35] kaldari: seems to do it the same :) [23:05:36] I've added siebrand to verify [23:05:55] good idea [23:06:20] I also added explicit instructions in the qqq message so hopefully it's not confusing for the translators [23:06:46] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71736 [23:06:58] yurik, would you please review https://gerrit.wikimedia.org/r/71738 ? [23:07:40] yurik, it's dependent on 71406. [23:08:09] yurik, that is to say, i branched from there. it's not technically dependent. [23:09:30] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71736 [23:09:34] New patchset: Kaldari; "Fixing link to login page so that it returns users to upload page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71736 [23:22:04] jdlrobson: tomasz wants me to get an architectural overview of MobileFrontend from you (or Max). I imagine this would be easier in person though. [23:22:51] kaldari: no problem - want to do it tomorrow? [23:22:56] will you be able to get to the office? [23:23:37] I'm going to try to [23:23:53] BTW, I still don't see that planning meeting on my calendar. Is that tomorrow? [23:24:03] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71736 [23:24:36] kaldari: really? mmm.. i invited you today [23:24:48] 1pm [23:24:50] I got the code hygiene invite [23:24:59] eek you disappeared off the invite [23:25:01] how strange.. [23:25:29] kaldari: did you get it now? [23:26:12] nope [23:27:38] mmm [23:27:44] maybe it's because i didn't create it.. [23:28:10] now kaldari ? [23:28:19] ooh.. "An error has occurred. Please try again later." [23:28:43] kaldari: might be worth dropping a mail to Rachel she's the creator [23:28:57] still nothing :( [23:29:12] OK, I'll ping rachel [23:29:50] kaldari: i've sent you a copy in the meantime [23:31:09] MaxSem: still there? Any ideas how we could deprecate the need for the MobileFormatter on the main page? [23:31:16] (but still make it work as it currently does?) [23:31:48] jdlrobson, you're currently relying on JS to format it properly in alpha, right? [23:32:51] alpha does weird things - it simply strips inline styles and restyles tables [23:32:55] but this won't work on windows phones :( [23:33:21] i think the only real long term solution to this is to redirect the Main Page to a mobile main page [23:34:04] personally i would like home page transformations disabled by default though- i recently saw someone optimizing a main page that was already optimized :) [23:34:07] ie. no tables [23:34:51] jdlrobson: finally got the invite [23:35:00] kaldari: ssweeett [23:52:49] New patchset: Jdlrobson; "Allow editing on special cased main page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71742