[00:04:23] New patchset: MaxSem; "Remove device specific stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71731 [00:05:47] Kaldari is on mobile team now?! \o/ [00:06:00] tis true [00:08:02] mmm +126, -643 [00:28:30] Thehelpfulone: What does "Desktop-only pages" mean? [00:28:40] Damn, just missed MaxSem. [00:29:04] pages that will only show in desktop view on foundation wiki due to issues if you see them on the mobile frontend [00:29:37] view them through the mobile frontend* [01:02:03] New patchset: Jdlrobson; "Default to non homepage special casing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71749 [01:09:26] New patchset: Jdlrobson; "Default to non homepage special casing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71749 [01:30:35] New patchset: Yurik; "Reapply "Constrain redirects to Wikipedia Zero partner-sourced requests."" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71753 [01:31:31] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71753 [16:52:37] MaxSem, I guess it's just the two of us for the standup? [16:55:04] dr0ptp4kt, finishing up with 71406 [16:55:28] dr0ptp4kt, could you review https://gerrit.wikimedia.org/r/#/c/71756/ [16:55:30] i'm here, though virtual [16:55:37] would be good to deploy in a few min [16:55:48] Maryana, everyone here is virtual [16:55:52] :D [16:56:41] oh, ok [16:56:50] not sure if Tomasz is coming to the office [16:57:13] ok, I'll set it up then [16:57:37] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71406 [17:00:18] dr0ptp4kt, around? [17:10:53] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71756 [17:12:00] yurik, yeah, i'm here [17:12:16] brion, do we have some newer Windows Phone testing device in the office? something running the newest IE? [17:14:12] jgonera: i have a windows phone 8 device in my cabinet -- is RobH there? he should have a key [17:14:14] it's the nokia [17:15:35] cool, I'll ask RobH [17:16:20] Maryana, today's story review overlaps with tech talk - can we move it forward by 30 minutes? [17:16:40] works for me - check w/jcmish [17:22:17] jgonera: got it? unfortunately like windows phone 7 it has NO DEBUG CONSOLE making it a bastard to debug on :) [17:22:48] yep, got it brion, fortunately I only want to check if position: fixed works well ;) [17:22:52] yay :D [17:25:28] jcmish, what do you think? ^^ [17:25:58] I only seem a message from jgonera and brion [17:26:09] I was rebooting what's up? [17:27:06] dr0ptp4kt, testing time - patches are live... god save the queen [17:27:20] yurik, okay, will look [17:29:10] dr0ptp4kt, could you take a look - is this a major new bug? [17:29:11] http://en.zero.wikipedia.org/wiki/United_Nations [17:29:22] in external linkns [17:29:48] brion, I think I already asked this, but do you know how to clear browser cache on WIndows Phone in general? [17:29:59] MaxSem: ? [17:30:13] jgonera: if it's not in settings…. i don't know :( [17:30:22] jcmish, Maryana, today's story review overlaps with tech talk - can we move it forward by 30 minutes? works for me - check w/jcmish [17:30:22] lemme see if i can bring up an emu here [17:30:34] ah yep [17:30:36] can do [17:31:27] yurik, which symptom are you seeing? [17:31:59] dr0ptp4kt, in external links, the images are "", and clicking on them shows banners in non-wikipedia projects [17:32:02] yurik, the images under "External links"? [17:32:16] yes [17:32:42] yurik, i'm not sure whether that's a bug that entered the system recently or has always been there. [17:33:08] dr0ptp4kt, come to think of it, it might be the result of X-CS spoofing [17:34:07] yurik, oh, ha, i see, those are the icons for those projects! [17:34:30] yurik, the links to the actual wikimedia sites - those i think are a known symptom [17:34:42] oki [17:34:58] yurik, i agree, the X-CS spoofing is what's causing those other wikimedia sites to render strangely as mobile sites [17:35:09] seems like we are really blocked for fixing all of these issues until MaxSem creates a new hook for us :) [17:35:38] yurik!!!! [17:35:42] :) [17:36:44] brion, clearing history seems to do that, although its not a perfect solution because it clears everything else too... oh well [17:36:55] bah [17:36:58] close enough :D [17:37:04] hey brion [17:37:08] hey SickPanda [17:37:34] I'll go off in a wild, rather nauseous [17:37:52] 'We are planning to release a Chromium-based Opera for Linux, but it's not ready yet.' boooooo opera 15 no linux release yet? [17:39:59] yurik, as far as i can tell it's working normally now [17:40:10] s/ now// [17:41:05] dr0ptp4kt, oki [17:41:17] there are a few more patches outstanding, will depl next week [17:41:19] brion: I'm going to go off and try to sleep it off in about 20 mins. Need me to look at anything? [17:41:43] SickPanda: nope i've got you're existing notes to work from so far :D [17:41:49] sleep well and feel better! [17:44:15] yurik, cool. i see no autodeploys this week. good :) [17:44:33] last think anyone needs is to have to get on a call during a holiday [17:48:03] New patchset: Yurik; "Moved special page rendering to dedicated class" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71134 [17:48:34] brion: not sure if my earlier message got through, but I'm going to go off and try to sleep it off in about 10 mins. Need me to look at anything? [17:49:18] SickPanda: go sleeeeeeeep [17:49:27] sounds like a good idea :) [17:49:35] do look at that large patch though. [17:49:41] dr0ptp4kt, grr, forgot to deploy https://gerrit.wikimedia.org/r/#/c/71134/ [17:49:43] could you +2 it [17:49:57] i thought youalready did that one [17:50:25] dr0ptp4kt, still there? [17:50:27] yurik, i did. it looks like Krinkle posted some kind of comment? [17:50:39] oh, that was something else, don't worry about it [17:50:52] could you +2 it again pls [17:51:10] i didn't change it, just rebased [17:51:17] yurik, will do. will have to ask Krinkle what the comments are about. [17:51:44] dr0ptp4kt, we have 9 min of our depl window :( [17:51:59] the comment was about how to use "review" button - you should only +2 [17:52:10] you shouldn't touch "verified" while reviewing [17:52:15] that's what his comment is about [17:52:39] and he disabled it for us [17:53:01] New review: Dr0ptp4kt; "Per yurik's latest comments, no additional code change, just rebase." [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 2; - https://gerrit.wikimedia.org/r/71134 [17:53:05] Change merged: jenkins-bot; [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71134 [17:53:16] yurik, okay. i guess that means code review entails testing. [17:53:27] yurik, just +2'd it ^ [17:53:32] thx :) [17:57:03] yurik, are you able to +2 https://gerrit.wikimedia.org/r/#/c/71738/ as well? [17:57:32] dr0ptp4kt, no, thought that we should fix it a bit more [17:57:45] not very happy with how many arguments we have to pass in [17:58:08] (that's the same feedback i got on my other api patch today btw, so i'm guilty of that myself) [17:59:05] dr0ptp4kt, could you go ahead and test again? just re-deployed [17:59:21] yurik, what was added? anything? [17:59:50] dr0ptp4kt, the special page [17:59:57] that last patch [18:00:08] yurik, only the first two arguments actually need to be passed to that method. we could even get it down to 1 if we were willing to use $wgOut as a global. [18:00:12] yurik, okay, cool, will test [18:04:49] yurik, it seems to be working [18:06:04] dr0ptp4kt, great, i'm finishing up wmf9 deployment, all is good :) [18:07:01] yurik, excellent. [18:07:14] is MaxSem around today? [18:07:22] he is [18:21:44] brion: there's an email to mobile-feedback-l, in french, with a bunch of feedback. But I liked the end, which Google Translate tells me is [18:21:48] <6> .... But hey, the appilcation works as is where my 4/5 because it can be very useful (do not have to go through USB & PC to join Wikimedia Commons). [18:21:49] THANK YOU. [18:21:49] :) [18:22:07] \o/ [18:22:09] yayyyy [18:23:43] MaxSem, hey, didn't see you comment. Any hope to get a new hook? pls pls pls? [18:24:40] yurik, depends on https://gerrit.wikimedia.org/r/#/c/69336/ [18:25:25] MaxSem, i can +2 it now :) [18:26:28] New patchset: Dr0ptp4kt; "Stop showing 'free' banner for images served on .zero." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71738 [18:28:33] ^yurik, made small tweak to renderBanner so that it will only technically require the $config value. also took off two unnecessary null args from invocation from within PageRenderingHooks.php. the invocation from ZeroConfigContent.php by definition uses all params. [18:31:47] MaxSem, would you please +2 https://gerrit.wikimedia.org/r/71710 ? once you guys have 69336 figured out, i'm happy to go in and rewire things with respect to the banners. but i don't see the point of introducing further merge conflicts at this point. [18:32:36] (MaxSem, i'm assuming once you guys have 69336 figured out i will have some license to rewire in MobileFrontned. you know what people say about assuming, of course.) [18:44:30] Maryana: do you have a minute to discuss the stories for today? [18:44:56] sure; i'm checking in w/vibha on the design stuff at 12 [18:45:02] want to talk now or after that? [18:45:06] let's do after [18:45:12] k [18:45:14] I doubt we can make it through is 15 mins [18:45:15] i'll ping you [18:45:22] sweet thanks [18:45:37] np [18:58:37] New patchset: JGonera; "Fixes to animations (transitions) and notifications" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71855 [19:02:00] New patchset: JGonera; "Fixes to animations (transitions) and notifications" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71855 [19:14:05] yurik: Code review doesn't entail testing as much that it doesn't entail jenkins execution. [19:14:33] Krinkle, ? [19:14:40] If you perform your own tests (e.g. install it, interact with it locally, verifify it works) that can be communicated as CR+2 or with a textual comment [19:15:01] but the "Verified" field is exclusively intended for automated tests, because they block other commits if they fail but are overridden. [19:15:06] a superset, not a subset. [19:15:09] Anyway. [19:15:26] Dont worry about it, I just disabled the confusing buttons. [19:15:27] Krinkle, i only do +2 verified + submit & publish only during deployments to speed up core update, as i need to deploy right away [19:16:00] for example if I add the latest version of the extension to core wmf branch [19:16:14] otherwise yes, i only do +2 review [19:16:40] I don't see how being in a deployment means the commit doesn't need unit testing? You'll have to wait a few seconds like everyone else. [19:17:30] If jenkins is failing and the deployment needs to happen immediately, you can ask a gerrit admin (not me) to bypass Verified, but in general there is no excuse. I didn't create this, I'm just making sure it keeps woring. [19:17:41] working* [19:24:12] tfinc: I just tried to send a crash report from the android app to mobile-feedback-l... [19:24:22] and got a 550, address does not exist error. [19:24:48] ragesoss: eek. on a phone call right now. can you mail mobile-tec [19:24:51] Krinkle, i am totally fine with unit tests, BUT during deployment I do git add extension/X, git commit and git review -- so the change is only which version of the extension is linked to WMF branch. I don't think unit tests cover this, yet these steps are done under a big time constraint inside the deployment window. Since sometimes the unit tests halt, we can't wait for them to finish for this [19:25:14] tfinc: will do. [19:25:20] (if I can) [19:25:46] yurik: the commit hash shouldn't change (other than getting an extra merge commit on top). Also, you could do this before the deployment window and in the deployment window only merge the change in core/wmf and deploy that. [19:25:57] Anyway, I'm not having this argument. Nothing I can/should be doing about it. [19:26:04] New patchset: Jdlrobson; "Bug alpha: Ensure heading is correct on nearby overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71860 [19:29:00] tfinc: you mean mobile-l? [19:32:57] ragesoss: that works [19:33:48] tfinc: I think I just sent it successfully to mobile-feedback-l@lists.wikimedia.org (as opposed to just @wikimedia.org, where the app points) [19:35:45] jcmish, ok, done checking in w/vibha - want to chat about stories? [19:36:20] yup [19:36:28] hangout? [19:36:52] sure thing - lemme whip one up real quick [19:36:59] you beat me to it :) [19:40:47] dfoy, re http://meta.wikimedia.org/wiki/Zero:639-02 --- that extra IP you added today is a NOOP [19:41:53] dfoy, also, the new logic for banners is in - now it should render in whatever language is the default [19:48:40] jgonera: I can only meet until 3pm PDT today [19:48:45] I have to take my son to the dentist [19:48:52] do you want to change it to friday? [19:49:53] jcmish, we can change it to Friday [19:50:16] although my calendar shows two story review meetings, today, so maybe it's at 2pm? [19:50:23] I mean finishes at 2pm [19:50:30] it's 1:30 [19:50:34] oh, ok [19:50:39] max wanted it moves for tech chat [19:50:49] which is what pushed our time out [19:50:51] I guess it's safer to move our meeting to Friday then [19:51:00] k sounds good [20:01:03] yurik: ok thx [20:01:33] dfoy, i just updated that page again - removing redundant setting and english banner [20:01:43] because i suspect that you don't have one from them yet [20:22:18] New patchset: JGonera; "Fixes to animations (transitions) and notifications" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71855 [20:30:15] jgonera: jdlrobson joining? [20:52:39] MaxSem: i've had to mute you a couple of times due to excess noise on your mic. has this been happening to you ? [20:52:56] I live near a highway [20:53:07] that would do it [20:53:18] but i'm surpised that the headset is picking it up [21:34:02] MaxSem: did you have any thoughts on https://gerrit.wikimedia.org/r/#/c/71749/ ? [21:34:16] i'd really like to kill the need for homepage special casing in some form.. :/ [21:35:31] I've seen it yesterday, and I have objections, just need to formulate them all:) [21:35:54] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71742 [21:39:22] New patchset: Jdlrobson; "Bug alpha: Ensure heading is correct on nearby overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71860 [21:40:21] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71860 [21:46:19] MaxSem: ok cool. i look forward to hearing them - i've been wondering if we could generate wikipages once for all these wikis and redirect in these situations rather than special casing.. [21:47:54] ragesoss: saw the patch, I fixed that yesterday before the release [21:52:19] New patchset: JGonera; "Regression: re-enable new page creation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71928 [21:55:14] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71928 [21:56:03] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71390 [21:58:27] Yuvi, shouldn't you be sleeping? [21:59:04] ragesoss: I was. I had a horrible nightmare and now I don't want to go back to sleep [21:59:42] on the nightly, that memory error happens on multiple devices, just on loading previous uploads. [21:59:46] ragesoss: I was endlessly scrolling through what looked like VP threads, but unable to understand what they were saying, but keenly aware that I've to implement something contentious being described [22:00:02] oh god [22:00:40] it did feel horrible and a tad bit helpless. There was this vague realization that people were screaming at me but no idea why [22:00:54] ragesoss: I'm staying away from VPT / VE feedback / Flow Feedback for a while [22:01:53] ragesoss: also still too nauseus, so bah [22:03:21] :( [22:03:22] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/71749 [22:23:44] New patchset: JGonera; "Alpha: Allow commenting on talk topics" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71152 [22:27:07] New patchset: JGonera; "Alpha: Allow commenting on talk topics" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71152 [22:49:08] New review: Jdlrobson; "Might break scrolling in left menu? Doesn't seem to work for me.." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/71855 [22:49:09] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71152 [23:00:29] New patchset: JGonera; "Fixes to animations (transitions) and notifications" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71855 [23:01:30] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71855 [23:06:34] New patchset: JGonera; "Regression: fix background glitch in left nav" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71935 [23:06:37] jdlrobson, ^ [23:08:47] New patchset: Jdlrobson; "Bug 43271: Always enable section collapsing html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71936 [23:09:19] New patchset: JGonera; "Regression: fix background glitch in left nav" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71935 [23:13:46] New patchset: Jdlrobson; "Bug 43271: Always enable section collapsing html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71936 [23:25:01] i moved some of your bugs into ready for dev, kaldari & jgonera [23:27:00] New patchset: Jdlrobson; "Bug 43271: Always enable section collapsing html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71936 [23:27:33] New review: Jdlrobson; "Obviously test is failing .. but Max if this looks sound could you do the necessary changes on the P..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71936 [23:32:56] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71935