[12:37:26] ragesoss: thanks for the patch :D [14:13:59] * brion downloads Kindle Fire emulator images for fun, whee [14:18:06] brion: nice definition of fun :) [14:18:33] i got curious about the behavior of the browser, saw a bug report about VE not working :) [14:18:45] Silk? [14:18:52] yeah, it's a proxied thing, similar to Opera Mini [14:19:09] but... on a larger screen [14:19:13] well [14:19:20] my impression is it's more like a caching proxy [14:19:31] hmm, doesn't have its own protocol? [14:19:35] opera mini does like javascript execution on the server and has its own magic format [14:19:37] (that'll be good) [14:19:38] yeah [14:20:04] brion: had a chance to look at my (by now rather large) UploadWizard patch? [14:20:27] it makes me cringe, how big it is [14:20:29] * YuviPanda stabs gerrit [14:20:34] took a quick peek, need to actually test it and stuff :) [14:20:34] it's 30+ commits on GitHub [14:21:16] heh [14:21:25] hey Yuvi. [14:21:46] did you see my bug that the memory error shows up on all my devices, including with the Play store version? [14:22:10] ragesoss: yeah, I'm not seeing it on mine. [14:22:17] huh. [14:22:31] maybe related to login / sync? [14:22:47] * YuviPanda looks at crash report again [14:22:50] ragesoss: i merged your patch, btw [14:23:12] yeah, saw that message here... replied after we netsplit. [14:23:22] :) [14:23:36] ragesoss: nothing much to do with sync, exception is in the image loading code [14:23:37] * ragesoss is leet hacker [14:23:43] ragesoss: indeed! [14:23:59] ragesoss: try uninstalling and reinstalling? [14:24:07] have done so. [14:24:53] brion: are you seeing this? ^ [14:25:01] seeing what? [14:25:12] brion: out of memory crashes if you scroll up and down [14:25:16] could it have to do with weird files in my upload history? [14:25:24] what weird files? [14:25:32] hmmmmm.... do you have any videos? [14:25:36] no idea, just throwing ideas out there. [14:25:46] that's a possibility. [14:26:13] YuviPanda: haven't noticed that, just crashing when swiping left/right a lot in 2.3 [14:26:24] https://test.wikipedia.org/w/index.php?title=Special:ListFiles/Ragesock [14:26:24] i do have some videos and pdfs in there :) [14:26:49] maybe that huge png? [14:27:05] huge pngs shouldn't really cause problems [14:27:21] brion: I want to add a 'low res' mode. downloading full res images takes forever on my connection... [14:27:34] brion: rather, I want to add a 'high res' mode that you can opt into [14:27:49] mmm [14:28:06] one possibility is a setting, another is auto-scaling based on connection speed [14:28:12] setting's easier to hack in though ;) [14:29:12] brion: there's not really a reliable way to get connection speed [14:29:28] brion: we can do something like 'wifi or data', but then again, my 3G is faster than my wifi... [14:29:48] we can measure how long it takes to download, and keep going based on that... [14:29:59] but that's rocket science, let's leave it for another time :) [14:30:02] :D [14:30:02] true [14:30:51] not getting a crash now on my main phone, after reinstalling from Play. [14:31:24] ragesoss: might be memory pressure from other app sthe previous time? [14:32:26] brion: should be effective only for thumbs. right now because we base our sizing solely on width, the size requested for the thumbs and the full sized images are the esame [14:32:36] brion: for thumbs, I think we shouldn't multiply by density. [14:33:27] could do [14:33:43] or we could load *even lower*-res items while scrolling, then settle into full-res when the scrolling settles [14:33:45] [14:33:46] ragesoss: are the thumbnails loading slowly? [14:34:07] brion: that sounds feasible too, provided we don't start thrashing the CPU with too many threads [14:34:11] or the network with too many requests [14:34:24] YuviPanda: depends on definition of slowly. [14:34:34] ragesoss: slower than previous versions? [14:34:37] slower than you'd like? [14:34:38] but in generally, seems in line with previous. [14:34:42] ok [14:34:53] of course, I'd like 'instant' [14:35:00] slower than you find acceptable? :) [14:35:17] oh, got the crash [14:35:52] scrolled down to the middle of my stream, and started waiting for thumbs to load... took about 5 seconds of not loading, and then crash. [14:36:12] * YuviPanda does that [14:36:27] * brion is suspicious of that in-memory bitmap cache [14:37:11] brion: the crash reports ragesoss sent me don't involve the in memory cache directly - they are while reading from the network [14:37:16] but yes, could easily be the in memory cache [14:37:40] i suspect it's just eating a lot of ram and increasing the memory pressure [14:37:47] especially if a phone's set with a low per-application memory limit [14:37:51] true [14:37:56] I guess 1/8 is too high? [14:38:17] * YuviPanda considers switching to a different image loading library as a last resort, at some point of time [14:38:51] Shutting down? [14:38:52] ominous [14:40:00] i'd just avoid caching in-memory. not sure it's worth it [14:40:16] hmm, can do [14:40:19] and increase disk cache [14:40:20] a lot [14:43:08] brion: so, 1. increase disk cache, 2. kill memory cache, 3. reduce thumb quality [14:43:19] \o/ [14:43:21] sounds good [14:43:27] brion: i also want to add some diagnostics to see what exactly is crashing ragesoss's phone. It might be a large video / audio thing [14:43:31] caused by the fallback mechanism [14:43:43] that reads full size things if it can't find a suitable thumb [14:44:19] that could do it... I certianly have sizeable video files in both my main account and the test account I was using. [14:44:29] indeed [14:44:39] hmm, this requires a 'su' funcitonality at some point, for debugging [14:44:40] video and/or that huge png [14:57:19] YuviPanda: need a logcat? I could do that. [14:57:27] ragesoss: yeah, that'd be helpful [14:57:34] ragesoss: but moment, it needs one more command executed before logcat [15:02:09] brion: talking to the WLM folks over skype now, to see what we can do [15:02:18] whee [15:05:09] ooh kindle fire hd 7 and 8.9 both have hdmi out [15:05:38] brion: so do the $50 android tablets I saw yesterday at Big Lots [15:05:48] hehe [15:06:08] i'm just annoyed that my nexus7 doesn't >:| [15:06:19] cause otherwise they're like the same hardware [15:06:53] just thinking whether it's worth picking up a 2nd-gen kindle for testing... [15:07:03] updated OS since the first-gen i have [15:07:23] brion: CM10 will probably enable MHL on the nexus7 at some point, right? [15:07:33] can it? oooooh [15:07:50] i'd like miracast on my n7 and n10 too... [15:07:58] …and a miracast *recorder*. :P [15:11:35] hmm... I don't see anything about MHL support in the works for nexus 7. [15:11:53] I'm expecting it to be added to CM10.1 for my phone soon. [15:12:14] brion: is tfinc going to be working today? [15:12:17] http://qt-project.org/qt5/qt51/ "tech previews" for qt for iOS and android :D [15:12:23] YuviPanda: no idea [15:12:27] brion: they've been on tech preview for too long ;( [15:12:30] brion: are you? :D [15:12:37] i'm staying home since the strike's still on this morning but poking at stuff :) [15:12:51] nice :) [15:13:54] of course they haven't settled on a new labor contract so there might be another strike in a month [15:14:15] is there a set date for the strike to end? [15:14:37] well today for now [15:14:49] trains start running at 3pm [15:14:58] so nobody can get TO work today but they can go home [15:16:33] is someone know how to create a ".gitreview" file for a new gerrit repo? [15:16:55] ^ YuviPanda [15:18:47] orsa: in a meeting. usually just copy one from another project and modify it? :) [15:19:50] which one for instance?.. do i have to clone all the project? [15:20:56] any of them! And you don't have to clone them, just browse on git.wikimedia.org [15:20:59] that must be a relief for the people who've been stuck at work since the strike started. [15:22:10] hehe :P [15:24:08] thanks [15:32:26] brion: notes from the WLM meeting http://etherpad.wikimedia.org/WLM-2013-07-05 [15:32:39] (ad hoc, odder just wanted to see if we could talk and we ended up with 4 people :)) [15:42:52] New patchset: Kaldari; "Add missing i18n message for user notificaitons tooltip" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72104 [15:48:04] YuviPanda: if you need any testing / logs from me, feel free to email me instructions. [15:48:08] bye for now. [15:48:19] ragesoss: will do. sorry about not being able to give those right away [15:48:37] no need to apologize [16:17:40] hmm, so there's supposed to be google tv devices based on jelly bean coming out this year [16:17:48] but the ones currently out appear to be the honeycomb-based one [16:17:49] *shudder* [16:18:50] heh [16:22:50] there, i ordered myself a kindle fire hd and a little google tv box [16:23:02] it's running the old OS but may be upgradable. we'll see :D [16:23:13] 'may be', yaeaaah :) [16:24:36] * YuviPanda pokes brion with https://gerrit.wikimedia.org/r/#/c/70446/ [16:24:46] http://gigaom.com/2013/05/15/google-tv-android-jelly-bean-update/ [16:24:59] will leave some more comments :) [16:25:12] it's getting bigger by the day. [16:25:12] don't forget we need that conversion script though, unless you want to move all the campaign data by hand ;) [16:25:29] brion: indeed, it's on my next to-do on the trello card, but I don't feel like making this patch even bigger [16:25:39] as it is it is fairly unnavigable [16:25:42] well, i wouldn't want to land this without it [16:25:44] brion: I didn't plan on adding validation this time either [16:25:49] but you could do it as a second commit i guess [16:25:57] brion: yeah, I want to add it as a separate patch [16:26:00] ok [16:26:14] we shouldn't need to maintain compatibility commit to commit [16:26:16] only release to release [16:27:38] brion: also needs an PI module [16:27:40] *API [16:27:45] as another commit [16:29:34] yeah, i just hate committing something with "surprise! if you deploy this it'll break" [16:29:52] do we need an api module, or just fetch the json data via query/revisions? [16:29:54] true, but even with a maintenance script if you just deploy it it will break! [16:29:57] someone needs to run it :) [16:30:05] well you could make it migrate on demand…… ;) [16:30:06] brion: we can jsut do that with query/revisions right now [16:30:27] brion: oh dear god noooo! :) [16:30:45] brion: plus this also requires changes to the config on LocalSettings.php anyway. [16:34:24] brion: i'm working on the maintanence script now, btw. [16:34:38] brion: also API might be needed as a query module if we want to get only 'enabled' campaigns [16:34:48] hmm, to get a list mebbe yeah [16:35:09] and it *would* be nice to get the data as a plain json subtree instead of a string that needs to be decoded again [16:35:36] brion: true. so that'll also have to go into the API. but I'd want this to be a query submodule, so unsure if that'll fly [16:35:44] brion: especially because it supports xml, blah blah [16:35:48] oh xml [16:38:37] New review: MaxSem; "Looks reasonable in HTML view, but extremely faily in WML: http://i41.tinypic.com/2uz7xnd.png" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/71749 [16:43:09] hah [16:43:18] i was freaking out that i'd broken my local install and it was stuck on mobile view [16:43:25] then realized i had selected the minerva skin in myh prefs ;) [16:43:29] ah :) [16:44:12] Fatal error: Call to undefined function efSchemaValidate() in /Library/WebServer/Documents/core/extensions-all/UploadWizard/includes/CampaignContent.php on line 61 [16:45:05] brion: dependency on EventLogging [16:45:17] brion: (mentioned in comment), should probably put it in commit summary [16:45:29] YuviPanda: ok at the least you need to document that in the README and INSTALL files. better still if you prevent the extension from running if its deps are missing [16:45:51] brion: yeah, that was a review comment yesterday. I'm going to get on that. [16:47:49] "Invalid node: expecting "string", got "number". Path: "Root node -> defaults -> lat" [16:47:52] with your sample data [16:48:25] ah, fixing! [16:50:05] brion: patch on the way. [16:50:11] \o/ [16:52:52] brion: pushed. [16:52:55] should be there momentarily [16:53:18] brion: suchabot updated that :) [16:53:22] brion: should work now [16:54:13] New review: MaxSem; "Overall, I would like some testing of this with real-world main pages." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71749 [16:54:15] whee [16:56:08] YuviPanda: i'm not sure i understand the 'wikitext' and 'label' members on the 'fields' entries [16:56:26] brion: they're straight up ports of the current fields in the campaign [16:56:36] hmm, well i don't understand them now then ;) [16:56:37] brion: wikitext represents the wikitext that is going to be added to the upload's description [16:56:44] brion: label is just the label for the textbox [16:56:47] ok [16:56:50] brion: documented in UploadCampaign.config.php [16:56:53] so hardcoded in one language, yippeee [16:56:55] (which has the defaults) [16:56:59] we'll worry about internationalization laters [16:57:22] brb [16:57:51] brion: i18n is taken care of with 'labelPage', it can point to a mw page that can be i18n'd [17:05:48] whee [17:10:44] sorry, hangouts crashed on me :( [17:14:25] New review: Jdlrobson; "owch should definitely fix the wap side - maybe always special case for wap?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71749 [17:16:05] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72104 [17:17:12] jdlrobson, does Nearby work for you in production? [17:17:35] jgonera: which nearby? [17:17:47] well, on Wikipedia [17:17:50] yep.. [17:17:56] hm [17:17:58] in stable anyhow.. [17:18:08] not working for you? [17:18:16] any errors thrown? [17:18:36] oh, only in Firefox [17:18:38] weird [17:20:06] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71953 [17:20:15] MaxSem: https://gerrit.wikimedia.org/r/#/c/71710/ < shall we merge? [17:20:19] jgonera: firefox?! [17:20:21] eek [17:20:22] * jdlrobson looks [17:20:59] jgonera: works for me.. [17:21:17] hm, nvm then, I must have some weird confg in my firefox [17:21:38] jgonera: you got me worried there ;-) [17:22:01] but, Nearby doesn't work on desktop anymore [17:22:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=50761 [17:23:00] or wait, did it ever work on desktop? [17:23:24] there's never #mw-mf-page-center so notifications always fail [17:24:03] oohh [17:24:34] jgonera: whoosie [17:24:40] we should fix that :) [17:24:42] do we use notifications in Nearby now? [17:24:43] yeah [17:25:20] jgonera: no… [17:25:37] but the notifications div is created at the start [17:25:38] :-S [17:25:47] yeah [17:25:51] why would el be undefined though [17:26:00] el = $( '
' ). [17:26:01] appendTo( '#notifications' )[ 0 ]; [17:26:08] because it cannot append it to mw-mf-page-center I guess [17:26:15] or notifications [17:26:28] (depending if we're looking at production or master) [17:26:35] ohhh cos no notifications div [17:26:39] eek [17:26:55] it did used to work.. i wonder what happened [17:27:27] my guess is that we did not load notifications on desktop? [17:27:39] New review: MaxSem; "Sigh" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/71710 [17:28:03] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71710 [17:30:33] jgonera: this sort of thing is going to continue to bite us till our skin is closer in line with desktop :/ [17:31:04] tfinc: ping? [17:31:12] YuviPanda: hmm? [17:31:16] well, sort of, we can't get rid of #mw-mf-page-center or #mw-mf-viewport [17:31:17] tfinc: http://etherpad.wikimedia.org/WLM-2013-07-05 notes from WLM meeting. [17:31:28] thanks [17:31:33] tfinc: would also be nice if you respond to WLM on list today. [17:32:00] plus I'm not sure if our notifications would work/look good on Vector anyway [17:32:42] has uploading images and adding them directly to articles been disabled for mobile web? [17:33:05] no [17:33:09] I was trying to do an upload, the but the little add-image button isn't doing anything. [17:33:16] MaxSem: did you get a chance to glance at https://gerrit.wikimedia.org/r/#/c/71936/ [17:33:26] ragesoss, what page and browser? [17:33:52] page: https://en.wikipedia.org/wiki/The_Shoppes_at_Northway [17:34:03] browser: stock Android browser [17:34:18] (on experimental settings for wikipedia) [17:35:06] ragesoss, for me the button doesn't show up at all because it's a page with an infobox [17:35:23] and currently we don't support adding images to pages with infoboxes [17:35:42] so for you the button is there but does nothing? [17:35:45] jgonera: if I get there from special:nearby, I still get the no-image icon in the nearby list, and also in the preview [17:35:52] the button is only there in the preview for me. [17:35:54] but it does nothing. [17:36:00] jgonera: we do show it on inboxes now.. [17:36:06] we do? [17:36:07] hm [17:36:42] for some reason I don't get the button [17:36:45] jgonera: well i thought we did.. mm [17:37:11] and what we show in preview and nearby unfortunately not always matches what we show in the article... [17:37:13] I don't get the button except in the lede preview from special:nearby [17:37:33] yeah, so this one is "supposed" to do nothing [17:37:45] it's not a button, more of a placeholder if there's no image [17:37:50] brion, forgot to tell you - http://theoldreader.com/ -- seems like a good reader replacement [17:37:53] but I can see how it can be confusing [17:38:00] yeh this is why the preview never made it to stable.. wasn't 100% clear [17:38:22] yeah... preview is kinda confusing. [17:38:30] what's the purpose? [17:38:36] jdlrobson, I think it should at least be a link to the article [17:38:40] the idea was to help explore quicker on your phone without leaving the page [17:38:58] as when you click on a link currently you have to click back to find the next article [17:39:01] ah... so it loads via js and you stay on special:nearby [17:39:06] yurik: thx, i'm trying out a few things now. digg's reader doesn't have an android app so i'm using feedly atm [17:39:10] exactly [17:39:15] i wanted to make a more app like experience [17:39:24] so if i wanted to find things to take photos of [17:39:37] i could flick between all the pages and then go and read them in full when i found something interesting [17:39:49] not quite right though.. [17:39:56] brion, theoldreader is just a website, just like greader, nothing more. Feedly is nice in some uses though [17:40:24] feedly has a very pretty interface. maybe too pretty ;) [17:41:52] yurik, i'm going to enable 404-01 for 30 seconds to test something, then i'll immediately revert. cool? [17:42:15] dr0ptp4kt, sure. The carrier contacted you? [17:42:57] dr0ptp4kt, oh, i see your email, sure go ahead [17:43:07] okay. just a moment. [17:43:11] ^yurik [17:45:46] tfinc: https://twitter.com/rakugojon/status/353207924828561408/photo/1 [17:56:24] jgonera: kaldari any idea where our windows phone is? [18:01:36] jdlrobson: I have no idea :) [18:01:50] mmm [18:02:34] ash jgonera must have promoted it to the nice cupboard [18:02:36] i found it [18:10:19] yeah, I'd say it's somewhere between nice and crappy ;) [18:10:47] there's also the new one I took from brion, the Nokia, this one's pretty good [18:11:09] the nokia's very nice build quality [18:11:13] it's just stuck on windows phone ;) [18:11:38] but it has IE10 which is pretty good [18:11:47] no upload support though [18:11:51] other than that pretty good [18:11:56] no? huh [18:12:17] yeah it actually comes back reporting all the FileReader support etc, but there's nothing hooked up to the file input control for selection [18:12:22] is there something we can do to support uploads on it or it just lacks support for FileReader and FormData? [18:12:23] drives me nuts :) [18:12:30] I see [18:12:49] hopefully they'll fix it in a point release [18:13:06] let's hope so. does Microsoft has some bug tracker? [18:13:13] have* [18:15:04] hmm, i should track that stuff down :) i've only done beta feedback before [18:22:34] New review: Kaldari; "Just some annoying style and documentation requests ;)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/69585 [18:25:33] dr0ptp4kt, btw, if you set X-CS=... URL parameter (instead of the header), you don't need to enable it [18:28:09] anyone knows if Michelle going to be online today? [18:33:08] yurik, yeah, checked that earlier, actually! it's a good feature, btw. i wanted to officially check the cache for this 30 second test, though, too. brb [18:36:48] New patchset: Kaldari; "Adding the page ID to the debugging output" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72121 [18:40:09] New patchset: Kaldari; "Adding the page ID to the debugging output" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72121 [18:45:01] * jgonera starts the journey to the office, should take ~1h [18:46:49] New patchset: Jdlrobson; "Hygiene: Cleanup the html for the cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72122 [18:58:49] New patchset: MaxSem; "Bug 43271: Always enable section collapsing html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71936 [18:59:10] jdlrobson, ^^ [18:59:23] great Max will take a look in a min :) [19:07:13] New patchset: Jdlrobson; "Device cleanup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72127 [19:17:12] how 'bout https://gerrit.wikimedia.org/r/#/c/71731/ instead of ^^^ :)? [19:29:32] tfinc: see if you can respond to WLM before leaving office today. Don't want to keep getting constantly poked over the weekend about it :) [19:29:36] New patchset: Jdlrobson; "Bug 50681: Don't duplicate the watchlist message when empty" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71944 [19:38:22] * multichill pokes YuviPanda about WLM :P [19:38:30] ohai multichill :) [19:39:18] multichill: you might be interested in http://etherpad.wikimedia.org/WLM-2013-07-05 which happened today [19:40:43] I've been thining about monuments to wikidata, wikidata export -> lucene/solr -> nice json api [19:42:11] YuviPanda: Wouldn't that be a much nicer backend that the wlm api? [19:42:34] multichill: yeah, we want to wait for that before doing any type of 'discovery' [19:42:54] multichill: if you look at the 'links' section, it only talks about 'Upload Campaigns', which is making upload easier, not discovery [19:43:19] imho discovery was the hardest part last year [19:43:20] multichill: why do export -> lucene -> api? rather than just wait for wikidata's query stuff to mature? [19:43:23] true [19:43:28] it will be the hardest part every year [19:43:37] Because I want to search [19:43:40] we're trying to make sure that whatever we build isn't WLM specific. [19:43:53] why can't you search with wikidata queries? [19:44:11] And searching by location is something that I don't expect to become part of the wikibase api, I expect a search engine to be in front of it [19:44:24] ah, yes. [19:44:26] by location [19:44:37] Just like normal Mediawiki search is not part of the regular api [19:44:49] (in our Wikimedia cluster setup) [19:44:50] well, why not though? They added geo support recently, but I suspect Extension:GeoData will be replaced by Wikibase stuff at some point [19:45:22] True, I didn't really expect it to be implemented that way [19:45:40] but I doubt any of that will happen before this year's WLM [19:45:57] also we've no idea how much support the mobile app will be able to provide for WLM. [19:46:20] We have two parts <-> [19:46:36] the wlm mobile app from last year? [19:46:55] I don't think we want to touch that, unless extreme things happen [19:47:11] have you seen https://www.mediawiki.org/wiki/User:Yuvipanda/Mobile_campaigns [19:47:11] You probably have something newer and better than that [19:47:17] Yes, campaigns [19:47:26] yeah, but unsure if all of it will be completed before WLM. [19:47:28] So you have the general app and you can focus on subsets [19:47:31] yeah [19:47:44] and 'campaigns' won't be WLM specific, they can be used for other things too [19:48:04] How long ago did mobile web start tagging images it uploaded with the category:Uploaded from mobile/web. Did it always do it? [19:48:07] 'Wiki Takes X' is the obvious candidate, but I am hoping that having history / watchlisting for Campaigns would let other people setup campaigns for other things [19:48:15] Yes, that's a good thing [19:48:19] bawolff: always, IIRC [19:48:46] Will you be in Hong Kong YuviPanda? [19:48:52] yes, multichill! [19:48:54] i will be [19:49:01] * multichill too [19:49:07] :D [19:49:10] Oh, I think I got confused by one of the maintinace categories being bigger than the mobile cat, but I think what happened is the maint cat contains things from all mobile types [19:49:11] I'm leaving to China in exactly 7 days [19:49:26] multichill: oh! and then coming to hk from there? [19:49:33] Yes [19:49:33] bawolff: yeah, there's /android and /ios too [19:50:21] multichill: hoping to get the Campaign: namespace stuff deployed before Wikimania though [19:50:48] I will be traveling for about a month so not a lot of coding from my side (besides the hackathon of course) [19:51:19] heh. I'm just trying to find people to trout me if I'm missing things that are obvious [19:56:48] YuviPanda: btw, toolserver is not fubar [19:57:02] sure, but not reliable much of late either... [19:57:16] Toollabs is even worse [19:57:30] It's just not ready [19:57:46] what else is needed before monuments api can run off toollabs? [19:58:29] See https://bugzilla.wikimedia.org/show_bug.cgi?id=49177 [19:58:32] I've been spending my weekends on Tool Labs instead of the Mobile app... [19:58:56] hmm, depends on one bug [19:58:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=48851 is just sitting there without anything happening [19:59:14] i just poked him again [20:00:20] multichill: coren says he's commenting there now [20:01:16] Yeah right, I'm getting pretty damn fed up with the toollabs. Yes, we're looking into it, yes, we're working on it. *nothing happens* [20:02:17] multichill: yeah, I understand it's frustrating, but it is just getting started. I spend a fair amount of time on IRC and otherwise hacking on it, so I'll keep poking until this gets fixed [20:05:09] Just getting started? This already took over a month without any form of communication [20:06:27] there's been other work going on in the background. NFS is painful and in the process of 'getting fixed', the stuff is getting puppetized, WSGI support is coming, replication itself was properly on only about a month or so ago... [20:07:03] 'just getting started' -> was about toollabs itself, compared to toolserver, which has been around for a longer time [20:21:44] YuviPanda: k [20:22:04] hey violetto vbamba sorry we were out to lunch [20:22:37] the svg's you sent me should give me what i need for time being - will probably need to run it by you quickly afterwards though to sanity check [20:23:33] that works [20:25:21] New patchset: Jdlrobson; "Remove blackberry stylesheet" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72136 [20:25:22] New patchset: Jdlrobson; "Remove kindle stylesheet" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72137 [20:25:22] New patchset: Jdlrobson; "Drop iphone device stylesheet support" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72138 [20:25:47] \o/ kill zee stylesheeeets [20:26:21] brion: most of the comments you made addressed, working on teh final thing now [20:26:27] \o/ [20:26:35] brion: re: messages, I'm reusing code+messages from EventLogging [20:26:43] yeah, that just feels dirty though [20:26:45] eventually this should all go into Core, but right now i'm just directly reusing them [20:26:54] yeah [20:26:54] it's temporary :D [20:26:55] so I personally think that's okay [20:26:57] yeah [20:27:01] extensions shouldn't know about other extensions' message names [20:27:05] JsonContent + JsonSchema should go into core soon [20:27:06] but we'll let that slide ;) [20:27:10] woo [20:27:11] yay :) [20:27:23] brion: once this gets merged and I get this off my plate I'll work on it on the side [20:28:09] UploadWizard seems to keep validation rules all around the place :( [20:28:29] YuviPanda: I would love you forever for making it less nasty [20:28:40] YuviPanda: This would make a fine cleanup bug [20:28:44] marktraceur: you have a JS refactor going on, don't you? [20:29:03] marktraceur: I'll offer to fix validation after that gets merged [20:29:26] Coolio [20:29:42] I also modified a Nischayn22 patch to make validation use promises in some spots. [20:30:53] yeah, I think promises should come first [20:31:15] we should perhaps have a jenkins patch even that makes sure that anything with async: false gets an automatic -2 [20:31:23] I can't think of any situation in which it would be useful [20:32:25] New patchset: Jdlrobson; "Bug 43271: Always enable section collapsing html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71936 [20:33:38] MaxSem: i just updated core and i'm seeing the table of contents... [20:33:50] (in mobile) [20:33:51] can you confirm if the same is happening for you? [20:34:47] table of contents is no longer a table.. [20:34:59] lololoolol [20:35:54] MaxSem: fixed ... [20:35:54] New patchset: Jdlrobson; "Prevent table of contents leaking into mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72142 [20:36:01] Matmarex's work :) ^ [20:37:05] I'll add this rule to mw-config in case core gets deployed before MF [20:37:15] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72142 [20:37:33] sweet thanks MaxSem [20:39:51] lol, just reproduced https://bugzilla.wikimedia.org/show_bug.cgi?id=50784 [20:39:59] FUUUUUUUUUUUUUUUU [20:45:11] YuviPanda: i'm trying to dig up the WLM thread i'd say we'd respond under. can't find it [20:45:20] tfinc: let me give you the title, moment [20:45:28] nm [20:45:31] Re: [Wiki Loves Monuments] Wikimedia Foundations app for Wiki Loves Monuments [20:45:38] YuviPanda: --^ [20:45:41] :) [20:46:06] New review: Jdlrobson; "Max if you're happy go ahead and merge" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/71936 [20:46:27] MaxSem: how did you reproduce? [20:46:37] cd core && git pull [20:47:13] MaxSem: but his error says SkinMobileBase [20:47:17] we don't have a skin mobile base.. [20:47:36] Original exception: exception 'MWException' with message 'Call to undefined method SkinMobileBeta::getLanguages' in /home/max/Projects/MediaWiki/includes/Skin.php:1613 [20:47:56] pfffffft [20:48:27] MaxSem: me don't understand /home/aiowiki/aiowiki/w/extensions/MobileFrontend/includes/skins/SkinMobileBase.php(172): [20:48:27] SkinMobile->getLanguages() [20:48:48] now grep for it in the core [20:49:31] jdlrobson, can you +1 https://gerrit.wikimedia.org/r/72144 ? [20:49:52] MaxSem: sure [20:50:04] MaxSem: I still can't reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=50784 [20:50:16] I'll fix it myself [20:51:19] MaxSem: i'm just puzzled as I don't see why SkinMobileBase exists in the error [20:51:26] hopefully you'll patch will explain? :) [20:51:56] MaxSem: have started trying to remove device support [20:52:00] just fyi :) [20:52:44] jdlrobson, MaxSem, don't forget about our desire for a new hook :) [20:53:15] yurik: is there a bug open? Otherwise there is a risk of forgetting … :) [20:53:39] jdlrobson, no worries, i will keep reminding every day, much better than any bug report ;) [20:54:19] zero wants a hook that gets a full DOM object of the HTML before it gets returned [20:55:59] New patchset: Jdlrobson; "Blindly remove simple, opera mini and opera mobile stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72146 [20:56:18] MaxSem, i was thinking about this problem somemore, and realized that if mobilefrontend creates a hook "processDOM", and uses that hook itself to convert lang.wp.org to lang.m.wp.org, zero can override that behaviour with a different hook implementation and return "false" if it handled DOM rewrites, and TRUE if it wants mobile to rewrite [20:57:26] this way we will get rid of the onGetMobileUrl hook as well [20:59:31] YuviPanda: whats the best page to link to for an explanation of camapigns ? the one on your user page ? [20:59:40] tfinc: yeah, that's the best one so far [21:00:46] YuviPanda: can't find yours. link please [21:00:48] yurik, GetMobileUrl is needed for other stuff - we use these links in UI so they're unavailable to DOM [21:00:53] mw.org search is timing out [21:00:56] tfinc: https://www.mediawiki.org/wiki/User:Yuvipanda/Mobile_campaigns [21:02:10] MaxSem, sure, we could leave it (or possibly have some other major hook that will not only process DOM, but will also handle other skin elements [21:02:40] or separate it into 2 hooks: HandleDOM, HandleNonDOM hooks [21:03:07] ughhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh [21:03:51] we need to sit down and decide what our interaction is lacking and what needs to be changed, ad-hoc improvements aren't helping [21:03:53] is max happy because of my suggestions or because the visual editor team is so succesful? [21:04:19] jdlrobson, can't repro now [21:04:40] did I do something with my WC? :P [21:04:40] MaxSem: I'm pretty sure the guy was using an old version of MobileFrontend [21:05:08] YuviPanda: here is my first pass http://etherpad.wikimedia.org/WLMMobile [21:05:16] * YuviPanda clicks [21:06:20] tfinc: adding more numbers from last year while talking about the 6000 contribs goal would be nice. [21:06:39] YuviPanda: put in a note [21:06:42] good point though [21:07:10] tfinc: yeah [21:07:28] tfinc: also remember it took a lot of effort as well. MaxSem, jdlrobson, a tiny bit of me, phil, and I forgot how many other people [21:07:39] put that note in [21:07:43] YuviPanda: put it in there [21:07:50] EDIT [21:07:51] tfinc: i've mentioned it in the note [21:07:57] oh you want me to add it directly? [21:07:58] oh [21:07:59] ok [21:08:08] yeah do it [21:08:12] hmm I'm not sure how exactly to say that without sounding awkward [21:08:12] jdlrobson, MaxSem do you want to have a quick hangout to discuss how zero & mb should interact? [21:08:14] * YuviPanda makes a first pass [21:08:36] YuviPanda: does our stance come off clear in the email? did i miss anything ? [21:09:13] i'm doing another read, tfinc. [21:09:45] yurik: i'm too busy at the moment sorry - maybe next week? [21:09:51] jdlrobson: this is the room escape that i was telling you about http://realescapegame.com/rersf1/ [21:10:33] tfinc: can you verify the 'people' number? anyone I'm missing? [21:10:45] '3 people' -> jdlrobson, MaxSem and Phil. [21:11:09] it was more then that [21:11:13] jdlrobson and brion helped out [21:11:25] lindsey [21:11:26] as well [21:11:39] and a little bit of me. you were involved too [21:11:49] was it 4 months or 2 months? [21:12:00] i want to say 2 [21:12:17] i think it was 2-3 in the end [21:12:36] yeah [21:12:56] YuviPanda: will campaigns give us discover or just meta data attachment to photos ? [21:13:01] just metadata [21:13:08] no discover without wikidata [21:13:38] New patchset: Jdlrobson; "Blindly remove simple, opera mini and opera mobile stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72146 [21:13:54] if campaign uploads come with a specific tag in future, we can discover based on that [21:13:57] jdlrobson, blindly? [21:14:01] tfinc: should I add a note about the Campaign: namespace work we are doing? [21:14:09] right now i think they optionally set categories but you can't 100% rely on that [21:14:12] which will help them (apparently tremendously) but is unrelated? [21:14:15] ie. MaxSem i.e. with very little testing - just glancing at the rules none of them make any sense [21:14:17] New patchset: JGonera; "Fix delay property of notification transition (CSS)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72155 [21:14:26] YuviPanda: is it relevant? not sure what your referring to [21:14:30] brion: yeah, that's something I'll probably add once this stuff is all merged. 'tracking' category. [21:14:37] \o/ [21:14:40] tfinc: unsure if relevent. it's the campaign backend stuff I'm working on right now. [21:15:16] campaign is used heavily by WLM on the desktop side, and the work I'm doing is a massive upgrade to it [21:16:04] blehy [21:16:14] tfinc: unsure if relevent. it's the campaign backend stuff I'm working on right now. [21:16:14] campaign is used heavily by WLM on the desktop side, and the work I'm doing is a massive upgrade to it [21:16:16] LiFI [21:16:33] yeah, figured ;) [21:16:40] YuviPanda: write up a paragraph and see if it fits in. i'll check in on it later tonight [21:16:48] tfinc: okay. do send it out today tho :) [21:16:51] tfinc: writing it out now [21:17:00] YuviPanda: i have my points in :D [21:17:11] and hopefully i'm being clear and direct enough [21:17:18] yo are, yeah [21:17:18] just a matter of you including your points [21:17:35] should run this past someone else for a final look tho [21:17:42] at this point i rather have somebody upset but know our choices rather then being confused [21:17:50] +1 [21:18:56] tfinc: look now? [21:19:29] i've my point in [21:19:35] checking .. [21:20:17] YuviPanda: it works [21:20:39] lets ship it [21:20:58] tfinc: you're missing a question mark [21:20:59] i just added it [21:21:05] done [21:21:27] tfinc: feel free to pass that through someone else before mailing out though. English is not my first language, etc etc usual disclaimers [21:21:27] :) [21:23:13] i think its fine [21:23:47] :) [21:23:51] go ahead then [21:23:58] MaxSem: this ready to go from your pod? https://gerrit.wikimedia.org/r/#/c/71936/ [21:24:01] *pov [21:25:36] mmm, maybe a little frontend review? [21:26:10] YuviPanda: sent [21:26:23] sweet [21:26:27] YuviPanda: with 4min to spare :D [21:26:34] wonderful :) [21:26:39] now to wait for pitchforks... [21:26:41] ;) [21:27:42] i'm sure they've been sharpening them [21:27:56] but honestly i'd rather go through a flame war now then in two months [21:28:19] oh yeah [21:28:20] true [21:28:22] completely agreed [21:28:42] wish I didn't have this exam thing though. we could've probably gotten campaigns out in time if not for that [21:28:44] at least on android [21:31:33] yurik, jdlrobson - when? [21:32:00] MaxSem, i will send a short email soon, outlining what we have discussed before. Just reply with your thoughts. [21:32:29] I don't believe in email discussions, too slow:) [21:33:07] i'd prefer an email - i'm much better with written conversations [21:34:08] MaxSem, jdlrobson just sent an email, pls reply :) [21:34:44] MaxSem, i can answer your questions/listen to ideas in real time over hangout, up to you [21:35:03] just wanted to put down where we stand, and record all ideas in one email thread [21:40:48] New patchset: JGonera; "Remove .border-radius LESS mixin and use border-radius" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72203 [21:50:58] New patchset: JGonera; "Remove .boxshadow LESS mixin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72212 [21:54:58] New patchset: JGonera; "Remove -o-box-sizing from .box-sizing LESS mixin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72214 [21:55:59] New review: MaxSem; "Why not log the title itself?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72121 [22:01:47] New patchset: Jdlrobson; "Blindly remove simple, opera mini and opera mobile stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72146 [22:01:57] New patchset: JGonera; "Remove -moz-background-size from .background-size LESS mixin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72216 [22:07:32] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/71944 [22:12:06] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72146 [22:12:33] MaxSem, any questions about email? [22:13:38] no clarity at all [22:13:46] wha? [22:13:48] why? why this particular way? [22:14:05] Mobile ext should have a hook "mobile-DOM-refactor", and do the default "lang.wp.org" -> "lang.m.wp.org" transformation only if the hook returned TRUE. Zero will implement its own handler for this hook, and will return "false" if it handled needed replacements itself. [22:14:12] is a big meh [22:14:20] why so? [22:14:37] would you rather have two different transformations??? mobile transforms one way, zero - another way [22:15:01] first of all, we use GetMobileUrl for stuff like redirection. feel free to alter it, but you can't get rid of it [22:15:31] max, i never mentioned getmobileurl in the email [22:15:50] but you sound like you want to replace it [22:16:03] "Mobile ext should have a hook "mobile-DOM-refactor", and do the default "lang.wp.org" -> "lang.m.wp.org"" [22:16:53] i'm a bit confused - what exactly are you objecting to? [22:17:24] I'm a bit confused too:_) [22:17:24] my position - we need to transform one way in mobile, and a different way in zero, so we might as well have them as different options [22:18:00] aha [22:18:02] "do the default "lang.wp.org" -> "lang.m.wp.org" transformation" [22:18:18] we don't do this, we rely on relative links [22:18:30] ok, even better [22:18:43] that's why I suggested a talk [22:19:03] if mobile never transforms links, no need for that logic [22:19:35] the hook would alter DOM [22:19:40] and everyone is happy [22:20:05] but in that case, why does mobile need to do HTML->DOM? [22:22:01] to remove some stuff and to reformat some other [22:22:39] ok, so what are the issues with calling a hook with the DOM object? [22:23:32] * MaxSem bites jdlrobson for producing a chain of commits [22:25:11] https://gerrit.wikimedia.org/r/#/c/69336/ centralises this stuff, I would really like to do it only after this change is merged [22:25:54] MaxSem, whenever is convinient, as long as we can access both the DOM and the footer links [22:27:15] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71944 [22:28:14] New patchset: JGonera; "Remove -ms-linear-gradient from .vertical-gradient LESS mixin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72223 [22:29:19] New patchset: MaxSem; "Create a thin base class for all our skins" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69336 [22:35:52] New patchset: Jdlrobson; "Story 832: Show icons when not available / add new assets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72227 [22:35:53] New patchset: Jdlrobson; "Inform users why certain functions are not enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72228 [22:37:22] New review: Jdlrobson; "The original less file was written by Munaf for a desktop context so this is more than possible" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/72223 [22:37:41] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72223 [22:53:36] New patchset: Kaldari; "Adding the page ID to the debugging output" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72121 [22:58:08] New patchset: MaxSem; "Adding the page to the debugging output" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72121 [22:58:55] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72121 [23:22:08] New patchset: JGonera; "Simplify .animation LESS mixin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72231 [23:56:20] New patchset: JGonera; "Hygiene: Cleanup the html for the cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72122 [23:58:08] New patchset: Jdlrobson; "Bug 50681: Don't duplicate the watchlist message when empty" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71944 [23:58:57] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71944 [23:59:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72122