[00:00:04] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72231 [00:04:39] tfinc: I decided to just propose some minimum documentation practices for all of MediaWiki (at least on the PHP side), since I'm sure MobileFrontend isn't the only extension lacking thorough code documentation: http://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/PHP#Recommending_some_minimum_documentation_practices [00:05:22] sent an email to wikitech-l as well [00:08:18] bug 1 compells you! [00:12:12] New patchset: JGonera; "Bug 43271: Always enable section collapsing html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71936 [00:13:11] New patchset: Jdlrobson; "Only allow h2's to have an edit link" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72234 [00:14:11] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71936 [00:14:51] kaldari: +1 - we should also encourage documentation by having some automated documentation generator that publishes it somewhere... [00:19:13] jdlrobson_: such as https://doc.wikimedia.org/mediawiki-core/master/php/html/? :) [00:19:26] YuviPanda: exactly.. but for Mobilefrontend [00:19:37] and preferably a bit nicer laid out.. [00:19:49] yeah, should be simple enough to hook up [00:20:08] jdlrobson_: and re: nicer layout, doxygen themes that look nicer seem hard to find :( [00:20:14] New review: Jdlrobson; "\o/" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/72216 [00:20:22] using something that's not doxygen would also be nice, yeah. [00:20:31] New patchset: JGonera; "Show notifications (toasts) when overlay is open" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72235 [00:20:33] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72216 [00:20:34] YuviPanda: that would be cool. Would encourage more documentation if there was a place on the web [00:21:47] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72212 [00:23:11] YuviPanda, jdlrobson: it's not a bad start, although I hate those giant inheritance and collaboration diagrams. Is there any way to kill those? [00:23:36] kaldari: I raised that on the mailing list like... 2 years back, and was beat back with someone telling me 'but I use that all the time!' [00:23:50] Ah, yeah, I think I remember that :P{ [00:23:53] kaldari: used to be much worse, tehre were huge separate diagrams for *each method*, and then Reedy silently killed those. [00:24:09] * Reedy cries [00:24:12] I think silent killing is the best thing to do with anything doxygen related, to avoid bikeshedding [00:24:41] Oh yeah, I remember that. If I ever clicked on Title or User or one of those classes, I could just kiss my browser goodbye :) [00:24:46] * YuviPanda remembers writing code on an 800x600 netbook scrreen [00:24:47] kaldari: yeah [00:25:10] kaldari: even current doxygen is that way for my poor ol' macbook air, btw. I've resorted to reading the code directly in vim, with help of taglist... [00:25:52] I'm OK with the class diagram I guess. At least it's not as bad as it used to be :) [00:26:00] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72155 [00:26:40] kaldari: damn, so now because I reminded you of 'horrible old days' you are okay with 'horrible current situation'? tch tch [00:26:40] ;P [00:26:50] lol [00:26:55] I guess so [00:27:00] kaldari: we should at least get rid of the 'long list of unnavigable other methods where this method is used!' under each method. [00:27:01] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72235 [00:27:13] it is just a list of links now, rather than a diagram. still... [00:27:29] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72234 [00:28:23] jdlrobson_: kaldari http://demo.phpdoc.org/Responsive/namespaces/phpDocumentor.html looks very sweet [00:28:50] it's actually fast too [00:29:06] don't have to wait 5 seconds after each click :P [00:29:13] yeah [00:30:03] but hey, compared to the old days I shouldn't complain ;) [00:30:17] :D [00:31:00] and the project isn't even dead! [00:31:01] https://github.com/phpDocumentor/phpDocumentor2 [00:31:01] nice [00:31:15] New patchset: JGonera; "Remove .border-radius LESS mixin and use border-radius" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72203 [00:31:55] New patchset: Jdlrobson; "Remove kindle stylesheet" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72137 [00:31:55] New patchset: Jdlrobson; "Remove blackberry stylesheet" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72136 [00:31:55] New patchset: Jdlrobson; "Device cleanup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72127 [00:32:03] New patchset: JGonera; "Remove -o-box-sizing from .box-sizing LESS mixin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72214 [00:34:01] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72203 [00:34:27] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72214 [00:35:23] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72136 [00:35:23] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72127 [00:35:52] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72137 [00:36:47] New patchset: Jdlrobson; "Drop iphone device stylesheet support" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72138 [00:36:50] kaldari: emailed wikitech :) [00:37:08] rapid [00:40:00] New patchset: Jdlrobson; "Remove device specific stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71731 [00:41:03] MaxSem: commence wetting of pants. Device specific stylesheets are dead. Long live css! [00:41:06] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72138 [01:06:15] New patchset: Jdlrobson; "Fix nearby desktop view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72238 [01:10:11] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72238 [01:39:59] New patchset: JGonera; "Fix jumping watchstar spinner" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72239 [01:41:42] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72239 [08:02:22] MaxSem: You already awake? [08:04:02] MaxSem: I'm looking into enabling the nearby feature at the Dutch Wikipedia. Difficult part is that the Dutch Wikipedia uses a slightly different format: Underscores instead of pipes [08:04:10] So for example 52_22_49_N_4_38_26_E_type:city(146753)_region:NL-NH [08:04:56] Any suggestion on how to get it in there? One option would be to change the harvesting code to also understand underscores, the other would be to do something with lua [08:05:19] But I'm a complete lua noob and I don't know if the #coordinates is accessible from lua [08:38:16] multichill, lua [08:38:48] I'm not really into lua either [08:50:38] MaxSem: How to access coordinates in lua? [08:50:49] dunno:P [08:51:09] I think you have to include some sort of hook in your code [09:17:06] multichill, https://en.wikipedia.org/wiki/Module:String#sub [09:51:02] MaxSem: See https://nl.wikipedia.org/wiki/Gebruiker:Multichill/Kladblok [10:30:54] mmm, pipes [10:31:48] then https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#frame:callParserFunction :P [13:33:49] MaxSem: I got it to work, see https://nl.wikipedia.org/w/api.php?action=query&list=geosearch&gsradius=10000&gspage=Haarlem&format=json [13:34:14] How long does it takes before https://nl.wikipedia.org/wiki/Speciaal:InDeBuurt starts showing something? [14:32:40] multichill, it gets updated every half an hour [14:34:07] multichill: btw, tfinc emailed about the wlm app y'day [15:16:52] MaxSem: Ok, it's been more than half an hour. Why am I not seeing anything? [15:17:32] Hmm, https://en.wikipedia.org/wiki/Special:Nearby is empty too [15:18:13] https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Nearby too and all the random other Wikipedia's I tried [15:36:45] multichill, eh - job queue [15:37:11] MaxSem: No, it's something else, filing the bug right now [15:38:45] nearby doesn't like desktop browsers [15:39:19] multichill, Cannot set property 'ontouchstart' of undefined [15:39:24] a known bug [15:40:42] I remember opening it my normal browser. What's the bug id? [15:41:25] MaxSem: Oh, https://nl.m.wikipedia.org/wiki/Speciaal:InDeBuurt does work in FF [15:42:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=50761 [15:43:14] That's marked as resolved, so that can't be correct [15:43:22] look at the dates [15:44:31] I looked, it's just weird to close bugs when they are not solved yet, but that's because we don't have a good structure for that [15:44:47] It should be two parts, one the software bug and one instance for the usage on WMF sites [18:17:37] ConfusedPanda: Feature request - I just used my mom's phone to upload http://commons.wikimedia.org/wiki/File:Sausage_Breakfast_Casserole.jpg - I would like to remove my account info from the app now but can't [18:17:47] (Android version, which I assume is your fault) [18:17:52] marktraceur: you can! [18:17:57] Howwww [18:18:13] marktraceur: go to phone settings, you will find 'wikimedia commons'. Has a 'Remove Account' thing [18:18:20] (also the category adding interface was one huge target for "skip" that I accidentally hit) [18:18:23] Ah, K [18:18:25] marktraceur: accounts were centrally managed [18:19:07] in Android [18:19:40] marktraceur: true, hopefully we'll have a better design at some point. [18:20:32] marktraceur: when we get design resources [18:21:10] Categories added, will go get my name wiped from her phone, ta very much [18:26:25] marktraceur: thanks for the upload :) [18:27:18] *nod* even used it [18:27:26] http://en.wikibooks.org/w/index.php?title=Cookbook:Wakeup_Sausage_Casserole&stable=0 [18:27:57] You can catch a glimpse of my IRC window in that picture too... [18:29:34] marktraceur: nice! [18:34:28] Hopefully the finished product works out nicely also [19:25:07] hey mhurd :) [19:25:19] hey yuvi! [19:25:51] mhurd: enjoying the weekend? [19:26:51] ConfusedPanda: yes! slept in, did laundry, some programming, coffee and climbing… it's a good day [19:27:13] what are you up to today? [19:27:35] mhurd: just trying to get marktraceur to merge stuff and practice some puppet [19:27:44] mhurd: also talking to the WLM folks about campaigns [19:27:53] mhurd: seen the mobile campaigns? [19:28:12] ConfusedPanda: nice! no haven't seen [19:28:24] mhurd: https://www.mediawiki.org/wiki/User:Yuvipanda/Mobile_campaigns [19:28:38] mhurd: i'll start work on an android implementation once the server side work is merged into UploadWizard [19:29:07] oh yes! i have read that! looks like a good plan [19:30:05] mhurd: how's the detail stuff on iOS coming up? [19:30:15] mhurd: had a chance to look at the translatewiki stuff? [19:31:52] ConfusedPanda: the detail stuff was being very uncooperative - lots of weirdness with scrolling table views, but as of yesterday it's behaving finally [19:32:55] ConfusedPanda: been so caught up in details page haven't looked an translatewiki stuff yet either [19:34:54] mhurd: ah, ok [19:37:13] ConfusedPanda: oh the translate app that you mentored - yes i did look at that. sorry, coffee hasn't kicked in completely haha [19:43:07] ConfusedPanda: did you have a chance to visit yosemite when you were here? [19:43:16] mhurd: no, not at all [19:43:27] ConfusedPanda: http://youtu.be/y58C1y8VkqM [19:43:43] mhurd: tfinc just took me climbing on the mission, and bowling. Rest of the time I had to wander the strets alone, because I was under 21 :( [19:43:59] ConfusedPanda: gah! noooo haha [19:44:38] ConfusedPanda: we'll have to do a road trip [19:44:47] september, hopefully! [19:44:57] ConfusedPanda: yes!! [19:45:04] mhurd: I've never been a car in the US either! [19:45:09] that looks amazing [19:46:10] ConfusedPanda: the drive to yosemite is beautiful too - around sonora there are rolling hills - it looks like the old windows xp wallpaper [19:49:20] mhurd: amazing. yes, definitely! [19:49:59] mhurd: I walked from the office to the golden gate bridge and then crossed it, that was fun + scenic [19:50:09] mhurd: the park right under it was pretty amazing + the view was really nice [19:50:28] mhurd: sadly I wasn't remotely closed to prepared, and I finally found out why 'real' shoes matter [19:51:04] ConfusedPanda: ah yes, i've found that out the hard way as well [20:00:43] mhurd: yeah, so i bet this time will be better prepared :) [20:01:37] mhurd: also there'll be a lot of folks landing up for the all staff, and staying, so should be fun [20:01:44] mhurd: last time there was the folsom street fair, I heard. [20:03:23] ConfusedPanda: hmm haven't heard of it, but there are so many events here it's hard to keep track [20:03:34] ConfusedPanda: good problem to have [20:04:41] vbamba: hey vibha! [20:05:21] mhurd: hehe, yeah. SF problems, I guess :) [20:05:34] ConfusedPanda: :) [22:33:43] New patchset: TheDJ; "Set padding on header, to avoid collision with collapse control" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72325