[06:26:49] New patchset: Mgrover; "Automation tests for Mingle Stories#976 and #977 - Must be logged in to use Watchlist and Uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72480 [07:38:05] [Commons-iOS] siebrand pushed 1 new commit to master: http://git.io/YQacGw [07:38:05] Commons-iOS/master 2fa0a88 Siebrand Mazeland: Localisation updates from http://translatewiki.net. [13:31:18] New patchset: MaxSem; "Remove device specific stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71731 [13:40:37] New patchset: MaxSem; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [13:51:43] New patchset: MaxSem; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [16:40:29] Hey Maryana [16:40:38] good morning! [16:40:54] howdy! [16:41:07] Boy is SF having a great month :D [16:41:14] is the Bart strike over yet? [16:41:22] yeah, thankfully [16:41:26] oh good [16:41:48] so I have one story in ready for sign off the rest are bugs [16:42:08] oh man, that's a lot of red [16:42:08] I left them for you to review like normal but I did go through them all :D [16:42:15] EVERY one of them :D [16:42:19] :) [16:42:33] and it looks like we're good for sprint kickoff? [16:43:08] ok, i guess since there's not really anything for design to look at, we don't need to have our 11:30. i'll probably just get together with jon or juliusz to go over the bugs [16:43:14] and yep, i think we're all set for kickoff :) [16:43:32] awesome when you do can you use beta labs [16:43:42] for checking any bugs instead of their machines [16:43:59] i wanna use it as the source of truth :D well the source of "possible" truth :D [16:44:17] yes! will do. hopefully it's not painfully slow today [16:44:25] nope so far this weekend [16:44:32] and this morning it's been a-ok [16:44:37] knock on wood [16:44:39] though I probably just jinxed it [16:44:45] yeah, nice going [16:44:47] ;) [16:44:53] hehe [16:45:26] are we waiting on anything from the design team that would impede kickoff? [16:47:37] a couple of the stories have assets that are still kinda sketchy placeholders, but i bumped them down in priority [16:47:51] i think by the time folks start on the top stories, the copy + visuals for those assets should be finalized [16:48:02] okay cool [16:48:19] so who won in the BART strike?:P [16:48:24] (this is #920 & #921) [16:48:24] I will get my fake Mustache so I can stand in for arthur properly [16:48:28] :D [16:48:33] maxsem, there were only losers :( [17:11:45] hey brion [17:11:55] yo yo [17:12:05] we conflicted on patch submission :P [17:12:18] heh [17:12:21] i merged mine since we don't have anything honeycomb specific. [17:12:24] spiffy [17:12:29] our styles are now just 'pre ICS' and 'post ICS' [17:12:37] i'm getting a google tv device which i think is honeycomb based so i'll test on that ;) [17:12:41] brion: also, code review for the large campaigns patch? [17:12:51] YuviPanda: i'll take another look through it after standup [17:12:55] brion: sweet [17:12:58] then i'll finish up the details page and you can review that :D [17:15:07] brion: \o/ [17:18:31] maxsem, do you need any help with the wmf wiki stuff? i'm happy to pitch in and categorize pages [17:25:14] Maryana, thanks - there's https://wikimediafoundation.org/wiki/Category:Desktop-only_pages [17:25:20] brion: i'm going to look into the OOM, and also consider trying a different image loading library. Now that we have MediaWikiImageView it should be easier [17:25:47] its contents are prevented from mobile view [17:26:30] but some groups of pages we need to blacklist don't even have a suitable common template [17:31:53] YuviPanda: taking out Volley, or taking out the image decoder portion? [17:32:08] volley. we don't do manual image decoding anywhere [17:32:19] ok [17:32:31] any problems with it other than the memory cache? [17:32:41] not that big a deal now, again, since there exists MediaWikiImageView. [17:32:56] brion: the network library itself isn't as good as I'd like it to be (no promises, just callbacks) [17:33:16] brion: also, the fact that it has no community to speak of - there's just a git repo, and google pushes to it when it feels like. Makes me a little uncomfortable. [17:33:25] nobody to report bugs to, etc [17:33:30] it's not as bad as code drops, but still [17:33:49] this was also the reason we didn't move the rest of the API to that, I think. [17:33:52] aww [17:34:15] brion: but since it's all abstracted away now, shouldn't matter too much [17:34:18] maybe i'll write a java promise library like my obj-c one. i've been going mad with anonymous inner classes as callbacks :D [17:34:19] yay [17:34:35] brion: promises already exist in Java. just that these things have to use them! [17:35:07] write once, run everywhere [17:35:10] promises, promises... [17:35:22] brion: hahah :P [17:39:15] brion: not going to replace anything right now, though. Campaigns first... [17:39:34] yes [17:39:43] brion: so... CodeReview? :D [17:39:57] moment [17:40:03] looking at http://elohim.gaijin.com/flowdemo/ it's pretty :D [17:41:24] * brion wanders over to https://gerrit.wikimedia.org/r/#/c/70446/ [17:41:33] brion: it is indeed! [17:46:50] New patchset: Jdlrobson; "Tweaks to cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72551 [17:47:56] YuviPanda: i don't see any responses on the WLM thread. did you hear any chatter ? [17:48:16] tfinc: yeah, spent a good amount of time on the #wikilovesmonuments channel explaining it. [17:48:27] tfinc: mostly to odder. he did say he'll respond... [17:49:09] YuviPanda: it would be good for them to respond on list rather then fragmenting the discussion [17:49:41] tfinc: they're also concerned in general (outside of mobile), since last year preperations started in may, while there hasn't been too much work this year yet. So mobile hasn't been the biggest worry so far. [17:49:44] tfinc: yeah, will poke him [17:49:54] thanks [17:51:36] YuviPanda: i noticed the lat/lon are now specific as numbers. what do we store when there's no lat/lon default? 0? 0 can be legit, in theory :) [17:51:41] i guess 0,0 is unlikely [17:52:00] brion: it's also current behavior. [17:52:05] brion: plus yeah, 'unlikely' [17:52:08] ah perfect :D [17:52:10] that'll do then [17:52:16] when in doubt, call it legacy behavior ;) [17:52:25] brion: adding null check now [17:56:18] New patchset: Jdlrobson; "Tweaks to cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72551 [17:57:06] brion: updated [17:57:19] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72551 [18:03:57] YuviPanda: all migrated campaigns come up as disabled [18:04:11] brion: hmm, really? [18:04:13] * YuviPanda looks [18:04:15] yup [18:05:42] brion: hmm, I see it [18:06:47] brion: looks like the number / string confusion. grr. let me fix [18:07:40] YuviPanda: with migrated code using 'wlm-nl' I can't get past the 'release rights' stage. no JS errors, it just doesn't do anything when i click 'next' [18:07:48] switching back to the master version, it works fine [18:08:08] hmm, I remember testing with that and it worked [18:08:10] let me test again [18:08:38] see this is why i wanted the migration script done [18:08:48] can't really review it until there's test data to work with [18:09:29] brion: :) [18:09:46] brion: try another wlm- cthing? [18:10:46] i mean, something else? [18:11:42] wlm-de-hh works [18:16:00] New patchset: Jdlrobson; "Set padding on header, to avoid collision with collapse control" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72325 [18:16:01] New patchset: Jdlrobson; "Add educational prefix to all less files" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72560 [18:16:31] New review: Jdlrobson; "I updated the corresponding less file as well. Thanks for the fix!" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/72325 [18:17:24] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72325 [18:17:36] brion: the 'disabled by default' thing fixed. now looking at wlm-nl [18:17:44] whee [18:22:46] MaxSem: jgonera any views on the mission statement ? http://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web/Mission [18:24:54] added my color to this bikeshed:P [18:31:59] New patchset: Jdlrobson; "Regression: Correctly use extend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72564 [18:36:53] https://bugzilla.wikimedia.org/show_bug.cgi?id=50761 < MaxSem [18:37:05] Seems someone added the back port tag [18:38:14] * MaxSem is confused [18:38:51] I thought that tag is for core changes only [18:39:22] jdlrobson, I can deploy it if we can't wait 22 hours:) [18:39:33] I'm fine [18:39:48] no skin off my back either way [18:40:01] i think we can live another day [18:43:42] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72564 [19:01:34] PHP Fatal error: Allowed memory size of 183500800 bytes exhausted (tried to allocate 102401 bytes) in /usr/local/apache/common-local/php-1.22wmf8/extensions/MobileFrontend/includes/skins/MinervaTemplate.php on line 58 [19:04:39] Reedy, Parser is much more skilled at generating these:) [19:05:14] Funny to see it in skin code though [19:06:15] Hey MaxSem, I need your brain-power at https://gerrit.wikimedia.org/r/#/c/72373/ [19:06:25] yep, already seen [19:06:41] Let me know if you have any ideas or if I should just refactor it to do all the queries one at a time [19:06:52] one at a time is too slow [19:10:01] So far it's made my head hurt trying to come up with a solution so I'm going to grab some brain fuel. [19:14:07] New patchset: MaxSem; "An incomplete attempt to fix MobileContext::getDesktopUrl()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72612 [19:14:32] New review: MaxSem; "Incomplete." [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/72612 [19:25:24] auughh, can't stay logged in on wmf wiki >:[ [19:59:07] Maryana_lunch: just noticed we don't event log when a user watches an article from the anon CTA :( [20:02:26] kaldari, I think I know what to do with PageImages and it's one big eww [20:02:28] New patchset: Jdlrobson; "Inform users why certain functions are not enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72228 [20:02:29] New patchset: Jdlrobson; "Story 832: Show icons when not available / add new assets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72227 [20:08:42] MaxSem: Oh? [20:10:31] YuviPanda: the parcelable stuff for Media/Contribution are only used at runtime right? they're only stored as sql? [20:10:32] lots of array manipulation [20:15:03] brion: yeah, parcelable is only runtime [20:15:05] nothing on disk [20:15:18] good, then nothing will break when i add to it :D [20:15:23] oh yes definitely [20:15:30] Parcelable is *always* breakable [20:22:55] aaaaaaaah HashMap is not serializable [20:23:09] i'll go with writeMap and see if it explodes [20:25:47] can that Java do at least anything useful? gah, even C# can serialize these [20:27:15] brion: why are you serializing them? [20:27:27] brion: also, use a bundle! [20:28:12] YuviPanda: in Media.writeToParcel there's a few parcel.writeSerializable()s [20:28:22] true true. [20:28:29] that's fine [20:28:31] just asking why :) [20:28:37] as in [20:28:38] gah [20:28:45] i was about to ask 'what are you putting in the hashtable' [20:33:48] YuviPanda: hash table is the multilingual descriptions [20:33:56] oooh, we're parsing those now? [20:33:57] nice [20:34:04] is that ok or prefer a list of arrays or something? [20:34:52] nah, hash of lang code -> desc sounds okay to me [20:37:56] New patchset: Cmcmahon; "Automation tests for Mingle Stories#976 and #977 - Must be logged in to use Watchlist and Uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72480 [20:50:52] New patchset: Jdlrobson; "Bug 50680: Use mouseup rather than keyup to open search overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72631 [20:51:30] New patchset: Cmcmahon; "Automation tests for Mingle Stories#976 and #977 - Must be logged in to use Watchlist and Uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72480 [20:52:41] New patchset: Cmcmahon; "Automation tests for Mingle Stories#976 and #977 - Must be logged in to use Watchlist and Uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72480 [20:56:08] jdlrobson: "just noticed we don't event log when a user watches an article from the anon CTA" [20:56:10] ? [20:59:16] looks like we were missing a video call for sprint kickoff [20:59:19] I just added one [20:59:32] https://plus.google.com/hangouts/_/b211abd91a844a43ade97b636c35aab3b9fab79d [20:59:56] New review: Cmcmahon; "un-typo'd, formatted, tested, merged" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/72480 [21:00:15] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72480 [21:00:34] ughhhh "You're not allowed to join this video call." [21:00:41] uhoh [21:00:55] sorry, squatters in our meeting room [21:01:04] i'm glaring at them very menacingly [21:01:18] same here google is great :) [21:01:32] let me see if I can create a new hangout and send it [21:01:45] jcmish: mergedededed: https://gerrit.wikimedia.org/r/#/c/72480/ [21:01:55] sweet thanks chrismcmahon [21:02:28] https://plus.google.com/hangouts/_/1d8d96f615860ca6e255ba680c0270babc07609b?pqs=1&authuser=0&hl=en [21:02:39] MaxSem: [21:02:41] see if that works [21:03:37] having permission problems here too [21:04:19] sent a new link jdlrobson Maryana jgonera [21:04:30] that's actually working Max and I are on let me know [21:04:36] if you can't access it [21:16:22] brion: here's the doc making my life ever so much less confusing: http://developer.apple.com/library/ios/#documentation/WindowsViews/Conceptual/ViewControllerCatalog/Chapters/NavigationControllers.html [21:16:32] +1 [21:22:59] YuviPanda: ok so i'm trying to move the categories and descriptions lists into Media object, currently still fetching/filling them from MediaDataExtractor [21:23:04] https://github.com/brion/apps-android-commons/commit/510569ddd571ef3688815f452d7b5fc6b40c7794 <- work in progress commit [21:23:12] okay looking [21:23:17] unfortunately my ArrayList for categories doesn't get initialized [21:23:22] which confuses the hell out of me [21:23:57] i'm sure i'm missing something obvious [21:25:10] brion: doesn't get initialized anywhere at all? [21:25:45] well not when i load the detail page [21:26:01] it's null, so when i go to clear it out and fill in the categories it explodes with a null pointer exception [21:27:08] i can give up and assume it'll be null at start, but it feels icky [21:27:13] since i think i'm initializing it… :) [21:27:27] brion: breakpoing on the initializer, see if that is hit? [21:27:51] also i wonder if Contribution is calling its parent constructur? [21:28:24] hmm it doe [21:28:25] s [21:28:51] oooh real debugger eh [21:28:52] i'll try [21:29:03] brion: ah, one such constructor doesn't actually call super [21:29:16] Contribution.java L206 [21:29:19] ¡Bastardo! [21:29:44] that would be me, yes. [21:29:51] heh [21:29:54] that's only called from one place, which is fromCursor [21:29:56] right below it [21:30:01] so that might be it? [21:30:08] yeah, that sounds likely [21:30:12] so if you're getting data out of the sqlite table, it won't be initialize [21:30:12] d [21:30:37] hmm, i can stick it in a super constructor [21:32:34] … can constructors not call simpler constructors? [21:32:51] you get one 'super' call [21:32:51] and it has to be the first thing you do [21:32:54] in your constructor [21:33:00] aha this(); [21:33:19] YuviPanda: within Media I need constructor with params to call constructor without params :) [21:33:21] and i think this should work [21:33:28] hmmm [21:33:29] yes [21:33:31] that should work [21:33:38] so put 'should initialize no matter what' [21:33:39] in that [21:34:02] yayyyyyy it works [21:34:09] :)_ [21:36:20] New patchset: Jdlrobson; "Remove device specific stylesheets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71731 [21:37:18] So MaxSem how do you feel about merging https://gerrit.wikimedia.org/r/#/c/71749/ for deployment after next? [21:37:43] (if we fix the wap bit) [21:37:53] do we have a functional WAP device?:P [21:38:09] haah no [21:38:11] cause I fear that Opera is a badd approximation [21:38:23] srsly, we should get one [21:38:45] the problem with wap is they don't tend to have wifi connections ;-) [21:38:53] so it would need a sim card etc and data cost [21:39:10] btw for background - https://gerrit.wikimedia.org/r/#/c/71748/ - i generated this by writing a script that visited every wikimedia project page and looked to see if the main page had been special cased [21:39:28] if we spend like 5 megs per month on testing, that wouldn't be insanely expensive [21:39:37] so the only visible difference on html is that pages which currently say 'please enable homepage' will get homepages [21:39:52] MaxSem: worth dropping a mail to tfinc ? i'm all for it if it's possible [21:40:24] http://af.m.wikipedia.org/ < but things like that are embarrassing [21:40:27] still no special casing!! [21:41:29] jdlrobson: just confirming, but without specifically setting target as mobile, normal RL modules won't load for mobile, right? [21:41:36] hmm, how about us returning unchanged HTMl if there's no special ids? [21:41:51] MaxSem: that could also work :) [21:44:12] zomg it's way past food time. bbiab [21:56:38] YuviPanda: correct [21:57:03] MaxSem: I would like to kill the main page special casing with fire though. we've been too nice in providing an easy way out [21:57:14] all main pages should be massively redesigned! [21:57:28] feel free to;) [21:57:37] (redesign them) [21:58:54] maxsem, i don't get how this hidden category thing works >:[ [21:58:57] yehhh i need media query support though :( [21:59:27] Maryana, you just add it and it works:) [21:59:30] ( https://m.mediawiki.org/wiki/Requests_for_comment/Allow_styling_in_templates ) [22:00:44] for example, https://wikimediafoundation.org/wiki/Wikipedia_Zero?useformat=mobile works [22:00:54] [[Category:Desktop-only pages|{{PAGENAME}}]] [22:00:56] ? [22:01:24] https://wikimediafoundation.org/wiki/Staff_and_contractors?useformat=mobile is blacklisted [22:01:38] is for templates only [22:01:44] bah [22:01:46] i knew it [22:02:18] ok, so it works now, no deployment necessary? [22:02:35] through the magic of templates? :) [22:02:59] but why aren't all pages in this cat listed here? https://wikimediafoundation.org/wiki/Category:Desktop-only_pages [22:03:14] New patchset: MaxSem; "Output unchanged main page instead of nothing if no special cased ids" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72639 [22:03:14] New patchset: JGonera; "Story 839: Save from preview in editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72640 [22:03:26] jdlrobson, ^^ [22:04:00] New patchset: JGonera; "Story 839: Save from preview in editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72640 [22:04:00] brion-away: vibha stopped by for the iPod [22:07:25] New patchset: JGonera; "Remove deleted messages from Resources.php" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72642 [22:07:36] New patchset: Jdlrobson; "Output unchanged main page instead of nothing if no special cased ids" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72639 [22:08:57] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72642 [22:09:22] \o/ MaxSem [22:09:24] made a few tweaks [22:10:50] New patchset: JGonera; "Make editor license links open in separate tabs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72643 [22:14:23] brion: so looks like I'll have to write my own implementation of array_replace [22:14:33] brion: that treats non-associative arrays as scalar values and just rplaces them [22:14:43] brion: rather than replace them recursively [22:14:53] that should fix this, almost done with that [22:14:54] testing now [22:14:55] oh php [22:15:01] indeed [22:15:13] having separate array and hash classes would've made sure this doesn't happen [22:15:24] return ( bool )count( array_filter( array_keys( $array ), 'is_string' ) ); [22:15:31] is how you detect if something is an assoc array or not [22:15:34] * YuviPanda facepalms [22:19:50] New patchset: Cmcmahon; "name scenarios" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72644 [22:23:05] New patchset: Cmcmahon; "name scenarios" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72644 [22:23:45] New review: Cmcmahon; "forgot to name the Scenarios, use visit() not on()" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/72644 [22:24:06] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72644 [22:26:52] YuviPanda: just for fun i picked up a Google TV box… good news is it's got all the debug settings like any regular android device! [22:27:01] toow! [22:27:02] err [22:27:03] woot! [22:27:04] bad news is it's got a *regular* usb port, so i need a different cable to hook i tup [22:27:09] good news is, i have one at home [22:27:14] so i'll fiddle with that later :D [22:27:15] wait so you need regular usb to regular usb? [22:27:17] :D [22:27:18] niceeed [22:27:19] yeah [22:27:34] we can have slideshows of commons photos running on screens at wikimania [22:27:35] seems to still be honeycomb-based :D [22:27:44] from campaigns [22:27:44] YES THATD BE SWEEEEET [22:27:48] similar to how other conferences have like hashtag thingies [22:27:53] but we need to get this all done by than [22:27:56] arrhurr durr! [22:28:02] yeah gotta get in geeeeear [22:28:03] I think this works, let me test it some more [22:28:26] main thing we need for gtv support is to say we don't require touchscreen [22:28:33] and make sure d-pad navigation actually works consistently [22:30:20] brion: ah [22:30:23] does it tho? [22:30:35] it seems to mostly work on my nexus 1's little trackball [22:30:38] i'll play with it more later [22:32:21] hmm, this merging business is nasty [22:33:24] http://www.theverge.com/2013/5/5/4302244/google-glass-awkward-interactions-parodied-saturday-night-live [22:33:52] brion: so if we recursively merge *properly* and sanely, it runs into problems - because now I need a lot of null checks everywhere [22:34:04] since I won't be getting empty fields, etc - for example. [22:34:09] hmm [22:34:19] mhurd: i'm in R33. ready when you are [22:34:26] garr hurr durr. [22:34:34] tfinc: omw [22:34:48] urggg [22:34:49] New patchset: JGonera; "Style all the inputs and textareas in the same way" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72648 [22:35:21] no, this doesn't work [22:35:22] aargh. [22:35:34] there has to be a general solution! [22:40:00] brion: I have ! ( mw.UploadWizard.config.fields && mw.UploadWizard.config.fields[0].wikitext ) , [22:40:11] and mw.UploadWizard.config.fields is [] [22:40:20] why is the second condition being evaluated at all? [22:40:22] ! [22:40:22] i think [] is true in javascript [22:40:25] am I missing something here? [22:40:26] wat [22:40:30] it's an object [22:40:34] mw.UploadWizard.config.fields == false [22:40:41] true [22:40:43] says firefox [22:40:48] >>> mw.UploadWizard.config.fields == true [22:40:51] false [22:40:53] says firefox [22:40:57] well [22:41:02] 1 == true is false as well [22:41:08] no wait it isn't [22:41:22] >>> 1 == true [22:41:22] brain…. breaking…. languages…. silly [22:41:25] true [22:41:29] that's why we have === :P [22:41:44] true :) [22:42:09] brion: in this case === is going to make things awkward [22:42:12] >>> mw.UploadWizard.config.fields === [] [22:42:15] false [22:42:32] >>> mw.UploadWizard.config.fields [22:42:33] [] [22:42:33] check fields.length [22:42:45] so that we can't do if fields is null [22:42:50] [] === [] <- returns false because they're different objects [22:42:53] fields && fields.length ? [22:43:01] but is that how it is supposed to be?! [22:43:11] because mw.UploadWizard.config.fields == false is true! [22:43:28] so why isn't it shortcircuiting? [22:44:11] hmm [22:45:00] YuviPanda: Wait, what value ==false? Empty array? [22:45:11] mw.UploadWizard.config.fields [22:45:12] [] [22:45:14] yes [22:45:15] empty array [22:45:26] YuviPanda: I think "== false" doesn't necessarily mean "falsy" [22:45:38] == false returning true doesn't mean falsy? [22:45:43] == isn't strict... [22:45:44] YuviPanda: Why not use ternary, or just write the if statement [22:46:05] i can add an extra statement, but why doesn't this work!? [22:54:29] Maryana, we do have hot cat enabled on wmfwiki btw [22:54:38] oh snap [22:54:42] thank you! [22:54:43] :D [22:54:46] :) [22:56:09]