[00:09:59] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72663 [00:11:11] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72650 [00:11:37] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72643 [00:13:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72648 [00:21:29] New patchset: JGonera; "Prevent cutting off license image" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72668 [00:27:56] New review: JGonera; "Please check if it works on Kindle. I vaguely remember I used keyup because Kindle would only refres..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/72631 [00:29:17] sorry I ran off to eat jgonera [00:29:27] I waited to pull the logs so you're fine [00:38:23] jdlrobson, do you still want to merge something? I guess we're done for now, right? [00:38:40] jgonera: i was doing the toast message for unavailable photo uploads [00:38:41] almost done.. [00:39:02] jcmish, can we still smuggle this one in? [00:40:10] yeah I'm good [00:40:12] ew, stale toast [00:40:12] go for it [00:40:22] :D stale toast nice haha [00:44:47] New patchset: Jdlrobson; "Inform users why certain functions are not enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72228 [00:45:00] jgonera jcmish ^ [00:45:08] k got it [00:46:37] tfinc: https://github.com/montehurd/Commons-iOS/compare/detailsDetails [00:46:57] jgonera: can you review and merge? [00:47:00] tfinc: doesn't have the iPad image resolution tweak - going to add that now [00:47:08] nice [00:47:32] i'll pull it down tonight and play with it [00:56:23] New patchset: JGonera; "Inform users why certain functions are not enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72228 [00:57:18] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72228 [16:25:54] playing with the Google TV … bad news is turns out you can't do USB debugging :( [16:26:03] good news is you can connect via adb over the network \o/ [16:27:00] zomg commons is runnnnnnninnnggggg [16:37:24] not so good when the IP addresses get reassigned during your debug session though :P [16:53:53] Maryana, yt? [16:54:02] yep - what's up? [16:55:01] current iteration story wall and previous iteration's one point to the same list of cards [16:55:11] a botched up new iteration? [16:55:17] yeah, i noticed that… not sure [16:55:31] but i didn't do it :) [16:56:35] we've got a load of cards in current iteration's ready for dev - another fail? [16:57:15] no, that's expected. these are just the current iteration's stories [16:57:24] or do you mean leftovers from last iteration? [16:57:33] (grr, mingle) [16:58:20] I don't think that https://mingle.corp.wikimedia.org/projects/mobile/cards?favorite_id=625&view=Next+iteration+story+wall is all we're going to work on for the next 2 weeks [16:58:45] MaxSem: ? [16:59:34] jdlrobson, mingle meltdown [16:59:39] how so? [16:59:46] maxsem, you're looking a tthe next iteration [16:59:59] go to story wall tab [17:00:07] that should have the current iteration's cards [17:00:10] at least it does for me [17:00:28] https://mingle.corp.wikimedia.org/projects/mobile/cards/grid?aggregate_property%5Bcolumn%5D=story+points&aggregate_type%5Bcolumn%5D=sum&color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BInfrastructure%5D&filters%5B%5D=%5BIteration%5D%5Bis%5D%5B%28Current+iteration%29%5D&group_by%5Blane%5D=status&lanes=In+Analysis%2CR [17:00:28] +for+Estimation%2CReady+for+Development%2CIn+Development%2CAwaiting+Final+Code+Review%2CReady+for+Testing%2CIn+Testing%2CReady+for+Signoff%2CAccepted&tab=Story+Wall < this url [17:00:35] LOVELY AND LONG woooo! \o/ [17:00:55] maxsem, seeing it? [17:00:58] so does "Story wall" point to the right iteration or what? [17:01:17] yes [17:01:17] for me, anyway [17:01:26] and how can we fix the previous iteration? [17:01:56] hey guys did I mess up wone of the iterations? [17:02:14] and jdlrobson and MaxSem did you check and see why on beta labs I can't upload a photo? [17:02:24] brion: it got merged! :) [17:02:27] sure mgrover i'll check that out now [17:02:33] danke [17:02:52] mgrover: in terms of mingle - i'm not sure - but there are things in testing that should probably be in last iteration (to give us a better idea of velocity) [17:03:01] YuviPanda: https://commons.wikimedia.org/wiki/File:Google_TV_app_switch_menu_with_Commons_app.jpeg :) [17:03:04] i'm not quite sure how that's suppose to work.. [17:03:21] yeah, the current iteration story wall is fine, but previous iteration got eaten somehow [17:04:20] ah jdlrobson those I should have moved to ready for signoff on the other iteration sorry about that I can fix that let me see what I did with the previous Maryana one moment [17:04:21] mgrover: do you remember the url when you had the empty message box? [17:04:46] let me grab it I saved it on my phone :D [17:04:51] ahh mgrover that's normal - that's a messagw thing dont worry [17:05:00] ahhh okay cool [17:05:02] * jdlrobson wishes there was a way to get latest messages on beta labs.. [17:05:18] * mgrover agrees with jdlrobson [17:05:24] brion: looks sweet :D [17:05:26] it always freaks me out [17:06:09] YuviPanda: unfortunately it's… not perfect. sometimes d-pad navigation issues. but most importantly, there's not a gallery picker app or an email app [17:06:19] so you can't send feedback/crash reports, and you can't upload photos :) [17:06:22] brion: no gallery at all in a tv app? [17:06:28] waat [17:06:31] there's a 'photos' app [17:06:39] but it doesn't seem to implement the picker intent [17:06:40] but it doesn't let you share photos, only 'url's? [17:06:42] yeah [17:07:12] also no default apps accept 'share' :) [17:07:25] mgrover: not sure i understand the placeholder problem.. [17:07:29] but with some tweaking we could make it work, and it'd be bitchin' for slideshows [17:07:33] so once we have such a feature i'll play with it more [17:07:38] brion: indeed :) [17:09:23] ok i gotta run some errands then back to work [17:09:27] so when you refresh the screen it just flickers and the window shows "Search Wikipedia (Experimental)" for a brief second [17:09:48] what browser mgrover ? [17:09:48] then it changes to "Search Wikipedia (Experimen [17:09:57] on safari on iphone and ipad [17:10:12] latest os [17:10:31] ahh that's just a browser thing mgrover [17:11:07] alrighty it's why I said it was an honorable mention item :D [17:11:40] New review: Jdlrobson; "merge post deployment" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/72668 [17:14:16] mgrover: you cool with merging the fix for the talk bubble before deployment? [17:14:18] super minor one.. [17:14:48] can I look at the commit? [17:14:48] gerrit number? [17:15:03] mgrover: sure 1s [17:15:26] New patchset: Jdlrobson; "Regression: Correct styling of the talk button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72747 [17:15:32] ^ there you go mgrover [17:15:48] changing a 4 to a 3 ;-) [17:16:09] oh yeah I'm good with that one too [17:16:19] sweet [17:16:46] MaxSem: ping [17:16:51] pong [17:16:57] on to trying to figure out the story wall issue :) [17:17:01] mgrover: thanks for the git logs being super early :D [17:17:06] i'm looking at geodata and see how wikidata / wikibase can fit in [17:17:20] wee! [17:17:22] there is a dim parameter and wonder how commonly it is used? [17:17:40] jdlrobson: you bet [17:17:44] mgrover: are you still manually constructing them? [17:17:52] yes and no [17:17:58] I played with my script [17:18:09] and got some of it to generate as part of testing it out [17:18:12] you want any help on that? i'm really keen to codify some of other commit message coding best practices [17:18:15] but I need to do a few more tweaks [17:18:17] didn't get them all [17:18:33] sure when I'm done I'll commit it and make you the reviewer [17:18:38] we'll pair and clean it up [17:18:40] MaxSem: i also see the type to dim stuff which seems more commonly used [17:18:56] * jdlrobson is also surprised max didn't merge the removal of device stylesheets after wetting himself in irc the other day ;-) [17:19:02] mgrover: sweeT :D [17:19:07] mmm, hard to say because there's always a default dim [17:19:15] Maryana: the last iteration was #827 2012/2013 Q4 - Iteration 6 right? [17:19:30] this one that just wrapped up? [17:20:15] i believe so [17:20:48] k weird because it did change it but I can't get the previous story wall to show that [17:20:50] let me poke around [17:21:38] aude, I did a quick scan of coordinates from dump and it looks like dim isn't really popular. scale is more so, ut still no more than 10% total [17:22:05] hmmmm scale [17:22:14] ok [17:22:27] we could have something that maps to the types as a start [17:22:48] and dim or scale could potentially be other wikidata properties, or could be handled some other way [17:22:57] aude, when I investigated this, I decided that scale is very subjective and dim is much more clear [17:23:20] woohoo fixed Maryana jdlrobson MaxSem [17:23:28] MaxSem: ok [17:23:31] take a look at previous and current [17:23:53] dim can be a property of the item, although it's up to the community and has to wait until we have the quantity data type [17:24:04] until then, i suppose dim can be done the same way as it's done now [17:24:12] e.g. in templates and in the parser function in the wikipedias [17:24:20] or could use type [17:25:50] aude, how will GD and WD interact? [17:26:05] that's what i'm figuring out [17:26:26] heh [17:26:50] i could at least make an updater script that gets data from wikidata / wikibase [17:27:01] I'm ready to help with anything I can. if you need to chat, just poke me [17:27:11] i got solr working with geodata :) [17:27:17] wasn't difficult [17:27:47] we just need to figure out how to handle dim and if we want maps on wikidata, then how to set a zoom level for a map [17:27:57] e.g. map with a single coordinate or such [17:35:38] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72747 [17:36:15] any Kaldaris around? [17:40:48] howdy [17:40:58] hey [17:41:46] thanks for the code review [17:44:56] kaldari, can you review https://gerrit.wikimedia.org/r/72218 please? [17:45:09] sure [17:46:20] looks good to me [17:47:54] thanks:) [18:03:16] New patchset: JGonera; "Fix JS errors reported by jshint 2.1.4" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72753 [18:18:43] tfinc: stepping out run quick errand [18:18:48] mhurd: k [18:19:00] tfinc: get a chance to play with details branch? [18:19:17] jdlrobson, kaldari http://stackoverflow.com/a/1285155/365238 [18:19:30] mhurd: no, i couldn't find the iPod touch last night. betting i left it in my desk. mhurd is the pull request merged in ? [18:19:37] or should i build from the pull request [18:20:35] not merged yet - pull from https://github.com/montehurd/Commons-iOS/tree/detailsDetails [18:20:41] k [18:21:24] brb. should take ~45 min [18:35:56] MaxSem: i think this may be out of date - care to cleanup at some point? https://m.mediawiki.org/wiki/Mobile_Gateway#editor-10 [18:38:04] YuviPanda: hmm, pull req didn't make it to gerrit? https://github.com/wikimedia/apps-android-commons/pull/24#issuecomment-20689835 [18:38:06] jdlrobson, this page is a mess. what is it intended to be - a mobile team project page or something? if not, what does our team's mission statement does on it? [18:38:24] brion: hmm, 'error'd out. looking into it in a couple of minutes. [18:38:33] tx [18:38:36] brion: setting up the WLM folks for testing things now [18:38:41] spiffy [18:38:43] no rush :D [18:38:45] MaxSem: agreed. I started trying to consolidate our documentation as it was scattered all over the place. Vibha was making a page that already existed for example. Could do with some help gardening it all [18:38:49] just a honeycomb fix that won't affect many folks [18:38:51] this page is meant to be the homepage for mobile web [18:38:53] brion: :) [18:39:13] mobile web? that's vague:) [18:39:19] i guess mission statement would be better on the team page.. moving [18:39:31] is it for users, developers, WMFers, volunteers? [18:39:58] how different is it from [[Extension:MobileFrontend]]? [18:40:00] MaxSem: it should be for everyone - it's the homepage for MobileFrontend basically [18:40:10] then it should be a redirect [18:40:49] yeh Extension:MobileFrontend is a mess.. [18:41:16] a reason to make it not mess:) [18:41:53] I'll merge them and attempt to make the result less sucky [18:42:34] "Buggy Transitions, errors or strange ux? Leave us a note on this discussion page" - and a link to non-discussion page:P [18:42:46] yeah that as vibha ;-) [18:42:52] *that was [18:43:08] i corrected that Max no? [18:43:48] where's discussion at https://www.mediawiki.org/wiki/Mobile_design ?;) [18:44:01] MaxSem: i'll poke vibha now.. [18:47:02] she's right here, jdlrobson [18:47:05] behind the whiteboard [18:47:10] i know Maryana [18:47:15] i sent a mail - i didn't want to interrupt [18:51:43] "MobileFrontend is a MediaWiki extension providing a mobile web front-end to MediaWiki sites including Wikipedia. [...] It is powered by the MobileFrontend extension." [18:52:58] a great proof that this page is redundant [18:54:52] MaxSem: got another version of PageImages for you: https://gerrit.wikimedia.org/r/#/c/72373/8 [18:58:24] jdlrobson, see my reply [19:18:37] New patchset: JGonera; "Story 839: Add preview header (follow-up)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72764 [19:24:52] jdlrobson, who's gonna merge https://gerrit.wikimedia.org/r/72639 ?:P [19:37:32] brion: it's up on betalabs ;) [19:37:40] woo [19:37:54] brion: http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard&campaign=wlm-nl [19:38:04] brion: let me know if you want rights to edit pages there [19:39:23] Firefox can't establish a connection to the server at commons.wikimedia.beta.wmflabs.org. [19:39:32] ah there it goes [19:39:41] brion: yeah, it was down for a couple of seconds [19:39:46] MaxSem: you can - i guess it's too late for this deployment though :) [19:39:49] hashar, etc are doing some filesystem maintenance on it [19:40:19] yeah:) [19:42:19] hmm [19:42:23] {{subst:WLM-is-running|nl|Template:Wiki Loves Monuments 2012}} [19:42:32] brion: those aren't imported [19:42:39] ah [19:42:42] brion: so that's all going to be messed up [19:42:46] i was worried something was saving the page wrong [19:42:47] brion: i'm asking odder to import those [19:42:48] http://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Screenshot_of_Windows_8.1_store_with_Wikipedia_app.png&action=edit [19:43:24] brion: nah, it looks right. [19:43:53] Firefox can't establish a connection to the server at upload.beta.wmflabs.org. [19:44:08] oh labs [19:44:13] you sorta work :) [19:44:52] brion: :D [19:45:06] brion: it's currently being debugged at -labs. Shared storage is being a pisspot [19:45:12] brion: not our fault :) [19:45:15] hah [19:45:45] brion: i've a coupole other feature requests from the wlm folks which i'm going to fix now [19:45:45] https://bugzilla.wikimedia.org/show_bug.cgi?id=39910 [19:45:49] https://bugzilla.wikimedia.org/show_bug.cgi?id=39911 [19:46:45] brion: any objections to fixing those? [19:47:07] feel free to work those out with the requesters, i don't mind :) [19:47:40] :) [19:48:15] ooh we could add game controller support to commons app! ;) https://devs.ouya.tv/developers/docs/controllers [19:48:41] yurik & dr0ptp4kt, shall I deploy Zero along with MF? [19:50:53] MaxSem, that should be safe. just locali(z|s)ation updates. yurik, yuri_k ^ [19:51:03] tfinc: odder responded via email. [19:51:14] to that thread [19:51:21] if it's just l18n, then itt's not needed [19:51:37] MaxSem, yeah, don't worry about it, thx [19:52:37] MaxSem, good point. [19:59:58] Hey MaxSem are we ready to get started [20:00:15] in process [20:02:17] jcmish, jdlrobson, jgonera, Maryana - we're live on testwiki, please test:) [20:02:21] kayo [20:03:10] New patchset: JGonera; "Small fixes to page actions" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72767 [20:03:16] who doing the deployment today? MaxSem? [20:03:39] kaldari: MaxSem deploys to test wiki we test [20:03:47] then he promotes it up to en.m [20:04:13] would anyone object to me going ahead and deploying my config change to turn on Disambiguator for the other wikis? [20:04:46] it's already live on test, test2, and en.wiki [20:05:07] kaldari: I don't know enough about it to weigh in... MaxSem ? [20:05:08] go ahead [20:05:20] thanks [20:05:30] if it's on en, it's pretty safe:P [20:05:43] sweet [20:05:47] thanks for weighing in [20:05:56] kaldari, will you announce it on blogs or something? [20:08:42] everything's looking good for me so far.. [20:09:08] automation tests passed now doing some manual poking around [20:11:20] hmm, jdlrobson, why do the edit and upload icons flash locked when pages first load and then show up unlocked [20:11:22] you seeing that? [20:11:53] it's because the javascript loads at the bottom [20:11:56] ergh, "An error occurred while invoking the map callback in /usr/local/apache/common-local/php-1.22wmf9/includes/resourceloader/ResourceLoaderFileModule.php on line 611" [20:12:18] that error wasn't there before we rolled out to testwiki [20:12:22] o_O ? [20:13:06] I'm all done with the disambiguator roll-out BTW [20:13:10] it's readStyleFiles() [20:13:29] MaxSem: what's going on? [20:13:30] kaldari: \o/ [20:13:44] jdlrobson, flood in error log [20:13:49] you have to write it like this, though: The Disambiguator(tm) [20:13:55] oh yeah [20:13:58] MaxSem: any further information? [20:14:27] do any of our modules list a missing css file? [20:14:49] it's hard to say without knowing further information [20:16:55] aha [20:16:57] ResourceLoaderFileModule::readStyleFile: style file not found: "/usr/local/apache/common-local/php-1.22wmf9/extensions/MobileFrontend/stylesheets/devices/" [20:17:02] lol [20:22:59] mmmm [20:23:18] MaxSem: https://gerrit.wikimedia.org/r/#/c/71731/ < push the button? [20:25:08] New patchset: MaxSem; "Quick hack to remove now useless device modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72773 [20:25:20] too scary for right now, ^^^ is simpler, jdlrobson [20:25:29] i love scary MaxSem :) [20:25:46] MaxSem: you missed the global [20:25:51] $wgMFVaryResources [20:25:51] sorry guys have been heads down poking around [20:25:56] did I miss something in testing? [20:26:09] I love it too, but I also love Wikipedia [20:26:20] jcmish, that bug wasn't visible to you [20:26:31] ah okay [20:27:38] I understand that everyone have heard this a bunch times already, but you suck, PHP! [20:27:41] MaxSem: btw, you can also get the exceptions from the front-end. e.g. on test.wikipedia.org/wiki ?format=mobile I open the Network tab and see this: [20:27:41] https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mobile.styles%7Cmobile.styles.page%7Cmobile.xdevice.detect%7Cmobile.zero.styles&only=styles&skin=minerva&target=mobile&* [20:27:47] https://test.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mobile.styles%7Cmobile.styles.page%7Cmobile.xdevice.detect%7Cmobile.zero.styles&only=styles&skin=minerva&target=mobile&* [20:27:51] exception 'MWException' with message 'ResourceLoaderFileModule::readStyleFile: style file not found: "/usr/local/apache/common-local/php-1.22wmf9/extensions/MobileFrontend/stylesheets/devices/"' in /usr/local/apache/common-local/php-1.22wmf9/includes/resourceloader/ResourceLoaderFileModule.php:633 [20:28:17] whoa. ghost toast in firefox [20:28:36] ha ghost toast? [20:28:40] faded out? [20:28:48] toast mesage with no text [20:28:52] spooky [20:28:54] :) [20:28:59] *message [20:29:10] ha [20:29:13] MaxSem: btw, I noticed that on https://test.wikipedia.org/wiki/Main_Page?useformat=mobile there is a rather concerning request that I urge you to look into [20:29:19] https://geoiplookup.wikimedia.org/?_=1373400794154 [20:29:25] https://bits.wikimedia.org/geoiplookup [20:29:39] 1) There is 2 of them (why?), 2) It has cache busting parameters (why?) [20:29:54] humm, humm [20:30:09] Not sure if it's caused by mobile, but I only see it happening on mobile [20:30:22] Krinkle, asking mwalker in #-dev [20:30:37] k [20:30:48] am i getting ghost toast b/c the messages haven't updated yet? [20:30:53] ^ jdlrobson [20:31:29] Maryana: correct [20:31:44] k, cool [20:32:29] Krinkle: i'm only seeing one geoiplookup script... [20:32:40] New patchset: MaxSem; "Quick hack to remove now useless device modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72773 [20:32:56] jdlrobson, ^^^ [20:33:07] found the real failing piece of code [20:33:16] Caused by https://test.wikipedia.org/w/load.php?debug=true&lang=en&modules=ext.centralNotice.bannerController.mobile%2Cmobiledevice%7Cjquery.client%2Ccookie%2CmwExtension%7Cmediawiki.notify%2Cutil%7Cmediawiki.page.startup&skin=vector&only=scripts [20:33:52] // If the user has no counry assigned, we try a new lookup via [20:33:52] // geoiplookup.wikimedia.org. This hostname has no IPv6 address, [20:33:53] // so will force dual-stack users to fall back to IPv4. [20:33:54] if ( mw.centralNotice.data.country === 'XX' ) { [20:33:56] $( 'body' ).append( '' ); [20:34:00] Aha, interesting [20:34:56] mm.. so yeh that's in the central notice extension.. [20:35:18] Maryana: outside of the javascript thing [20:35:19] MaxSem: i -1ed it [20:35:21] everything looks good to me [20:35:29] you? [20:35:38] Why is this doing html parsing and dom manipulation? Wouldn't it be way easier to just $.getScript( url ) [20:35:53] yep, all's well with the user-facing features, jcmish [20:35:58] Krinkle: i'm not sure - you'd have to ask mwalker [20:36:02] cool [20:36:04] i do not know this code.. [20:36:20] i imagine it's legacy reasons [20:36:57] New patchset: MaxSem; "Quick hack to remove now useless device modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72773 [20:39:14] New patchset: Jdlrobson; "Quick hack to remove now useless device modules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72773 [20:39:25] New review: Jdlrobson; "Still think we should have done the 'scary' merge rather than a quick hack but never mind.." [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/72773 [20:40:36] jdlrobson, the scary one is scary - for example in one of the previos patchsets it would have resulted in mobile view on main site for mobile users [20:40:40] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72773 [20:41:02] needs a paranoid review, preferrably by awjr [20:45:59] jcmish & Maryana, are we set to scap? [20:46:08] yup MaxSem [20:46:16] let's do it [21:03:37] heads up, I can't start scapping due to gerrit slowness [21:10:27] grr [21:12:10] scapping [21:12:14] New review: Jdlrobson; "merge when safe" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/72753 [21:17:59] kaldari: the sca(p)t dance - http://www.youtube.com/watch?v=3cnQCk0u49w [21:18:53] I was thinking of making Scap, the movie [21:18:56] it would be epic [21:19:35] would it just be 45 min of us sitting quietly? [21:20:19] kaldari, a bit on how we deploy: MF gets deployed from the branch called production, to prevent platform from updating it [21:20:22] It would be set in 2012, so actually 1:15 of sitting quietly [21:20:49] I usually save production to production.bak, then recreate production from master [21:21:10] MaxSem: OK, that's similar to how fundraising does it as well [21:21:33] a bit of a pain, but gives you more control over what gets deployed when [21:21:36] before pushing the change beyond testwiki, we need a veto from the tester and PM [21:22:15] who gets to be the tester? Whoever wrote the code? [21:22:22] or Michelle? or both? [21:22:24] Michelle [21:22:34] ok [21:22:40] but everyone tests:) [21:23:58] So after I get my code merged into master, is there any special process for getting it into production, or do I just assume it will get picked up by production unless I say otherwise? [21:24:32] I mean assuming I'm not the person actually cutting the production branch [21:25:21] production is always created from master [21:25:28] New review: Jdlrobson; "fire at will" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/72767 [21:25:54] unless there are emergency fixes outside of our window which are cherry-picked [21:26:08] ok [21:42:10] all right jcmish, jdlrobson, jgonera, kaldari, Maryana - we're live:) [21:42:25] yay! [21:42:30] thanks MaxSem gonna start looking now [21:42:32] what did we deploy? [21:42:48] MF [21:43:21] brion: jdlrobson: how do your schedules look for the 18th/19th of this month? howie is trying to put together a offsite product retreat before wikimania. we'd need both days all day [21:43:24] kaldari, if you look at the previous iteration story wall in mingle, you'll see most of the stories & bugs we deployed [21:43:42] * brion checks gcal [21:44:05] tfinc: should work for me [21:45:50] thanks [21:45:57] automation tests passed on the poking around and kaldari we keep a page on deployments up to date http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2013-07-09 [21:46:35] tfinc: works for me - the week after is my last week before travels [21:46:36] ok [21:48:08] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72753 [21:49:28] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72639 [21:50:15] jgonera: https://gerrit.wikimedia.org/r/#/c/72560/ [21:50:18] woohoo jdlrobson and Maryana we have messages showing now :D [21:50:28] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72767 [21:50:29] ack, i see mix of old & new icons... [21:50:34] for locked edit and uplod [21:50:44] oh where? Maryana [21:51:05] main page… they just showed up [21:51:25]