[00:11:36] New patchset: Jdlrobson; "Fix QUnit tests in Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72873 [00:12:19] New patchset: JGonera; "Remove redundant CSS rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72874 [00:16:25] New patchset: JGonera; "Remove CSS rules for #mw-mf-header" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72875 [00:21:43] [Commons-iOS] montehurd opened pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [00:30:14] New review: Krinkle; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72873 [00:41:31] Question: What browsers are we actually required to support on MobileFrontend? [00:42:23] tfinc, MaxSem, jgonera: ^ [00:43:16] we usually test on Safari, Android Browser and newest Chrome, but we generally aim to provide at least minimal functionality on _any_ browser [00:43:55] For example, background-size isn't supported in IE8, but do we care about IE8 for mobile? [00:50:04] kaldari, not really, we care for old mobile browsers, not the desktop ones. on desktop it's good enough if everything works in the newest ones [00:50:24] makes sense [01:02:57] jorm: you still here? [01:03:06] yes. [01:03:07] 'sup? [01:03:18] any interest in doing trivia on the East side tonite? [01:03:29] 7:30 at Pacific Coast Brewery [01:04:32] yes, but i cannot. [01:04:50] 'tis stacey's derby practice, and i've got a stack of bugs to fix in flow. [01:04:52] :( [01:04:56] i know. [01:05:07] but i'm interested! hella interested, if this is going to be a thing going forward. [01:05:11] just not enough notice. [01:07:40] New review: Kaldari; "background-size doesn't work in IE8, but apparently that doesn't matter for mobile." [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/72862 [01:08:04] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72862 [06:06:07] New patchset: Mgrover; "QA Automation test make sure that Menus open to the correct bug Mingle Ticket#996 bug found reference #994" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72895 [08:01:06] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [08:27:25] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [17:16:12] "Card 666 does not exist." [17:16:28] brion: are you on the hangout? [17:16:32] i hear but not see a tfinc [17:16:37] crap got stuck on bugzilla [17:16:38] moment [17:26:18] brion: i added you as reviewer on one, have a look at it? [17:26:22] (patch on gerrit, smallish) [17:29:45] sec [17:30:19] YuviPanda: is it this one or another one? https://gerrit.wikimedia.org/r/#/c/72869/ [17:30:33] brion: that's the one [17:30:43] looking [17:30:59] hmm [17:31:15] on its face, that drops localization capability [17:31:39] though,,, removing 'lagelPage' perhaps isn't a problem, if 'labelPage' is what gets actually used :) [17:33:32] brion: how does it *drop* localization capability? [17:33:35] brion: {{int:}} :D [17:33:43] "Overrides label when set. $1 is replaced by the language code. " [17:33:47] brion: which does sane language fallback [17:33:48] ugh [17:33:51] ah [17:33:58] brion: the fallback for $1 is 'if not found assume lang is en' [17:34:01] hah [17:34:03] (the current code, that is) [17:34:05] so, ugh. [17:34:22] brion: so this patch makes it *more* localizable :) [17:34:27] re: the

thing isn't there a 'parseInline' function that strips the

? [17:34:28] or more i18nable, unsure about the terminology... [17:34:35] brion: ooh? looking [17:37:06] YuviPanda: also, why leave headerLabelPage and thanksLabelPage as-is? harder to change, or reason not to? [17:38:10] brion: you can't automatically transition them [17:38:24] brion: they have to be manually done, since {{int}} works differently than $1 based naive i18n [17:38:40] YuviPanda: so you're only changing the one that's not currently used? :) [17:38:42] brion: but if you look at the bugs the people who use campaigns now are happy to do that, and I can hlep. [17:38:49] brion: oh wait [17:38:58] brion: headerLabelPage and thanksLAbelPage were also replaced [17:38:59] i think [17:39:03] maybe I didn't push that? [17:39:04] checking [17:39:23] not unless there's some real fancy code [17:39:33] brion: yeah, I missed a push. grr [17:39:34] pushing now [17:41:27] brion: see now [17:41:29] new patchset [17:41:35] looking [17:41:45] brion: and of course, there's the github PR which has the commits separately and easier to look at :) [17:43:01] looking [17:49:50] YuviPanda: made some comments [17:50:09] brion: looking [17:54:03] brion: parseInline does exist, yes :) [17:54:10] \o/ [17:54:41] brion: new patchset coming up in a moment [17:55:16] oh, windows rt 8.1 update… i can try out the new snapping feature on an actual touchscreen on my surface rt ;) [17:56:41] interestingly the installer triggers a warning dialog :D [17:57:56] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [17:58:52] brion: fixed, testing now [17:58:54] * brion checks the time…. ok i'll be in the office after lunch i guess :D [18:01:32] $ git checkout monte/detailsDetails \o/ [18:01:49] (yo dawg, etc) [18:03:38] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [18:05:13] brion: new patchset! :) [18:05:17] whee [18:06:00] brion: there's some testing on the side, but I think I should start writing up more detail on how the campaigns work should proceed. [18:10:07] Mozilla/5.0 (Linux; U; Android 4.1.2; ru-ru; GT-I9100 Build/JZO54K) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30 [18:10:23] grr [18:10:51] text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 [18:12:40] jdlrobson, brion, does monday and tuesday after next work for you guys for the product retreat? [18:12:47] the 22nd and 23rd? [18:12:56] Maryana: yep [18:12:57] we'd have to reschedule mobile deployment that week [18:13:11] k, i think howie is itching to pull the trigger on a venue [18:13:29] (i'm just glad it's no longer scheduled for my birthday :D) [18:14:33] :D [18:14:49] YuviPanda: ok lemme test the updated migration; the rest looks ok [18:15:02] brion: no migrations update. Check my reply there [18:15:21] YuviPanda: since the schema's changed, i want to make sure it doesn't explode... [18:15:29] brion: ah, okay [18:15:32] shouldn't... [18:17:57] ok, so extra fields are ignored [18:18:11] i have to set a defined field out-of-type to cause an error editing [18:18:14] hmm, should work :) [18:18:38] brion: yeah, extra ones are [18:19:58] i wonder if it's worth having a way to mark deprecated fields.... [18:20:21] brion: we could leave comments in there, maybe. [18:20:38] meh,it's a one-time thing [18:20:39] brion: things we should consider when JsonContent.php goes into core, of course [18:20:40] :) [18:20:41] they'll get fixed :) [18:20:43] yeah [18:20:53] ok seems to work, i'll sign off on that [18:21:04] i'll +1 it and leave the +2 for marktraceur [18:21:15] brion: ok :) [18:22:26] Agh [18:22:43] ok while i'm between code reviews i'm gonna pack up here. see y'all in a bit [18:23:43] marktraceur: you could let him +2 too if you want :) [18:23:46] spread the load around, etc? [18:23:53] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [18:24:51] I see no reason why not [18:25:03] But if he's not comfortable then sure, I'll look at it [18:25:26] I'm totally supposed to be finishing up the half-working FR vagrant work for K4 [18:28:15] marktraceur: no no, I am totally comfortable [18:28:33] No, not you, brion [18:28:36] marktraceur: and he would be too, but I think he was deferring because I asked him to not merge the 'big' patch until you took a look at it [18:28:47] should be easy enough to find out when he comes back [18:28:56] I feel a tinge of guilt pulling you away from your duties [18:28:59] Mm. [18:29:33] chrismcmahon: No such file or directory - /private/wmf/secret.yml (Errno::ENOENT) when I try to run the acceptance tests :( [18:30:03] text/html, application/ [18:30:57] " text/html, application/ [18:31:12] blergh [18:35:57] jdlrobson: check the README: https://github.com/wikimedia/qa-browsertests for 'secret.yml' [18:36:30] chrismcmahon: i was just pointing out it seems unnecessary / confusing. I'm writing an email about my experiences as so far it's been a pain to get them running :(. [18:36:31] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [18:36:36] jdlrobson: more detailed instructions https://www.mediawiki.org/wiki/Meetings/2013-06-27 [18:36:46] jdlrobson: thanks, will read [18:37:02] chrismcmahon: haven't sent yet but will make sure i include you :) [18:38:44] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [18:49:53] jdlrobson: we had pretty good success with the instructions on that mw.o page ^^ [18:51:24] chrismcmahonbrb: jdlrobson I've also found it very easy to run them inside vagrant with ori-l's work [18:51:28] (browsertests) [18:58:41] hmm, was lunch hangout cancelled? [19:04:59] New patchset: Jdlrobson; "Regression: Deal with cleanup template inconsistencies" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73009 [19:05:15] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [19:05:54] cd [19:06:00] hehe wrong window [19:08:43] MaxSem, any updates on the hook ideas? [19:09:26] yurik, the refactoring seems to be gaining speed again, once it's merged, your hook will be next [19:19:30] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [19:20:25] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [19:29:14] can't get on irc from regular client wtf [19:29:17] i'm on the web gateway [19:29:20] and services are still broken [19:40:21] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [19:41:09] brion: hey, marktraceur said he was okay with you +2ing this. spreading the load of review, etc [19:41:15] ok [19:45:45] hey Maryana [19:45:59] heya [19:46:21] howdy I completely spaced about our prioritization meeting :D I miss arthur! :D so I'm looking at the story wall [19:46:36] for Iteration Planning ... the next iteration is Beaver? [19:48:40] brion: another small commit (last from UW for a while, I promise!) https://gerrit.wikimedia.org/r/#/c/73016/ [19:48:44] yes indeed, jcmish [19:49:00] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [19:49:14] brion: just removing some dead code [19:49:22] alrighty I have no idea how to get it to show up on the iteration planning list :D [19:49:26] have you done that before? [19:50:02] hrrm.. i think there's a way to add it to the team view [19:51:18] jcmish, ok, there i think i did it [19:51:22] check the iteration planning tab [19:51:26] oh sweet [19:51:42] \o/ [19:51:42] does beaver show up to the right? [19:51:42] yup [19:51:42] sweet [19:51:47] how did you do it? [19:52:41] the little arrows next to the tabs that look like refresh [19:52:52] they actually add whatever columns you have in your view to the team view [19:52:57] oh cool [19:53:07] i thought they just refreshed haha [19:53:16] yeah, i had to hover over to figure it out [19:53:25] mingle… *shakes fist* [19:53:34] ha well done [19:55:37] New patchset: MaxSem; "Simplify WAPness detection" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73018 [20:01:32] Guest94406: thanks :) [20:04:42] real irc client! yayyy [20:05:02] brion: :D thanks for merging [20:07:14] kaldari: http://mobile-reportcard.wmflabs.org/ [20:27:30] brion: https://gerrit.wikimedia.org/r/#/c/73021/ [20:27:33] brion: thoughts? [20:29:09] YuviPanda: what's the 'FIXME: Use another 'algorithm' that doesn't punish low res devices ' ? [20:29:24] brion: so right now factor is going to be '1' for mdpi devices [20:29:30] brion: .... and 0.75 for ldpi ones :D [20:29:38] brion: so there won't be any downscaling there [20:29:55] ah i see [20:30:07] brion: i'm thinking of other ways to do that. Just divide by two? take the square root? [20:30:11] YuviPanda: well you could just check if density is > 160 and only do the scale-back there [20:30:25] brion: sure, but that still has the problem that we aren't downscaling at all for ldpi devices [20:30:32] that'll mean they're sharper, yeah, but not faster... [20:30:42] er [20:30:51] wouldn't that exactly downscale them ? [20:31:28] brion: hmm? [20:31:34] brion: how so? we';ll just be dividing by 1... [20:32:07] we'd be dividing by 0.75 wouldn't we? [20:32:47] brion: yeah, dividing by 0.75 increases width, and dividing by 1 leaves it the same [20:32:54] while ideally we'd want it to reduce at all times [20:33:06] er [20:33:11] * brion tries to remember math, it's hard [20:33:25] anything divided by something lesser than 1 increases it! [20:33:25] ok so width/height are in device pixels at the start, right? [20:33:26] :D [20:33:34] brion: ah, no. they're in 'real' pixels [20:33:42] um [20:33:54] i would consider device pixels to be real pixels [20:34:00] device-independent pixels are not real pixels :) [20:34:09] gaah, you're right [20:34:10] true true [20:34:26] tripped by dp being abbreviation for device independent pixel [20:35:44] yea :D [20:35:48] that drives me nuts [20:35:50] it should be dip [20:36:39] agh they accept 'dip' also but recommend 'dp' for consistency with the dreaded 'sp' [20:36:44] which really should be 'sip' :P [20:36:45] brion: so dip is also accepted [20:36:48] yeah [20:36:49] * brion stabs android [20:37:02] brion: anyway, back to math... :D [20:37:27] :D [20:37:27] brion: divide by max(2, densityFactor)? [20:37:37] so we'll divide *at least* by 2 in all cases [20:37:51] and more if necessary (xxhdip and stuff) [20:38:24] so if i understand here's what we want [20:38:50] mdpi, hdpi, xhdpi: end up fetching the dp size [20:39:01] ldpi: fetch the raw pixel size [20:39:06] or? [20:39:54] brion: or, 'give me a smaller image, by a factor of *something*', for everything [20:40:33] well, smaller image on ldpi/mdpi is gonna be blurry as hell [20:40:40] aaah [20:40:41] true [20:40:55] and they're going to be already small, since ldpi devices are... small [20:41:08] brion: your algorithm should give us ideal results, I think. let me add an if for the <1 case. [20:41:21] \o/ [20:41:44] ugh google is now reminding me of peoples' birthdays on my search pages [20:42:10] in a notification that covers up settings buttons. nice. at least it's dismissable [20:42:11] brion: I've 'worked' around a few problems by using two browsers. Chrome for GMail / GCal and Firefox for searching/everything-else [20:44:30] brion: pushed [20:44:52] looking [20:46:00] looks feasible, lemme test [20:46:57] brion: woo [20:47:06] brion: thumbnails are a fair bit faster to me now [20:52:37] New patchset: Jdlrobson; "Makefile: Add make qa command" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73028 [20:52:37] New patchset: Jdlrobson; "QA: Correct the acceptance tests for main page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73029 [20:52:37] New patchset: Jdlrobson; "QA: Update README" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73030 [21:03:26] New patchset: Jdlrobson; "Fix QUnit tests in Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72873 [21:04:22] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72875 [21:08:42] i wish the density keywords sorted alphabetically [21:10:22] New patchset: MaxSem; "Create a thin base class for all our skins" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69336 [21:10:51] [Commons-iOS] montehurd synchronize pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [21:11:15] brion: just pushed update [21:11:41] New patchset: MaxSem; "Create a thin base class for all our skins" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69336 [21:24:17] gerrit-wm: mergable? [21:37:07] why was I talking to gerrit-wm [21:37:08] grr [21:48:41] silly YuviPanda thinking bots are real people [21:48:59] :D [21:50:00] brion: was it faster? at all? [21:50:12] ragesoss: around? [21:52:08] ragesoss: email'd [21:59:46] brion: https://gerrit.wikimedia.org/r/#/c/73097/ [21:59:48] 1 liner [21:59:53] i'm going to self merge [21:59:54] just a fyi [22:13:33] kaldari: your keyboard is hilarious :) [22:16:18] no it's not! it's.... formidable! [22:16:26] :) [22:17:51] kaldari: indeed it is something of the sort [22:18:30] if a crazed Wikimedians ever busts in the office, I can just throw my keyboard at them [22:20:23] kaldari: pic? [22:20:43] kaldari: also don't leave it around where rmoen can trip on them in the dark :) [22:20:49] rmoen: also, you're coming to Wikimania, right? [22:21:08] ^^ ;) [22:21:14] http://www.dansdata.com/images/clicky/ballboard1024.jpg [22:22:16] YuviPanda: indeed I am coming. [22:22:30] rmoen: maybe I sohuld bring some old monk :P [22:22:31] kaldari: there is a joke about me tripping on things ;) [22:22:47] YuviPanda: Maybe? [22:22:55] mmkay [22:26:51] New review: Jdlrobson; "Works on Kindle" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72631 [22:31:06] New patchset: Jdlrobson; "QA: New Automation test Menu urls for bug 51078" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72895 [22:33:26] New patchset: Jdlrobson; "QA: Correct the acceptance tests for main page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73029 [22:34:14] brion: anything other than volley cache you want me to look at before I start working on Campaigns? [22:35:14] YuviPanda: that's all at the moment [22:35:26] i'll have another update for you on the detail page in a bit, but not immeditely [22:37:46] brion: swet [22:40:50] hah my blackberry 10 dev alpha device has expired itself, it no longer runs [22:41:00] and we don't care enough to by a Z10 or Q10 [22:41:08] sorry blackberry [22:43:23] New patchset: Jdlrobson; "Bug 51078: Correct anonymous watchlist url" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73115 [22:43:37] New review: Jdlrobson; "https://gerrit.wikimedia.org/r/73115 makes this test pass but guess we should merge that first :)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/72895 [22:45:37] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72631 [22:48:18] brion: scroll question when u have a sec [22:50:12] brion: :D so now you have another expensive brick... [22:50:56] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73115 [22:51:08] YuviPanda: that one was free at least :D [22:51:13] true true :D [22:51:25] brion: I'm yet to meet anyone with a newer blackberry device that they did not get free at a dev event [22:52:17] i've seen one Z10 in the wild. [22:52:17] one. [22:54:43] brion: endangered species [22:54:53] brion: hmm, are you sure it wasn't given away for free? [22:54:55] New patchset: Jdlrobson; "Story 839: Add preview header (follow-up)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72764 [22:54:55] New patchset: Jdlrobson; "Remove redundant CSS rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72874 [22:55:01] might been [22:55:03] mhurd: moment [22:55:07] i'm fighting windows [22:55:10] it's a silly place [22:55:20] brion: no worries [22:56:44] New patchset: Jdlrobson; "Remove redundant CSS rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72874 [22:58:05] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72764 [23:01:01] where did jcmish go? [23:01:33] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72895 [23:08:35] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/72649 [23:09:06] New patchset: Jdlrobson; "Make photo upload overlay look consistent with the editor" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72649 [23:09:20] New review: Jdlrobson; "Made minor adjustment see comment on last patch set." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/72649 [23:14:05] New patchset: JGonera; "Makefile: Add make qa command" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73028 [23:15:42] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72649 [23:16:45] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72874 [23:22:50] New review: Jdlrobson; "Still finding the layout confusing - here are my areas of confusion and suggestions to resolving!" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69336 [23:24:51] New patchset: Jdlrobson; "Prevent cutting off license image" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72668 [23:25:47] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72668 [23:26:03] New patchset: Jdlrobson; "Makefile: Add make cucumber command" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73028 [23:26:47] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73028 [23:30:46] New patchset: Jdlrobson; "Bug 50699: Remove the logged in toast notification" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73123 [23:34:54] New patchset: Jdlrobson; "Bug 50701: Add cursor pointer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73124 [23:40:39] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/72895 [23:42:02] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73124 [23:42:31] New review: JGonera; "I think we should also remove the PHP code that generates welcome=yes in the URL." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/73123 [23:45:06] New patchset: JGonera; "Regression: Deal with cleanup template inconsistencies" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73009 [23:46:05] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73009 [23:46:22] brion: also, do we have the original vector/psd sources for the assets in the 'welcome' screen stuff? [23:46:54] YuviPanda: well it's sorta a mix of bitmaps and vector drawings in code i think :D we'll figure out the best way to deal with em [23:47:11] i just screenshotted from the iOS simulator ;))) [23:47:11] brion: oeak [23:47:12] ok [23:47:19] gotta run, more stuff to do for house planning [23:47:25] get to see it tomorrow wheeeee [23:47:31] brion: cya [23:49:03] New patchset: Jdlrobson; "Bug 50136: Allow editing of things other than wikitext" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73127 [23:49:21] New review: Jdlrobson; "Need to rewrite the tests / add new ones" [mediawiki/extensions/MobileFrontend] (master) C: -2; - https://gerrit.wikimedia.org/r/73127 [23:49:30] Maryana, are all those editor bugs really lower priority than anything else (mingle)? [23:49:38] no! [23:49:43] prioritizing now [23:50:08] i was also not sure why the limn bug didn't get moved over, so i just went ahead & moved it [23:51:34] k, jgonera, i moved them up [23:52:24] New review: JGonera; "PhotoApi changes not necessary, those tests don't fail on recent Firefox versions." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/72873 [23:52:46] Maryana, thanks [23:53:25] New patchset: Jdlrobson; "Fix QUnit tests in Firefox" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72873 [23:54:23] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72873