[00:00:07] <gerrit-wm>	 New review: Siebrand; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/73556
[11:19:08] <prtksxna>	 YuviPanda: See mail :)
[11:19:13] <YuviPanda>	 looking
[11:20:27] <prtksxna>	 YuviPanda: Should we make a list of backgrounds that we will test it against?
[11:20:44] <YuviPanda>	 prtksxna: pick a random wallpaper and test no?
[11:20:57] <YuviPanda>	 prtksxna: also I'm wondering if we should change the style from Holo Dark to Holo light
[11:21:03] <prtksxna>	 Me too
[11:21:31] <prtksxna>	 YuviPanda: lut4rp and I usually tested the icon on a couple of different colours and wallpapers, never know what people are going to be using…
[11:21:55] <YuviPanda>	 prtksxna: true, true. do you already have such a list that we can reuse?
[11:22:02] * prtksxna  looks around

[11:22:03] <prtksxna>	 no :(
[11:39:24] <prtksxna>	 YuviPanda: Emailed you all the sizes :)
[11:49:31] <YuviPanda>	 prtksxna: github.com/wikimedia/apps-android-commons
[13:07:19] <gerrit-wm>	 New patchset: Zfilipin; "Updated Cucumber Ruby gem" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73751
[17:15:17] <YuviPanda>	 mhurd: standup?
[17:17:01] <gerrit-wm>	 New patchset: Jdlrobson; "Story 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555
[17:17:32] <gerrit-wm>	 New review: Jdlrobson; "Will need a cache flush so should not be merged till post deployment 16th July. Please review though..." [mediawiki/extensions/MobileFrontend] (master) C: -2;  - https://gerrit.wikimedia.org/r/73555
[17:21:47] <gerrit-wm>	 New review: Kaldari; "Looks like there's a bug with invalidating the page cache..." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/73555
[17:22:40] <gerrit-wm>	 New patchset: JGonera; "Story 931: Editing guider text" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73556
[17:32:22] <gerrit-wm>	 New patchset: JGonera; "Story 805: Move Left Nav grouping to Stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73129
[17:34:02] <mhurd>	 tfinc: didn't see them upstairs
[17:34:30] <gerrit-wm>	 New review: JGonera; "I'll fix when the arrow shows up. Editor icon not showing up when the section is folded and when the..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73357
[17:36:45] <YuviPanda>	 tfinc: anything from brion?
[17:47:55] <mhurd>	 YuviPanda: hey yuvi, do you know where i could look to see if an upload cancellation was indeed logged?
[17:48:04] <YuviPanda>	 mhurd: do you have stat1 access?
[17:48:16] <mhurd>	 YuviPanda: hmm i don't think so
[17:48:38] <YuviPanda>	 mhurd: so right now I can help do that, but you should file an RT ticket
[17:48:40] <YuviPanda>	 for access
[17:49:05] <YuviPanda>	 Maryana: is there something written up somewhere about how to get stat1 access that I can point mhurd to?
[17:49:20] <Maryana>	 i believe somewhere on office wiki… 1 sec
[17:50:11] <Maryana>	 https://office.wikimedia.org/wiki/Editor_Engagement_Experiments/Data_analysis#Connect_to_stat1
[17:50:37] <mhurd>	 Maryana: YuviPanda: thanks!
[17:50:53] <YuviPanda>	 mhurd: let me know if you want me to look at things while you test things
[17:51:31] <Maryana>	 it looks like the research credentials pw isn't on there - you'll have to get that from dario.. somehow
[17:52:01] <Maryana>	 he's in italy unfortunately, and he's always really paranoid about sharing it via.. anything. but hopefully he's figured out some kind of secure solution by now
[17:52:53] <mhurd>	 YuviPanda: it looks like code for logging cancellations is in place already - i just cancelled an upload - was going to check if the cancellation was recorded. is that easy for you to do?
[17:53:01] <mhurd>	 Maryana: ah thanks
[17:53:02] <YuviPanda>	 mhurd: indeed. moment
[17:53:52] <mhurd>	 YuviPanda: the file name was "jsjdudjd8373"
[17:54:12] <Maryana>	 mhurd, you can ping him on #wikimedia-e3 - nick DarTar
[17:54:39] <Maryana>	 rope me in and i'll vouch for your credibility ;)
[17:54:48] <YuviPanda>	 mhurd: checking
[17:55:42] <YuviPanda>	 mhurd: yeah, i see it
[17:55:45] <YuviPanda>	 mhurd: cancelled twice
[17:55:46] <YuviPanda>	 mhurd
[17:55:48] <YuviPanda>	 err
[17:55:50] <mhurd>	 YuviPanda: ah! perfect!
[17:55:50] <YuviPanda>	 montehur
[17:55:50] <YuviPanda>	 d
[17:56:00] <YuviPanda>	 mhurd: can you upload it successfuly so I can check that too
[17:56:04] <mhurd>	 YuviPanda: i did indeed cancel it twice
[17:56:08] <mhurd>	 YuviPanda: ya
[17:56:18] <YuviPanda>	 poke me
[17:56:21] <mhurd>	 YuviPanda: uploaded
[17:56:23] <YuviPanda>	 ok
[17:56:35] <YuviPanda>	 mhurd: yup, works :)
[17:56:39] <YuviPanda>	 you can mark that as done
[17:56:40] <mhurd>	 yay!
[17:56:44] <mhurd>	 thanks!!!
[17:56:46] <YuviPanda>	 mhurd: :)
[17:56:49] <YuviPanda>	 i'll exit now?
[17:56:53] <YuviPanda>	 mhurd: you should still get stat1 access ;)
[17:56:53] <mhurd>	 ya
[17:57:04] <mhurd>	 YuviPanda: will do
[17:57:07] <YuviPanda>	 i'm logging off it now
[18:03:50] <tfinc>	 YuviPanda: not yet. i'm going to text him
[18:04:09] <YuviPanda>	 tfinc: ok
[18:05:43] <gerrit-wm>	 New patchset: Kaldari; "Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555
[18:07:56] <mhurd>	 tfinc: books delivered :)
[18:08:02] <tfinc>	 mhurd: thanks
[18:11:42] <gerrit-wm>	 New review: Kaldari; "Don't merge until change Ib1e6b8f4 is merged, per story requirements." [mediawiki/extensions/MobileFrontend] (master) C: -2;  - https://gerrit.wikimedia.org/r/73555
[18:12:07] <vbamba>	 Thanks for the books! mhurd and tfinc
[18:12:32] <tfinc>	 vbamba: of course. we like to give you guys good stuffs. i had hoped to get them to you before the weekend but you guys escaped too quickly
[18:12:50] <tfinc>	 vbamba: did mhurd explain the books to you ?
[18:13:09] <mhurd>	 tfinc: poorly haha
[18:13:23] <gerrit-wm>	 New patchset: Kaldari; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555
[18:15:05] <mhurd>	 YuviPanda: so… license name/link. pointers on where/how to begin?
[18:15:14] <YuviPanda>	 ah
[18:15:17] <YuviPanda>	 mhurd: moment, finding
[18:15:54] <YuviPanda>	 mhurd: https://github.com/brion/apps-android-commons/tree/detail-page is brion's work, but it has a few things mixed in
[18:16:21] <YuviPanda>	 mhurd: https://github.com/wikimedia/mediawiki-extensions-UploadWizard/blob/master/UploadWizard.config.php has the raw license data
[18:16:37] <YuviPanda>	 mhurd: so brion's work also extracts descriptions in all lanuages + the license info
[18:16:58] <YuviPanda>	 mhurd: so if you want to parse just the license info, that might be easier
[18:17:29] <gerrit-wm>	 New patchset: JGonera; "Retain editor position when going back from the preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73792
[18:18:17] <jcmish>	 MaxSem:  I'm trying to upload a photo to beta labs and it keeps saying please wait
[18:18:24] <jcmish>	 can you see if something weird is going on?
[18:18:35] <mhurd>	 YuviPanda: omg
[18:18:39] <MaxSem>	 traditional monday fun:(
[18:18:45] <jcmish>	 YUP
[18:19:18] <YuviPanda>	 mhurd: and wikitext is a pain to parse, but if you look at what brion is doing he's using the API to give him back an XML DOM of the wikitext, so you can parse things out of the XML DOM
[18:19:23] <YuviPanda>	 mhurd: so that is *slightly* easier
[18:19:25] <YuviPanda>	 but not by too much
[18:19:33] <YuviPanda>	 well, actually it is a lot more easier :P
[18:19:43] <MaxSem>	 jcmish, are you on http or https?
[18:19:54] <jcmish>	 http
[18:20:04] <mhurd>	 YuviPanda: sounds like a plan
[18:20:15] <jcmish>	 betalabs doesn't have https I don't believe
[18:20:15] <YuviPanda>	 mhurd: yeah
[18:20:28] <YuviPanda>	 mhurd: and on reading the config file
[18:20:38] <YuviPanda>	 mhurd: for most of the licenses
[18:20:44] <YuviPanda>	 mhurd: you have a template called self
[18:20:48] <YuviPanda>	 and these are params for that
[18:21:02] <YuviPanda>	 mhurd: so when it says 	'templates' => array( 'PD-Art' )
[18:21:10] <YuviPanda>	 it means that the template actually is {{self|PD-Art}}
[18:21:13] <YuviPanda>	 *mostly*
[18:21:17] <YuviPanda>	 it can also be {{PD-Art}}
[18:21:19] <YuviPanda>	 :D
[18:22:03] <mhurd>	 YuviPanda: oh god. haha
[18:23:02] <YuviPanda>	 mhurd: yeah. I suggest staying away from regexes, no matter how tempting :)
[18:23:16] <YuviPanda>	 mhurd: unless you plan on *modifying* the text, at which point you might have to use them
[18:23:32] <kaldari>	 If anyone has the bandwidth, this change needs lots of review and testing: https://gerrit.wikimedia.org/r/#/c/73555/
[18:23:44] <MaxSem>	 hmm, I see &r=0.1999705050542071 on action=upload. not related and not beraking anything, but needs to be fixed
[18:23:51] <MaxSem>	 jdlrobson, jgonera^^
[18:23:59] <mhurd>	 YuviPanda: ya i'll hold off on regex if possible
[18:24:17] <YuviPanda>	 mhurd: yeah, for just reading XML is better off (the pre-processed XML)
[18:24:20] <jdlrobson>	 MaxSem: it's there for a reason - see FIXME
[18:24:25] <MaxSem>	 ah
[18:24:35] <jdlrobson>	 in meeting but will be back in a bit ;-
[18:24:44] <jdlrobson>	 fixme may no longer be relevant
[18:29:12] <tfinc>	 Maryana: is the QA acceptance call happening today ?
[18:29:26] <Maryana>	 nope, no design-related changes to review
[18:29:33] <tfinc>	 k
[18:29:47] <Maryana>	 jcmish, you think we'll have stuff to look at tomorrow?
[18:30:04] <jcmish>	 MaxSem:  I did get one photo to load
[18:30:09] <Maryana>	 or does it just depend on the speed with which people code review.. :)
[18:30:11] <jcmish>	 the second just error'd out
[18:30:33] <jcmish>	 Maryana:  it depends on how much of this makes it through final code review
[18:30:40] <jcmish>	 but I say we set up something just in case
[18:30:44] <jcmish>	 same time?
[18:31:17] <MaxSem>	 jcmish, first for me failed, second one got through. funnily, O forgot to watch network activity for the one that failed:]
[18:31:26] <Maryana>	 sure thing
[18:31:34] <jcmish>	 ha :D
[18:38:19] <kaldari>	 jgonera: BTW, according to the user story specs, editing can't be pushed out until the pencil icon stuff is merged, so that should be high priority (unless Maryana wants to change that requirement)
[18:38:46] <kaldari>	 https://mingle.corp.wikimedia.org/projects/mobile/cards/980 + https://gerrit.wikimedia.org/r/#/c/73357/
[18:38:55] <Maryana>	 yeah, it doesn't really make sense to deploy editing with no user-facing way to edit
[18:39:10] <Maryana>	 those should go out as a package deal
[18:39:39] <kaldari>	 card 980 seems to be about the pencil icon for section editing specifically
[18:39:40] <Maryana>	 kaldari, your keyboard is ridiculously loud
[18:39:55] * Maryana  looks

[18:40:05] <Maryana>	 ah, yes. for section editing
[18:40:23] <kaldari>	 should having the pencil icon for section editing be a requirement for editing to go stable?
[18:40:53] <Maryana>	 yes, unless it's a huge blocker
[18:41:02] <YuviPanda>	 mmm, mechanical keyboards :D
[18:41:07] <kaldari>	 probably not a huge blocker
[18:41:24] <kaldari>	 but jgonera would know better
[18:48:36] <gerrit-wm>	 New review: Jdlrobson; "Breaks lazy loading pages on alpha" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/73525
[18:51:10] <gerrit-wm>	 New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/70953
[18:51:39] <jdlrobson>	 pencil icon should go live tomorrow
[18:52:07] <Maryana>	 in beta, right?
[18:53:21] <gerrit-wm>	 New review: Jdlrobson; "Looks good.. anyway we can retain the caret position of the editor as well?" [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/73792
[18:53:50] <jdlrobson>	 Maryana: yup
[18:54:30] <Maryana>	 ok, i think that's what kaldari was confused about
[18:54:31] <MaxSem>	 jcmish, reproduced: it's hanging in /w/api.php?format=json&action=tokens&type=centralauth
[18:54:33] <MaxSem>	 eek
[18:54:45] <MaxSem>	 aha 503 Service Unavailable
[18:54:59] <gerrit-wm>	 New review: Jdlrobson; "Can we at least have a fade in animation? I find it really jarring and unexpected..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73357
[18:54:59] <Maryana>	 we're gonna deploy the pencil edit icon to beta tomorrow, kaldari, and then deploy all the editing changes to stable next deployment window
[18:54:59] <MaxSem>	 poop
[18:55:45] <jdlrobson>	 Maryana: the edit icon appearing on a toggle is SOOO jarring
[18:55:55] <Maryana>	 can i see?
[18:56:04] <jdlrobson>	 yeh when i come out of this meeting
[18:56:06] <kaldari>	 Maryana: and I assume "all the editing changes" includes the icon for section editing, correct?
[18:56:29] <Maryana>	 yep
[18:56:38] <jcmish>	 yup that's it MaxSem and bummer :(
[18:56:50] <Maryana>	 jdlrobson, ok, thanks - now get back to opsen land!
[18:57:05] <jdlrobson>	 Maryana: pm
[18:57:31] <Maryana>	 ah, thx - looking
[18:57:32] <gerrit-wm>	 New patchset: JGonera; "Cleanup .loading (spinner) CSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73525
[18:58:21] <gerrit-wm>	 New review: JGonera; "Can you elaborate? Seems to be working perfectly fine for me." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73525
[18:58:23] <jdlrobson>	 Maryana: also wikivoyage is being weird on mobile editing https://bugzilla.wikimedia.org/show_bug.cgi?id=51385
[18:58:43] <jdlrobson>	 jgonera: in alpha lazy load a page - it shows a blank screen despite using the loading class
[18:59:14] <jgonera>	 oh, so you mean you can't see the spinner? it loads so fast that I didn't get the chance to notice...
[18:59:27] <jgonera>	 right
[18:59:57] <jdlrobson>	 jgonera: correct
[19:01:14] <Maryana>	 can i log into JDLR wiki?
[19:01:18] <Maryana>	 jdlrobson ^
[19:02:58] <MaxSem>	 jcmish, confirmed - beta being beta
[19:04:53] <jcmish>	 :(
[19:05:01] <jcmish>	 oh beta
[19:05:06] <jcmish>	 how you vex me so!
[19:06:56] <gerrit-wm>	 New patchset: JGonera; "Cleanup .loading (spinner) CSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73525
[19:17:23] <YuviPanda>	 hey brion
[19:17:25] <YuviPanda>	 :D
[19:17:33] <brion>	 heyyy
[19:17:37] <YuviPanda>	 still groggy/
[19:17:38] <YuviPanda>	 ?
[19:17:54] <brion>	 yep, catching up on mail etc
[19:18:21] <brion>	 poked around a little more at the new house over the weekend, whee
[19:18:25] <brion>	 still needs lots of work :D
[19:18:29] <YuviPanda>	 brion: nice!
[19:19:03] <brion>	 i'll have room for a home office again
[19:19:21] <YuviPanda>	 brion: kicked out RobH?
[19:19:24] <mhurd>	 hey brion!
[19:19:35] <brion>	 haha no will just stash him downstairs in the new place :)
[19:19:45] <brion>	 mhurd: heyyyy
[19:20:04] <brion>	 sorry I'm way behind on reviewing the updates. any new stuff come in while I was offline? :D
[19:20:35] <YuviPanda>	 brion: also, can you look at https://gerrit.wikimedia.org/r/#/c/71997/ whne you have time? It's not directly related, but I think it can have some rather useful applicatons in the future
[19:20:59] <brion>	 randomincategory? ooh people will love that
[19:21:02] <brion>	 i'll peek at it later
[19:21:10] <YuviPanda>	 brion: i'lla dd you as reviewer
[19:21:16] <mhurd>	 brion: no worry! i had a few more commits to details branch late last week. should be ready for another review pass
[19:21:23] <brion>	 sweet
[19:21:59] <YuviPanda>	 brion: added. There's also a pull request for icons on commons app, but no rush on that one.
[19:25:46] <mhurd>	 brion: been playing with the license / link extraction. question: noticed that license is hidden category on images i upload via the app - is the license always added as a category? can i just grab from category?
[19:26:39] <brion>	 mhurd: the license templates bring in the hidden categories. in theory you could probably detect the licenses from the full category list yes
[19:26:53] <brion>	 i'm not sure whether that's better or worse than searching for the templates
[19:27:00] <brion>	 someday soon we need to push to reform all the data :)
[19:27:06] <brion>	 but for now we get to work with what we got
[19:31:46] <mhurd>	 brion: thx!
[19:48:02] <mhurd>	 brion: if i do a simple string match on category for existing license names it would be super easy as i could just keep a dict of known licenses and their urls - but wouldn't work for 'custom' licenses because i believe users can enter url for those. would that be a non-starter?
[19:48:29] <brion>	 mhurd: if we can just collect the standard ones that'll probably be fine for now
[19:48:57] <mhurd>	 brion: coolness
[20:27:49] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73525
[20:30:35] <gerrit-wm>	 New review: Jdlrobson; "( $('textarea').get(0).setSelectionRange(200,200) } )" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73792
[20:38:24] <gerrit-wm>	 New review: Jdlrobson; "Appears to be inconsistent with this asset https://mingle.corp.wikimedia.org/attachments/809bf66916d..." [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/73556
[20:58:57] <tfinc>	 jgonera: make sure to put in your thoughts on the quiet space thread
[21:11:25] <gerrit-wm>	 New review: Siebrand; "Reviewed i18n/L10n" [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/73556
[21:15:01] <gerrit-wm>	 New patchset: Jdlrobson; "Bug 51052: Show non-existent pages in watchlist" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73195
[21:17:49] <gerrit-wm>	 New review: Jdlrobson; "Worth exploring retaining caret position in future." [mediawiki/extensions/MobileFrontend] (master) C: 2;  - https://gerrit.wikimedia.org/r/73792
[21:18:14] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73792
[21:19:45] <jdlrobson>	 yurik: https://gerrit.wikimedia.org/r/#/c/73336/
[21:19:49] <jdlrobson>	 ^ can that be merged?
[21:19:58] <yurik>	 looking
[21:23:07] <yurik>	 jdlrobson, merged
[21:23:28] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73336
[21:37:12] <gerrit-wm>	 New patchset: JGonera; "Story 931: Editing guider text" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73556
[21:38:18] <tfinc>	 heads up https://github.com/blog/1559-github-s-on-your-phone
[21:38:52] <MaxSem>	 humm
[21:38:56] <MaxSem>	 awesome
[21:42:37] <jdlrobson>	 Maryana: looks like our meme got political.. https://www.facebook.com/photo.php?fbid=10152069364808662&l=49dc376b90
[21:42:48] <Maryana>	 woah
[21:44:04] <jdlrobson>	 http://api-status.com/ < MaxSem seen this?
[21:47:19] <MaxSem>	 :)
[22:00:21] <kaldari>	 Hey guys, I have to fix a major bug someone introduced to WikiLove and deploy it before it gets out to en.wiki (it's already live on Commons and test). So I'll be busy with that for the next half hour or so :(
[22:04:58] <YuviPanda>	 marktraceur:  brion https://commons.wikimedia.org/wiki/Commons:Village_pump#Update_to_UploadCampaigns mentioned you guys. Thanks for the help! :)
[22:06:05] <marktraceur>	 Huzzah, YuviPanda!
[22:06:10] <YuviPanda>	 indeed.
[22:06:26] <YuviPanda>	 I expect absolutely nobody to respond there, and perhaps 3 people to respond to my thread on wikilovesmonuments-l
[22:11:54] <YuviPanda>	 ragesoss: https://commons.wikimedia.org/wiki/Commons:Village_pump#Update_to_UploadCampaigns
[22:13:55] <gerrit-wm>	 New patchset: Jdlrobson; "Avoid adding duplicate styles on watchlist and nearby" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73879
[22:15:24] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73556
[22:22:37] <gerrit-wm>	 New patchset: Jdlrobson; "Story 805: Move Left Nav grouping to Stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73129
[22:22:40] <gerrit-wm>	 New patchset: Jdlrobson; "Stop double escaping wiki name" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73882
[22:23:06] <gerrit-wm>	 New review: Jdlrobson; "Looks good to me (separated out Juliusz's code)" [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/73882
[22:29:27] <gerrit-wm>	 New patchset: Cmcmahon; "QA: Correct the acceptance tests for main page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73029
[22:29:42] <YuviPanda>	 brion: I'm off to sleep now, want me to do anything before I go?
[22:29:56] <brion>	 YuviPanda: email me the link of the thing you wanted me to review
[22:30:04] <brion>	 and i'll poke it in a bit :D
[22:30:06] <YuviPanda>	 brion: i added you as reviewer, but email too
[22:30:32] <brion>	 juts in case i can't find it in gerrit :D
[22:30:37] <YuviPanda>	 brion: yeah, emailed
[22:34:09] <jdlrobson>	 kaldari brion any desire to sink teeth into Max's code? https://gerrit.wikimedia.org/r/#/c/73018/
[22:35:40] <brion>	 hmm i remember some versions of opera claiming wml support or something
[22:36:03] <brion>	 i'll assume those are old shitty versions of opera ;)
[22:37:18] <brion>	 i don't see any current references so… probably ok
[22:40:22] <MaxSem>	 if Opera 4 reports WAP suport AND no HTML support... it has the right to get what it'll get
[22:40:57] <brion>	 yeah :D
[22:42:56] <brion>	 ugh remind me how to run a specific extension unit test file again?
[22:43:19] <brion>	 there we go, found it
[22:43:48] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73882
[22:49:14] <gerrit-wm>	 New patchset: Brion VIBBER; "Simplify WAPness detection" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73018
[22:49:52] <gerrit-wm>	 New review: Brion VIBBER; "I added a couple test cases for handling the accept header; they seem to fail. I'm not sure if I did..." [mediawiki/extensions/MobileFrontend] (master); V: -1 C: -1;  - https://gerrit.wikimedia.org/r/73018
[22:50:37] <brion>	 MaxSem: ^ not sure if i did the test cases wrong or if there's a problem with the accept processing logic, can you double-check?
[22:53:17] <MaxSem>	 brion, the logic is different - if a browser reports that it accepts HTML, it will get HTML. I thought before about precendence, but this behaviour is consistent with what we had before
[22:53:37] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73195
[22:53:57] <kaldari>	 jdlrobson: watchlist fix is merged
[22:54:13] <brion>	 MaxSem: ah ok lemme adjust it for that logic then
[22:54:15] <brion>	 makes sense
[22:55:14] <brion>	 ah d'oh i'm putting them in the wrong section
[22:55:16] <brion>	 no wonder they fail
[22:55:39] <jdlrobson>	 sweet thanks kaldari
[22:57:43] <gerrit-wm>	 New patchset: Brion VIBBER; "Simplify WAPness detection" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73018
[22:58:04] <gerrit-wm>	 New review: Brion VIBBER; "Fix some tests, I think this makes sense now :D" [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/73018
[23:05:51] <gerrit-wm>	 New review: Kaldari; "Looks reasonable to me." [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/73018
[23:30:47] <gerrit-wm>	 New patchset: JGonera; "Make editor button work on Android 2.x" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73900
[23:31:38] <jgonera>	 jdlrobson, kaldari https://gerrit.wikimedia.org/r/73900 would be nice to merge it before tomorrow, since it's the last deployment before pushing all of this to stable
[23:32:07] <kaldari>	 adding self
[23:34:16] <gerrit-wm>	 New patchset: Kaldari; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555
[23:37:48] <MaxSem>	 brion, I think I'm wrong: https://gerrit.wikimedia.org/r/#/c/73018/3/includes/DeviceDetection.php <-- looks like it used to return WAP when both it and HTML were requested
[23:38:04] <brion>	 hmmmm
[23:38:09] <brion>	 well if it claims html let's give it html
[23:38:14] <brion>	 i think that's …. sane?
[23:38:43] <MaxSem>	 still my addition of && strpos( $this->acceptHeader, 'text/html' ) === false changes the behaviour
[23:44:38] <MaxSem>	 or it's better... see the Samsung Jet test
[23:46:21] <gerrit-wm>	 New patchset: Cmcmahon; "QA: Correct the acceptance tests for main page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73029
[23:52:32] <gerrit-wm>	 New review: Cmcmahon; "* Made the test pass in the world of Bug 51204" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73029
[23:56:54] <jgonera>	 jcmish, can we extend the code cutoff slightly? I don't know where jdlrobson disappeared...
[23:57:09] <jcmish>	 umm sure by how long?
[23:58:33] <jgonera>	 hard to say... 20 minutes? I hope he's back soon
[23:59:04] <jcmish>	 k you got it
[23:59:12] <chrismcmahonbrb>	 jcmish: jdlrobson fyi https://gerrit.wikimedia.org/r/#/c/73029/
[23:59:16] <jcmish>	 I'll be one for a few more hours anyway
[23:59:30] <jcmish>	 so I'll give him until 6pm PDT
[23:59:33] <jcmish>	 :)
[23:59:43] <jcmish>	 chrismcmahonbrb:  was just looking at it