[00:00:00] jcmish: it was a mighty refactor [00:00:09] hahah [00:00:46] I figure i shall take it all in after I'm done testing for the deployment [00:01:53] jcmish: I ran all the tests afterward, all is still green on beta at least, search will fail in prod because of https://bugzilla.wikimedia.org/show_bug.cgi?id=51204 which is a little bit funky I think [00:03:36] so Maryana does that mean 51204 is a bug or by design? [00:03:39] New patchset: JGonera; "Story 980: Use pencil icon for section editing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73357 [00:03:42] I can't tell by reading the notes [00:03:50] opps lost maryana :D [00:04:17] New review: JGonera; "Updated to look like in the newest assets after consulting with May." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73357 [00:04:28] kaldari, jdlrobson https://gerrit.wikimedia.org/r/#/c/73357/ [00:04:52] jcmish: the workflow for 51204 is by design, but the implementation seems really odd to me. [00:05:12] yeah that seems pretty wonky [00:05:42] jcmish: at bare minimum we'll need some sort of message e.g. "type stuff above to see results" after clicking in the search field [00:06:18] I'll run it by jgonera and jdlrobson to see if there's some other implementation [00:06:22] we can do [00:06:30] /nick chrismcmahonbeenbackforawhile [00:06:32] And I'll to to maryana about it tomorrow in our meeting [00:07:54] what's 51204? a bug? [00:08:11] yup a bug [00:08:27] https://bugzilla.wikimedia.org/show_bug.cgi?id=51204 [00:08:57] jgonera: a not-quite-finished feature. I don't like the word 'bug' :) [00:08:59] yeah, I'm not quite happy with how jdlrobson fixed this. previously even if I started typing in the search field before the search module loaded, it would still trigger search as soon as it loaded [00:09:08] heh [00:10:15] jgonera: the DOM in the page right now after clicking in the search input the first time is a bit strange fwiw [00:10:59] why exactly? [00:11:03] let me see [00:12:09] jgonera: afact, after clicking the search input there are two elements in the page with name=search that refer to the same element, and only the second one actually addresses the element [00:12:31] afaict even [00:14:13] I think this was the case since I remember, not that I like it [00:15:09] jgonera: I figure I'll bring it up with Jon and Maryana tomorrow [00:15:18] could be worth trying another implementation? [00:15:26] or seeing if there's a better way [00:15:32] but I'll leave that to Maryana [00:17:08] there are better ways, but I guess we're waiting for the design team to redesign the overlays and then fix it for good [00:17:26] ah okay [00:19:15] jcmish: anyhoo, if you have a +1 or a -1 for the test, do let me know, I think this is worth merging for future maintainability. [00:20:18] yeah I plan to get it merged tonight Chris [00:20:30] kaldari, saw your GettingStarted mobile overview [00:20:34] I'm just finishing up a couple tests [00:20:36] Looks good. Keep us posted on how we can help. [00:23:37] will do [00:41:35] * Maryana reads up [00:41:45] what's going on, jcmish & jgonera? [00:41:51] New patchset: JGonera; "Story 980: Use pencil icon for section editing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73357 [00:49:21] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73357 [00:49:42] howdy Maryana we were talking about um https://bugzilla.wikimedia.org/show_bug.cgi?id=51204 [00:50:08] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73900 [00:50:23] jgonera: did tell me that we're waiting on some changes from design that should help out with this [00:53:43] New patchset: JGonera; "Remove unnecessary RTL CSS rule" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73913 [01:00:30] jgonera: and jdlrobson are we ready to stop merges for tomorrow? [01:02:02] jcmish: i think we are good [01:02:07] sorry for the lateness in today [01:02:12] but it's a big deployment ;-) [01:02:26] jdlrobson: k thanks yeah I'll be doing tons o testing [01:02:35] I'd already planned to because of the size so it's okay [01:36:19] New review: Mgrover; "Reviewed and ran on my machine, understand that there is a bug when running this on en.m related to ..." [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/73029 [01:36:41] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73029 [16:15:00] brion: you've a couple of pull requests / gerrit patchsets for the mobile app, but only one is mergeable [16:15:11] looking [16:15:27] brion: https://github.com/wikimedia/apps-android-commons/pull/30 is the mergeable one [16:16:05] brion: labs is wonky again, so gerrit syncing is slow [16:16:21] bah [16:17:11] brion: i'm doing them manually right no [16:17:11] w [16:21:41] brion: okay, the mergeable pull requests are on gerrit now [16:21:42] \o/ [16:21:42] i'm commenting on github [16:21:42] brion: also I like holo light *much* better than Dark. Take a look at it. Also made some changes to the upload UX, after discussing with friend/designer prtksxna_gone [16:21:42] gonna try it [16:21:42] brion: okay. I'm going for food, will be back in about 30 mins. [16:21:42] ok [16:21:42] brion: also there's a PR with new icons :D take a look. No flaming! [16:21:42] brb [16:21:42] :D [16:21:43] brion: I liek the new ones because they are more 'android'y [16:21:43] but we can work on them some more [16:21:43] (clear silhoutte) [16:21:43] okay [16:21:43] nom nom [16:21:43] brb [16:39:17] aaaaaaah stuck on waiting for first sync [16:39:18] i HATE not having a refresh button [16:39:21] is it waiting to be scheduled? [16:39:22] is it running but failing? [16:39:22] who knows... [16:39:25] there it goes. only took 5-10 minutes to start going [16:39:25] its scheduled to be scheduled [17:15:03] brion: hey brion [17:15:19] hey mhurd_home [17:15:20] feel better :D [17:15:27] thx! [17:15:28] scheduling a design sync-up for friday i see? [17:16:12] yuvipanda: can you make that design call on friday? [17:16:12] ya! [17:16:20] i want us to sync up a little better :) [17:16:31] and not on irc, where i have a horrible tendency to make the designers cry [17:16:38] hehe [17:16:46] my engineer speak is not very nice to them :( [17:17:02] i tried to schedule early as possible for yuvi [17:17:08] cool [17:17:54] hope this cold leaves me alone by then or i may be remote too [17:19:25] heh [17:21:57] feel better, mhurd_home! [17:22:29] Maryana: thanks! [17:23:01] yuvipanda: i actually like the overall look w/ holo-light, but some stuff needs some adjustment/fixing. left some comments on both github and gerrit (gerrit doesn't take photo uploads yet :D) [17:23:14] i'm undecided on the new icon, but it does look spiffy :D [17:23:40] just how terrible is my JS in https://github.com/MaxSem/Minifier/tree/master/server ?:D [17:24:41] jdlrobson, the place you suggested is a farewell lunch kind of place, not a welcome lunch kind of place ;) [17:26:45] MaxSem: doesn't look *too* explody offhand :D [17:29:46] Maryana: lol ;-) [17:30:03] and now you know where i'm taking you if you ever leave [17:30:14] not sure if that's an incentive or dis-incentive [17:30:25] MaxSem can do javascript now o_O [17:30:26] !! [17:30:30] woo! \o/ [17:31:00] brion: i downloaded Xcode 5 and it seems to be working fine. have you noticed any issues with it? [17:31:22] nothing too explode :) [17:31:48] mhurd_home: but if you compile with target of iOS 7, it'll show the new styles for the navigation bar and other widgets [17:31:48] try it out and see what needs adjustment [17:31:56] pooh good idea [17:32:13] damn auto correct [17:32:21] iirc the < back arrow on the navbar is REALLY prominent, we might want to tone it down] [17:32:28] ooh != pooh [17:32:57] interesting [17:35:13] split of the net! [17:35:18] we must be cautious [17:35:35] New review: Cmcmahon; "I'd be happy to help hack on this, but I'd like to see it a little further developed first. " [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/72895 [17:37:08] brion: sorry, ZNC troubles. grr [17:37:21] looking up at logs, moment [17:37:47] brion: mhurd_home I see a calendar invite for both friday and thursday. is that expected? [17:38:03] brion: and yes, holo light needs a bit more work, but I too like it in general a lot better [17:38:12] brion: any specifics on the new icon? [17:38:51] yuvipanda_: it does kinda disappear on a sea blue background :) [17:38:59] otherwise looks kinda nice [17:39:04] prtksxna_gone: ^ [17:39:08] brion: yeah, will poke him on it. [17:39:12] jdlrobson & kaldari, how about us doing the same way with https://gerrit.wikimedia.org/r/#/c/69585/ as we did to that tricky redirection change some time ago - checkout from gerrit to see if it works in production, then just commit (disabling unit tests that fails)? [17:39:19] though we should at least coordinate with those design folks since they have ideas of coordinating icon styles between apps/sites [17:39:49] at this point I'm rather discouraged at that prospect, brion. I'll probably hear back in a month. meh. [17:40:03] brion: but true. something to do during the syncup, I guess. [17:40:04] yuvipanda_: that's weird. should only be for friday [17:40:15] mhurd_home: okay, I'll cancel the thursday one [17:40:32] mhurd_home: done [17:40:38] yuvipanda_: what time on thurs did it say? [17:40:40] mhurd_home: err, weird [17:40:55] mhurd_home: I cancelled the thursday one, the friday one was also gone :| [17:40:57] can you invite me again? [17:41:00] maybe a glitch [17:41:07] yuvipanda_: ya [17:41:07] * brion stabs gcal [17:41:11] hehe [17:41:23] MaxSem: tricky redirection change? i can't remember that one.. [17:42:08] mhurd_home: I can make it, but in general I prefer not to have meetings after standup on Friday. would be nice if it were thursday, but I've UploadWizard deployment on Thursday, so this is fine [17:42:29] MaxSem: i actually think we could get away with just stripping the toc in https://gerrit.wikimedia.org/r/#/c/69585/6/includes/formatters/MobileFormatter.php [17:42:34] the rest should be possible with css... [17:42:55] we should then aggressively change core to allow us to exclude the table of contents [17:43:04] yuvipanda_: makes sense [17:43:26] jdlrobson, I've been working on TOC - could resume if there's a card for it [17:43:43] btw, anyone knows WTF span.t is? [17:44:07] mhurd_home: I still don't have it on calendar :| can you add me as a guest? [17:44:11] than forward/ [17:44:13] ? [17:44:39] yuvipanda_: weird! [17:44:42] ya [17:45:20] "that tricky redirection change" was https://gerrit.wikimedia.org/r/#/c/37600/ btw [17:47:58] gotta charge, bbiab [17:48:10] yuvipanda_: it's being weird. says you declined. did you get email update? [17:50:58] MaxSem: nope- but if it's not documented kill it [17:51:05] that's what i say! [17:51:29] MaxSem: i'm still urgently hoping i can find out wtf is wrong with logging in on mobile wikipedia... [17:52:54] jdlrobson, what do you think re https://gerrit.wikimedia.org/r/#/c/69585/ ? [17:53:37] MaxSem: so the test just fails because of a unicode problem right? [17:53:59] personally i'd love you to remove all the rules in https://gerrit.wikimedia.org/r/#/c/69585/6/includes/formatters/MobileFormatter.php… we can just add those to Common.css ... [17:54:05] (if we need to) [17:54:14] (remove all rules apart from .toc) [17:54:22] the test fails because there's something wrong with running tests in Jenkins [17:54:24] and i'd say deploy it and revert it if things blow up [17:54:30] it's progress [17:54:36] progress is good [17:54:43] ok [17:54:46] mhurd_home: I got an email from your address, with a forward of the invite. [17:54:51] lemme disable the test [17:54:56] MaxSem: good idea [17:55:02] also remove those other rules whilst there? [17:55:47] let's do that next deployment, too little time toi test them [17:56:11] mhurd_home: meh, it's still not there. I'll just try to turn up anyway and pick up the link from you guys :) [17:58:39] New patchset: MaxSem; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [17:58:47] jdlrobson, ^^^ [17:59:12] New patchset: Jdlrobson; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [17:59:37] MaxSem: just checking it out [18:00:27] mhurd_home: approved your iOS cert req [18:01:23] brion: ah thanks! didn't realize Xcode sent one when i was trying to add the ios 7 iPod to organizer [18:01:39] New patchset: Jdlrobson; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [18:01:55] MaxSem: looks fine to me - was jcmish ok about merging? [18:02:13] don't know [18:02:20] New review: Jdlrobson; "Feel free to merge if Michelle says that's cool." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/69585 [18:02:37] where's she, btw? [18:03:02] * jdlrobson shrugs [18:03:21] apparently there's a meeting at 11.30 so hopefully she'll turn up then [18:07:56] brion: ya ion compatibility is gonna take some work. i suspect that taking the auto-layout leap first will ease the transition [18:08:08] *nod* [18:08:10] "ion" = ios7 [18:08:12] ion? [18:08:16] ah [18:08:17] :) [18:08:18] autocorrect [18:08:23] not my day haha [18:08:33] brion: any progress on the desc. patch for android? [18:08:48] YuviPanda: did u get email for event? [18:08:50] YuviPanda: later. reviewing for iOS now [18:09:16] brion: I'm thinking of doing a release for android today or tomorrow, primarily as fix for multiple upload crashing. [18:09:24] mhurd_home: i've an email but it's not in my calendar [18:09:27] k [18:09:27] good enough, I guess [18:09:56] gah! [18:14:49] New patchset: Jdlrobson; "Make sure lists are styled in preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73987 [18:15:13] mhurd_home: don't worry about gcal being eek :) I'll take care of it [18:15:40] YuviPanda: k thx [18:21:24] mhurd_home: ok i'm happy to merge https://github.com/wikimedia/Commons-iOS/pull/92/files, it's not exploding and looks awesome -- any last-minute changes you want to make first? [18:21:51] brion: awesome! nothing at present [18:22:13] pushing zee button! [18:22:18] whee [18:22:23] [Commons-iOS] brion closed pull request #92: Sliding details page overlaying pinch-able preview image (master...detailsDetails) http://git.io/d8XP6g [18:22:23] :) [18:22:30] jdlrobson, can we make the magnify icons CSS-only ? [18:23:32] MaxSem: ? [18:23:38] are you talking about MobileFormatter? [18:23:53] jdlrobson: personally i'd love you to remove all the rules in https://gerrit.wikimedia.org/r/#/c/69585/6/includes/formatters/MobileFormatter.php… we can just add those to Common.css ... [18:25:42] but that would just increase HTML size:) I want to play bad and replace
with just
or just [18:26:25] jdlrobson, jgonera - we're in 31 for a quick QA review - grab kenan on your way :) [18:32:10] MaxSem: meh - i suspect the performance gain of not parsing a huge html string would outweigh the added html in the gzip downloaded file [18:33:30] hmm, just thought - we'll have to perform these transformations for WML anyway [18:33:42] so there has to be a split between rules [18:45:58] anyone know if mhurd will be in the office today? [18:46:43] rfarrand: he said no, has a cold [18:46:55] thanks Yuvi! [18:48:36] rfarrand: :) [18:48:44] brion: mind if I do a release...now? [18:48:46] beta10! [18:48:58] brion: it's crashing for HC and also for multiple upload. this should fix both. [18:49:13] brion: any objections? [18:57:58] YuviPanda: go for it [18:58:06] brion: okay. help with testing? :) [18:58:16] sure i can help quick [18:58:19] brion: since last time there was a phantom bug with my build machine. scary. [18:58:24] brion: okay, let me get the apks done. [18:58:24] then i have to run some house errands for a couple hours then i'll be back [18:58:34] brion: okay. [18:58:35] flooring whee [18:58:42] i fear the costs [18:58:49] brion: aww. [18:58:49] but i'm sick of shitty carpets [18:58:51] heh [18:59:00] I just bought the most expensive pillow and blankets i've ever bought [18:59:04] tired of shitty pillows :) [19:00:26] haha [19:03:04] brb [19:13:08] YuviPanda: builds to test yet/ [19:13:09] ? [19:13:32] brion: no, moment. TrueCrypt is being difficult [19:14:23] ok [19:16:47] brion: email'd [19:19:11] whee [19:19:53] ok reinstalling from play store [19:19:55] then testing upgrade [19:19:59] brion: sweet [19:21:09] grrr touchwiz [19:21:18] gooooo nexus ;) [19:23:35] YuviPanda: so far so good, tested on 2.3 [19:23:42] multiple upload works with no surprising explosions [19:23:46] anything else i should test? [19:23:52] brion: single upload? [19:23:56] hah wise [19:24:45] looks good [19:24:49] +1 i say [19:24:55] brion: sweet. let me push then :) [19:25:16] :DDD [19:25:19] i'll upload to download [19:25:32] brion: oh yeah. please do [19:25:36] brion: i'll send gerrit patchset for bump ow [19:26:34] -rw-rw-r-- 1 brion wikidev 1809219 2013-07-16 19:25 wikimedia-commons-1.0beta10.apk [19:26:37] sweet [19:27:47] brion: https://gerrit.wikimedia.org/r/#/c/73996/ [19:27:48] +2? [19:27:50] ok gotta run. email me if needed :) [19:27:54] oh real quick [19:27:58] brion: yes, just a bump [19:28:02] and this is the version i sent you [19:28:03] so [19:28:21] +2'd [19:43:39] YuviPanda: do you have that link you sent me yesterday for the upload wizard source? i don't have it on my home machine [19:43:49] mhurd: moment [19:46:24] *siren sound* DEPLOYMENT IN 15 MINUTES! XD [19:49:21] jcmish, jdlrobson, jgonera - no reports of problems due to removal of per-device stylesheets? [19:49:45] no sir [19:49:50] mhurd: https://github.com/wikimedia/mediawiki-extensions-UploadWizard/blob/master/UploadWizard.config.php [19:49:52] cool [19:49:55] mhurd: see under 'licenses' [19:50:00] may it RIP then [19:50:04] not that I've seen come in jdlrobson jgonera ? [19:51:31] YuviPanda: thank you! [19:52:27] mhurd: yw :) [19:53:49] jdlrobson: the cache flush isn't today right? [19:54:13] right [19:54:41] k thanks MaxSem [20:03:16] all right jcmish, jdlrobson, jgonera, Maryana - we're live on testwiki, please test:) [20:03:28] can do! [20:04:46] anyone knows a reason why we shouldn't deploy https://gerrit.wikimedia.org/r/#/c/72983/ ? [20:06:46] kaldari, we're live on testwiki, please test:) [20:09:22] MaxSem: roger [20:09:45] MaxSem: what is that load script stuf?!! [20:09:48] i've never seen that before :D [20:10:12] luckily for you:P [20:10:37] it's for MFDeviceDetectModule [20:13:22] MaxSem: looks good to me [20:13:28] (not too much to test this time :)) [20:13:52] tests have passed and now I'm just poking around [20:14:09] MaxSem: did you see https://gerrit.wikimedia.org/r/#/c/73332/ ? [20:14:39] (just saw i hadn't added you as a reviewer - only mentioned it in commit) [20:15:22] merging [20:15:55] thanks MaxSem ! [20:20:58] MaxSem: jdlrobson Maryana jgonera looks good [20:21:20] yeah, looks good to me - jgonera, did you test the android-related bugs? [20:21:43] yes, I edited and didn;t notice any problems [20:22:19] okay. in such case, I'm going to quickly test a revision from gerrit before reverting and deploying what we've been testing [20:23:54] New patchset: MaxSem; "Bug 48917: Fix extracts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [20:25:59] we switching to a new editing schema, jdlrobson? [20:26:42] Maryana: ooohhh yeh [20:31:00] New review: MaxSem; "Tested in production live by deploying this rev on testwiki - works despite what the test says." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [20:33:19] testing done. reverted, preparing to scap [20:34:25] uhoh reverted? [20:35:08] my test, see ^^^ [20:35:59] played scatman MaxSem [20:36:06] I declare a scap! http://www.youtube.com/watch?v=3cnQCk0u49w [20:36:35] oh whew :D [20:36:52] YuviPanda: don't have my computer to test for s couple more hours [20:37:04] brion: heh, okay. I'll just test on mine and push out, since the last one didn't break [20:37:19] brion: happy to have caught that *before* though :) [20:39:06] * MaxSem scaps [20:39:10] brion: do replace on download. at some point tho [21:05:42] New patchset: Jdlrobson; "Story 920: Show uploads tutorial after following anon cta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73550 [21:05:57] New patchset: JGonera; "Scope animations-related workaround inside .animations" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74057 [21:08:37] New patchset: Jdlrobson; "Story 920: Show uploads tutorial after following anon cta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73550 [21:10:51] New patchset: JGonera; "Disable animations on Android 2.x" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74059 [21:11:01] New patchset: Jdlrobson; "Add returnToQuery to editor cta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74060 [21:17:38] we found a slight regression [21:17:43] Maryana: ^ [21:17:48] the loader is huge on stable [21:17:50] I can apply a fix to enwiki [21:17:58] (the loader for the watch star on stable) [21:18:18] oh I was gonna ask what loader [21:18:50] eek.. lemme take a look [21:20:00] hmm, it doesn't look so bad [21:20:08] oh wait, i'm in beta [21:20:31] gah [21:20:38] it looks like a double spinner? [21:20:55] :D [21:20:57] ju ju made it pop [21:21:02] it's not so bad, though, jdlrobson [21:21:07] Maryana: i fixed it on enwiki but all other wikis have this problem [21:21:11] unless they copy the hack.. [21:21:14] i think it's ok [21:21:37] Maryana: yeh I think we can live with it like that for the time being [21:21:38] we're gonna roll out a whole new watchlist UI next week anyway ;) [21:21:47] at least no one in twitter can insult me in my own language [21:22:00] Maryana: that reminds me - is the talk button being promoted? [21:22:02] i think we said no.. [21:22:24] no [21:23:50] do we need to deploy a fix? [21:23:50] uhh [21:24:01] nope, we're ok maxsem [21:24:10] however, what's up with the typography on the main page of enwiki? [21:24:32] it looks like the old typography.. :-/ [21:24:53] jdlrobson jgonera ^ [21:25:07] New patchset: JGonera; "Disable animations on Android 2.x" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74059 [21:25:49] New patchset: JGonera; "A hack for the editor on Android 2.x" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74063 [21:28:17] grr, i started running a query on the 6th floor, and now i can't leave until it finishes or it'll break in the elevator [21:28:32] unless… i leave my computer [21:28:32] * Maryana is a genius [21:30:08] Maryana_afk: start using mosh next time :) Should fix these issues. Even persists across hibernates / ip changes! :) [21:35:55] New patchset: JGonera; "A hack for the editor on Android 2.x" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74063 [21:37:29] yuvipanda: mosh, eh? [21:37:36] Maryana: yeah, 'mobile ssh' [21:37:37] innnteresting.. [21:37:52] Maryana: keeps connections alive across network disconnects, slow connections, packetloss, etc [21:38:12] Maryana: rather very useful for me since all those things keep happening to me usually :) [21:38:34] heh. we watched delhi belly last night and thought of you [21:38:45] Maryana: and it also does some nice optimizations with regard to line editing, so typing things into a remote shell should be much better [21:38:56] Maryana: haha :D Fun part? I've never watched that movie :) [21:39:23] so when people tell me that I've no idea what to think :) I can fix that next week [21:39:47] you should watch it and tell us if it's an accurate depiction [21:40:09] Maryana: :D will do. [21:40:28] Maryana: I can do that, or not watch it until I come over, so you can watch me watch that for the first time and see how I react... [21:40:53] New review: MaxSem; "Per Jon." [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/69585 [21:41:06] i'm not sure if i have the patience to watch it again.. [21:41:13] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/69585 [21:41:21] Maryana: hehe :P [21:43:55] New patchset: JGonera; "Fix license image alignment in editor and uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74068 [21:54:27] New patchset: Jdlrobson; "Bug 51458: Allow watching outside main namespace" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74070 [21:55:15] New patchset: MaxSem; "Remove some removals" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74071 [21:59:45] New review: Jdlrobson; "Also breaks beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [22:00:34] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73913 [22:02:29] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74068 [22:03:11] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/74063 [22:04:24] Maryana: we never added a placeholder to the edit box on a new page.. [22:04:41] you mean when creating a page? [22:05:32] Maryana: https://bugzilla.wikimedia.org/show_bug.cgi?id=51480 [22:06:46] ah, right [22:07:00] this is why i don't want to show red links yet :) [22:07:08] it's going to require some fancy user education [22:08:33] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74059 [22:08:34] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74057 [22:11:48] jdlrobson, I was thinking: we might need a way to define global CSS [22:15:38] kaldari: blame william mckinley https://bugzilla.wikimedia.org/show_bug.cgi?id=50205 [22:17:08] Maryana, can we write a story for decreasing content margin for the next iteration? It's not a big thing, but I told May and Vibha that we'd do it when we move everything to stable and I feel we'll forget if it's not in mingle :) [22:17:37] is that a story or a bug? [22:24:20] Maryana: where are the design twins? [22:24:28] we have a story which has no assets.. [22:24:29] i see one up here on 6 [22:24:37] they're both up here [22:24:39] which story? [22:24:46] can you tell them Ryan is working on https://mingle.corp.wikimedia.org/projects/mobile/cards/921 and needs to know what it's supposed to look like? [22:27:15] there's an attachment [22:27:21] https://mingle.corp.wikimedia.org/attachments/486f369fc204d86224b258d28c404f3c/379/921.pdf [22:27:24] kaldari ^ [22:27:27] Maryana: have you seen the attachment.. ? :) [22:27:41] it's .. fuzzy... [22:27:44] oh, i see, you mean the actual visual components? [22:27:54] needs a bit more fleshing out perhaps [22:27:55] yeh it doesn't say what the text should say or what the image should be [22:27:59] it hints it might be a nag overlay as well [22:28:03] New review: JGonera; "Many small inline comments." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/73550 [22:28:05] which would change things drastically.. [22:28:05] the card should have the copy in it [22:28:31] jdlrobson, you built out the uploads piece of this, right? let's make sure to keep this consistent [22:28:36] i'm sure this asset is outdated by now [22:28:40] ok so no nag overlay - just image and text? [22:28:48] Maryana: ok in that case we just need an image i guess [22:28:49] go with exactly the same UI as what you did on uploads [22:28:50] yeah [22:29:03] shouldn't it say something specific to the article? [22:29:19] hmm? [22:29:23] Such as "You can now edit the San Francisco page by clicking on the edit icon" [22:29:35] oh, we can do that? [22:29:40] yeah, let's do that :) [22:30:47] There seems to be uncertainty regarding the UI/workflow differences between upload and edit [22:31:01] such as the text for the buttons and the cancelation workflow [22:31:07] (… and the Special:Uploads first time tutorial) [22:31:25] i ran with the assumption i'd copy Special:Uploads so that it just says "Got it!" which dismisses the overlay [22:31:41] rather than introducing an X and another way of getting at editing/uploading which i think is confusing [22:31:56] (as the user should click on the thing being pointed to :)) [22:32:39] are Vibha and May around? [22:32:45] and free? [22:33:14] we need to get them on IRC [22:35:55] MaxSem: I do wish you'd let other people chip in with thoughts on RFCs or at least entertain them before opposing things outright… in my opinion it does launch the discussion in a negative way that is not helpful and does make it look like the entire mobile team disagrees with each other…. it also undermines all the work jgonera put in to writing it. Just my 2 cents that I wanted to raise. [22:36:43] Maryana: we're coming up to you..! [22:38:17] hello world?! [22:40:40] jdlrobson, I'm entitled to an opinion [22:43:16] sure MaxSem I'm just saying I think it can be counterproductive when expressed so early on in the process and being so unconstructive (in that it just says no) - I simply wish you'd allowed others to chip in first… by being a member of the mobile team I think your expression carries more weight and could harm any RFC when expressed like this as it has now set a tone for the discussion. [22:44:05] hmm, if I oppose it, it makes sense that I want it to fail, no? [22:44:39] and sorry, but I also believe that taking the customizability away from users is unconstructive [22:45:19] ragesoss: true true, you probably have a few now [22:45:19] ragesoss: you mean 'delete all failed uploads' right? [22:45:20] ragesoss: any idea where that ought to be? [22:45:20] ragesoss: settings maybe? [22:45:20] brion: i got the license-from-category code working. it's not perfect, but seems to have correctly determined the license of all the embedded images of the day so far… will continue to test... [22:45:20] abort is what it says on individual failed uploads. [22:45:31] ragesoss: hmm, I need to change that too. [22:45:51] ragesoss: but does putting that in settings make sense? or should this take up an entry in menu on my contributions? [22:46:02] mhurd awesome! [22:46:22] either. [22:46:27] I'm still at the house will.look over the code when I get back [22:46:45] for me, I'd slightly prefer menu. [22:47:10] "remove" is the right word. [22:47:16] ragesoss: yeah, true. let me file bugs [22:47:33] ragesoss: rather, it should be 'abort' while it is uploading, and then become remove when it fails [22:47:50] brion: i'll try to have patch ready in next hour or 2 depending on if i can break it [22:48:09] great :) [22:48:26] and jesus, I don't think I'll ever understand cats. [22:49:22] categories need to be replaced with wikidata totally [22:49:49] Yuvi: makes sense. [22:50:16] also, retry all [22:50:22] New review: Jdlrobson; "After talking with Maryana apparently the tutorial overlay button should not have a button got it bu..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73550 [22:50:35] ragesoss: true. that'll keep adding on, and we already have 3... [22:50:44] I can move about inside settings maybe, but that feels wrong [22:51:44] if it only appears when failed uploads are present, it's fine. [22:52:05] ragesoss: true. [22:52:09] i'm adding bugs now [22:52:24] power users like powerful menus. [22:52:44] ragesoss: https://bugzilla.wikimedia.org/show_bug.cgi?id=51488 [22:52:53] MaxSem: at least try to see other's perspective and suggest a halfway solution even if you dislike it - this kind of attitude can be very disheartening to your team members [22:52:59] ragesoss: actually, we'll eventually have the slide-out-from-left drawer, so settings, etc should go there. [22:53:05] so this should be fine [22:53:54] ragesoss: https://bugzilla.wikimedia.org/show_bug.cgi?id=51489 [22:54:07] ragesoss: https://bugzilla.wikimedia.org/51488 [22:55:39] you fixed OOM too? [22:56:12] I'll test tonight. [22:56:12] ragesoss: we relevied a lot of memory pressure, so this should be fixed for most people... [22:56:15] ragesoss: okay. [22:56:20] ragesoss: and thumbs should also load faster [22:56:31] noticeably, at least if you're not on an incredibly-super-fast conn [23:54:43] mhurd: send a pull req when you're ready, even if it needs some more work i'd love to look over the current status :) [23:54:51] ok lemme reupload the android apk [23:55:04] brion: will do [23:55:24] btw flooring is expensive [23:55:35] brion: also download the current one from store and see how it is. i hope I got the correct one this time :P [23:55:40] heh ok [23:56:13] YuviPanda: ok this look right? f333e34de6f584fb248cb8b215385dec wikimedia-commons-1.0beta10.apk [23:56:20] lemme check md5 [23:56:35] brion: yup looks legit [23:56:39] \o/ [23:56:56] ok lemme upgrade from store on one of my devices [23:56:56] n7 is handy [23:57:23] heh [23:57:30] the cat seems to have slept on my lap. [23:57:45] awww [23:58:17] ok i see the update in the store, installing...