[00:02:26] YuviPanda: ok i got a crash testing multiple upload…. but i think it's because i picked Picasa-synced photos [00:02:27] i remember having trouble with Picasa before [00:02:33] brion: grr, pick normal ones? [00:02:36] on WLM [00:02:37] brion: also verify you have beta10 [00:02:38] yeah moment [00:02:59] '1.0beta10' yes :) [00:03:55] New patchset: Jdlrobson; "Story 920: Show uploads tutorial after following anon cta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73550 [00:03:55] New patchset: Jdlrobson; "Rename the horrible overlay class to something more meaningful" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74094 [00:04:43] YuviPanda: so flight of the concords.. want me to buy a ticket? [00:04:46] well 2.. [00:04:56] jdlrobson: is it refundable if I'm not there? I'll know by mid august if I'm coming. [00:05:03] YuviPanda: ok it's much happier with the non-picasa photos :) [00:05:05] well.. i'm sure we can sell it on easily [00:05:11] jdlrobson: true that. do buy! [00:05:17] and its dave chapelle as well.. [00:05:19] hopefully not sold out.. [00:05:20] jdlrobson: first time ever there's a band I like and is touring! [00:05:28] hmm, I've no idea who Dave Chapelle is [00:05:30] brion: :) [00:05:35] only downside is we have to go to mountain view [00:05:36] brion: and thumb loading should also be faster [00:05:54] jdlrobson: well, that's alright, I think. At least we don't have to go to NZ [00:05:59] YuviPanda: yeah thumbs are slightly blurrier, presumably faster but it's hard to tell on my fast cable ;) [00:06:02] YuviPanda: you ok with general admission? more fun.. [00:06:21] jdlrobson: I've never been to a concert in my life so I've no idea what general admission means :D [00:06:26] ohhh nos [00:06:29] i can't make that date actually :( [00:06:29] New review: Mgrover; "I'll clean up it up but the failure is a legitimate failure and there is a bug written see the origi..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/72895 [00:06:31] jdlrobson: though I guess it is sortof like our Agra to Delhi return trip [00:06:39] Hi.. [00:06:45] jdlrobson: :( [00:06:48] YuviPanda: just realized i'm off to vegas.. [00:06:56] you can come there instead if you want..? [00:07:00] YuviPanda: I'll take a ticket too please. [00:07:08] there we go YuviPanda you [00:07:08] v [00:07:18] *you've got a backup ;-) [00:07:22] bbiab [00:07:23] * YuviPanda gives T13|playingDad a parking ticket :) [00:08:01] jdlrobson: hmm, how far up will I have to book the vegas ticket? I'll be there for allstaff, so no idea what the schedule will be like [00:08:45] jdlrobson: also gave a +1 to MaxSem's -1 for site-scoping CSS. And a question about if this can be enforced at all when there exist gadgets. [00:09:26] YuviPanda: You've written CSS before right? [00:09:33] jdlrobson: err, yes? [00:09:44] so you know how much of a pain in the arse it is to manage and keep efficient and organised? [00:10:02] that said i think customizing UI and scoping Common.css are too different problems [00:10:07] you can do both in a sane way [00:10:09] the existing way is not sane [00:10:18] jdlrobson: yeah, but I've also written gadgets before, so I know how much it makes sense to let this be. [00:10:31] jdlrobson: agreed, but a sane way to do 'site customizations' has to exist first before this can be killed [00:10:52] jdlrobson: also if we let gadgets have css, then I don't know if we can technically enforce this at all. [00:10:52] YuviPanda: and this RFC doesn't stop this - that would be a constructive comment to make in response to the request for comment :) [00:11:13] saying "NOOOO this is terrible don't do it -1" helps no one and continues a pattern of MediaWiki being adverse to any change. [00:11:16] jdlrobson: of course, I *think* I made a constructive comment about the gadget thing. [00:11:36] jdlrobson: I think that is also because I already saw that play out on mobile-tech so didn't feel like repeating that [00:11:42] (references to tumblr, etc) [00:12:15] YuviPanda: surely you of all people want to repeat in a public setting!? :D [00:12:38] when disagreeing with something I always try to first see the positive points behind doing something and suggest a counter proposal rather than just saying -1 or -2 - these help no one and really irritate me [00:12:42] jdlrobson: I think I gave up on that fight, really. Everything seems to keep getting silo'd up, so meh. [00:12:51] i see it all the time on wikitech and it's just demoralizing [00:12:57] jdlrobson: and I've trie denough times in the past. [00:13:01] YuviPanda: ? [00:13:07] jdlrobson: 'repeat in a public setting' [00:13:25] YuviPanda: juliusz even said in his email he wanted some feedback before posting [00:13:32] i think that's a legitimate use of a private mailing list - to make sure the right message goes out [00:14:27] * jdlrobson awaits the day where someone enables Common.php on MediaWiki [00:14:47] that too. There aren't too many emails I feel like 'this should be public'. Hopefully that is because we're doing things on appropriate lists (I saw them on mobile-l, wikitech-l and design over the last week!) or Perhaps I'm giving up, or we are just writing lesser emails, or they are not even on mobile-tech :P [00:15:21] YuviPanda: i think we are - i think we're getting better at using the mailing lists wisely [00:15:24] jdlrobson: but yes, you are right. I'll mention that there needs to exist a nicer way to customize mediawiki, but I don't think Common.css / js should ever go away. [00:15:28] i hope you've noticed i flag stuff when i think we're doing it wrong [00:15:38] jdlrobson: true, seeing those on design and wikitech was nice [00:16:03] jdlrobson: yeah, that is also nice :) I've not had to think about it for the most part since that last thread, which is a Good Thing! [00:16:24] YuviPanda: I guess we're stuck with Common.css and Common.js for the time being - i wish they didn't exist but hey not much one can do about that now. It pisses me off that people see CSS and JS as somehow less dangerous to edit than Common.php [00:16:28] *then PHP [00:16:48] well, it is restricted to just admins. [00:17:00] and it's just a wiki - if you want to CR, put them on your watchlist :) [00:17:41] I'm reasonably happy that they are rather free, 'wiki way', etc. Writing Gadgets is fun. [00:18:37] oom crash on my main account and good phone, Yuvi. [00:18:59] brion: https://github.com/montehurd/Commons-iOS/compare/potdLicense [00:19:04] ragesoss: arrr. at the same time or later? [00:19:08] ragesoss: while you scroll? [00:19:15] ragesoss: and without laaaarge png? [00:19:27] woohoo [00:19:54] yeah, or while I stop scrolling at a new place. not sure. no huge PNG though. [00:20:10] jdlrobson: made a comment about needing a better way to do customizations. You're correct I should've lead with that though. [00:20:29] in last build, it was a 3 mb jpg that kept crashing it. [00:20:30] ragesoss: hmm, I'll migrate us off Volley and see if that makes things better [00:20:34] hmmmm [00:20:38] Thanks YuviPanda I appreciate that - I think that is more useful [00:20:42] jpgs shouldn't crash them, dammit [00:20:46] RFC's are living documents so can be adapted :) [00:21:09] jdlrobson: :) is the concern about Gadgets clearly written? or should i expand on that? [00:21:25] aka 'does it make sense?' [00:21:54] on the plus side, MHL works on my phone now. [00:22:13] ragesoss: heh, because commons kept crashing? :) [00:22:36] jdlrobson: this is the first RFC for the new process, I think. let's see how that goes! [00:22:53] jdlrobson: I need to start one soon too (including JSONContent in Core, though unsure if that should be an RFC or a Patch) [00:23:05] jdlrobson: congrats, and good luck :) [00:23:33] brion: https://commons.wikimedia.org/wiki/Commons:Village_pump#Join_an_IRC_Chat_about_Multimedia_this_Thursday might be something you're interested in (since you <3 highres images) [00:23:49] mhurd cool I'll test it in a bit and add some comments [00:23:51] and related stuff [00:24:03] Yuvi ooh yes [00:24:09] brion: yay! [00:24:52] brion: though the first reply there 'Commons is pretty as it is!' is very annoying. meh. [00:24:57] MHL landed in CyanogenMod for my phone a few days ago. Commons app looks good on it. [00:25:03] hah [00:25:18] sweet! [00:25:19] ragesoss: niice! [00:25:55] and miracast coming soon, allegedly. [00:26:12] brion: also, btw - we killed both the Campaign APIs. MaxSem ran numbers on the API logs for me for all of last month, and one had 0 hits and the other had ~70 hits (several from me, no doubt, trying it out) [00:26:43] in the app, you mean? [00:26:44] excellent [00:26:51] now if I can find something to receive it, I'll achieve Android Nirvana [00:27:01] don't need compact interfaces then :) [00:27:02] or something [00:27:09] compat [00:27:31] brion: they can be retreived with the usual action=query prop=revisions interface now [00:27:46] I would love a software miracast receiver/recorder [00:27:54] yup [00:28:03] MaxSem: no, in UploadWizard :) there was a large refactor, all the old code went away, and with it the old API. [00:28:24] it's a compat breaking change. Special:UploadCampaign also went away [00:28:40] one API was for the editing interface and the other for WLM iirc [00:28:57] WLM app [00:29:20] brion: yeah, the WLM app one you built had 0 hits :) [00:29:36] brion: the other one had ~70. [00:29:47] well we killed it off ;) [00:29:59] brion: yeah, but it was there, and documented, and nobody was using it :P [00:31:22] exterminate! [00:31:27] brion: hehe, indeed! [00:32:05] brion: thoughts on the 'new'er holo light interface for photo upload? show just a 'strip' of the image that shows you a full, zoomable/pannable image on tapping [00:32:15] (once categorization, etc issues are fixed, of course) [00:33:46] the cropped strip seems hard to read for me with ought the translucency effect [00:34:14] I'd consider a small but full thumb which is expansible? [00:34:42] brion: harder to read? [00:34:47] brion: it's not supposed to overlap with anything [00:35:29] brion: idea is to dump you into gallery on tap, so we don't have to worry about zoom/pan/etc [00:35:30] Maryana: jgonera can you poke Maryana - i have a quick question before i leave today [00:35:38] i'm here [00:36:08] Maryana: sooo.. i worked out why logins are not being kept [00:36:12] i'm kinda pissed actually :) [00:36:21] what happenened? what is it? [00:36:25] Maryana: apparently we're not setting the keep me logged in for 30 days checkbox [00:36:37] so i'm wondering whether i should show that in the ui or force it? [00:36:37] ragesoss: also can you do the adb logcat | grep Volley thing? [00:36:44] ragesoss: to help figure out which image is causing it this time? [00:37:17] jdlrobson, someone told me we were forcing it... I think Arthur [00:37:26] jgonera: yeh this is what annoys me - I heard the same [00:37:28] but it's not true [00:38:47] New patchset: JGonera; "Fix position-fixed workaround for older devices in overlays" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74098 [00:39:21] jdlrobson, I'd just force it [00:39:28] Yuvi I like the tap I'm concept yes! just felt odd cropped that way [00:39:35] tap in [00:39:47] chris steipp wasn't too happy with the idea of me forcing it :) [00:40:25] i can talk to him [00:40:41] brion: hmm, okay. So problem with full sized square is that it'll take too much space, and will go under the keyboard when it expands [00:41:07] true [00:41:16] brion: I'm trying to (with prtksxna_gone) design them so that they look usable and nice both with the keyboard out and without [00:41:26] on portrait and landscape. fairly tough, but fun [00:41:33] also fuck, cat's tongues are like sandpaper! [00:41:43] lol [00:48:54] New patchset: Jdlrobson; "Sigh." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74100 [00:52:38] Yuvi: will do tonight or tomorrow. [00:55:18] ragesoss: ty! [00:56:49] New review: MaxSem; "Loool:(" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/74100 [00:57:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74100 [00:57:15] nice [01:00:47] New patchset: JGonera; "A hack for the editor on Android 2.x" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74063 [01:09:05] New patchset: JGonera; "Reuse jQuery vars" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74101 [01:09:30] gah, no brion [01:18:17] * YuviPanda heads to slep [06:55:39] yurik: morning :) [06:56:10] yurik: got an error response back from the search API Vumi uses: "{u'servedby': u'mw1204', u'error': {u'info': u'Pool queue is full', u'code': u'srsearch-error'}}" [06:56:40] yurik: only once though so not a major issue, just curious how we can possibly deal better with those on our side. [11:00:00] prtksxna: thoughts on keeping the background overlay as is, but blurring it with a proper gaussian blur instead of just using alpha? [11:00:23] YuviPanda: Are you talking about the image upload activity? [11:00:27] yeah [11:00:59] YuviPanda: Can you add a gaussian blur with code? [11:01:10] prtksxna: yeah [11:01:29] prtksxna: it's a little tricky but very doable, and doable fairly fast. [11:01:40] YuviPanda: Wait, that is futile. The point of showing the image is so that the person can check if the correct image is being uploaded, right? [11:01:50] hmm, right. and a blur makes that pointless [11:02:56] YuviPanda: What is the problem that you are facing with the decision that we had took yesterday (or was it day before?)? [11:03:07] *taken [11:03:30] prtksxna: categories not panning 'up' properly. I've not implemeneted that yet. [11:03:40] prtksxna: there's a screenshot on the pull request. moment [11:04:57] prtksxna: https://github.com/wikimedia/apps-android-commons/pull/29 [11:05:21] YuviPanda: Yes, I was just looking that that… [11:05:29] YuviPanda: Gimme a minute [11:05:52] it's a problem with smaller screens, rather than with gingerbread as such [11:06:00] also problematic when you have a lot of categories [11:08:02] and in landscape [11:08:34] but if you totally hide the image by panning up, which happens if the keyboard is already up, you've no way of actually seeing the image [11:09:27] YuviPanda: What happened to the idea of showing a "square cropped" image on the top left with the Title & Description on the side and the categories below? [11:10:17] prtksxna: wouldn't the image be too small? Also the title and desc might be squished? Plus the description is usually multiple lines. [11:10:27] Hmmm [11:10:31] prtksxna: also that forces people to add categories before starting uploads, and unsure if I want to do that [11:10:41] since I don't have the code for title-less upload-starting yet [11:11:00] YuviPanda: There was the hack you were telling me about, but yes, we should think about this a little(lot) more [11:11:08] prtksxna: true [11:11:27] prtksxna: the current + pan up might be a temp hack of sorts. [11:11:33] the hack is very hacky. [11:11:55] * prtksxna hacks the hacky hack [11:12:08] Hmm [11:13:29] YuviPanda: So are we saying that the current(20% image on top) solution is just NOT going to work out? [11:13:47] YuviPanda: And that having the blurry picture in the background is not solving the purpose? [11:13:47] prtksxna: no no, it can be a temp hack, since the only problem is that when we pan up the image will be hidden [11:14:11] prtksxna: the blurry overlay doesn't work with Holo Light, which is one of the primary reasons the app is still holo dark [11:14:59] YuviPanda: The image hiding is fine(I believe), does one still really want to look at the image while entering the title? [11:15:15] yeah, it's just a minor point [11:15:30] hmm, okay, let me figure a way to get that to pan and scroll now. [11:15:43] If I am typing the title, my focus would/should be on the keyboard and the input text field, right? [11:15:51] YuviPanda: Alright [11:16:03] prtksxna: only problem I could think of is if the keyboard is already open when you open the activity, which will hide the image before you can look at it [11:16:14] prtksxna: but I guess that's a minor case (it is a bug that happens in some devices) that we can ignore for now [11:16:30] prtksxna: also should the image need any affordances to show that it can be tapped to show the entire thing or is the current bits okay? [11:16:39] YuviPanda: Also, how do I send different pull requests? My previous commit got included in the same pull request. How can I make a different pull request for the HoloLight icons? [11:17:09] YuviPanda: I think the image itself, with the copyright stuff on it should be fine [11:17:17] We could get feedback for it? [11:18:13] prtksxna: git remote add wikimedia https://github.com/wikimedia/apps-android-commons.git [11:18:17] prtksxna: git fetch wikimedia [11:18:28] prtksxna: git checkout wikimedia/master -b holo-light-icons [11:18:38] prtksxna: then do your commits there. it'll create a branch called holo-light-icons [11:18:42] YuviPanda: grrr! We'll just do it when I come downstairs :P [11:18:47] prtksxna: and from next time you can just do the fetch and checkout [11:18:48] prtksxna: :P sure [16:08:30] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74101 [16:11:49] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74071 [16:27:09] brion: so for holo light, I need to still fix 1. categories hiding, 2. icons, 3. multiple upload. Otherwise looks fine right now. [16:58:16] yuvi: crash report and volley logcat coming shortly. [16:58:41] \o/ [16:59:11] it was another not-huge jpg that crashed it, looks like. [16:59:17] :( [16:59:40] YuviPanda: the holo-light theme is growing on me. still needs some icon fixes and fixes for the new image display style though [16:59:58] i'm also not having any luck with that 'tap to view image', it's either crashing gallery or launching the album overview for me [17:00:29] https://commons.wikimedia.org/wiki/File:Trident_Maple_bonsai_52,_30_April_2012.JPG [17:00:50] that's the culprit. [17:00:54] this time. [17:01:25] huh... a whole string of 404's in the volley before that. [17:02:20] ragesoss: were they for small images or non-JPG/PNG images? the way thumbs are loaded there's a shortcut that tries a fixed URL, then falls back if that didn't work as expected [17:02:58] no, they were for normal jpgs [17:03:11] funky. i'll leave the log parsing to yuvi then :) [17:03:59] the very first one is for a large webm file, though. [17:04:21] oooh [17:04:25] yeah the thumbnail fallback behavior is probably bad on large videos [17:04:47] i may have to rewrite that part myself since yuvi objects to using the image info api :) [17:13:29] hey mhurd [17:13:40] hey brion [17:13:59] still under the weather today :( [17:14:00] feeling better or worse today? :) [17:14:02] aww [17:14:07] bout the same [17:14:16] well that's better than worse. i …. think [17:15:28] reauthenticating to google…. :P [17:19:48] awjr + anyone else: Fundraising is starting it's first trial mobile campaign on iPhone + Android [17:21:00] \o/ whee [17:23:08] mwalker, awjr's not there:) [17:28:35] Here's the core change I need reviewed: https://gerrit.wikimedia.org/r/#/c/73548/ [17:31:06] brion: i forgot to make the license name link to the license text - i have the url though - just need to hook it up. do you think i should just make the whole attribution box a link? [17:31:24] mhurd: yeah that sounds sensible [17:31:57] brion: then tapping elsewhere dismisses the attribution panel as it does now? [17:32:06] +1 [17:32:08] me like [17:32:25] yay [17:34:56] YuviPanda: thoughts on showing the image in-app instead of going to the gallery app? [17:35:05] MaxSem: do you have everything you need for next weeks cache flush? [17:35:07] the viewing isn't working for me, at least for photos i take with camera in-app [17:35:10] kaldari: thanks for the link :) [17:35:20] brion: yeah looking into camera fix [17:35:26] whee [17:35:31] jdlrobson, whaddaya mean? [17:35:48] brion: showing in app maybe but that is a fair amount of work if we want zoom [17:36:09] *nod* [17:36:28] MaxSem: peter youngermeister email [17:36:44] Ryan Lane has apparently been assigned [17:37:00] (to clear the cache in our next deployment window) [17:37:37] MaxSem: I was just wondering if anything else needs to be done - are you okay to schedule with ryan when you are likely to need it? [17:37:50] yes, I know about Ryan [17:38:28] will poke him later this week [17:41:28] jdlrobson, is Tomasz in the office? [18:00:15] brion: i'm wondering if tapping the attribution label could do more than just link to the license - maybe link to the wiki page for image too? [18:00:50] mhurd: mmmm indeed [18:00:56] not sure if giving a menu to choose is overkill or not [18:01:08] brion: maybe just pop up an action sheet? [18:01:23] yeah that'd be easy enough to od [18:01:29] ya [18:01:49] will try it real quick [18:22:11] New patchset: Kaldari; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [18:29:18] mhurd: exciting to see the licenses show up in the app [18:29:37] tfinc: yes! :) adding links now [18:29:39] YuviPanda: how is getting licenses into the android app going ? [18:29:53] tfinc: brion is still at it. [18:30:01] no new commits yet [18:30:01] woot [18:30:25] he's bitten off a bigger piece than just licenses, which I think is really fine - since on Android we don't show other people's images yet. [18:30:45] did someone say licenses? [18:31:43] I wanna see! [18:31:44] kaldari: we're stealing license info from UW :) [18:31:49] ah cool [18:31:51] kaldari: and brion is writing a wikitext parser :D [18:32:03] well just pulling out of the preprocessor tree [18:32:11] so it's already sorta parsed :) [18:32:37] only sortof! [18:32:44] it's exciting :) [18:32:57] the licensing choices in UW are a bit complicated. Hope you guys manage to simplify it a bit for mobile [18:33:27] we had to accomodate a shitload of edge cases for UW [18:33:57] but I imagine mobile uploads won't have to deal with as many, like PD-old, PD-art, NASA, etc. [18:34:57] kaldari: yeah, for putting up we just have BY, BY-SA and 0 [18:35:19] why did we support multiple licenses anyway? GFDL 1.2 ought be good enough for anyone ;) [18:35:24] kaldari: this is problem of specifying what licenses each are, which is apparently a legal requirement. Feels a bit weird to me since we don't do that anywhere [18:37:44] a lot of those license choices were added due to community demand, not legal requirements [18:38:10] brion: kaldari are you sure that we need to display the license name whenever we use it? and just linking to the file on commons isn't enough? [18:38:20] brion: kaldari because if that is the case than all images on enwiki are inviolation, no? [18:38:23] *in violation [18:38:32] yeah, this is a point of common discussion on wiki [18:38:45] there was an RFC about it last month [18:39:00] the consensus was that our current practice of linking is good enough [18:39:18] about there were some strong minority voices that disagreed [18:39:20] it's relevant metadata to what you can do with the image, so we ought to show it i think [18:39:33] sure sure, but I don't know if it is a *legal* requirement [18:40:34] i'll leave that to the legal eagles :) [18:42:20] ah [18:48:43] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73129 [19:02:25] New patchset: Jdlrobson; "Update to latest schema" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73331 [19:05:54] brion: just pushed commit to potdLicense branch adding action sheet when the pic of the day attribution label is tapped [19:06:32] \o/ i'll test [19:06:42] yay! [19:06:52] i just realized i didn't have any coffee yesterday [19:06:57] haha [19:07:17] https://en.wikipedia.org/wiki/Caffeine#Withdrawal [19:07:23] hahaha [19:07:56] https://en.wikipedia.org/wiki/Caffeine_withdrawal <- wow this is a ….. lame breakout article [19:08:52] brion: haha yeah not much additional info there [19:09:25] commons probably needs photos of groggy-looking people [19:11:44] mhurd: i got an entry with a 'null' license, possibly cached from before? http://upload.wikimedia.org/wikipedia/mediawiki/9/97/Commons_ios_screenshot_null_license.png [19:12:42] lemme go delete and reinstall, see if that helps [19:12:45] brion: ooh yeah. i think i know what's causing it [19:12:52] or should iw air :D [19:12:55] *i wait [19:14:31] MaxSem, did you deploy yesterday? [19:14:36] yurik, yep [19:16:27] brion: i thinks it's not copying the bundled image if it sees it's already been copied. but when updating the bundled images i actually want them to be overwritten. wouldn't affect users who didn't already have bundled pic of the day's - but after the next release users will have bundled images so the next release after that would have to have a one-time flag instructing the app to blast existing bundled images so the [19:16:28] updated ones would get copied [19:16:50] hmm, if they're updated files they should get copied…. shouldn't they? [19:16:53] hrmf [19:17:05] ya [19:17:08] i know old files don't get removed though [19:18:31] the bundled pic of the day files are named by the day they were the pic of the day - "POTD-2013-05-24.dict" etc [19:19:07] so if i see they're already present in the potd folder i don't re-copy them from the bundle [19:19:23] that will need to be thought about.... [19:19:33] ahhh i see [19:19:42] you're extracting them from the dicts into files? [19:20:26] the easiest fix is having a one-time flag telling the app the bundled images were updated and so need to be copied once regardless [19:21:00] i think [19:21:18] can you just check the file modified date? [19:21:32] that would be easier probably :) [19:21:36] :D [19:24:37] mhurd: i'd also recommend adding an 'unknown' label just in case something turns up outside the main list [19:24:41] better than '(null)' :D [19:24:50] brion: sounds good [19:26:17] tfinc: patching the null issue now [19:26:45] mhurd: what was it ? [19:28:05] tfinc: i updated the bundled pic of the day cache files, but it was only copying them over if they didn't already exist, which is good, unless you've made a change to them - i.e. added license info or some such [19:28:34] so the outdated files weren't' being overwritten [19:29:03] implementing brions suggestion for a fix now [19:29:23] may need to venture for coffee soon [19:32:20] New review: Yurik; "after some thinking, i finally (sorry for delay :)) figured what i don't like with this approach - r..." [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/71738 [19:45:22] New patchset: JGonera; "Fix position-fixed workaround for older devices in overlays" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74098 [19:47:24] mhurd: also https://github.com/montehurd/Commons-iOS/commit/ec1320a635265f74a1903e51079e3744eba14a89#commitcomment-3658028 [19:50:22] brion: good catch - i'll can re-arrange the content of the "getLicenses" method slightly to fix. sometimes the category license will say "cc-by-sa-3.0-migration" or some such which is why i made it match like that [19:50:33] oh ugh [19:50:37] funnnnnn [19:50:58] haha [19:53:00] New patchset: Jdlrobson; "Update to latest schema" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73331 [19:59:41] New review: Jdlrobson; "Max?" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/73018 [20:03:09] Online planning poker room: http://hat.jit.su/68197 [20:15:24] http://mobile-reportcard.wmflabs.org/ < kenanwang [20:25:04] jdlrobson: fyi, your response to amir makes no sense to me because the formatting seems to be... messed up? [20:25:22] YuviPanda: really? i'll take a look in a bit [20:25:34] jdlrobson: yeah, suddenly ordered lists! :) [20:26:52] mhurd: ok lemme test the update you committed [20:26:58] YuviPanda: \o/ [20:27:10] * jdlrobson loves liquid threads !!!!!! [20:27:24] brion: just about to push fix to the string match issue you found [20:27:25] jdlrobson: also I think there's a magic word you can use to turn off LQT, but it might be too late for that page. [20:27:33] that page is gone [20:27:38] ok i see licenses now, that's fixed :D [20:27:41] mhurd: awesome [20:27:44] brion: yay! [20:27:54] jdlrobson: yeah you can disable it but then you just have a blank page :D [20:28:30] jdlrobson: {{#useliquidthreads:0}} [20:29:48] brion: we should probably 'make it so' that RFC pages don't use LQT. They do indeed suck, I prefer talk pages. [20:30:04] i hate old talk pages [20:30:12] they remind me we have years of technical debt [20:30:18] and a user-hostile UI [20:30:27] I hate LQT, it reminds me of how much we abandon stuff [20:30:35] heh [20:30:39] well… things to fix ;) [20:30:42] :D [20:30:49] brion: we won't have flow for at least another 6 months, maybe a year [20:31:13] fixing discussion so humans can behave like humans to each other is only the most important thing we can do [20:31:23] no rush! [20:31:33] hehe :) [20:37:23] did we lose push announcements in channel? oh no it's cause the branch is on your forked repo [20:37:37] if there's actually a pull req i think we see it tho [20:37:40] hmm, and android ones go to -dev [20:37:43]