[00:25:14] hmm no brion [00:29:46] kaldari, the final design spec is attached to card 921 now [00:29:53] https://mingle.corp.wikimedia.org/projects/mobile/cards/921 [00:53:19] New patchset: Kaldari; "Story 920: Show uploads tutorial after following anon cta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73550 [00:53:19] New patchset: Kaldari; "Rename the horrible overlay class to something more meaningful" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74094 [00:53:19] New patchset: Kaldari; "Adding editing tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74309 [01:08:53] New review: Kaldari; "Need to abstract the tutorial image so that different tutorials can have different images (or no ima..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/73550 [01:09:24] New patchset: Kaldari; "Adding editing tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74309 [06:47:25] [Commons-iOS] montehurd opened pull request #95: Improve login page layout efficency and re-enabled landscape login. (master...landscapeLogin) http://git.io/meYa8A [07:05:43] [Commons-iOS] montehurd synchronize pull request #95: Improve login page layout efficency and re-enabled landscape login. (master...landscapeLogin) http://git.io/meYa8A [07:07:23] [Commons-iOS] montehurd synchronize pull request #95: Improve login page layout efficency and re-enabled landscape login. (master...landscapeLogin) http://git.io/meYa8A [16:05:02] New patchset: MaxSem; "Apply page blacklisting only when choosing a skin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74378 [16:58:00] Hey Maryana are we meeting today? [16:58:56] good morning, jcmish [16:59:05] howdy! :D [16:59:10] i don't have a whole lot for today. was gonna try to go through all the bugs in ready for signoff [16:59:17] anything scary i should know about? [17:00:34] Nope the only thing I was going to tell you about is the Windows bug… I tested it on my surface to make sure it's not an issue [17:00:53] but I think we have windows phones in the office? [17:06:37] YuviPanda: Will we have to change the design? Will it make things easier? [17:06:54] prtksxna: for the scroller? do you have any other ideas? [17:07:01] prtksxna: this is doable, it's just 3 hours instead of 3 mins [17:07:14] prtksxna: but there's the issue of multiple uploads that needs fixing [17:07:33] YuviPanda: Not yet…but if you think its not worth the effort, we could cook up something else, though that'll take some time too [17:07:45] prtksxna: yeah, I think this issue is fine, I can get that fixed [17:07:48] so don't worry about that. [17:08:00] k [17:13:24] jcmish, yeah, i believe brion has a windows phone - i'll try to check it out [17:13:44] Maryana: k cool [17:14:01] oooo, campaigns work going to get deployed soon :) [17:14:01] Maryana: jcmish: IIRC juliusz or jon has it [17:14:20] sweet, i will gank it from them [17:14:22] ah thanks brion sneaky devils [17:15:26] New patchset: Jdlrobson; "Story 920: Show uploads tutorial after following anon cta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73550 [17:18:46] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73550 [17:19:04] New patchset: Kaldari; "Rename the horrible overlay class to something more meaningful" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74094 [17:20:49] New patchset: Jdlrobson; "Story 921: Adding editing tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74309 [17:21:12] New review: Jdlrobson; "juju can you quickly check and merge?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73331 [17:22:04] New review: Jdlrobson; "Anyway we can add a phpunit test?" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/74378 [17:26:40] New review: MaxSem; "> Anyway we can add a phpunit test?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74378 [17:27:00] jdlrobson: Lots of merge conflicts on the rebase :( Might be a few minutes... [17:27:53] YuviPanda brion I've updated the icon [17:28:16] New review: Jdlrobson; "Sounds like that will be useful. I'm happy to merge without it - I just think this sort of thing wou..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74378 [17:29:10] YuviPanda: is the scrolling fix a separate branch? i see https://gerrit.wikimedia.org/r/#/c/74306/ but it doesn't look like it'll help with the other screen [17:29:20] brion: yeah, they're unrelated. [17:29:42] Jojo (yeah, that's you jdlrobson), I'll do code review as soon as I get to the office, which should be around 11 [17:29:43] brion: this one just scrolls you to the 'new' items in categories list when tehy show up [17:29:53] jgonera: ;-) [17:30:19] prtksxna: \o/, nice! [17:31:04] brion: can you check the new icons too? :) [17:32:55] YuviPanda: you want the new icons now or after another couple beta releases? [17:33:15] brion: I'd like to tack them on to beta11, which should be next week. [17:33:37] with a beta label on the icon? or just beta on the version? [17:33:56] brion: hmm, good question. taking 'beta' off the icon but still calling it beta might be confusing [17:34:16] brion: I don't have objections to calling beta11 '1.0' and removing beta label. [17:34:23] brion: since we don't have anything going in right now for that. [17:34:29] brion: it can be our 'stabilizing' cycle :) [17:34:57] brion: or just stick with beta in the name, and add a new icon. I don't mind us being in forever beta either. [17:35:03] heh [17:35:39] brion: as long as we're making quick releases, I'm fine. [17:35:41] * prtksxna is wondering how to add a beta label to that icon  [17:36:05] prtksxna: that'd be nice, but not sure how hard that'll be. [17:36:32] YuviPanda: Its not looking too nice in my brain [17:36:37] hehe :) [17:36:41] YuviPanda: But I guess its temporary… [17:36:52] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74063 [17:36:57] brion: prtksxna I don't mind removing the beta label from the icon. [17:37:05] and keeping it just in the version number. [17:37:14] \o/ ok let's do that for now [17:37:28] brion: \o/ [17:37:30] damn i lost the tab [17:37:33] * brion finds the link again [17:38:05] mergifieeeed [17:38:06] brion: we should try to move off a '1.0' type versioning scheme to something that is more... temperoary. Don't want to keep thinking 'we can make a huge release once a month' [17:38:31] 1.1/1.2/1.3/.….1.99999? [17:38:32] brion: \o/ can you make screenshots? [17:38:36] brion: hehe :D [17:38:43] brion: perhaps just call it 1, and next time... call it [17:38:44] 2 [17:38:48] integers4lyf [17:39:12] 127.0.0.1 [17:39:25] My first ever contribution :D [17:39:28] * YuviPanda makes brion a GUI to track Version Numbers in Visual Basic [17:39:36] prtksxna: welcome to open source development :) [17:39:40] * YuviPanda says some other cheesy lines. [17:39:45] *design [17:39:51] :P [17:39:56] :D [17:42:09] New patchset: Jdlrobson; "Bug 51480: Add placeholder text to textarea" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74392 [17:44:12] \o/ whee [17:45:50] brion: also merge the categories tiny patch? not the holo one [17:49:07] ah yeah [17:50:56] New patchset: Jdlrobson; "Bug 51550: Always set padding right" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74395 [17:52:18] http://www.bbc.co.uk/news/technology-23354613 [17:52:29] Wikipedia edit wars revealed! [17:53:12] shocked [17:53:16] i am SHOCKED that there are edit wars [17:54:03] YuviPanda: should I poke more at those holo bits or leave that to you next week and get other stuff ready in the meantime? [17:54:05] * Maryana clutches her pearls [17:54:16] * brion gets the smelling salts [17:54:23] :D [17:57:01] kenanwang, you should be getting an email from usertesting.com sometime nowish [17:57:49] poke around - we use this thing all the time for remote user testing [17:58:00] Maryana: got it [17:58:44] sweet :) i need to run a test on editing in beta. want to set one up together at some point today? [18:01:11] New patchset: Kaldari; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [18:02:03] brion: there's office hours on -office about the new multimedia stuff, thought you might be interested [18:02:09] brion: heh, you're already there :) [18:02:13] :D [18:02:18] kaldari: i'm ready in r33 whenever you are [18:10:30] New patchset: Jdlrobson; "Bug 51627: Fix return to link in Cta drawers to include namespace" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74408 [18:29:19] tfinc: hangout troubles, be tehre in a minute [18:31:09] New review: Jdlrobson; "Few issues with this - fixing up myself and I'll resubmit.." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/73555 [18:32:32] tfinc: you got bumped [18:32:45] tfinc: I still can't hear you [18:32:47] YuviPanda: weird. max was able to hear me just fine [18:32:51] and i can hear you [18:32:55] are your speakers working? [18:32:56] tfinc: my audio works fine, since I can hear other things [18:32:58] tfinc: yeah [18:33:08] tfinc: just double checked. yes [18:33:19] tfinc: let me kill and restart [18:39:13] New patchset: Kaldari; "Story 921: Adding editing tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74309 [18:48:36] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74408 [18:59:46] brion: couple pull reqs for you :) [18:59:52] woo [19:00:39] flicker fix looks simple [19:00:47] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/sMqGqQ [19:00:47] Commons-iOS/master 7c25006 Monte Hurd: Fixed annoying flicker of pic of day attribution box on iPad.... [19:00:47] Commons-iOS/master 944bdaf Brion Vibber: Merge pull request #94 from montehurd/potdLicense... [19:00:49] ya, and the latter one was kind of accidental, but i thought you'd like it [19:00:54] :D [19:00:59] yay! [19:03:31] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74392 [19:04:51] mhurd: the animation on rotate looks awesome [19:05:14] :) [19:05:52] lemme check on iPad sim [19:06:35] New review: Kaldari; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74378 [19:07:01] looks good let's merge these [19:07:25] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/x05dkA [19:07:25] Commons-iOS/master 5e5ce37 Monte Hurd: Improve login page layout efficency and re-enabled landscape login.... [19:07:25] Commons-iOS/master 49b7c44 Brion Vibber: Merge pull request #95 from montehurd/landscapeLogin... [19:08:06] brion: awesome! [19:08:30] mhurd: ping? [19:08:39] YuviPanda: hey yuvi! [19:09:00] mhurd: brion want to setup an etherpad and list things to talk about on the design meeting? I think that'll make things easier for everyone involved. [19:09:11] ya for sure [19:09:18] sounds wise :D [19:09:19] mhurd: you gonna be in tomorrow or remote? [19:09:33] let me start one up [19:09:51] brion: mhurd http://etherpad.wmflabs.org/pad/p/wm-mobile-design-jul [19:10:00] brion: i'm going to try my best to be there in person [19:10:11] ok don't push yourself if you feel sick though! [19:10:30] will do [19:10:32] mhurd: +1 to brion, our remote participation stuff is fairly good :) [19:10:39] i'll try to be there, but then will probably have to run off to do house crap after [19:10:50] YuviPanda: :) [19:10:56] starting to panic, we have two weeks to move :) [19:11:09] hehe, nomad4lyf! :D [19:11:30] brion: 2weeks?! [19:11:57] yeah the old tenant took longer than intended to get out, and the landlord foolishly promised to rent out our current apartment…. sooner than he really should have [19:12:01] so…. MADNESS [19:12:12] oh god [19:12:25] we're trying to get new flooring in and the walls repainted and some new appliances [19:12:36] so…. yeah. [19:14:13] brion: mhurd so... what do we put on the etherpad? :D [19:14:36] YuviPanda: hmmm [19:17:01] mhurd: can you name yourself on the etherpad so it is easier to follow? [19:17:11] oops! [19:17:41] ty [19:17:45] hmm, I no longer have a cat [19:19:00] jcmish, something funky is going on with editing in beta labs [19:19:34] New patchset: Jdlrobson; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [19:19:36] i was testing out on android, and it won't let me use the edit button at all, won't even give me toast [19:19:50] New review: Jdlrobson; "Juliusz I'll let you take a 3rd pass over this..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/73555 [19:23:15] New patchset: Jdlrobson; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [19:23:33] New review: Jdlrobson; "jgonera / juju I'll let you take a 3rd pass over this..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/73555 [19:28:49] New patchset: Jdlrobson; "Rename the horrible overlay class to something more meaningful" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74094 [19:29:34] dfoy, do you need me in nokya's meeting? [19:31:17] New patchset: Jdlrobson; "Rename the horrible overlay class to something more meaningful" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74094 [19:33:15] New patchset: Jdlrobson; "Rename the horrible overlay class to something more meaningful" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74094 [19:34:16] bbiab [19:34:35] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74094 [19:35:31] New patchset: Jdlrobson; "Do not leave a gap on stub pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74427 [19:41:12] prtksxna: sorry about the pull request spam, just a misbehaving bot on my part :) [19:44:51] YuviPanda Internet too slow to receive them anyway :P [19:54:55] New review: MaxSem; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74378 [19:59:43] yuri_k: no, that's ok [20:03:41] dfoy, i'm already connected, did you connect ok? [20:05:38] hmm Maryana any other devices or just that one? [20:06:02] i didn't try w/others, but android was def not working [20:06:50] [Commons-iOS] montehurd opened pull request #96: Reorganized LoginViewController.m with relevant pragma mark sections. (master...loginPragma) http://git.io/CEOMjQ [20:08:43] ah bad juju on betalabs right now [20:08:57] I'm getting errors just trying to pull up versions let me put a ticket in [20:09:29] New review: Yuvipanda; "I have no idea what is going on but just wanted to say 'Juju'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [20:10:19] New review: Kaldari; "Looks good to me. I'll let Jon merge since I'm not sure how badly he wants a Selenium test for this :)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/74378 [20:15:09] http://articles.washingtonpost.com/2013-06-30/opinions/40292503_1_internet-richard-bejtlich-hackers < hahah. guys we're doing it wrong and need to turn off the internet and wikipedia... [20:18:34] New patchset: Jdlrobson; "Editing: Make sure lists are styled in preview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73987 [20:19:08] jgonera: kaldari can we have a big frontend code review before bowling - i'd like to get most things wrapped up today if possible [20:22:07] New patchset: Jdlrobson; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [20:22:57] New review: Jdlrobson; "Slight adjustment to address FIXME in the lead photo uploader" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/73555 [20:23:10] Maryana: it's actually busted. jdlrobson jgonera on beta labs editing does not work … I checked and the commits were up to date as of 18 mins ago [20:23:13] YuviPanda: juju is what the design twins call jgonera [20:23:23] ... 'design twins'? [20:23:30] Maryana: looking [20:23:38] YuviPanda: May and Vibha - that's their nickname [20:23:42] ah :) [20:23:52] WHY WAS THAT NOT ON THE MAILING LIST!!! [20:23:53] :P [20:24:01] New patchset: JGonera; "Update to latest schema" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73331 [20:24:07] jdlrobson: thoughts on splitting that RFC? [20:24:13] jgonera: ^ [20:24:18] ha jdlrobson and jgonera this is how I use juju so that makes me laugh http://en.wikipedia.org/wiki/Juju [20:24:31] YuviPanda: i think it's a good idea = but first we need to promote all our editing stuff and new nav - top most priority [20:24:43] YuviPanda: i'll send a nickname mail later today [20:25:05] jcmish: oh wow, interesting! Interestingly and unrelated, it is a fairly common dog name around here :) [20:25:08] Maryana: yeh.. something weird going on on beta labs.. [20:25:14] YuviPanda, yeah, we can split it [20:25:25] ha! [20:25:26] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73331 [20:25:33] yeah, will also keep the negativity down, I'd think. [20:25:34] really a dog name? [20:25:35] haha [20:25:46] MaxSem… GET http://bits.beta.wmflabs.org/static-master/extensions/MobileFrontend/javascripts/modules/editor/editor.js 404 (Not Found) [20:25:48] jgonera: yeah. I know at least 6 with that name. [20:26:08] Maryana: for some reason editor js is not loading... [20:26:38] http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=ext.eventLogging%2CnavigationTiming%7Cjquery.hidpi%2Cjson%7Cmediawiki.cldr%2Chidpi%2CjqueryMsg%2Clanguage%7Cmediawiki.language.data%2Cinit%7Cmediawiki.libs.pluralruleparser%7Cmobile.beta%2Chead%2Cstable%2Cstartup%7Cmobile.beta.common%2Cplumbing%7Cmobile.editing.schema%7Cmobile.pagelist.styles%7Cmobile.stable.common%2Cplumbing%2Cstyles%7Cmobile.toas [20:26:38] yles%7Cmobile.uploads.schema%7Cmobile.watchlist.schema%7Cschema.Edit%2CNavigationTiming&skin=vector&version=20130718T201330Z&* < sorry [20:27:03] jcmish Maryana looks like something went wrong on beta labs again [20:27:20] (these files exist) [20:27:21] hmm is it a config jdlrobson? [20:27:31] should I ask for them to bounce the server? [20:28:00] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73987 [20:28:26] jcmish: i'm not too sure.. [20:28:46] k I'll log a ticket [20:28:55] and give the info above and test case [20:29:34] New patchset: JGonera; "Do not leave a gap on stub pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74427 [20:29:42] MaxSem: ^^ any ideas on what I might tell the ops folks to look for on beta labs to help us? [20:32:48] New patchset: Jdlrobson; "Regression: Center login button in drawer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74516 [20:33:55] New patchset: JGonera; "Remove echo specific css to reflect html changes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/71709 [20:34:23] New review: JGonera; "Not dependent on the Echo patchset, this styling was not applied anyway." [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/71709 [20:36:39] jcmish, looks like some stuff hasn't been updated [20:37:28] ah so maybe the script didn't finish in the middle of updating [20:37:44] New patchset: Jdlrobson; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [20:37:44] no,it's still that way [20:37:44] New patchset: Jdlrobson; "Add event binding in initialize for PhotoUploaderPageActionButton" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74517 [20:37:49] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73879 [20:38:15] New review: JGonera; "Padding probably shouldn't be applied (causing headings to wrap) if someone is not logged in (and th..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/74395 [20:39:01] New review: Jdlrobson; "I updated the bug with a comment - let's see what happens there." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74395 [20:39:54] kaldari: can you review https://gerrit.wikimedia.org/r/#/c/74070/ ? [20:40:06] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74516 [20:40:23] jdlrobson: yes [20:40:29] whhhy thank you :) [20:49:59] New patchset: Jdlrobson; "Hygiene: Remove dead css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74519 [20:50:02] New patchset: Jdlrobson; "Hide the user button on the login screen" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74520 [20:52:11] [Commons-iOS] montehurd opened pull request #97: Fix another annoying flicker - rotating details page made image jump. (master...imageRotate) http://git.io/WIVQwg [20:58:43] [Commons-iOS] montehurd synchronize pull request #97: Fix another annoying flicker - rotating details page made image jump. (master...imageRotate) http://git.io/WIVQwg [20:58:45] New review: Kaldari; "I can now watch them, but they still don't show up under the 'All' tab (default view) of the watchlist." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/74070 [21:10:52] New patchset: Jdlrobson; "Add event binding in initialize for PhotoUploaderPageActionButton" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74517 [21:10:52] New patchset: Jdlrobson; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [21:10:52] New patchset: Jdlrobson; "Enable anonymous photo upload cta by default" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74525 [21:10:52] New patchset: Jdlrobson; "Story 920: Make upload tutorial screen have an upload and cancel button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74526 [21:15:38] tfinc: Simpsons arcade game is awesome. I totally forgot about it, but it's great. [21:17:26] StevenW: having just gone to an arcade game convention. its fresh in my head [21:23:34] New review: Jdlrobson; "This is by design - the all view only shows main namespace (see https://bugzilla.wikimedia.org/show_..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74070 [21:32:00] New patchset: Jdlrobson; "Story 921: Adding editing tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74309 [21:32:00] New patchset: Jdlrobson; "Story 920: Make upload tutorial screen have an upload and cancel button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74526 [21:34:19] New patchset: Jdlrobson; "Add event binding in initialize for PhotoUploaderPageActionButton" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74517 [21:34:19] New patchset: Jdlrobson; "Story 921: Adding editing tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74309 [21:34:20] New patchset: Jdlrobson; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [21:34:20] New patchset: Jdlrobson; "Enable anonymous photo upload cta by default" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74525 [21:34:20] New patchset: Jdlrobson; "Story 920: Make upload tutorial screen have an upload and cancel button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74526 [21:34:56] New review: Jdlrobson; "Made a few adjustments to make it more similar to the photo upload tutorial." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/74309 [21:35:21] MaxSem: did you want to add a test to https://gerrit.wikimedia.org/r/#/c/74378/? [21:36:43] (otherwise i'll merge) [21:41:50] jdlrobson, go ahead. the test for isBlacklistedPage() is possible, but pointless as it's just too obvious [21:42:16] MaxSem: does this complete 830 ? [21:43:40] deploy, test, then enable redirection - in this order, otherwise there might be infinite redirection loops [21:44:24] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74378 [21:45:00] thanks:) [21:47:41] mhurd: does http://etherpad.wmflabs.org/pad/p/wm-mobile-design-jul look complete enough? [21:56:39] New patchset: Jdlrobson; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [22:03:39] * YuviPanda prods mhurd [22:09:46] New patchset: Jdlrobson; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [22:22:51] New patchset: JGonera; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [22:23:56] New patchset: JGonera; "Stories 902, 903: Promoting pageactions (including editing) to stable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [22:32:04] YuviPanda: is good :) [22:32:11] mhurd: add it to the invite? :) [22:32:18] k [22:35:03] New patchset: JGonera; "Enable anonymous photo upload cta by default" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74525 [22:35:49] New patchset: JGonera; "Add event binding in initialize for PhotoUploaderPageActionButton" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74517 [22:37:23] YuviPanda: added [22:39:57] YuviPanda: how are you still awake ? [22:40:02] mhurd: no idea. [22:40:13] err [22:40:15] tfinc: no idea. [22:40:19] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74520 [22:40:19] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74519 [22:40:29] tfinc: Done with Android stuff for the day, playing with some toollabs stuff [23:00:54] congrats Maryana [23:01:05] thanks :) [23:02:10] Maryana: StevenW congrats :) [23:02:42] thank you too!